[jira] [Commented] (GEODE-7768) Code clean up, remove redundant null check in BootstrappingFunction

2020-02-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044019#comment-17044019
 ] 

ASF subversion and git services commented on GEODE-7768:


Commit bf3e2801e96b9fc15954d02e5a762ba89f3e4891 in geode's branch 
refs/heads/feature/GEODE-7109 from mkevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bf3e280 ]

GEODE-7768: remove redundant null checks (#4701)



> Code clean up, remove redundant null check in BootstrappingFunction
> ---
>
> Key: GEODE-7768
> URL: https://issues.apache.org/jira/browse/GEODE-7768
> Project: Geode
>  Issue Type: Task
>Reporter: Jason Huynh
>Assignee: Mario Kevo
>Priority: Major
>  Labels: beginner, newb, starter
> Fix For: 1.13.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The null check in the equals method of BootstrappingFunction can be safely 
> removed.  The instanceof check will return false if the object is null.
> See here:  
> [https://github.com/apache/geode/blob/cee84bbc53c707b2ca13ca664fb3087fec1c71ed/extensions/geode-modules/src/main/java/org/apache/geode/modules/util/BootstrappingFunction.java#L194]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7768) Code clean up, remove redundant null check in BootstrappingFunction

2020-02-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042252#comment-17042252
 ] 

ASF subversion and git services commented on GEODE-7768:


Commit bf3e2801e96b9fc15954d02e5a762ba89f3e4891 in geode's branch 
refs/heads/mass-test-run from mkevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bf3e280 ]

GEODE-7768: remove redundant null checks (#4701)



> Code clean up, remove redundant null check in BootstrappingFunction
> ---
>
> Key: GEODE-7768
> URL: https://issues.apache.org/jira/browse/GEODE-7768
> Project: Geode
>  Issue Type: Task
>Reporter: Jason Huynh
>Assignee: Mario Kevo
>Priority: Major
>  Labels: beginner, newb, starter
> Fix For: 1.13.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The null check in the equals method of BootstrappingFunction can be safely 
> removed.  The instanceof check will return false if the object is null.
> See here:  
> [https://github.com/apache/geode/blob/cee84bbc53c707b2ca13ca664fb3087fec1c71ed/extensions/geode-modules/src/main/java/org/apache/geode/modules/util/BootstrappingFunction.java#L194]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7768) Code clean up, remove redundant null check in BootstrappingFunction

2020-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039765#comment-17039765
 ] 

ASF subversion and git services commented on GEODE-7768:


Commit bf3e2801e96b9fc15954d02e5a762ba89f3e4891 in geode's branch 
refs/heads/develop from mkevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bf3e280 ]

GEODE-7768: remove redundant null checks (#4701)



> Code clean up, remove redundant null check in BootstrappingFunction
> ---
>
> Key: GEODE-7768
> URL: https://issues.apache.org/jira/browse/GEODE-7768
> Project: Geode
>  Issue Type: Task
>Reporter: Jason Huynh
>Assignee: Mario Kevo
>Priority: Major
>  Labels: beginner, newb, starter
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The null check in the equals method of BootstrappingFunction can be safely 
> removed.  The instanceof check will return false if the object is null.
> See here:  
> [https://github.com/apache/geode/blob/cee84bbc53c707b2ca13ca664fb3087fec1c71ed/extensions/geode-modules/src/main/java/org/apache/geode/modules/util/BootstrappingFunction.java#L194]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)