[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271860#comment-17271860 ] ASF GitHub Bot commented on GEODE-8207: --- pdxcodemonkey merged pull request #729: URL: https://github.com/apache/geode-native/pull/729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271585#comment-17271585 ] ASF GitHub Bot commented on GEODE-8207: --- pdxcodemonkey merged pull request #729: URL: https://github.com/apache/geode-native/pull/729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270512#comment-17270512 ] ASF GitHub Bot commented on GEODE-8207: --- moleske opened a new pull request #729: URL: https://github.com/apache/geode-native/pull/729 Since https://github.com/apache/geode-native/pull/608 got rid of this warning on clang, we can get rid of it on windows. Though let me know if I really should make a new jira instead of reusing the old one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Fix For: 1.14.0 > > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129764#comment-17129764 ] ASF subversion and git services commented on GEODE-8207: Commit f9926e0a5d6fa637a4c175fa9ea517f384cb in geode-native's branch refs/heads/develop from M. Oleske [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=f99 ] GEODE-8207: Enfore No Unknown Pragmas as Error (#608) > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129763#comment-17129763 ] ASF GitHub Bot commented on GEODE-8207: --- pdxcodemonkey merged pull request #608: URL: https://github.com/apache/geode-native/pull/608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129487#comment-17129487 ] ASF GitHub Bot commented on GEODE-8207: --- pivotal-jbarrett commented on pull request #608: URL: https://github.com/apache/geode-native/pull/608#issuecomment-640794162 > I switched to definitions in config.h I forgot that those were unprefixed definitions in there. We should fix that some day so they don't collide with others. > but also spent a little time trying to figure out the correct way in cmake to detect those pragmas. I didn't succeed in the latter, kept ending up in docs for checking compiler flags. The closest I hit to was `get_target_property` but couldn't figure out what target or property I'd really be looking for. If you have thoughts on detection, I can take another try at using cmake to determine if those pragmas exist (as long as folks don't mind waiting a week in between my attempts based on my current schedule) I believe you want to use `check_cxx_source_compiles`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127184#comment-17127184 ] ASF GitHub Bot commented on GEODE-8207: --- moleske commented on pull request #608: URL: https://github.com/apache/geode-native/pull/608#issuecomment-639911919 @pivotal-jbarrett I switched to definitions in config.h, but also spent a little time trying to figure out the correct way in cmake to detect those pragmas. I didn't succeed in the latter, kept ending up in docs for checking compiler flags. The closest I hit to was `get_target_property` but couldn't figure out what target or property I'd really be looking for. If you have thoughts on detection, I can take another try at using cmake to determine if those pragmas exist (as long as folks don't mind waiting a week in between my attempts based on my current schedule) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120341#comment-17120341 ] ASF GitHub Bot commented on GEODE-8207: --- moleske opened a new pull request #608: URL: https://github.com/apache/geode-native/pull/608 I just used `__sun` and `_MSC_VER` as the check. Worked for Windows, Mac, and Kubuntu 20.04. Don't have a Sun based setup to test that one. I checked the box for "Allow edits by maintainers" so just push up anything you might discover. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
