[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127153#comment-17127153 ] ASF subversion and git services commented on GEODE-8211: Commit 77d4bf8afd7a1c715a84b03dadda6673bc36f3f4 in geode's branch refs/heads/mass-test-run from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=77d4bf8 ] GEODE-8211: Fix flaky test by increasing client timeout (#5213) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127167#comment-17127167 ] ASF subversion and git services commented on GEODE-8211: Commit 77d4bf8afd7a1c715a84b03dadda6673bc36f3f4 in geode's branch refs/heads/mass-test-run from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=77d4bf8 ] GEODE-8211: Fix flaky test by increasing client timeout (#5213) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126105#comment-17126105 ] ASF subversion and git services commented on GEODE-8211: Commit 77d4bf8afd7a1c715a84b03dadda6673bc36f3f4 in geode's branch refs/heads/develop from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=77d4bf8 ] GEODE-8211: Fix flaky test by increasing client timeout (#5213) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126103#comment-17126103 ] ASF GitHub Bot commented on GEODE-8211: --- jdeppe-pivotal merged pull request #5213: URL: https://github.com/apache/geode/pull/5213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126012#comment-17126012 ] ASF GitHub Bot commented on GEODE-8211: --- jdeppe-pivotal opened a new pull request #5213: URL: https://github.com/apache/geode/pull/5213 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125327#comment-17125327 ] ASF subversion and git services commented on GEODE-8211: Commit 1d71714f45ceabaea93482bbe161dc34e7f8db22 in geode's branch refs/heads/develop from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d71714 ] GEODE-8211: ignore flaky test (#5210) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125302#comment-17125302 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal opened a new pull request #5210: URL: https://github.com/apache/geode/pull/5210 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125279#comment-17125279 ] ASF subversion and git services commented on GEODE-8211: Commit 62e7c54c05a1ee025596d6c36da262e2bd35bb8e in geode's branch refs/heads/develop from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=62e7c54 ] GEODE-8211: fix flaky shutdown test (#5209) The problem was that the instance variable being set by one thread and read by another was not volatile. > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125278#comment-17125278 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal merged pull request #5209: URL: https://github.com/apache/geode/pull/5209 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125270#comment-17125270
]
ASF GitHub Bot commented on GEODE-8211:
---
dschneider-pivotal commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434814852
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##
@@ -61,11 +61,7 @@ public void
shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a
JedisDataException when the command
// returns an error.
-try {
- jedis.shutdown();
-} catch (JedisConnectionException ignore) {
Review comment:
Also, this fix was already reviewed on another branch. I just wanted it
to be isolated on its own PR instead of being part of another PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Xiaojian Zhou
>Assignee: Darrel Schneider
>Priority: Major
> Labels: flaky
> Fix For: 1.14.0
>
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125269#comment-17125269
]
ASF GitHub Bot commented on GEODE-8211:
---
dschneider-pivotal commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434814571
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##
@@ -61,11 +61,7 @@ public void
shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a
JedisDataException when the command
// returns an error.
-try {
- jedis.shutdown();
-} catch (JedisConnectionException ignore) {
Review comment:
It was throwing this before, intermittently, because the server was
actually shutting down intermittently. The point of the test was for shutdown
to be a NOOP. But the flag the test sets to make it a noop did not work because
the thread reading the flag is in another thread so it sometimes did not see
that the command was unsupported. So now with the "volatile" on the boolean, it
will always see the change this test makes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Xiaojian Zhou
>Assignee: Darrel Schneider
>Priority: Major
> Labels: flaky
> Fix For: 1.14.0
>
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125267#comment-17125267
]
ASF GitHub Bot commented on GEODE-8211:
---
jchen21 commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434811874
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##
@@ -61,11 +61,7 @@ public void
shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a
JedisDataException when the command
// returns an error.
-try {
- jedis.shutdown();
-} catch (JedisConnectionException ignore) {
Review comment:
Will `jedis.shutdown()` no longer throw `JedisConnectionException`? Or
if `JedisConnectionException` is thrown, we just don't want to catch it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Xiaojian Zhou
>Assignee: Darrel Schneider
>Priority: Major
> Labels: flaky
> Fix For: 1.14.0
>
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125258#comment-17125258 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal opened a new pull request #5209: URL: https://github.com/apache/geode/pull/5209 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125216#comment-17125216 ] Jianxia Chen commented on GEODE-8211: - Another failure: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK11/builds/223#A I have to reopen the issue. > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124051#comment-17124051
]
Mark Hanson commented on GEODE-8211:
Another failure
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/221#A]
{noformat}
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0097/test-results/integrationTest/1591114323/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0097/test-artifacts/1591114323/integrationtestfiles-OpenJDK8-1.14.0-build.0097.tgz
{noformat}
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Xiaojian Zhou
>Assignee: Darrel Schneider
>Priority: Major
> Labels: flaky
> Fix For: 1.14.0
>
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121442#comment-17121442 ] ASF subversion and git services commented on GEODE-8211: Commit 0fdcd5b05be49fe450771d249537b0c3f04df462 in geode's branch refs/heads/develop from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0fdcd5b ] GEODE-8211: fix flaky ShutdownIntegrationTest (#5193) test now creates a new client connection after calling the disabled shutdown > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121441#comment-17121441 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal merged pull request #5193: URL: https://github.com/apache/geode/pull/5193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121414#comment-17121414
]
ASF GitHub Bot commented on GEODE-8211:
---
gesterzhou commented on a change in pull request #5193:
URL: https://github.com/apache/geode/pull/5193#discussion_r433551229
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##
@@ -61,7 +61,11 @@ public void
shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a
JedisDataException when the command
// returns an error.
-jedis.shutdown();
+try {
+ jedis.shutdown();
+} catch (JedisConnectionException ignore) {
+ // Sometimes it throws sometimes it does not.
+}
Review comment:
You might need to fix line 70 too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Xiaojian Zhou
>Assignee: Darrel Schneider
>Priority: Major
> Labels: flaky
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121407#comment-17121407 ] ASF GitHub Bot commented on GEODE-8211: --- dschneider-pivotal opened a new pull request #5193: URL: https://github.com/apache/geode/pull/5193 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
