[jira] [Commented] (GEODE-8226) redis publish should work even if some members of the cluster are not redis servers
[
https://issues.apache.org/jira/browse/GEODE-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129542#comment-17129542
]
ASF GitHub Bot commented on GEODE-8226:
---
dschneider-pivotal merged pull request #5215:
URL: https://github.com/apache/geode/pull/5215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> redis publish should work even if some members of the cluster are not redis
> servers
> ---
>
> Key: GEODE-8226
> URL: https://issues.apache.org/jira/browse/GEODE-8226
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Fix For: 1.14.0
>
>
> Steps to reproduce
> # Start a locator and server with the redis API's running
> {{gfsh start locator
> gfsh start server --name=server1 --locators=localhost[10334] --server-port=0
> --redis-port=6379 --redis-bind-address=127.0.0.1}}
> # Open 2 terminals, and run Redis-CLI
> # On one terminal run the SUBSCRIBE command
> # On the other terminal PUBLISH to the channel that the first terminal
> SUBSCRIBED (in step 3).
> ###This should work correctly.
> # Add another server that does NOT have Redis started
> {{gfsh start server --name=server1 --locators=localhost[10334]
> --server-port=0 --redis-port=6379 --redis-bind-address=127.0.0.1}}
> # Repeat Step 4
> Notice that the SUBSCRIBER received multiple messages, and a server error was
> thrown from the PUBLISHER.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8226) redis publish should work even if some members of the cluster are not redis servers
[
https://issues.apache.org/jira/browse/GEODE-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128478#comment-17128478
]
ASF subversion and git services commented on GEODE-8226:
Commit e023b547dd48424cf76567f696d81965e152b5ec in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e023b54 ]
GEODE-8226: change publish to work with non-redis servers present (#5215)
Changed PubSubDUnitTest to have an additional non-redis server.
This caused multiple tests in it to fail.
Changed the publish code that uses the FunctionService
to only execute the function on members that have the redis data region.
The tests started passing.
> redis publish should work even if some members of the cluster are not redis
> servers
> ---
>
> Key: GEODE-8226
> URL: https://issues.apache.org/jira/browse/GEODE-8226
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>
> Steps to reproduce
> # Start a locator and server with the redis API's running
> {{gfsh start locator
> gfsh start server --name=server1 --locators=localhost[10334] --server-port=0
> --redis-port=6379 --redis-bind-address=127.0.0.1}}
> # Open 2 terminals, and run Redis-CLI
> # On one terminal run the SUBSCRIBE command
> # On the other terminal PUBLISH to the channel that the first terminal
> SUBSCRIBED (in step 3).
> ###This should work correctly.
> # Add another server that does NOT have Redis started
> {{gfsh start server --name=server1 --locators=localhost[10334]
> --server-port=0 --redis-port=6379 --redis-bind-address=127.0.0.1}}
> # Repeat Step 4
> Notice that the SUBSCRIBER received multiple messages, and a server error was
> thrown from the PUBLISHER.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8226) redis publish should work even if some members of the cluster are not redis servers
[
https://issues.apache.org/jira/browse/GEODE-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126219#comment-17126219
]
ASF GitHub Bot commented on GEODE-8226:
---
dschneider-pivotal opened a new pull request #5215:
URL: https://github.com/apache/geode/pull/5215
Changed PubSubDUnitTest to have an additional non-redis server.
This caused multiple tests in it to fail.
Changed the publish code that uses the FunctionService
to only execute the function on members that have the redis data region.
The tests started passing.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> redis publish should work even if some members of the cluster are not redis
> servers
> ---
>
> Key: GEODE-8226
> URL: https://issues.apache.org/jira/browse/GEODE-8226
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>
> Steps to reproduce
> # Start a locator and server with the redis API's running
> {{gfsh start locator
> gfsh start server --name=server1 --locators=localhost[10334] --server-port=0
> --redis-port=6379 --redis-bind-address=127.0.0.1}}
> # Open 2 terminals, and run Redis-CLI
> # On one terminal run the SUBSCRIBE command
> # On the other terminal PUBLISH to the channel that the first terminal
> SUBSCRIBED (in step 3).
> ###This should work correctly.
> # Add another server that does NOT have Redis started
> {{gfsh start server --name=server1 --locators=localhost[10334]
> --server-port=0 --redis-port=6379 --redis-bind-address=127.0.0.1}}
> # Repeat Step 4
> Notice that the SUBSCRIBER received multiple messages, and a server error was
> thrown from the PUBLISHER.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
