[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130886#comment-17130886 ] ASF subversion and git services commented on GEODE-8230: Commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f in geode's branch refs/heads/feature/GEODE-8067 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f65ea45 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130876#comment-17130876 ] ASF subversion and git services commented on GEODE-8230: Commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f in geode's branch refs/heads/feature/GEODE-8067 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f65ea45 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130865#comment-17130865 ] ASF subversion and git services commented on GEODE-8230: Commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f in geode's branch refs/heads/feature/GEODE-8067 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f65ea45 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130854#comment-17130854 ] ASF subversion and git services commented on GEODE-8230: Commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f in geode's branch refs/heads/feature/GEODE-8067 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f65ea45 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130841#comment-17130841 ] ASF subversion and git services commented on GEODE-8230: Commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f in geode's branch refs/heads/feature/GEODE-8067 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f65ea45 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129889#comment-17129889 ] ASF subversion and git services commented on GEODE-8230: Commit 944d17648e072d22ab29950bba191071bfe6c543 in geode's branch refs/heads/support/1.12 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=944d176 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab (cherry picked from commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f) > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129880#comment-17129880 ] ASF subversion and git services commented on GEODE-8230: Commit f65ea452443bcd2d0dac6ef1d2d958b0cb02936f in geode's branch refs/heads/develop from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f65ea45 ] GEODE-8230: run benchmarks in parallel with other CI jobs (#5217) * run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129879#comment-17129879 ] ASF GitHub Bot commented on GEODE-8230: --- onichols-pivotal merged pull request #5217: URL: https://github.com/apache/geode/pull/5217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127179#comment-17127179 ] ASF GitHub Bot commented on GEODE-8230: --- onichols-pivotal opened a new pull request #5217: URL: https://github.com/apache/geode/pull/5217 before, we ran Build, then all Test jobs in parallel (which takes ~5 hours), then all Benchmark jobs (which takes ~5 hours). Presumably the benchmarks were run after all tests, on the premise that benchmarks are meaningless if the code is not correct. However, required PR checks now prevent incorrect code from getting into develop in the first place, and the remaining occasional failures are flaky, so it's rather arbitrary to gate benchmarks on a lottery. However, faster feedback has clear benefits, hence this PR to cut our CI pipeline from 10 hours to 5 hours. Also eliminates redundant jobs (ApiCheck and UnitTest are deterministic and already have required JDK11 flavors in the PR pipeline, so JDK8 flavor only is more than sufficient in the develop pipeline) Also decreases benchmarks max_in_flight from 3 to 2, since now that we have support branches, we don't want to max our quota just from develop. Some sort of global "pool" resource might be a more elegant way to manage this resource quota across pipelines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
