[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432990#comment-17432990
 ] 

ASF subversion and git services commented on GEODE-9553:


Commit 91ee46a3781858956f0b6bcaa835ba4e0ec9b991 in geode-native's branch 
refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=91ee46a ]

GEODE-9553: remove all remaining printf variations from C++ code (#885)



> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> tests\cpp\testobject\InvalidPdxUsage.cpp
> tests\cpp\testobject\NestedPdxObject.cpp
> tests\cpp\testobject\PdxClassV1.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432987#comment-17432987
 ] 

ASF GitHub Bot commented on GEODE-9553:
---

pdxcodemonkey merged pull request #885:
URL: https://github.com/apache/geode-native/pull/885


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430185#comment-17430185
 ] 

ASF subversion and git services commented on GEODE-9553:


Commit 5ba942c7811819ada9baa182da4e38e70db3a221 in geode-native's branch 
refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5ba942c ]

GEODE-9553: remove sprintf usage in test utility code (/tests/cpp) (#883)



> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> tests\cpp\testobject\InvalidPdxUsage.cpp
> tests\cpp\testobject\NestedPdxObject.cpp
> tests\cpp\testobject\PdxClassV1.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430186#comment-17430186
 ] 

ASF GitHub Bot commented on GEODE-9553:
---

pdxcodemonkey merged pull request #883:
URL: https://github.com/apache/geode-native/pull/883


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427704#comment-17427704
 ] 

ASF GitHub Bot commented on GEODE-9553:
---

pdxcodemonkey merged pull request #879:
URL: https://github.com/apache/geode-native/pull/879


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427702#comment-17427702
 ] 

ASF subversion and git services commented on GEODE-9553:


Commit 7eed9d3868118f5f0d1d93f75c2a4b64ddb7cead in geode-native's branch 
refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=7eed9d3 ]

GEODE-9553: remove usage of sprintf from tests (#879)



> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> tests\cpp\testobject\InvalidPdxUsage.cpp
> tests\cpp\testobject\NestedPdxObject.cpp
> tests\cpp\testobject\PdxClassV1.cpp
> tests\cpp\testobject\PdxClassV2.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422940#comment-17422940
 ] 

ASF subversion and git services commented on GEODE-9553:


Commit 10d248406ffc3796a52bfdd641188f1aec696945 in geode-native's branch 
refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=10d2484 ]

GEODE-9553: remove sprintf and snprintf from geode native (#871)

* GEODE-9553: Replace instances of sprintf and snprintf in geode native
- Occasionally one of these will pop up as an error in a new compiler,
  and really they have no place in a modern C++ codebase.
- Just the product code (mostly) for now, we'll do test code in another PR

> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422941#comment-17422941
 ] 

ASF GitHub Bot commented on GEODE-9553:
---

pdxcodemonkey merged pull request #871:
URL: https://github.com/apache/geode-native/pull/871


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
> tests\cpp\security\XmlAuthzCredentialGenerator.cpp
> tests\cpp\testobject\BatchObject.cpp
> tests\cpp\testobject\DeltaPSTObject.cpp
> tests\cpp\testobject\DeltaTestImpl.cpp
> tests\cpp\testobject\EqStruct.cpp
> tests\cpp\testobject\FastAssetAccount.cpp
> 

[jira] [Commented] (GEODE-9553) Review and eliminate all remaining usage of sprintf, snprintf, etc

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422899#comment-17422899
 ] 

ASF GitHub Bot commented on GEODE-9553:
---

echobravopapa commented on a change in pull request #871:
URL: https://github.com/apache/geode-native/pull/871#discussion_r719578551



##
File path: cppcache/src/TcrMessage.cpp
##
@@ -3212,12 +3206,10 @@ TcrMessageHelper::ChunkObjectType 
TcrMessageHelper::readChunkPartHeader(
   // TODO enum - wtf?

Review comment:
   while your in there... maybe delete this line, thanks...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Review and eliminate all remaining usage of sprintf, snprintf, etc
> --
>
> Key: GEODE-9553
> URL: https://issues.apache.org/jira/browse/GEODE-9553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> From time to time, we will pick up a new version of a compiler on one or 
> another platform we build on, and get new complaints about potential buffer 
> overflows or other assorted badness around persistent use of sprintf.  See 
> the following pull request, e.g.: 
> https://github.com/apache/geode-native/pull/861
> Fixing these when they come up is good as far as it goes, but we're really 
> just applying band-aids to the problem.  *All* use of sprintf is bad, 
> snprintf only slightly less so.  Someone needs to just go through the code 
> and rewrite all instances in modern C++ using std::string, std::stringstream, 
> etc.
> At a glance, here is the list of remaining files containing calls to sprintf:
> {code}
> c:\Users\bblake\src\geode-native>findstr /sm sprintf *.cpp
> cppcache\integration\test\ThinClientConflation.cpp
> cppcache\integration-test\fw_dunit.cpp
> cppcache\integration-test\testCacheless.cpp
> cppcache\integration-test\testOverflowPutGetSqLite.cpp
> cppcache\integration-test\testRegionMap.cpp
> cppcache\integration-test\testSerialization.cpp
> cppcache\integration-test\testThinClientBigValue.cpp
> cppcache\integration-test\testThinClientCacheablesLimits.cpp
> cppcache\integration-test\testThinClientCacheableStringArray.cpp
> cppcache\integration-test\testThinClientConflation.cpp
> cppcache\integration-test\testThinClientCq.cpp
> cppcache\integration-test\testThinClientCqDurable.cpp
> cppcache\integration-test\testThinClientCqFailover.cpp
> cppcache\integration-test\testThinClientCqHAFailover.cpp
> cppcache\integration-test\testThinClientCqIR.cpp
> cppcache\integration-test\testThinClientDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientGetInterests.cpp
> cppcache\integration-test\testThinClientHADistOps.cpp
> cppcache\integration-test\testThinClientHAEventIDMap.cpp
> cppcache\integration-test\testThinClientHAFailover.cpp
> cppcache\integration-test\testThinClientHAFailoverRegex.cpp
> cppcache\integration-test\testThinClientHAMixedRedundancy.cpp
> cppcache\integration-test\testThinClientHAPeriodicAck.cpp
> cppcache\integration-test\testThinClientHeapLRU.cpp
> cppcache\integration-test\testThinClientInterest1_Bug1001.cpp
> cppcache\integration-test\testThinClientInterestNotify.cpp
> cppcache\integration-test\testThinClientIntResPolKeysInv.cpp
> cppcache\integration-test\testThinClientListenerCallbackArgTest.cpp
> cppcache\integration-test\testThinClientLRUExpiration.cpp
> cppcache\integration-test\testThinClientMultiDS.cpp
> cppcache\integration-test\testThinClientNotificationWithDeltaWithoutcache.cpp
> cppcache\integration-test\testThinClientPdxDeltaWithNotification.cpp
> cppcache\integration-test\testThinClientPdxInstance.cpp
> cppcache\integration-test\testThinClientPoolAttrTest.cpp
> cppcache\integration-test\testThinClientPoolExecuteFunctionThrowsException.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunction.cpp
> cppcache\integration-test\testThinClientPoolExecuteHAFunctionPrSHOP.cpp
> cppcache\integration-test\testThinClientPoolRedundancy.cpp
> cppcache\integration-test\testThinClientPRPutAllFailover.cpp
> cppcache\integration-test\testThinClientRemoteQueryRS.cpp
> cppcache\integration-test\testThinClientRemoteQuerySS.cpp
> cppcache\integration-test\testThinClientRemoteRegionQuery.cpp
> cppcache\integration-test\testThinClientRemoveOps.cpp
> cppcache\integration-test\testThinClientSecurityPostAuthorization.cpp
> cppcache\integration-test\testXmlCacheCreationWithPools.cpp
> cppcache\integration-test\testXmlCacheInitialization.cpp
> tests\cpp\security\PkcsCredentialGenerator.cpp
>