[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430224#comment-17430224 ] ASF GitHub Bot commented on GEODE-9719: --- mmartell merged pull request #881: URL: https://github.com/apache/geode-native/pull/881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430223#comment-17430223 ] ASF subversion and git services commented on GEODE-9719: Commit 5a1ba8d19709dcda170ea7e313cbae7ad92f797c in geode-native's branch refs/heads/develop from Michael Martell [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5a1ba8d ] GEODE-9719: Start/Stop cluster in a test fixture (#881) * Start/Stop cluster in a test fixture * Create an authRegion in same cluster * Turn off cluster output after all tests run > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[
https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430182#comment-17430182
]
ASF GitHub Bot commented on GEODE-9719:
---
pdxcodemonkey commented on a change in pull request #881:
URL: https://github.com/apache/geode-native/pull/881#discussion_r731252105
##
File path: netcore/shared/GfshExecute.cs
##
@@ -28,11 +28,19 @@ public class GfshExecute : Gfsh
private String connectionCommand_ = null;
private ITestOutputHelper output;
-public GfshExecute(ITestOutputHelper output)
+public ITestOutputHelper Output
{
-this.output = output;
+ get { return output; }
+ set { output = value; }
}
+
+public GfshExecute(ITestOutputHelper output)
+{
+//Output = output;
+this.output = output;
+}
Review comment:
Looks like you have a tabs vs spaces issue in this file(?). Please fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Switch .NET Core Tests to Xunit Fixtures
>
>
> Key: GEODE-9719
> URL: https://issues.apache.org/jira/browse/GEODE-9719
> Project: Geode
> Issue Type: Test
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Labels: pull-request-available
>
> The programmatic cluster support brought in by
> [GEODE-9600|http://example.com] currently starts and stops the geode cluster
> for each test. This ticket is to switch the tests to an Xunit fixture model
> wherein all tests for netcore-lib will be run against a single cluster
> start/stop, and similarly for netcore-session.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428416#comment-17428416 ] ASF GitHub Bot commented on GEODE-9719: --- mmartell commented on pull request #881: URL: https://github.com/apache/geode-native/pull/881#issuecomment-941283771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428408#comment-17428408 ] ASF GitHub Bot commented on GEODE-9719: --- mmartell opened a new pull request #881: URL: https://github.com/apache/geode-native/pull/881 This switches the NetCore test framework to Xunit fixtures. A separate fixture is used for each of the test suites (i.e., netcore-integration-test and netcore-session-integration-test. It also just creates an authRegion not separate cluster for the netcore auth tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428001#comment-17428001 ] ASF GitHub Bot commented on GEODE-9719: --- mmartell commented on pull request #881: URL: https://github.com/apache/geode-native/pull/881#issuecomment-941909201 Rebased against develop to pickup fix for .../integration/test/FunctionExecutionTest.cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427861#comment-17427861 ] ASF GitHub Bot commented on GEODE-9719: --- mmartell commented on pull request #881: URL: https://github.com/apache/geode-native/pull/881#issuecomment-941283771 The build failures are not due to this PR so putting back to Ready for Review mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427814#comment-17427814 ] ASF GitHub Bot commented on GEODE-9719: --- mmartell opened a new pull request #881: URL: https://github.com/apache/geode-native/pull/881 This switches the NetCore test framework to Xunit fixtures. A separate fixture is used for each of the test suites (i.e., netcore-integration-test and netcore-session-integration-test. It also just creates an authRegion not separate cluster for the netcore auth tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
