[jira] [Commented] (GEODE-9929) testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest

2022-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492781#comment-17492781
 ] 

ASF subversion and git services commented on GEODE-9929:


Commit 9fa1c1b3afd1193bb4072501c0ff23008da8625e in geode's branch 
refs/heads/WIP-GEODE-9892 from Hale Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9fa1c1b ]

GEODE-10021: Clean up RemoteTransactionDUnitTest (#7339)

Clean up RemoteTransactionDUnitTest for the next time this failure
occurs.

While trying to reproduce the failure described by GEODE-9929 I did some
clean up so I would be able to get more useful information out of the
failures. I cleaned up a lot of warnings, mostly using IntelliJ's tools.

I cleaned up:
- assertNull
- assertTrue
- assertFalse
- fail
- WaitCriterion
- added  where required to get rid of warnings
- removed unnecessary throws of Exceptions on methods that don't throw
- in assertions switched the actual and expected to be the correct direction
- getGemfireCache (deprecated) -> getCache


> testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest
> 
>
> Key: GEODE-9929
> URL: https://issues.apache.org/jira/browse/GEODE-9929
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.14.3
>Reporter: Kristen
>Priority: Major
>
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest > 
> testTXCreationAndCleanupAtCommit FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call in VM 0 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.doBasicChecks(RemoteTransactionDUnitTest.java:590)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.testTXCreationAndCleanupAtCommit(RemoteTransactionDUnitTest.java:565)
> Caused by:
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertNotNull(Assert.java:713)
> at org.junit.Assert.assertNotNull(Assert.java:723)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call(RemoteTransactionDUnitTest.java:595)
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call in VM 1 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:121)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:109)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.preTearDownCacheTestCase(RemoteTransactionDUnitTest.java:182)
> Caused by:
> java.lang.AssertionError: Event never occurred after 3 ms: 
> at org.junit.Assert.fail(Assert.java:89)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:144)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call(RemoteTransactionDUnitTest.java:149)
> 8838 tests completed, 1 failed, 458 skipped



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (GEODE-9929) testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest

2022-02-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492207#comment-17492207
 ] 

ASF subversion and git services commented on GEODE-9929:


Commit 9fa1c1b3afd1193bb4072501c0ff23008da8625e in geode's branch 
refs/heads/GEODE-9892-Create-Infrastructure-for-Redis-Lists from Hale Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9fa1c1b ]

GEODE-10021: Clean up RemoteTransactionDUnitTest (#7339)

Clean up RemoteTransactionDUnitTest for the next time this failure
occurs.

While trying to reproduce the failure described by GEODE-9929 I did some
clean up so I would be able to get more useful information out of the
failures. I cleaned up a lot of warnings, mostly using IntelliJ's tools.

I cleaned up:
- assertNull
- assertTrue
- assertFalse
- fail
- WaitCriterion
- added  where required to get rid of warnings
- removed unnecessary throws of Exceptions on methods that don't throw
- in assertions switched the actual and expected to be the correct direction
- getGemfireCache (deprecated) -> getCache


> testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest
> 
>
> Key: GEODE-9929
> URL: https://issues.apache.org/jira/browse/GEODE-9929
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.14.3
>Reporter: Kristen
>Priority: Major
>
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest > 
> testTXCreationAndCleanupAtCommit FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call in VM 0 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.doBasicChecks(RemoteTransactionDUnitTest.java:590)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.testTXCreationAndCleanupAtCommit(RemoteTransactionDUnitTest.java:565)
> Caused by:
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertNotNull(Assert.java:713)
> at org.junit.Assert.assertNotNull(Assert.java:723)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call(RemoteTransactionDUnitTest.java:595)
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call in VM 1 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:121)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:109)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.preTearDownCacheTestCase(RemoteTransactionDUnitTest.java:182)
> Caused by:
> java.lang.AssertionError: Event never occurred after 3 ms: 
> at org.junit.Assert.fail(Assert.java:89)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:144)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call(RemoteTransactionDUnitTest.java:149)
> 8838 tests completed, 1 failed, 458 skipped



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (GEODE-9929) testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest

2022-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491095#comment-17491095
 ] 

ASF subversion and git services commented on GEODE-9929:


Commit 9fa1c1b3afd1193bb4072501c0ff23008da8625e in geode's branch 
refs/heads/develop from Hale Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9fa1c1b ]

GEODE-10021: Clean up RemoteTransactionDUnitTest (#7339)

Clean up RemoteTransactionDUnitTest for the next time this failure
occurs.

While trying to reproduce the failure described by GEODE-9929 I did some
clean up so I would be able to get more useful information out of the
failures. I cleaned up a lot of warnings, mostly using IntelliJ's tools.

I cleaned up:
- assertNull
- assertTrue
- assertFalse
- fail
- WaitCriterion
- added  where required to get rid of warnings
- removed unnecessary throws of Exceptions on methods that don't throw
- in assertions switched the actual and expected to be the correct direction
- getGemfireCache (deprecated) -> getCache


> testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest
> 
>
> Key: GEODE-9929
> URL: https://issues.apache.org/jira/browse/GEODE-9929
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.14.3
>Reporter: Kristen
>Priority: Major
>
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest > 
> testTXCreationAndCleanupAtCommit FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call in VM 0 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.doBasicChecks(RemoteTransactionDUnitTest.java:590)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.testTXCreationAndCleanupAtCommit(RemoteTransactionDUnitTest.java:565)
> Caused by:
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertNotNull(Assert.java:713)
> at org.junit.Assert.assertNotNull(Assert.java:723)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call(RemoteTransactionDUnitTest.java:595)
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call in VM 1 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:121)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:109)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.preTearDownCacheTestCase(RemoteTransactionDUnitTest.java:182)
> Caused by:
> java.lang.AssertionError: Event never occurred after 3 ms: 
> at org.junit.Assert.fail(Assert.java:89)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:144)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call(RemoteTransactionDUnitTest.java:149)
> 8838 tests completed, 1 failed, 458 skipped



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (GEODE-9929) testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest

2022-02-04 Thread Hale Bales (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487361#comment-17487361
 ] 

Hale Bales commented on GEODE-9929:
---

Removing needsTriage label as this is not a release blocker.

What I found was that `testTXCreationAndCleanupAtCommit` calls `doBasicChecks`. 
In this there is a callable that attempts to pause the transaction through the 
manager, but the returned `TXStateProxy` is null. The call to 
`TXManagerImpl.pauseTransaction()` that should return a `TXStateProxy` calls 
`internalSuspend(bool)`. In this method we call `getTXState()` but receive a 
null result instead of a `TXStateProxy`. `getTXState()` can return null if the 
`TXStateProxy` on the context is null; if the `TXStateProxy` is Paused; or if 
the `TXStateProxy` is does not have any transactions in progress. As I was 
never able to reproduce the failure after thousands of runs, I do not know 
which of these cases has resulted in the error.

Given all that, this seems like a timing issue in the test, and an infrequent 
one at that. This timing issue is unlikely to affect users, and is therefore 
not of high enough priority to be a 1.15 release blocker.

> testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest
> 
>
> Key: GEODE-9929
> URL: https://issues.apache.org/jira/browse/GEODE-9929
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.14.3
>Reporter: Kristen
>Priority: Major
>
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest > 
> testTXCreationAndCleanupAtCommit FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call in VM 0 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.doBasicChecks(RemoteTransactionDUnitTest.java:590)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.testTXCreationAndCleanupAtCommit(RemoteTransactionDUnitTest.java:565)
> Caused by:
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertNotNull(Assert.java:713)
> at org.junit.Assert.assertNotNull(Assert.java:723)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call(RemoteTransactionDUnitTest.java:595)
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call in VM 1 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:121)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:109)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.preTearDownCacheTestCase(RemoteTransactionDUnitTest.java:182)
> Caused by:
> java.lang.AssertionError: Event never occurred after 3 ms: 
> at org.junit.Assert.fail(Assert.java:89)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:144)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call(RemoteTransactionDUnitTest.java:149)
> 8838 tests completed, 1 failed, 458 skipped



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (GEODE-9929) testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest

2022-01-06 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470152#comment-17470152
 ] 

Geode Integration commented on GEODE-9929:
--

Seen on support/1.14 in [distributed-test-openjdk8 
#20|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-14-main/jobs/distributed-test-openjdk8/builds/20]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.3-build.0907/test-results/distributedTest/1641468543/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.3-build.0907/test-artifacts/1641468543/distributedtestfiles-openjdk8-1.14.3-build.0907.tgz].

> testTXCreationAndCleanupAtCommit when running RemoteTransactionDUnitTest
> 
>
> Key: GEODE-9929
> URL: https://issues.apache.org/jira/browse/GEODE-9929
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.14.3
>Reporter: Kristen
>Priority: Major
>
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest > 
> testTXCreationAndCleanupAtCommit FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call in VM 0 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.doBasicChecks(RemoteTransactionDUnitTest.java:590)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.testTXCreationAndCleanupAtCommit(RemoteTransactionDUnitTest.java:565)
> Caused by:
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertNotNull(Assert.java:713)
> at org.junit.Assert.assertNotNull(Assert.java:723)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$8.call(RemoteTransactionDUnitTest.java:595)
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call in VM 1 
> running on Host 9acb6806d25d with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:473)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:121)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:109)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest.preTearDownCacheTestCase(RemoteTransactionDUnitTest.java:182)
> Caused by:
> java.lang.AssertionError: Event never occurred after 3 ms: 
> at org.junit.Assert.fail(Assert.java:89)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:144)
> at 
> org.apache.geode.internal.cache.RemoteTransactionDUnitTest$2.call(RemoteTransactionDUnitTest.java:149)
> 8838 tests completed, 1 failed, 458 skipped



--
This message was sent by Atlassian Jira
(v8.20.1#820001)