[jira] [Reopened] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory

2018-07-10 Thread Dan Smith (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith reopened GEODE-5292:
--

This test failed again in CI

 
{noformat}
org.apache.geode.cache.ConcurrentRegionOperationIntegrationTest > 
replaceWithClearAndDestroy FAILED
    java.lang.AssertionError:
    Expecting:
  
    to be an instance of:
  
    but was:
  <"java.lang.IllegalStateException: retain failed addr=140497939066896 
addr2=140497939066896 100 times history=null
        at 
org.apache.geode.internal.offheap.OffHeapRegionEntryHelper._getValueRetain(OffHeapRegionEntryHelper.java:397)
        at 
org.apache.geode.internal.cache.entries.VersionedThinDiskLRURegionEntryOffHeapIntKey.getValueRetain(VersionedThinDiskLRURegionEntryOffHeapIntKey.java:134)
        at 
org.apache.geode.internal.cache.entries.DiskEntry$Helper.getValueOffHeapOrDiskWithoutFaultIn(DiskEntry.java:1016)
        at 
org.apache.geode.internal.cache.entries.AbstractOplogDiskRegionEntry.getValueOffHeapOrDiskWithoutFaultIn(AbstractOplogDiskRegionEntry.java:97)
        at 
org.apache.geode.internal.cache.map.RegionMapPut.setOldValueEvenIfFaultedOut(RegionMapPut.java:204)
        at 
org.apache.geode.internal.cache.map.RegionMapPut.setOldValueInEvent(RegionMapPut.java:171)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutOnSynchronizedRegionEntry(AbstractRegionMapPut.java:269)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutOnRegionEntryInMap(AbstractRegionMapPut.java:261)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.addRegionEntryToMapAndDoPut(AbstractRegionMapPut.java:239)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutRetryingIfNeeded(AbstractRegionMapPut.java:204)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doWithIndexInUpdateMode(AbstractRegionMapPut.java:186)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:168)
        at 
org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:150)
        at 
org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:158)
        at 
org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2104)
        at 
org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5661)
        at 
org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:371)
        at 
org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:152)
        at 
org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5086)
        at 
org.apache.geode.internal.cache.LocalRegion.replace(LocalRegion.java:11742)
        at 
org.apache.geode.internal.cache.LocalRegion.replace(LocalRegion.java:11703)
        at 
org.apache.geode.cache.ConcurrentRegionOperationIntegrationTest.lambda$replaceWithClearAndDestroy$1(ConcurrentRegionOperationIntegrationTest.java:85)
        at 
org.assertj.core.api.ThrowableAssert.catchThrowable(ThrowableAssert.java:60)
        at 
org.assertj.core.api.ThrowableTypeAssert.isThrownBy(ThrowableTypeAssert.java:54)
        at 
org.apache.geode.cache.ConcurrentRegionOperationIntegrationTest.replaceWithClearAndDestroy(ConcurrentRegionOperationIntegrationTest.java:85)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at 

[jira] [Reopened] (GEODE-5292) Replace with concurrent clear and destroy leaks off heap memory

2018-07-06 Thread Dan Smith (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith reopened GEODE-5292:
--

> Replace with concurrent clear and destroy leaks off heap memory
> ---
>
> Key: GEODE-5292
> URL: https://issues.apache.org/jira/browse/GEODE-5292
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
>  Labels: pull-request-available, swat
> Fix For: 1.8.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> For a region that has been configured with off-heap storage and overflow to 
> disk, memory can be leaked if
>  * region clear
>  * region destroy 
>  * region replace
> all happen concurrently. The root cause appears to be region clear modifying 
> entries for values stored on disk without synchronizing the entries. This 
> prevents replace from freeing the off-heap memory for the new value when the 
> replace fails because the region is being destroyed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)