[
https://issues.apache.org/jira/browse/GEODE-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols resolved GEODE-9702.
---------------------------------
Fix Version/s: 1.15.0
Resolution: Fixed
> japicmp should fail when new methods are added to public interface
> ------------------------------------------------------------------
>
> Key: GEODE-9702
> URL: https://issues.apache.org/jira/browse/GEODE-9702
> Project: Geode
> Issue Type: Bug
> Components: ci
> Affects Versions: 1.15.0
> Reporter: Owen Nichols
> Assignee: Robert Houghton
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> At least twice in 1.15.0 (commits 7aa03824 and b377e3f8), new methods were
> added to Geode's public API (such as
> `GatewaySender.getRetriesToGetTransactionEventsFromQueue`). While adding
> methods _is_ compatible with existing source and binary calls to this
> interface, it breaks anything else that implements this interface. _Even if_
> a default implementation had been provided, there are still edge cases where
> it could collide with existing implementation that may already have methods
> with those names. These two examples have been fixed now by GEODE-9629 and
> GEODE-9630; this ticket is to fix CI to prevent this in the future.
> Our required PR check "*api-check-test-openjdk11*" should have prevented this
> from happening...
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
