[jira] [Updated] (GEODE-10306) CacheServerImpl should stop the acceptor immediately after stop is called

2022-05-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-10306:
---
Labels: pull-request-available  (was: )

> CacheServerImpl should stop the acceptor immediately after stop is called
> -
>
> Key: GEODE-10306
> URL: https://issues.apache.org/jira/browse/GEODE-10306
> Project: Geode
>  Issue Type: Bug
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>  Labels: pull-request-available
>
> Currently, after cache server stop is called, it takes a while for the 
> acceptor to stop taking new data, which can be a problem because the bigger 
> the window of time, the greater the risk of data loss. 
>  
> {noformat}
> public synchronized void stop() {
>   if (!isRunning()) {
> return;
>   }
>   RuntimeException firstException = null;
>   try {
> if (loadMonitor != null) {
>   loadMonitor.stop();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing load monitor", e);
> firstException = e;
>   }
>   try {
> if (advisor != null) {
>   advisor.close();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing advisor", e);
> firstException = e;
>   }
> PROBLEM ->  try {
> if (acceptor != null) {
>   acceptor.close();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing acceptor monitor", e);
> if (firstException != null) {
>   firstException = e;
> }
>   } {noformat}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (GEODE-10306) CacheServerImpl should stop the acceptor immediately after stop is called

2022-05-13 Thread Anthony Baker (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-10306:
--
Labels:   (was: needsTriage)

> CacheServerImpl should stop the acceptor immediately after stop is called
> -
>
> Key: GEODE-10306
> URL: https://issues.apache.org/jira/browse/GEODE-10306
> Project: Geode
>  Issue Type: Bug
>Reporter: Mark Hanson
>Priority: Major
>
> Currently, after cache server stop is called, it takes a while for the 
> acceptor to stop taking new data, which can be a problem because the bigger 
> the window of time, the greater the risk of data loss. 
>  
> {noformat}
> public synchronized void stop() {
>   if (!isRunning()) {
> return;
>   }
>   RuntimeException firstException = null;
>   try {
> if (loadMonitor != null) {
>   loadMonitor.stop();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing load monitor", e);
> firstException = e;
>   }
>   try {
> if (advisor != null) {
>   advisor.close();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing advisor", e);
> firstException = e;
>   }
> PROBLEM ->  try {
> if (acceptor != null) {
>   acceptor.close();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing acceptor monitor", e);
> if (firstException != null) {
>   firstException = e;
> }
>   } {noformat}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Updated] (GEODE-10306) CacheServerImpl should stop the acceptor immediately after stop is called

2022-05-12 Thread Alexander Murmann (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Murmann updated GEODE-10306:
--
Labels: needsTriage  (was: )

> CacheServerImpl should stop the acceptor immediately after stop is called
> -
>
> Key: GEODE-10306
> URL: https://issues.apache.org/jira/browse/GEODE-10306
> Project: Geode
>  Issue Type: Bug
>Reporter: Mark Hanson
>Priority: Major
>  Labels: needsTriage
>
> Currently, after cache server stop is called, it takes a while for the 
> acceptor to stop taking new data, which can be a problem because the bigger 
> the window of time, the greater the risk of data loss. 
>  
> {noformat}
> public synchronized void stop() {
>   if (!isRunning()) {
> return;
>   }
>   RuntimeException firstException = null;
>   try {
> if (loadMonitor != null) {
>   loadMonitor.stop();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing load monitor", e);
> firstException = e;
>   }
>   try {
> if (advisor != null) {
>   advisor.close();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing advisor", e);
> firstException = e;
>   }
> PROBLEM ->  try {
> if (acceptor != null) {
>   acceptor.close();
> }
>   } catch (RuntimeException e) {
> logger.warn("CacheServer - Error closing acceptor monitor", e);
> if (firstException != null) {
>   firstException = e;
> }
>   } {noformat}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)