[jira] [Commented] (GEODE-8497) Get heap memory occupied by GW senders queue events
[ https://issues.apache.org/jira/browse/GEODE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216469#comment-17216469 ] ASF GitHub Bot commented on GEODE-8497: --- mivanac merged pull request #5514: URL: https://github.com/apache/geode/pull/5514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Get heap memory occupied by GW senders queue events > --- > > Key: GEODE-8497 > URL: https://issues.apache.org/jira/browse/GEODE-8497 > Project: Geode > Issue Type: Improvement > Components: jmx, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Extract exact heap memory occupied by GW senders queue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8497) Get heap memory occupied by GW senders queue events
[ https://issues.apache.org/jira/browse/GEODE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216471#comment-17216471 ] ASF subversion and git services commented on GEODE-8497: Commit c362f77591fa83e5f87a056fe221d1241de87348 in geode's branch refs/heads/develop from Mario Ivanac [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c362f77 ] GEODE-8497: added getTotalQueueSizeBytesInUse (#5514) * GEODE-8497: added getTotalQueueSizeBytesInUse * GEODE-8497: updated UT * GEODE-8497: fix fail statistics after restart > Get heap memory occupied by GW senders queue events > --- > > Key: GEODE-8497 > URL: https://issues.apache.org/jira/browse/GEODE-8497 > Project: Geode > Issue Type: Improvement > Components: jmx, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Extract exact heap memory occupied by GW senders queue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8497) Get heap memory occupied by GW senders queue events
[ https://issues.apache.org/jira/browse/GEODE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216470#comment-17216470 ] ASF subversion and git services commented on GEODE-8497: Commit c362f77591fa83e5f87a056fe221d1241de87348 in geode's branch refs/heads/develop from Mario Ivanac [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c362f77 ] GEODE-8497: added getTotalQueueSizeBytesInUse (#5514) * GEODE-8497: added getTotalQueueSizeBytesInUse * GEODE-8497: updated UT * GEODE-8497: fix fail statistics after restart > Get heap memory occupied by GW senders queue events > --- > > Key: GEODE-8497 > URL: https://issues.apache.org/jira/browse/GEODE-8497 > Project: Geode > Issue Type: Improvement > Components: jmx, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Extract exact heap memory occupied by GW senders queue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8497) Get heap memory occupied by GW senders queue events
[ https://issues.apache.org/jira/browse/GEODE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216472#comment-17216472 ] ASF subversion and git services commented on GEODE-8497: Commit c362f77591fa83e5f87a056fe221d1241de87348 in geode's branch refs/heads/develop from Mario Ivanac [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c362f77 ] GEODE-8497: added getTotalQueueSizeBytesInUse (#5514) * GEODE-8497: added getTotalQueueSizeBytesInUse * GEODE-8497: updated UT * GEODE-8497: fix fail statistics after restart > Get heap memory occupied by GW senders queue events > --- > > Key: GEODE-8497 > URL: https://issues.apache.org/jira/browse/GEODE-8497 > Project: Geode > Issue Type: Improvement > Components: jmx, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Extract exact heap memory occupied by GW senders queue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8497) Get heap memory occupied by GW senders queue events
[ https://issues.apache.org/jira/browse/GEODE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Ivanac resolved GEODE-8497. - Resolution: Fixed > Get heap memory occupied by GW senders queue events > --- > > Key: GEODE-8497 > URL: https://issues.apache.org/jira/browse/GEODE-8497 > Project: Geode > Issue Type: Improvement > Components: jmx, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Extract exact heap memory occupied by GW senders queue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8497) Get heap memory occupied by GW senders queue events
[ https://issues.apache.org/jira/browse/GEODE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216473#comment-17216473 ] ASF subversion and git services commented on GEODE-8497: Commit c362f77591fa83e5f87a056fe221d1241de87348 in geode's branch refs/heads/develop from Mario Ivanac [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c362f77 ] GEODE-8497: added getTotalQueueSizeBytesInUse (#5514) * GEODE-8497: added getTotalQueueSizeBytesInUse * GEODE-8497: updated UT * GEODE-8497: fix fail statistics after restart > Get heap memory occupied by GW senders queue events > --- > > Key: GEODE-8497 > URL: https://issues.apache.org/jira/browse/GEODE-8497 > Project: Geode > Issue Type: Improvement > Components: jmx, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Extract exact heap memory occupied by GW senders queue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8627) Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided
[
https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216762#comment-17216762
]
ASF GitHub Bot commented on GEODE-8627:
---
jdeppe-pivotal commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r507788349
##
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/pubsub/Subscription.java
##
@@ -53,11 +53,15 @@ void publishMessage(byte[] channel, byte[] message,
List createResponse(byte[] channel, byte[] message);
/**
- * Return the subscription name. In the case of a pattern the string
representation of the
- * pattern is returned.
+ * Return the channel name. In the case of a pattern null is returned.
*/
byte[] getChannelName();
+ /**
+ * Return the pattern name. In the case of a channel null is returned.
+ */
+ byte[] getPatternName();
Review comment:
I can see that you want the method name to be more expressive, but I
don't think it's good practice to have an API where some methods return null
depending on what type of object you're using. That opens the door for a dev to
easily make a mistake. I'd prefer to keep a single method but give it a more
descriptive name. Perhaps `getSubscriptionName()` or `getChannelOrPattern()`.
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractSubscriptionsIntegrationTest.java
##
@@ -88,18 +111,91 @@ public void multiSubscribe() {
.untilAsserted(() ->
assertThat(mockSubscriber.getReceivedPMessages()).hasSize(1));
assertThat(mockSubscriber.getReceivedEvents()).containsExactly("message",
"pmessage");
mockSubscriber.unsubscribe();
-client.close();
}
@Test
- public void unallowedCommandsWhileSubscribed() {
-Jedis client = new Jedis("localhost", getPort());
+ public void
unsubscribingImplicitlyFromAllChannels_doesNotUnsubscribeFromPatterns() {
Review comment:
Do we not already have similar tests in `AbstractPubSubIntegrationTest`?
Perhaps `testUnsubscribingImplicitlyFromAllChannels` and
`testPunsubscribingImplicitlyFromAllChannels`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis not unsubscribing and punsubscribing correctly when no channel/pattern
> provided
> -
>
> Key: GEODE-8627
> URL: https://issues.apache.org/jira/browse/GEODE-8627
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
> Labels: pull-request-available
>
> Geode Redis should unsubscribe from all channels (not including patterns)
> when no channel is provided and punsubscribe from all patterns (not including
> channels) when no pattern is provided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8627) Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided
[
https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216767#comment-17216767
]
ASF GitHub Bot commented on GEODE-8627:
---
jdeppe-pivotal commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r507793073
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractSubscriptionsIntegrationTest.java
##
@@ -88,18 +111,91 @@ public void multiSubscribe() {
.untilAsserted(() ->
assertThat(mockSubscriber.getReceivedPMessages()).hasSize(1));
assertThat(mockSubscriber.getReceivedEvents()).containsExactly("message",
"pmessage");
mockSubscriber.unsubscribe();
-client.close();
}
@Test
- public void unallowedCommandsWhileSubscribed() {
-Jedis client = new Jedis("localhost", getPort());
+ public void
unsubscribingImplicitlyFromAllChannels_doesNotUnsubscribeFromPatterns() {
Review comment:
Do we not already have similar tests in `AbstractPubSubIntegrationTest`?
Perhaps `testUnsubscribingImplicitlyFromAllChannels` and
`testPunsubscribingImplicitlyFromAllChannels`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis not unsubscribing and punsubscribing correctly when no channel/pattern
> provided
> -
>
> Key: GEODE-8627
> URL: https://issues.apache.org/jira/browse/GEODE-8627
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
> Labels: pull-request-available
>
> Geode Redis should unsubscribe from all channels (not including patterns)
> when no channel is provided and punsubscribe from all patterns (not including
> channels) when no pattern is provided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8629) Redis TTL should round up the returned value
Jens Deppe created GEODE-8629: - Summary: Redis TTL should round up the returned value Key: GEODE-8629 URL: https://issues.apache.org/jira/browse/GEODE-8629 Project: Geode Issue Type: Improvement Components: redis Reporter: Jens Deppe Because native redis does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8630) Add Redis UNLINK command
[
https://issues.apache.org/jira/browse/GEODE-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8630:
--
Labels: pull-request-available (was: )
> Add Redis UNLINK command
>
>
> Key: GEODE-8630
> URL: https://issues.apache.org/jira/browse/GEODE-8630
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Implemented as a synonym to {{DEL}}. We are not doing async deletes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8630) Add Redis UNLINK command
[
https://issues.apache.org/jira/browse/GEODE-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216811#comment-17216811
]
ASF GitHub Bot commented on GEODE-8630:
---
jdeppe-pivotal opened a new pull request #5641:
URL: https://github.com/apache/geode/pull/5641
- This does not implement async deletes
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Redis UNLINK command
>
>
> Key: GEODE-8630
> URL: https://issues.apache.org/jira/browse/GEODE-8630
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
>
> Implemented as a synonym to {{DEL}}. We are not doing async deletes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8575) IntegrationTest failure IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository FAILED
[
https://issues.apache.org/jira/browse/GEODE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Donal Evans resolved GEODE-8575.
Fix Version/s: 1.14.0
Resolution: Fixed
> IntegrationTest failure
> IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository
> FAILED
> ---
>
> Key: GEODE-8575
> URL: https://issues.apache.org/jira/browse/GEODE-8575
> Project: Geode
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.14.0
>Reporter: Mark Hanson
>Assignee: Donal Evans
>Priority: Major
> Fix For: 1.14.0
>
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK11/builds/478]
>
> {noformat}
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest
> >
> shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository
> FAILED
> org.mockito.exceptions.misusing.UnfinishedStubbingException:
> Unfinished stubbing detected here:
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:102)
> E.g. thenReturn() may be missing.
> Examples of correct stubbing:
> when(mock.isOk()).thenReturn(true);
> when(mock.isOk()).thenThrow(exception);
> doThrow(exception).when(mock).someVoidMethod();
> Hints:
> 1. missing thenReturn()
> 2. you are trying to stub a final method, which is not supported
> 3. you are stubbing the behaviour of another mock inside before
> 'thenReturn' instruction is completed
> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:102)
> {noformat}
>
>
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0388/test-results/integrationTest/1601691512/]
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0388/test-artifacts/1601691512/integrationtestfiles-OpenJDK11-1.14.0-build.0388.tgz]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8630) Add Redis UNLINK command
Jens Deppe created GEODE-8630:
-
Summary: Add Redis UNLINK command
Key: GEODE-8630
URL: https://issues.apache.org/jira/browse/GEODE-8630
Project: Geode
Issue Type: Improvement
Components: redis
Reporter: Jens Deppe
Implemented as a synonym to {{DEL}}. We are not doing async deletes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8628) SetReadTimeout not working
Michael Martell created GEODE-8628: -- Summary: SetReadTimeout not working Key: GEODE-8628 URL: https://issues.apache.org/jira/browse/GEODE-8628 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell This PoolFactory API isn't working. We need to write a new test for this functionality. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8627) Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided
[
https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216857#comment-17216857
]
ASF GitHub Bot commented on GEODE-8627:
---
sabbey37 commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r507884986
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractSubscriptionsIntegrationTest.java
##
@@ -88,18 +111,91 @@ public void multiSubscribe() {
.untilAsserted(() ->
assertThat(mockSubscriber.getReceivedPMessages()).hasSize(1));
assertThat(mockSubscriber.getReceivedEvents()).containsExactly("message",
"pmessage");
mockSubscriber.unsubscribe();
-client.close();
}
@Test
- public void unallowedCommandsWhileSubscribed() {
-Jedis client = new Jedis("localhost", getPort());
+ public void
unsubscribingImplicitlyFromAllChannels_doesNotUnsubscribeFromPatterns() {
Review comment:
We do have a test that only subscribes to channels and then unsubscribes
without an argument. We did not have a test that subscribes to channels and
psubscribes to patterns, then unsubscribes without an argument (or
punsubscribes without an argument). We were incorrectly unsubscribing from
everything (channels and patterns) when punsubscribe or unsubscribe were called
without an argument. Native Redis will only unsubscribe from channels (not
patterns) if unsubscribe is called without an argument or punsubscribe only
from patterns (not channels) if punsubscribe is called without an argument.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis not unsubscribing and punsubscribing correctly when no channel/pattern
> provided
> -
>
> Key: GEODE-8627
> URL: https://issues.apache.org/jira/browse/GEODE-8627
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
> Labels: pull-request-available
>
> Geode Redis should unsubscribe from all channels (not including patterns)
> when no channel is provided and punsubscribe from all patterns (not including
> channels) when no pattern is provided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8627) Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided
[ https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216865#comment-17216865 ] ASF GitHub Bot commented on GEODE-8627: --- sabbey37 commented on a change in pull request #5639: URL: https://github.com/apache/geode/pull/5639#discussion_r507886058 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/pubsub/Subscription.java ## @@ -53,11 +53,15 @@ void publishMessage(byte[] channel, byte[] message, List createResponse(byte[] channel, byte[] message); /** - * Return the subscription name. In the case of a pattern the string representation of the - * pattern is returned. + * Return the channel name. In the case of a pattern null is returned. */ byte[] getChannelName(); + /** + * Return the pattern name. In the case of a channel null is returned. + */ + byte[] getPatternName(); Review comment: I'm definitely open to suggestions on this, maybe we could have another method that's called `getChannelOrPattern()` or some other way of distinguishing whether a channel/pattern name was returned? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Redis not unsubscribing and punsubscribing correctly when no channel/pattern > provided > - > > Key: GEODE-8627 > URL: https://issues.apache.org/jira/browse/GEODE-8627 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Geode Redis should unsubscribe from all channels (not including patterns) > when no channel is provided and punsubscribe from all patterns (not including > channels) when no pattern is provided. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8629) Redis TTL should round up the returned value
[ https://issues.apache.org/jira/browse/GEODE-8629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216782#comment-17216782 ] ASF GitHub Bot commented on GEODE-8629: --- jdeppe-pivotal opened a new pull request #5640: URL: https://github.com/apache/geode/pull/5640 Authored-by: Jens Deppe Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Redis TTL should round up the returned value > > > Key: GEODE-8629 > URL: https://issues.apache.org/jira/browse/GEODE-8629 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Jens Deppe >Priority: Major > > Because native redis does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8629) Redis TTL should round up the returned value
[ https://issues.apache.org/jira/browse/GEODE-8629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8629: -- Labels: pull-request-available (was: ) > Redis TTL should round up the returned value > > > Key: GEODE-8629 > URL: https://issues.apache.org/jira/browse/GEODE-8629 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Jens Deppe >Priority: Major > Labels: pull-request-available > > Because native redis does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8627) Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided
[ https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216868#comment-17216868 ] ASF GitHub Bot commented on GEODE-8627: --- sabbey37 commented on a change in pull request #5639: URL: https://github.com/apache/geode/pull/5639#discussion_r507886058 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/pubsub/Subscription.java ## @@ -53,11 +53,15 @@ void publishMessage(byte[] channel, byte[] message, List createResponse(byte[] channel, byte[] message); /** - * Return the subscription name. In the case of a pattern the string representation of the - * pattern is returned. + * Return the channel name. In the case of a pattern null is returned. */ byte[] getChannelName(); + /** + * Return the pattern name. In the case of a channel null is returned. + */ + byte[] getPatternName(); Review comment: I'm definitely open to suggestions on this. The main reason this method was created and the `getChannelName()` method was changed was to unsubscribe from only channels or only patterns as appropriate. We could always distinguish a channel from a pattern in other ways. What do you think is best? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Redis not unsubscribing and punsubscribing correctly when no channel/pattern > provided > - > > Key: GEODE-8627 > URL: https://issues.apache.org/jira/browse/GEODE-8627 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Sarah Abbey >Assignee: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Geode Redis should unsubscribe from all channels (not including patterns) > when no channel is provided and punsubscribe from all patterns (not including > channels) when no pattern is provided. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6903) CI Failure: GemFireTransactionDataSourceIntegrationTest.testExceptionHandlingGetConnection failed with Assertion
[
https://issues.apache.org/jira/browse/GEODE-6903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216876#comment-17216876
]
Geode Integration commented on GEODE-6903:
--
Seen in [IntegrationTestOpenJDK11
#518|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK11/builds/518]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0422/test-results/integrationTest/1603125178/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0422/test-artifacts/1603125178/integrationtestfiles-OpenJDK11-1.14.0-build.0422.tgz].
> CI Failure:
> GemFireTransactionDataSourceIntegrationTest.testExceptionHandlingGetConnection
> failed with Assertion
>
>
> Key: GEODE-6903
> URL: https://issues.apache.org/jira/browse/GEODE-6903
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Affects Versions: 1.14.0
>Reporter: Eric Shu
>Assignee: Kirk Lund
>Priority: Major
> Labels: flaky
>
> {noformat}
> org.apache.geode.internal.datasource.GemFireTransactionDataSourceIntegrationTest
> > testExceptionHandlingGetConnection FAILED
> org.junit.ComparisonFailure: expected:<[0]> but was:<[2]>
> at sun.reflect.GeneratedConstructorAccessor26.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.datasource.GemFireTransactionDataSourceIntegrationTest.testExceptionHandlingGetConnection(GemFireTransactionDataSourceIntegrationTest.java:141)
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.10.0-SNAPSHOT.0399/test-results/integrationTest/1561170841/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.10.0-SNAPSHOT.0399/test-artifacts/1561170841/integrationtestfiles-OpenJDK8-1.10.0-SNAPSHOT.0399.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8620) Actual redundancy of -1 in restore redundancy result
[ https://issues.apache.org/jira/browse/GEODE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8620: -- Labels: pull-request-available (was: ) > Actual redundancy of -1 in restore redundancy result > > > Key: GEODE-8620 > URL: https://issues.apache.org/jira/browse/GEODE-8620 > Project: Geode > Issue Type: Bug > Components: gfsh, management >Affects Versions: 1.13.0 >Reporter: Aaron Lindsey >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > > Steps to reproduce: > # Create a geode cluster with 1 locator and 2 servers. > # Create a region of type PARTITION_REDUNDANT. > # Put an entry into the region. > # Trigger a restore redundancy operation via the management REST API or gfsh. > # The result from the restore redundancy operation states that the actual > redundancy for the region is -1. However, the expected redundancy at this > point is 1 because there should be enough cache servers in the cluster to > hold the redundant copy. > # Stop one of the servers. > # Trigger another restore redundancy operation via the management REST API > or gfsh. > # The result from the second restore redundancy operation again states that > the actual redundancy for the region is -1. However, the region should be > counted as having zero redundant copies at this point because there is only > one cache server. > I encountered this issue while using the management REST API, although the > same issue happens in the gfsh command. I assume fixing the gfsh command > would also fix the management REST API. If not, I can break this out into two > separate JIRAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216917#comment-17216917 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216919#comment-17216919 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216921#comment-17216921 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216918#comment-17216918 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8627) Redis not unsubscribing and punsubscribing correctly when no channel/pattern provided
[
https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217019#comment-17217019
]
ASF GitHub Bot commented on GEODE-8627:
---
jdeppe-pivotal commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r507977581
##
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/pubsub/Subscription.java
##
@@ -53,11 +53,15 @@ void publishMessage(byte[] channel, byte[] message,
List createResponse(byte[] channel, byte[] message);
/**
- * Return the subscription name. In the case of a pattern the string
representation of the
- * pattern is returned.
+ * Return the channel name. In the case of a pattern null is returned.
*/
byte[] getChannelName();
+ /**
+ * Return the pattern name. In the case of a channel null is returned.
+ */
+ byte[] getPatternName();
Review comment:
I see what the problem is now. I think it would be better to provide a
`Type` enum into the `Subscription` interface:
```
enum Type {
CHANNEL,
PATTERN;
}
Type getType();
```
And then you should be able to filter by that when you need to have methods
distinguish the type of subscription.
In the `PubSub` interface you can add:
```
List findSubscribedChannels(Client client, Subscription.Type type);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis not unsubscribing and punsubscribing correctly when no channel/pattern
> provided
> -
>
> Key: GEODE-8627
> URL: https://issues.apache.org/jira/browse/GEODE-8627
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
> Labels: pull-request-available
>
> Geode Redis should unsubscribe from all channels (not including patterns)
> when no channel is provided and punsubscribe from all patterns (not including
> channels) when no pattern is provided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8607) Add new API for getting oldest tombstone age.
[ https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade updated GEODE-8607: - Affects Version/s: 1.14.0 > Add new API for getting oldest tombstone age. > - > > Key: GEODE-8607 > URL: https://issues.apache.org/jira/browse/GEODE-8607 > Project: Geode > Issue Type: Bug > Components: core >Affects Versions: 1.14.0 >Reporter: Mark Hanson >Assignee: Mark Hanson >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > It would be handy in diagnosing certain issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216915#comment-17216915 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216916#comment-17216916 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code
[
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216993#comment-17216993
]
ASF GitHub Bot commented on GEODE-8584:
---
Bill commented on a change in pull request #5638:
URL: https://github.com/apache/geode/pull/5638#discussion_r507961548
##
File path:
geode-core/src/main/java/org/apache/geode/internal/net/ByteBufferSharingImpl.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.net;
+
+import java.nio.ByteBuffer;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * An {@link AutoCloseable} meant to be acquired in a try-with-resources
statement. The resource (a
+ * {@link ByteBuffer}) is available (for reading and modification) in the
scope of the
+ * try-with-resources. Collaborates with {@link ByteBufferReferencing} to
ensure final dereference
+ * returns the {@link ByteBuffer} to the pool.
+ */
+class ByteBufferSharingImpl implements ByteBufferSharing {
+
+ private final ByteBuffer buffer;
+ private final Lock lock;
+ private final ByteBufferReferencing referencing;
+
+ /**
+ * This constructor is for use only by the owner of the shared resource (a
{@link ByteBuffer}).
+ * Furthermore, this constructor is only for use in constructing the very
first {@link
+ * ByteBufferSharingImpl} for the resource. Subsequent instances must be
constructed via the copy
+ * constructor.
+ *
+ * A resource owner calls this constructor and retains the reference and
never hands it out.
+ * Instead, the owner hands out copies, constructed via the copy constructor.
+ *
+ * This constructor acquires no lock and does not modify the reference count
through the {@link
+ * ByteBufferReferencing} (passed in here.)
+ */
+ ByteBufferSharingImpl(final ByteBuffer buffer,
+ final ByteBufferReferencing referencing) {
+this(buffer, new ReentrantLock(), referencing);
+ }
+
+ /**
+ * This constructor is for use only by the owner of the shared resource.
It's used for handing out
+ * references to the shared resource. So it does reference counting and also
acquires a lock.
+ *
+ * Resource owners will typically return the result of this constructor, to
a caller. That caller
+ * binds that reference to a variable in a try-with-resources statement and
relies on the
+ * AutoCloseable protocol to invoke close() on the object at the end of the
block.
+ */
+ ByteBufferSharingImpl(final ByteBufferSharingImpl other) {
+this(other.buffer, other.lock, other.referencing);
+referencing.addReference();
+lock.lock();
+ }
+
+ private ByteBufferSharingImpl(final ByteBuffer buffer,
+ final Lock lock,
+ final ByteBufferReferencing referencing) {
+this.buffer = buffer;
+this.lock = lock;
+this.referencing = referencing;
+ }
+
+ @Override
+ public ByteBuffer getBuffer() {
+return buffer;
+ }
+
+ @Override
+ public void close() {
+final int usages = referencing.dropReference();
+if (usages > 0) {
+ /*
+ * We don't unlock when the very last usage goes away. The resource
owner holds the first
+ * usage and there is no lock associated with that one. Subsequent
usages have a lock and
+ * so require a corresponding unlock.
+ */
+ lock.unlock();
Review comment:
Talked to @dschneider-pivotal and we agreed this is not an issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Message transmission fails with IllegalStateException in socket i/o code
>
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Affects Versions:
[jira] [Assigned] (GEODE-8607) Add new API for getting oldest tombstone age.
[ https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade reassigned GEODE-8607: Assignee: Mark Hanson > Add new API for getting oldest tombstone age. > - > > Key: GEODE-8607 > URL: https://issues.apache.org/jira/browse/GEODE-8607 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Mark Hanson >Assignee: Mark Hanson >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > It would be handy in diagnosing certain issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8607) Add new API for getting oldest tombstone age.
[ https://issues.apache.org/jira/browse/GEODE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade updated GEODE-8607: - Labels: GeodeOperationAPI pull-request-available (was: pull-request-available) > Add new API for getting oldest tombstone age. > - > > Key: GEODE-8607 > URL: https://issues.apache.org/jira/browse/GEODE-8607 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Mark Hanson >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > It would be handy in diagnosing certain issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216912#comment-17216912 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216908#comment-17216908 ] ASF GitHub Bot commented on GEODE-7864: --- DonalEvans merged pull request #5582: URL: https://github.com/apache/geode/pull/5582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code
[
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216944#comment-17216944
]
ASF GitHub Bot commented on GEODE-8584:
---
dschneider-pivotal commented on a change in pull request #5638:
URL: https://github.com/apache/geode/pull/5638#discussion_r507920984
##
File path:
geode-core/src/main/java/org/apache/geode/internal/net/ByteBufferSharingImpl.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.net;
+
+import java.nio.ByteBuffer;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * An {@link AutoCloseable} meant to be acquired in a try-with-resources
statement. The resource (a
+ * {@link ByteBuffer}) is available (for reading and modification) in the
scope of the
+ * try-with-resources. Collaborates with {@link ByteBufferReferencing} to
ensure final dereference
+ * returns the {@link ByteBuffer} to the pool.
+ */
+class ByteBufferSharingImpl implements ByteBufferSharing {
+
+ private final ByteBuffer buffer;
+ private final Lock lock;
+ private final ByteBufferReferencing referencing;
+
+ /**
+ * This constructor is for use only by the owner of the shared resource (a
{@link ByteBuffer}).
+ * Furthermore, this constructor is only for use in constructing the very
first {@link
+ * ByteBufferSharingImpl} for the resource. Subsequent instances must be
constructed via the copy
+ * constructor.
+ *
+ * A resource owner calls this constructor and retains the reference and
never hands it out.
+ * Instead, the owner hands out copies, constructed via the copy constructor.
+ *
+ * This constructor acquires no lock and does not modify the reference count
through the {@link
+ * ByteBufferReferencing} (passed in here.)
+ */
+ ByteBufferSharingImpl(final ByteBuffer buffer,
+ final ByteBufferReferencing referencing) {
+this(buffer, new ReentrantLock(), referencing);
+ }
+
+ /**
+ * This constructor is for use only by the owner of the shared resource.
It's used for handing out
+ * references to the shared resource. So it does reference counting and also
acquires a lock.
+ *
+ * Resource owners will typically return the result of this constructor, to
a caller. That caller
+ * binds that reference to a variable in a try-with-resources statement and
relies on the
+ * AutoCloseable protocol to invoke close() on the object at the end of the
block.
+ */
+ ByteBufferSharingImpl(final ByteBufferSharingImpl other) {
Review comment:
Always creating a new instance at the start of try-with-resources is not
needed. In the case of this object I think it would be okay for the same
instance to be used by multiple threads concurrently and each one to call close
concurrently on the same instance. If so this would address Jakes concern about
object allocation.
##
File path:
geode-core/src/main/java/org/apache/geode/internal/net/ByteBufferSharingImpl.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.net;
+
+import java.nio.ByteBuffer;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * An {@link AutoCloseable} meant to be acquired in a try-with-resources
statement. The resource (a
+ * {@link
[jira] [Commented] (GEODE-8620) Actual redundancy of -1 in restore redundancy result
[ https://issues.apache.org/jira/browse/GEODE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216906#comment-17216906 ] ASF GitHub Bot commented on GEODE-8620: --- DonalEvans opened a new pull request #5642: URL: https://github.com/apache/geode/pull/5642 Authored-by: Donal Evans Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Actual redundancy of -1 in restore redundancy result > > > Key: GEODE-8620 > URL: https://issues.apache.org/jira/browse/GEODE-8620 > Project: Geode > Issue Type: Bug > Components: gfsh, management >Affects Versions: 1.13.0 >Reporter: Aaron Lindsey >Assignee: Donal Evans >Priority: Major > > Steps to reproduce: > # Create a geode cluster with 1 locator and 2 servers. > # Create a region of type PARTITION_REDUNDANT. > # Put an entry into the region. > # Trigger a restore redundancy operation via the management REST API or gfsh. > # The result from the restore redundancy operation states that the actual > redundancy for the region is -1. However, the expected redundancy at this > point is 1 because there should be enough cache servers in the cluster to > hold the redundant copy. > # Stop one of the servers. > # Trigger another restore redundancy operation via the management REST API > or gfsh. > # The result from the second restore redundancy operation again states that > the actual redundancy for the region is -1. However, the region should be > counted as having zero redundant copies at this point because there is only > one cache server. > I encountered this issue while using the management REST API, although the > same issue happens in the gfsh command. I assume fixing the gfsh command > would also fix the management REST API. If not, I can break this out into two > separate JIRAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216911#comment-17216911 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216914#comment-17216914 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216922#comment-17216922 ] ASF subversion and git services commented on GEODE-7864: Commit 02ffbceba8b58a2c7864b6756a2e18f08e9ddf69 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=02ffbce ] GEODE-7864: Fix potential resource leak LGTM warnings (#5582) * GEODE-7864: Fix potential resource leak LGTM warnings Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8620) Actual redundancy of -1 in restore redundancy result
[ https://issues.apache.org/jira/browse/GEODE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217133#comment-17217133 ] ASF GitHub Bot commented on GEODE-8620: --- DonalEvans merged pull request #5642: URL: https://github.com/apache/geode/pull/5642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Actual redundancy of -1 in restore redundancy result > > > Key: GEODE-8620 > URL: https://issues.apache.org/jira/browse/GEODE-8620 > Project: Geode > Issue Type: Bug > Components: gfsh, management >Affects Versions: 1.13.0 >Reporter: Aaron Lindsey >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > > Steps to reproduce: > # Create a geode cluster with 1 locator and 2 servers. > # Create a region of type PARTITION_REDUNDANT. > # Put an entry into the region. > # Trigger a restore redundancy operation via the management REST API or gfsh. > # The result from the restore redundancy operation states that the actual > redundancy for the region is -1. However, the expected redundancy at this > point is 1 because there should be enough cache servers in the cluster to > hold the redundant copy. > # Stop one of the servers. > # Trigger another restore redundancy operation via the management REST API > or gfsh. > # The result from the second restore redundancy operation again states that > the actual redundancy for the region is -1. However, the region should be > counted as having zero redundant copies at this point because there is only > one cache server. > I encountered this issue while using the management REST API, although the > same issue happens in the gfsh command. I assume fixing the gfsh command > would also fix the management REST API. If not, I can break this out into two > separate JIRAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8620) Actual redundancy of -1 in restore redundancy result
[ https://issues.apache.org/jira/browse/GEODE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217136#comment-17217136 ] ASF subversion and git services commented on GEODE-8620: Commit 505eb3af1f61edd8dff9e199104c72987ef281ab in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=505eb3a ] GEODE-8620: Do not include non-created buckets in redundancy calculation (#5642) Authored-by: Donal Evans > Actual redundancy of -1 in restore redundancy result > > > Key: GEODE-8620 > URL: https://issues.apache.org/jira/browse/GEODE-8620 > Project: Geode > Issue Type: Bug > Components: gfsh, management >Affects Versions: 1.13.0 >Reporter: Aaron Lindsey >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > > Steps to reproduce: > # Create a geode cluster with 1 locator and 2 servers. > # Create a region of type PARTITION_REDUNDANT. > # Put an entry into the region. > # Trigger a restore redundancy operation via the management REST API or gfsh. > # The result from the restore redundancy operation states that the actual > redundancy for the region is -1. However, the expected redundancy at this > point is 1 because there should be enough cache servers in the cluster to > hold the redundant copy. > # Stop one of the servers. > # Trigger another restore redundancy operation via the management REST API > or gfsh. > # The result from the second restore redundancy operation again states that > the actual redundancy for the region is -1. However, the region should be > counted as having zero redundant copies at this point because there is only > one cache server. > I encountered this issue while using the management REST API, although the > same issue happens in the gfsh command. I assume fixing the gfsh command > would also fix the management REST API. If not, I can break this out into two > separate JIRAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8620) Actual redundancy of -1 in restore redundancy result
[ https://issues.apache.org/jira/browse/GEODE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217135#comment-17217135 ] ASF subversion and git services commented on GEODE-8620: Commit 505eb3af1f61edd8dff9e199104c72987ef281ab in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=505eb3a ] GEODE-8620: Do not include non-created buckets in redundancy calculation (#5642) Authored-by: Donal Evans > Actual redundancy of -1 in restore redundancy result > > > Key: GEODE-8620 > URL: https://issues.apache.org/jira/browse/GEODE-8620 > Project: Geode > Issue Type: Bug > Components: gfsh, management >Affects Versions: 1.13.0 >Reporter: Aaron Lindsey >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > > Steps to reproduce: > # Create a geode cluster with 1 locator and 2 servers. > # Create a region of type PARTITION_REDUNDANT. > # Put an entry into the region. > # Trigger a restore redundancy operation via the management REST API or gfsh. > # The result from the restore redundancy operation states that the actual > redundancy for the region is -1. However, the expected redundancy at this > point is 1 because there should be enough cache servers in the cluster to > hold the redundant copy. > # Stop one of the servers. > # Trigger another restore redundancy operation via the management REST API > or gfsh. > # The result from the second restore redundancy operation again states that > the actual redundancy for the region is -1. However, the region should be > counted as having zero redundant copies at this point because there is only > one cache server. > I encountered this issue while using the management REST API, although the > same issue happens in the gfsh command. I assume fixing the gfsh command > would also fix the management REST API. If not, I can break this out into two > separate JIRAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8631) CI failure: PRClientServerRegionFunctionExecutionSingleHopDUnitTest > testServerPutAllFunction[ExecuteFunctionByObject] FAILED
Owen Nichols created GEODE-8631: --- Summary: CI failure: PRClientServerRegionFunctionExecutionSingleHopDUnitTest > testServerPutAllFunction[ExecuteFunctionByObject] FAILED Key: GEODE-8631 URL: https://issues.apache.org/jira/browse/GEODE-8631 Project: Geode Issue Type: Bug Components: core Affects Versions: 1.14.0 Reporter: Owen Nichols -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8631) CI failure: PRClientServerRegionFunctionExecutionSingleHopDUnitTest > testServerPutAllFunction[ExecuteFunctionByObject] FAILED
[ https://issues.apache.org/jira/browse/GEODE-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217089#comment-17217089 ] Geode Integration commented on GEODE-8631: -- Seen in [DistributedTestOpenJDK11 #528|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/528] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0423/test-results/distributedTest/1603135495/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0423/test-artifacts/1603135495/distributedtestfiles-OpenJDK11-1.14.0-build.0423.tgz]. > CI failure: PRClientServerRegionFunctionExecutionSingleHopDUnitTest > > testServerPutAllFunction[ExecuteFunctionByObject] FAILED > -- > > Key: GEODE-8631 > URL: https://issues.apache.org/jira/browse/GEODE-8631 > Project: Geode > Issue Type: Bug > Components: core >Affects Versions: 1.14.0 >Reporter: Owen Nichols >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6183) CI Failure: LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles failed with ConditionTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217085#comment-17217085 ] Geode Integration commented on GEODE-6183: -- Seen in [WindowsCoreIntegrationTestOpenJDK8 #508|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsCoreIntegrationTestOpenJDK8/builds/508] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0423/test-results/integrationTest/1603140922/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0423/test-artifacts/1603140922/windows-coreintegrationtestfiles-OpenJDK8-1.14.0-build.0423.tgz]. > CI Failure: > LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles failed > with ConditionTimeoutException > > > Key: GEODE-6183 > URL: https://issues.apache.org/jira/browse/GEODE-6183 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Eric Shu >Assignee: Kirk Lund >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > Test failed in > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/223 > org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > > startDeletesStaleControlFiles FAILED > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.distributed.LocatorLauncherRemoteIntegrationTestCase that > uses org.apache.geode.distributed.LocatorLauncher expected:<[online]> but > was:<[not responding]> within 300 seconds. > Caused by: > org.junit.ComparisonFailure: expected:<[online]> but was:<[not > responding]> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217095#comment-17217095
]
ASF subversion and git services commented on GEODE-8593:
Commit 6b92114bf1d43d69ff525857f31c29d8b6ae3032 in geode-native's branch
refs/heads/support/1.13 from Dave Barnes
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6b92114 ]
GEODE-8593: Update geode-native examples to use builder pattern: C++ (revisions)
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217103#comment-17217103
]
ASF subversion and git services commented on GEODE-8593:
Commit 29dd73b5ce0253ccd0865aecb0986b4a42aec741 in geode-native's branch
refs/heads/develop from Dave Barnes
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=29dd73b ]
GEODE-8593: Update geode-native examples to use builder pattern: C++ (revisions)
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7460) CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs ForcedDisconnectException Failure
[ https://issues.apache.org/jira/browse/GEODE-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217172#comment-17217172 ] Geode Integration commented on GEODE-7460: -- Seen in [DistributedTestOpenJDK11 #529|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/529] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0423/test-results/distributedTest/1603148318/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0423/test-artifacts/1603148318/distributedtestfiles-OpenJDK11-1.14.0-build.0423.tgz]. > CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs > ForcedDisconnectException Failure > --- > > Key: GEODE-7460 > URL: https://issues.apache.org/jira/browse/GEODE-7460 > Project: Geode > Issue Type: Bug > Components: membership >Affects Versions: 1.13.0, 1.14.0 >Reporter: Robert Houghton >Assignee: Bill Burcham >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > From the failing job: > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > http://files.apachegeode-ci.info/builds/apache-develop-main/1.12.0-SNAPSHOT.0016/test-results/distributedTest/1573784422/ > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > http://files.apachegeode-ci.info/builds/apache-develop-main/1.12.0-SNAPSHOT.0016/test-artifacts/1573784422/distributedtestfiles-OpenJDK8-1.12.0-SNAPSHOT.0016.tgz > DistributedTest failure due to exception: > org.apache.geode.distributed.DistributedMemberDUnitTest > testGroupsInAllVMs > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.distributed.DistributedMemberDUnitTest$6.run in VM 0 running > on Host 3e09f1029b44 with 4 VMs > at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:579) > at org.apache.geode.test.dunit.VM.invoke(VM.java:406) > at > org.apache.geode.distributed.DistributedMemberDUnitTest.testGroupsInAllVMs(DistributedMemberDUnitTest.java:333) > Caused by: > org.apache.geode.SystemConnectException: One or more peers generated > exceptions during connection attempt > at > org.apache.geode.distributed.internal.ClusterDistributionManager.sendStartupMessage(ClusterDistributionManager.java:1625) > at > org.apache.geode.distributed.internal.ClusterDistributionManager.create(ClusterDistributionManager.java:354) > at > org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:759) > at > org.apache.geode.distributed.internal.InternalDistributedSystem.access$200(InternalDistributedSystem.java:136) > at > org.apache.geode.distributed.internal.InternalDistributedSystem$Builder.build(InternalDistributedSystem.java:3009) > at > org.apache.geode.distributed.internal.InternalDistributedSystem.connectInternal(InternalDistributedSystem.java:269) > at > org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:159) > at > org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase.getSystem(JUnit4DistributedTestCase.java:181) > at > org.apache.geode.distributed.DistributedMemberDUnitTest$6.run(DistributedMemberDUnitTest.java:339) > Caused by: > > org.apache.geode.distributed.DistributedSystemDisconnectedException: > DistributedSystem is shutting down, caused by > org.apache.geode.ForcedDisconnectException: Exiting due to possible network > partition event due to loss of 1 cache processes: > [172.17.0.14(myName:1):41001] > at > org.apache.geode.distributed.internal.membership.adapter.GMSMembershipManager.directChannelSend(GMSMembershipManager.java:1591) > at > org.apache.geode.distributed.internal.membership.adapter.GMSMembershipManager.send(GMSMembershipManager.java:1751) > at > org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058) > at > org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1985) > at > org.apache.geode.distributed.internal.StartupOperation.sendStartupMessage(StartupOperation.java:74) > at > org.apache.geode.distributed.internal.ClusterDistributionManager.sendStartupMessage(ClusterDistributionManager.java:1622) > ... 8 more > Caused by: >
[jira] [Commented] (GEODE-7960) CI: SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion FAILED on Windows
[
https://issues.apache.org/jira/browse/GEODE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217171#comment-17217171
]
Geode Integration commented on GEODE-7960:
--
Seen in [WindowsUnitTestOpenJDK8
#513|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK8/builds/513]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0424/test-results/test/1603148479/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0424/test-artifacts/1603148479/windows-unittestfiles-OpenJDK8-1.14.0-build.0424.tgz].
> CI: SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion
> FAILED on Windows
>
>
> Key: GEODE-7960
> URL: https://issues.apache.org/jira/browse/GEODE-7960
> Project: Geode
> Issue Type: Bug
> Components: logging
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>Priority: Major
>
> Looks like a flaky test on windows:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/21
> {noformat}
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLoggerTest
> > logsMissingChildRegionUntilCompletion FAILED
> org.mockito.exceptions.verification.NoInteractionsWanted:
> No interactions wanted here:
> -> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion(SingleThreadColocationLoggerTest.java:180)
> But found this interaction on mock 'consumer':
> -> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLogger.logMissingRegions(SingleThreadColocationLogger.java:229)
> ***
> For your reference, here is the list of all invocations ([?] - means
> unverified).
> 1. -> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLogger.logMissingRegions(SingleThreadColocationLogger.java:229)
> 2. [?]-> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLogger.logMissingRegions(SingleThreadColocationLogger.java:229)
> at
> org.apache.geode.internal.cache.partitioned.colocation.SingleThreadColocationLoggerTest.logsMissingChildRegionUntilCompletion(SingleThreadColocationLoggerTest.java:180)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8466) Create a ClassLoaderService to abstract away dealing with the default ClassLoader directly
[ https://issues.apache.org/jira/browse/GEODE-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217182#comment-17217182 ] ASF GitHub Bot commented on GEODE-8466: --- lgtm-com[bot] commented on pull request #5548: URL: https://github.com/apache/geode/pull/5548#issuecomment-712521167 This pull request **introduces 3 alerts** and **fixes 1** when merging d80228410dd76454e5bf61553efabd32df5bafbc into 505eb3af1f61edd8dff9e199104c72987ef281ab - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-9646bdfcbac381a818210ba2828bafada3ecfac1) **new alerts:** * 2 for Potential input resource leak * 1 for Use of a broken or risky cryptographic algorithm **fixed alerts:** * 1 for Use of a broken or risky cryptographic algorithm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create a ClassLoaderService to abstract away dealing with the default > ClassLoader directly > -- > > Key: GEODE-8466 > URL: https://issues.apache.org/jira/browse/GEODE-8466 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > With the addition of ClassLoader isolation using JBoss Modules GEODE-8067, > the manner in which we interact with the ClassLoader needs to change. > An abstraction is required around the default functions like > `findResourceAsStream`, `loadClass` and `loadService`. > As these features will behave differently between different ClassLoader > implementations, it is best to have a single service that will expose that > functionality in a transparent manner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
