[jira] [Commented] (GEODE-72) Remove deprecated APIs from Geode

2015-08-20 Thread Darrel Schneider (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705272#comment-14705272
 ] 

Darrel Schneider commented on GEODE-72:
---

Cache.setGatewayHub(), getGatewayHub() no longer exist. Perhaps they were 
removed in the recent gateway code refactoring.

 Remove deprecated APIs from Geode
 -

 Key: GEODE-72
 URL: https://issues.apache.org/jira/browse/GEODE-72
 Project: Geode
  Issue Type: Improvement
Affects Versions: 1.0.0-incubating
Reporter: Bruce Schuchardt
  Labels: cleanup

 The Geode APIs are riddled with old, deprecated interfaces, methods and 
 settings inherited from GemFire.  Unless there is a good reason to keep them 
 shouldn't we remove them all before going out of incubation?
 Here are the things I could find that are marked as being deprecated:
 APIs deprecated in GemFire 4.2:
 * Cache.setGatewayHub(), getGatewayHub()
  
  
 APIs deprecated in GemFire 5.0:
 * AttributesMutator/AttributesFactory.setCacheListener()
 * AttributesFactory.createRegionAttributes()
 * RegionAttriubutes.getPersistBackup(), getEnableWAN(), getCacheListener(), 
 getEnableConflation() and associated methods in other classes (RegionFactory, 
 AttributesFactory, RegionAttributesCreation, RemoteRegionAttributes)
 * Cache.createVMRegion(), SystemMemberCache.createVMRegion()
 CacheEvent.isExpiration() and isDistributed()
 TransactionEvent.getXXXEvents()
 * EntryEvent.isLoad()/isLocalLoad()/isNetLoad()
 * MirrorType and associated methods and identifiers (also xml and various 
 javadocs)
 * CacheTransactionManager.getListener()/setListener()
 * AbstractRegion.setIgnoreJTA()
 * DistributedSystem.getId(), getMemberId()
  
   
 APIs deprecated in GemFire 5.1:
 * AcceptorImpl BridgeServer.SELECTOR, SELECTOR_POOL_SIZE, HANDSHAKE_POOL_SIZE 
 properties
 * DLS.lockInterruptibly(), suspendLockingInterruptibly()
  
 APIs deprecated in an undocumented version prior to 5.7:
 * Use of hostname:port to specify a locator in gemfire.properties
 * PartitionAttributesFactory.setLocalProperties(), setGlobalProperties()  
 property names (LOCAL_MAX_MEMORY_PROPERTY, etc), and corresponding stuff in 
 PartitionAttributes (5.2?)
 * PAF.setCacheLoader(), PartitionAttributes.getCacheLoader() (5.0?)
 * PartitionAttributes.getTotalSize()
 * class EntryNotFoundInRegion (5.0?)
 * Region.keys(), entries(),
 * AdminDistributedSystemFactory.bindToAddress()
 * MessageFactory, MsgOutputStream
  
 APIs deprecated in GemFire 5.7:
 * Endpoints in client/server, and associated classes 
 (BridgeLoader/Writer/Client,  EndpointExistsException, etc), BridgePoolImpl
 * BoundedLinkedHashMap and other cache.util utility classes no longer in use
 * BridgeServer (use CacheServer), Cache.addBridgeServer(), 
 Cache.getBridgeServers().  Also associated methods in AdminDistributedSystem, 
 SystemMemberCache, SystemMemberType, CacheServerConfig and 
 DistributedSystemConfig
 * ServerRefusedConnectionException (moved from util to client package)
 * EntryEvent.isBridgeEvent() and other places (InternalCacheEvent)
 * RegionAttriubutes.getEnableBridgeConflation(), and associated methods in 
 other classes (RegionFactory, AttributesFactory, RegionAttributesCreation, 
 CacheXmlParser, RemoteRegionAttributes)
 * DataSerializer.register(Class,byte)
 * The internal ForceDisconnectOperation, 
 AdminDistributedSystemJmxImpl.manageCacheServer(), manageCacheServers(), 
 SystemMemberCacheJmxImpl.manageBridgeServer(), manageBridgeServers()
  
 APIs deprecated after GemFire 5.7 and before 8.0
 * The com.gemstone.gemfire.admin and admin.jmx packages.  Some of the 
 implementation is in com.gemstone.gemfire.internal.remote.
 * DiskWriteAttributes, DiskWriteAttributesFactory and associated methods
 * DiskDirs and associated methods
 * DiskDirSizes and associated methods
 * AttributesFactory and associated methods
 * Cache.close(boolean), Cache.createRegion(String, RegionAttributes), 
 Cache.getLoggerI18n() and getSecurityLoggerI18n(), Cache.readyForEvents()
 * CacheFactory.create()
 * ClientNotReadyException
 * CommitConflictException, CommitDistributionException, 
 CommitIncompleteException (7.0)
 * RemoteTransactionException (6.6)
 * DataPolicy.isEmpty(), and the other is() methods
 * EntryOperation.getOperation() (both introduced and deprecated in 6.0)
 * EvictionAlgorithm.LIFO_ENTRY, LIFO_MEMORY
 * Execution.execute(String, boolean), execute(String, boolean, boolean), 
 execute(String, boolean, boolean, boolean)
 * FunctionService.onMember(DistributedSystem, DistributedMember), 
 onMembers(DistributedSystem), onMembers(DistributedSystem, 
 SetDistributedMember)
 * IndexType
 * Query.compile(), isCompiled()
 * QueryService.createIndex() variants, getIndexes()
 * Region.loadSnapshot(), saveSnapshot() (7.0)
 * Region.createSubRegion() (7.0)
 * 

[jira] [Resolved] (GEODE-213) JMX -http manager treats start gateway-sender as start gateway-receiver

2015-08-20 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-213.
-
   Resolution: Fixed
Fix Version/s: 1.0.0-incubating

Merged in PR #15 and created a new unit test to confirm bug and fix.

 JMX -http manager treats start gateway-sender as start gateway-receiver
 ---

 Key: GEODE-213
 URL: https://issues.apache.org/jira/browse/GEODE-213
 Project: Geode
  Issue Type: Bug
  Components: core
Affects Versions: 1.0.0-incubating
Reporter: Vitaliy Gavrilov
Assignee: Kirk Lund
 Fix For: 1.0.0-incubating


 WanCommandsControlle in method startGatewaySender builds up a command using 
 the string constant for gateway receiver instead of sender



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-234) remove deprecated MirrorType class

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-234:
--

 Summary: remove deprecated MirrorType class
 Key: GEODE-234
 URL: https://issues.apache.org/jira/browse/GEODE-234
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


All uses of MirrorType should be changed to use DataPolicy.REPLICATE.
All apis that take it as a parameter or return it need to be deleted.
The cache-9.0.xsd should also be changed to no longer have the mirror-type 
region-attribute.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GEODE-232) gfsh prints ERROR StatusLogger log4j2-cli.xml not found in file system or classpath

2015-08-20 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-232.
-
   Resolution: Fixed
Fix Version/s: 1.0.0-incubating

Bug and subsequent fix are verified by new tests.

 gfsh prints ERROR StatusLogger log4j2-cli.xml not found in file system or 
 classpath
 ---

 Key: GEODE-232
 URL: https://issues.apache.org/jira/browse/GEODE-232
 Project: Geode
  Issue Type: Bug
Reporter: Eric Shu
Assignee: Kirk Lund
Priority: Critical
 Fix For: 1.0.0-incubating


 ./open/gemfire-assembly/build/install/apache-geode/bin/gfsh
 ERROR StatusLogger File not found in file system or classpath: 
 /com/gemstone/gemfire/internal/logging/log4j/log4j2-cli.xml
 ERROR StatusLogger No log4j2 configuration file found. Using default 
 configuration: logging only errors to the console.
 _ __
/ _/ __/ __/ // /
   / /  __/ /___  /_  / _  / 
  / /__/ / /  _/ / // /  
 /__/_/  /__/_//_/v1.0.0-incubating-SNAPSHOT
 Monitor and Manage GemFire
 gfsh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-244) RebalanceOperationDUnitTest testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion

2015-08-20 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-244:

Description: 
RebalanceOperationDUnitTest 
testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion in 
nightly build #190:
{color:red}
{noformat}
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest  
testRecoverRedundancyParallelAsyncEventQueueSimulation FAILED
dunit.RMIException: While invoking 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest$43.run 
in VM 0 running on Host jenkins-ubuntu-1404-4gb-f59 with 4 VMs
at dunit.VM.invoke(VM.java:359)
at dunit.VM.invoke(VM.java:303)
at dunit.VM.invoke(VM.java:257)
at 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.recoverRedundancyParallelAsyncEventQueue(RebalanceOperationDUnitTest.java:1148)
at 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.testRecoverRedundancyParallelAsyncEventQueueSimulation(RebalanceOperationDUnitTest.java:1090)

Caused by:
junit.framework.AssertionFailedError: expected:6 but was:4
{noformat}
{color}

  was:
RebalanceOperationDUnitTest 
testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion in 
nightly build #190:
{color:red}
{{
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest  
testRecoverRedundancyParallelAsyncEventQueueSimulation FAILED
dunit.RMIException: While invoking 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest$43.run 
in VM 0 running on Host jenkins-ubuntu-1404-4gb-f59 with 4 VMs
at dunit.VM.invoke(VM.java:359)
at dunit.VM.invoke(VM.java:303)
at dunit.VM.invoke(VM.java:257)
at 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.recoverRedundancyParallelAsyncEventQueue(RebalanceOperationDUnitTest.java:1148)
at 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.testRecoverRedundancyParallelAsyncEventQueueSimulation(RebalanceOperationDUnitTest.java:1090)

Caused by:
junit.framework.AssertionFailedError: expected:6 but was:4
}}
{color}


 RebalanceOperationDUnitTest 
 testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion
 --

 Key: GEODE-244
 URL: https://issues.apache.org/jira/browse/GEODE-244
 Project: Geode
  Issue Type: Bug
Affects Versions: 1.0.0-incubating
Reporter: Kirk Lund

 RebalanceOperationDUnitTest 
 testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion in 
 nightly build #190:
 {color:red}
 {noformat}
 com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest  
 testRecoverRedundancyParallelAsyncEventQueueSimulation FAILED
 dunit.RMIException: While invoking 
 com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest$43.run
  in VM 0 running on Host jenkins-ubuntu-1404-4gb-f59 with 4 VMs
 at dunit.VM.invoke(VM.java:359)
 at dunit.VM.invoke(VM.java:303)
 at dunit.VM.invoke(VM.java:257)
 at 
 com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.recoverRedundancyParallelAsyncEventQueue(RebalanceOperationDUnitTest.java:1148)
 at 
 com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.testRecoverRedundancyParallelAsyncEventQueueSimulation(RebalanceOperationDUnitTest.java:1090)
 Caused by:
 junit.framework.AssertionFailedError: expected:6 but was:4
 {noformat}
 {color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-244) RebalanceOperationDUnitTest testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion

2015-08-20 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-244:
---

 Summary: RebalanceOperationDUnitTest 
testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion
 Key: GEODE-244
 URL: https://issues.apache.org/jira/browse/GEODE-244
 Project: Geode
  Issue Type: Bug
Affects Versions: 1.0.0-incubating
Reporter: Kirk Lund


RebalanceOperationDUnitTest 
testRecoverRedundancyParallelAsyncEventQueueSimulation failed an assertion in 
nightly build #190:
{color:red}
{{
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest  
testRecoverRedundancyParallelAsyncEventQueueSimulation FAILED
dunit.RMIException: While invoking 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest$43.run 
in VM 0 running on Host jenkins-ubuntu-1404-4gb-f59 with 4 VMs
at dunit.VM.invoke(VM.java:359)
at dunit.VM.invoke(VM.java:303)
at dunit.VM.invoke(VM.java:257)
at 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.recoverRedundancyParallelAsyncEventQueue(RebalanceOperationDUnitTest.java:1148)
at 
com.gemstone.gemfire.internal.cache.control.RebalanceOperationDUnitTest.testRecoverRedundancyParallelAsyncEventQueueSimulation(RebalanceOperationDUnitTest.java:1090)

Caused by:
junit.framework.AssertionFailedError: expected:6 but was:4
}}
{color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-232) gfsh prints ERROR StatusLogger log4j2-cli.xml not found in file system or classpath

2015-08-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706199#comment-14706199
 ] 

ASF subversion and git services commented on GEODE-232:
---

Commit 19732b2d8060c5707448364d998ba287ccd9f727 in incubator-geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=19732b2 ]

GEODE-232: Convert resource string to URI string for log4j2-cli.xml

Add lots of new unit and integration tests for LogService.


 gfsh prints ERROR StatusLogger log4j2-cli.xml not found in file system or 
 classpath
 ---

 Key: GEODE-232
 URL: https://issues.apache.org/jira/browse/GEODE-232
 Project: Geode
  Issue Type: Bug
Reporter: Eric Shu
Assignee: Kirk Lund
Priority: Critical

 ./open/gemfire-assembly/build/install/apache-geode/bin/gfsh
 ERROR StatusLogger File not found in file system or classpath: 
 /com/gemstone/gemfire/internal/logging/log4j/log4j2-cli.xml
 ERROR StatusLogger No log4j2 configuration file found. Using default 
 configuration: logging only errors to the console.
 _ __
/ _/ __/ __/ // /
   / /  __/ /___  /_  / _  / 
  / /__/ / /  _/ / // /  
 /__/_/  /__/_//_/v1.0.0-incubating-SNAPSHOT
 Monitor and Manage GemFire
 gfsh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-239) Remove deprecated region creation methods

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-239:
--

 Summary: Remove deprecated region creation methods
 Key: GEODE-239
 URL: https://issues.apache.org/jira/browse/GEODE-239
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


createVMRegion and createRegion can both be removed on Cache and replaced with 
createRegionFactory().create().

This should be a pretty simple change to make but may be a bit more work since 
the parameters passed to the old method are split up between 
createRegionFactory and its create method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-243) Remove the old client/server bridge classes

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-243:
--

 Summary: Remove the old client/server bridge classes
 Key: GEODE-243
 URL: https://issues.apache.org/jira/browse/GEODE-243
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


The following classes should be removed. They were part of a very old 
client/server implementation that has been replaced by pools.

- com.gemstone.gemfire.cache.util.BridgeClient
- com.gemstone.gemfire.cache.util.BridgeLoader
- com.gemstone.gemfire.cache.util.BridgeWriter
- com.gemstone.gemfire.cache.util.BridgeServer
- com.gemstone.gemfire.cache.util.BridgeMembership
- com.gemstone.gemfire.cache.util.BridgeMembershipEvent
- com.gemstone.gemfire.cache.util.BridgeMembershipListener
- com.gemstone.gemfire.cache.util.BridgeMembershipListenerAdapter
- com.gemstone.gemfire.cache.util.BridgeWriterException
- com.gemstone.gemfire.cache.util.EndpointDoesNotExistException
- com.gemstone.gemfire.cache.util.EndpointException
- com.gemstone.gemfire.cache.util.EndpointExistsException
- com.gemstone.gemfire.cache.util.EndpointInUseException

unit tests may still exist that test this older implementation. They can be 
removed since a corresponding test using pools also exists.

This task may be more work and it would be wise to have someone who understands 
the old code involved in removing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-241) Remove deprecated listener methods on CacheTransactionManager

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-241:
--

 Summary: Remove deprecated listener methods on 
CacheTransactionManager
 Key: GEODE-241
 URL: https://issues.apache.org/jira/browse/GEODE-241
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


CacheTransactionManager has a gettor and settor for listener. These need to 
be removed and callers converted over to use the listeners methods: 
getListeners, addListener, removeListener, and initListeners.

Pretty simple task but requires a large number of unit test changes.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-238) Remove deprecated RegionAttributes

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-238:
--

 Summary: Remove deprecated RegionAttributes
 Key: GEODE-238
 URL: https://issues.apache.org/jira/browse/GEODE-238
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


The following RegionAttributes are deprecated and need to be removed.
The show up in a number of difference classes (RegionAttributes, CacheFactory, 
AttributesFactory, RegionAttributesCreation, RemoteRegionAttributes) and they 
are also in the cache-9.0.xsd in the region-attributes element.
They are:
- cache-listener: no xsd work needed. The apis now support multiple listeners. 
See also GEODE-231
- persist-backup: use one of the persistent DataPolicy instances
- disk-write-attributes: use disk-store instead
- disk-dirs: use disk-store instead
- disk-dir-sizes: use disk-store instead
- early-ack: feature was removed so just delete these methods
- publisher: feature was removed so just delete these methods
- enable-conflation: use enable-subscription-conflation instead
- enable-bridge-conflation: use enable-subscription-conflation instead

This issue will be more work since it involves more tests, xml changes, and 
some of the changes are not simple substitutions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-240) Remove deprecated methods on TransactionEvent

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-240:
--

 Summary: Remove deprecated methods on TransactionEvent
 Key: GEODE-240
 URL: https://issues.apache.org/jira/browse/GEODE-240
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


The following methods should all be deleted from TransactionEvent and callers 
should be changed to instead use getEvents. The caller may have to do its own 
filtering on getEvents to find the event(s) it is interested in.
- getCreateEvents
- getDestroyEvents
- getPutEvents
- getInvalidateEvents

Some of the existing unit tests depend on the filtering done by these methods 
so that filtering will need to move to some test util methods.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-232) gfsh prints ERROR StatusLogger log4j2-cli.xml not found in file system or classpath

2015-08-20 Thread Anthony Baker (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705749#comment-14705749
 ] 

Anthony Baker commented on GEODE-232:
-

I'm running from the product tree and see this issue:

{noformat}
Anthony-Baker-MacBook-Pro:~ abaker$ cd 
code/incubator-geode/gemfire-assembly/build/install/apache-geode/
Anthony-Baker-MacBook-Pro:apache-geode abaker$ bin/gfsh
ERROR StatusLogger File not found in file system or classpath: 
/com/gemstone/gemfire/internal/logging/log4j/log4j2-cli.xml
ERROR StatusLogger No log4j2 configuration file found. Using default 
configuration: logging only errors to the console.
_ __
   / _/ __/ __/ // /
  / /  __/ /___  /_  / _  / 
 / /__/ / /  _/ / // /  
/__/_/  /__/_//_/v1.0.0-incubating-SNAPSHOT

Monitor and Manage GemFire
gfsh
{noformat}

I think the relative path lookup for {{../library}} should be enhanced to based 
on the location of the {{gfsh}} script not the {{$PWD}}.

 gfsh prints ERROR StatusLogger log4j2-cli.xml not found in file system or 
 classpath
 ---

 Key: GEODE-232
 URL: https://issues.apache.org/jira/browse/GEODE-232
 Project: Geode
  Issue Type: Bug
Reporter: Eric Shu
Assignee: Kirk Lund
Priority: Critical

 ./open/gemfire-assembly/build/install/apache-geode/bin/gfsh
 ERROR StatusLogger File not found in file system or classpath: 
 /com/gemstone/gemfire/internal/logging/log4j/log4j2-cli.xml
 ERROR StatusLogger No log4j2 configuration file found. Using default 
 configuration: logging only errors to the console.
 _ __
/ _/ __/ __/ // /
   / /  __/ /___  /_  / _  / 
  / /__/ / /  _/ / // /  
 /__/_/  /__/_//_/v1.0.0-incubating-SNAPSHOT
 Monitor and Manage GemFire
 gfsh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-72) Remove deprecated APIs from Geode

2015-08-20 Thread Darrel Schneider (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705711#comment-14705711
 ] 

Darrel Schneider commented on GEODE-72:
---

In phase one of this issue I think we should focus on removing deprecated 
features from the external apis.
We should save things in internal packages (for example 
LocalRegion.notifyToRoll and AbstractRegion.setIgnoreJTA) for phase two.


 Remove deprecated APIs from Geode
 -

 Key: GEODE-72
 URL: https://issues.apache.org/jira/browse/GEODE-72
 Project: Geode
  Issue Type: Improvement
Affects Versions: 1.0.0-incubating
Reporter: Bruce Schuchardt
  Labels: cleanup

 The Geode APIs are riddled with old, deprecated interfaces, methods and 
 settings inherited from GemFire.  Unless there is a good reason to keep them 
 shouldn't we remove them all before going out of incubation?
 Here are the things I could find that are marked as being deprecated:
 APIs deprecated in GemFire 4.2:
 * Cache.setGatewayHub(), getGatewayHub()
  
  
 APIs deprecated in GemFire 5.0:
 * AttributesMutator/AttributesFactory.setCacheListener()
 * AttributesFactory.createRegionAttributes()
 * RegionAttriubutes.getPersistBackup(), getEnableWAN(), getCacheListener(), 
 getEnableConflation() and associated methods in other classes (RegionFactory, 
 AttributesFactory, RegionAttributesCreation, RemoteRegionAttributes)
 * Cache.createVMRegion(), SystemMemberCache.createVMRegion()
 CacheEvent.isExpiration() and isDistributed()
 TransactionEvent.getXXXEvents()
 * EntryEvent.isLoad()/isLocalLoad()/isNetLoad()
 * MirrorType and associated methods and identifiers (also xml and various 
 javadocs)
 * CacheTransactionManager.getListener()/setListener()
 * AbstractRegion.setIgnoreJTA()
 * DistributedSystem.getId(), getMemberId()
  
   
 APIs deprecated in GemFire 5.1:
 * AcceptorImpl BridgeServer.SELECTOR, SELECTOR_POOL_SIZE, HANDSHAKE_POOL_SIZE 
 properties
 * DLS.lockInterruptibly(), suspendLockingInterruptibly()
  
 APIs deprecated in an undocumented version prior to 5.7:
 * Use of hostname:port to specify a locator in gemfire.properties
 * PartitionAttributesFactory.setLocalProperties(), setGlobalProperties()  
 property names (LOCAL_MAX_MEMORY_PROPERTY, etc), and corresponding stuff in 
 PartitionAttributes (5.2?)
 * PAF.setCacheLoader(), PartitionAttributes.getCacheLoader() (5.0?)
 * PartitionAttributes.getTotalSize()
 * class EntryNotFoundInRegion (5.0?)
 * Region.keys(), entries(),
 * AdminDistributedSystemFactory.bindToAddress()
 * MessageFactory, MsgOutputStream
  
 APIs deprecated in GemFire 5.7:
 * Endpoints in client/server, and associated classes 
 (BridgeLoader/Writer/Client,  EndpointExistsException, etc), BridgePoolImpl
 * BoundedLinkedHashMap and other cache.util utility classes no longer in use
 * BridgeServer (use CacheServer), Cache.addBridgeServer(), 
 Cache.getBridgeServers().  Also associated methods in AdminDistributedSystem, 
 SystemMemberCache, SystemMemberType, CacheServerConfig and 
 DistributedSystemConfig
 * ServerRefusedConnectionException (moved from util to client package)
 * EntryEvent.isBridgeEvent() and other places (InternalCacheEvent)
 * RegionAttriubutes.getEnableBridgeConflation(), and associated methods in 
 other classes (RegionFactory, AttributesFactory, RegionAttributesCreation, 
 CacheXmlParser, RemoteRegionAttributes)
 * DataSerializer.register(Class,byte)
 * The internal ForceDisconnectOperation, 
 AdminDistributedSystemJmxImpl.manageCacheServer(), manageCacheServers(), 
 SystemMemberCacheJmxImpl.manageBridgeServer(), manageBridgeServers()
  
 APIs deprecated after GemFire 5.7 and before 8.0
 * The com.gemstone.gemfire.admin and admin.jmx packages.  Some of the 
 implementation is in com.gemstone.gemfire.internal.remote.
 * DiskWriteAttributes, DiskWriteAttributesFactory and associated methods
 * DiskDirs and associated methods
 * DiskDirSizes and associated methods
 * AttributesFactory and associated methods
 * Cache.close(boolean), Cache.createRegion(String, RegionAttributes), 
 Cache.getLoggerI18n() and getSecurityLoggerI18n(), Cache.readyForEvents()
 * CacheFactory.create()
 * ClientNotReadyException
 * CommitConflictException, CommitDistributionException, 
 CommitIncompleteException (7.0)
 * RemoteTransactionException (6.6)
 * DataPolicy.isEmpty(), and the other is() methods
 * EntryOperation.getOperation() (both introduced and deprecated in 6.0)
 * EvictionAlgorithm.LIFO_ENTRY, LIFO_MEMORY
 * Execution.execute(String, boolean), execute(String, boolean, boolean), 
 execute(String, boolean, boolean, boolean)
 * FunctionService.onMember(DistributedSystem, DistributedMember), 
 onMembers(DistributedSystem), onMembers(DistributedSystem, 
 SetDistributedMember)
 * IndexType
 * Query.compile(), isCompiled()
 * QueryService.createIndex() 

[jira] [Updated] (GEODE-72) Remove deprecated APIs from Geode

2015-08-20 Thread Darrel Schneider (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider updated GEODE-72:
--
Description: 
The Geode APIs are riddled with old, deprecated interfaces, methods and 
settings inherited from GemFire.  Unless there is a good reason to keep them 
shouldn't we remove them all before going out of incubation?

Here are the things I could find that are marked as being deprecated:


APIs deprecated in GemFire 4.2:
* Cache.setGatewayHub(), getGatewayHub()
 
 
APIs deprecated in GemFire 5.0:
* AttributesMutator/AttributesFactory.setCacheListener()
* AttributesFactory.createRegionAttributes()
* RegionAttributes.getPersistBackup(), getEnableWAN(), getCacheListener(), 
getEnableConflation() and associated methods in other classes (RegionFactory, 
AttributesFactory, RegionAttributesCreation, RemoteRegionAttributes)
* Cache.createVMRegion(), SystemMemberCache.createVMRegion()
CacheEvent.isExpiration() and isDistributed()
TransactionEvent.getXXXEvents()
* EntryEvent.isLoad()/isLocalLoad()/isNetLoad()
* MirrorType and associated methods and identifiers (also xml and various 
javadocs)
* CacheTransactionManager.getListener()/setListener()
* AbstractRegion.setIgnoreJTA()
* DistributedSystem.getId(), getMemberId()
 
  
APIs deprecated in GemFire 5.1:
* AcceptorImpl BridgeServer.SELECTOR, SELECTOR_POOL_SIZE, HANDSHAKE_POOL_SIZE 
properties
* DLS.lockInterruptibly(), suspendLockingInterruptibly()
 
APIs deprecated in an undocumented version prior to 5.7:
* Use of hostname:port to specify a locator in gemfire.properties
* PartitionAttributesFactory.setLocalProperties(), setGlobalProperties()  
property names (LOCAL_MAX_MEMORY_PROPERTY, etc), and corresponding stuff in 
PartitionAttributes (5.2?)
* PAF.setCacheLoader(), PartitionAttributes.getCacheLoader() (5.0?)
* PartitionAttributes.getTotalSize()
* class EntryNotFoundInRegion (5.0?)
* Region.keys(), entries(),
* AdminDistributedSystemFactory.bindToAddress()
* MessageFactory, MsgOutputStream
 
APIs deprecated in GemFire 5.7:
* Endpoints in client/server, and associated classes 
(BridgeLoader/Writer/Client,  EndpointExistsException, etc), BridgePoolImpl
* BoundedLinkedHashMap and other cache.util utility classes no longer in use
* BridgeServer (use CacheServer), Cache.addBridgeServer(), 
Cache.getBridgeServers().  Also associated methods in AdminDistributedSystem, 
SystemMemberCache, SystemMemberType, CacheServerConfig and 
DistributedSystemConfig
* ServerRefusedConnectionException (moved from util to client package)
* EntryEvent.isBridgeEvent() and other places (InternalCacheEvent)
* RegionAttriubutes.getEnableBridgeConflation(), and associated methods in 
other classes (RegionFactory, AttributesFactory, RegionAttributesCreation, 
CacheXmlParser, RemoteRegionAttributes)
* DataSerializer.register(Class,byte)
* The internal ForceDisconnectOperation, 
AdminDistributedSystemJmxImpl.manageCacheServer(), manageCacheServers(), 
SystemMemberCacheJmxImpl.manageBridgeServer(), manageBridgeServers()
 
APIs deprecated after GemFire 5.7 and before 8.0
* The com.gemstone.gemfire.admin and admin.jmx packages.  Some of the 
implementation is in com.gemstone.gemfire.internal.remote.
* DiskWriteAttributes, DiskWriteAttributesFactory and associated methods
* DiskDirs and associated methods
* DiskDirSizes and associated methods
* AttributesFactory and associated methods
* Cache.close(boolean), Cache.createRegion(String, RegionAttributes), 
Cache.getLoggerI18n() and getSecurityLoggerI18n(), Cache.readyForEvents()
* CacheFactory.create()
* ClientNotReadyException
* CommitConflictException, CommitDistributionException, 
CommitIncompleteException (7.0)
* RemoteTransactionException (6.6)
* DataPolicy.isEmpty(), and the other is() methods
* EntryOperation.getOperation() (both introduced and deprecated in 6.0)
* EvictionAlgorithm.LIFO_ENTRY, LIFO_MEMORY
* Execution.execute(String, boolean), execute(String, boolean, boolean), 
execute(String, boolean, boolean, boolean)
* FunctionService.onMember(DistributedSystem, DistributedMember), 
onMembers(DistributedSystem), onMembers(DistributedSystem, 
SetDistributedMember)
* IndexType
* Query.compile(), isCompiled()
* QueryService.createIndex() variants, getIndexes()
* Region.loadSnapshot(), saveSnapshot() (7.0)
* Region.createSubRegion() (7.0)
* Region.getCache()
* CacheServer.DEFAULT_GROUPS, get/setGroups(), get/setNotifyBySubscription(), 
get/setOverflowDi
* RegionFactory constructors, RegionFactory.setEarlyAck(), 
RegionFactory.setEnableGateway(), setPublisher() 
* BridgeServer.get/setNotifyBySubscription()
* writeable-working-dir distribution property
* DistributedSystem.connect(), disconnect()
* Locator.startLocator(int, File), startLocator(int, File, InetAddress) etc.
* Locator.getLocators(), hasLocators()
* LocalRegion.notifyToRoll()
* ReflectionBasedAutoSerializer(ListString), setSerializableClasses()

APIs deprecated since 

[jira] [Created] (GEODE-235) EntryEvent toString should describe the region the event is on

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-235:
--

 Summary: EntryEvent toString should describe the region the event 
is on
 Key: GEODE-235
 URL: https://issues.apache.org/jira/browse/GEODE-235
 Project: Geode
  Issue Type: Improvement
Reporter: Darrel Schneider


When an EntryEvent gets logged it looks something like this:
{code}
Event=EntryEventImpl[op=CREATE;key=112;oldValue=null;newValue=VMCachedDeserializable@2009740363;callbackArg=null;originRemote=true;originMember=cc2-rh6v448:3889;callbacksInvoked;version={v1;
 rv1; mbr=cc2-rh6v449:50532; time=1439996558405; 
remote};id=EventID[threadID=61;sequenceID=389];isFromServer]
{code}

Given that every EntryEvent is also a CacheEvent which has a getRegion method 
we should also show the fully qualified region name for the event.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-236) Remove deprecated CacheEvent methods

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-236:
--

 Summary: Remove deprecated CacheEvent methods
 Key: GEODE-236
 URL: https://issues.apache.org/jira/browse/GEODE-236
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


The following methods need to be removed:
- CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration
- CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed

This should be a pretty easy task to complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-237) Remove EntryEvent deprecated methods

2015-08-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-237:
--

 Summary: Remove EntryEvent deprecated methods
 Key: GEODE-237
 URL: https://issues.apache.org/jira/browse/GEODE-237
 Project: Geode
  Issue Type: Sub-task
Reporter: Darrel Schneider


The following EntryEvent methods need to be removed:
- isLocalLoad: change to getOperation().isLocalLoad
- isNetLoad: change to getOperation().isNetLoad
- isLoad: change to getOperation().isLoad
- isNetSearch: change to getOperation().isNetSearch
- isBridgeEvent: change to hasClientOrigin

these should be pretty easy to change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)