[jira] [Commented] (GEODE-417) deprecated ssl-* gemfire properties should not be allowed with cluster-ssl-* properties

2016-03-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187403#comment-15187403
 ] 

ASF subversion and git services commented on GEODE-417:
---

Commit 6c74e5ab10295c4420c3d75694ab5e077c46e16e in incubator-geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6c74e5a ]

GEODE-417: deprecated ssl-* gemfire properties should not be allowed with 
cluster-ssl-* properties

Modified the verification code to only complain if corresponding properties
are both set and are not equal.  Modified the exception text to be (I believe)
grammatically correct.


> deprecated ssl-* gemfire properties should not be allowed with cluster-ssl-* 
> properties
> ---
>
> Key: GEODE-417
> URL: https://issues.apache.org/jira/browse/GEODE-417
> Project: Geode
>  Issue Type: Bug
>  Components: membership, security
>Reporter: Darrel Schneider
>Assignee: Bruce Schuchardt
>Priority: Minor
>
> The ssl-* gemfire properties were deprecated in 8.0 in favor of the 
> cluster-ssl-* properties. If you specify both then you are supposed to get an 
> error if they are not the same. But instead you only get the error if they 
> are both not equal to the default value. For the properties whose values are 
> String the equality check does an identity check against the default value 
> which will never be true. For the properties whose values are Boolean the 
> equality check is ok but the logic is wrong. It should be asking if both of 
> them were set to the same value; not if both of them are not equal to the 
> default.
> The same problem exists for jmx-manager-ssl which was deprecated in favor of 
> jmx-manager-ssl-enabled.
> Another related problem is that if you do get the exception it has a message 
> that says "...Prefer way is to use" which is bad english.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-417) deprecated ssl-* gemfire properties should not be allowed with cluster-ssl-* properties

2016-02-23 Thread Edin Zulich (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159484#comment-15159484
 ] 

Edin Zulich commented on GEODE-417:
---

Since these were deprecated in 8.0, it seems that they can be removed at this 
point.

> deprecated ssl-* gemfire properties should not be allowed with cluster-ssl-* 
> properties
> ---
>
> Key: GEODE-417
> URL: https://issues.apache.org/jira/browse/GEODE-417
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Bruce Schuchardt
>Priority: Minor
>
> The ssl-* gemfire properties were deprecated in 8.0 in favor of the 
> cluster-ssl-* properties. If you specify both then you are supposed to get an 
> error if they are not the same. But instead you only get the error if they 
> are both not equal to the default value. For the properties whose values are 
> String the equality check does an identity check against the default value 
> which will never be true. For the properties whose values are Boolean the 
> equality check is ok but the logic is wrong. It should be asking if both of 
> them were set to the same value; not if both of them are not equal to the 
> default.
> The same problem exists for jmx-manager-ssl which was deprecated in favor of 
> jmx-manager-ssl-enabled.
> Another related problem is that if you do get the exception it has a message 
> that says "...Prefer way is to use" which is bad english.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)