[jira] [Commented] (GEODE-93) Entry count stats are incorrect with PR with entry eviction and async disk
[ https://issues.apache.org/jira/browse/GEODE-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396030#comment-15396030 ] ASF subversion and git services commented on GEODE-93: -- Commit 9389c6fece1adb3e83bc7a8863a2d84f52bfc0fa in incubator-geode's branch refs/heads/develop from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9389c6f ] GEODE-1700: fix stat corrupting when async queue full A common method is now used for writing async ops to disk. The same method is now used for both flushing an item that has been taken out of the queue and for when the queue is full causing a sync write to be done. Also did a minor refactoring to get rid of the "removed" flag. This revision fixes a bug introduced in GEODE-93 and should be included with that fix. > Entry count stats are incorrect with PR with entry eviction and async disk > -- > > Key: GEODE-93 > URL: https://issues.apache.org/jira/browse/GEODE-93 > Project: Geode > Issue Type: Bug > Components: eviction >Reporter: Dan Smith >Assignee: Sai Boorlagadda > Fix For: 1.0.0-incubating.M3 > > Attachments: > 0001-Test-that-demonstrates-incorrect-entriesOnDisk-and-e.patch > > > I discovered this while writing a unit test for GEODE-56. It looks like when > doing operations on a PR with entry eviction of 1, overflow to disk, and > asynchronous persistence, the stats fo entries in memory and entries on disk > are incorrect. Entries in memory is too high and entriesOnDisk goes negative. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-93) Entry count stats are incorrect with PR with entry eviction and async disk
[ https://issues.apache.org/jira/browse/GEODE-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308657#comment-15308657 ] ASF subversion and git services commented on GEODE-93: -- Commit b55478387169d8f83989ad38d8cfdb6202d8b697 in incubator-geode's branch refs/heads/feature/GEODE-93 from [~sboorlagadda] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b554783 ] Merge branch 'develop' into feature/GEODE-93 > Entry count stats are incorrect with PR with entry eviction and async disk > -- > > Key: GEODE-93 > URL: https://issues.apache.org/jira/browse/GEODE-93 > Project: Geode > Issue Type: Bug > Components: eviction >Reporter: Dan Smith >Assignee: Sai Boorlagadda > Attachments: > 0001-Test-that-demonstrates-incorrect-entriesOnDisk-and-e.patch > > > I discovered this while writing a unit test for GEODE-56. It looks like when > doing operations on a PR with entry eviction of 1, overflow to disk, and > asynchronous persistence, the stats fo entries in memory and entries on disk > are incorrect. Entries in memory is too high and entriesOnDisk goes negative. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-93) Entry count stats are incorrect with PR with entry eviction and async disk
[ https://issues.apache.org/jira/browse/GEODE-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635870#comment-14635870 ] ASF subversion and git services commented on GEODE-93: -- Commit b8686b52b97f8cbe1b46df8cda81a5e2bbd4cfaf in incubator-geode's branch refs/heads/develop from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b8686b5 ] GEODE-56 Decrementing bytesOverflowedOnDisk when an update happens to an evicted entry. For persistent regions, we were correctly updating this stat. But for non persistent regions we did not read the old size on disk, so we were not updating the stat. If the entry was in the async queue, we only increment the stat once when the final value is actually written to disk. So we will only decrement the stat if the oldValue is not pending asynchronous write to disk. I'm still seeing issues with the entryCount. I've tracked this down to what I think is a problem with tombstones. It appears when we modify an entry that is a tombstone, we increment the entry count once for the new value, and once for removing the tombstone. I've filed GEODE-92 and GEODE-93 for the issues I've found with this new test. Entry count stats are incorrect with PR with entry eviction and async disk -- Key: GEODE-93 URL: https://issues.apache.org/jira/browse/GEODE-93 Project: Geode Issue Type: Bug Reporter: Dan Smith Attachments: 0001-Test-that-demonstrates-incorrect-entriesOnDisk-and-e.patch I discovered this while writing a unit test for GEODE-56. It looks like when doing operations on a PR with entry eviction of 1, overflow to disk, and asynchronous persistence, the stats fo entries in memory and entries on disk are incorrect. Entries in memory is too high and entriesOnDisk goes negative. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
