[jira] [Closed] (GUACAMOLE-809) Add documentation for the REST API

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman closed GUACAMOLE-809.
---
Resolution: Duplicate

> Add documentation for the REST API
> --
>
> Key: GUACAMOLE-809
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-809
> Project: Guacamole
>  Issue Type: Wish
>  Components: Documentation
>Reporter: Parth Mishra
>Priority: Minor
>
> The Java Servlet exposes HTTP endpoints as the basis for REST API calls from 
> the frontend client. Currently, there is no easy way to know what these 
> endpoints are without viewing the source code or inspecting the network calls.
> I suggest integrating some API documentation tool (e.g. Swagger) to expose 
> this information in a more accessible manner. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GUACAMOLE-897) Docker support for restricting authentication to database users only

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman resolved GUACAMOLE-897.
-
Fix Version/s: 1.2.0
   Resolution: Implemented

This was implemented recently in the master branch in the following commit:
https://github.com/apache/guacamole-client/commit/062edda07b7759d3a86a9a8b476d03eb8a4aeda1

> Docker support for restricting authentication to database users only
> 
>
> Key: GUACAMOLE-897
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-897
> Project: Guacamole
>  Issue Type: Improvement
>  Components: Documentation, guacamole-docker
>Affects Versions: 1.0.0
>Reporter: Stephen Cluff
>Priority: Minor
> Fix For: 1.2.0
>
>
> Add support for the following properties to start.sh:
>  * mysql-user-required
>  * postgresql-user-required



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GUACAMOLE-760) add timezone info using DB Connection string

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman reassigned GUACAMOLE-760:
---

Assignee: Nick Couchman

> add timezone info using DB Connection string
> 
>
> Key: GUACAMOLE-760
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-760
> Project: Guacamole
>  Issue Type: Improvement
>  Components: guacamole-client
>Affects Versions: 1.0.0
>Reporter: Not Speedy
>Assignee: Nick Couchman
>Priority: Minor
>
> a recent update to with mariadb or its driver prevented guacamole client from 
> loading. 
> Cause: java.sql.SQLException: The server time zone value 'CDT' is 
> unrecognized or represents more than one time zone. You must configure either 
> the server or JDBC driver (via the serverTimezone configuration property).
> loading the timezone table and setting it globally on the mariadb resolved 
> this, however it might be beneficial to add a system property that will set 
> within the connection string.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GUACAMOLE-852) Support MariaDB JDBC Driver

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman reassigned GUACAMOLE-852:
---

Assignee: Nick Couchman

> Support MariaDB JDBC Driver
> ---
>
> Key: GUACAMOLE-852
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-852
> Project: Guacamole
>  Issue Type: Improvement
>  Components: guacamole-auth-jdbc-mysql
>Reporter: Nick Couchman
>Assignee: Nick Couchman
>Priority: Minor
>
> The MariaDB JDBC driver implements a different class than the MySQL driver, 
> so some changes will need to be made to the JDBC module to support that 
> version of the driver.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GUACAMOLE-614) Infinite loop caused by guac_iconv

2019-12-26 Thread Nick Couchman (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003764#comment-17003764
 ] 

Nick Couchman commented on GUACAMOLE-614:
-

[~aiden0z]: Can you retry with 1.0.0 and see if you still have the issue?

> Infinite loop caused by guac_iconv
> --
>
> Key: GUACAMOLE-614
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-614
> Project: Guacamole
>  Issue Type: Bug
>  Components: guacamole-server
>Affects Versions: 0.9.14
> Environment: Guacd 0.9.14 with docker
>Reporter: Aiden Luo
>Priority: Minor
>
> The encoding reader/writer may return zero, but the caller did not check zero 
> value. That may cause the infinite loop when handle incorrect bytes. 
>  See the line starts with {color:#FF}/*** {color}.
> {code:java}
> int guac_iconv(guac_iconv_read* reader, const char** input, int in_remaining,
> guac_iconv_write* writer, char** output, int out_remaining) {
> while (in_remaining > 0 && out_remaining > 0) {
> int value;
> const char* read_start;
> char* write_start;
> /* Read character */
> read_start = *input;
> /*** reader may return value and not change input ***/
> value = reader(input, in_remaining);
> in_remaining -= *input - read_start;
> /* Write character */
> write_start = *output;
> /*** writer may return value and not change output ***/
> writer(output, out_remaining, value);
> out_remaining -= *output - write_start;
> /* Stop if null terminator reached */
> if (value == 0)
> return 1;
> }
> /* Null terminator not reached */
> return 0;
> }
> {code}
>  
> *Analysis procedure*
> *1.  Find problem thread*
> {code:java}
> [root@jettydocker2 /]# ps -ef
> UID PID PPID C STIME TTY TIME CMD
> root 1 0 0 01:35 ? 00:00:40 /usr/local/sbin/guacd -b 0.0.0.0 -f
> root 464 1 0 02:51 ? 00:00:17 /usr/local/sbin/guacd -b 0.0.0.0 -f
> root 615 1 96 03:12 ? 01:23:39 /usr/local/sbin/guacd -b 0.0.0.0 -f
> root 703 1 0 03:38 ? 00:00:00 /usr/local/sbin/guacd -b 0.0.0.0 -f
> root 712 1 0 03:45 ? 00:00:15 /usr/local/sbin/guacd -b 0.0.0.0 -f
> root 728 1 0 04:01 ? 00:00:02 /usr/local/sbin/guacd -b 0.0.0.0 -f
> root 735 0 0 04:39 ? 00:00:00 bash
> root 747 735 0 04:39 ? 00:00:00 ps -ef
> [root@jettydocker2 /]# top -b -H -p 615
> top - 04:40:08 up 48 days, 2:56, 0 users, load average: 1.01, 1.11, 1.19
> Threads: 3 total, 1 running, 2 sleeping, 0 stopped, 0 zombie
> %Cpu(s): 25.4 us, 0.0 sy, 0.0 ni, 74.6 id, 0.0 wa, 0.0 hi, 0.0 si, 0.0 st
> KiB Mem : 8175596 total, 2269700 free, 1883596 used, 4022300 buff/cache
> KiB Swap: 0 total, 0 free, 0 used. 5914664 avail Mem
> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
> 619 root 20 0 1861008 23848 3444 R 99.9 0.3 83:56.87 guacd
> 615 root 20 0 1861008 23848 3444 S 0.0 0.3 0:00.00 guacd
> 621 root 20 0 1861008 23848 3444 S 0.0 0.3 0:00.02 guacd
> {code}
>  
> *2. GDB anaylsis*
> {code:java}
> [root@jettydocker2 /]# gdb /usr/local/sbin/guacd 615
> GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-110.el7
> Copyright (C) 2013 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law. Type "show copying"
> and "show
> 
> (gdb) info threads
> Id Target Id Frame
> 3 Thread 0x7efffeffd700 (LWP 619) "guacd" guac_iconv (reader=0x7f00683e22fa 
> , input=0x7efffefbc638, in_remaining=2,
> writer=0x7f00683e240f , output=0x7efffefbc630, 
> out_remaining=1) at iconv.c:74
> 2 Thread 0x7f0059ffb700 (LWP 621) "guacd" 0x7f00721f9f3d in nanosleep () 
> from /lib64/libpthread.so.0
> * 1 Thread 0x7f0043fff700 (LWP 615) "guacd" 0x7f00721f3f97 in 
> pthread_join () from /lib64/libpthread.so.0
> (gdb) t 3
> [Switching to thread 3 (Thread 0x7efffeffd700 (LWP 619))]
> #0 guac_iconv (reader=0x7f00683e22fa , input=0x7efffefbc638, 
> in_remaining=2, writer=0x7f00683e240f ,
> output=0x7efffefbc630, out_remaining=1) at iconv.c:74
> 74 read_start = *input;
> (gdb) bt
> #0 guac_iconv (reader=0x7f00683e22fa , input=0x7efffefbc638, 
> in_remaining=2, writer=0x7f00683e240f ,
> output=0x7efffefbc630, out_remaining=1) at iconv.c:74
> #1 0x7f00683df11d in guac_vnc_cut_text (client=0x7f007302e010, 
> text=0x7f00600019d0 " #", , textlen=5) at 
> clipboard.c:135
> #2 0x7f00681c97c7 in HandleRFBServerMessage () from 
> /lib64/libvncclient.so.0
> #3 0x7f00683e0c97 in guac_vnc_client_thread (data=0x7f005c00aee0) at 
> vnc.c:350
> #4 0x7f00721f2e25 in start_thread () from /lib64/libpthread.so.0
> #5 0x7f0070aeabad in clone () from /lib64/libc.so.6
> (gdb) f 0
> #0 guac_iconv (reader=0x7f00683e22fa , input=0x7efffefbc638, 
> in_remaining=2, writer=0x7f00683e240f ,
> output=0x7efffefbc630, out_remaining=1) at iconv.c:79
> 79 write_start = *output;
> (gdb) n [18/1979]
> 80 

[jira] [Commented] (GUACAMOLE-604) Add support for Polish keyboard layout

2019-12-26 Thread Nick Couchman (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003763#comment-17003763
 ] 

Nick Couchman commented on GUACAMOLE-604:
-

[~krogac]: If you have any familiarity with the layout it would be helpful if 
you'd be willing to take a stab at it.

> Add support for Polish keyboard layout
> --
>
> Key: GUACAMOLE-604
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-604
> Project: Guacamole
>  Issue Type: New Feature
>  Components: RDP
>Reporter: krogac
>Priority: Minor
>
> Connection RDP not support Polish keyboard layout.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GUACAMOLE-583) SQL Instance Strings

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman reassigned GUACAMOLE-583:
---

Assignee: Nick Couchman

> SQL Instance Strings
> 
>
> Key: GUACAMOLE-583
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-583
> Project: Guacamole
>  Issue Type: Bug
>  Components: guacamole-auth-jdbc-sqlserver
>Affects Versions: 0.9.14
>Reporter: Martyn Jarrett
>Assignee: Nick Couchman
>Priority: Minor
>
> Add a property to the SQL Server module configuration to account for instance 
> names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GUACAMOLE-583) SQL Instance Strings

2019-12-26 Thread Nick Couchman (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003762#comment-17003762
 ] 

Nick Couchman commented on GUACAMOLE-583:
-

[~Jarrett]: I've taken a stab at adding an option, "sqlserver-instance", that 
configures this.  Any chance you could try it out?  I don't have a 
Windows-based SQL Server at the moment to try it on...

https://github.com/necouchman/guacamole-client/tree/jira/583

> SQL Instance Strings
> 
>
> Key: GUACAMOLE-583
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-583
> Project: Guacamole
>  Issue Type: Bug
>  Components: guacamole-auth-jdbc-sqlserver
>Affects Versions: 0.9.14
>Reporter: Martyn Jarrett
>Priority: Minor
>
> Add a property to the SQL Server module configuration to account for instance 
> names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (GUACAMOLE-913) Theme/Look and Feel Selector

2019-12-26 Thread Mathieu BRUNOT (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003701#comment-17003701
 ] 

Mathieu BRUNOT edited comment on GUACAMOLE-913 at 12/26/19 6:16 PM:


If you're saying that due to the screenshot, sorry to disappoint you but I've 
only edited the HTML withing my browser to show my idea. There is no actual 
development done to select a theme.

The only development I've done is the dark theme for Guacamole, which I 
mentioned ([https://github.com/madmath03/dark-guacamole]) but it's just for a 
Chrome plugin, not a Guacamole "official" theme.
 I guess it can still be used though for reference of CSS classes to modify.


was (Author: mathieu.brunot):
If you're saying that due to the screenshot, sorry to disappoint you but I've 
only edited the HTML to show my idea. There is no actual development done to 
select a theme.

The only development I've done is the dark theme for Guacamole, which I 
mentioned 
([(https://github.com/madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole])
 but it's just for a Chrome plugin, not a Guacamole "official" theme.
I guess it can still be used though for reference of CSS classes to modify.

> Theme/Look and Feel Selector
> 
>
> Key: GUACAMOLE-913
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-913
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-client
>Reporter: Mathieu BRUNOT
>Priority: Minor
> Attachments: guacamole_jira_look_and_feel.png
>
>
> I know it is currently possible to customize theme and branding of Guacamole 
> through extensions, but my idea is slightly different.
> I think it might be nice to have a theme/look and feel selector, accessible 
> to all users through their settings. For instance, Guacamole could provide 
> the current (default) theme and a dark theme:  
> !guacamole_jira_look_and_feel.png!
> It would also be nice to allow devs to add more selectable themes to their 
> Guacamole instance
> So it's not really a complete rework / rebranding of Guacamole like we can 
> currently do, but more like a per user customizable look and feel.
> Right now, I'm doing that with a custom [Stylish|https://userstyles.org/] / 
> [Stylus|https://add0n.com/stylus.html] theme 
> ([madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole]) but 
> having it directly in Guacamole would feel much better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (GUACAMOLE-913) Theme/Look and Feel Selector

2019-12-26 Thread Mathieu BRUNOT (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003701#comment-17003701
 ] 

Mathieu BRUNOT edited comment on GUACAMOLE-913 at 12/26/19 4:58 PM:


If you're saying that due to the screenshot, sorry to disappoint you but I've 
only edited the HTML to show my idea. There is no actual development done to 
select a theme.

The only development I've done is the dark theme for Guacamole, which I 
mentioned 
([(https://github.com/madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole])
 but it's just for a Chrome plugin, not a Guacamole "official" theme.
I guess it can still be used though for reference of CSS classes to modify.


was (Author: mathieu.brunot):
If you're saying that due to the screenshot, sorry to disappoint you but I've 
only edited the HTML to show my idea. There is no actual development done to 
select a theme.

The only development I've done is the dark theme for Guacamole, which I 
mentioned: https://github.com/madmath03/dark-guacamole

> Theme/Look and Feel Selector
> 
>
> Key: GUACAMOLE-913
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-913
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-client
>Reporter: Mathieu BRUNOT
>Priority: Minor
> Attachments: guacamole_jira_look_and_feel.png
>
>
> I know it is currently possible to customize theme and branding of Guacamole 
> through extensions, but my idea is slightly different.
> I think it might be nice to have a theme/look and feel selector, accessible 
> to all users through their settings. For instance, Guacamole could provide 
> the current (default) theme and a dark theme:  
> !guacamole_jira_look_and_feel.png!
> It would also be nice to allow devs to add more selectable themes to their 
> Guacamole instance
> So it's not really a complete rework / rebranding of Guacamole like we can 
> currently do, but more like a per user customizable look and feel.
> Right now, I'm doing that with a custom [Stylish|https://userstyles.org/] / 
> [Stylus|https://add0n.com/stylus.html] theme 
> ([madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole]) but 
> having it directly in Guacamole would feel much better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GUACAMOLE-913) Theme/Look and Feel Selector

2019-12-26 Thread Mathieu BRUNOT (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003701#comment-17003701
 ] 

Mathieu BRUNOT commented on GUACAMOLE-913:
--

If you're saying that due to the screenshot, sorry to disappoint you but I've 
only edited the HTML to show my idea. There is no actual development done to 
select a theme.

The only development I've done is the dark theme for Guacamole, which I 
mentioned: https://github.com/madmath03/dark-guacamole

> Theme/Look and Feel Selector
> 
>
> Key: GUACAMOLE-913
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-913
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-client
>Reporter: Mathieu BRUNOT
>Priority: Minor
> Attachments: guacamole_jira_look_and_feel.png
>
>
> I know it is currently possible to customize theme and branding of Guacamole 
> through extensions, but my idea is slightly different.
> I think it might be nice to have a theme/look and feel selector, accessible 
> to all users through their settings. For instance, Guacamole could provide 
> the current (default) theme and a dark theme:  
> !guacamole_jira_look_and_feel.png!
> It would also be nice to allow devs to add more selectable themes to their 
> Guacamole instance
> So it's not really a complete rework / rebranding of Guacamole like we can 
> currently do, but more like a per user customizable look and feel.
> Right now, I'm doing that with a custom [Stylish|https://userstyles.org/] / 
> [Stylus|https://add0n.com/stylus.html] theme 
> ([madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole]) but 
> having it directly in Guacamole would feel much better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GUACAMOLE-914) LDAP sharing profiles

2019-12-26 Thread Nick Couchman (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003684#comment-17003684
 ] 

Nick Couchman commented on GUACAMOLE-914:
-

No reason this can't be done; however, I think some other items would have to 
be implemented within the LDAP module, as well - like Active Connection 
tracking.

> LDAP sharing profiles
> -
>
> Key: GUACAMOLE-914
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-914
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-auth-ldap
>Reporter: Mathieu BRUNOT
>Priority: Minor
>
> Currently, we can create connections in an LDAP but we cannot create _Sharing 
> Profile(s)_.
> Sharing profile can be really useful for tech support in an organization, so 
> I'm wondering if it would be possible to create a "LDAP only" property to 
> setup sharing profiles. For instance, maybe we could use something like this: 
> {noformat}
> guacConfigParameter: sharingProfile=myprofilename
> guacConfigParameter: 
> sharingProfile=myotherprofilewhichisreadonly:read-only{noformat}
> The parameter value could be the name of the profile, with a separator used 
> to specify additional parameters (read-only).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GUACAMOLE-914) LDAP sharing profiles

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman updated GUACAMOLE-914:

Affects Version/s: (was: 1.0.0)

> LDAP sharing profiles
> -
>
> Key: GUACAMOLE-914
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-914
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-auth-ldap
>Reporter: Mathieu BRUNOT
>Priority: Minor
>
> Currently, we can create connections in an LDAP but we cannot create _Sharing 
> Profile(s)_.
> Sharing profile can be really useful for tech support in an organization, so 
> I'm wondering if it would be possible to create a "LDAP only" property to 
> setup sharing profiles. For instance, maybe we could use something like this: 
> {noformat}
> guacConfigParameter: sharingProfile=myprofilename
> guacConfigParameter: 
> sharingProfile=myotherprofilewhichisreadonly:read-only{noformat}
> The parameter value could be the name of the profile, with a separator used 
> to specify additional parameters (read-only).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GUACAMOLE-913) Theme/Look and Feel Selector

2019-12-26 Thread Nick Couchman (Jira)


 [ 
https://issues.apache.org/jira/browse/GUACAMOLE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Couchman updated GUACAMOLE-913:

Affects Version/s: (was: 1.0.0)

> Theme/Look and Feel Selector
> 
>
> Key: GUACAMOLE-913
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-913
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-client
>Reporter: Mathieu BRUNOT
>Priority: Minor
> Attachments: guacamole_jira_look_and_feel.png
>
>
> I know it is currently possible to customize theme and branding of Guacamole 
> through extensions, but my idea is slightly different.
> I think it might be nice to have a theme/look and feel selector, accessible 
> to all users through their settings. For instance, Guacamole could provide 
> the current (default) theme and a dark theme:  
> !guacamole_jira_look_and_feel.png!
> It would also be nice to allow devs to add more selectable themes to their 
> Guacamole instance
> So it's not really a complete rework / rebranding of Guacamole like we can 
> currently do, but more like a per user customizable look and feel.
> Right now, I'm doing that with a custom [Stylish|https://userstyles.org/] / 
> [Stylus|https://add0n.com/stylus.html] theme 
> ([madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole]) but 
> having it directly in Guacamole would feel much better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GUACAMOLE-913) Theme/Look and Feel Selector

2019-12-26 Thread Nick Couchman (Jira)


[ 
https://issues.apache.org/jira/browse/GUACAMOLE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003683#comment-17003683
 ] 

Nick Couchman commented on GUACAMOLE-913:
-

It looks like maybe this is something you have (or someone you know has) 
already worked on?  Care to contribute whatever work you've done?

> Theme/Look and Feel Selector
> 
>
> Key: GUACAMOLE-913
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-913
> Project: Guacamole
>  Issue Type: Wish
>  Components: guacamole-client
>Affects Versions: 1.0.0
>Reporter: Mathieu BRUNOT
>Priority: Minor
> Attachments: guacamole_jira_look_and_feel.png
>
>
> I know it is currently possible to customize theme and branding of Guacamole 
> through extensions, but my idea is slightly different.
> I think it might be nice to have a theme/look and feel selector, accessible 
> to all users through their settings. For instance, Guacamole could provide 
> the current (default) theme and a dark theme:  
> !guacamole_jira_look_and_feel.png!
> It would also be nice to allow devs to add more selectable themes to their 
> Guacamole instance
> So it's not really a complete rework / rebranding of Guacamole like we can 
> currently do, but more like a per user customizable look and feel.
> Right now, I'm doing that with a custom [Stylish|https://userstyles.org/] / 
> [Stylus|https://add0n.com/stylus.html] theme 
> ([madmath03/dark-guacamole|https://github.com/madmath03/dark-guacamole]) but 
> having it directly in Guacamole would feel much better.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)