[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852434#comment-17852434 ] Thomas Kruse commented on GUACAMOLE-1085: - I had a direct chat with Leonard and we think it would help to focus the efforts if there is indeed a set of tasks remaining to get a preview/beta done to gather feedback from users. Do you think you could help with that? We are flexible regarding the format (subtasks here, github comments on the PR), of course. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > Fix For: 2.0.0 > > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851599#comment-17851599 ] Nick Couchman commented on GUACAMOLE-1085: -- [~everflux] : While the PR is nearly a year old, Leonard continues to actively work on it, as he has time, I'm sure. There were commits pushed a recently as a few weeks ago, and he has a list of things he is working through that also gets updated periodically. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > Fix For: 2.0.0 > > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851586#comment-17851586 ] Thomas Kruse commented on GUACAMOLE-1085: - Perhaps this would be a good time to re-visit the PR as it is nearly a year old. Could we move forward by identifying tangible, isolated tasks that are still to be done? Perhaps we could use subtasks of this issue. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > Fix For: 2.0.0 > > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748518#comment-17748518 ] Thomas Kruse commented on GUACAMOLE-1085: - The PR is [https://github.com/apache/guacamole-client/pull/896] Everybody please have a look and provide feedback/thoughts. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734479#comment-17734479 ] Leonard Wagner commented on GUACAMOLE-1085: --- [~vnick] You could definitely do it like this and completely replace the AngularJS. I guess I overcomplicated things since I don’t have much experience with the other Guacamole components. I would like to like to keep the overall structure as it is for now to get feedback on the migration as soon as possible. At first glance it looks like replacing the AngularJS build with Angular build won’t require much effort. So I would say that there won’t be much overhead if we separate the frontend code from the Java code later on. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734376#comment-17734376 ] Nick Couchman commented on GUACAMOLE-1085: -- [~leonard2901]: I'm curious why having it available within the same codebase and/or running instance would be preferable to just running it in another container or Tomcat instance alongside the existing one? When you get to the actual PR, I would think having the AngularJS code completely removed would be what you actually want, so it seems like working toward that would be preferable. Regarding the Maven build - my only comment would be that there was a Jira issue that dealt with actually separating the front-end code (JS/AngularJS/Angular) from the REST API (Java), so this might be a good opportunity to do that, as well, and fully extract that. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[
https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734364#comment-17734364
]
Leonard Wagner commented on GUACAMOLE-1085:
---
We would like to create a draft pull request for this soon to gather some
feedback.
I'm currently integrating the new Angular application into the maven build. Do
you have any thoughts on how it should be integrated in the rest of the
application for testing purposes?
I thought that it would be helpful to have both frontends available at the same
time until the migration is completed. So maybe add the new code to something
like {{guacamole\src\main\frontend-v2}} and copy the build artifacts to {{/v2}}
so the Angular frontend is available at {{_tomcat_url_/guacamole/v2}}?
> Consider migrating web application from AngularJS
> -
>
> Key: GUACAMOLE-1085
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole
>Reporter: Alfred Egger
>Priority: Major
>
> [AngularJS is in an LTS period until June 30,
> 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c].
> Unless resurrected as a community-driven project, it will be cease being
> maintained after that date. Assuming no such project surfaces, we should look
> into migrate the web application to another framework.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714710#comment-17714710 ] Mark Nolan commented on GUACAMOLE-1085: --- I'm happy to participate in a call, though I'm on holiday for the next week and will be probably be living dangerously if I take part then! I'm also not sure that I can add a great deal beyond what I wrote above, but happy to join anyway. I will email you my details separately. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714057#comment-17714057 ] Thomas Kruse commented on GUACAMOLE-1085: - We would like to discuss our approach especially in regards to extensibility/customization as we think that the architecture of Angular restricts the kind of dynamic changes leveraged by the current Guacamole app. [~mjumper] are you interested in joining us in a video call? (And of course all other interested parties, [~manolan], [~christopher.klinge] ?) Perhaps we could coordinate outside of Jira - my email is 'tk' with the domain 'trion.de'. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690036#comment-17690036 ] Mark Nolan commented on GUACAMOLE-1085: --- At the moment, an extension can modify the behaviour of the page it is hosted on because it can add methods to the controller of that page, interact with all the data items used by the controller and with all the controls owned by that page. Is this wise? Possibly not, but it is possible today and I have extensions that do this. Of those things, access to all the data used by a controller is the most important, I would say. For example, I have an extension that adds buttons next to each host. These buttons allow you to start and stop the Google Cloud virtual machines corresponding to the hosts. To do this, they need information about the machine on that line. How could this be modelled in Angular? You could implement the additional UI controls as a separate component and position it relative to the containing HTML in the same way that the current version does - I have some concerns about doing that dynamically, but I can see it is possible. But how will you give it access to the data? The only way I can see is to pass the data as an input parameter to the component. But will you pass the entire context or selectively pass only the data associated with the specific item being modified? If you pass the entire context, that is a lot of data and it rather defeats the whole point of the Angular component model. Or you can create a central data component and pass that to each component, but that's still the same problem. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687906#comment-17687906 ] Thomas Kruse commented on GUACAMOLE-1085: - Could you elaborate in which situations this is a problem or why you would like to improve that specifically? > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687901#comment-17687901 ] Mark Nolan commented on GUACAMOLE-1085: --- To me, the bigger problem is that extensions have access to the entire context and can modify as desired. I cannot see how you would achieve this in Angular without breaking the scoping rules apart. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684965#comment-17684965 ] Mike Jumper commented on GUACAMOLE-1085: Great! The main things to keep in mind for an implementation are: * The current ability for extensions to patch HTML dynamically (this is done by declaring HTML patches that are then dynamically applied at runtime). This is very commonly used for branding. See: https://guacamole.apache.org/doc/gug/guacamole-ext.html#updating-existing-html * The current ability for extensions to define custom field types (this is done by registering a new field type by providing a template, controller, and field type definition). For example: https://github.com/apache/guacamole-client/blob/72b0634a5f0270c693ca9a944b54ca15ec1de170/extensions/guacamole-auth-totp/src/main/resources/config/totpConfig.js#L26-L31 * The current ability for extensions to define new pages within the web application (this is done by defining new AngularJS routes). For example: https://github.com/glyptodon/guacamole-connection-tester/blob/7761997f7a0853226a9aaa99b05a22ece3524962/src/main/resources/config/connectionTesterRouteConfig.js#L26-L32 * The current ability for extensions to augment or override established translation strings by providing their own translation JSON. I suspect that any new UI framework, even Angular, will not directly lend itself well to custom pages and field types the way AngularJS did, and a new API specific to those capabilities may need to be provided. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684831#comment-17684831 ] Thomas Kruse commented on GUACAMOLE-1085: - We will start with an initial spike on April 1st (no joke). We will first evaluate possible architecture options and then move to a prototype. Feel free to reach out if you are interested in providing input or remarks let me know. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653508#comment-17653508 ] Conrad O'Brien commented on GUACAMOLE-1085: --- This is no doubt this is a Herculean task. Is there a way to financially support this endeavor? > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625139#comment-17625139 ] Christopher Klinge commented on GUACAMOLE-1085: --- I had a colleague of mine who is familiar with this kind of update take a quick look at the project and his gut estimate is at least 2 months of work for an experienced front end dev. As Nick pointed out, close to all of the files will be affected and whilst some code may be easy to update, other parts are likely to require full rewrites. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625137#comment-17625137 ] Nick Couchman commented on GUACAMOLE-1085: -- [~everflux]: Basically, everything in the Guacamole Client front-end code ( https://github.com/apache/guacamole-client/tree/master/guacamole/src/main/frontend/src ) will have to be reworked to remove the AngularJS functionality and dependencies and replace it with Angular or whatever framework we decide to go with. It is likely that will in some way touch - update or replace - every single file in that frontend/src directory - there may be a handful of exceptions that are just vanilla JavaScript with no AngularJS dependencies, but I think it's basically everything in that folder. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624926#comment-17624926 ] Thomas Kruse commented on GUACAMOLE-1085: - I would like to internally discuss of this is feasible for us to sponsor/do a PoC spike. Currently I have no real understanding of the requirements. Where can I get a good understanding of what should be achievable in regard to customization of the frontend. Is data available of current use cases of users of guacamole what kind of flexibility is required in the real world? > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620621#comment-17620621 ] Mike Jumper commented on GUACAMOLE-1085: It is pretty substantial. [~jmuehlner] and I started working on the migration a while back, before we had to shift over to working on other things. The migration itself was not too insane, but we don't have an answer on the extension side for things like HTML template patching and custom field types. Angular moved away from the dynamic compilation approach used in AngularJS and adopted build-time template compilation. Great for performance, but devilish for dynamic things and extensibility. It's possible, I'm sure, but maybe not without breaking compatibility and providing our own API outside of Angular for HTML patching and custom fields. IIRC, Angular has a dynamic compiler, but it's considered experimental. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620554#comment-17620554 ] Mark Nolan commented on GUACAMOLE-1085: --- As I said 2 years ago, I really don't think this is very easy. Just re-writing the stock interface would be fairly easy, but making extensions work (allowing extensions to change the client presentation) would be considerable work and would need careful design. Please don't underestimate the effort involved here. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620012#comment-17620012 ] Christopher Klinge commented on GUACAMOLE-1085: --- We use Guacamole in a production environment and have very strict security requirements. The client using a version of AngularJS that is by now outdated is a significant issue for us. I believe upgrading to Angular is the best bet, as maintaining a fork of AngularJS incurs more effort than it is worth. We might be able in helping by either implementing the transition ourselves or helping to sponsor the necessary work. Can who is more familiar with the internals of guacamole-client provide an estimate of the work necessary? > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613763#comment-17613763 ] Thomas Kruse commented on GUACAMOLE-1085: - We might be able to sponsor an initial transition to Angular. Would it make sense to first have https://issues.apache.org/jira/browse/GUACAMOLE-1481 completed? Is there anything else to be considered? > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426578#comment-17426578 ] Nick Couchman commented on GUACAMOLE-1085: -- Looks like someone has picked up commercial support for AngularJS, but no indication that this will include any open community around it... https://xlts.dev/angularjs > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260174#comment-17260174 ] James Muehlner commented on GUACAMOLE-1085: --- Ah good, I stand corrected. My comments about needing to buy into Babel/Webpack/Browserify were mistaken (which is good!). I'd say that it looks like using ngUpgrade to upgrade the webapp piece by piece, with both AngularJS and Angular components running in the same application at the same time is the way to go, if possible. This approach should allow dividing up the work of upgrading different parts of the app, and ensuring that all changes are properly tested and released in a timely manner, rather than trying to upgrade everything in one big push, flipping to the new code at the end. (This is the approach we used when originally migrating to AngularJS, and even with the much-smaller webapp at the time, it was a pain) > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258503#comment-17258503 ] Mark Nolan commented on GUACAMOLE-1085: --- You can build Angular applications using a Maven plugin (e.g. frontend plugin), though I have no experience with that in practice. It would probably work for any npm/yarn compatible framework. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258491#comment-17258491 ] James Muehlner commented on GUACAMOLE-1085: --- It looks like LTS support for AngularJS has been [extended to December 31st, 2020|https://docs.angularjs.org/misc/version-support-status], but in any case we are now within 1 year of the end of AngularJS. I agree with [~manolan] that migrating to Angular would be a major undertaking, requiring at least a partial rewrite of the entire application. It does look like there are some tools provided to help upgrade AngularJS apps to Angular, so this is probably the easiest/smoothest path to upgrading. As far as alternative frameworks, I have the most experience working with react, which I _believe_ is now eligible for use in ASF projects [after being re-licensed under MIT|https://engineering.fb.com/2017/09/22/web/relicensing-react-jest-flow-and-immutable-js/]. It looks like upgrading to either React or Angular would likely also require changing the way the build works. We many need to buy at least partially into the whole NPM/Babel/Webpack/Browserify ecosystem. I have no experience with Vue. I'd also be happy to work on migrating to whatever framework comes next. It looks like Angular is probably the leading candidate at the moment. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138372#comment-17138372 ] Mark Nolan commented on GUACAMOLE-1085: --- I would love to see the project move to Angular! I much prefer the structure of Angular components and the use of Typescript is a benefit. I would hugely favour it over React or Vue, which don't provide the same scope at all. For example, we would need to select an Ajax library as well and agree a standard for dependency injection etc. But I think it would be very difficult. I have no experience in Angular meta-programming (by which I mean writing applications that modify themselves), so this is just guesswork, but I think it would be quite hard to provide the current flexibility. At the moment, extensions can easily extend the behaviour of the existing interface because they always have access to the enclosing scope. This is not true in Angular, where scope has to be passed explicitly as an input binding to child components. Of course, we could (probably) make it standard that components always pass their whole scope to all dynamic children (children from extensions), but that would be a bit cumbersome. And then there's the Typescript conversion, which means that things may not always be called exactly what they were called in the source code. Not a problem if you are transpiling the whole code-base together, but it might be an issue for extensions. We *could* write Angular in Javascript rather than Typescript, but that loses half the benefit! Anyway, I would definitely support it and be happy to help, but I think it would be a large and complex undertaking. > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[ https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119519#comment-17119519 ] Nick Couchman commented on GUACAMOLE-1085: -- It looks like Angular is the successor to AngularJS - I'm sure migrating is not a trivial exercise, and forgive my ignorance, but is there any reason that moving to Angular is not a natural path forward? > Consider migrating web application from AngularJS > - > > Key: GUACAMOLE-1085 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Alfred Egger >Priority: Major > > [AngularJS is in an LTS period until June 30, > 2021|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c]. > Unless resurrected as a community-driven project, it will be cease being > maintained after that date. Assuming no such project surfaces, we should look > into migrate the web application to another framework. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-1085) Consider migrating web application from AngularJS
[
https://issues.apache.org/jira/browse/GUACAMOLE-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119300#comment-17119300
]
Mike Jumper commented on GUACAMOLE-1085:
{quote}
[AngularJS is in LTS support until June 30, 2021 and will be unsupported from
then
on|https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c].
Apache Guacamole still uses AngularJS for its frontend and has to be migrated
away after that point except somebody starts working on it again with
maintainable fork.
{quote}
Indeed. It would be wonderful if someone does pick up AngularJS before than and
begins such a community-driven fork.
{quote}
Does Guacamole intend to migrate to another framework (Vue.js, React, Angular)
at some point?
{quote}
Short answer: yes. Unless it becomes clear that AngularJS will continue being
maintained by the community, we will migrate to something else.
I'd still caution against looking at that date a hard deadline for all projects
using AngularJS to jump ship. It certainly gets progressively worse after that
date, but AngularJS will not instantly turn into poison on June 30, 2021.
> Consider migrating web application from AngularJS
> -
>
> Key: GUACAMOLE-1085
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1085
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole
>Affects Versions: 0.9.14, 1.0.0, 1.1.0
>Reporter: Alfred Egger
>Priority: Major
>
> AngularJS is in LTS support until June 30, 2021 and will be unsupported from
> then on [1]. Apache Guacamole still uses AngularJS for its frontend and has
> to be migrated away after that point except somebody starts working on it
> again with maintainable fork. Does Guacamole intend to migrate to another
> framework (Vue.js, React, Angular) at some point?
> [1]
> https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
