[jira] [Commented] (GUACAMOLE-1525) Support for true fullscreen mode and keyboard lock
[ https://issues.apache.org/jira/browse/GUACAMOLE-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708175#comment-17708175 ] Nick Couchman commented on GUACAMOLE-1525: -- [~sirux88]: The best way to contribute code to existing requests is to respond on the request and offer your help. If the requests really are stale you can certainly open a new pull request for one or both of those issues with a suggested resolution, and just mention that you are continuing the work. We can take care of closing out the old requests if/when the new one(s) are accepted. > Support for true fullscreen mode and keyboard lock > -- > > Key: GUACAMOLE-1525 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1525 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: sirux88 >Priority: Minor > > As the browser specific fullscreen mode isn't a true fullscreen mode, i made > some changes to allow usage of browser fullscreen api ([Fullscreen API - Web > APIs | MDN > (mozilla.org)|https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API]) > This change works on > > Futhermore this change allows usage of browser keyboard lock api > ([Keyboard.lock() - Web APIs | MDN > (mozilla.org)|https://developer.mozilla.org/en-US/docs/Web/API/Keyboard/lock]) > to prevent execution of special keys on local (eg. Meta key, Functionkeys > with special browser purpose like F5 oder F11) > Unfortunately keyboard lock api only works on chromium based browsers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GUACAMOLE-1525) Support for true fullscreen mode and keyboard lock
[ https://issues.apache.org/jira/browse/GUACAMOLE-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484355#comment-17484355 ] sirux88 commented on GUACAMOLE-1525: I saw both pull requests/Jira issues but unfortunately I mentioned them on github only. Since both seemed stale (GUACAMOLE-124 due to inactivity and GUACAMOLE-989 due to functionality issues) i tried to provide a combined solution to get them up again. I also created a new request because i didn't know how to contribute (code not commenting/discussing) to an existing issue/pull request. Maybe you could give me a hint how to do [~vnick] > Support for true fullscreen mode and keyboard lock > -- > > Key: GUACAMOLE-1525 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-1525 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: sirux88 >Priority: Minor > > As the browser specific fullscreen mode isn't a true fullscreen mode, i made > some changes to allow usage of browser fullscreen api ([Fullscreen API - Web > APIs | MDN > (mozilla.org)|https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API]) > This change works on > > Futhermore this change allows usage of browser keyboard lock api > ([Keyboard.lock() - Web APIs | MDN > (mozilla.org)|https://developer.mozilla.org/en-US/docs/Web/API/Keyboard/lock]) > to prevent execution of special keys on local (eg. Meta key, Functionkeys > with special browser purpose like F5 oder F11) > Unfortunately keyboard lock api only works on chromium based browsers -- This message was sent by Atlassian Jira (v8.20.1#820001)
