[jira] [Resolved] (HAWQ-932) HAWQ fails to query external table defined with "localhost" in URL

[Oleksandr Diachenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Diachenko resolved HAWQ-932.
--
Resolution: Fixed

> HAWQ fails to query external table defined with "localhost" in URL
> --
>
> Key: HAWQ-932
> URL: https://issues.apache.org/jira/browse/HAWQ-932
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: External Tables, PXF
>Reporter: Goden Yao
>Assignee: Oleksandr Diachenko
> Fix For: 2.0.1.0-incubating
>
>
> Originally reported by [~jpatel] when he's making a docker image based on 
> HAWQ 2.0.0.0-incubating dev build. Investigated by [~odiachenko]
> There is workaround to define it with 127.0.0.1, but there is not a 
> workaround for querying tables using HCatalog integration.
> It used to work before.
> {code}
> template1=# CREATE EXTERNAL TABLE ext_table1 (t1text, t2text,
> num1  integer, dub1  double precision) LOCATION
> (E'pxf://localhost:51200/hive_small_data?PROFILE=Hive') FORMAT 'CUSTOM'
> (formatter='pxfwritable_import');*
> CREATE EXTERNAL TABLE
> template1=# select * from ext_table1;
> ERROR:  remote component error (0): (libchurl.c:898)*
> {code}
> When I turned on debug mode in curl, I found this error in logs - "*
> Closing connection 0".
> I found a workaround, to set CURLOPT_RESOLVE option in curl:
> {code}
> struct curl_slist *host = NULL;
> host = curl_slist_append(NULL, "localhost:51200:127.0.0.1");*
> set_curl_option(context, CURLOPT_RESOLVE, host);
> {code}
> It seems like an issue with DNS cache,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #800: HAWQ-936. Add GUC for array expansion in ORCA opt...

[vraghavan78]

Github user vraghavan78 commented on the issue:

https://github.com/apache/incubator-hawq/pull/800
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #799: HAWQ-934. Populate canSetTag of PlannedStmt from ...

[vraghavan78]

Github user vraghavan78 commented on the issue:

https://github.com/apache/incubator-hawq/pull/799
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #795: HAWQ-860. Fix ORCA wrong plan when correlated sub...

[vraghavan78]

Github user vraghavan78 commented on the issue:

https://github.com/apache/incubator-hawq/pull/795
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #808: HAWQ-944. Implement new pg_ltoa function a...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/808#discussion_r71923516
  
--- Diff: src/backend/access/external/pxfutils.c ---
@@ -39,7 +39,7 @@ bool are_ips_equal(char *ip1, char *ip2)
 /* override port str with given new port int */
 void port_to_str(char **port, int new_port)
 {
-   char tmp[10];
+   char tmp[sizeof(new_port) + 2];
--- End diff --

This will not be sufficient. sizeof would return 4 and tmp would be 
allocated only 6 bytes which wouldn't be sufficient to store the 32 bit 
interger as a string


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...

[shivzone]

Github user shivzone commented on the issue:

https://github.com/apache/incubator-hawq/pull/808
  
I would prefer if we have a general util function that determines precisely 
the number of bytes to "stringify" the given data type (int16 or int32) as a 
character array


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Comment Edited] (HAWQ-944) Numutils.c: pg_ltoa and pg_itoa functions allocate unnecessary amount of bytes

[Shivram Mani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389985#comment-15389985
 ] 

Shivram Mani edited comment on HAWQ-944 at 7/22/16 6:22 PM:


Yes, it does look like we are over allocating bytes 


was (Author: shivram):
Nice catch on the patch !

> Numutils.c: pg_ltoa and pg_itoa functions allocate unnecessary amount of bytes
> --
>
> Key: HAWQ-944
> URL: https://issues.apache.org/jira/browse/HAWQ-944
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kavinder Dhaliwal
>Assignee: Kavinder Dhaliwal
>Priority: Minor
> Fix For: 2.0.1.0-incubating
>
>
> The current implementations of {{pg_ltoa}} and {{pg_itoa}} allocate a 33 byte 
> char array and set the input pointer to that array. This is far too many 
> bytes than needed to translate an int16 or int32 to a string
> int32 -> 10 bytes maximum + 1 sign bit + '\0' = 12 bytes
> int16 ->  5 bytes maximum  + 1 sign bit + '\0' = 7 bytes
> When HAWQ/Greenplum forked from Postgres the two functions simply delegated 
> to {{sprintf}} so an optimization was introduced that involved the 33 byte 
> solution. Postgres itself implemented these functions in commit 
> https://github.com/postgres/postgres/commit/4fc115b2e981f8c63165ca86a23215380a3fda66
>  that require a 12 byte maximum char pointer.
> This is a minor improvement that can be made to the HAWQ codebase and it's 
> relatively little effort to do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-944) Numutils.c: pg_ltoa and pg_itoa functions allocate unnecessary amount of bytes

[Shivram Mani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389985#comment-15389985
 ] 

Shivram Mani commented on HAWQ-944:
---

Nice catch on the patch !

> Numutils.c: pg_ltoa and pg_itoa functions allocate unnecessary amount of bytes
> --
>
> Key: HAWQ-944
> URL: https://issues.apache.org/jira/browse/HAWQ-944
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kavinder Dhaliwal
>Assignee: Kavinder Dhaliwal
>Priority: Minor
> Fix For: 2.0.1.0-incubating
>
>
> The current implementations of {{pg_ltoa}} and {{pg_itoa}} allocate a 33 byte 
> char array and set the input pointer to that array. This is far too many 
> bytes than needed to translate an int16 or int32 to a string
> int32 -> 10 bytes maximum + 1 sign bit + '\0' = 12 bytes
> int16 ->  5 bytes maximum  + 1 sign bit + '\0' = 7 bytes
> When HAWQ/Greenplum forked from Postgres the two functions simply delegated 
> to {{sprintf}} so an optimization was introduced that involved the 33 byte 
> solution. Postgres itself implemented these functions in commit 
> https://github.com/postgres/postgres/commit/4fc115b2e981f8c63165ca86a23215380a3fda66
>  that require a 12 byte maximum char pointer.
> This is a minor improvement that can be made to the HAWQ codebase and it's 
> relatively little effort to do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-946) Document which GUCs are not intended for end-user customization

[Severine Tymon (JIRA)]

Severine Tymon created HAWQ-946:
---

 Summary: Document which GUCs are not intended for end-user 
customization
 Key: HAWQ-946
 URL: https://issues.apache.org/jira/browse/HAWQ-946
 Project: Apache HAWQ
  Issue Type: Improvement
  Components: Documentation
Reporter: Severine Tymon
Assignee: Lei Chang


There are a number of GUCs (server configuration parameters) that are *not* 
described currently in the product documentation but are visible either via 1) 
`hawq config` 2) or within code (src/backend/utils/misc/guc.c). These 
parameters should be labeled (or documented) appropriately. Make clear which 
configs are intended for developer debugging purposes only and are not intended 
for HAWQ end-user customization. 

Requesting that we:
1) Document the usage of the GUC and/or label the GUC context correctly in code 
as "internal-only" or "developer option" (in other words, apply appropriate 
contexts consistently.) Also, possibly hide these configs from hawq config 
output.
2) Add documentation for GUCs in which end user customization is possible but 
not recommended except for specific, advanced use cases.
3) If the GUC is no longer in use, then deprecate the GUC (either remove or 
mark as DEFUNCT?) . For example, "gp_vmem_idle_resource_timeout" was removed 
from product docs, but not from code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HAWQ-946) Document which GUCs are not intended for end-user customization

[Severine Tymon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Severine Tymon updated HAWQ-946:

Fix Version/s: backlog

> Document which GUCs are not intended for end-user customization
> ---
>
> Key: HAWQ-946
> URL: https://issues.apache.org/jira/browse/HAWQ-946
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Severine Tymon
>Assignee: Lei Chang
> Fix For: backlog
>
>
> There are a number of GUCs (server configuration parameters) that are *not* 
> described currently in the product documentation but are visible either via 
> 1) `hawq config` 2) or within code (src/backend/utils/misc/guc.c). These 
> parameters should be labeled (or documented) appropriately. Make clear which 
> configs are intended for developer debugging purposes only and are not 
> intended for HAWQ end-user customization. 
> Requesting that we:
> 1) Document the usage of the GUC and/or label the GUC context correctly in 
> code as "internal-only" or "developer option" (in other words, apply 
> appropriate contexts consistently.) Also, possibly hide these configs from 
> hawq config output.
> 2) Add documentation for GUCs in which end user customization is possible but 
> not recommended except for specific, advanced use cases.
> 3) If the GUC is no longer in use, then deprecate the GUC (either remove or 
> mark as DEFUNCT?) . For example, "gp_vmem_idle_resource_timeout" was removed 
> from product docs, but not from code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...

[kavinderd]

Github user kavinderd commented on the issue:

https://github.com/apache/incubator-hawq/pull/808
  
@xunzhang No rush, take your time


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #808: HAWQ-944. Implement new pg_ltoa function as per p...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/808
  
@kavinderd I will review this next Monday, sorry for the latency.  If it is 
a hurry, you could at somebody else to review. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo closed HAWQ-945.
-
Resolution: Fixed

> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389139#comment-15389139
 ] 

ASF GitHub Bot commented on HAWQ-945:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/809


> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389133#comment-15389133
 ] 

ASF GitHub Bot commented on HAWQ-945:
-

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/809
  
+1


> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #809: HAWQ-945. catalog:char/varchar test cases fail du...

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/809
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389129#comment-15389129
 ] 

ASF GitHub Bot commented on HAWQ-945:
-

Github user yaoj2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/809
  
+1


> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #809: HAWQ-945. catalog:char/varchar test cases fail du...

[yaoj2]

Github user yaoj2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/809
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389125#comment-15389125
 ] 

ASF GitHub Bot commented on HAWQ-945:
-

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/809

HAWQ-945. catalog:char/varchar test cases fail due to locale settings.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq test3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #809


commit 1e3cdd448a30e8db62ad47e428d318f78acd1a34
Author: Paul Guo 
Date:   2016-07-22T07:50:37Z

HAWQ-945. catalog:char/varchar test cases fail due to locale settings.




> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #809: HAWQ-945. catalog:char/varchar test cases ...

[paul-guo-]

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/809

HAWQ-945. catalog:char/varchar test cases fail due to locale settings.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq test3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #809


commit 1e3cdd448a30e8db62ad47e428d318f78acd1a34
Author: Paul Guo 
Date:   2016-07-22T07:50:37Z

HAWQ-945. catalog:char/varchar test cases fail due to locale settings.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo updated HAWQ-945:
--
Fix Version/s: 2.0.1.0-incubating

> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo reassigned HAWQ-945:
-

Assignee: Paul Guo  (was: Lei Chang)

> catalog:char/varchar test cases fail due to locale settings.
> 
>
> Key: HAWQ-945
> URL: https://issues.apache.org/jira/browse/HAWQ-945
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-945) catalog:char/varchar test cases fail due to locale settings.

[Paul Guo (JIRA)]

Paul Guo created HAWQ-945:
-

 Summary: catalog:char/varchar test cases fail due to locale 
settings.
 Key: HAWQ-945
 URL: https://issues.apache.org/jira/browse/HAWQ-945
 Project: Apache HAWQ
  Issue Type: Bug
Reporter: Paul Guo
Assignee: Lei Chang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)