[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...

[stanlyxiang]

Github user stanlyxiang commented on the issue:

https://github.com/apache/incubator-hawq/pull/1035
  
＋1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1037: HAWQ-1188. Fix guc type issue for Gp_inte...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1037


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1037: HAWQ-1188. Fix guc type issue for Gp_interconnec...

[liming01]

Github user liming01 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1037
  
+1. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1037: HAWQ-1188. Fix guc type issue for Gp_inte...

[wengyanqing]

GitHub user wengyanqing opened a pull request:

https://github.com/apache/incubator-hawq/pull/1037

HAWQ-1188. Fix guc type issue for Gp_interconnect_transmit_timeout



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wengyanqing/incubator-hawq HAWQ-1188

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1037.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1037


commit 7c05a23f0ef6ccb8d5d6d5f613683f8d18e29426
Author: ivan 
Date:   2016-12-05T07:27:32Z

HAWQ-1188. Fix guc type issue for Gp_interconnect_transmit_timeout




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (HAWQ-1189) Split schedule.txt into sanity and full scheduler files for feature tests

[hongwu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu resolved HAWQ-1189.
--
Resolution: Resolved

> Split schedule.txt into sanity and full scheduler files for feature tests
> -
>
> Key: HAWQ-1189
> URL: https://issues.apache.org/jira/browse/HAWQ-1189
> Project: Apache HAWQ
>  Issue Type: Test
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #1024: Split schedule file to sanity and full te...

[xunzhang]

Github user xunzhang closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1024


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1024: Split schedule file to sanity and full tests for...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/1024
  
Merged into master, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (HAWQ-1189) Split schedule.txt into sanity and full scheduler files for feature tests

[hongwu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongwu reassigned HAWQ-1189:


Assignee: hongwu  (was: Jiali Yao)

> Split schedule.txt into sanity and full scheduler files for feature tests
> -
>
> Key: HAWQ-1189
> URL: https://issues.apache.org/jira/browse/HAWQ-1189
> Project: Apache HAWQ
>  Issue Type: Test
>  Components: Tests
>Reporter: hongwu
>Assignee: hongwu
> Fix For: 2.0.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-1189) Split schedule.txt into sanity and full scheduler files for feature tests

[hongwu (JIRA)]

hongwu created HAWQ-1189:


 Summary: Split schedule.txt into sanity and full scheduler files 
for feature tests
 Key: HAWQ-1189
 URL: https://issues.apache.org/jira/browse/HAWQ-1189
 Project: Apache HAWQ
  Issue Type: Test
  Components: Tests
Reporter: hongwu
Assignee: Jiali Yao
 Fix For: 2.0.1.0-incubating






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized, -Wsiz...

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1035
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90804840
  
--- Diff: src/backend/gp_libpq_fe/fe-exec.c ---
@@ -2968,7 +2968,7 @@ PQoidStatus(const PGresult *res)
 
size_t  len;
 
-   if (!res || !res->cmdStatus || strncmp(res->cmdStatus, "INSERT ", 7) != 
0)
+   if (!res || strncmp(res->cmdStatus, "INSERT ", 7) != 0)
--- End diff --

I do not think assuming strncpy(NULL, ...) is ok is a good idea. At least I 
quickly searched on stackoverflow,


http://stackoverflow.com/questions/21865041/in-c-what-exactly-happens-when-you-pass-a-null-pointer-to-strcmp

Although this page is probably not accurate, but your change might risk not 
working in some lib/platform implementation.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90804941
  
--- Diff: src/backend/resourcemanager/include/utils/simplestring.h ---
@@ -63,7 +63,7 @@ bool SimpleStringEmpty(SimpStringPtr str);
 int  SimpleStringLocateChar(SimpStringPtr str, char target, int *location);
 /* string to the other number values. */
 int  SimpleStringToInt32(SimpStringPtr str, int32_t *value);
-int  SimpleStringToInt64(SimpStringPtr str, int64_t *value);
+int  SimpleStringToInt64(SimpStringPtr str, int64 *value);
--- End diff --

Why change this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90805120
  
--- Diff: src/interfaces/libpq/fe-exec.c ---
@@ -2710,7 +2710,6 @@ PQoidValue(const PGresult *res)
unsigned long result;
 
if (!res ||
--- End diff --

See previous comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90804848
  
--- Diff: src/backend/gp_libpq_fe/fe-exec.c ---
@@ -2992,7 +2992,6 @@ PQoidValue(const PGresult *res)
unsigned long result;
 
if (!res ||
--- End diff --

See comment above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90803660
  
--- Diff: src/backend/gp_libpq_fe/fe-exec.c ---
@@ -2668,7 +2668,7 @@ PQresultStatus(const PGresult *res)
 char *
 PQresStatus(ExecStatusType status)
 {
-   if ((int)status < 0 || status >= sizeof pgresStatus / sizeof 
pgresStatus[0])
+   if (status < PGRES_EMPTY_QUERY || (unsigned int) status >= sizeof 
pgresStatus / sizeof pgresStatus[0])
--- End diff --

Again, see my previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90805107
  
--- Diff: src/interfaces/libpq/fe-exec.c ---
@@ -2386,7 +2386,7 @@ PQresultStatus(const PGresult *res)
 char *
 PQresStatus(ExecStatusType status)
 {
-   if (status < 0 || status >= sizeof pgresStatus / sizeof pgresStatus[0])
+   if (status < PGRES_EMPTY_QUERY || (unsigned int) status >= sizeof 
pgresStatus / sizeof pgresStatus[0])
--- End diff --

See previous comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90805114
  
--- Diff: src/interfaces/libpq/fe-exec.c ---
@@ -2686,7 +2686,7 @@ PQoidStatus(const PGresult *res)
 
size_t  len;
 
-   if (!res || !res->cmdStatus || strncmp(res->cmdStatus, "INSERT ", 7) != 
0)
+   if (!res || strncmp(res->cmdStatus, "INSERT ", 7) != 0)
--- End diff --

See previous comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90803468
  
--- Diff: src/backend/gp_libpq_fe/fe-connect.c ---
@@ -436,7 +436,7 @@ PQconnectStartParams(const char **keywords,
{
conn->status = CONNECTION_BAD;
/* errorMessage is already set */
-   return false;
+   return conn;
--- End diff --

The original code is absolutely buggy. However please double check the 
logic to see whether conn instead of others like NULL should be returned.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1036: HAWQ-1188. Fix "-Wtautological-constant-o...

[ictmalili]

Github user ictmalili commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1036#discussion_r90798944
  
--- Diff: src/backend/cdb/cdbgang.c ---
@@ -444,7 +444,7 @@ disconnectAndDestroyGang(Gang *gp)
elog(DEBUG2, "Warning: disconnectAndDestroyGang called on an %s 
gang",
 gp->active ? "active" : "allocated");
 
-   if (gp->gang_id < 1 || gp->gang_id > 1 || gp->type > 10 || 
gp->size > 10)
+   if (gp->gang_id < 1 || gp->gang_id > 1 || gp->type > 
GANGTYPE_PRIMARY_WRITER || gp->size > 10)
--- End diff --

Why extract this parameter out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1035: HAWQ-1187. Fix "-Wsometimes-uninitialized...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1035#discussion_r90799626
  
--- Diff: src/bin/pg_dump/dumputils.c ---
@@ -1062,7 +1062,7 @@ char *
 custom_fmtopts_string(const char *src)
 {
int len = src ? strlen(src) : 0;
-   char   *result = malloc(len * 2 + 1);
+   char   *result = calloc(1, len * 2 + 1);
--- End diff --

fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (HAWQ-1183) Writable external table with Hash distribution shows slow performance

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo closed HAWQ-1183.
--
   Resolution: Fixed
Fix Version/s: 2.0.1.0-incubating

> Writable external table with Hash distribution shows slow performance
> -
>
> Key: HAWQ-1183
> URL: https://issues.apache.org/jira/browse/HAWQ-1183
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
> Fix For: 2.0.1.0-incubating
>
>
> Steps:
> 1. Create tables and populate them.
> drop table tbl1;
> drop external table ext_tbl1;
> drop external table ext_tbl1_random;
> CREATE TABLE tbl1 (a int, b text) DISTRIBUTED BY (a);
> INSERT INTO tbl1 VALUES (generate_series(1,1000),'aaa');
> INSERT INTO tbl1 VALUES (generate_series(1,1),'bbb');
> INSERT INTO tbl1 VALUES (generate_series(1,10),'bbc');
> INSERT INTO tbl1 VALUES (generate_series(1,100),'bdbc');
> INSERT INTO tbl1 VALUES (generate_series(1,100),'bdddbc');
> CREATE WRITABLE EXTERNAL TABLE ext_tbl1
> ( LIKE tbl1 )
> LOCATION ('gpfdist://127.0.0.1/tbl1.csv')
> FORMAT 'CSV' (DELIMITER ',')
> DISTRIBUTED BY (a);
> CREATE WRITABLE EXTERNAL TABLE ext_tbl1_random
> ( LIKE tbl1 )
> LOCATION ('gpfdist://127.0.0.1/tbl1.random.csv')
> FORMAT 'CSV' (DELIMITER ',')
> DISTRIBUTED RANDOMLY;
> 2. Write the two external tables. We can find that the external table with 
> hash distribution is slow with inserting, and plan shows that it has 1 
> workers only.
> postgres=# explain analyze INSERT INTO ext_tbl1 SELECT * from tbl1;
>  QUERY PLAN
> -
> -
> 
>  Insert  (cost=0.00..509.20 rows=1000 width=8)
>Rows out:  Avg 2111000.0 rows x 1 workers.  
> Max/Last(seg0:host67/seg0:host67) 2111000/2111000 rows with 17/17 ms to first 
> row, 20145/20145 ms to end, start offset by 18/18 ms.
>Executor memory:  1K bytes.
>->  Result  (cost=0.00..431.07 rows=1000 width=20)
>  Rows out:  Avg 2111000.0 rows x 1 workers.  
> Max/Last(seg0:host67/seg0:host67) 2111000/2111000 rows with 14/14 ms to first 
> row, 1919/1919 ms to end, start offset by 18/18 ms
> .
>  ->  Redistribute Motion 1:1  (slice1; segments: 1)  
> (cost=0.00..431.05 rows=1000 width=8)
>Hash Key: tbl1.a
>Rows out:  Avg 2111000.0 rows x 1 workers at destination.  
> Max/Last(seg0:host67/seg0:host67) 2111000/2111000 rows with 14/14 ms to first 
> row, 1273/1273 ms to end, sta
> rt offset by 18/18 ms.
>->  Table Scan on tbl1  (cost=0.00..431.01 rows=1000 width=8)
>  Rows out:  Avg 2111000.0 rows x 1 workers.  
> Max/Last(seg0:host67/seg0:host67) 2111000/2111000 rows with 13/13 ms to first 
> row, 447/447 ms to end, start offset b
> y 18/18 ms.
>  Slice statistics:
>(slice0)Executor memory: 293K bytes (seg0:host67).
>(slice1)Executor memory: 303K bytes (seg0:host67).
>  Statement statistics:
>Memory used: 262144K bytes
>  Optimizer status: PQO version 1.684
>  Dispatcher statistics:
>executors used(total/cached/new connection): (2/0/2); dispatcher 
> time(total/connection/dispatch data): (13.138 ms/12.628 ms/0.061 ms).
>dispatch data time(max/min/avg): (0.034 ms/0.025 ms/0.029 ms); consume 
> executor data time(max/min/avg): (0.098 ms/0.036 ms/0.067 ms); free executor 
> time(max/min/avg): (0.000 ms/0
> .000 ms/0.000 ms).
>  Data locality statistics:
>data locality ratio: 1.000; virtual segment number: 1; different host 
> number: 1; virtual segment number per host(avg/min/max): (1/1/1); segment 
> size(avg/min/max): (46023656.000 B
> /46023656 B/46023656 B); segment size with penalty(avg/min/max): 
> (46023656.000 B/46023656 B/46023656 B); continuity(avg/min/max): 
> (1.000/1.000/1.000); DFS metadatacache: 27.930 ms;
> resource allocation: 11.879 ms; datalocality calculation: 0.207 ms.
>  Total runtime: 20356.994 ms
> (22 rows)
> postgres=#
> postgres=# explain analyze INSERT INTO ext_tbl1_random SELECT * from tbl1;
> QUERY PLAN
> -
> -
> 

[GitHub] incubator-hawq pull request #1033: HAWQ-1183. Writable external table with H...

[paul-guo-]

Github user paul-guo- closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1033


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---