[GitHub] incubator-hawq issue #1065: HAWQ-1208. Porting gpdb interconnect fix to hawq...

[liming01]

Github user liming01 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1065
  
It is better to keep them separate commit, so that we can easy tracing the 
problem. If you think they are too many commit, you can using merge instead of 
rebase. 

+1. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1065: HAWQ-1208. Porting gpdb interconnect fix to hawq...

[huor]

Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/1065
  
Given there are multiple fix in each of commit, it is better to merge 
Ming's port and your fix that span in several commit into single commit. The 
commit message need to contain all port and fix as well. Any better option from 
your mind?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1065: HAWQ-1208. Porting gpdb interconnect fix ...

[stanlyxiang]

GitHub user stanlyxiang opened a pull request:

https://github.com/apache/incubator-hawq/pull/1065

HAWQ-1208. Porting gpdb interconnect fix to hawq.

cc @liming01 @wengyanqing @huor 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyxiang/incubator-hawq gpdb_interconn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1065.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1065


commit 34b301a41cd453e455ef6944d3544d22d7dfbe64
Author: Ming LI 
Date:   2016-12-09T11:35:12Z

HAWQ-1208. Porting gpdb interconnect fix to hawq

This commit includes below commits in gpdb:
--
commit ce9cf07073946644b9dbc9a2fa0c1ca1179c57ee
Author: xiongg1 
Date:   Wed Jun 10 19:31:05 2015 -0400

[JIRA: MPP-25589] interconnect timeout bug

commit 615934aa7cf87eab9b258cb56eae7766aabab979
Author: tangp4 
Date:   Tue Jul 7 22:00:24 2015 -0400

[JIRA: MPP-25497] Fix the coverity defect CIDs: 16672

commit ae75ad81020533e0acc69daba086581dbca68ed2
Author: TangPengzhou 
Date:   Thu May 21 17:36:30 2015 +0800

[JIRA: MPP-25497]  Shutdown interconnect thread before shmem_exit()

Sometimes, if a FATAL level error occurs, shmem_exit() freed contexts 
that
still being accessed by ic thread, this cause a segment fault 
unexpectedly.

commit 08f5afc6272b96ea54281c0b56bb8e0431acd3be
Author: Ming LI 
Date:   2016-12-09T11:54:59Z

HAWQ-1208. Porting gpdb interconnect fix to hawq #2

This commit includes below commits in gpdb:
---
commit 2d7d0735f5b862d62a84d446f6dd2ce44b0df250
Author: Gang Xiong 
Date:   Sun Jan 3 13:37:34 2016 -0500

[JIRA:MPP-26123] Handle corner case of interconnect ack packet

When the ack packet is resent with UDPIC_FLAGS_STOP set, we need to make
sure the sender is aware of that. Otherwise, the sender will hang there
forever.

commit ad8328423661cb64e7b905df4928e48d532653b9
Author: Heikki Linnakangas 
Date:   Sun Aug 30 00:11:17 2015 +0300

[MPP-25631] Remove unnecessary #includes.

No particular urgency to clean up just these, just something that 
caught my
eye while browsing the code.

commit 65809c0bf53a665a16e467331ea6e7d65aee54c6
Author: xiongg1 
Date:   Mon Jun 15 19:36:55 2015 -0400

[JIRA: MPP-25590] Wrong error message when socket is exhausted on master

commit 0367fb0935d705a55f6c941d5b40457efd0bf8de
Author: Ming LI 
Date:   2016-12-19T05:12:58Z

HAWQ-1208. Porting gpdb interconnect fix to hawq #3

commit a343ed5bfd992b10137ad232f241be72857d6ea2
Author: gpadmin 
Date:   Thu Oct 27 18:58:54 2016 +

Add GUC called gp_interconnect_tcp_listener_backlog for tcp 
interconnect to control the backlog param of listen call

commit eda343b5050e31764154698f25e88d6f3fa7e957
Author: Kenan Yao 
Date:   Tue Oct 25 16:10:05 2016 +0800

Fix a bug in function destroyConnHashTable which frees a wrong pointer 
and
should cause SIGSEGV.

Signed-off-by: Pengzhou Tang 

commit 616f3c8f0ea372e01d166f4a6c52c6075a74ecd3
Author: Pengzhou Tang 
Date:   Tue Apr 5 10:50:55 2016 +0800

Fix coverity issue for 7e8f391dfdd

commit 7e8f391dfdd8945573d8b621533626813f8f7684
Author: tangpengzhou 
Date:   Mon Mar 28 23:47:48 2016 +

Fix tcp socket/port leak when interconnect type is udp or udpifc

Since gpdb don't allow changing interconnect type after connection 
started, it's unnecessary to
allocate a tcp socket and port for hot switching from udp/udpifc to tcp.

commit 7e8f391dfdd8945573d8b621533626813f8f7684
Author: tangpengzhou 
Date:   Mon Mar 28 23:47:48 2016 +

Fix tcp socket/port leak when interconnect type is udp or udpifc

Since gpdb don't allow changing interconnect type after connection 
started, it's unnecessary to
allocate a tcp socket and port for hot switching from udp/udpifc to tcp.

commit 8ec73f12c99cae321c301a079f2cae2914fc
Author: Pengzhou Tang 
Date:   Thu Mar 3 15:36:06 2016 +0800

Fix incorrect EOS warning message generated by direct-dispatch type 
queries

QD should not expect end-of-stream comes from QEs who is 

[jira] [Commented] (HAWQ-398) Port Interconnect Hanging Bug Fix from GPDB to HAWQ

[Ming LI (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15774669#comment-15774669
 ] 

Ming LI commented on HAWQ-398:
--

This fix will be merged by HAWQ-1208 which porting many import fixes in gpdb 
inter connnector to hawq all in once.

> Port Interconnect Hanging Bug Fix from GPDB to HAWQ
> ---
>
> Key: HAWQ-398
> URL: https://issues.apache.org/jira/browse/HAWQ-398
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Interconnect
>Reporter: Lirong Jian
>Assignee: Lei Chang
> Fix For: backlog
>
>
> There is an known issue with UDP Interconnect, which has been fixed in GPDB: 
> https://github.com/greenplum-db/gpdb/pull/336/. We should port the fix to 
> HAWQ.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)