[jira] [Assigned] (HAWQ-1379) Do not send options multiple times in build_startup_packet()

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo reassigned HAWQ-1379:
--

Assignee: Paul Guo  (was: Ed Espino)

> Do not send options multiple times in build_startup_packet()
> 
>
> Key: HAWQ-1379
> URL: https://issues.apache.org/jira/browse/HAWQ-1379
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> build_startup_packet() build a libpq packet, however it includes 
> conn->pgoptions more than 1 time - this is is unnecessary and really wastes 
> network bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HAWQ-1380) Keep hawq_toolkit schema check in HAWQ native side

[Hongxu Ma (JIRA)]

Hongxu Ma created HAWQ-1380:
---

 Summary: Keep hawq_toolkit schema check in HAWQ native side
 Key: HAWQ-1380
 URL: https://issues.apache.org/jira/browse/HAWQ-1380
 Project: Apache HAWQ
  Issue Type: Sub-task
Reporter: Hongxu Ma
Assignee: Ed Espino
 Fix For: 2.2.0.0-incubating


Given that *hawq_toolkit* is an administrative schema, let's keep it in HAWQ 
Native, outside of Ranger. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (HAWQ-1380) Keep hawq_toolkit schema check in HAWQ native side

[Hongxu Ma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongxu Ma reassigned HAWQ-1380:
---

Assignee: Hongxu Ma  (was: Ed Espino)

> Keep hawq_toolkit schema check in HAWQ native side
> --
>
> Key: HAWQ-1380
> URL: https://issues.apache.org/jira/browse/HAWQ-1380
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Security
>Reporter: Hongxu Ma
>Assignee: Hongxu Ma
> Fix For: 2.2.0.0-incubating
>
>
> Given that *hawq_toolkit* is an administrative schema, let's keep it in HAWQ 
> Native, outside of Ranger. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1163: HAWQ-1379. Do not send options multiple t...

[paul-guo-]

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/1163

HAWQ-1379. Do not send options multiple times in build_startup_packet()

This patch also tweak the related code a bit.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq misc2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1163


commit 9d47315cb44024b572945cb0936864e71391286e
Author: Paul Guo 
Date:   2017-03-07T07:14:14Z

HAWQ-1379. Do not send options multiple times in build_startup_packet()

This patch also tweak the related code a bit.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (HAWQ-1379) Do not send options multiple times in build_startup_packet()

[Paul Guo (JIRA)]

Paul Guo created HAWQ-1379:
--

 Summary: Do not send options multiple times in 
build_startup_packet()
 Key: HAWQ-1379
 URL: https://issues.apache.org/jira/browse/HAWQ-1379
 Project: Apache HAWQ
  Issue Type: Bug
Reporter: Paul Guo
Assignee: Ed Espino


build_startup_packet() build a libpq packet, however it includes 
conn->pgoptions more than 1 time - this is is unnecessary and really wastes 
network bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1161: HAWQ-1377. Add more information for Range...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1161#discussion_r104591806
  
--- Diff: src/backend/utils/misc/etc/hawq-site.xml ---
@@ -163,24 +163,22 @@ under the License.
 
 hawq_rps_address_host
 localhost
-Ranger plugin server address hostname.
- For example, HAWQ Ranger plugin server address is 
localhost:8432/rps.
-
+Ranger plugin server address hostname.
 
 
 
 hawq_rps_address_port
 8432
-Ranger plugin server address port number.
- For example, HAWQ Ranger plugin server address is 
localhost:8432/rps.
-
+Ranger plugin server address port 
number.
--- End diff --

The port number of Ranger Plugin Service 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1161: HAWQ-1377. Add more information for Range...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1161#discussion_r104591869
  
--- Diff: src/backend/utils/misc/etc/hawq-site.xml ---
@@ -163,24 +163,22 @@ under the License.
 
 hawq_rps_address_host
 localhost
-Ranger plugin server address hostname.
- For example, HAWQ Ranger plugin server address is 
localhost:8432/rps.
-
+Ranger plugin server address hostname.
 
 
 
 hawq_rps_address_port
 8432
-Ranger plugin server address port number.
- For example, HAWQ Ranger plugin server address is 
localhost:8432/rps.
-
+Ranger plugin server address port 
number.
 
 
 
 hawq_rps_address_suffix
 rps
-Ranger plugin server suffix of restful service 
address.
--- End diff --

the suffix of Ranger Plugin Service. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1161: HAWQ-1377. Add more information for Range...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1161#discussion_r104591559
  
--- Diff: src/backend/utils/misc/etc/hawq-site.xml ---
@@ -163,24 +163,22 @@ under the License.
 
 hawq_rps_address_host
 localhost
-Ranger plugin server address hostname.
- For example, HAWQ Ranger plugin server address is 
localhost:8432/rps.
-
+Ranger plugin server address hostname.
--- End diff --

The description can be "The hostname of Ranger plugin server" 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1157: HAWQ-1371. Fix QE process hang in shared ...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1157#discussion_r104572394
  
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -634,16 +634,16 @@ static int retry_read(int fd, char *buf, int rsize)
 
 read_retry:
sz = read(fd, buf, rsize);
-   if (sz > 0)
+   if (sz >= 0)  
return sz;
-   else if(sz == 0 || errno == EINTR)
+   else if(errno == EINTR)
--- End diff --

It's set as bocking IO in this case AFAIK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (HAWQ-1374) RPS still uses policies from 'hawq' serviceName even when name is changed in rps.properties

[Alexander Denissov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Denissov resolved HAWQ-1374.
--
   Resolution: Fixed
Fix Version/s: 2.2.0.0-incubating

> RPS still uses policies from 'hawq' serviceName even when name is changed in 
> rps.properties
> ---
>
> Key: HAWQ-1374
> URL: https://issues.apache.org/jira/browse/HAWQ-1374
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Security
>Reporter: Alexander Denissov
>Assignee: Alexander Denissov
> Fix For: 2.2.0.0-incubating
>
>
> Ranger Plugin Service can be configured which policy set to use when 
> requesting access policies from the Ranger Admin. The property is 
> RANGER_HAWQ_INSTANCE in rps.properties file.
> However, currently, changing this name does not result in RPS requesting the 
> appropriate policy set, RPS still fetches policies defined under 'hawq' 
> instance.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1157: HAWQ-1371. Fix QE process hang in shared ...

[wengyanqing]

Github user wengyanqing commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1157#discussion_r104548625
  
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -634,16 +634,16 @@ static int retry_read(int fd, char *buf, int rsize)
 
 read_retry:
sz = read(fd, buf, rsize);
-   if (sz > 0)
+   if (sz >= 0)  
return sz;
-   else if(sz == 0 || errno == EINTR)
+   else if(errno == EINTR)
--- End diff --

It needs to handle EAGAIN in nonblocking read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (HAWQ-1377) Add more information for Ranger related GUCs in default hawq-site.xml

[Chunling Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chunling Wang reassigned HAWQ-1377:
---

Assignee: Chunling Wang  (was: Ed Espino)

> Add more information for Ranger related GUCs in default hawq-site.xml
> -
>
> Key: HAWQ-1377
> URL: https://issues.apache.org/jira/browse/HAWQ-1377
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Security
>Reporter: Chunling Wang
>Assignee: Chunling Wang
> Fix For: 2.2.0.0-incubating
>
>
> We should add default GUCs for Ranger in sample hawq-site.xml, just as what 
> resource manager does, so that users don't need to refer to the documents for 
> detailed GUC names.
> The output content should be like follows:
> {code}
> 
> 
> hawq_acl_type
> standalone
> 
> 
> hawq_rps_address_host
> localhost
> 
> 
> hawq_rps_address_suffix
> rps
> 
> 
> hawq_rps_address_port
> 8432
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1162: HAWQ-1378. Elaborate the "invalid command...

[paul-guo-]

GitHub user paul-guo- opened a pull request:

https://github.com/apache/incubator-hawq/pull/1162

HAWQ-1378. Elaborate the "invalid command-line arguments for server p…

…rocess" error.

This patch mostly follows the pg commit below.

commit 86947e666d39229558311d7b0be45608fd071ed8
Author: Peter Eisentraut 
Date:   Sun Mar 11 01:52:05 2012 +0200

Add more detail to error message for invalid arguments for server 
process

It now prints the argument that was at fault.

Also fix a small misbehavior where the error message issued by
getopt() would complain about a program named "--single", because
that's what argv[0] is in the server process.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-guo-/incubator-hawq misc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1162


commit 29dc87c07c9b312d7bb5a00c376ee65bd2b2deac
Author: Paul Guo 
Date:   2017-03-06T07:36:08Z

HAWQ-1378. Elaborate the "invalid command-line arguments for server 
process" error.

This patch mostly follows the pg commit below.

commit 86947e666d39229558311d7b0be45608fd071ed8
Author: Peter Eisentraut 
Date:   Sun Mar 11 01:52:05 2012 +0200

Add more detail to error message for invalid arguments for server 
process

It now prints the argument that was at fault.

Also fix a small misbehavior where the error message issued by
getopt() would complain about a program named "--single", because
that's what argv[0] is in the server process.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (HAWQ-1378) Elaborate the "invalid command-line arguments for server process" error.

[Paul Guo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Guo reassigned HAWQ-1378:
--

Assignee: Paul Guo  (was: Ed Espino)

> Elaborate the "invalid command-line arguments for server process" error.
> 
>
> Key: HAWQ-1378
> URL: https://issues.apache.org/jira/browse/HAWQ-1378
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Paul Guo
>
> I saw the following errors when running several times,
> "Error dispatching to ***: connection pointer is NULL."
> FATAL:  invalid command-line arguments for server process
> While this usually means there is bug in related code but the code should 
> have reported more detailed log so that we could catch what argument is wrong 
> with less pain, even there is log level switch for argument dumping.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HAWQ-1378) Elaborate the "invalid command-line arguments for server process" error.

[Paul Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897170#comment-15897170
 ] 

Paul Guo commented on HAWQ-1378:


There have been a related pg upstream patch. It looks good. We could basically 
follow that.

   commit 86947e666d39229558311d7b0be45608fd071ed8
Author: Peter Eisentraut 
Date:   Sun Mar 11 01:52:05 2012 +0200

Add more detail to error message for invalid arguments for server 
process

It now prints the argument that was at fault.

Also fix a small misbehavior where the error message issued by
getopt() would complain about a program named "--single", because
that's what argv[0] is in the server process.

> Elaborate the "invalid command-line arguments for server process" error.
> 
>
> Key: HAWQ-1378
> URL: https://issues.apache.org/jira/browse/HAWQ-1378
> Project: Apache HAWQ
>  Issue Type: Bug
>Reporter: Paul Guo
>Assignee: Ed Espino
>
> I saw the following errors when running several times,
> "Error dispatching to ***: connection pointer is NULL."
> FATAL:  invalid command-line arguments for server process
> While this usually means there is bug in related code but the code should 
> have reported more detailed log so that we could catch what argument is wrong 
> with less pain, even there is log level switch for argument dumping.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HAWQ-1378) Elaborate the "invalid command-line arguments for server process" error.

[Paul Guo (JIRA)]

Paul Guo created HAWQ-1378:
--

 Summary: Elaborate the "invalid command-line arguments for server 
process" error.
 Key: HAWQ-1378
 URL: https://issues.apache.org/jira/browse/HAWQ-1378
 Project: Apache HAWQ
  Issue Type: Bug
Reporter: Paul Guo
Assignee: Ed Espino


I saw the following errors when running several times,

"Error dispatching to ***: connection pointer is NULL."
FATAL:  invalid command-line arguments for server process

While this usually means there is bug in related code but the code should have 
reported more detailed log so that we could catch what argument is wrong with 
less pain, even there is log level switch for argument dumping.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)