[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix HAWQ make install with DES...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1184


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
OK, so +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
They are all generated by 'pg_config', they should not be relative PATH. 


# Extension makefiles should set PG_CONFIG, but older ones might not
ifndef PG_CONFIG
PG_CONFIG = pg_config
endif

bindir := $(shell $(PG_CONFIG) --bindir)
datadir := $(shell $(PG_CONFIG) --sharedir)
sysconfdir := $(shell $(PG_CONFIG) --sysconfdir)
libdir := $(shell $(PG_CONFIG) --libdir)
pkglibdir := $(shell $(PG_CONFIG) --pkglibdir)
includedir := $(shell $(PG_CONFIG) --includedir)
pkgincludedir := $(shell $(PG_CONFIG) --pkgincludedir)
mandir := $(shell $(PG_CONFIG) --mandir)
docdir := $(shell $(PG_CONFIG) --docdir)
localedir := $(shell $(PG_CONFIG) --localedir)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
If you can make sure all of the later paths are absolute path, it will be 
fine, e.g.
${DESTDIR}${docdir}
${DESTDIR}$(bindir)
${DESTDIR}${libdir}
$(DESTDIR)${sysconfdir}

I'm just a bit worried about the could be a bug in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1180: HAWQ-1396. Fix the bug when query hcatalog via P...

[zhangh43]

Github user zhangh43 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1180
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1183: HAWQ-1400. An improvement in SQL Util des...

[jiny2]

Github user jiny2 closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1183


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
@paul-guo- 
I don't think the --prefix option can set a relative path, so there is 
definitely no need to add a '/' between DESTDIR and PREFIX-DIR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
Cool work! I just have one concern.
 
I saw a lot of fix like this, however is is possible the later one is a 
relative path while DESTDIR has not a tailing / and this could lead to a bug, 
so maybe you could add / between them to prevent this, besides: 1) This will 
make code easier to read 2) even there is // in your path, it is not a problem 
also. How do you think?

$(DESTDIR)${sysconfdir}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1181: HAWQ-1398. Fixing invalid references in log stat...

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1181
  
elog supports formatting just like standard c function printf, etc. When I 
fixed a QD bug I modified some QD logs to use __func__. I think it will be a 
huge work to modify all, so I suggest we modify them when seeing them given 
this kind of bug is not functionality bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-1402) Update pxf-profiles.xml config file comments for all Hive-related profiles

[Lisa Owen (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937204#comment-15937204
 ] 

Lisa Owen commented on HAWQ-1402:
-

i assume this change is for the pxf-profiles.xml that is installed when you 
install the pxf rpms.  so, it will be effective/noticable in hawq 2.2.0.0.  
this file is used for command-line-managed clusters.  ambari-managed clusters 
have their own pxf-profiles.xml.  in what version of ambari will these perf 
statements be removed?

> Update pxf-profiles.xml config file comments for all Hive-related profiles
> --
>
> Key: HAWQ-1402
> URL: https://issues.apache.org/jira/browse/HAWQ-1402
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Ed Espino
> Fix For: 2.2.0.0-incubating
>
>
> Some performance-related statements are obsolete for Hive profiles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

[denalex]

Github user denalex commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1185#discussion_r107498956
  
--- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml ---
@@ -46,6 +46,7 @@ under the License.
 
 This profile is suitable for using when connecting to Hive.
 Supports GPDBWritable output format, as specified in FORMAT 
header parameter.
+Based on storage format, it uses one of optimized 
profiles(HiveRC, HiveText, HiveORC) whenever it's possible.
 
--- End diff --

Does it also need to be changed in Ambari since there is a corresponding 
template there ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

[denalex]

Github user denalex commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1185#discussion_r107498808
  
--- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml ---
@@ -46,6 +46,7 @@ under the License.
 
 This profile is suitable for using when connecting to Hive.
 Supports GPDBWritable output format, as specified in FORMAT 
header parameter.
+Based on storage format, it uses one of optimized 
profiles(HiveRC, HiveText, HiveORC) whenever it's possible.
--- End diff --

I'd say: "It auto-detects actual file storage format and uses an optimized 
profile (HiveRC, HiveText, HiveORC) if applicable."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

[sansanichfb]

GitHub user sansanichfb opened a pull request:

https://github.com/apache/incubator-hawq/pull/1185

HAWQ-1402. Updated comments for Hive-related profiles.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1402

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1185


commit a1334d4fb1fb0e70324ff948b58a58c165b92507
Author: Oleksandr Diachenko 
Date:   2017-03-22T18:36:56Z

HAWQ-1402. Updated comments for Hive-related profiles.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-1402) Update pxf-profiles.xml config file comments for all Hive-related profiles

[Oleksandr Diachenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Diachenko updated HAWQ-1402:
--
Description: Some performance-related statements are obsolete for Hive 
profiles.

> Update pxf-profiles.xml config file comments for all Hive-related profiles
> --
>
> Key: HAWQ-1402
> URL: https://issues.apache.org/jira/browse/HAWQ-1402
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Ed Espino
> Fix For: 2.2.0.0-incubating
>
>
> Some performance-related statements are obsolete for Hive profiles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HAWQ-1402) Update pxf-profiles.xml config file comments for all Hive-related profiles

[Oleksandr Diachenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Diachenko updated HAWQ-1402:
--
Fix Version/s: 2.2.0.0-incubating

> Update pxf-profiles.xml config file comments for all Hive-related profiles
> --
>
> Key: HAWQ-1402
> URL: https://issues.apache.org/jira/browse/HAWQ-1402
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Ed Espino
> Fix For: 2.2.0.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HAWQ-304) Support update and delete on non-heap tables

[Christian Tzolov (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936618#comment-15936618
 ] 

Christian Tzolov commented on HAWQ-304:
---

Glad to hear it works [~hongxu ma]!  

We are still working on correctness vs. efficiency implementation of the INSERT 
rule. We may end-up implementing two different InsertRule strategies and allow 
the user to configure the prefered one: 
https://github.com/tzolov/calcite-sql-rewriter/issues/2

Another observation. It seems like HAWQ doesn't support OVER-PARTITION-BY 
without an explicit ORDER BY! Furthermore it seems that HAWQ allays performs 
internal Sort  
My interpretation of Postgres spec: 
https://www.postgresql.org/docs/current/static/sql-expressions.html#SYNTAX-WINDOW-FUNCTIONS
 is that a missing `frame_clause` is equal to `ROWS BETWEEN UNBOUNDED PRECEDING 
AND UNBOUNDED FOLLOWING`. In both cases you shouldn't need ORDER BY.  
I assume that unnecessary SORT would incur undesired performance overhead. 


> Support update and delete on non-heap tables
> 
>
> Key: HAWQ-304
> URL: https://issues.apache.org/jira/browse/HAWQ-304
> Project: Apache HAWQ
>  Issue Type: Wish
>  Components: Storage
>Reporter: Lei Chang
>Assignee: Lili Ma
> Fix For: 3.0.0.0
>
> Attachments: mutable_table.sql
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...

[huor]

Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/1183
  
+1 for the fix. The clarification looks better to have root cause


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix HAWQ make install with DES...

[radarwave]

Github user radarwave commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1184#discussion_r107420381
  
--- Diff: tools/bin/pythonSrc/PyGreSQL-4.0/setup.py ---
@@ -62,6 +62,11 @@ def pg_config(s):
 raise Exception("pg_config tool is not available.")
 if not d:
 raise Exception("Could not get %s information." % s)
+
+DESTDIR = os.getenv('DESTDIR')
+if DESTDIR:
+print "DESTDIR is %s" % DESTDIR
--- End diff --

Thank, fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[huor]

Github user huor commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
Great to have the fix for build. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix HAWQ make install with DES...

[huor]

Github user huor commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1184#discussion_r107409405
  
--- Diff: tools/bin/pythonSrc/PyGreSQL-4.0/setup.py ---
@@ -62,6 +62,11 @@ def pg_config(s):
 raise Exception("pg_config tool is not available.")
 if not d:
 raise Exception("Could not get %s information." % s)
+
+DESTDIR = os.getenv('DESTDIR')
+if DESTDIR:
+print "DESTDIR is %s" % DESTDIR
--- End diff --

Need to remove the debug info here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix python modules install wit...

[radarwave]

GitHub user radarwave opened a pull request:

https://github.com/apache/incubator-hawq/pull/1184

HAWQ-1401. Fix python modules install with DESTDIR.

Need to handle pygresql install as it depend on the pre-installed hawq 
components.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/radarwave/incubator-hawq destdir

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1184


commit 7d0a03e2408ff6a07dfd628501354a9ac366582e
Author: rlei 
Date:   2017-03-22T04:41:01Z

HAWQ-1401. Fix python modules install with DESTDIR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1184
  
@edespino @paul-guo- @huor @xunzhang 
Please help to review, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---