[GitHub] incubator-hawq pull request #1211: HAWQ-1425. Print error message if ssh con...
Github user paul-guo- commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1211#discussion_r110319372 --- Diff: tools/bin/hawqpylib/hawqlib.py --- @@ -203,6 +203,17 @@ def check_hostname_equal(remote_host, user = ""): cmd = "hostname" result_local, local_hostname, stderr_remote = local_ssh_output(cmd) result_remote, remote_hostname, stderr_remote = remote_ssh_output(cmd, remote_host, user) +# SSH return 255 error code when having connection issues, otherwise return code is in [0, 255). +if result_remote == 255: +print "Create ssh connection to %s failed." % remote_host +print "Please check the ssh connection and make sure passwordless ssh enabled." +sys.exit(result_remote) +elif result_remote > 0: +print "Execute remote command failed." +sys.exit(result_remote) +else: +pass + --- End diff -- Judge via 255 seems to be wrong since the cmd could return 255, e.g. [pguo@host67:/home/pguo]$ ssh 127.0.0.1 'exit 255' [pguo@host67:/home/pguo]$ echo $? 255 I'm wondering whether we could show the error info in hawq utility output or log file, and we still check result_remote>0 and log for this condition like this: ssh command returns with error, either ssh connection fails or cmd exits with error. see more in log or. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1211: HAWQ-1425. Print error message if ssh connect fa...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1211 +1 for the fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (HAWQ-1426) hawq extract meets error after the table was reorganized.
[ https://issues.apache.org/jira/browse/HAWQ-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960282#comment-15960282 ] Lili Ma commented on HAWQ-1426: --- RCA: When hawq extract tries to find the HDFS files information, it wrongly treated the pg_aoseg.pg_aoseg_$relid as the catalog table for storing those information. When determining the file path of a table, hawq extract should follow below steps: 1. Find the directory on HDFS which stores the actual data for the table. This can be achieved by following the column "relfilenode" in pg_class table. 2. Find the detailed file name for the table under above directory. This can be achieved by searching the catalog table pg_aoseg.pg_aoseg(paqseg)_$. The table name suffix is neither $relid nor $relfilenode under some circumstances. We should get it by referring the column "segrelid" in catalog table "pg_appendonly", and then looking up the table "pg_class" to get the accurate table name. > hawq extract meets error after the table was reorganized. > - > > Key: HAWQ-1426 > URL: https://issues.apache.org/jira/browse/HAWQ-1426 > Project: Apache HAWQ > Issue Type: Bug > Components: Command Line Tools >Reporter: Lili Ma >Assignee: Ed Espino > Fix For: 2.3.0.0-incubating > > > After one table is reorganized, hawq extract the table will meet error. > Reproduce Steps: > 1. create an AO table > 2. insert into several records into it > 3. Get the table reorganized. "alter table a set with (reorganize=true);" > 4. run hawq extract, error thrown out. > For the bug fix, we should also guarantee that hawq extract should work if > the table is truncated and re-inserted. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-hawq pull request #1198: HAWQ-1417. Fixed crash when ANALYZE after...
Github user liming01 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 +1 for the fix as the mock of the verification is not feasible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (HAWQ-1423) cmock framework does not recognize __MAYBE_UNUSED.
[
https://issues.apache.org/jira/browse/HAWQ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radar Lei reassigned HAWQ-1423:
---
Assignee: Paul Guo (was: Radar Lei)
> cmock framework does not recognize __MAYBE_UNUSED.
> --
>
> Key: HAWQ-1423
> URL: https://issues.apache.org/jira/browse/HAWQ-1423
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
>Reporter: Ming LI
>Assignee: Paul Guo
> Fix For: 2.3.0.0-incubating
>
>
> This bug only exists on MacOS.
> Reproduce Steps:
> {code}
> 1. ./configure
> 2. make -j8
> 3. cd src/backend
> 4. make unittest-check
> {code}
> Build log:
> {code}
> ../../../../../src/test/unit/mock/backend/libpq/be-secure_mock.c:174:2:
> error: void function 'report_commerror'
> should not return a value [-Wreturn-type]
> return (__MAYBE_UNUSED) mock();
> ^ ~~~
> 1 error generated.
> make[4]: ***
> [../../../../../src/test/unit/mock/backend/libpq/be-secure_mock.o] Error 1
> make[3]: *** [mockup-phony] Error 2
> make[2]: *** [unittest-check] Error 2
> make[1]: *** [unittest-check] Error 2
> make: *** [unittest-check] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (HAWQ-1425) Incorrect init cluster error message while ssh connection failed
[ https://issues.apache.org/jira/browse/HAWQ-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radar Lei reassigned HAWQ-1425: --- Assignee: Radar Lei (was: Ed Espino) > Incorrect init cluster error message while ssh connection failed > > > Key: HAWQ-1425 > URL: https://issues.apache.org/jira/browse/HAWQ-1425 > Project: Apache HAWQ > Issue Type: Bug > Components: Command Line Tools >Reporter: Radar Lei >Assignee: Radar Lei > > If password-less ssh connection is not set, run hawq init cluster will give > wrong error message: > 'This can be run on master host only'. > Actually this might caused by ssh connection to master host failed. We should > handle this situation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
