[GitHub] incubator-hawq issue #1279: HAWQ-1310. Reformat resource_negotiator().

[jiny2]

Github user jiny2 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1279
  
Please close this pr as per my understanding it has been delivered last 
week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1279: HAWQ-1310. Reformat resource_negotiator().

[jinyismilodon]

Github user jinyismilodon commented on the issue:

https://github.com/apache/incubator-hawq/pull/1279
  
This has been delivered last week per my understanding, please close it 
@amyrazz44 . Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1280#discussion_r133107473
  
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
 krb_keytabfile = argv[5];
 }
 
+//get tde key name param
+for (int i = 1; i < argc; i++) {
+if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+tde_keyname = argv[i+1];
--- End diff --

thanks, I will fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-1510) Add TDE-related functionality into hawq command line tools

[Hongxu Ma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongxu Ma updated HAWQ-1510:

Description: 
1, hawq init
the only way to enable tde in hawq:
user should give a key name(already created by hadoop key command) parameter 
when execuate the init command, it makes the whole hawq_default directory as an 
encryption zone.

note:
cannot support transfer the existed(and non-empty) hawq_default directory into 
an encryption zone.

command:
{code}
hawq init cluster --tde_keyname key_demo
{code}

-2, hawq state-
-show the encryption zone info if user enable tde in hawq.-

3, hawq register 
cannot register file in different encryption zones / un-encryption zones.

4, hawq extract
give user a warning of the table data is stored in encryption zone if user 
enable tde in hawq.


  was:
1, hawq init
the only way to enable tde in hawq:
user should give a key name(already created by hadoop key command) parameter 
when execuate the init command, it makes the whole hawq_default directory as an 
encryption zone.

note:
cannot support transfer the existed(and non-empty) hawq_default directory into 
an encryption zone.

-2, hawq state-
-show the encryption zone info if user enable tde in hawq.-

3, hawq register 
cannot register file in different encryption zones / un-encryption zones.

4, hawq extract
give user a warning of the table data is stored in encryption zone if user 
enable tde in hawq.



> Add TDE-related functionality into hawq command line tools
> --
>
> Key: HAWQ-1510
> URL: https://issues.apache.org/jira/browse/HAWQ-1510
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Command Line Tools
>Reporter: Hongxu Ma
>Assignee: Hongxu Ma
> Fix For: 2.3.0.0-incubating
>
>
> 1, hawq init
> the only way to enable tde in hawq:
> user should give a key name(already created by hadoop key command) parameter 
> when execuate the init command, it makes the whole hawq_default directory as 
> an encryption zone.
> note:
> cannot support transfer the existed(and non-empty) hawq_default directory 
> into an encryption zone.
> command:
> {code}
> hawq init cluster --tde_keyname key_demo
> {code}
> -2, hawq state-
> -show the encryption zone info if user enable tde in hawq.-
> 3, hawq register 
> cannot register file in different encryption zones / un-encryption zones.
> 4, hawq extract
> give user a warning of the table data is stored in encryption zone if user 
> enable tde in hawq.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...

[amyrazz44]

Github user amyrazz44 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1280
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...

[amyrazz44]

Github user amyrazz44 commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1280#discussion_r132901535
  
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
 krb_keytabfile = argv[5];
 }
 
+//get tde key name param
+for (int i = 1; i < argc; i++) {
+if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+tde_keyname = argv[i+1];
--- End diff --

Add some comments in code about this will be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1280#discussion_r132900269
  
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
 krb_keytabfile = argv[5];
 }
 
+//get tde key name param
+for (int i = 1; i < argc; i++) {
+if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+tde_keyname = argv[i+1];
--- End diff --

why not use `argv[6]` as the `tde_keyname`?
because the params before it may be empty...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...

[interma]

Github user interma commented on the issue:

https://github.com/apache/incubator-hawq/pull/1280
  
@linwen @wengyanqing @amyrazz44 help to review, thanks.

Note:
Only include necessary code of **hawq-init**, other command modification 
will be added in another PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...

[interma]

GitHub user interma opened a pull request:

https://github.com/apache/incubator-hawq/pull/1280

HAWQ-1510. Add TDE-related functionality into hawq init command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/interma/interma-hawq HAWQ-1510-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1280


commit d312bea527927b845544e43347e0174c5eec032d
Author: interma 
Date:   2017-08-14T08:30:45Z

HAWQ-1510. Add TDE-related functionality into hawq init command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---