[GitHub] incubator-hawq issue #1151: HAWQ-1359. Add policy test for HAWQ with Ranger ...

[linwen]

Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/1151
  
+1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1151: HAWQ-1359. Add policy test for HAWQ with Ranger ...

[zhangh43]

Github user zhangh43 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1151
  
This PR use different users to run different queries, which is a 
consideration of performance. Since adding a policy in ranger will lead to 
several secs delay, and we use sleep() to ensure policy is ready. If we add 
policy for each query, the total sleep time is linear to the case number. So we 
choose to use run all the queries by different users and add policies firstly 
and then sleep only once, finally we run all the queries again with added 
policies to check whether policies work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1151: HAWQ-1359. Add policy test for HAWQ with Ranger ...

[zhangh43]

Github user zhangh43 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1151
  
Using rat to add licenses and remove some redundant file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1151: HAWQ-1359. Add policy test for HAWQ with Ranger ...

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1151
  
The shell scripts: Please add license header.
The tar.gz file: I'd suggest generating it dynamically.

Please make sure license check passes.

2017-02-28 11:47 GMT+08:00 Paul Guo :

> Maybe a.txt could  be a more meaningful file name?
> Is __init__.py useful? (If yes, please add license header).
>
> 2017-02-28 11:22 GMT+08:00 Huan Zhang :
>
>> Policy test includes different json requests(used by ranger) for
>> different quries, For example, for query "select * from a;", it needs 
usage
>> privilege of schema public, and select privilege of table a.
>> There are also queries can only be executed by superuser, we also test
>> them in policy test.
>>
>> Signed-off-by: Chuling Wang wangchunlin...@126.com
>> --
>> You can view, comment on, or merge this pull request online at:
>>
>>   https://github.com/apache/incubator-hawq/pull/1151
>> Commit Summary
>>
>>- HAWQ-1359. Add policy test for HAWQ with Ranger enabled.
>>
>> File Changes
>>
>>- *M* src/test/feature/ExternalSource/test_errortbl.cpp
>> (8)
>>- *A* src/test/feature/Ranger/__init__.py
>> (0)
>>- *A* src/test/feature/Ranger/a.txt
>> (2)
>>- *A* src/test/feature/Ranger/ans/adminfirst1.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst10.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst11.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst12.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst13.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst14.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst15.ans
>> (4)
>>- *A* src/test/feature/Ranger/ans/adminfirst16.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst17.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst18.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst19.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst2.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst20.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst21.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst22.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst23.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst24.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst25.ans
>>
>>(5)
>>- *A* src/test/feature/Ranger/ans/adminfirst26.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst27.ans
>>
>>(29)
>>- *A* src/test/feature/Ranger/ans/adminfirst28.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst29.ans
>>
>>(4)
>>- *A* src/test/feature/Ranger/ans/adminfirst3.ans
>>

[GitHub] incubator-hawq issue #1151: HAWQ-1359. Add policy test for HAWQ with Ranger ...

[paul-guo-]

Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1151
  
Maybe a.txt could  be a more meaningful file name?
Is __init__.py useful? (If yes, please add license header).

2017-02-28 11:22 GMT+08:00 Huan Zhang :

> Policy test includes different json requests(used by ranger) for different
> quries, For example, for query "select * from a;", it needs usage 
privilege
> of schema public, and select privilege of table a.
> There are also queries can only be executed by superuser, we also test
> them in policy test.
>
> Signed-off-by: Chuling Wang wangchunlin...@126.com
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/incubator-hawq/pull/1151
> Commit Summary
>
>- HAWQ-1359. Add policy test for HAWQ with Ranger enabled.
>
> File Changes
>
>- *M* src/test/feature/ExternalSource/test_errortbl.cpp
> (8)
>- *A* src/test/feature/Ranger/__init__.py
> (0)
>- *A* src/test/feature/Ranger/a.txt
> (2)
>- *A* src/test/feature/Ranger/ans/adminfirst1.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst10.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst11.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst12.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst13.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst14.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst15.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst16.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst17.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst18.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst19.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst2.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst20.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst21.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst22.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst23.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst24.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst25.ans
> (5)
>- *A* src/test/feature/Ranger/ans/adminfirst26.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst27.ans
>
>(29)
>- *A* src/test/feature/Ranger/ans/adminfirst28.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst29.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst3.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst30.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst31.ans
> (4)
>- *A* src/test/feature/Ranger/ans/adminfirst32.ans
> (