[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @edespino, closing the PR. Thanks for the notification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @huor - As this has been committed, can you please close this PR now? Thanks buddy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 Thanks @edespino for your feedback. I have bundled the license/* in hawq binary release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @rvs, we have separate rpm packages for hawq c/c++ components, and java components (pxf, ranger). ```hawq_rpm_packages âââ apache-hawq-2.2.0.0-el7.x86_64.rpm âââ apache-tomcat-7.0.62-el6.noarch.rpm âââ hawq-ranger-plugin-2.2.0.0-1.el7.centos.noarch.rpm âââ pxf-3.2.1.0-1.el6.noarch.rpm âââ pxf-hbase-3.2.1.0-1.el6.noarch.rpm âââ pxf-hdfs-3.2.1.0-1.el6.noarch.rpm âââ pxf-hive-3.2.1.0-1.el6.noarch.rpm âââ pxf-jdbc-3.2.1.0-1.el6.noarch.rpm âââ pxf-json-3.2.1.0-1.el6.noarch.rpm âââ pxf-service-3.2.1.0-1.el6.noarch.rpm ``` It contains LICENSE, NOTICE, and DISCLAIMER files for hawq c/c++ components in this PR, i.e., apache-hawq-2.2.0.0-el7.x86_64.rpm. For pxf (pxf-*.rpm, apache-tomcat-7.0.62-el6.noarch.rpm) and ranger (hawq-ranger-plugin-2.2.0.0-1.el7.centos.noarch.rpm), there are incompatible license and we will do them in separate PR once your feedback for pxf and ranger part is available. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 I guess my point is -- this still doesn't address the Java side of things. Do you plan to do it in a separate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @rvs, thanks for the review and feedback. You are right. We expand the LICENSE for source release by adding extra dependency to get that for binary release. Here is the changes: ``` rhuo-mbp:incubator-hawq rhuo$ diff dist/hawq/LICENSE LICENSE 265,270d264 < (BSD 2 Clause) Google Mock (https://github.com/google/googletest/tree/master/googlemock)src/bin/pg_dump > src/backend/port/qnx4/shm.c > src/backend/port/beos/shm.c ``` For the NOTICE, the dependencies are either ASL v2 or category B license with no LICENSE with themselves, so there is not change according to https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors. Please let us know your comments for further refinement. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @huor I'm a bit confused -- it appears that both LICENSE and NOTICE files you added are copies of what already exists in the repo. For the binary distribution we need a much more expanded set (as per your Google doc spreadsheet) right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @rvs, @edespino, @paul-guo- @radarwave, please review and let us know your feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
