[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-09-05 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@outofmem0ry There is no jira number in your commit, I have add it and 
merged this commit.  Please close this PR. Thanks.


---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-09-05 Thread outofmem0ry
Github user outofmem0ry commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@radarwave Done. Thank you for the review


---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-09-04 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@outofmem0ry Please squash your commits and rewrite the commit messages as 
now the answer file is not changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-08-31 Thread outofmem0ry
Github user outofmem0ry commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@paul-guo- @radarwave do you need any other inputs needed from my side ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-08-02 Thread radarwave
Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-08-02 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-08-01 Thread outofmem0ry
Github user outofmem0ry commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
@paul-guo- updated the doc as per the review comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

2017-07-05 Thread paul-guo-
Github user paul-guo- commented on the issue:

https://github.com/apache/incubator-hawq/pull/1263
  
You could run the test using parallel-run-feature-test.sh.

Basically the test need to set some properties so that ans files are 
uniform.
In parallel-run-feature-test.sh, e.g. the date style is set as below,

  run_sql "alter database $TEST_DB_NAME set datestyle to 'postgres,MDY';"

An ideal fix for this is to document it in readme, warning not to run 
googletest directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---