[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user jiadexin commented on the issue: https://github.com/apache/incubator-hawq/pull/972 closes #972 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/972 @shivzone - for future reference, there are two ways a PR can be automatically closed that I rely on regularly: - You can reference the pull request in the commit description or body of the commit message (e.g. "closes #972), the PR will automatically be closed. - If the review branch has been recently rebased on master, the sha1 in the review branch and master can be the same after the merge process. If this is the case, the PR will detect the change has been merged and the PR is automatically closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/972 Its merged. Please close the pull request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user michaelandrepearce commented on the issue: https://github.com/apache/incubator-hawq/pull/972 Can this be merged now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/972 @jiadexin java8 has stricter checks with code comments to be javadoc compatible. Please fix the above errors pointed by @edespino --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/972 Shouldn't there be an update of the classpath files located in pxf/pxf-service/src/main/resources with: ``` /usr/lib/pxf/pxf-jdbc-*[0-9].jar ``` Should the vendor specific jdbc drivers also be added to these files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/972 I pulled the PR source locally and attempted to build it on my Mac OS X 10.12.3/Java 1.8.0_121. The pxf-jdbc:javadoc build operation failed with the following output: ``` 08:50 $ javac -version javac 1.8.0_121 â ~/workspace/HAWQ/incubator-hawq/pxf [PR-972 L|â¦3] 08:50 $ java -version java version "1.8.0_121" Java(TM) SE Runtime Environment (build 1.8.0_121-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode) â ~/workspace/HAWQ/incubator-hawq/pxf [PR-972 L|â¦3] 08:50 $ system_profiler SPSoftwareDataType Software: System Software Overview: System Version: macOS 10.12.3 (16D32) Kernel Version: Darwin 16.4.0 Boot Volume: Macintosh HD Boot Mode: Normal Computer Name: EdEspino User Name: Ed Espino (eespino) Secure Virtual Memory: Enabled System Integrity Protection: Disabled Time since boot: 3 days 19:44 â ~/workspace/HAWQ/incubator-hawq/pxf [PR-972 L|â¦3] 08:51 $ â ~/workspace/HAWQ/incubator-hawq/pxf [PR-972 L|â¦3] 08:51 $ make ./gradlew clean release :clean UP-TO-DATE :pxf:clean :pxf-api:clean :pxf-hbase:clean :pxf-hdfs:clean :pxf-hive:clean :pxf-jdbc:clean :pxf-json:clean UP-TO-DATE :pxf-service:clean :pxf:compileJava UP-TO-DATE :pxf:processResources UP-TO-DATE :pxf:classes UP-TO-DATE :pxf:jar SKIPPED :pxf:assemble UP-TO-DATE :pxf:compileTestJava UP-TO-DATE :pxf:processTestResources UP-TO-DATE :pxf:testClasses UP-TO-DATE :pxf:test UP-TO-DATE :pxf:check UP-TO-DATE :pxf:build UP-TO-DATE :pxf:buildRpm :pxf:distTar UP-TO-DATE :pxf:javadoc UP-TO-DATE :pxf-api:compileJava :pxf-api:processResources UP-TO-DATE :pxf-api:classes :pxf-api:jar :pxf-api:assemble :pxf-api:compileTestJavaNote: /Users/eespino/workspace/HAWQ/incubator-hawq/pxf/pxf-api/src/test/java/org/apache/hawq/pxf/api/utilities/ColumnDescriptorTest.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. :pxf-api:processTestResources UP-TO-DATE :pxf-api:testClasses :pxf-api:test :pxf-api:check :pxf-api:build :pxf-api:javadoc :pxf-hbase:compileJava :pxf-hbase:processResources UP-TO-DATE :pxf-hbase:classes :pxf-hbase:jar :pxf-hbase:assemble :pxf-hbase:compileTestJava :pxf-hbase:processTestResources UP-TO-DATE :pxf-hbase:testClasses :pxf-hbase:test :pxf-hbase:check :pxf-hbase:build :pxf-hbase:buildRpm :pxf-hbase:distTar :pxf-hbase:javadoc :pxf-hdfs:compileJava :pxf-hdfs:processResources UP-TO-DATE :pxf-hdfs:classes :pxf-hdfs:jar :pxf-hdfs:assemble :pxf-hdfs:compileTestJava :pxf-hdfs:processTestResources UP-TO-DATE :pxf-hdfs:testClasses :pxf-hdfs:test :pxf-hdfs:check :pxf-hdfs:build :pxf-hdfs:buildRpm :pxf-hdfs:distTar :pxf-hdfs:javadoc :pxf-service:generateSources :pxf-service:compileJava :pxf-service:processResources :pxf-service:classes :pxf-service:jar :pxf-hive:compileJava :pxf-hive:processResources UP-TO-DATE :pxf-hive:classes :pxf-hive:jar :pxf-hive:assemble :pxf-hive:compileTestJavaNote: /Users/eespino/workspace/HAWQ/incubator-hawq/pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilitiesTest.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: /Users/eespino/workspace/HAWQ/incubator-hawq/pxf/pxf-hive/src/test/java/org/apache/hawq/pxf/plugins/hive/HiveORCAccessorTest.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :pxf-hive:processTestResources UP-TO-DATE :pxf-hive:testClasses :pxf-hive:test :pxf-hive:check :pxf-hive:build :pxf-hive:buildRpm :pxf-hive:distTar :pxf-service:javadoc UP-TO-DATE :pxf-hive:javadoc :pxf-jdbc:compileJava :pxf-jdbc:processResources UP-TO-DATE :pxf-jdbc:classes :pxf-jdbc:jar :pxf-jdbc:assemble :pxf-jdbc:compileTestJava :pxf-jdbc:processTestResources UP-TO-DATE :pxf-jdbc:testClasses :pxf-jdbc:test :pxf-jdbc:check :pxf-jdbc:build :pxf-jdbc:buildRpm :pxf-jdbc:distTar :pxf-jdbc:javadoc/Users/eespino/workspace/HAWQ/incubator-hawq/pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java:238: warning: no description for @throws * @throws Exception ^ /Users/eespino/workspace/HAWQ/incubator-hawq/pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java:40: warning: empty tag * ^
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user ig-michaelpearce commented on the issue: https://github.com/apache/incubator-hawq/pull/972 @shivzone do other pxf plugins have this? I cannot see this. Could this be merged and then later address in a follow on JIRA? Seems this has stalled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/972 @jiadexin the next step is for us to discuss the Integration testing. We can discuss about this in the Jira HAWQ-1108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/972 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user jiadexin commented on the issue: https://github.com/apache/incubator-hawq/pull/972 @shivzoneIf there are no partitions, then only one fragment. if have partitions ,HAWQ-MASTER scheduling strategy support is required. HDFS is distributed, and pxf-hdfs can allocate hosts for the fragment via the hdfs file metadata. The role of pxf-jdbc is mainly used to integrate the enterprise has been running the traditional relational database, these systems are generally stand-alone system, may not deploy PXF Engine. In the current HAWQ PXF engine implementation, pxf-instance can not know all pxf-hosts, so only the current host name can be assigned. if configured in the LOCATION in the DDL, when a large number of 'pxf hosts' is used, the DDL statement is extremely long. and not flexible. i think, HAWQ-MASTER wants to support a scheduling strategy: when the fragment host name is null, HAWQ-MASTER automatically assigned a HAWQ-segment host. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #972: HAWQ-1108 Add JDBC PXF Plugin
Github user jiadexin commented on the issue: https://github.com/apache/incubator-hawq/pull/972 @hornn Thank you for your suggestion, the original code has some of casually. Some of the recommendations I replied to you , the other already changed in accordance with the your recommendations . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
