[GitHub] incubator-hawq pull request #807: HAWQ-897. Add feature test for create tabl...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/807#discussion_r76211338
  
--- Diff: src/test/feature/catalog/test_create_table.cpp ---
@@ -22,26 +22,26 @@ class TestCreateTable : public ::testing::Test {
 TEST_F(TestCreateTable, TestCreateTable1) {
   hawq::test::SQLUtility util;
   // prepare
-  util.execute("DROP TABLE IF EXISTS aggtest");
--- End diff --

I think jinyi's intent is to test "create/drop table".

Actually the constructor and destructor of class hawq::test::SQLUtility are 
exactly doing what you've suggested.

See src/test/feature/lib/sql_util.cpp for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #807: HAWQ-897. Add feature test for create tabl...

[hsyuan]

Github user hsyuan commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/807#discussion_r76184425
  
--- Diff: src/test/feature/catalog/test_create_table.cpp ---
@@ -22,26 +22,26 @@ class TestCreateTable : public ::testing::Test {
 TEST_F(TestCreateTable, TestCreateTable1) {
   hawq::test::SQLUtility util;
   // prepare
-  util.execute("DROP TABLE IF EXISTS aggtest");
--- End diff --

The easier way to do this is creating a new schema `X`, set the default 
search_path to `X`. At the end of the test, drop the schema. In this way, you 
don't need to take care of dropping tables when you add new test cases. This is 
how GPDB is doing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #807: HAWQ-897. Add feature test for create tabl...

[jiny2]

GitHub user jiny2 opened a pull request:

https://github.com/apache/incubator-hawq/pull/807

HAWQ-897. Add feature test for create table distribution with new test 
framework



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jiny2/incubator-hawq HAWQ-897

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #807


commit 5fb757d8597b6dfa3e64cda81260e4d819e1793c
Author: YI JIN 
Date:   2016-07-21T04:28:24Z

HAWQ-897. Add feature test for create table distribution with new test 
framework




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---