[GitHub] incubator-hawq pull request #853: HAWQ-967. Extend Projection info to includ...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hawq/pull/853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #853: HAWQ-967. Extend Projection info to includ...
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/853#discussion_r76117988
--- Diff: src/backend/access/external/pxffilters.c ---
@@ -451,6 +452,51 @@ opexpr_to_pxffilter(OpExpr *expr, PxfFilterDesc
*filter)
return false;
}
+static List*
+append_attr_from_var(Var* var, List* attrs)
+{
+ AttrNumber varattno = var->varattno;
+ /* system attr not supported */
+ if (varattno > InvalidAttrNumber)
--- End diff --
@kavinderd, yes, physical attributes should have positive value, some
system attributes have -1, and we are not projecting them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #853: HAWQ-967. Extend Projection info to includ...
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/853#discussion_r76100388
--- Diff: src/backend/access/external/pxffilters.c ---
@@ -451,6 +452,51 @@ opexpr_to_pxffilter(OpExpr *expr, PxfFilterDesc
*filter)
return false;
}
+static List*
+append_attr_from_var(Var* var, List* attrs)
+{
+ AttrNumber varattno = var->varattno;
+ /* system attr not supported */
+ if (varattno > InvalidAttrNumber)
--- End diff --
So the `varattno` is only valid when greater than `InvalidAttrNumber`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #853: HAWQ-967. Extend Projection info to includ...
GitHub user sansanichfb opened a pull request: https://github.com/apache/incubator-hawq/pull/853 HAWQ-967. Extend Projection info to include filter attributes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-hawq HAWQ-967 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #853 commit 64c3af08025add685701aca785f1ce6d2c86a81a Author: Oleksandr Diachenko Date: 2016-08-08T20:16:24Z HAWQ-967. Project additional columns from basic WHERE clause. commit 36f68c2af4bdad75f051161e423ff46670cbf689 Author: Oleksandr Diachenko Date: 2016-08-11T01:09:25Z HAWQ-967. Support OR, NOT. commit d0e541938c60698c46669c56af7bcf212a3de970 Author: Oleksandr Diachenko Date: 2016-08-19T00:00:43Z HAWQ-975. Added support for IS (NOT) NULL. commit f40b2918eca1fb1293781354cef8c1d216b07b30 Author: Oleksandr Diachenko Date: 2016-08-19T21:40:22Z HAWQ-975. Added support for IN, BETWEEN, LIKE. commit 0ce86673718d99918ed0782aa1c4d3270d3d080c Author: Oleksandr Diachenko Date: 2016-08-19T22:10:57Z HAWQ-975. Added memory cleanup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
