[ 
https://issues.apache.org/jira/browse/HAWQ-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000498#comment-16000498
 ] 

Paul Guo commented on HAWQ-1444:
--------------------------------

I went through the callers of gettimeofday() in code and did not find obvious 
bad use of it since the following code change, so I'm closing this JIRA.

    HAWQ-1439. tolerate system time being changed to earlier point when 
checking resource context timeout

> Need to replace gettimeofday() with clock_gettime() for related timeout 
> checking code
> -------------------------------------------------------------------------------------
>
>                 Key: HAWQ-1444
>                 URL: https://issues.apache.org/jira/browse/HAWQ-1444
>             Project: Apache HAWQ
>          Issue Type: Bug
>          Components: Core
>            Reporter: Paul Guo
>            Assignee: Paul Guo
>             Fix For: backlog
>
>
> gettimeofday() could be affected by ntp kinda things. If using it for timeout 
> logic there could be wrong, e.g. time goes backwards. We could 
> clock_gettime() with CLOCK_MONOTONIC as an alternative.
> For some platforms/oses that does not have the support for clock_gettime(), 
> we can fall back to use gettimeofday().
> Note getCurrentTime() in code is a good example.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to