[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209109#comment-15209109 ] ASF GitHub Bot commented on HAWQ-445: - Github user armenatzoglou commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-200532790 Thanks @wengyanqing > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209110#comment-15209110 ] ASF GitHub Bot commented on HAWQ-445: - Github user armenatzoglou closed the pull request at: https://github.com/apache/incubator-hawq/pull/378 > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207878#comment-15207878 ] ASF GitHub Bot commented on HAWQ-445: - Github user wengyanqing commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-200185372 I had merged this PR, @armenatzoglou would you please close it ? > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172526#comment-15172526 ] ASF GitHub Bot commented on HAWQ-445: - Github user armenatzoglou commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-190366671 @changleicn Please add the hash of GPDB commits (see first comment) in the final commit. thanks > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172510#comment-15172510 ] ASF GitHub Bot commented on HAWQ-445: - Github user armenatzoglou commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-190363151 @foyzur I gave it a try to cherry-pick the changes from stash, but it is not possible, since they have different folder structure. I have added the hash of your commits in this PR. > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170137#comment-15170137 ] ASF GitHub Bot commented on HAWQ-445: - Github user armenatzoglou commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-189530006 @foyzur I see your point, but I do not think that this is possible for this PR. The reason is that this code comes from a commit three years ago. Unfortunately, in GPDB OSS there is no commits' history from back then. In particular, the history of the files changed in this PR starts from 10/23/2015 with a commit that squashes all previous ones. Consequently, those commits are not appropriate for this PR. Thanks > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167535#comment-15167535 ] ASF GitHub Bot commented on HAWQ-445: - Github user foyzur commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-188903783 @armenatzoglou is it possible to preserve the original cherry-picked commit and add any additional modification on top of that? Going forward we will be porting many fixes from GPDB to HAWQ and it might be a good practice to preserve the authorship :-) That's also the way we port fixes from Postgres to GPDB, e.g. > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163810#comment-15163810 ] ASF GitHub Bot commented on HAWQ-445: - Github user foyzur commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-188453389 LGTM. > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163580#comment-15163580 ] ASF GitHub Bot commented on HAWQ-445: - Github user karthijrk commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-188423548 LGTM :+1: > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159989#comment-15159989 ] ASF GitHub Bot commented on HAWQ-445: - Github user armenatzoglou commented on the pull request: https://github.com/apache/incubator-hawq/pull/378#issuecomment-187993259 @foyzur Please take a look when you have time. > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-445) Support large strings (up to a GB) in text_to_array()
[ https://issues.apache.org/jira/browse/HAWQ-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159984#comment-15159984 ] ASF GitHub Bot commented on HAWQ-445: - GitHub user armenatzoglou opened a pull request: https://github.com/apache/incubator-hawq/pull/378 HAWQ-445. Support large strings (up to a GB) in text_to_array() This commit is adding support to handle large strings (up to a GB) in text_to_array(). The fix has been picked from GPDB. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gcaragea/incubator-hawq nikos-HAWQ-445 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/378.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #378 commit 3933f12af3c3eb1fadc13b4192a056f055d434a8 Author: Nikos Armenatzoglou Date: 2016-02-23T00:27:02Z HAWQ-445. Support large strings (up to a GB) in text_to_array() > Support large strings (up to a GB) in text_to_array() > - > > Key: HAWQ-445 > URL: https://issues.apache.org/jira/browse/HAWQ-445 > Project: Apache HAWQ > Issue Type: Improvement > Components: Query Execution >Reporter: Nikos Armenatzoglou >Assignee: George Caragea > -- This message was sent by Atlassian JIRA (v6.3.4#6332)