[jira] [Updated] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop
[
https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Honghua updated HBASE-10516:
-
Attachment: HBASE-10516-trunk_v3.patch
v3 patch attached per [~nkeywal]'s latest feedback on the v2 patch:
# DeleteTableHandler : IOE thrown directly
# AssignmentManager : IE thrown directly (add throws clause for its containing
assign() method, change another RuntimeException to IE in the same method. The
next upper containing method of its direct containing method does throw IE, so
this change should match the exception design better)
# LruBlockCache : exit at first IE and interrupt()
# ZooKeeperWatcher : RuntimeException thrown as timeout handling nearby
Ping [~nkeywal] and thanks!
Refactor code where Threads.sleep is called within a while/for loop
---
Key: HBASE-10516
URL: https://issues.apache.org/jira/browse/HBASE-10516
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10516-trunk_v1.patch, HBASE-10516-trunk_v2.patch,
HBASE-10516-trunk_v3.patch
Threads.sleep implementation:
{code}
public static void sleep(long millis) {
try {
Thread.sleep(millis);
} catch (InterruptedException e) {
e.printStackTrace();
Thread.currentThread().interrupt();
}
}
{code}
From above implementation, the current thread's interrupt status is
restored/reset when InterruptedException is caught and handled. If this
method is called within a while/for loop, if a first InterruptedException is
thrown during sleep, it will make the Threads.sleep in next loop immediately
throw InterruptedException without expected sleep. This behavior breaks the
intention for independent sleep in each loop
I mentioned above in HBASE-10497 and this jira is created to handle it
separately per [~nkeywal]'s suggestion
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop
[
https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905077#comment-13905077
]
Feng Honghua commented on HBASE-10516:
--
bq.Nice writeup @nkeywal (and nice commentary Feng Honghua – especially the bit
about resetting interrupt is useless unless it checked in upper layers). We
should extract your wisdom and put on dev list? It is good stuff. I can write
it up in refguide after we are agreed.
Sounds good, [~stack]
Refactor code where Threads.sleep is called within a while/for loop
---
Key: HBASE-10516
URL: https://issues.apache.org/jira/browse/HBASE-10516
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10516-trunk_v1.patch, HBASE-10516-trunk_v2.patch,
HBASE-10516-trunk_v3.patch
Threads.sleep implementation:
{code}
public static void sleep(long millis) {
try {
Thread.sleep(millis);
} catch (InterruptedException e) {
e.printStackTrace();
Thread.currentThread().interrupt();
}
}
{code}
From above implementation, the current thread's interrupt status is
restored/reset when InterruptedException is caught and handled. If this
method is called within a while/for loop, if a first InterruptedException is
thrown during sleep, it will make the Threads.sleep in next loop immediately
throw InterruptedException without expected sleep. This behavior breaks the
intention for independent sleep in each loop
I mentioned above in HBASE-10497 and this jira is created to handle it
separately per [~nkeywal]'s suggestion
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905085#comment-13905085 ] ramkrishna.s.vasudevan commented on HBASE-10532: We already have a CellComparator introduced for Prefixtree. Infact compareStaticIgnoreMvccVersion() in CellComparator can be used to compare the flat keys incase of seekTo, reseekTo, seekBefore. May be I will add the required comparators to the existing Cellcomparator. Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue. --- Key: HBASE-10532 URL: https://issues.apache.org/jira/browse/HBASE-10532 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.99.0 Attachments: HBASE-10532.patch, HBASE-10532.patch public int compareRows(final KeyValue left, final KeyValue right) public boolean matchingRows(final KeyValue left, final KeyValue right) We can make them to use Cells instead of KeyValue incase we need to use them for comparison of any type of cell in future. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop
[
https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905088#comment-13905088
]
Nicolas Liochon commented on HBASE-10516:
-
I'm +1 for v3. I will commit shortly if no one disagree.
Thanks for the patch, Feng. Sorry again the the review in 2 passes, thanks for
taking the comments into account.
I'm going to review the other patches today.
I will write up a small text on interruption for the dev list as well.
Refactor code where Threads.sleep is called within a while/for loop
---
Key: HBASE-10516
URL: https://issues.apache.org/jira/browse/HBASE-10516
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10516-trunk_v1.patch, HBASE-10516-trunk_v2.patch,
HBASE-10516-trunk_v3.patch
Threads.sleep implementation:
{code}
public static void sleep(long millis) {
try {
Thread.sleep(millis);
} catch (InterruptedException e) {
e.printStackTrace();
Thread.currentThread().interrupt();
}
}
{code}
From above implementation, the current thread's interrupt status is
restored/reset when InterruptedException is caught and handled. If this
method is called within a while/for loop, if a first InterruptedException is
thrown during sleep, it will make the Threads.sleep in next loop immediately
throw InterruptedException without expected sleep. This behavior breaks the
intention for independent sleep in each loop
I mentioned above in HBASE-10497 and this jira is created to handle it
separately per [~nkeywal]'s suggestion
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10537) Let the ExportSnapshot mapper fail and retry on error
[ https://issues.apache.org/jira/browse/HBASE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-10537: Resolution: Fixed Fix Version/s: 0.96.2 Status: Resolved (was: Patch Available) Let the ExportSnapshot mapper fail and retry on error - Key: HBASE-10537 URL: https://issues.apache.org/jira/browse/HBASE-10537 Project: HBase Issue Type: Bug Components: snapshots Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10537-v1.patch, HBASE-10537-v2.patch Instead of completing the job, and force the user to re-run the export if something failed, let the Mapper fail and retry automatically based on the job.getMaxMapAttempts() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
[ https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-10531: --- Attachment: HBASE-10531.patch Patch that deprecates and adds new seekTo, reseekTo and seekBefore APIs. Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo Key: HBASE-10531 URL: https://issues.apache.org/jira/browse/HBASE-10531 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.99.0 Attachments: HBASE-10531.patch Currently the byte[] key passed to HFileScanner.seekTo and HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts. And the caller forms this by using kv.getBuffer, which is actually deprecated. So see how this can be achieved considering kv.getBuffer is removed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10566) cleanup rpcTimeout in the client
Nicolas Liochon created HBASE-10566: --- Summary: cleanup rpcTimeout in the client Key: HBASE-10566 URL: https://issues.apache.org/jira/browse/HBASE-10566 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.99.0 There are two issues: 1) A confusion between the socket timeout and the call timeout Socket timeouts should be minimal: a default like 20 seconds, that could be lowered to single digits timeouts for some apps: if we can not write to the socket in 10 second, we have an issue. This is different from the total duration (send query + do query + receive query), that can be longer, as it can include remotes calls on the server and so on. Today, we have a single value, it does not allow us to have low socket read timeouts. 2) The timeout can be different between the calls. Typically, if the total time, retries included is 60 seconds but failed after 2 seconds, then the remaining is 58s. HBase does this today, but by hacking with a thread local storage variable. It's a hack (it should have been a parameter of the methods, the TLS allowed to bypass all the layers. May be protobuf makes this complicated, to be confirmed), but as well it does not really work, because we can have multithreading issues (we use the updated rpc timeout of someone else, or we create a new BlockingRpcChannelImplementation with a random default timeout). Ideally, we could send the call timeout to the server as well: it will be able to dismiss alone the calls that it received but git stick in the request queue or in the internal retries (on hdfs for example). This will make the system more reactive to failure. I think we can solve this now, especially after 10525. The main issue is to something that fits well with protobuf... Then it should be easy to have a pool of thread for writers and readers, w/o a single thread per region server as today. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-9537) completebulkload does 'copy' StoreFiles instead of 'cut'
[ https://issues.apache.org/jira/browse/HBASE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosdent updated HBASE-9537: Attachment: HBASE-9537.patch completebulkload does 'copy' StoreFiles instead of 'cut' Key: HBASE-9537 URL: https://issues.apache.org/jira/browse/HBASE-9537 Project: HBase Issue Type: Bug Components: HFile, mapreduce, regionserver Affects Versions: 0.94.11 Reporter: M. BagherEsmaeily Attachments: HBASE-9537.patch, LoadIncrementalHFiles.log, region.log I was using HBase complete bulk load to transfer the output of ImportTsv to a table in HBase, and I noticed that it copies the output instead of cutting. This takes long time for my gigabytes of data. In HBase documentation (http://hbase.apache.org/book/ops_mgt.html#completebulkload) I read that the files would be moved not copied. Can anyone help me with this? I use Hbase 0.94.11 and Hadoop 1.2.1. The file system of bulkload output directory and hbase cluster are the same, too. I've also coded a MapReduce job using HFileOutputFormat. When I use LoadIncrementalHFiles to move the output of my job to HBase table, it still copies instead of cut. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-9537) completebulkload does 'copy' StoreFiles instead of 'cut'
[ https://issues.apache.org/jira/browse/HBASE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosdent updated HBASE-9537: Attachment: (was: HBASE-9537.patch) completebulkload does 'copy' StoreFiles instead of 'cut' Key: HBASE-9537 URL: https://issues.apache.org/jira/browse/HBASE-9537 Project: HBase Issue Type: Bug Components: HFile, mapreduce, regionserver Affects Versions: 0.94.11 Reporter: M. BagherEsmaeily Attachments: LoadIncrementalHFiles.log, region.log I was using HBase complete bulk load to transfer the output of ImportTsv to a table in HBase, and I noticed that it copies the output instead of cutting. This takes long time for my gigabytes of data. In HBase documentation (http://hbase.apache.org/book/ops_mgt.html#completebulkload) I read that the files would be moved not copied. Can anyone help me with this? I use Hbase 0.94.11 and Hadoop 1.2.1. The file system of bulkload output directory and hbase cluster are the same, too. I've also coded a MapReduce job using HFileOutputFormat. When I use LoadIncrementalHFiles to move the output of my job to HBase table, it still copies instead of cut. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-8304) Bulkload fail to remove files if fs.default.name / fs.defaultFS is configured without default port.
[ https://issues.apache.org/jira/browse/HBASE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] haosdent updated HBASE-8304: Attachment: HBASE-9537.patch I determine whether two fs is same by their checksum. Any better way? Bulkload fail to remove files if fs.default.name / fs.defaultFS is configured without default port. --- Key: HBASE-8304 URL: https://issues.apache.org/jira/browse/HBASE-8304 Project: HBase Issue Type: Bug Components: HFile, regionserver Affects Versions: 0.94.5 Reporter: Raymond Liu Attachments: HBASE-9537.patch When fs.default.name or fs.defaultFS in hadoop core-site.xml is configured as hdfs://ip, and hbase.rootdir is configured as hdfs://ip:port/hbaserootdir where port is the hdfs namenode's default port. the bulkload operation will not remove the file in bulk output dir. Store::bulkLoadHfile will think hdfs:://ip and hdfs:://ip:port as different filesystem and go with copy approaching instead of rename. The root cause is that hbase master will rewrite fs.default.name/fs.defaultFS according to hbase.rootdir when regionserver started, thus, dest fs uri from the hregion will not matching src fs uri passed from client. any suggestion what is the best approaching to fix this issue? I kind of think that we could check for default port if src uri come without port info. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop
[
https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905335#comment-13905335
]
Feng Honghua commented on HBASE-10516:
--
bq.Sorry again the the review in 2 passes
No sorry here, your review is really appreciated:-)
bq.I will write up a small text on interruption for the dev list as well.
That's great!
Refactor code where Threads.sleep is called within a while/for loop
---
Key: HBASE-10516
URL: https://issues.apache.org/jira/browse/HBASE-10516
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10516-trunk_v1.patch, HBASE-10516-trunk_v2.patch,
HBASE-10516-trunk_v3.patch
Threads.sleep implementation:
{code}
public static void sleep(long millis) {
try {
Thread.sleep(millis);
} catch (InterruptedException e) {
e.printStackTrace();
Thread.currentThread().interrupt();
}
}
{code}
From above implementation, the current thread's interrupt status is
restored/reset when InterruptedException is caught and handled. If this
method is called within a while/for loop, if a first InterruptedException is
thrown during sleep, it will make the Threads.sleep in next loop immediately
throw InterruptedException without expected sleep. This behavior breaks the
intention for independent sleep in each loop
I mentioned above in HBASE-10497 and this jira is created to handle it
separately per [~nkeywal]'s suggestion
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10519) Add handling for swallowed InterruptedException thrown by Thread.sleep in rest related files
[ https://issues.apache.org/jira/browse/HBASE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905340#comment-13905340 ] Nicolas Liochon commented on HBASE-10519: - +1, I will commit if nobody disagrees. Add handling for swallowed InterruptedException thrown by Thread.sleep in rest related files Key: HBASE-10519 URL: https://issues.apache.org/jira/browse/HBASE-10519 Project: HBase Issue Type: Sub-task Components: REST Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10519-trunk_v1.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10519) Add handling for swallowed InterruptedException thrown by Thread.sleep in rest related files
[ https://issues.apache.org/jira/browse/HBASE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10519: Fix Version/s: 0.99.0 Add handling for swallowed InterruptedException thrown by Thread.sleep in rest related files Key: HBASE-10519 URL: https://issues.apache.org/jira/browse/HBASE-10519 Project: HBase Issue Type: Sub-task Components: REST Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10519-trunk_v1.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10519) Add handling for swallowed InterruptedException thrown by Thread.sleep in rest related files
[ https://issues.apache.org/jira/browse/HBASE-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10519: Affects Version/s: 0.99.0 0.98.0 Add handling for swallowed InterruptedException thrown by Thread.sleep in rest related files Key: HBASE-10519 URL: https://issues.apache.org/jira/browse/HBASE-10519 Project: HBase Issue Type: Sub-task Components: REST Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10519-trunk_v1.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10520) Add handling for swallowed InterruptedException thrown by Thread.sleep in MiniZooKeeperCluster
[ https://issues.apache.org/jira/browse/HBASE-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905345#comment-13905345 ] Nicolas Liochon commented on HBASE-10520: - I agree with the analysis and the solution, +1. Will commit if nobody disagrees. Add handling for swallowed InterruptedException thrown by Thread.sleep in MiniZooKeeperCluster -- Key: HBASE-10520 URL: https://issues.apache.org/jira/browse/HBASE-10520 Project: HBase Issue Type: Sub-task Components: Zookeeper Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10520-trunk_v1.patch, HBASE-10520-trunk_v2.patch, HBASE-10520-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10520) Add handling for swallowed InterruptedException thrown by Thread.sleep in MiniZooKeeperCluster
[ https://issues.apache.org/jira/browse/HBASE-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10520: Fix Version/s: 0.99.0 Add handling for swallowed InterruptedException thrown by Thread.sleep in MiniZooKeeperCluster -- Key: HBASE-10520 URL: https://issues.apache.org/jira/browse/HBASE-10520 Project: HBase Issue Type: Sub-task Components: Zookeeper Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10520-trunk_v1.patch, HBASE-10520-trunk_v2.patch, HBASE-10520-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10520) Add handling for swallowed InterruptedException thrown by Thread.sleep in MiniZooKeeperCluster
[ https://issues.apache.org/jira/browse/HBASE-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10520: Affects Version/s: 0.99.0 0.98.0 Add handling for swallowed InterruptedException thrown by Thread.sleep in MiniZooKeeperCluster -- Key: HBASE-10520 URL: https://issues.apache.org/jira/browse/HBASE-10520 Project: HBase Issue Type: Sub-task Components: Zookeeper Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10520-trunk_v1.patch, HBASE-10520-trunk_v2.patch, HBASE-10520-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10556) Possible data loss due to non-handled DroppedSnapshotException for user-triggered flush from client/shell
[ https://issues.apache.org/jira/browse/HBASE-10556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905351#comment-13905351 ] Feng Honghua commented on HBASE-10556: -- Thanks [~yuzhih...@gmail.com] for the review, and ping [~lhofhansl], [~stack] and [~apurtell] for review and another +1, thanks:-) Possible data loss due to non-handled DroppedSnapshotException for user-triggered flush from client/shell - Key: HBASE-10556 URL: https://issues.apache.org/jira/browse/HBASE-10556 Project: HBase Issue Type: Bug Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Priority: Critical Attachments: HBASE-10556-trunk_v1.patch During the code review when investigating HBASE-10499, a possibility of data loss due to non-handled DroppedSnapshotException for user-triggered flush is exposed. Data loss can happen as below: # A flush for some region is triggered via HBaseAdmin or shell # The request reaches regionserver and eventually HRegion.internalFlushcache is called, then fails at persisting memstore's snapshot to hfile, DroppedSnapshotException is thrown and the snapshot is left not cleared. # DroppedSnapshotException is not handled in HRegion, and is just encapsulated as a ServiceException before returning to client # After a while, some new writes are handled and put in the current memstore, then a new flush is triggered for the region due to memstoreSize exceeds flush threshold # This second(new) flush succeeds, for the HStore which failed in the previous user-triggered flush, the remained non-empty snapshot is used rather than a new snapshot made from the current memstore, but HLog's latest sequenceId is used for the resultant hfiles --- the sequenceId attached within the hfiles says all edits with sequenceId = it have all been persisted, but actually it's not the truth for the edits still in the existing memstore # Now the regionserver hosting this region dies # During the replay phase of failover, the edits corresponding to the ones while are in memstore and not actually persisted in hfiles when the previous regionserver dies will be ignored, since they are deemed as persisted by compared to the hfiles' latest consequenceID --- These edits are lost... For the second flush, we also can't discard the remained snapshot and make a new one using current memstore, that way the data in the remained snapshot is lost. We should abort the regionserver immediately and rely on the failover to replay the log for data safety. DroppedSnapshotException is correctly handled in MemStoreFlusher for internally triggered flush (which are generated by flush-size / rollWriter / periodicFlusher). But user-triggered flush is processed directly by HRegionServer-HRegion without putting a flush entry to flushQueue, hence not handled by MemStoreFlusher -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905360#comment-13905360 ] Nicolas Liochon commented on HBASE-10521: - For RpcServer#Listener#run, we could just log and return, no? This will stop the thread cleanly. In RpcServer#Reader#doRunLoop we shallow the interruption In RpcServer#Responder#doRunLoop we can do a return or a break as well (see the case of an exception coming from waitPending today: we take into account this exception, as it's caught and it terminates the thread cleanly) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10419) Add multiget support to PerformanceEvaluation
[
https://issues.apache.org/jira/browse/HBASE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905367#comment-13905367
]
Hadoop QA commented on HBASE-10419:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629693/HBASE-10419-v4-trunk.patch
against trunk revision .
ATTACHMENT ID: 12629693
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8741//console
This message is automatically generated.
Add multiget support to PerformanceEvaluation
-
Key: HBASE-10419
URL: https://issues.apache.org/jira/browse/HBASE-10419
Project: HBase
Issue Type: Improvement
Components: test
Reporter: Nick Dimiduk
Assignee: Nick Dimiduk
Priority: Minor
Attachments: HBASE-10419-v2-trunk.patch, HBASE-10419-v3-trunk.patch,
HBASE-10419-v4-trunk.patch, HBASE-10419.0.patch, HBASE-10419.1.patch
Folks planning to use multiget may find this useful.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Honghua updated HBASE-10521: - Attachment: HBASE-10521-trunk_v3.patch v3 patch attached per [~nkeywal]'s latest review feedback on v2, thanks! Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch, HBASE-10521-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10522) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in client
[ https://issues.apache.org/jira/browse/HBASE-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10522: Fix Version/s: 0.99.0 Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in client -- Key: HBASE-10522 URL: https://issues.apache.org/jira/browse/HBASE-10522 Project: HBase Issue Type: Sub-task Components: Client Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10522-trunk_v1.patch, HBASE-10522-trunk_v2.patch, HBASE-10522-trunk_v3.patch A sub-task of HBASE-10497 # rethrow rather than ignore InterruptedException thrown in deleteTable, this behavior is to align with other similar methods such as createTable/enableTable/disableTable # correct some wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10522) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in client
[
https://issues.apache.org/jira/browse/HBASE-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905384#comment-13905384
]
Nicolas Liochon commented on HBASE-10522:
-
HTableMultiplexer. It will be shallowed a few lines after (in the '} catch
(Exception e) {'). But I don't really know what to do here. Let's keep your
patch as it is.
HBaseAdmin#deleteTable. Its scary (why is it different today???), but let's do
that.
Note that Ideally HBaseAdmin#deleteTables should manage the
InterruptedIOException (calling ExceptionUtil#rethrowIfInterrupt)
HBaseAdmin#snapshot seems ok.
+1 so... Will wait one more day before committing if someone wants to double
check.
Correct wrong handling and add proper handling for swallowed
InterruptedException thrown by Thread.sleep in client
--
Key: HBASE-10522
URL: https://issues.apache.org/jira/browse/HBASE-10522
Project: HBase
Issue Type: Sub-task
Components: Client
Affects Versions: 0.98.0, 0.99.0
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.99.0
Attachments: HBASE-10522-trunk_v1.patch, HBASE-10522-trunk_v2.patch,
HBASE-10522-trunk_v3.patch
A sub-task of HBASE-10497
# rethrow rather than ignore InterruptedException thrown in deleteTable, this
behavior is to align with other similar methods such as
createTable/enableTable/disableTable
# correct some wrong handling of InterruptedException where
Thread.currentThread.interrupt() is called within while loops
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10522) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in client
[ https://issues.apache.org/jira/browse/HBASE-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10522: Affects Version/s: 0.99.0 0.98.0 Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in client -- Key: HBASE-10522 URL: https://issues.apache.org/jira/browse/HBASE-10522 Project: HBase Issue Type: Sub-task Components: Client Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10522-trunk_v1.patch, HBASE-10522-trunk_v2.patch, HBASE-10522-trunk_v3.patch A sub-task of HBASE-10497 # rethrow rather than ignore InterruptedException thrown in deleteTable, this behavior is to align with other similar methods such as createTable/enableTable/disableTable # correct some wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10523) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util
[ https://issues.apache.org/jira/browse/HBASE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905389#comment-13905389 ] Nicolas Liochon commented on HBASE-10523: - FSUtils#setVersion ok FSUtils#setClusterId yeah! FSUtils#waitOnSafeMode ok HBaseFsck ok JVMClusterUtil ok (if we touch this file again, RuntimeException(Master not active after 30 seconds); should become an IOException for consistency) +1 then I'm going to commit this one as there is already a +1 from Stack as well. Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util Key: HBASE-10523 URL: https://issues.apache.org/jira/browse/HBASE-10523 Project: HBase Issue Type: Sub-task Components: util Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10523-trunk_v1.patch, HBASE-10523-trunk_v2.patch, HBASE-10523-trunk_v3.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10523) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util
[ https://issues.apache.org/jira/browse/HBASE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10523: Affects Version/s: 0.99.0 0.98.0 Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util Key: HBASE-10523 URL: https://issues.apache.org/jira/browse/HBASE-10523 Project: HBase Issue Type: Sub-task Components: util Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10523-trunk_v1.patch, HBASE-10523-trunk_v2.patch, HBASE-10523-trunk_v3.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10523) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util
[ https://issues.apache.org/jira/browse/HBASE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10523: Fix Version/s: 0.99.0 Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util Key: HBASE-10523 URL: https://issues.apache.org/jira/browse/HBASE-10523 Project: HBase Issue Type: Sub-task Components: util Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10523-trunk_v1.patch, HBASE-10523-trunk_v2.patch, HBASE-10523-trunk_v3.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10537) Let the ExportSnapshot mapper fail and retry on error
[ https://issues.apache.org/jira/browse/HBASE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905394#comment-13905394 ] Hudson commented on HBASE-10537: SUCCESS: Integrated in HBase-TRUNK #4931 (See [https://builds.apache.org/job/HBase-TRUNK/4931/]) HBASE-10537 Let the ExportSnapshot mapper fail and retry on error (mbertozzi: rev 1569680) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java Let the ExportSnapshot mapper fail and retry on error - Key: HBASE-10537 URL: https://issues.apache.org/jira/browse/HBASE-10537 Project: HBase Issue Type: Bug Components: snapshots Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10537-v1.patch, HBASE-10537-v2.patch Instead of completing the job, and force the user to re-run the export if something failed, let the Mapper fail and retry automatically based on the job.getMaxMapAttempts() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (HBASE-10523) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util
[ https://issues.apache.org/jira/browse/HBASE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905396#comment-13905396 ] Nicolas Liochon edited comment on HBASE-10523 at 2/19/14 1:14 PM: -- Committed to trunk, thanks for the work the patch! was (Author: nkeywal): Committed to trunk, thanks for work the patch! Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util Key: HBASE-10523 URL: https://issues.apache.org/jira/browse/HBASE-10523 Project: HBase Issue Type: Sub-task Components: util Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10523-trunk_v1.patch, HBASE-10523-trunk_v2.patch, HBASE-10523-trunk_v3.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10523) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util
[ https://issues.apache.org/jira/browse/HBASE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10523: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to trunk, thanks for work the patch! Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util Key: HBASE-10523 URL: https://issues.apache.org/jira/browse/HBASE-10523 Project: HBase Issue Type: Sub-task Components: util Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10523-trunk_v1.patch, HBASE-10523-trunk_v2.patch, HBASE-10523-trunk_v3.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10537) Let the ExportSnapshot mapper fail and retry on error
[ https://issues.apache.org/jira/browse/HBASE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905400#comment-13905400 ] Hudson commented on HBASE-10537: FAILURE: Integrated in hbase-0.96-hadoop2 #208 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/208/]) HBASE-10537 Let the ExportSnapshot mapper fail and retry on error (mbertozzi: rev 1569686) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java Let the ExportSnapshot mapper fail and retry on error - Key: HBASE-10537 URL: https://issues.apache.org/jira/browse/HBASE-10537 Project: HBase Issue Type: Bug Components: snapshots Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10537-v1.patch, HBASE-10537-v2.patch Instead of completing the job, and force the user to re-run the export if something failed, let the Mapper fail and retry automatically based on the job.getMaxMapAttempts() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10511) Add latency percentiles on PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905398#comment-13905398 ] Hudson commented on HBASE-10511: FAILURE: Integrated in hbase-0.96-hadoop2 #208 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/208/]) HBASE-10511 Add latency percentiles on PerformanceEvaluation (Nicolas Liochon) (ndimiduk: rev 1569568) * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java Add latency percentiles on PerformanceEvaluation Key: HBASE-10511 URL: https://issues.apache.org/jira/browse/HBASE-10511 Project: HBase Issue Type: Improvement Components: test Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.96.2, 0.98.1, 0.99.0, hbase-10070 Attachments: 10511.v1.patch The latency is reported as an array or float. It's easier to deal with percentiles :-) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10565) FavoredNodesPlan accidentally uses an internal Netty type
[ https://issues.apache.org/jira/browse/HBASE-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905397#comment-13905397 ] Hudson commented on HBASE-10565: FAILURE: Integrated in hbase-0.96-hadoop2 #208 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/208/]) HBASE-10565 FavoredNodesPlan accidentally uses an internal Netty type (apurtell: rev 1569594) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodesPlan.java FavoredNodesPlan accidentally uses an internal Netty type - Key: HBASE-10565 URL: https://issues.apache.org/jira/browse/HBASE-10565 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: 10565.patch Obvious fix. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10548) Correct commons-math dependency version
[
https://issues.apache.org/jira/browse/HBASE-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905399#comment-13905399
]
Hudson commented on HBASE-10548:
FAILURE: Integrated in hbase-0.96-hadoop2 #208 (See
[https://builds.apache.org/job/hbase-0.96-hadoop2/208/])
HBASE-10548 Correct commons-math dependency version (ndimiduk: rev 1569569)
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
* /hbase/branches/0.96/pom.xml
Correct commons-math dependency version
---
Key: HBASE-10548
URL: https://issues.apache.org/jira/browse/HBASE-10548
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.96.2, 0.98.1, 0.99.0
Reporter: Nick Dimiduk
Assignee: Nick Dimiduk
Priority: Minor
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: HBASE-10548.00.patch, HBASE-10548.01-0.96.patch,
HBASE-10548.01-0.98.patch, HBASE-10548.01.patch
From my
[comment|https://issues.apache.org/jira/browse/HBASE-10511?focusedCommentId=13902238page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13902238]
on HBASE-10511:
I have hadoop-1.2.1 installed from tgz, which packages commons-math-2.1. This
is *different* from the listed maven dependency, 2.2.
{noformat}
$ tar tvf hadoop-1.2.1.tar.gz | grep commons-math
-rw-rw-r-- 0 0 0 832410 Jul 22 2013
hadoop-1.2.1/lib/commons-math-2.1.jar
$ mvn -f pom.xml.hadoop1 dependency:tree | grep commons-math
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed
from 2.1)
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed
from 2.1)
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed
from 2.1)
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile (version managed
from 2.1)
[INFO] +- org.apache.commons:commons-math:jar:2.2:compile
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile
[INFO] +- org.apache.commons:commons-math:jar:2.2:compile
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile
[INFO] +- org.apache.commons:commons-math:jar:2.2:compile
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile
[INFO] | +- org.apache.commons:commons-math:jar:2.2:compile
{noformat}
This is a problem because the 2.1 version of
[DescriptiveStatistics|http://commons.apache.org/proper/commons-math/javadocs/api-2.1/org/apache/commons/math/stat/descriptive/DescriptiveStatistics.html]
doesn't have a double[] constructor. Running the MR job, mappers fail:
{noformat}
java.lang.NoSuchMethodError:
org.apache.commons.math.stat.descriptive.DescriptiveStatistics.init([D)V
at
org.apache.hadoop.hbase.PerformanceEvaluation$RandomReadTest.testTakedown(PerformanceEvaluation.java:1163)
at
org.apache.hadoop.hbase.PerformanceEvaluation$Test.test(PerformanceEvaluation.java:984)
at
org.apache.hadoop.hbase.PerformanceEvaluation.runOneClient(PerformanceEvaluation.java:1401)
at
org.apache.hadoop.hbase.PerformanceEvaluation$EvaluationMapTask.map(PerformanceEvaluation.java:522)
at
org.apache.hadoop.hbase.PerformanceEvaluation$EvaluationMapTask.map(PerformanceEvaluation.java:474)
at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:145)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10537) Let the ExportSnapshot mapper fail and retry on error
[ https://issues.apache.org/jira/browse/HBASE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905425#comment-13905425 ] Hudson commented on HBASE-10537: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #157 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/157/]) HBASE-10537 Let the ExportSnapshot mapper fail and retry on error (mbertozzi: rev 1569682) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java Let the ExportSnapshot mapper fail and retry on error - Key: HBASE-10537 URL: https://issues.apache.org/jira/browse/HBASE-10537 Project: HBase Issue Type: Bug Components: snapshots Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10537-v1.patch, HBASE-10537-v2.patch Instead of completing the job, and force the user to re-run the export if something failed, let the Mapper fail and retry automatically based on the job.getMaxMapAttempts() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905428#comment-13905428 ] Nicolas Liochon commented on HBASE-10524: - Yes, I'm going to commit with a small change + LOG.warn(Interrupted while sleeping during get task list ..., e1); = not need to log the exception, so I will log this + LOG.warn(Interrupted while sleeping during get task list.); Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver Key: HBASE-10524 URL: https://issues.apache.org/jira/browse/HBASE-10524 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10537) Let the ExportSnapshot mapper fail and retry on error
[ https://issues.apache.org/jira/browse/HBASE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905463#comment-13905463 ] Hudson commented on HBASE-10537: SUCCESS: Integrated in hbase-0.96 #302 (See [https://builds.apache.org/job/hbase-0.96/302/]) HBASE-10537 Let the ExportSnapshot mapper fail and retry on error (mbertozzi: rev 1569686) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java Let the ExportSnapshot mapper fail and retry on error - Key: HBASE-10537 URL: https://issues.apache.org/jira/browse/HBASE-10537 Project: HBase Issue Type: Bug Components: snapshots Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10537-v1.patch, HBASE-10537-v2.patch Instead of completing the job, and force the user to re-run the export if something failed, let the Mapper fail and retry automatically based on the job.getMaxMapAttempts() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905468#comment-13905468 ] Nicolas Liochon commented on HBASE-10524: - Oops, actually no. getTaskList should just throw InterruptedException, this exception is managed in the upper layers already. See attached patch. wdyt? Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver Key: HBASE-10524 URL: https://issues.apache.org/jira/browse/HBASE-10524 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch, split.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10524: Attachment: split.patch Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver Key: HBASE-10524 URL: https://issues.apache.org/jira/browse/HBASE-10524 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch, split.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[
https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905467#comment-13905467
]
Anoop Sam John commented on HBASE-10534:
+1
Rowkey in TsvImporterTextMapper initializing with wrong length
--
Key: HBASE-10534
URL: https://issues.apache.org/jira/browse/HBASE-10534
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.96.0
Reporter: rajeshbabu
Assignee: rajeshbabu
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: HBASE-10534.patch
In TsvImporterTextMapper rowkey initializing with wrong length.
parser.parseRowKey give pair of start and end positions, so the rowkey length
initialized with rowkey end position instead of length.
{code}
PairInteger,Integer rowKeyOffests =
parser.parseRowKey(value.getBytes(), value.getLength());
ImmutableBytesWritable rowKey = new ImmutableBytesWritable(
value.getBytes(), rowKeyOffests.getFirst(),
rowKeyOffests.getSecond());
{code}
Its better to change TsvParser#parseRowKey to return starting position and
length of rowkey.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10567) Add overwrite manifest option to ExportSnapshot
[ https://issues.apache.org/jira/browse/HBASE-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-10567: Status: Patch Available (was: Open) Add overwrite manifest option to ExportSnapshot --- Key: HBASE-10567 URL: https://issues.apache.org/jira/browse/HBASE-10567 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.96.1.1, 0.94.16, 0.98.0, 0.99.0 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10567-v0.patch If you want to export a snapshot twice (e.g. in case you accidentally removed a file and now your snapshot is corrupted) you have to manually remove the .hbase-snapshot/SNAPSHOT_NAME directory and then run the ExportSnapshot tool. Add an -overwrite option to this operation automatically. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10567) Add overwrite manifest option to ExportSnapshot
[ https://issues.apache.org/jira/browse/HBASE-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-10567: Attachment: HBASE-10567-v0.patch Add overwrite manifest option to ExportSnapshot --- Key: HBASE-10567 URL: https://issues.apache.org/jira/browse/HBASE-10567 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.98.0, 0.94.16, 0.99.0, 0.96.1.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10567-v0.patch If you want to export a snapshot twice (e.g. in case you accidentally removed a file and now your snapshot is corrupted) you have to manually remove the .hbase-snapshot/SNAPSHOT_NAME directory and then run the ExportSnapshot tool. Add an -overwrite option to this operation automatically. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10567) Add overwrite manifest option to ExportSnapshot
Matteo Bertozzi created HBASE-10567: --- Summary: Add overwrite manifest option to ExportSnapshot Key: HBASE-10567 URL: https://issues.apache.org/jira/browse/HBASE-10567 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.96.1.1, 0.94.16, 0.98.0, 0.99.0 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10567-v0.patch If you want to export a snapshot twice (e.g. in case you accidentally removed a file and now your snapshot is corrupted) you have to manually remove the .hbase-snapshot/SNAPSHOT_NAME directory and then run the ExportSnapshot tool. Add an -overwrite option to this operation automatically. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop
[
https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905474#comment-13905474
]
Hadoop QA commented on HBASE-10516:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629734/HBASE-10516-trunk_v3.patch
against trunk revision .
ATTACHMENT ID: 12629734
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8742//console
This message is automatically generated.
Refactor code where Threads.sleep is called within a while/for loop
---
Key: HBASE-10516
URL: https://issues.apache.org/jira/browse/HBASE-10516
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10516-trunk_v1.patch, HBASE-10516-trunk_v2.patch,
HBASE-10516-trunk_v3.patch
Threads.sleep implementation:
{code}
public static void sleep(long millis) {
try {
Thread.sleep(millis);
} catch (InterruptedException e) {
e.printStackTrace();
Thread.currentThread().interrupt();
}
}
{code}
From above implementation, the current thread's interrupt status is
restored/reset when InterruptedException is caught and handled. If this
method is called within a while/for loop, if a first InterruptedException is
thrown during sleep, it will make the Threads.sleep in next loop immediately
throw InterruptedException without expected sleep. This behavior breaks the
intention for independent sleep in each loop
I mentioned above in HBASE-10497 and this jira is created to handle it
separately per [~nkeywal]'s suggestion
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10537) Let the ExportSnapshot mapper fail and retry on error
[ https://issues.apache.org/jira/browse/HBASE-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905493#comment-13905493 ] Hudson commented on HBASE-10537: SUCCESS: Integrated in HBase-0.98 #168 (See [https://builds.apache.org/job/HBase-0.98/168/]) HBASE-10537 Let the ExportSnapshot mapper fail and retry on error (mbertozzi: rev 1569682) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java Let the ExportSnapshot mapper fail and retry on error - Key: HBASE-10537 URL: https://issues.apache.org/jira/browse/HBASE-10537 Project: HBase Issue Type: Bug Components: snapshots Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10537-v1.patch, HBASE-10537-v2.patch Instead of completing the job, and force the user to re-run the export if something failed, let the Mapper fail and retry automatically based on the job.getMaxMapAttempts() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905502#comment-13905502 ] Feng Honghua commented on HBASE-10524: -- Yes, both taskLoop and run handle InterruptedException already(though some just handle for its own sleep), letting getTaskList()/taskLoop() just throw out IE and letting run() handle IE does make the code cleaner. Good to me:-) btw: I made a new patch for HBASE-10521, would you help review it again? thanks:-) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver Key: HBASE-10524 URL: https://issues.apache.org/jira/browse/HBASE-10524 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch, split.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905509#comment-13905509 ] Feng Honghua commented on HBASE-10524: -- btw: the attached patch doesn't contain change to HRegionServer? please remember to include that when committing, or let me make a new one? Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver Key: HBASE-10524 URL: https://issues.apache.org/jira/browse/HBASE-10524 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch, split.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[
https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905525#comment-13905525
]
Hadoop QA commented on HBASE-10521:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629757/HBASE-10521-trunk_v3.patch
against trunk revision .
ATTACHMENT ID: 12629757
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8743//console
This message is automatically generated.
Add handling for swallowed InterruptedException thrown by Thread.sleep in
RpcServer and RpcClient
-
Key: HBASE-10521
URL: https://issues.apache.org/jira/browse/HBASE-10521
Project: HBase
Issue Type: Sub-task
Components: IPC/RPC
Reporter: Feng Honghua
Assignee: Feng Honghua
Priority: Minor
Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch,
HBASE-10521-trunk_v3.patch
A sub-task of HBASE-10497
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[ https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905546#comment-13905546 ] Nicolas Liochon commented on HBASE-10524: - Thanks, so, I will commit the two parts if nobody disagrees. Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver Key: HBASE-10524 URL: https://issues.apache.org/jira/browse/HBASE-10524 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Feng Honghua Assignee: Feng Honghua Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch, split.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10521: Status: Patch Available (was: Open) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch, HBASE-10521-trunk_v3.patch, HBASE-10521-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10521: Attachment: HBASE-10521-trunk_v3.patch Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch, HBASE-10521-trunk_v3.patch, HBASE-10521-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905551#comment-13905551 ] Nicolas Liochon commented on HBASE-10521: - This seems ok, but the zombie test is a bad smell. Let's rerun this. I will also change the log level from warning to info or debug during commit. Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch, HBASE-10521-trunk_v3.patch, HBASE-10521-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10521: Status: Open (was: Patch Available) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch, HBASE-10521-trunk_v3.patch, HBASE-10521-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[ https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905552#comment-13905552 ] Nicolas Liochon commented on HBASE-10521: - (patch submitted again to get a new run) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient - Key: HBASE-10521 URL: https://issues.apache.org/jira/browse/HBASE-10521 Project: HBase Issue Type: Sub-task Components: IPC/RPC Reporter: Feng Honghua Assignee: Feng Honghua Priority: Minor Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch, HBASE-10521-trunk_v3.patch, HBASE-10521-trunk_v3.patch A sub-task of HBASE-10497 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10567) Add overwrite manifest option to ExportSnapshot
[
https://issues.apache.org/jira/browse/HBASE-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905571#comment-13905571
]
Jonathan Hsieh commented on HBASE-10567:
should check return value here and return error message.
{code}
@@ -686,6 +689,9 @@ public final class ExportSnapshot extends Configured
implements Tool {
}
// Step 3 - Rename fs2:/.snapshot/.tmp/snapshot
fs2:/.snapshot/snapshot
+ if (overwrite outputFs.exists(outputSnapshotDir)) {
+outputFs.delete(outputSnapshotDir, true);
+ }
if (!outputFs.rename(snapshotTmpDir, outputSnapshotDir)) {
System.err.println(Snapshot export failed!);
System.err.println(Unable to rename snapshot directory from= +
{code}
Otherwise looks good to me.
Add overwrite manifest option to ExportSnapshot
---
Key: HBASE-10567
URL: https://issues.apache.org/jira/browse/HBASE-10567
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.98.0, 0.94.16, 0.99.0, 0.96.1.1
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE-10567-v0.patch
If you want to export a snapshot twice (e.g. in case you accidentally removed
a file and now your snapshot is corrupted) you have to manually remove the
.hbase-snapshot/SNAPSHOT_NAME directory and then run the ExportSnapshot tool.
Add an -overwrite option to this operation automatically.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10525) Allow the client to use a different thread for writing to ease interrupt
[ https://issues.apache.org/jira/browse/HBASE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10525: Status: Open (was: Patch Available) Allow the client to use a different thread for writing to ease interrupt Key: HBASE-10525 URL: https://issues.apache.org/jira/browse/HBASE-10525 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10525.v1.patch, 10525.v2.patch, HBaseclient-EventualConsistency.pdf This is an issue in the HBASE-10070 context, but as well more generally if you want to interrupt an operation with a limited cost. I will attach a doc with a more detailed explanation. This adds a thread per region server; so it's otional. The first patch activates it by default to see how it behaves on a full hadoop-qa run. The target is to be unset by default. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10525) Allow the client to use a different thread for writing to ease interrupt
[ https://issues.apache.org/jira/browse/HBASE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10525: Attachment: 10525.v3.patch Allow the client to use a different thread for writing to ease interrupt Key: HBASE-10525 URL: https://issues.apache.org/jira/browse/HBASE-10525 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10525.v1.patch, 10525.v2.patch, 10525.v3.patch, HBaseclient-EventualConsistency.pdf This is an issue in the HBASE-10070 context, but as well more generally if you want to interrupt an operation with a limited cost. I will attach a doc with a more detailed explanation. This adds a thread per region server; so it's otional. The first patch activates it by default to see how it behaves on a full hadoop-qa run. The target is to be unset by default. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10525) Allow the client to use a different thread for writing to ease interrupt
[ https://issues.apache.org/jira/browse/HBASE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10525: Status: Patch Available (was: Open) same as v2 excepted that the new behavior is disabled by default. It's what I would like to commit. Allow the client to use a different thread for writing to ease interrupt Key: HBASE-10525 URL: https://issues.apache.org/jira/browse/HBASE-10525 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10525.v1.patch, 10525.v2.patch, 10525.v3.patch, HBaseclient-EventualConsistency.pdf This is an issue in the HBASE-10070 context, but as well more generally if you want to interrupt an operation with a limited cost. I will attach a doc with a more detailed explanation. This adds a thread per region server; so it's otional. The first patch activates it by default to see how it behaves on a full hadoop-qa run. The target is to be unset by default. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (HBASE-10568) InMemroy Row Prefix Bloom Filter
Manukranth Kolloju created HBASE-10568: -- Summary: InMemroy Row Prefix Bloom Filter Key: HBASE-10568 URL: https://issues.apache.org/jira/browse/HBASE-10568 Project: HBase Issue Type: New Feature Components: regionserver Affects Versions: 0.89-fb Reporter: Manukranth Kolloju Assignee: Manukranth Kolloju Fix For: 0.89-fb This in-memory bloom filter gives faster lookups for rowPrefixes while using CompoundRowPrefixFilter. This intends to supplement the row prefix filter on the hfiles. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10567) Add overwrite manifest option to ExportSnapshot
[
https://issues.apache.org/jira/browse/HBASE-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905612#comment-13905612
]
Hadoop QA commented on HBASE-10567:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629770/HBASE-10567-v0.patch
against trunk revision .
ATTACHMENT ID: 12629770
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8744//console
This message is automatically generated.
Add overwrite manifest option to ExportSnapshot
---
Key: HBASE-10567
URL: https://issues.apache.org/jira/browse/HBASE-10567
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.98.0, 0.94.16, 0.99.0, 0.96.1.1
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE-10567-v0.patch
If you want to export a snapshot twice (e.g. in case you accidentally removed
a file and now your snapshot is corrupted) you have to manually remove the
.hbase-snapshot/SNAPSHOT_NAME directory and then run the ExportSnapshot tool.
Add an -overwrite option to this operation automatically.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10523) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util
[ https://issues.apache.org/jira/browse/HBASE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905655#comment-13905655 ] Hudson commented on HBASE-10523: SUCCESS: Integrated in HBase-TRUNK #4932 (See [https://builds.apache.org/job/HBase-TRUNK/4932/]) HBASE-10523 Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util (Feng Honghua) (nkeywal: rev 1569733) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in util Key: HBASE-10523 URL: https://issues.apache.org/jira/browse/HBASE-10523 Project: HBase Issue Type: Sub-task Components: util Affects Versions: 0.98.0, 0.99.0 Reporter: Feng Honghua Assignee: Feng Honghua Fix For: 0.99.0 Attachments: HBASE-10523-trunk_v1.patch, HBASE-10523-trunk_v2.patch, HBASE-10523-trunk_v3.patch A sub-task of HBASE-10497 # correct wrong handling of InterruptedException where Thread.currentThread.interrupt() is called within while loops # add proper handling for swallowed InterruptedException -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10350) Master/AM/RegionStates changes to create and assign region replicas
[ https://issues.apache.org/jira/browse/HBASE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905662#comment-13905662 ] Jimmy Xiang commented on HBASE-10350: - Looks good to me. +1. Master/AM/RegionStates changes to create and assign region replicas --- Key: HBASE-10350 URL: https://issues.apache.org/jira/browse/HBASE-10350 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Devaraj Das Fix For: 0.99.0 Attachments: 10350-1.txt, 10350-3.txt, 10350-4-5.txt As per design in the parent jira, this jira will capture the changes in the master side (especially AM / RegionStates) for creating tables with region replicas, and making sure the regions are assigned on create and failover. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10524) Correct wrong handling and add proper handling for swallowed InterruptedException thrown by Thread.sleep in regionserver
[
https://issues.apache.org/jira/browse/HBASE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905663#comment-13905663
]
Hadoop QA commented on HBASE-10524:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629769/split.patch
against trunk revision .
ATTACHMENT ID: 12629769
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8745//console
This message is automatically generated.
Correct wrong handling and add proper handling for swallowed
InterruptedException thrown by Thread.sleep in regionserver
Key: HBASE-10524
URL: https://issues.apache.org/jira/browse/HBASE-10524
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-10524-trunk_v1.patch, HBASE-10524-trunk_v2.patch,
split.patch
A sub-task of HBASE-10497
# correct wrong handling of InterruptedException where
Thread.currentThread.interrupt() is called within while loops
# add proper handling for swallowed InterruptedException
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Created] (HBASE-10569) Co-locate meta and master
Jimmy Xiang created HBASE-10569: --- Summary: Co-locate meta and master Key: HBASE-10569 URL: https://issues.apache.org/jira/browse/HBASE-10569 Project: HBase Issue Type: Improvement Components: master, Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang I was thinking simplifying/improving the region assignments. The first step is to co-locate the meta and the master as many people agreed on HBASE-5487. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10419) Add multiget support to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-10419: - Attachment: HBASE-10419-0.96.patch patch for 0.96. Add multiget support to PerformanceEvaluation - Key: HBASE-10419 URL: https://issues.apache.org/jira/browse/HBASE-10419 Project: HBase Issue Type: Improvement Components: test Reporter: Nick Dimiduk Assignee: Nick Dimiduk Priority: Minor Attachments: HBASE-10419-0.96.patch, HBASE-10419-v2-trunk.patch, HBASE-10419-v3-trunk.patch, HBASE-10419-v4-trunk.patch, HBASE-10419.0.patch, HBASE-10419.1.patch Folks planning to use multiget may find this useful. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10419) Add multiget support to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-10419: - Resolution: Fixed Status: Resolved (was: Patch Available) Coommitted to 0.96, 0.98, trunk. Thanks folks. Add multiget support to PerformanceEvaluation - Key: HBASE-10419 URL: https://issues.apache.org/jira/browse/HBASE-10419 Project: HBase Issue Type: Improvement Components: test Reporter: Nick Dimiduk Assignee: Nick Dimiduk Priority: Minor Attachments: HBASE-10419-0.96.patch, HBASE-10419-v2-trunk.patch, HBASE-10419-v3-trunk.patch, HBASE-10419-v4-trunk.patch, HBASE-10419.0.patch, HBASE-10419.1.patch Folks planning to use multiget may find this useful. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[
https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rajeshbabu updated HBASE-10534:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.96,0.98 and trunk.
Thanks for review Ted and Anoop.
Rowkey in TsvImporterTextMapper initializing with wrong length
--
Key: HBASE-10534
URL: https://issues.apache.org/jira/browse/HBASE-10534
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.96.0
Reporter: rajeshbabu
Assignee: rajeshbabu
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: HBASE-10534.patch
In TsvImporterTextMapper rowkey initializing with wrong length.
parser.parseRowKey give pair of start and end positions, so the rowkey length
initialized with rowkey end position instead of length.
{code}
PairInteger,Integer rowKeyOffests =
parser.parseRowKey(value.getBytes(), value.getLength());
ImmutableBytesWritable rowKey = new ImmutableBytesWritable(
value.getBytes(), rowKeyOffests.getFirst(),
rowKeyOffests.getSecond());
{code}
Its better to change TsvParser#parseRowKey to return starting position and
length of rowkey.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10566) cleanup rpcTimeout in the client
[
https://issues.apache.org/jira/browse/HBASE-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905738#comment-13905738
]
Nicolas Liochon commented on HBASE-10566:
-
To be fixed in this patch, there is a bug in HTable#mutateRow
{code}
public void mutateRow(final RowMutations rm) throws IOException {
RegionServerCallableVoid callable =
new RegionServerCallableVoid(connection, getName(), rm.getRow()) {
public Void call() throws IOException {
try {
RegionAction.Builder regionMutationBuilder =
RequestConverter.buildRegionAction(
getLocation().getRegionInfo().getRegionName(), rm);
regionMutationBuilder.setAtomic(true);
MultiRequest request =
MultiRequest.newBuilder().addRegionAction(regionMutationBuilder.build()).build();
PayloadCarryingRpcController pcrc = new
PayloadCarryingRpcController();
pcrc.setPriority(tableName);
getStub().multi(null, request); pcrc
not used
} catch (ServiceException se) {
throw ProtobufUtil.getRemoteException(se);
}
return null;
}
};
rpcCallerFactory.Void newCaller().callWithRetries(callable,
this.operationTimeout);
}
{code}
cleanup rpcTimeout in the client
Key: HBASE-10566
URL: https://issues.apache.org/jira/browse/HBASE-10566
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 0.99.0
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Fix For: 0.99.0
There are two issues:
1) A confusion between the socket timeout and the call timeout
Socket timeouts should be minimal: a default like 20 seconds, that could be
lowered to single digits timeouts for some apps: if we can not write to the
socket in 10 second, we have an issue. This is different from the total
duration (send query + do query + receive query), that can be longer, as it
can include remotes calls on the server and so on. Today, we have a single
value, it does not allow us to have low socket read timeouts.
2) The timeout can be different between the calls. Typically, if the total
time, retries included is 60 seconds but failed after 2 seconds, then the
remaining is 58s. HBase does this today, but by hacking with a thread local
storage variable. It's a hack (it should have been a parameter of the
methods, the TLS allowed to bypass all the layers. May be protobuf makes this
complicated, to be confirmed), but as well it does not really work, because
we can have multithreading issues (we use the updated rpc timeout of someone
else, or we create a new BlockingRpcChannelImplementation with a random
default timeout).
Ideally, we could send the call timeout to the server as well: it will be
able to dismiss alone the calls that it received but git stick in the request
queue or in the internal retries (on hdfs for example).
This will make the system more reactive to failure.
I think we can solve this now, especially after 10525. The main issue is to
something that fits well with protobuf...
Then it should be easy to have a pool of thread for writers and readers, w/o
a single thread per region server as today.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10569) Co-locate meta and master
[ https://issues.apache.org/jira/browse/HBASE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905749#comment-13905749 ] Elliott Clark commented on HBASE-10569: --- +1 Co-locate meta and master - Key: HBASE-10569 URL: https://issues.apache.org/jira/browse/HBASE-10569 Project: HBase Issue Type: Improvement Components: master, Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang I was thinking simplifying/improving the region assignments. The first step is to co-locate the meta and the master as many people agreed on HBASE-5487. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10526) Using Cell instead of KeyValue in HFileOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905751#comment-13905751 ] Jonathan Hsieh commented on HBASE-10526: Nick D bq. I'm not a fan of maintaining both versions of this thing – and especially not a fan of the new class's name because it confuses the file format version. bq. Can we instead deprecate the KeyValue version in 0.96, 0.98 and replace it with the Cell version on trunk? jimmy bq. It's better not to simply replace it, which may impact the upgrade path of some existing old applications. As to the class name, I am open for suggestions. v2 has HFIleOutputFormat (KV version) deprecated and pointing to HFileOutputFormat2 (Cell version). I'd be fine if 0.98 and 0.96 had both with the old KV version deprecated. (I'd argue this is early enough in both branch's lives and this is a compat problem from 0.94.) I'd also prefer it if trunk could remove the old version and only have the Cell version. I think HFileOutputFormat2 is as good as any. We are still writing the same files out -- just providing a api cleanup. Using Cell instead of KeyValue in HFileOutputFormat --- Key: HBASE-10526 URL: https://issues.apache.org/jira/browse/HBASE-10526 Project: HBase Issue Type: Sub-task Components: mapreduce Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: hbase-10526.patch, hbase-10526_v1.1.patch, hbase-10526_v2.patch HFileOutputFormat/KeyValueSortReducer use KeyValue. We should deprecate them and use Cell instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
[
https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905755#comment-13905755
]
Nick Dimiduk commented on HBASE-10531:
--
Patch looks good to me. I'd rename {{Cell kv}} to {{Cell key}} so it's clear to
the reader that only the key part is considered.
Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
Key: HBASE-10531
URL: https://issues.apache.org/jira/browse/HBASE-10531
Project: HBase
Issue Type: Sub-task
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.99.0
Attachments: HBASE-10531.patch
Currently the byte[] key passed to HFileScanner.seekTo and
HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts. And
the caller forms this by using kv.getBuffer, which is actually deprecated.
So see how this can be achieved considering kv.getBuffer is removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10526) Using Cell instead of KeyValue in HFileOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905756#comment-13905756 ] Jonathan Hsieh commented on HBASE-10526: I'm +1 on this assuming that it was mostly a copy and paste job and after the qabot cleanup. Using Cell instead of KeyValue in HFileOutputFormat --- Key: HBASE-10526 URL: https://issues.apache.org/jira/browse/HBASE-10526 Project: HBase Issue Type: Sub-task Components: mapreduce Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: hbase-10526.patch, hbase-10526_v1.1.patch, hbase-10526_v2.patch HFileOutputFormat/KeyValueSortReducer use KeyValue. We should deprecate them and use Cell instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10521) Add handling for swallowed InterruptedException thrown by Thread.sleep in RpcServer and RpcClient
[
https://issues.apache.org/jira/browse/HBASE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905764#comment-13905764
]
Hadoop QA commented on HBASE-10521:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629785/HBASE-10521-trunk_v3.patch
against trunk revision .
ATTACHMENT ID: 12629785
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8746//console
This message is automatically generated.
Add handling for swallowed InterruptedException thrown by Thread.sleep in
RpcServer and RpcClient
-
Key: HBASE-10521
URL: https://issues.apache.org/jira/browse/HBASE-10521
Project: HBase
Issue Type: Sub-task
Components: IPC/RPC
Reporter: Feng Honghua
Assignee: Feng Honghua
Priority: Minor
Attachments: HBASE-10521-trunk_v1.patch, HBASE-10521-trunk_v2.patch,
HBASE-10521-trunk_v3.patch, HBASE-10521-trunk_v3.patch
A sub-task of HBASE-10497
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10350) Master/AM/RegionStates changes to create and assign region replicas
[ https://issues.apache.org/jira/browse/HBASE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-10350: Attachment: 10350-4-6.txt Thanks for the reviews, Enis and Jimmy. This is the patch I am going to commit in the branch (there was one minor conflict). Master/AM/RegionStates changes to create and assign region replicas --- Key: HBASE-10350 URL: https://issues.apache.org/jira/browse/HBASE-10350 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Devaraj Das Fix For: 0.99.0 Attachments: 10350-1.txt, 10350-3.txt, 10350-4-5.txt, 10350-4-6.txt As per design in the parent jira, this jira will capture the changes in the master side (especially AM / RegionStates) for creating tables with region replicas, and making sure the regions are assigned on create and failover. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10350) Master/AM/RegionStates changes to create and assign region replicas
[ https://issues.apache.org/jira/browse/HBASE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905776#comment-13905776 ] Devaraj Das commented on HBASE-10350: - Committed to branch hbase-10070. Master/AM/RegionStates changes to create and assign region replicas --- Key: HBASE-10350 URL: https://issues.apache.org/jira/browse/HBASE-10350 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Devaraj Das Fix For: 0.99.0, hbase-10070 Attachments: 10350-1.txt, 10350-3.txt, 10350-4-5.txt, 10350-4-6.txt As per design in the parent jira, this jira will capture the changes in the master side (especially AM / RegionStates) for creating tables with region replicas, and making sure the regions are assigned on create and failover. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10350) Master/AM/RegionStates changes to create and assign region replicas
[ https://issues.apache.org/jira/browse/HBASE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-10350: Fix Version/s: hbase-10070 Master/AM/RegionStates changes to create and assign region replicas --- Key: HBASE-10350 URL: https://issues.apache.org/jira/browse/HBASE-10350 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Devaraj Das Fix For: 0.99.0, hbase-10070 Attachments: 10350-1.txt, 10350-3.txt, 10350-4-5.txt, 10350-4-6.txt As per design in the parent jira, this jira will capture the changes in the master side (especially AM / RegionStates) for creating tables with region replicas, and making sure the regions are assigned on create and failover. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10451) Enable back Tag compression on HFiles
[ https://issues.apache.org/jira/browse/HBASE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-10451: --- Attachment: HBASE-10451_V5.patch Sorry.. I have to again -1 my own patch and have to change the approach. Dictionary impl is LRU and so when find index of an entry the entry will be moved to head. So we can not assume the head entry is the one we have to delete on move previous. [KV can have a new tag and an already added tag as second tag] Also based on the counter we can not know the position of entry to be deleted, as when the size of the dictionary reaches capacity, we will add new entries in random locations (pointed by current tail). A simpler approach to solve the problem can be like When we do movePrevious, we cache the tag bytes into the current State and also a boolean state set as not to do uncompress of tags in the next time decodeNext() call. Also we will cache the total compressed length of the tags bytes. When next time decode of next entry happens, we will not try uncompressinf tags. We will just use the cached tags bytes and just skip 'tagsCompressedLength' bytes of source stream. With this patch the YCSB test scenario what Ram tested passes.(Scenario reproduced in a UT) Also the Integration test passes. Ram can you run YCSB in your env also once pls and confirm this is fine ? Enable back Tag compression on HFiles - Key: HBASE-10451 URL: https://issues.apache.org/jira/browse/HBASE-10451 Project: HBase Issue Type: Bug Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Priority: Critical Fix For: 0.98.1, 0.99.0 Attachments: HBASE-10451.patch, HBASE-10451_V2.patch, HBASE-10451_V3.patch, HBASE-10451_V4.patch, HBASE-10451_V5.patch HBASE-10443 disables tag compression on HFiles. This Jira is to fix the issues we have found out in HBASE-10443 and enable it back. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10525) Allow the client to use a different thread for writing to ease interrupt
[
https://issues.apache.org/jira/browse/HBASE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905805#comment-13905805
]
Hadoop QA commented on HBASE-10525:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629790/10525.v3.patch
against trunk revision .
ATTACHMENT ID: 12629790
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8747//console
This message is automatically generated.
Allow the client to use a different thread for writing to ease interrupt
Key: HBASE-10525
URL: https://issues.apache.org/jira/browse/HBASE-10525
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 0.99.0
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Fix For: 0.99.0
Attachments: 10525.v1.patch, 10525.v2.patch, 10525.v3.patch,
HBaseclient-EventualConsistency.pdf
This is an issue in the HBASE-10070 context, but as well more generally if
you want to interrupt an operation with a limited cost.
I will attach a doc with a more detailed explanation.
This adds a thread per region server; so it's otional. The first patch
activates it by default to see how it behaves on a full hadoop-qa run. The
target is to be unset by default.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Created] (HBASE-10570) Allow overrides of Surefire secondPartForkMode and testFailureIgnore
Andrew Purtell created HBASE-10570:
--
Summary: Allow overrides of Surefire secondPartForkMode and
testFailureIgnore
Key: HBASE-10570
URL: https://issues.apache.org/jira/browse/HBASE-10570
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Priority: Minor
Fix For: 0.96.2, 0.98.1, 0.99.0
It can be useful to override the fork and ignore behavior of our Surefire unit
testing machinery.
For example, this will put only one test into each generated surefire jar and
always fork a child JVM to run it:
{noformat}
mvn test ... -Dsurefire.firstPartForkMode=always
-Dsurefire.secondPartForkMode=always
{noformat}
Useful for isolating test failures and finding zombies.
Sometimes it is also useful to ignore test failures:
{noformat}
mvn test ... -Dsurefire.testFailureIgnore=true
{noformat}
This will let test suite execution continue even if a test times out. Maven has
CLI options for this sort of thing but they don't always work as expected.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10570) Allow overrides of Surefire secondPartForkMode and testFailureIgnore
[
https://issues.apache.org/jira/browse/HBASE-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-10570:
---
Status: Patch Available (was: Open)
Allow overrides of Surefire secondPartForkMode and testFailureIgnore
Key: HBASE-10570
URL: https://issues.apache.org/jira/browse/HBASE-10570
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Priority: Minor
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: 10570.patch
It can be useful to override the fork and ignore behavior of our Surefire
unit testing machinery.
For example, this will put only one test into each generated surefire jar and
always fork a child JVM to run it:
{noformat}
mvn test ... -Dsurefire.firstPartForkMode=always
-Dsurefire.secondPartForkMode=always
{noformat}
Useful for isolating test failures and finding zombies.
Sometimes it is also useful to ignore test failures:
{noformat}
mvn test ... -Dsurefire.testFailureIgnore=true
{noformat}
This will let test suite execution continue even if a test times out. Maven
has CLI options for this sort of thing but they don't always work as
expected.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-10570) Allow overrides of Surefire secondPartForkMode and testFailureIgnore
[
https://issues.apache.org/jira/browse/HBASE-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-10570:
---
Attachment: 10570.patch
Allow overrides of Surefire secondPartForkMode and testFailureIgnore
Key: HBASE-10570
URL: https://issues.apache.org/jira/browse/HBASE-10570
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Priority: Minor
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: 10570.patch
It can be useful to override the fork and ignore behavior of our Surefire
unit testing machinery.
For example, this will put only one test into each generated surefire jar and
always fork a child JVM to run it:
{noformat}
mvn test ... -Dsurefire.firstPartForkMode=always
-Dsurefire.secondPartForkMode=always
{noformat}
Useful for isolating test failures and finding zombies.
Sometimes it is also useful to ignore test failures:
{noformat}
mvn test ... -Dsurefire.testFailureIgnore=true
{noformat}
This will let test suite execution continue even if a test times out. Maven
has CLI options for this sort of thing but they don't always work as
expected.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
[
https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905815#comment-13905815
]
Anoop Sam John commented on HBASE-10531:
HFileScanner is @InterfaceAudience.Private Still we have to do deprecate and
then add new API as overloaded?
It will be better to add the alternate API to use along with @Deprecated.
nit : There are white spaces in the patch.
{code}
+ public int seekTo(Cell kv) throws IOException {
+KeyValue keyValue = KeyValueUtil.ensureKeyValue(kv);
+return seekTo(keyValue.getBuffer(), keyValue.getOffset(),
keyValue.getLength());
+ }
{code}
You will avoid the refercence to keyValue.getBuffer() in coming patches?
In the code we still refer to deprecated API. Better we can use the new API
now. (?)
Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
Key: HBASE-10531
URL: https://issues.apache.org/jira/browse/HBASE-10531
Project: HBase
Issue Type: Sub-task
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Fix For: 0.99.0
Attachments: HBASE-10531.patch
Currently the byte[] key passed to HFileScanner.seekTo and
HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts. And
the caller forms this by using kv.getBuffer, which is actually deprecated.
So see how this can be achieved considering kv.getBuffer is removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
[ https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905846#comment-13905846 ] Andrew Purtell commented on HBASE-10531: It would be great if we can do an exorcism of private interfaces rather than deprecate them. We did this for KeyValue comparators between 0.96 and 0.98. I get that folks like Phoenix want some measure of internal interface stability, but until 1.0 if the cost is adding technical debt in the form of littering the code with half-broken or fully broken deprecated APIs, it is not worth it. Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo Key: HBASE-10531 URL: https://issues.apache.org/jira/browse/HBASE-10531 Project: HBase Issue Type: Sub-task Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.99.0 Attachments: HBASE-10531.patch Currently the byte[] key passed to HFileScanner.seekTo and HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts. And the caller forms this by using kv.getBuffer, which is actually deprecated. So see how this can be achieved considering kv.getBuffer is removed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-7320) Remove KeyValue.getBuffer()
[ https://issues.apache.org/jira/browse/HBASE-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905864#comment-13905864 ] Andrew Purtell commented on HBASE-7320: --- bq. Another tricky part is serialization and deserialization. We do not want to change the HFile storage format (I think). Maybe. I think an ideal state is where we are operating in place on encoded cells from disk to socket and vice versa. (For example, http://kentonv.github.io/capnproto/encoding.html) Remove KeyValue.getBuffer() --- Key: HBASE-7320 URL: https://issues.apache.org/jira/browse/HBASE-7320 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl Assignee: stack Fix For: 0.99.0 Attachments: 7320-simple.txt In many places this is simple task of just replacing the method name. There, however, quite a few places where we assume that: # the entire KV is backed by a single byte array # the KVs key portion is backed by a single byte array Some of those can easily be fixed, others will need their own jiras. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10566) cleanup rpcTimeout in the client
[ https://issues.apache.org/jira/browse/HBASE-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905868#comment-13905868 ] Nicolas Liochon commented on HBASE-10566: - Here a sample, using the rpcController to give the info: - call() is replaced by call(finishBefore): it indicates that the call should finish before this time - call(0) means default timeout - we could forward the info to the server (somewhere in protobuf) - we would need to instantiate one rpcController per call (we more or less do that already) Any opinion on the approach? It seems that's how protobuf should be used, but I may be wrong. cleanup rpcTimeout in the client Key: HBASE-10566 URL: https://issues.apache.org/jira/browse/HBASE-10566 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10566.sample.patch There are two issues: 1) A confusion between the socket timeout and the call timeout Socket timeouts should be minimal: a default like 20 seconds, that could be lowered to single digits timeouts for some apps: if we can not write to the socket in 10 second, we have an issue. This is different from the total duration (send query + do query + receive query), that can be longer, as it can include remotes calls on the server and so on. Today, we have a single value, it does not allow us to have low socket read timeouts. 2) The timeout can be different between the calls. Typically, if the total time, retries included is 60 seconds but failed after 2 seconds, then the remaining is 58s. HBase does this today, but by hacking with a thread local storage variable. It's a hack (it should have been a parameter of the methods, the TLS allowed to bypass all the layers. May be protobuf makes this complicated, to be confirmed), but as well it does not really work, because we can have multithreading issues (we use the updated rpc timeout of someone else, or we create a new BlockingRpcChannelImplementation with a random default timeout). Ideally, we could send the call timeout to the server as well: it will be able to dismiss alone the calls that it received but git stick in the request queue or in the internal retries (on hdfs for example). This will make the system more reactive to failure. I think we can solve this now, especially after 10525. The main issue is to something that fits well with protobuf... Then it should be easy to have a pool of thread for writers and readers, w/o a single thread per region server as today. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10566) cleanup rpcTimeout in the client
[ https://issues.apache.org/jira/browse/HBASE-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Liochon updated HBASE-10566: Attachment: 10566.sample.patch cleanup rpcTimeout in the client Key: HBASE-10566 URL: https://issues.apache.org/jira/browse/HBASE-10566 Project: HBase Issue Type: Bug Components: Client Affects Versions: 0.99.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10566.sample.patch There are two issues: 1) A confusion between the socket timeout and the call timeout Socket timeouts should be minimal: a default like 20 seconds, that could be lowered to single digits timeouts for some apps: if we can not write to the socket in 10 second, we have an issue. This is different from the total duration (send query + do query + receive query), that can be longer, as it can include remotes calls on the server and so on. Today, we have a single value, it does not allow us to have low socket read timeouts. 2) The timeout can be different between the calls. Typically, if the total time, retries included is 60 seconds but failed after 2 seconds, then the remaining is 58s. HBase does this today, but by hacking with a thread local storage variable. It's a hack (it should have been a parameter of the methods, the TLS allowed to bypass all the layers. May be protobuf makes this complicated, to be confirmed), but as well it does not really work, because we can have multithreading issues (we use the updated rpc timeout of someone else, or we create a new BlockingRpcChannelImplementation with a random default timeout). Ideally, we could send the call timeout to the server as well: it will be able to dismiss alone the calls that it received but git stick in the request queue or in the internal retries (on hdfs for example). This will make the system more reactive to failure. I think we can solve this now, especially after 10525. The main issue is to something that fits well with protobuf... Then it should be easy to have a pool of thread for writers and readers, w/o a single thread per region server as today. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10451) Enable back Tag compression on HFiles
[ https://issues.apache.org/jira/browse/HBASE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905850#comment-13905850 ] Andrew Purtell commented on HBASE-10451: I will +1 the latest patch if you can post evidence of successful cluster test results to this JIRA. Enable back Tag compression on HFiles - Key: HBASE-10451 URL: https://issues.apache.org/jira/browse/HBASE-10451 Project: HBase Issue Type: Bug Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Priority: Critical Fix For: 0.98.1, 0.99.0 Attachments: HBASE-10451.patch, HBASE-10451_V2.patch, HBASE-10451_V3.patch, HBASE-10451_V4.patch, HBASE-10451_V5.patch HBASE-10443 disables tag compression on HFiles. This Jira is to fix the issues we have found out in HBASE-10443 and enable it back. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10569) Co-locate meta and master
[ https://issues.apache.org/jira/browse/HBASE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905851#comment-13905851 ] Enis Soztutar commented on HBASE-10569: --- I think this would be a good incremental step towards a more sane master implementation. We can alternatively decide to not co-locate meta, but make meta read only for region servers and clients, only to be written by master. RS operations will be carried through master (RS sends RPC to master, and master does the meta update). If co-locating, are you thinking of opening the region (and rest of RS machinery in master), or move some of the assignment logic to the RS who hosts meta? Co-locate meta and master - Key: HBASE-10569 URL: https://issues.apache.org/jira/browse/HBASE-10569 Project: HBase Issue Type: Improvement Components: master, Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang I was thinking simplifying/improving the region assignments. The first step is to co-locate the meta and the master as many people agreed on HBASE-5487. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10355) Failover RPC's from client using region replicas
[
https://issues.apache.org/jira/browse/HBASE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905853#comment-13905853
]
Enis Soztutar commented on HBASE-10355:
---
The patch looks great.
This patch defines primaryCallTimeout in nanosec, while HBASE-10356 is in ms.
We should fix either that or this. We can append ns or ms to the name of the
conf option.
It looks costly to get these from configuration for every get:
{code}
+int callTimeout = configuration.getInt(
{code}
Can we get this once and save it at initialization.
Interruption via Future.cancel() seems good. It works with HBASE-10472, right?
I guess CompletionService is also available for jdk6. Are you gonna submit an
updated patch?
Failover RPC's from client using region replicas
Key: HBASE-10355
URL: https://issues.apache.org/jira/browse/HBASE-10355
Project: HBase
Issue Type: Sub-task
Components: Client
Reporter: Enis Soztutar
Assignee: Nicolas Liochon
Fix For: 0.99.0
Attachments: 10355.v1.patch, 10355.v2.patch
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10355) Failover RPC's from client using region replicas
[ https://issues.apache.org/jira/browse/HBASE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905878#comment-13905878 ] Nicolas Liochon commented on HBASE-10355: - bq. We should fix either that or this I think we need micro seconds, at least for testing: a synchronous get takes ~0.2ms on my 1Gb network, so if we want to play with the secondary calls probability with probability different than 0 100%, we need it. As well, for end user, it makes send to use values like 50m microseconds: compared to 1ms, it divides the latency by 2. And the perf will be much better on a modern hardware actually. bq. It works with HBASE-10472, right? Yes, plus HBASE-10525 bq. I guess CompletionService is also available for jdk6 Actually yes. I was wrong. But the v2 simplifies a little the code compared to the default CompletionService, so I prefer to keep it actually. Failover RPC's from client using region replicas Key: HBASE-10355 URL: https://issues.apache.org/jira/browse/HBASE-10355 Project: HBase Issue Type: Sub-task Components: Client Reporter: Enis Soztutar Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10355.v1.patch, 10355.v2.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10569) Co-locate meta and master
[ https://issues.apache.org/jira/browse/HBASE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905883#comment-13905883 ] Jimmy Xiang commented on HBASE-10569: - bq. If co-locating, are you thinking of opening the region (and rest of RS machinery in master), or move some of the assignment logic to the RS who hosts meta? The first one. I was thinking to make a master also a region server. So that all are region servers. By configuration, some region servers can host the master processes. Co-locate meta and master - Key: HBASE-10569 URL: https://issues.apache.org/jira/browse/HBASE-10569 Project: HBase Issue Type: Improvement Components: master, Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang I was thinking simplifying/improving the region assignments. The first step is to co-locate the meta and the master as many people agreed on HBASE-5487. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10355) Failover RPC's from client using region replicas
[ https://issues.apache.org/jira/browse/HBASE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905887#comment-13905887 ] Nicolas Liochon commented on HBASE-10355: - I forgot about this: bq. int callTimeout = configuration.getInt( I'm going to do a v3 to do that; Failover RPC's from client using region replicas Key: HBASE-10355 URL: https://issues.apache.org/jira/browse/HBASE-10355 Project: HBase Issue Type: Sub-task Components: Client Reporter: Enis Soztutar Assignee: Nicolas Liochon Fix For: 0.99.0 Attachments: 10355.v1.patch, 10355.v2.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10567) Add overwrite manifest option to ExportSnapshot
[ https://issues.apache.org/jira/browse/HBASE-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-10567: Attachment: HBASE-10567-v1.patch v1 is slightly different, I've added the return check but moved the delete at the beginning, to avoid the case where the destination is another hbase cluster and someone will do a restore/clone during the ExportSnapshot operation.. by deleting the folder the snapshot will not be available for list/restore/clone until the end of the export. Add overwrite manifest option to ExportSnapshot --- Key: HBASE-10567 URL: https://issues.apache.org/jira/browse/HBASE-10567 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.98.0, 0.94.16, 0.99.0, 0.96.1.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-10567-v0.patch, HBASE-10567-v1.patch If you want to export a snapshot twice (e.g. in case you accidentally removed a file and now your snapshot is corrupted) you have to manually remove the .hbase-snapshot/SNAPSHOT_NAME directory and then run the ExportSnapshot tool. Add an -overwrite option to this operation automatically. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10362) HBCK changes for supporting region replicas
[ https://issues.apache.org/jira/browse/HBASE-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905959#comment-13905959 ] Enis Soztutar commented on HBASE-10362: --- I think the patch needs an update with the latest branch changes. HBCK changes for supporting region replicas --- Key: HBASE-10362 URL: https://issues.apache.org/jira/browse/HBASE-10362 Project: HBase Issue Type: Sub-task Components: hbck Reporter: Enis Soztutar Assignee: Devaraj Das Fix For: 0.99.0 Attachments: 10362-1.txt We should support region replicas in HBCK. The changes are probably not that intrusive. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10526) Using Cell instead of KeyValue in HFileOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated HBASE-10526: Attachment: hbase-10526_v3.patch Attached patch v3 that fixed the qabot warnings. Ok, will remove the old version in trunk, and keep both the new one and the older one in 0.96 and 0.98. Using Cell instead of KeyValue in HFileOutputFormat --- Key: HBASE-10526 URL: https://issues.apache.org/jira/browse/HBASE-10526 Project: HBase Issue Type: Sub-task Components: mapreduce Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: hbase-10526.patch, hbase-10526_v1.1.patch, hbase-10526_v2.patch, hbase-10526_v3.patch HFileOutputFormat/KeyValueSortReducer use KeyValue. We should deprecate them and use Cell instead. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10451) Enable back Tag compression on HFiles
[
https://issues.apache.org/jira/browse/HBASE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905990#comment-13905990
]
Hadoop QA commented on HBASE-10451:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629832/HBASE-10451_V5.patch
against trunk revision .
ATTACHMENT ID: 12629832
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers.testEncodedSeeker(TestEncodedSeekers.java:125)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8749//console
This message is automatically generated.
Enable back Tag compression on HFiles
-
Key: HBASE-10451
URL: https://issues.apache.org/jira/browse/HBASE-10451
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Critical
Fix For: 0.98.1, 0.99.0
Attachments: HBASE-10451.patch, HBASE-10451_V2.patch,
HBASE-10451_V3.patch, HBASE-10451_V4.patch, HBASE-10451_V5.patch
HBASE-10443 disables tag compression on HFiles. This Jira is to fix the
issues we have found out in HBASE-10443 and enable it back.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10419) Add multiget support to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906011#comment-13906011 ] Hudson commented on HBASE-10419: SUCCESS: Integrated in HBase-0.98 #169 (See [https://builds.apache.org/job/HBase-0.98/169/]) HBASE-10419 Add multiget support to PerformanceEvaluation (ndimiduk: rev 1569827) * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java Add multiget support to PerformanceEvaluation - Key: HBASE-10419 URL: https://issues.apache.org/jira/browse/HBASE-10419 Project: HBase Issue Type: Improvement Components: test Reporter: Nick Dimiduk Assignee: Nick Dimiduk Priority: Minor Attachments: HBASE-10419-0.96.patch, HBASE-10419-v2-trunk.patch, HBASE-10419-v3-trunk.patch, HBASE-10419-v4-trunk.patch, HBASE-10419.0.patch, HBASE-10419.1.patch Folks planning to use multiget may find this useful. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10570) Allow overrides of Surefire secondPartForkMode and testFailureIgnore
[
https://issues.apache.org/jira/browse/HBASE-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906014#comment-13906014
]
Hadoop QA commented on HBASE-10570:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629835/10570.patch
against trunk revision .
ATTACHMENT ID: 12629835
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:354)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8750//console
This message is automatically generated.
Allow overrides of Surefire secondPartForkMode and testFailureIgnore
Key: HBASE-10570
URL: https://issues.apache.org/jira/browse/HBASE-10570
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Priority: Minor
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: 10570.patch
It can be useful to override the fork and ignore behavior of our Surefire
unit testing machinery.
For example, this will put only one test into each generated surefire jar and
always fork a child JVM to run it:
{noformat}
mvn test ... -Dsurefire.firstPartForkMode=always
-Dsurefire.secondPartForkMode=always
{noformat}
Useful for isolating test failures and finding zombies.
Sometimes it is also useful to ignore test failures:
{noformat}
mvn test ... -Dsurefire.testFailureIgnore=true
{noformat}
This will let test suite execution continue even if a test times out. Maven
has CLI options for this sort of thing but they don't always work as
expected.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10570) Allow overrides of Surefire secondPartForkMode and testFailureIgnore
[
https://issues.apache.org/jira/browse/HBASE-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906021#comment-13906021
]
Nicolas Liochon commented on HBASE-10570:
-
+1
Allow overrides of Surefire secondPartForkMode and testFailureIgnore
Key: HBASE-10570
URL: https://issues.apache.org/jira/browse/HBASE-10570
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Priority: Minor
Fix For: 0.96.2, 0.98.1, 0.99.0
Attachments: 10570.patch
It can be useful to override the fork and ignore behavior of our Surefire
unit testing machinery.
For example, this will put only one test into each generated surefire jar and
always fork a child JVM to run it:
{noformat}
mvn test ... -Dsurefire.firstPartForkMode=always
-Dsurefire.secondPartForkMode=always
{noformat}
Useful for isolating test failures and finding zombies.
Sometimes it is also useful to ignore test failures:
{noformat}
mvn test ... -Dsurefire.testFailureIgnore=true
{noformat}
This will let test suite execution continue even if a test times out. Maven
has CLI options for this sort of thing but they don't always work as
expected.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10419) Add multiget support to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906026#comment-13906026 ] Hudson commented on HBASE-10419: SUCCESS: Integrated in HBase-TRUNK #4933 (See [https://builds.apache.org/job/HBase-TRUNK/4933/]) HBASE-10419 Add multiget support to PerformanceEvaluation (ndimiduk: rev 1569826) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java Add multiget support to PerformanceEvaluation - Key: HBASE-10419 URL: https://issues.apache.org/jira/browse/HBASE-10419 Project: HBase Issue Type: Improvement Components: test Reporter: Nick Dimiduk Assignee: Nick Dimiduk Priority: Minor Attachments: HBASE-10419-0.96.patch, HBASE-10419-v2-trunk.patch, HBASE-10419-v3-trunk.patch, HBASE-10419-v4-trunk.patch, HBASE-10419.0.patch, HBASE-10419.1.patch Folks planning to use multiget may find this useful. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
