[jira] [Commented] (HBASE-13355) QA bot reports checking javac twice
[ https://issues.apache.org/jira/browse/HBASE-13355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385504#comment-14385504 ] Hudson commented on HBASE-13355: FAILURE: Integrated in HBase-TRUNK #6317 (See [https://builds.apache.org/job/HBase-TRUNK/6317/]) HBASE-13355 QA bot reports checking javac twice (eclark: rev 0967c6af29ba0546a167583535659a0c13de45b3) * dev-support/test-patch.sh QA bot reports checking javac twice --- Key: HBASE-13355 URL: https://issues.apache.org/jira/browse/HBASE-13355 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 2.0.0 Attachments: HBASE-13355-v1.patch, HBASE-13355.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13337) Table regions are not assigning back, after restarting all regionservers at once.
[ https://issues.apache.org/jira/browse/HBASE-13337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385517#comment-14385517 ] Y. SREENIVASULU REDDY commented on HBASE-13337: --- [~jxiang] In the above scenario all regionservers are graceful down. and you are correct as a step 6, if we restart the hmaster, all regions are assigning back, and able to continue with client operations. Table regions are not assigning back, after restarting all regionservers at once. - Key: HBASE-13337 URL: https://issues.apache.org/jira/browse/HBASE-13337 Project: HBase Issue Type: Bug Components: Region Assignment Affects Versions: 2.0.0 Reporter: Y. SREENIVASULU REDDY Priority: Blocker Fix For: 2.0.0 Regions of the table are continouly in state=FAILED_CLOSE. {noformat} RegionState RIT time (ms) 8f62e819b356736053e06240f7f7c6fd t1,,1427362431330.8f62e819b356736053e06240f7f7c6fd. state=FAILED_CLOSE, ts=Thu Mar 26 15:05:36 IST 2015 (113s ago), server=VM1,16040,1427362531818 113929 caf59209ae65ea80fca6bdc6996a7d68 t1,,1427362431330.caf59209ae65ea80fca6bdc6996a7d68. state=FAILED_CLOSE, ts=Thu Mar 26 15:05:36 IST 2015 (113s ago), server=VM2,16040,1427362533691 113929 db52a74988f71e5cf257bbabf31f26f3 t1,,1427362431330.db52a74988f71e5cf257bbabf31f26f3. state=FAILED_CLOSE, ts=Thu Mar 26 15:05:36 IST 2015 (113s ago), server=VM3,16040,1427362533691 113920 43f3a65b9f9ff283f598c5450feab1f8 t1,,1427362431330.43f3a65b9f9ff283f598c5450feab1f8. state=FAILED_CLOSE, ts=Thu Mar 26 15:05:36 IST 2015 (113s ago), server=VM1,16040,1427362531818 113920 {noformat} *Steps to reproduce:* 1. Start HBase cluster with more than one regionserver. 2. Create a table with precreated regions. (lets say 15 regions) 3. Make sure the regions are well balanced. 4. Restart all the Regionservers process at once across the cluster, except HMaster process 5. After restarting the Regionservers, successfully will connect to the HMaster. *Bug:* But no regions are assigning back to the Regionservers. *Master log shows as follows:* {noformat} 2015-03-26 15:05:36,201 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.RegionStates: Transition {8f62e819b356736053e06240f7f7c6fd state=OFFLINE, ts=1427362536106, server=VM2,16040,1427362242602} to {8f62e819b356736053e06240f7f7c6fd state=PENDING_OPEN, ts=1427362536201, server=VM1,16040,1427362531818} 2015-03-26 15:05:36,202 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.RegionStateStore: Updating row t1,,1427362431330.8f62e819b356736053e06240f7f7c6fd. with state=PENDING_OPENsn=VM1,16040,1427362531818 2015-03-26 15:05:36,244 DEBUG [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.AssignmentManager: Force region state offline {8f62e819b356736053e06240f7f7c6fd state=PENDING_OPEN, ts=1427362536201, server=VM1,16040,1427362531818} 2015-03-26 15:05:36,244 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.RegionStates: Transition {8f62e819b356736053e06240f7f7c6fd state=PENDING_OPEN, ts=1427362536201, server=VM1,16040,1427362531818} to {8f62e819b356736053e06240f7f7c6fd state=PENDING_CLOSE, ts=1427362536244, server=VM1,16040,1427362531818} 2015-03-26 15:05:36,244 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.RegionStateStore: Updating row t1,,1427362431330.8f62e819b356736053e06240f7f7c6fd. with state=PENDING_CLOSE 2015-03-26 15:05:36,248 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.AssignmentManager: Server VM1,16040,1427362531818 returned java.nio.channels.ClosedChannelException for t1,,1427362431330.8f62e819b356736053e06240f7f7c6fd., try=1 of 10 2015-03-26 15:05:36,248 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.AssignmentManager: Server VM1,16040,1427362531818 returned java.nio.channels.ClosedChannelException for t1,,1427362431330.8f62e819b356736053e06240f7f7c6fd., try=2 of 10 2015-03-26 15:05:36,249 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.AssignmentManager: Server VM1,16040,1427362531818 returned java.nio.channels.ClosedChannelException for t1,,1427362431330.8f62e819b356736053e06240f7f7c6fd., try=3 of 10 2015-03-26 15:05:36,249 INFO [VM2,16020,1427362216887-GeneralBulkAssigner-0] master.AssignmentManager: Server VM1,16040,1427362531818 returned java.nio.channels.ClosedChannelException for
[jira] [Issue Comment Deleted] (HBASE-12972) Region, a supportable public/evolving subset of HRegion
[ https://issues.apache.org/jira/browse/HBASE-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12972: --- Comment: was deleted (was: I let this sit a bit longer but will commit tonight.) Region, a supportable public/evolving subset of HRegion --- Key: HBASE-12972 URL: https://issues.apache.org/jira/browse/HBASE-12972 Project: HBase Issue Type: New Feature Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 2.0.0, 1.1.0 Attachments: HBASE-12972-0.98.patch, HBASE-12972.patch, HBASE-12972.patch, HBASE-12972.patch, HBASE-12972.patch On HBASE-12566, [~lhofhansl] proposed: {quote} Maybe we can have a {{Region}} interface that is to {{HRegion}} is what {{Store}} is to {{HStore}}. Store marked with {{@InterfaceAudience.Private}} but used in some coprocessor hooks. {quote} By example, now coprocessors have to reach into HRegion in order to participate in row and region locking protocols, this is one area where the functionality is legitimate for coprocessors but not for users, so an in-between interface make sense. In addition we should promote {{Store}}'s interface audience to LimitedPrivate(COPROC). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385529#comment-14385529 ] Lars Hofhansl commented on HBASE-13262: --- So with this in place. Can we redo the server side size scanner size limit? I assume this can still go wrong. Maybe I'll make an 0.98 patch that drives the size from the client. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385532#comment-14385532 ] Josh Elser commented on HBASE-13262: bq. Can we redo the server side size scanner size limit? I assume this can still go wrong. You mean have the server adhere to the limit set in the {{Scan}}? Best as I can tell, the server does look at the size set on the scan. Perhaps I misunderstood your question though. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385533#comment-14385533 ] Josh Elser commented on HBASE-13262: Not at problem, glad we got this in. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-13357: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch, Ashish. If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385576#comment-14385576 ] stack commented on HBASE-10728: --- [~jmspaggi] Sorry boss for not being on top of this one better. Thanks [~larsgeorge] for driving it home. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-9817) Add throughput quota and enforce hard limits
[ https://issues.apache.org/jira/browse/HBASE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385468#comment-14385468 ] Ashish Singhi commented on HBASE-9817: -- Yes, the requirement here seems to be already implemented with HBASE-11598. Add throughput quota and enforce hard limits Key: HBASE-9817 URL: https://issues.apache.org/jira/browse/HBASE-9817 Project: HBase Issue Type: New Feature Components: Coprocessors Reporter: He Liangliang Assignee: He Liangliang Attachments: HBASE-9817.patch There is planning to add region count and table count quota mentioned in HBASE-8410. However, it's also quite useful to control the requesting throughput inside the region server. For example, we don't want a data dumping task affecting the online services and it's better to enforce the throughput quota inside HBase. Another common scenario is multi-tenancy, i.e. a cluster is shared by multiple applications. The following rules will be supported: 1. per user quota limits the total read/write throughput initiated by a single user on any table. 2. per (user, table) quota limits the total read/write throughput initiated by a single user on a specified table. The implementation will use coprocessor to intercept and check each request on each region. And each region server allocate a portion of quota from the total specified quota (for that user or user + table) based on the portion of active regions (the whole cluster or the specified table) assigned on that region server. The request will be rejected or delayed if the limit is reached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13357) If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385522#comment-14385522 ] Ted Yu commented on HBASE-13357: +1 If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException --- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13357) If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-13357: --- Hadoop Flags: Reviewed If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException --- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13317) Region server reportForDuty stuck looping if there is a master change
[ https://issues.apache.org/jira/browse/HBASE-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385544#comment-14385544 ] Hadoop QA commented on HBASE-13317: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708005/HBASE-13317-0.98-v4.patch against 0.98 branch at commit 0967c6af29ba0546a167583535659a0c13de45b3. ATTACHMENT ID: 12708005 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 25 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13478//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13478//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13478//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13478//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13478//console This message is automatically generated. Region server reportForDuty stuck looping if there is a master change - Key: HBASE-13317 URL: https://issues.apache.org/jira/browse/HBASE-13317 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 1.0.0, 2.0.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13317-0.98-v2.patch, HBASE-13317-0.98-v3.patch, HBASE-13317-0.98-v4.patch, HBASE-13317-0.98.patch During cluster startup, region server reportForDuty gets stuck looping if there is a master change. {noformat} 2015-03-22 11:15:16,186 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf274,6,1427045883965 with port=60020, startcode=1427048115174 2015-03-22 11:15:16,272 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:16,274 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:19,274 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:19,275 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385552#comment-14385552 ] Hadoop QA commented on HBASE-13262: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708007/HBASE-13262-0.98-v7.patch against 0.98 branch at commit 0967c6af29ba0546a167583535659a0c13de45b3. ATTACHMENT ID: 12708007 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 24 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13479//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13479//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13479//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13479//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13479//console This message is automatically generated. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385586#comment-14385586 ] Jean-Marc Spaggiari commented on HBASE-10728: - Don't worry [~saint@gmail.com], as [~apurtell] said, people are busy. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-13357: --- Summary: If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException (was: If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385525#comment-14385525 ] Hadoop QA commented on HBASE-13357: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708001/HBASE-13357.patch against master branch at commit 0967c6af29ba0546a167583535659a0c13de45b3. ATTACHMENT ID: 12708001 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13476//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13476//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13476//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13476//console This message is automatically generated. If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13317) Region server reportForDuty stuck looping if there is a master change
[ https://issues.apache.org/jira/browse/HBASE-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry He updated HBASE-13317: - Attachment: HBASE-13317-0.98-v4.patch Attached 0.98-v4 that addressed Ted's comment about the InterruptedException. Will post a master version shortly. Region server reportForDuty stuck looping if there is a master change - Key: HBASE-13317 URL: https://issues.apache.org/jira/browse/HBASE-13317 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 1.0.0, 2.0.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13317-0.98-v2.patch, HBASE-13317-0.98-v3.patch, HBASE-13317-0.98-v4.patch, HBASE-13317-0.98.patch During cluster startup, region server reportForDuty gets stuck looping if there is a master change. {noformat} 2015-03-22 11:15:16,186 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf274,6,1427045883965 with port=60020, startcode=1427048115174 2015-03-22 11:15:16,272 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:16,274 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:19,274 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:19,275 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:19,276 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:22,276 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:22,296 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:22,296 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:25,296 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:25,299 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:25,299 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:28,299 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:28,302 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:28,302 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. {noformat} What happended is the region server first got master=bigaperf274,6,1427045883965. Before it was able to report successfully, the maser changed to bigaperf273,6,1427048108439. We were supposed to open a new connection to the new master. But we never did, looping and trying to old address forever. -- This message was sent by Atlassian JIRA
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385535#comment-14385535 ] Hadoop QA commented on HBASE-13262: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708004/HBASE-13262-branch-1.0-v7.patch against branch-1.0 branch at commit 0967c6af29ba0546a167583535659a0c13de45b3. ATTACHMENT ID: 12708004 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 3759 checkstyle errors (more than the master's current 3758 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . {color:red}-1 core zombie tests{color}. There are 2 zombie test(s): at org.apache.camel.component.quartz2.SpringQuartzConsumerTwoAppsClusteredRecoveryTest.testQuartzPersistentStoreClusteredApp(SpringQuartzConsumerTwoAppsClusteredRecoveryTest.java:64) at org.apache.camel.component.jpa.JpaWithNamedQueryTest.testProducerInsertsIntoDatabaseThenConsumerFiresMessageExchange(JpaWithNamedQueryTest.java:112) at org.apache.camel.component.jpa.JpaWithNamedQueryTest.testProducerInsertsIntoDatabaseThenConsumerFiresMessageExchange(JpaWithNamedQueryTest.java:112) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13477//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13477//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13477//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13477//console This message is automatically generated. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385564#comment-14385564 ] Hudson commented on HBASE-13357: SUCCESS: Integrated in HBase-TRUNK #6318 (See [https://builds.apache.org/job/HBase-TRUNK/6318/]) HBASE-13357 If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException (Ashish Singhi) (tedyu: rev a6ff17b958985f806233c345f0c1a2e6f85ec323) * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13317) Region server reportForDuty stuck looping if there is a master change
[ https://issues.apache.org/jira/browse/HBASE-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry He updated HBASE-13317: - Attachment: HBASE-13317-master-v5.patch HBASE-13317-0.98-v5.patch Attached 0.98-v5, which only has nit changes from 0.98-v4. Attached master-v5. master branch has region sever on master. defaultMinToStart = 2. So Assert number of rs is changed in the test case. Region server reportForDuty stuck looping if there is a master change - Key: HBASE-13317 URL: https://issues.apache.org/jira/browse/HBASE-13317 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 1.0.0, 2.0.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13317-0.98-v2.patch, HBASE-13317-0.98-v3.patch, HBASE-13317-0.98-v4.patch, HBASE-13317-0.98-v5.patch, HBASE-13317-0.98.patch, HBASE-13317-master-v5.patch During cluster startup, region server reportForDuty gets stuck looping if there is a master change. {noformat} 2015-03-22 11:15:16,186 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf274,6,1427045883965 with port=60020, startcode=1427048115174 2015-03-22 11:15:16,272 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:16,274 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:19,274 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:19,275 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:19,276 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:22,276 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:22,296 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:22,296 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:25,296 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:25,299 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:25,299 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:28,299 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:28,302 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:28,302 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. {noformat} What happended is the region server first got master=bigaperf274,6,1427045883965. Before it was able to report successfully, the maser changed to
[jira] [Updated] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-13262: --- Attachment: HBASE-13262-0.98-v7.patch 0.98 patch. Had to move some stuff from ScannerCallable up to RegionServerCallable because of SmallClientScanner using RegionServerCallable directly. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385618#comment-14385618 ] Hudson commented on HBASE-13262: FAILURE: Integrated in HBase-1.0 #836 (See [https://builds.apache.org/job/HBase-1.0/836/]) HBASE-13262 Observe ScanResponse.moreResults in ClientScanner. (apurtell: rev 20189c258cbcf109de10f76f06c059681e438615) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSizeFailures.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12993) Use HBase 1.0 interfaces in hbase-thrift
[ https://issues.apache.org/jira/browse/HBASE-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12993: --- Attachment: HBASE-12993-1.patch rebased and changed the an Table comment. Use HBase 1.0 interfaces in hbase-thrift Key: HBASE-12993 URL: https://issues.apache.org/jira/browse/HBASE-12993 Project: HBase Issue Type: Bug Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 1.0.1 Attachments: HBASE-12993-1.patch, HBASE-12993.patch hbase-thrift uses HTable and HBaesAdmin. It also uses HTablePool, which is an outdated concept. As per [~ndimiduk] on the user group: {quote} I believe HTablePool is completely eclipsed by the modern Connection implementation. We'll need to keep the map of UserName = Connection (or maybe the ConnectionCache handles this?) Probably a single Connection (per user) with a large thread pool will do the trick. {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385625#comment-14385625 ] Hudson commented on HBASE-13262: FAILURE: Integrated in HBase-1.1 #336 (See [https://builds.apache.org/job/HBase-1.1/336/]) HBASE-13262 Observe ScanResponse.moreResults in ClientScanner. (apurtell: rev b0116398ffa6aec57d42739df40e22dc4edaaa0f) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSizeFailures.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-13262: --- Attachment: HBASE-13262-branch-1.0-v7.patch ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-9817) Add throughput quota and enforce hard limits
[ https://issues.apache.org/jira/browse/HBASE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh resolved HBASE-9817. --- Resolution: Duplicate Add throughput quota and enforce hard limits Key: HBASE-9817 URL: https://issues.apache.org/jira/browse/HBASE-9817 Project: HBase Issue Type: New Feature Components: Coprocessors Reporter: He Liangliang Assignee: He Liangliang Attachments: HBASE-9817.patch There is planning to add region count and table count quota mentioned in HBASE-8410. However, it's also quite useful to control the requesting throughput inside the region server. For example, we don't want a data dumping task affecting the online services and it's better to enforce the throughput quota inside HBase. Another common scenario is multi-tenancy, i.e. a cluster is shared by multiple applications. The following rules will be supported: 1. per user quota limits the total read/write throughput initiated by a single user on any table. 2. per (user, table) quota limits the total read/write throughput initiated by a single user on a specified table. The implementation will use coprocessor to intercept and check each request on each region. And each region server allocate a portion of quota from the total specified quota (for that user or user + table) based on the portion of active regions (the whole cluster or the specified table) assigned on that region server. The request will be rejected or delayed if the limit is reached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-9817) Add throughput quota and enforce hard limits
[ https://issues.apache.org/jira/browse/HBASE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385539#comment-14385539 ] Jonathan Hsieh commented on HBASE-9817: --- Alright, I'm going to close as dupe since this has been floating long enough. Add throughput quota and enforce hard limits Key: HBASE-9817 URL: https://issues.apache.org/jira/browse/HBASE-9817 Project: HBase Issue Type: New Feature Components: Coprocessors Reporter: He Liangliang Assignee: He Liangliang Attachments: HBASE-9817.patch There is planning to add region count and table count quota mentioned in HBASE-8410. However, it's also quite useful to control the requesting throughput inside the region server. For example, we don't want a data dumping task affecting the online services and it's better to enforce the throughput quota inside HBase. Another common scenario is multi-tenancy, i.e. a cluster is shared by multiple applications. The following rules will be supported: 1. per user quota limits the total read/write throughput initiated by a single user on any table. 2. per (user, table) quota limits the total read/write throughput initiated by a single user on a specified table. The implementation will use coprocessor to intercept and check each request on each region. And each region server allocate a portion of quota from the total specified quota (for that user or user + table) based on the portion of active regions (the whole cluster or the specified table) assigned on that region server. The request will be rejected or delayed if the limit is reached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385601#comment-14385601 ] Lars Hofhansl commented on HBASE-13262: --- Sorry wasn't clear. The max result size setting is available on the client only for 1.1 and up, right? I was wondering whether we can just turn on that setting on the server again for 0.98 and 1.0. But it would still be an issue with an old client that does not have this fix. So my next thought: Add the max size to 0.98 and 1.0 and remove the server side limit there. Then default the client size limit to 2mb. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13317) Region server reportForDuty stuck looping if there is a master change
[ https://issues.apache.org/jira/browse/HBASE-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385619#comment-14385619 ] Hadoop QA commented on HBASE-13317: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708018/HBASE-13317-master-v5.patch against master branch at commit a6ff17b958985f806233c345f0c1a2e6f85ec323. ATTACHMENT ID: 12708018 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13480//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13480//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13480//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13480//console This message is automatically generated. Region server reportForDuty stuck looping if there is a master change - Key: HBASE-13317 URL: https://issues.apache.org/jira/browse/HBASE-13317 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 1.0.0, 2.0.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13317-0.98-v2.patch, HBASE-13317-0.98-v3.patch, HBASE-13317-0.98-v4.patch, HBASE-13317-0.98-v5.patch, HBASE-13317-0.98.patch, HBASE-13317-master-v5.patch During cluster startup, region server reportForDuty gets stuck looping if there is a master change. {noformat} 2015-03-22 11:15:16,186 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf274,6,1427045883965 with port=60020, startcode=1427048115174 2015-03-22 11:15:16,272 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:16,274 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:19,274 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:19,275 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at
[jira] [Commented] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385637#comment-14385637 ] Ashish Singhi commented on HBASE-13357: --- Thanks Ted for the quick review. If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385636#comment-14385636 ] Ashish Singhi commented on HBASE-13357: --- Thanks Srikanth for taking a look. bq. It is a good practice to clean up the resources we've created towards the end of the test. Though this is not critical, it is more related to code hygiene. What say ? If you look at cleanup api we are already doing it. {code} for (HTableDescriptor table : ADMIN.listTables()) { ADMIN.disableTable(table.getTableName()); deleteTable(table.getTableName()); } for (NamespaceDescriptor ns : ADMIN.listNamespaceDescriptors()) { if (ns.getName().startsWith(prefix)) { ADMIN.deleteNamespace(ns.getName()); } } {code} If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13317) Region server reportForDuty stuck looping if there is a master change
[ https://issues.apache.org/jira/browse/HBASE-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385638#comment-14385638 ] Jerry He commented on HBASE-13317: -- Hi, [~enis] {code} if (rssStub == rss) { rssStub = null; } {code} Do you want me to clean up this in this JIRA? Region server reportForDuty stuck looping if there is a master change - Key: HBASE-13317 URL: https://issues.apache.org/jira/browse/HBASE-13317 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 1.0.0, 2.0.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: HBASE-13317-0.98-v2.patch, HBASE-13317-0.98-v3.patch, HBASE-13317-0.98-v4.patch, HBASE-13317-0.98-v5.patch, HBASE-13317-0.98.patch, HBASE-13317-master-v5.patch During cluster startup, region server reportForDuty gets stuck looping if there is a master change. {noformat} 2015-03-22 11:15:16,186 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf274,6,1427045883965 with port=60020, startcode=1427048115174 2015-03-22 11:15:16,272 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:16,274 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:19,274 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:19,275 WARN [regionserver60020] regionserver.HRegionServer: error telling master we are up com.google.protobuf.ServiceException: java.net.ConnectException: Connection refused at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcClient.java:1678) at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplementation.callBlockingMethod(RpcClient.java:1719) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:8277) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2137) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:896) at java.lang.Thread.run(Thread.java:745) 2015-03-22 11:15:19,276 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:22,276 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:22,296 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:22,296 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:25,296 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:25,299 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:25,299 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. 2015-03-22 11:15:28,299 INFO [regionserver60020] regionserver.HRegionServer: reportForDuty to master=bigaperf273,6,1427048108439 with port=60020, startcode=1427048115174 2015-03-22 11:15:28,302 DEBUG [regionserver60020] regionserver.HRegionServer: Master is not running yet 2015-03-22 11:15:28,302 WARN [regionserver60020] regionserver.HRegionServer: reportForDuty failed; sleeping and then retrying. {noformat} What happended is the region server first got master=bigaperf274,6,1427045883965. Before it was able to report successfully, the maser changed to bigaperf273,6,1427048108439. We were supposed to open a new connection to the new master. But we never did, looping and
[jira] [Commented] (HBASE-13357) If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385624#comment-14385624 ] Srikanth Srungarapu commented on HBASE-13357: - Patch looks ok to me. It is a good practice to clean up the resources we've created towards the end of the test. Though this is not critical, it is more related to code hygiene. What say ? {code} + @Test(expected = QuotaExceededException.class, timeout = 3) + public void testExceedTableQuotaInNamespace() throws Exception { +String nsp = prefix + _testExceedTableQuotaInNamespace; +NamespaceDescriptor nspDesc = + NamespaceDescriptor.create(nsp).addConfiguration(TableNamespaceManager.KEY_MAX_TABLES, 1) +.build(); +ADMIN.createNamespace(nspDesc); +assertNotNull(Namespace descriptor found null., ADMIN.getNamespaceDescriptor(nsp)); +assertEquals(ADMIN.listNamespaceDescriptors().length, 3); +HTableDescriptor tableDescOne = +new HTableDescriptor(TableName.valueOf(nsp + TableName.NAMESPACE_DELIM + table1)); +HTableDescriptor tableDescTwo = +new HTableDescriptor(TableName.valueOf(nsp + TableName.NAMESPACE_DELIM + table2)); +ADMIN.createTable(tableDescOne); +ADMIN.createTable(tableDescTwo, Bytes.toBytes(AAA), Bytes.toBytes(ZZZ), 4); + } {code} If maxTables/maxRegions exceeds quota in a namespace, throw QuotaExceededException -- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385631#comment-14385631 ] Hudson commented on HBASE-13262: SUCCESS: Integrated in HBase-TRUNK #6319 (See [https://builds.apache.org/job/HBase-TRUNK/6319/]) HBASE-13262 Observe ScanResponse.moreResults in ClientScanner. (apurtell: rev ced0e324a190e75d8a93b8b09676781853819361) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSizeFailures.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-13262: --- Resolution: Fixed Fix Version/s: (was: 0.98.13) 0.98.12 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to 0.98 and up. The new client tests pass on all branches, other client tests all pass (e.g. TestFromClientSide*) Changes in branch-1.0 and 0.98 are to private interfaces only and, even so, JavaACC says the private interface changes are binary compatible with previously compiled code. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385612#comment-14385612 ] Josh Elser commented on HBASE-13262: Thanks, Andrew! Your legwork is much appreciated. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385512#comment-14385512 ] Andrew Purtell commented on HBASE-13262: Great, thanks. Working on commits now. (Checking out locally first.) ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385521#comment-14385521 ] Lars George commented on HBASE-10728: - Will do [~apurtell]. Thanks for checking. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12413) Mismatch in the equals and hashcode methods of KeyValue
[ https://issues.apache.org/jira/browse/HBASE-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12413: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master. Thanks for the patch, Jingcheng and Gariel. Mismatch in the equals and hashcode methods of KeyValue --- Key: HBASE-12413 URL: https://issues.apache.org/jira/browse/HBASE-12413 Project: HBase Issue Type: Bug Reporter: Jingcheng Du Assignee: Jingcheng Du Priority: Minor Fix For: 2.0.0 Attachments: HBASE-12413-V2.diff, HBASE-12413.diff, HBASE-12413.v3.patch, HBASE-12413.v4.patch, HBASE-12413.v4.patch In the equals method of KeyValue only row key is compared, and in the hashcode method all bacing bytes are calculated. This breaks the Java rule. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385257#comment-14385257 ] Hadoop QA commented on HBASE-10728: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707984/0001-HBASE-10728-get_counter-value-is-never-used.patch against master branch at commit 5038fc76c950029c78681dff816d7465f6acbb91. ATTACHMENT ID: 12707984 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13474//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13474//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13474//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13474//console This message is automatically generated. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385252#comment-14385252 ] Jean-Marc Spaggiari commented on HBASE-10728: - Yep, a year old. I wrote a message on the dev list on July 30th 2014 to have someone looking at it, and never got any reply. It's not the only patch I have done which has been totally ignored with no-one to look at it. So at some point I gave up because it was more a waste of time than an investment into HBase. Regarding a wider issue, I don't remember :( I remember there was related issues with other commands, or other commands calling this one, or something like that, but I will have to dive into the code again to figure what it was. I'm +1 with the last version of the path you pushed. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385271#comment-14385271 ] Hadoop QA commented on HBASE-10728: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707985/0002-HBASE-10728-get_counter-value-is-never-used.patch against master branch at commit 5038fc76c950029c78681dff816d7465f6acbb91. ATTACHMENT ID: 12707985 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13475//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13475//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13475//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13475//console This message is automatically generated. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13355) QA bot reports checking javac twice
[ https://issues.apache.org/jira/browse/HBASE-13355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-13355: -- Attachment: HBASE-13355-v1.patch What I'm committing. QA bot reports checking javac twice --- Key: HBASE-13355 URL: https://issues.apache.org/jira/browse/HBASE-13355 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 2.0.0 Attachments: HBASE-13355-v1.patch, HBASE-13355.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385377#comment-14385377 ] Andrew Purtell commented on HBASE-13262: There's no rule. Personally, I will try to backport if no branch patches are provided if its clear how to resolve the conflicts and I'm confident of what I am doing. In this case, git is giving me large conflict sections. In order to port, I'd have to look at the master patch and replay it onto branch by hand. Better let the person(s) deeply engaged in the original work do that. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan
[ https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385370#comment-14385370 ] Josh Elser commented on HBASE-13262: The last time I had a patch targeted for multiple branches, I was told the committer would take care of the backporting. Your comment tells me otherwise. I'll get you some patches for branch-1.0 and 0.98. ResultScanner doesn't return all rows in Scan - Key: HBASE-13262 URL: https://issues.apache.org/jira/browse/HBASE-13262 Project: HBase Issue Type: Bug Components: Client Affects Versions: 2.0.0, 1.1.0 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT Reporter: Josh Elser Assignee: Josh Elser Priority: Blocker Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt Tried to write a simple Java client again 1.1.0-SNAPSHOT. * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), for a total of 10M cells written * Read back the data from the table, ensure I saw 10M cells Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of the actual rows. Running against 1.0.0, returns all 10M records as expected. [Code I was running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java] for the curious. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12413) Mismatch in the equals and hashcode methods of KeyValue
[ https://issues.apache.org/jira/browse/HBASE-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385386#comment-14385386 ] Hudson commented on HBASE-12413: SUCCESS: Integrated in HBase-TRUNK #6316 (See [https://builds.apache.org/job/HBase-TRUNK/6316/]) HBASE-12413 Mismatch in the equals and hashcode methods of KeyValue (Jingcheng Du and Gariel Reid) (tedyu: rev bd837d47f7230798f2bb7ac18e711e8f265b167f) * hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java * hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java Mismatch in the equals and hashcode methods of KeyValue --- Key: HBASE-12413 URL: https://issues.apache.org/jira/browse/HBASE-12413 Project: HBase Issue Type: Bug Reporter: Jingcheng Du Assignee: Jingcheng Du Priority: Minor Fix For: 2.0.0 Attachments: HBASE-12413-V2.diff, HBASE-12413.diff, HBASE-12413.v3.patch, HBASE-12413.v4.patch, HBASE-12413.v4.patch In the equals method of KeyValue only row key is compared, and in the hashcode method all bacing bytes are calculated. This breaks the Java rule. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13355) QA bot reports checking javac twice
[ https://issues.apache.org/jira/browse/HBASE-13355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-13355: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) QA bot reports checking javac twice --- Key: HBASE-13355 URL: https://issues.apache.org/jira/browse/HBASE-13355 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Priority: Minor Fix For: 2.0.0 Attachments: HBASE-13355-v1.patch, HBASE-13355.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385442#comment-14385442 ] Andrew Purtell commented on HBASE-10728: bq. Yep, a year old. I wrote a message on the dev list on July 30th 2014 to have someone looking at it, and never got any reply. It's not the only patch I have done which has been totally ignored with no-one to look at it. So at some point I gave up because it was more a waste of time than an investment into HBase. [~jmspaggi] I count 27 issues opened by you, assigned to you and committed, or mentioning you. By objective metrics (commits) your investment into HBase was not a waste of time. We're going to miss some things you'd need to prod us about if it's important to you. The unfortunate reality is this is a volunteer open source project and the committers on it have limited bandwidth for attention (at least until we have strong AI (smile)), and other time commitments. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385445#comment-14385445 ] Andrew Purtell commented on HBASE-10728: +1 I assume you are going to commit this [~larsgeorge], but if not then please ping me. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0, 1.0.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-8410) Basic quota support for namespaces
[ https://issues.apache.org/jira/browse/HBASE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385447#comment-14385447 ] Ashish Singhi commented on HBASE-8410: -- In the release note example we need to correct the command used, there is no shell command {{namespace_create}} instead it should be {{create_namespace}}. Also if possible can we also mention in the example how a user can unset the maxtable/maxregions in the namespace {code}alter_namespace 'ns3', {METHOD = 'unset', 'hbase.namespace.quota.maxtables'} {code} Basic quota support for namespaces -- Key: HBASE-8410 URL: https://issues.apache.org/jira/browse/HBASE-8410 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Vandana Ayyalasomayajula Fix For: 2.0.0 Attachments: 8410-master.9.patch, HBASE-8410-master.1.patch, HBASE-8410-master.4.patch, HBASE-8410-master.5.patch, HBASE-8410-master.6.patch, HBASE-8410-master.7.patch, HBASE-8410-master.9.patch, HBASE-8410-master.patch, HBASE-8410.docx, HBASE-8410_trunk_14.patch This task involves creating an observer which provides basic quota support to namespaces in terms of (1) number of tables and (2) number of regions. The quota support can be enabled by setting: property namehbase.coprocessor.region.classes/name valueorg.apache.hadoop.hbase.namespace.NamespaceController/value /property property namehbase.coprocessor.master.classes/name valueorg.apache.hadoop.hbase.namespace.NamespaceController/value /property in the hbase-site.xml. To add quotas to namespace, while creating namespace properties need to be added. Examples: 1. namespace_create 'ns1', {'hbase.namespace.quota.maxregion'='10'} 2. 1. namespace_create 'ns2', {'hbase.namespace.quota.maxtables'='2'}, {'hbase.namespace.quota.maxregion'='5'} The quotas can be modified/added to namespace at any point of time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-13357) If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException
Ashish Singhi created HBASE-13357: - Summary: If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Priority: Minor Fix For: 2.0.0 If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-13357) If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi reassigned HBASE-13357: - Assignee: Ashish Singhi If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException --- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13357) If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi updated HBASE-13357: -- Attachment: HBASE-13357.patch If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException --- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13357) If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException
[ https://issues.apache.org/jira/browse/HBASE-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi updated HBASE-13357: -- Status: Patch Available (was: Open) Simple patch. Please review If maxTables/maxRegions exceeds in a namespace throw QuotaExceededException --- Key: HBASE-13357 URL: https://issues.apache.org/jira/browse/HBASE-13357 Project: HBase Issue Type: Bug Affects Versions: 2.0.0 Reporter: Ashish Singhi Assignee: Ashish Singhi Priority: Minor Labels: quota Fix For: 2.0.0 Attachments: HBASE-13357.patch If maximum number of tables or regions count exceeds in a namespace we are throwing DoNotRetryIOException instead we should throw QuotaExceededException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-13356) HBase should provide an InputFormat supporting multiple scans in mapreduce jobs over snapshots
Andrew Mains created HBASE-13356: Summary: HBase should provide an InputFormat supporting multiple scans in mapreduce jobs over snapshots Key: HBASE-13356 URL: https://issues.apache.org/jira/browse/HBASE-13356 Project: HBase Issue Type: New Feature Components: mapreduce Reporter: Andrew Mains Priority: Minor Currently, HBase supports the pushing of multiple scans to mapreduce jobs over live tables (via MultiTableInputFormat) but only supports a single scan for mapreduce jobs over table snapshots. It would be handy to support multiple scans over snapshots as well, probably through another input format (MultiTableSnapshotInputFormat?). To mimic the functionality present in MultiTableInputFormat, the new input format would likely have to take in the names of all snapshots used in addition to the scans. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13252) Get rid of managed connections and connection caching
[ https://issues.apache.org/jira/browse/HBASE-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385169#comment-14385169 ] Hadoop QA commented on HBASE-13252: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707965/HBASE-13252-v5.patch against master branch at commit 0a500e5d305b0c75a6a357a5ff7a9210a615a007. ATTACHMENT ID: 12707965 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 38 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13471//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13471//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13471//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13471//console This message is automatically generated. Get rid of managed connections and connection caching - Key: HBASE-13252 URL: https://issues.apache.org/jira/browse/HBASE-13252 Project: HBase Issue Type: Sub-task Components: API Affects Versions: 2.0.0 Reporter: Mikhail Antonov Assignee: Mikhail Antonov Attachments: HBASE-13252-v0.patch, HBASE-13252-v1.patch, HBASE-13252-v1.patch, HBASE-13252-v2.patch, HBASE-13252-v2.patch, HBASE-13252-v3.patch, HBASE-13252-v4.patch, HBASE-13252-v5.patch (Need to): - Remove CONNECTION_INSTANCES from ConnectionManager - Remove HConnectionKey - Remove 'managed' property from ClusterConnection, HCI and places where it's used now - AFAIS this property isn't visible to client (ClusterConnection is private interface), so technically this would not even be backward-incompatible change, and no release note needed? - In fact, ConnectionManager can be removed, too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-13353) [Shell] get_counter is asking for too many parameters
[ https://issues.apache.org/jira/browse/HBASE-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars George resolved HBASE-13353. - Resolution: Duplicate Dupe of HBASE-10728. [Shell] get_counter is asking for too many parameters - Key: HBASE-13353 URL: https://issues.apache.org/jira/browse/HBASE-13353 Project: HBase Issue Type: Bug Components: shell Affects Versions: 1.0.0 Reporter: Lars George Labels: noob Trying: {code} hbase(main):036:0 get_counter 'counters', '20150101', 'daily:hits' {code} and getting {code} ERROR: wrong number of arguments (3 for 4) ... hbase get_counter 'ns1:t1', 'r1', 'c1' hbase get_counter 't1', 'r1', 'c1' {code} It is asking for another, undocumented parameter. The issue is that there is a can be nil markup missing in get_counter.rb: {code} 39 def command(table, row, column, value) 40get_counter(table(table), row, column, value) 41 end {code} The first line should be: {code} 39 def command(table, row, column, value = nil) {code} Easy fix, but makes me wonder why this is not caught anywhere or reported. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385205#comment-14385205 ] Lars George commented on HBASE-10728: - [~jmspaggi] you mention above you would create other JIRAs for 0.98 etc. Have you done so? Can we get this not all into this one and do a path and commit for all active branches? If you created more, please link to this issue so that we can track. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Attachments: HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars George updated HBASE-10728: Fix Version/s: 0.98.13 1.1.0 1.0.1 2.0.0 Affects Version/s: 1.0.0 Status: Patch Available (was: Open) New patch, with fixes, for trunk. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 0.99.0, 0.98.1, 0.96.2 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars George updated HBASE-10728: Attachment: 0001-HBASE-10728-get_counter-value-is-never-used.patch Updated patch with {{get_counter}} fix, typo clean up, and {{incr}} readd of printing results. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13303) Fix size calculation of results on the region server
[ https://issues.apache.org/jira/browse/HBASE-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385173#comment-14385173 ] Hudson commented on HBASE-13303: SUCCESS: Integrated in HBase-1.1 #335 (See [https://builds.apache.org/job/HBase-1.1/335/]) Amend HBASE-13303 Fix size calculation of results on the region server (apurtell: rev 7da7a77ff970b23c52106ef95520543dccf9d0c5) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java Fix size calculation of results on the region server Key: HBASE-13303 URL: https://issues.apache.org/jira/browse/HBASE-13303 Project: HBase Issue Type: Sub-task Components: Client Reporter: Lars Hofhansl Assignee: Andrew Purtell Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303-addendum-v1.patch, HBASE-13303.patch, HBASE-13303.patch, HBASE-13303.patch, TestResultSizeEstimation.java One of the problems in the parent is due to different size calculation between client and server when HFilev3 is used. Since tags are _never_ shipped to the client in a scan, we can have special size function (or a flag on the current one) that does not include the tags and the tags meta information (the length is what causes the issue), so that client and server will always calculate the same size. I'll make a patch within the hour, unless somebody beats me to it. [~apurtell], FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12413) Mismatch in the equals and hashcode methods of KeyValue
[ https://issues.apache.org/jira/browse/HBASE-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385175#comment-14385175 ] Hadoop QA commented on HBASE-12413: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707968/HBASE-12413.v4.patch against master branch at commit 0a500e5d305b0c75a6a357a5ff7a9210a615a007. ATTACHMENT ID: 12707968 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13472//testReport/ Release Findbugs (version 2.0.3)warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13472//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13472//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13472//console This message is automatically generated. Mismatch in the equals and hashcode methods of KeyValue --- Key: HBASE-12413 URL: https://issues.apache.org/jira/browse/HBASE-12413 Project: HBase Issue Type: Bug Reporter: Jingcheng Du Assignee: Jingcheng Du Priority: Minor Fix For: 2.0.0 Attachments: HBASE-12413-V2.diff, HBASE-12413.diff, HBASE-12413.v3.patch, HBASE-12413.v4.patch, HBASE-12413.v4.patch In the equals method of KeyValue only row key is compared, and in the hashcode method all bacing bytes are calculated. This breaks the Java rule. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13353) [Shell] get_counter is asking for too many parameters
[ https://issues.apache.org/jira/browse/HBASE-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385194#comment-14385194 ] Lars George commented on HBASE-13353: - Yes JM, I did find your JIRA just then. I cannot believe this is broken for a year now. Man! Let's fix this over in HBASE-10728, and I will commit it. OK? [Shell] get_counter is asking for too many parameters - Key: HBASE-13353 URL: https://issues.apache.org/jira/browse/HBASE-13353 Project: HBase Issue Type: Bug Components: shell Affects Versions: 1.0.0 Reporter: Lars George Labels: noob Trying: {code} hbase(main):036:0 get_counter 'counters', '20150101', 'daily:hits' {code} and getting {code} ERROR: wrong number of arguments (3 for 4) ... hbase get_counter 'ns1:t1', 'r1', 'c1' hbase get_counter 't1', 'r1', 'c1' {code} It is asking for another, undocumented parameter. The issue is that there is a can be nil markup missing in get_counter.rb: {code} 39 def command(table, row, column, value) 40get_counter(table(table), row, column, value) 41 end {code} The first line should be: {code} 39 def command(table, row, column, value = nil) {code} Easy fix, but makes me wonder why this is not caught anywhere or reported. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13303) Fix size calculation of results on the region server
[ https://issues.apache.org/jira/browse/HBASE-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385207#comment-14385207 ] Hudson commented on HBASE-13303: SUCCESS: Integrated in HBase-TRUNK #6315 (See [https://builds.apache.org/job/HBase-TRUNK/6315/]) Amend HBASE-13303 Fix size calculation of results on the region server (apurtell: rev 5038fc76c950029c78681dff816d7465f6acbb91) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java Fix size calculation of results on the region server Key: HBASE-13303 URL: https://issues.apache.org/jira/browse/HBASE-13303 Project: HBase Issue Type: Sub-task Components: Client Reporter: Lars Hofhansl Assignee: Andrew Purtell Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Attachments: HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303-addendum-v1.patch, HBASE-13303.patch, HBASE-13303.patch, HBASE-13303.patch, TestResultSizeEstimation.java One of the problems in the parent is due to different size calculation between client and server when HFilev3 is used. Since tags are _never_ shipped to the client in a scan, we can have special size function (or a flag on the current one) that does not include the tags and the tags meta information (the length is what causes the issue), so that client and server will always calculate the same size. I'll make a patch within the hour, unless somebody beats me to it. [~apurtell], FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385196#comment-14385196 ] Lars George commented on HBASE-10728: - Let's restart this issue, it cannot be that this is broken for a year now. There are two issues here I see: * {{get_counter}} needing an unnecessary last {{value}} parameter. We can make it accept {{nil}} but if it is never used, why keep it? * {{incr}} does not return the current value anymore, though it receives the {{Result}} instance for every call. [~jmspaggi], you mentioned this being a wider issue. What else is wrong? get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Attachments: HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385204#comment-14385204 ] Lars George commented on HBASE-10728: - I added {code} result = @table.increment(incr) return nil if result.isEmpty # Fetch cell value cell = result.listCells[0] org.apache.hadoop.hbase.util.Bytes::toLong(cell.getValue) {code} to table.rb#_incr_internal and {code} def incr(table, row, column, value = nil, args={}) format_simple_command do if cnt = table._incr_internal(row, column, value, args) puts COUNTER VALUE = #{cnt} else puts No counter found at specified coordinates end end end {code} into incr.rb, and now I get the value printed again. If there are no objections I recommend adding this again. The other thing [~jmspaggi] pointed out is the standard use of a required {{value}} parameter for some commands. We should clean this up too, I call copypaste error. At least for {{get_counter}} it is never used as JM pointed out a year ago. :( get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Attachments: HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars George updated HBASE-10728: Status: Open (was: Patch Available) get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.99.0, 0.98.1, 0.96.2 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10728) get_counter value is never used.
[ https://issues.apache.org/jira/browse/HBASE-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars George updated HBASE-10728: Attachment: 0002-HBASE-10728-get_counter-value-is-never-used.patch New patch, missed the update to {{table.rb}}. Tested on console, works as expected: {noformat} HBase Shell; enter 'helpRETURN' for list of supported commands. Type exitRETURN to leave the HBase Shell Version 2.0.0-SNAPSHOT, r7a5e6b8c0a7449fb6c6c1ca37b70753822243b83, Sat Mar 28 10:52:36 CET 2015 hbase(main):001:0 get_counter 'counters', '20150101', 'daily:hits' COUNTER VALUE = 3 hbase(main):002:0 incr 'counters', '20150101', 'daily:hits' COUNTER VALUE = 4 0 row(s) in 0.0910 seconds hbase(main):003:0 get_counter 'counters', '20150102', 'daily:hits' No counter found at specified coordinates hbase(main):004:0 incr 'counters', '20150102', 'daily:hits' COUNTER VALUE = 1 0 row(s) in 0.0920 seconds hbase(main):005:0 get_counter 'counters', '20150102', 'daily:hits' COUNTER VALUE = 1 {noformat} Should we add some tests? The Shell tests seem very _basic_ right now. get_counter value is never used. Key: HBASE-10728 URL: https://issues.apache.org/jira/browse/HBASE-10728 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.98.1, 0.99.0 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Attachments: 0001-HBASE-10728-get_counter-value-is-never-used.patch, 0002-HBASE-10728-get_counter-value-is-never-used.patch, HBASE-10728-v0-0.96.patch, HBASE-10728-v0-0.98.patch, HBASE-10728-v0-trunk.patch, HBASE-10728-v1-0.96.patch, HBASE-10728-v1-0.98.patch, HBASE-10728-v1-trunk.patch, HBASE-10728-v2-trunk.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)