[jira] [Updated] (HBASE-16115) Missing security context in RegionObserver coprocessor when a compaction is triggered through the UI
[ https://issues.apache.org/jira/browse/HBASE-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-16115: -- Affects Version/s: 0.98.20 > Missing security context in RegionObserver coprocessor when a compaction is > triggered through the UI > > > Key: HBASE-16115 > URL: https://issues.apache.org/jira/browse/HBASE-16115 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.20 >Reporter: Lars Hofhansl > > We ran into an interesting phenomenon which can easily render a cluster > unusable. > We loaded some tests data into a test table and forced a manual compaction > through the UI. We have some compaction hooks implemented in a region > observer, which writes back to another HBase table when the compaction > finishes. We noticed that this coprocessor is not setup correctly, it seems > the security context is missing. > The interesting part is that this _only_ happens when the compaction is > triggere through the UI. Automatic compactions (major or minor) or when > triggered via the HBase shell (folling a kinit) work fine. Only the > UI-triggered compactions cause this issues and lead to essentially > neverending compactions, immovable regions, etc. > Not sure what exactly the issue is, but I wanted to make sure I capture this. > [~apurtell], [~ghelmling], FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16115) Missing security context in RegionObserver coprocessor when a compaction is triggered through the UI
Lars Hofhansl created HBASE-16115: - Summary: Missing security context in RegionObserver coprocessor when a compaction is triggered through the UI Key: HBASE-16115 URL: https://issues.apache.org/jira/browse/HBASE-16115 Project: HBase Issue Type: Bug Reporter: Lars Hofhansl We ran into an interesting phenomenon which can easily render a cluster unusable. We loaded some tests data into a test table and forced a manual compaction through the UI. We have some compaction hooks implemented in a region observer, which writes back to another HBase table when the compaction finishes. We noticed that this coprocessor is not setup correctly, it seems the security context is missing. The interesting part is that this _only_ happens when the compaction is triggere through the UI. Automatic compactions (major or minor) or when triggered via the HBase shell (folling a kinit) work fine. Only the UI-triggered compactions cause this issues and lead to essentially neverending compactions, immovable regions, etc. Not sure what exactly the issue is, but I wanted to make sure I capture this. [~apurtell], [~ghelmling], FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/disabled
[ https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349941#comment-15349941 ] Ted Yu commented on HBASE-14007: +1 if tests pass. > Writing to table through MR should fail upfront if table does not > exist/disabled > > > Key: HBASE-14007 > URL: https://issues.apache.org/jira/browse/HBASE-14007 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.1.1 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Minor > Labels: mapreduce > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-14007.master.001.patch, HBASE-14007.patch > > > TableOutputFormat.checkOutputSpecs() needs to be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16114) Get regionLocation of only required regions for MR jobs
[ https://issues.apache.org/jira/browse/HBASE-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HBASE-16114: - Attachment: HBASE-16114.master.001.patch Attaching patch. > Get regionLocation of only required regions for MR jobs > --- > > Key: HBASE-16114 > URL: https://issues.apache.org/jira/browse/HBASE-16114 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.2.1 >Reporter: Thiruvel Thirumoolan >Priority: Minor > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16114.master.001.patch, > HBASE-16114.master.001.patch > > > We should only get the location of regions required during the MR job. This > will help for jobs with large regions but the job itself scans only a small > portion of it. Similar changes can be seen in MultiInputFormatBase.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16114) Get regionLocation of only required regions for MR jobs
[ https://issues.apache.org/jira/browse/HBASE-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HBASE-16114: - Attachment: HBASE-16114.master.001.patch > Get regionLocation of only required regions for MR jobs > --- > > Key: HBASE-16114 > URL: https://issues.apache.org/jira/browse/HBASE-16114 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.2.1 >Reporter: Thiruvel Thirumoolan >Priority: Minor > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16114.master.001.patch > > > We should only get the location of regions required during the MR job. This > will help for jobs with large regions but the job itself scans only a small > portion of it. Similar changes can be seen in MultiInputFormatBase.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-16114) Get regionLocation of only required regions for MR jobs
Thiruvel Thirumoolan created HBASE-16114: Summary: Get regionLocation of only required regions for MR jobs Key: HBASE-16114 URL: https://issues.apache.org/jira/browse/HBASE-16114 Project: HBase Issue Type: Improvement Components: mapreduce Affects Versions: 1.2.1 Reporter: Thiruvel Thirumoolan Priority: Minor Fix For: 2.0.0, 1.3.0 We should only get the location of regions required during the MR job. This will help for jobs with large regions but the job itself scans only a small portion of it. Similar changes can be seen in MultiInputFormatBase.java. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/disabled
[ https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HBASE-14007: - Status: Patch Available (was: Open) > Writing to table through MR should fail upfront if table does not > exist/disabled > > > Key: HBASE-14007 > URL: https://issues.apache.org/jira/browse/HBASE-14007 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.1.1 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Minor > Labels: mapreduce > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-14007.master.001.patch, HBASE-14007.patch > > > TableOutputFormat.checkOutputSpecs() needs to be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14007) Writing to table through MR should fail upfront if table does not exist/disabled
[ https://issues.apache.org/jira/browse/HBASE-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan updated HBASE-14007: - Attachment: HBASE-14007.master.001.patch Attaching patch with review comments addressed. [~tedyu], Sorry about the delay, please let me know if you have any other comments. > Writing to table through MR should fail upfront if table does not > exist/disabled > > > Key: HBASE-14007 > URL: https://issues.apache.org/jira/browse/HBASE-14007 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.1.1 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Minor > Labels: mapreduce > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-14007.master.001.patch, HBASE-14007.patch > > > TableOutputFormat.checkOutputSpecs() needs to be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16089) Add on FastPath for CoDel
[ https://issues.apache.org/jira/browse/HBASE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349922#comment-15349922 ] Hudson commented on HBASE-16089: SUCCESS: Integrated in HBase-1.3 #759 (See [https://builds.apache.org/job/HBase-1.3/759/]) HBASE-16089 Add on FastPath for CoDel (eclark: rev 65cbb6c2e7335596c6edf8c0243bcd66722641bb) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FifoWithFastPathBalancedQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/AdaptiveLifoCoDelCallQueue.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathBalancedQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java > Add on FastPath for CoDel > - > > Key: HBASE-16089 > URL: https://issues.apache.org/jira/browse/HBASE-16089 > Project: HBase > Issue Type: Improvement >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16089.patch, HBASE-16089.v1.patch, > HBASE-16089.v2.patch, HBASE-16089.v3.patch, > baselineFifo_codel_codelPlusPatch.png, v3.png > > > If this is all that awesome, so we should have it on CoDel too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16089) Add on FastPath for CoDel
[ https://issues.apache.org/jira/browse/HBASE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349921#comment-15349921 ] Hudson commented on HBASE-16089: FAILURE: Integrated in HBase-1.4 #250 (See [https://builds.apache.org/job/HBase-1.4/250/]) HBASE-16089 Add on FastPath for CoDel (eclark: rev f4c1fd1a478631b702320a61e78c4647e4fea449) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/AdaptiveLifoCoDelCallQueue.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathBalancedQueueRpcExecutor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FifoWithFastPathBalancedQueueRpcExecutor.java > Add on FastPath for CoDel > - > > Key: HBASE-16089 > URL: https://issues.apache.org/jira/browse/HBASE-16089 > Project: HBase > Issue Type: Improvement >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16089.patch, HBASE-16089.v1.patch, > HBASE-16089.v2.patch, HBASE-16089.v3.patch, > baselineFifo_codel_codelPlusPatch.png, v3.png > > > If this is all that awesome, so we should have it on CoDel too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16089) Add on FastPath for CoDel
[ https://issues.apache.org/jira/browse/HBASE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349863#comment-15349863 ] Hudson commented on HBASE-16089: FAILURE: Integrated in HBase-Trunk_matrix #1114 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1114/]) HBASE-16089 Add on FastPath for CoDel (eclark: rev fc4b8aa89d22961feb1ab7849104e68f6e1c0153) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathBalancedQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FifoWithFastPathBalancedQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/AdaptiveLifoCoDelCallQueue.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java > Add on FastPath for CoDel > - > > Key: HBASE-16089 > URL: https://issues.apache.org/jira/browse/HBASE-16089 > Project: HBase > Issue Type: Improvement >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16089.patch, HBASE-16089.v1.patch, > HBASE-16089.v2.patch, HBASE-16089.v3.patch, > baselineFifo_codel_codelPlusPatch.png, v3.png > > > If this is all that awesome, so we should have it on CoDel too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16089) Add on FastPath for CoDel
[ https://issues.apache.org/jira/browse/HBASE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349849#comment-15349849 ] Hudson commented on HBASE-16089: SUCCESS: Integrated in HBase-1.3-IT #734 (See [https://builds.apache.org/job/HBase-1.3-IT/734/]) HBASE-16089 Add on FastPath for CoDel (eclark: rev 65cbb6c2e7335596c6edf8c0243bcd66722641bb) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FastPathBalancedQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/FifoWithFastPathBalancedQueueRpcExecutor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/AdaptiveLifoCoDelCallQueue.java > Add on FastPath for CoDel > - > > Key: HBASE-16089 > URL: https://issues.apache.org/jira/browse/HBASE-16089 > Project: HBase > Issue Type: Improvement >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16089.patch, HBASE-16089.v1.patch, > HBASE-16089.v2.patch, HBASE-16089.v3.patch, > baselineFifo_codel_codelPlusPatch.png, v3.png > > > If this is all that awesome, so we should have it on CoDel too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16071) The VisibilityLabelFilter and AccessControlFilter should not count the "delete cell"
[
https://issues.apache.org/jira/browse/HBASE-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349845#comment-15349845
]
Hadoop QA commented on HBASE-16071:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
51s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 7 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 2s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 13s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 136m 12s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
| | hadoop.hbase.client.TestHCM |
| | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12813394/HBASE-16071-v2.patch |
| JIRA Issue | HBASE-16071 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / fc4b8aa |
| Default Java | 1.7.0_80 |
| Multi-JDK versions
[jira] [Commented] (HBASE-16087) Replication shouldn't start on a master if if only hosts system tables
[ https://issues.apache.org/jira/browse/HBASE-16087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349828#comment-15349828 ] Mikhail Antonov commented on HBASE-16087: - For people hosting system tables on master and not using or replicating acls or labels, running replication source on master is unnecessary overhead which is good to avoid (also potential warnings comings from it). On the other hand, people hosting system tables on masters AND using replicated acls / labels will be affected. My perception from prior discussions re meta-on-master is that it's a configuration not widely used in production, and so I think number of users affected would be very small (for them, the workaround exists as [~eclark] said). The patch looks good to me. Backward-compatible, but needs release note to describe the case above and workaround. > Replication shouldn't start on a master if if only hosts system tables > -- > > Key: HBASE-16087 > URL: https://issues.apache.org/jira/browse/HBASE-16087 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Attachments: HBASE-16087.patch, HBASE-16087.v1.patch > > > System tables aren't replicated so we shouldn't start up a replication master > if there are no user tables on the master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16087) Replication shouldn't start on a master if if only hosts system tables
[ https://issues.apache.org/jira/browse/HBASE-16087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349777#comment-15349777 ] Mikhail Antonov commented on HBASE-16087: - (just to note - the configuration here should only apply when system tables are hosted on master, your clusters are running in this configuration?) > Replication shouldn't start on a master if if only hosts system tables > -- > > Key: HBASE-16087 > URL: https://issues.apache.org/jira/browse/HBASE-16087 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Attachments: HBASE-16087.patch, HBASE-16087.v1.patch > > > System tables aren't replicated so we shouldn't start up a replication master > if there are no user tables on the master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16089) Add on FastPath for CoDel
[ https://issues.apache.org/jira/browse/HBASE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-16089: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.4.0 1.3.0 2.0.0 Status: Resolved (was: Patch Available) Pushed to master, branch-1, and branch-1.3 > Add on FastPath for CoDel > - > > Key: HBASE-16089 > URL: https://issues.apache.org/jira/browse/HBASE-16089 > Project: HBase > Issue Type: Improvement >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16089.patch, HBASE-16089.v1.patch, > HBASE-16089.v2.patch, HBASE-16089.v3.patch, > baselineFifo_codel_codelPlusPatch.png, v3.png > > > If this is all that awesome, so we should have it on CoDel too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16071) The VisibilityLabelFilter and AccessControlFilter should not count the "delete cell"
[
https://issues.apache.org/jira/browse/HBASE-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ChiaPing Tsai updated HBASE-16071:
--
Status: Patch Available (was: Open)
> The VisibilityLabelFilter and AccessControlFilter should not count the
> "delete cell"
>
>
> Key: HBASE-16071
> URL: https://issues.apache.org/jira/browse/HBASE-16071
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: ChiaPing Tsai
>Assignee: ChiaPing Tsai
>Priority: Minor
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-16071-v1.patch, HBASE-16071-v2.patch
>
>
> The VisibilityLabelFilter will see and count the "delete cell" if the
> scan.isRaw() returns true, so the (put) cell will be skipped if it has lower
> version than "delete cell"
> The critical code is shown below:
> {code:title=VisibilityLabelFilter.java|borderStyle=solid}
> public ReturnCode filterKeyValue(Cell cell) throws IOException {
> if (curFamily.getBytes() == null
> || !(CellUtil.matchingFamily(cell, curFamily.getBytes(),
> curFamily.getOffset(),
> curFamily.getLength( {
> curFamily.set(cell.getFamilyArray(), cell.getFamilyOffset(),
> cell.getFamilyLength());
> // For this family, all the columns can have max of
> curFamilyMaxVersions versions. No need to
> // consider the older versions for visibility label check.
> // Ideally this should have been done at a lower layer by HBase (?)
> curFamilyMaxVersions = cfVsMaxVersions.get(curFamily);
> // Family is changed. Just unset curQualifier.
> curQualifier.unset();
> }
> if (curQualifier.getBytes() == null
> || !(CellUtil.matchingQualifier(cell, curQualifier.getBytes(),
> curQualifier.getOffset(),
> curQualifier.getLength( {
> curQualifier.set(cell.getQualifierArray(), cell.getQualifierOffset(),
> cell.getQualifierLength());
> curQualMetVersions = 0;
> }
> curQualMetVersions++;
> if (curQualMetVersions > curFamilyMaxVersions) {
> return ReturnCode.SKIP;
> }
> return this.expEvaluator.evaluate(cell) ? ReturnCode.INCLUDE :
> ReturnCode.SKIP;
> }
> {code}
> [VisibilityLabelFilter.java|https://github.com/apache/hbase/blob/d7a4499dfc8b3936a0eca867589fc2b23b597866/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16071) The VisibilityLabelFilter and AccessControlFilter should not count the "delete cell"
[
https://issues.apache.org/jira/browse/HBASE-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349766#comment-15349766
]
ChiaPing Tsai commented on HBASE-16071:
---
I create a separate JIRA
[HBASE-16113|https://issues.apache.org/jira/browse/HBASE-16113]
> The VisibilityLabelFilter and AccessControlFilter should not count the
> "delete cell"
>
>
> Key: HBASE-16071
> URL: https://issues.apache.org/jira/browse/HBASE-16071
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: ChiaPing Tsai
>Assignee: ChiaPing Tsai
>Priority: Minor
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-16071-v1.patch
>
>
> The VisibilityLabelFilter will see and count the "delete cell" if the
> scan.isRaw() returns true, so the (put) cell will be skipped if it has lower
> version than "delete cell"
> The critical code is shown below:
> {code:title=VisibilityLabelFilter.java|borderStyle=solid}
> public ReturnCode filterKeyValue(Cell cell) throws IOException {
> if (curFamily.getBytes() == null
> || !(CellUtil.matchingFamily(cell, curFamily.getBytes(),
> curFamily.getOffset(),
> curFamily.getLength( {
> curFamily.set(cell.getFamilyArray(), cell.getFamilyOffset(),
> cell.getFamilyLength());
> // For this family, all the columns can have max of
> curFamilyMaxVersions versions. No need to
> // consider the older versions for visibility label check.
> // Ideally this should have been done at a lower layer by HBase (?)
> curFamilyMaxVersions = cfVsMaxVersions.get(curFamily);
> // Family is changed. Just unset curQualifier.
> curQualifier.unset();
> }
> if (curQualifier.getBytes() == null
> || !(CellUtil.matchingQualifier(cell, curQualifier.getBytes(),
> curQualifier.getOffset(),
> curQualifier.getLength( {
> curQualifier.set(cell.getQualifierArray(), cell.getQualifierOffset(),
> cell.getQualifierLength());
> curQualMetVersions = 0;
> }
> curQualMetVersions++;
> if (curQualMetVersions > curFamilyMaxVersions) {
> return ReturnCode.SKIP;
> }
> return this.expEvaluator.evaluate(cell) ? ReturnCode.INCLUDE :
> ReturnCode.SKIP;
> }
> {code}
> [VisibilityLabelFilter.java|https://github.com/apache/hbase/blob/d7a4499dfc8b3936a0eca867589fc2b23b597866/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-16113) The raw scan with "zero" max versions should return empty result
ChiaPing Tsai created HBASE-16113:
-
Summary: The raw scan with "zero" max versions should return empty
result
Key: HBASE-16113
URL: https://issues.apache.org/jira/browse/HBASE-16113
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Priority: Trivial
Step 1: put a cell
Step 2: delete the cell
Step 3: Scan#setRaw(true).setMaxVersions(0)
Step 4: Result result = table.getScanner(scan).next()
Step 5: The result will contain a Cell of DELETE type
Is it a correct result ? The critical code is shown below:
{code:title=ScanWildcardColumnTracker.java|borderStyle=solid}
// May be we should check the verion first
private MatchCode checkVersion(byte type, long timestamp) {
if (!CellUtil.isDelete(type)) {
currentCount++;
}
if (currentCount > maxVersions) {
return ScanQueryMatcher.MatchCode.SEEK_NEXT_COL; // skip to next col
}
// keep the KV if required by minversions or it is not expired, yet
if (currentCount <= minVersions || !isExpired(timestamp)) {
setTSAndType(timestamp, type);
return ScanQueryMatcher.MatchCode.INCLUDE;
} else {
return MatchCode.SEEK_NEXT_COL;
}
}
{code}
Comments?
Thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16089) Add on FastPath for CoDel
[ https://issues.apache.org/jira/browse/HBASE-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349756#comment-15349756 ] Elliott Clark commented on HBASE-16089: --- Thanks [~saint@gmail.com] that's awesome. Still a little lower than fifo ( but I think that's to be expected ). > Add on FastPath for CoDel > - > > Key: HBASE-16089 > URL: https://issues.apache.org/jira/browse/HBASE-16089 > Project: HBase > Issue Type: Improvement >Reporter: Elliott Clark >Assignee: Elliott Clark > Attachments: HBASE-16089.patch, HBASE-16089.v1.patch, > HBASE-16089.v2.patch, HBASE-16089.v3.patch, > baselineFifo_codel_codelPlusPatch.png, v3.png > > > If this is all that awesome, so we should have it on CoDel too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16071) The VisibilityLabelFilter and AccessControlFilter should not count the "delete cell"
[
https://issues.apache.org/jira/browse/HBASE-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349732#comment-15349732
]
ChiaPing Tsai commented on HBASE-16071:
---
I got an non-empty result from the raw scan which has the "zero" value of the
max version. The cells are shown below:
---
| delete t1 |
---
| put t1 |
---
Is it a correct result ? The critical code is shown below:
{code:title=ScanWildcardColumnTracker.java|borderStyle=solid}
// May be we should check the verion first
private MatchCode checkVersion(byte type, long timestamp) {
if (!CellUtil.isDelete(type)) {
currentCount++;
}
if (currentCount > maxVersions) {
return ScanQueryMatcher.MatchCode.SEEK_NEXT_COL; // skip to next col
}
// keep the KV if required by minversions or it is not expired, yet
if (currentCount <= minVersions || !isExpired(timestamp)) {
setTSAndType(timestamp, type);
return ScanQueryMatcher.MatchCode.INCLUDE;
} else {
return MatchCode.SEEK_NEXT_COL;
}
}
{code}
> The VisibilityLabelFilter and AccessControlFilter should not count the
> "delete cell"
>
>
> Key: HBASE-16071
> URL: https://issues.apache.org/jira/browse/HBASE-16071
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: ChiaPing Tsai
>Assignee: ChiaPing Tsai
>Priority: Minor
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-16071-v1.patch
>
>
> The VisibilityLabelFilter will see and count the "delete cell" if the
> scan.isRaw() returns true, so the (put) cell will be skipped if it has lower
> version than "delete cell"
> The critical code is shown below:
> {code:title=VisibilityLabelFilter.java|borderStyle=solid}
> public ReturnCode filterKeyValue(Cell cell) throws IOException {
> if (curFamily.getBytes() == null
> || !(CellUtil.matchingFamily(cell, curFamily.getBytes(),
> curFamily.getOffset(),
> curFamily.getLength( {
> curFamily.set(cell.getFamilyArray(), cell.getFamilyOffset(),
> cell.getFamilyLength());
> // For this family, all the columns can have max of
> curFamilyMaxVersions versions. No need to
> // consider the older versions for visibility label check.
> // Ideally this should have been done at a lower layer by HBase (?)
> curFamilyMaxVersions = cfVsMaxVersions.get(curFamily);
> // Family is changed. Just unset curQualifier.
> curQualifier.unset();
> }
> if (curQualifier.getBytes() == null
> || !(CellUtil.matchingQualifier(cell, curQualifier.getBytes(),
> curQualifier.getOffset(),
> curQualifier.getLength( {
> curQualifier.set(cell.getQualifierArray(), cell.getQualifierOffset(),
> cell.getQualifierLength());
> curQualMetVersions = 0;
> }
> curQualMetVersions++;
> if (curQualMetVersions > curFamilyMaxVersions) {
> return ReturnCode.SKIP;
> }
> return this.expEvaluator.evaluate(cell) ? ReturnCode.INCLUDE :
> ReturnCode.SKIP;
> }
> {code}
> [VisibilityLabelFilter.java|https://github.com/apache/hbase/blob/d7a4499dfc8b3936a0eca867589fc2b23b597866/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16109) Add Interface audience annotation to a few classes
[
https://issues.apache.org/jira/browse/HBASE-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349713#comment-15349713
]
Hadoop QA commented on HBASE-16109:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 57s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m 14s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 131m 9s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12813375/16109.v2.txt |
| JIRA Issue | HBASE-16109 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Updated] (HBASE-16112) TestMobFlushSnapshotFromClient is flaky
[
https://issues.apache.org/jira/browse/HBASE-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-16112:
---
Attachment: TestMobFlushSnapshotFromClient-2353.out
TestFlushSnapshotFromClient-2353.out
> TestMobFlushSnapshotFromClient is flaky
> ---
>
> Key: HBASE-16112
> URL: https://issues.apache.org/jira/browse/HBASE-16112
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
> Attachments: TestFlushSnapshotFromClient-2353.out,
> TestMobFlushSnapshotFromClient-2353.out
>
>
> On recent QA runs, TestMobFlushSnapshotFromClient failed twice.
> https://builds.apache.org/job/PreCommit-HBASE-Build/2360/#showFailuresLink
> https://builds.apache.org/job/PreCommit-HBASE-Build/2353/artifact/patchprocess/patch-unit-hbase-server.txt
> {code}
> org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient.org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
> Run 1:
> TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.tearDown:123->Object.wait:-2
> » TestTimedOut
> Run 2:
> TestMobFlushSnapshotFromClient.org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
> »
> org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient.testSnapshotStateAfterMerge(org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient)
> Run 1:
> TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.testSnapshotStateAfterMerge:335->TestFlushSnapshotFromClient.waitRegionsAfterMerge:526
> » RetriesExhausted
> Run 2:
> TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.tearDown:123 »
> InterruptedIO
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16112) TestMobFlushSnapshotFromClient is flaky
[
https://issues.apache.org/jira/browse/HBASE-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349663#comment-15349663
]
Ted Yu commented on HBASE-16112:
In #2353, TestFlushSnapshotFromClient also failed.
> TestMobFlushSnapshotFromClient is flaky
> ---
>
> Key: HBASE-16112
> URL: https://issues.apache.org/jira/browse/HBASE-16112
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
>
> On recent QA runs, TestMobFlushSnapshotFromClient failed twice.
> https://builds.apache.org/job/PreCommit-HBASE-Build/2360/#showFailuresLink
> https://builds.apache.org/job/PreCommit-HBASE-Build/2353/artifact/patchprocess/patch-unit-hbase-server.txt
> {code}
> org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient.org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
> Run 1:
> TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.tearDown:123->Object.wait:-2
> » TestTimedOut
> Run 2:
> TestMobFlushSnapshotFromClient.org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
> »
> org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient.testSnapshotStateAfterMerge(org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient)
> Run 1:
> TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.testSnapshotStateAfterMerge:335->TestFlushSnapshotFromClient.waitRegionsAfterMerge:526
> » RetriesExhausted
> Run 2:
> TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.tearDown:123 »
> InterruptedIO
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-16112) TestMobFlushSnapshotFromClient is flaky
Ted Yu created HBASE-16112:
--
Summary: TestMobFlushSnapshotFromClient is flaky
Key: HBASE-16112
URL: https://issues.apache.org/jira/browse/HBASE-16112
Project: HBase
Issue Type: Test
Reporter: Ted Yu
Priority: Minor
On recent QA runs, TestMobFlushSnapshotFromClient failed twice.
https://builds.apache.org/job/PreCommit-HBASE-Build/2360/#showFailuresLink
https://builds.apache.org/job/PreCommit-HBASE-Build/2353/artifact/patchprocess/patch-unit-hbase-server.txt
{code}
org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient.org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
Run 1:
TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.tearDown:123->Object.wait:-2
» TestTimedOut
Run 2:
TestMobFlushSnapshotFromClient.org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
»
org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient.testSnapshotStateAfterMerge(org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient)
Run 1:
TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.testSnapshotStateAfterMerge:335->TestFlushSnapshotFromClient.waitRegionsAfterMerge:526
» RetriesExhausted
Run 2:
TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.tearDown:123 »
InterruptedIO
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-16109) Add Interface audience annotation to a few classes
[ https://issues.apache.org/jira/browse/HBASE-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16109: --- Attachment: 16109.v2.txt > Add Interface audience annotation to a few classes > -- > > Key: HBASE-16109 > URL: https://issues.apache.org/jira/browse/HBASE-16109 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: 16109.v1.txt, 16109.v2.txt, 16109.v2.txt, 16109.v2.txt, > 16109.v2.txt > > > The following classes miss Interface audience: > FlushNonSloppyStoresFirstPolicy > FlushAllLargeStoresPolicy > MemStoreCompactor > This JIRA adds Interface audience to these classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16109) Add Interface audience annotation to a few classes
[
https://issues.apache.org/jira/browse/HBASE-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349599#comment-15349599
]
Hadoop QA commented on HBASE-16109:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 22s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 57s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 86m 28s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 128m 9s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster |
| | hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
| Timed out junit tests | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| |
org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager
|
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
[jira] [Updated] (HBASE-16109) Add Interface audience annotation to a few classes
[ https://issues.apache.org/jira/browse/HBASE-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16109: --- Attachment: 16109.v2.txt > Add Interface audience annotation to a few classes > -- > > Key: HBASE-16109 > URL: https://issues.apache.org/jira/browse/HBASE-16109 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: 16109.v1.txt, 16109.v2.txt, 16109.v2.txt, 16109.v2.txt > > > The following classes miss Interface audience: > FlushNonSloppyStoresFirstPolicy > FlushAllLargeStoresPolicy > MemStoreCompactor > This JIRA adds Interface audience to these classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16104) Support ColumnFamily in PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349511#comment-15349511 ] Anoop Sam John commented on HBASE-16104: Want to add more CFs? Plan to give a patch? > Support ColumnFamily in PerformanceEvaluation > - > > Key: HBASE-16104 > URL: https://issues.apache.org/jira/browse/HBASE-16104 > Project: HBase > Issue Type: Improvement > Components: tooling >Affects Versions: 0.98.17, 0.98.18 >Reporter: darion yaphet > > Support ColumnFamily when use PerformanceEvaluation to testing reading and > writing performance with a table existed . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16110) AsyncFS WAL doesn't work with Hadoop 2.8+
[ https://issues.apache.org/jira/browse/HBASE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349466#comment-15349466 ] Duo Zhang commented on HBASE-16110: --- And for hadoop 3, [~stack] and I are trying to push AsyncFSOutput related code into H3. No big progress yet... But seems the endless quarrel on AsyncFS API has ended finally. Will continue tracking it and prepare a patch at the right time. Thanks. > AsyncFS WAL doesn't work with Hadoop 2.8+ > - > > Key: HBASE-16110 > URL: https://issues.apache.org/jira/browse/HBASE-16110 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Priority: Blocker > Fix For: 2.0.0 > > > The async wal implementation doesn't work with Hadoop 2.8+. Fails compilation > and will fail running. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16110) AsyncFS WAL doesn't work with Hadoop 2.8+
[ https://issues.apache.org/jira/browse/HBASE-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349097#comment-15349097 ] Duo Zhang commented on HBASE-16110: --- Got it. Let me fix this. > AsyncFS WAL doesn't work with Hadoop 2.8+ > - > > Key: HBASE-16110 > URL: https://issues.apache.org/jira/browse/HBASE-16110 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Priority: Blocker > Fix For: 2.0.0 > > > The async wal implementation doesn't work with Hadoop 2.8+. Fails compilation > and will fail running. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13701) Consolidate SecureBulkLoadEndpoint into HBase core as default for bulk load
[ https://issues.apache.org/jira/browse/HBASE-13701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349094#comment-15349094 ] Jerry He commented on HBASE-13701: -- All the bulk load related test cases passed. But the failed test cases in above run seem to be related. I will take a look. > Consolidate SecureBulkLoadEndpoint into HBase core as default for bulk load > --- > > Key: HBASE-13701 > URL: https://issues.apache.org/jira/browse/HBASE-13701 > Project: HBase > Issue Type: Improvement >Reporter: Jerry He >Assignee: Jerry He > Fix For: 2.0.0 > > Attachments: HBASE-13701-v1.patch > > > HBASE-12052 makes SecureBulkLoadEndpoint work in a non-secure env to solve > HDFS permission issues. > We have encountered some of the permission issues and have to use this > SecureBulkLoadEndpoint to workaround issues. > We should probably consolidate SecureBulkLoadEndpoint into HBase core as > default for bulk load since it is able to handle both secure Kerberos and > non-secure cases. > Maintaining two versions of bulk load implementation is also a cause of > confusion, and having to explicitly set it is also inconvenient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
