[jira] [Updated] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18009:
--
Hadoop Flags: Incompatible change

> Move RpcServer.Call to a separated file
> ---
>
> Key: HBASE-18009
> URL: https://issues.apache.org/jira/browse/HBASE-18009
> Project: HBase
>  Issue Type: Improvement
>  Components: IPC/RPC
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-18009.patch
>
>
> For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000330#comment-16000330
 ] 

Duo Zhang commented on HBASE-18009:
---

{quote}
Similar way impls of Call from the RpcServer impl classes also?
{quote}
Yes, have already done this in the patch.

{quote}
Shall we also extract the RpcServer.Connection ?
{quote}
Yes, I think so. Will open another issue to address it. It is much complicated 
than extracting RpcServer.Call.

> Move RpcServer.Call to a separated file
> ---
>
> Key: HBASE-18009
> URL: https://issues.apache.org/jira/browse/HBASE-18009
> Project: HBase
>  Issue Type: Improvement
>  Components: IPC/RPC
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-18009.patch
>
>
> For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18009:
--
Status: Patch Available  (was: Open)

> Move RpcServer.Call to a separated file
> ---
>
> Key: HBASE-18009
> URL: https://issues.apache.org/jira/browse/HBASE-18009
> Project: HBase
>  Issue Type: Improvement
>  Components: IPC/RPC
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-18009.patch
>
>
> For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18009:
--
Attachment: HBASE-18009.patch

> Move RpcServer.Call to a separated file
> ---
>
> Key: HBASE-18009
> URL: https://issues.apache.org/jira/browse/HBASE-18009
> Project: HBase
>  Issue Type: Improvement
>  Components: IPC/RPC
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-18009.patch
>
>
> For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000326#comment-16000326
 ] 

Hadoop QA commented on HBASE-8758:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 28s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 
4s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 2s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
54m 55s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 185m 33s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
26s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 265m 47s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAsyncBalancerAdminApi |
|   | hadoop.hbase.client.TestAsyncSnapshotAdminApi |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12866812/8758-r1545168.patch |
| JIRA Issue | HBASE-8758 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux dafb3de3f800 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0d0ccc3 |
| Default Java | 1.8.0_131 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6717/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/6717/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6717/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6717/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This messa

[jira] [Commented] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000325#comment-16000325
 ] 

Chia-Ping Tsai commented on HBASE-18009:


Shall we also extract the RpcServer.Connection ?

> Move RpcServer.Call to a separated file
> ---
>
> Key: HBASE-18009
> URL: https://issues.apache.org/jira/browse/HBASE-18009
> Project: HBase
>  Issue Type: Improvement
>  Components: IPC/RPC
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
>
> For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000324#comment-16000324
 ] 

Anoop Sam John commented on HBASE-18009:


Similar way impls of Call from the RpcServer impl classes also?

> Move RpcServer.Call to a separated file
> ---
>
> Key: HBASE-18009
> URL: https://issues.apache.org/jira/browse/HBASE-18009
> Project: HBase
>  Issue Type: Improvement
>  Components: IPC/RPC
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
>
> For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18002) Investigate why bucket cache filling up in file mode in an exisitng file is slower

2017-05-07 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000320#comment-16000320
 ] 

Anoop Sam John commented on HBASE-18002:


I mean this.  From SSD, the reads/writes happen as pages and update as blocks.  
See here 
http://codecapsule.com/2014/02/12/coding-for-ssds-part-6-a-summary-what-every-programmer-should-know-about-solid-state-drives/.
When the file is already having data, we will overhead of writing new cache 
entries.   When our blocks are not aligned with pages in SSD (mostly yes this 
way), we will end up have to rewrite more pages/blocks to add an HFile block 
entry!
bq.bigger concern is that if there are lot of evictions and new blocks keeps 
getting filled up we may still end up with the same problem right?
Hmm true.. Need tests!

> Investigate why bucket cache filling up in file mode in an exisitng file  is 
> slower
> ---
>
> Key: HBASE-18002
> URL: https://issues.apache.org/jira/browse/HBASE-18002
> Project: HBase
>  Issue Type: Sub-task
>  Components: BucketCache
>Affects Versions: 2.0.0
>Reporter: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
>
> This issue was observed when we recently did some tests with SSD based bucket 
> cache. Similar thing was also reported by @stack and [~danielpol] while doing 
> some of these bucket cache related testing.
> When we try to preload a bucket cache (in file mode) with a new file the 
> bucket cache fills up quite faster and there not much 'failedBlockAdditions'. 
> But when the same bucket cache is filled up with a preexisitng file ( that 
> had already some entries filled up) this time it has more 
> 'failedBlockAdditions' and the cache does not fill up faster. Investigate why 
> this happens. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-11034) Get path validates column families twice

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000307#comment-16000307
 ] 

Hadoop QA commented on HBASE-11034:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 10s {color} 
| {color:red} HBASE-11034 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12642432/HBASE-11034.1.patch |
| JIRA Issue | HBASE-11034 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6718/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Get path validates column families twice
> 
>
> Key: HBASE-11034
> URL: https://issues.apache.org/jira/browse/HBASE-11034
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 0.98.0
>Reporter: Nick Dimiduk
>Assignee: Rekha Joshi
>Priority: Minor
> Attachments: HBASE-11034.1.patch
>
>
> HRegion#get(Get) adds/validates column families. The resulting RegionScanner 
> goes through the same validation dance a second time. That second 
> implementation is slightly less efficient, always checking the families, even 
> if there were no user-provided families and the prepareScanner() call already 
> did this. The current logic in HRegion#get() is smarter actually. Let's do 
> the work only once.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-11034) Get path validates column families twice

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000306#comment-16000306
 ] 

Chia-Ping Tsai commented on HBASE-11034:


[~rekhajoshm] Do you want to rebase the patch? I'm happy to commit it.

> Get path validates column families twice
> 
>
> Key: HBASE-11034
> URL: https://issues.apache.org/jira/browse/HBASE-11034
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver
>Affects Versions: 0.98.0
>Reporter: Nick Dimiduk
>Assignee: Rekha Joshi
>Priority: Minor
> Attachments: HBASE-11034.1.patch
>
>
> HRegion#get(Get) adds/validates column families. The resulting RegionScanner 
> goes through the same validation dance a second time. That second 
> implementation is slightly less efficient, always checking the families, even 
> if there were no user-provided families and the prepareScanner() call already 
> did this. The current logic in HRegion#get() is smarter actually. Let's do 
> the work only once.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18002) Investigate why bucket cache filling up in file mode in an exisitng file is slower

2017-05-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000297#comment-16000297
 ] 

ramkrishna.s.vasudevan commented on HBASE-18002:


bq.Our blocks might not be aligned with the device pages also
This should be the case even for an empty file. But yes for a filled up file 
there could be some other internal alignment that would have already been done 
and so new writes may take more time. 
I think the bigger concern is that if there are lot of evictions and new blocks 
keeps getting filled up we may still end up with the same problem right?

> Investigate why bucket cache filling up in file mode in an exisitng file  is 
> slower
> ---
>
> Key: HBASE-18002
> URL: https://issues.apache.org/jira/browse/HBASE-18002
> Project: HBase
>  Issue Type: Sub-task
>  Components: BucketCache
>Affects Versions: 2.0.0
>Reporter: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
>
> This issue was observed when we recently did some tests with SSD based bucket 
> cache. Similar thing was also reported by @stack and [~danielpol] while doing 
> some of these bucket cache related testing.
> When we try to preload a bucket cache (in file mode) with a new file the 
> bucket cache fills up quite faster and there not much 'failedBlockAdditions'. 
> But when the same bucket cache is filled up with a preexisitng file ( that 
> had already some entries filled up) this time it has more 
> 'failedBlockAdditions' and the cache does not fill up faster. Investigate why 
> this happens. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (HBASE-18009) Move RpcServer.Call to a separated file

2017-05-07 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-18009:
-

 Summary: Move RpcServer.Call to a separated file
 Key: HBASE-18009
 URL: https://issues.apache.org/jira/browse/HBASE-18009
 Project: HBase
  Issue Type: Improvement
  Components: IPC/RPC
Affects Versions: 2.0.0
Reporter: Duo Zhang
Assignee: Duo Zhang
 Fix For: 2.0.0


For making RpcServer easier to read.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17992) The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly

2017-05-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000234#comment-16000234
 ] 

Ted Yu commented on HBASE-17992:


{code}
+while(!exec.isTerminated()){
+  Thread.sleep(2000);
{code}
Should there be a bound on the total duration of waiting ?
{code}
+this.waittimeAttempts =
+this.coord.getRpcs().getConfiguration()
+.getLong("hbase.procedure.clearznodes.waittime", 3000l);
{code}
Add dot between "wait" and "time" in the config key name. If you keep Attempts 
in variable name, you can use waitTimeBetweenAttempts.
{code}
+  private final Map> submitSubprocedures=
+  new HashMap>();
{code}
Add comment for what purpose the map serves.

> The snapShot TimeoutException causes the cleanerChore thread to fail to 
> complete the archive correctly
> --
>
> Key: HBASE-17992
> URL: https://issues.apache.org/jira/browse/HBASE-17992
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Affects Versions: 0.98.10, 1.3.0
>Reporter: Bo Cui
> Attachments: hbase-17992.patch
>
>
> The problem is that when the snapshot occurs TimeoutException  or other 
> Exceptions, there is no correct delete /hbase/.hbase-snapshot/tmp, which 
> causes the cleanerChore to fail to complete the archive correctly.
> Modifying the configuration parameter (hbase.snapshot.master.timeout.millis = 
> 60) only reduces the probability of the problem occurring.
> So the solution to the problem is: multi-Threaded exceptions or 
> TimeoutExceptions, the Main-thread must wait until all the tasks are finished 
> or canceled, the Main-thread can be cleared 
> /hbase/.hbase-snapshot/tmp/snapshotName.Otherwise the task is likely to write 
> /hbase/.hbase-snapshot/tmp/snapshotName/region - mainfest
> The problem exists in disabledTableSnapshot and enabledTableSnapshot, because 
> I'm currently using the disabledTableSnapshot, so I provide the patch of 
> disabledTableSnapshot



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17992) The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly

2017-05-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000211#comment-16000211
 ] 

Ted Yu commented on HBASE-17992:


Can you put the patch on review board ?

Is it possible to add a test for the scenario ?

Thanks

> The snapShot TimeoutException causes the cleanerChore thread to fail to 
> complete the archive correctly
> --
>
> Key: HBASE-17992
> URL: https://issues.apache.org/jira/browse/HBASE-17992
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Affects Versions: 0.98.10, 1.3.0
>Reporter: Bo Cui
> Attachments: hbase-17992.patch
>
>
> The problem is that when the snapshot occurs TimeoutException  or other 
> Exceptions, there is no correct delete /hbase/.hbase-snapshot/tmp, which 
> causes the cleanerChore to fail to complete the archive correctly.
> Modifying the configuration parameter (hbase.snapshot.master.timeout.millis = 
> 60) only reduces the probability of the problem occurring.
> So the solution to the problem is: multi-Threaded exceptions or 
> TimeoutExceptions, the Main-thread must wait until all the tasks are finished 
> or canceled, the Main-thread can be cleared 
> /hbase/.hbase-snapshot/tmp/snapshotName.Otherwise the task is likely to write 
> /hbase/.hbase-snapshot/tmp/snapshotName/region - mainfest
> The problem exists in disabledTableSnapshot and enabledTableSnapshot, because 
> I'm currently using the disabledTableSnapshot, so I provide the patch of 
> disabledTableSnapshot



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-17992) The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly

2017-05-07 Thread Bo Cui (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Cui updated HBASE-17992:
---
Attachment: hbase-17992.patch

> The snapShot TimeoutException causes the cleanerChore thread to fail to 
> complete the archive correctly
> --
>
> Key: HBASE-17992
> URL: https://issues.apache.org/jira/browse/HBASE-17992
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots
>Affects Versions: 0.98.10, 1.3.0
>Reporter: Bo Cui
> Attachments: hbase-17992.patch
>
>
> The problem is that when the snapshot occurs TimeoutException  or other 
> Exceptions, there is no correct delete /hbase/.hbase-snapshot/tmp, which 
> causes the cleanerChore to fail to complete the archive correctly.
> Modifying the configuration parameter (hbase.snapshot.master.timeout.millis = 
> 60) only reduces the probability of the problem occurring.
> So the solution to the problem is: multi-Threaded exceptions or 
> TimeoutExceptions, the Main-thread must wait until all the tasks are finished 
> or canceled, the Main-thread can be cleared 
> /hbase/.hbase-snapshot/tmp/snapshotName.Otherwise the task is likely to write 
> /hbase/.hbase-snapshot/tmp/snapshotName/region - mainfest
> The problem exists in disabledTableSnapshot and enabledTableSnapshot, because 
> I'm currently using the disabledTableSnapshot, so I provide the patch of 
> disabledTableSnapshot



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-17471) Region Seqid will be out of order in WAL if using mvccPreAssign

2017-05-07 Thread Yu Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yu Li updated HBASE-17471:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 1.4.0
   2.0.0
   Status: Resolved  (was: Patch Available)

Pushed into branch-1. Close issue since all work done here. Thanks [~allan163] 
for the good job and thanks all for review.

> Region Seqid will be out of order in WAL if using mvccPreAssign
> ---
>
> Key: HBASE-17471
> URL: https://issues.apache.org/jira/browse/HBASE-17471
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Critical
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17471-branch-1.v0.patch, 
> HBASE-17471-branch-1.v1.patch, HBASE-17471-branch-1.v2.patch, 
> HBASE-17471-branch-1.v3.patch, HBASE-17471-duo.patch, 
> HBASE-17471-duo-v1.patch, HBASE-17471-duo-v2.patch, HBASE-17471.patch, 
> HBASE-17471.tmp, HBASE-17471.v2.patch, HBASE-17471.v3.patch, 
> HBASE-17471.v4.patch, HBASE-17471.v5.patch, HBASE-17471.v6.patch
>
>
>  mvccPreAssign was brought by HBASE-16698, which truly improved the 
> performance of writing, especially in ASYNC_WAL scenario. But mvccPreAssign 
> was only used in {{doMiniBatchMutate}}, not in Increment/Append path. If 
> Increment/Append and batch put are using against the same region in parallel, 
> then seqid of the same region may not monotonically increasing in the WAL. 
> Since one write path acquires mvcc/seqid before append, and the other 
> acquires in the append/sync consume thread.
> The out of order situation can easily reproduced by a simple UT, which was 
> attached in the attachment. I modified the code to assert on the disorder: 
> {code}
> if(this.highestSequenceIds.containsKey(encodedRegionName)) {
>   assert highestSequenceIds.get(encodedRegionName) < sequenceid;
> }
> {code}
> I'd like to say, If we allow disorder in WALs, then this is not a issue. 
> But as far as I know, if {{highestSequenceIds}} is not properly set, some 
> WALs may not archive to oldWALs correctly.
> which I haven't figure out yet is that, will disorder in WAL cause data loss 
> when recovering from disaster? If so, then it is a big problem need to be 
> fixed.
> I have fix this problem in our costom1.1.x branch, my solution is using 
> mvccPreAssign everywhere, making it un-configurable. Since mvccPreAssign it 
> is indeed a better way than assign seqid in the ringbuffer thread while 
> keeping handlers waiting for it.
> If anyone think it is doable, then I will port it to branch-1 and master 
> branch and upload it. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-8758:
--
Status: Patch Available  (was: Open)

> Error in RegionCoprocessorHost class preScanner method documentation.
> -
>
> Key: HBASE-8758
> URL: https://issues.apache.org/jira/browse/HBASE-8758
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.94.9, 0.95.2, 0.98.0
> Environment: Any. Actually it is just wrong comment in code.
>Reporter: Roman Nikitchenko
>Priority: Minor
>  Labels: beginner, comments, coprocessors, documentation
> Attachments: 8758-r1545168.patch, HBASE-8758-r1545168.patch, 
> HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to 
> return 'false' value in negative case (default operation should not be 
> bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000175#comment-16000175
 ] 

Ted Yu commented on HBASE-8758:
---

Re-attaching Roman's patch.

> Error in RegionCoprocessorHost class preScanner method documentation.
> -
>
> Key: HBASE-8758
> URL: https://issues.apache.org/jira/browse/HBASE-8758
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.98.0, 0.95.2, 0.94.9
> Environment: Any. Actually it is just wrong comment in code.
>Reporter: Roman Nikitchenko
>Priority: Minor
>  Labels: beginner, comments, coprocessors, documentation
> Attachments: 8758-r1545168.patch, HBASE-8758-r1545168.patch, 
> HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to 
> return 'false' value in negative case (default operation should not be 
> bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-8758:
--
Attachment: 8758-r1545168.patch

> Error in RegionCoprocessorHost class preScanner method documentation.
> -
>
> Key: HBASE-8758
> URL: https://issues.apache.org/jira/browse/HBASE-8758
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.98.0, 0.95.2, 0.94.9
> Environment: Any. Actually it is just wrong comment in code.
>Reporter: Roman Nikitchenko
>Priority: Minor
>  Labels: beginner, comments, coprocessors, documentation
> Attachments: 8758-r1545168.patch, HBASE-8758-r1545168.patch, 
> HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to 
> return 'false' value in negative case (default operation should not be 
> bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-8758:
--
Status: Open  (was: Patch Available)

> Error in RegionCoprocessorHost class preScanner method documentation.
> -
>
> Key: HBASE-8758
> URL: https://issues.apache.org/jira/browse/HBASE-8758
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.94.9, 0.95.2, 0.98.0
> Environment: Any. Actually it is just wrong comment in code.
>Reporter: Roman Nikitchenko
>Priority: Minor
>  Labels: beginner, comments, coprocessors, documentation
> Attachments: HBASE-8758-r1545168.patch, HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to 
> return 'false' value in negative case (default operation should not be 
> bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18001) Extend the "count" shell command to support specified conditions

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000170#comment-16000170
 ] 

Chia-Ping Tsai commented on HBASE-18001:


bq. Can we add three parameters STARTROW, STOPROW and FILTER?
It is better to include the parameters COLUMNS.

> Extend the "count" shell command to support specified conditions
> 
>
> Key: HBASE-18001
> URL: https://issues.apache.org/jira/browse/HBASE-18001
> Project: HBase
>  Issue Type: Improvement
>  Components: shell
>Affects Versions: 2.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
>
> shell command "count" can only count the number of rows in a table.
> And, it could not count the number of the specified conditions.
> Can we allow users to specified conditions like command "scan"?
> In that case, we can count the number of rows under any conditions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000166#comment-16000166
 ] 

Chia-Ping Tsai commented on HBASE-8758:
---

[~yuzhih...@gmail.com] Do you want to commit it? Or assign it to [~weliSmith] 
to revisit the patch.

> Error in RegionCoprocessorHost class preScanner method documentation.
> -
>
> Key: HBASE-8758
> URL: https://issues.apache.org/jira/browse/HBASE-8758
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.98.0, 0.95.2, 0.94.9
> Environment: Any. Actually it is just wrong comment in code.
>Reporter: Roman Nikitchenko
>Priority: Minor
>  Labels: beginner, comments, coprocessors, documentation
> Attachments: HBASE-8758-r1545168.patch, HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to 
> return 'false' value in negative case (default operation should not be 
> bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18001) Extend the "count" shell command to support specified conditions

2017-05-07 Thread Guangxu Cheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000165#comment-16000165
 ] 

Guangxu Cheng commented on HBASE-18001:
---

[~jmspaggi] Thanks for the reviews.
I think it is a very important option to specify the "startrow" and "stoprow".
Can we add three parameters STARTROW, STOPROW and FILTER?

> Extend the "count" shell command to support specified conditions
> 
>
> Key: HBASE-18001
> URL: https://issues.apache.org/jira/browse/HBASE-18001
> Project: HBase
>  Issue Type: Improvement
>  Components: shell
>Affects Versions: 2.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Minor
>  Labels: beginner
> Fix For: 2.0.0
>
>
> shell command "count" can only count the number of rows in a table.
> And, it could not count the number of the specified conditions.
> Can we allow users to specified conditions like command "scan"?
> In that case, we can count the number of rows under any conditions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17343) Make Compacting Memstore default in 2.0 with BASIC as the default type

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000147#comment-16000147
 ] 

Hadoop QA commented on HBASE-17343:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 26s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 21s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
54m 53s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 16s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
58s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 191m 45s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
|   | org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot |
|   | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12866794/HBASE-17343-V07.patch 
|
| JIRA Issue | HBASE-17343 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux d9c95f3b11e3 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0d0ccc3 |
| Default Java | 1.8.0_131 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6716/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/6716/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6716/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-B

[jira] [Commented] (HBASE-14614) Procedure v2: Core Assignment Manager

2017-05-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000119#comment-16000119
 ] 

Hudson commented on HBASE-14614:


FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #230 (See 
[https://builds.apache.org/job/HBase-HBASE-14614/230/])
HBASE-14614 Procedure v2 - Core Assignment Manager (Matteo Bertozzi) 
(stack: rev 9ba7e5b2803a10c29c0a3b0991ec1ee4b25196c5)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableGetMultiThreadedWithBasicCompaction.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Admin.proto
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java
* (edit) 
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java
* (add) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DispatchMergingRegionsProcedure.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit) 
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/MasterProcedureProtos.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionUnassigner.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMetaShutdownHandler.java
* (edit) 
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/RegionServerStatusProtos.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureConstants.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AddColumnFamilyProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestDeleteColumnFamilyProcedure.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MergeTableRegionsProcedure.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit) 
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/UnAssignCallable.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyColumnFamilyProcedure.java
* (edit) 
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestServerBusyException.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ProcedureSyncWait.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java
* (add) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionTransitionProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineNamespaceProcedure.java
* (delete) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java
* (edit) 
hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/generated/MasterProtos.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCloneSnapshotProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestDeleteTableProcedure.java
* (add) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/C

[jira] [Commented] (HBASE-18007) Clean up rest module code

2017-05-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000118#comment-16000118
 ] 

Hudson commented on HBASE-18007:


FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #230 (See 
[https://builds.apache.org/job/HBase-HBASE-14614/230/])
HBASE-18007 Clean up rest module code (tedyu: rev 
0d0ccc38fe59c555176d73e23595a9b569251329)
* (edit) 
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java


> Clean up rest module code 
> --
>
> Key: HBASE-18007
> URL: https://issues.apache.org/jira/browse/HBASE-18007
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-18007-v001.patch
>
>
> HBase rest model has many dead code, let's remove the dead code and clean up 
> warnings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17343) Make Compacting Memstore default in 2.0 with BASIC as the default type

2017-05-07 Thread Anastasia Braginsky (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1685#comment-1685
 ] 

Anastasia Braginsky commented on HBASE-17343:
-

Unable to recreate the failures. I believe they are not related. Submitting 
once again after rebase

> Make Compacting Memstore default in 2.0 with BASIC as the default type
> --
>
> Key: HBASE-17343
> URL: https://issues.apache.org/jira/browse/HBASE-17343
> Project: HBase
>  Issue Type: New Feature
>  Components: regionserver
>Affects Versions: 2.0.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: Anastasia Braginsky
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-17343-V01.patch, HBASE-17343-V02.patch, 
> HBASE-17343-V04.patch, HBASE-17343-V05.patch, HBASE-17343-V06.patch, 
> HBASE-17343-V07.patch
>
>
> FYI [~anastas], [~eshcar] and [~ebortnik].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-17343) Make Compacting Memstore default in 2.0 with BASIC as the default type

2017-05-07 Thread Anastasia Braginsky (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anastasia Braginsky updated HBASE-17343:

Attachment: HBASE-17343-V07.patch

> Make Compacting Memstore default in 2.0 with BASIC as the default type
> --
>
> Key: HBASE-17343
> URL: https://issues.apache.org/jira/browse/HBASE-17343
> Project: HBase
>  Issue Type: New Feature
>  Components: regionserver
>Affects Versions: 2.0.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: Anastasia Braginsky
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-17343-V01.patch, HBASE-17343-V02.patch, 
> HBASE-17343-V04.patch, HBASE-17343-V05.patch, HBASE-17343-V06.patch, 
> HBASE-17343-V07.patch
>
>
> FYI [~anastas], [~eshcar] and [~ebortnik].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-14083) Fix separator width in Backup Masters of WebUI

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1609#comment-1609
 ] 

Hadoop QA commented on HBASE-14083:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 27s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
55m 9s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 41s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
45s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 177m 28s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
|   | org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot |
|   | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12745395/HBASE-14083.patch |
| JIRA Issue | HBASE-14083 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux 896d51974365 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0d0ccc3 |
| Default Java | 1.8.0_131 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6715/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/6715/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6715/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6715/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fix separator width in Backup Masters of WebUI
> --
>
> Key: HBASE-14083
> URL: https://issues.apache.org/jira/browse/HBASE-14083
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Yuhao Bi
>Assignee: Yuhao Bi
>Priority: Minor
> Attachments: After.PNG, Before.PNG, HBASE-14083.patch
>
>
> The horizontal line separator above total count in backup master is shorter 
> than the others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-14083) Fix separator width in Backup Masters of WebUI

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1522#comment-1522
 ] 

Chia-Ping Tsai commented on HBASE-14083:


+1.
Do you want to commit it ? [~appy]

> Fix separator width in Backup Masters of WebUI
> --
>
> Key: HBASE-14083
> URL: https://issues.apache.org/jira/browse/HBASE-14083
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Reporter: Yuhao Bi
>Assignee: Yuhao Bi
>Priority: Minor
> Attachments: After.PNG, Before.PNG, HBASE-14083.patch
>
>
> The horizontal line separator above total count in backup master is shorter 
> than the others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17208) Manual Array Copy Cleanup: Automated

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1512#comment-1512
 ] 

Hadoop QA commented on HBASE-17208:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s {color} 
| {color:red} HBASE-17208 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12841051/HBASE-17208.patch |
| JIRA Issue | HBASE-17208 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6713/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Manual Array Copy Cleanup: Automated
> 
>
> Key: HBASE-17208
> URL: https://issues.apache.org/jira/browse/HBASE-17208
> Project: HBase
>  Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: HBASE-17208.patch
>
>
> Remove Manual Array Copies: Automated



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17209) manual Array to Collection Copy: Automated

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1513#comment-1513
 ] 

Hadoop QA commented on HBASE-17209:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s {color} 
| {color:red} HBASE-17209 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12841055/HBASE-17209.patch |
| JIRA Issue | HBASE-17209 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6714/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> manual Array to Collection Copy: Automated
> --
>
> Key: HBASE-17209
> URL: https://issues.apache.org/jira/browse/HBASE-17209
> Project: HBase
>  Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: HBASE-17209.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (HBASE-17209) manual Array to Collection Copy: Automated

2017-05-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai reassigned HBASE-17209:
--

Assignee: John Leach

> manual Array to Collection Copy: Automated
> --
>
> Key: HBASE-17209
> URL: https://issues.apache.org/jira/browse/HBASE-17209
> Project: HBase
>  Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: HBASE-17209.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17209) manual Array to Collection Copy: Automated

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1511#comment-1511
 ] 

Chia-Ping Tsai commented on HBASE-17209:


bq. java.util.*
Is it necessary?

> manual Array to Collection Copy: Automated
> --
>
> Key: HBASE-17209
> URL: https://issues.apache.org/jira/browse/HBASE-17209
> Project: HBase
>  Issue Type: Improvement
>Reporter: John Leach
>Priority: Trivial
> Attachments: HBASE-17209.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17208) Manual Array Copy Cleanup: Automated

2017-05-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1509#comment-1509
 ] 

Chia-Ping Tsai commented on HBASE-17208:


bq. I think we can use Arrays.copyOf and Arrays.copyOfRange for some of the 
cases in the patch?
+1. It is also related to performance. see HBASE-17233.

[~jleach] I'm glad to commit it if you address the comments from [~Apache9].

> Manual Array Copy Cleanup: Automated
> 
>
> Key: HBASE-17208
> URL: https://issues.apache.org/jira/browse/HBASE-17208
> Project: HBase
>  Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: HBASE-17208.patch
>
>
> Remove Manual Array Copies: Automated



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17887) TestAcidGuarantees fails frequently

2017-05-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1504#comment-1504
 ] 

Ted Yu commented on HBASE-17887:


Patch v4 looks good.

> TestAcidGuarantees fails frequently
> ---
>
> Key: HBASE-17887
> URL: https://issues.apache.org/jira/browse/HBASE-17887
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.0.0
>Reporter: Umesh Agashe
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.4.1
>
> Attachments: HBASE-17887.branch-1.v0.patch, 
> HBASE-17887.branch-1.v1.patch, HBASE-17887.branch-1.v1.patch, 
> HBASE-17887.branch-1.v2.patch, HBASE-17887.branch-1.v2.patch, 
> HBASE-17887.branch-1.v3.patch, HBASE-17887.branch-1.v4.patch, 
> HBASE-17887.branch-1.v4.patch, HBASE-17887.branch-1.v4.patch, 
> HBASE-17887.v0.patch, HBASE-17887.v1.patch
>
>
> As per the flaky tests dashboard here: 
> https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html,
>  It fails 30% of the time.
> While working on HBASE-17863, a few verification builds on patch failed due 
> to TestAcidGuarantees didn't pass. IMHO, the changes for HBASE-17863 are 
> unlikely to affect get/ put path.
> I ran the test with and without the patch several times locally and found 
> that TestAcidGuarantees fails without the patch similar number of times.
> Opening blocker, considering acid guarantees are critical to HBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-17499) Bound the total heap memory used for the rolling average of RegionLoads

2017-05-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-17499:
---
Labels: balancer  (was: )

> Bound the total heap memory used for the rolling average of RegionLoads
> ---
>
> Key: HBASE-17499
> URL: https://issues.apache.org/jira/browse/HBASE-17499
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>  Labels: balancer
>
> Currently "hbase.master.balancer.stochastic.numRegionLoadsToRemember" 
> controls the number of RegionLoads which are kept by StochasticLoadBalancer 
> for each region.
> The parameter doesn't take into account the number of regions in the cluster.
> Meaning, the amount of heap consumed by RegionLoads would be out of norm for 
> cluster with large number of regions.
> This issue is to see if we should bound the total heap memory used for the 
> rolling average of RegionLoads.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17860) Implement secure native client connection

2017-05-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999867#comment-15999867
 ] 

Ted Yu commented on HBASE-17860:


start-secure-docker.sh has been added in the patch.

> Implement secure native client connection
> -
>
> Key: HBASE-17860
> URL: https://issues.apache.org/jira/browse/HBASE-17860
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
>  Labels: native
> Attachments: 17860.v21.txt, 17860.v2.txt, 17860.v3.txt, 17860.v4.txt
>
>
> So far, the native client communicates with insecure cluster.
> This JIRA is to add secure connection support for native client using Cyrus 
> library.
> The work is based on earlier implementation and is redone via wangle and 
> folly frameworks.
> Thanks to [~devaraj] who started the initiative.
> Here is high level description of the design:
> * SaslHandler is declared as:
> {code}
> class SaslHandler
> : public wangle::HandlerAdapter std::unique_ptr>{
> {code}
> It would be inserted between EventBaseHandler and 
> LengthFieldBasedFrameDecoder in the pipeline (via 
> RpcPipelineFactory::newPipeline())
> * SaslHandler would intercept writes to server by buffering the IOBuf's and 
> start the handshake process (via sasl_client_XX calls provided by Cyrus)
> * after handshake is complete, SaslHandler would send the buffered IOBuf's to 
> server and act as pass-thru from then on



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-8758) Error in RegionCoprocessorHost class preScanner method documentation.

2017-05-07 Thread weliSmith (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999852#comment-15999852
 ] 

weliSmith commented on HBASE-8758:
--

hi [~rn]
I want to resolve this issue,can you assign this to me, thanks.

> Error in RegionCoprocessorHost class preScanner method documentation.
> -
>
> Key: HBASE-8758
> URL: https://issues.apache.org/jira/browse/HBASE-8758
> Project: HBase
>  Issue Type: Bug
>  Components: Coprocessors, documentation
>Affects Versions: 0.98.0, 0.95.2, 0.94.9
> Environment: Any. Actually it is just wrong comment in code.
>Reporter: Roman Nikitchenko
>Priority: Minor
>  Labels: beginner, comments, coprocessors, documentation
> Attachments: HBASE-8758-r1545168.patch, HBASE-8758-r1545168.patch
>
>
> preScannerOpen() method of RegionCoprocessorHost class is documented to 
> return 'false' value in negative case (default operation should not be 
> bypassed). Actual implementation returns 'null' value.
> Proposed solution is just to correct comment to match existing implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (HBASE-18008) Any HColumnDescriptor we give out should be immutable

2017-05-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18008:
---
Description: 
This is similar to HBASE-15583, but we should move up on to the 
ColumnFamilyDescriptor rather than ColumnDescriptor.
 

  was:
This is similar to HBASE-15583, but we should move up on to the 
FamilyDescriptor rather than ColumnDescriptor.
 


> Any HColumnDescriptor we give out should be immutable
> -
>
> Key: HBASE-18008
> URL: https://issues.apache.org/jira/browse/HBASE-18008
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0
>
>
> This is similar to HBASE-15583, but we should move up on to the 
> ColumnFamilyDescriptor rather than ColumnDescriptor.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18006) AsyncClientScanner does not retry openScan RPCs

2017-05-07 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999817#comment-15999817
 ] 

Duo Zhang commented on HBASE-18006:
---

So this is a bug of HBaseAdmin?

> AsyncClientScanner does not retry openScan RPCs
> ---
>
> Key: HBASE-18006
> URL: https://issues.apache.org/jira/browse/HBASE-18006
> Project: HBase
>  Issue Type: Bug
>Reporter: Enis Soztutar
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hbase-18006-test.patch
>
>
> I have been reading the code for the new async scan paths excessively, and 
> noticed that there is a problem in the retrying layer for openScan RPCs. 
> In AsyncClientScanner#callOpenScanner() we are doing a open scan RPC. The 
> retrying logic comes from using the single rpc retrying caller in 
> openScanner(). However, we have the logic for failing the scanner if any of 
> the RPC calls here: 
> {code}
>   stub.scan(controller, request, resp -> {
> if (controller.failed()) {
>   future.completeExceptionally(controller.getFailed());
>   return;
> }
> future.complete(new OpenScannerResponse(loc, isRegionServerRemote, 
> stub, controller, resp));
>   });
> {code}
> So, if the open scan gets an UnknownScannerException or something, instead of 
> retrying, it just fails the whole scan. 
> [~Apache9] FYI. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-17343) Make Compacting Memstore default in 2.0 with BASIC as the default type

2017-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999813#comment-15999813
 ] 

Hadoop QA commented on HBASE-17343:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 27s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 
12s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 1s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
1s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
56m 3s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 26s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
47s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 192m 19s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot |
|   | org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot |
|   | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12866756/HBASE-17343-V06.patch 
|
| JIRA Issue | HBASE-17343 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 379b32f01f7b 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0d0ccc3 |
| Default Java | 1.8.0_131 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6712/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/6712/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6712/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Bui

[jira] [Updated] (HBASE-17343) Make Compacting Memstore default in 2.0 with BASIC as the default type

2017-05-07 Thread Anastasia Braginsky (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anastasia Braginsky updated HBASE-17343:

Attachment: HBASE-17343-V06.patch

> Make Compacting Memstore default in 2.0 with BASIC as the default type
> --
>
> Key: HBASE-17343
> URL: https://issues.apache.org/jira/browse/HBASE-17343
> Project: HBase
>  Issue Type: New Feature
>  Components: regionserver
>Affects Versions: 2.0.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: Anastasia Braginsky
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-17343-V01.patch, HBASE-17343-V02.patch, 
> HBASE-17343-V04.patch, HBASE-17343-V05.patch, HBASE-17343-V06.patch
>
>
> FYI [~anastas], [~eshcar] and [~ebortnik].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-14925) Develop HBase shell command/tool to list table's region info through command line

2017-05-07 Thread Ashish Singhi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999730#comment-15999730
 ] 

Ashish Singhi commented on HBASE-14925:
---

bq. The addendum patch attached here will cleanly apply to branch-1 after the 
branch-1 patch for HBASE-17973 is committed.
OK, I will wait for it to get committed first.

> Develop HBase shell command/tool to list table's region info through command 
> line
> -
>
> Key: HBASE-14925
> URL: https://issues.apache.org/jira/browse/HBASE-14925
> Project: HBase
>  Issue Type: Improvement
>  Components: shell
>Reporter: Romil Choksi
>Assignee: Karan Mehta
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-14925.002.patch, 
> HBASE-14925.003.addendum.001.patch, HBASE-14925.003.patch, HBASE-14925.patch
>
>
> I am going through the hbase shell commands to see if there is anything I can 
> use to get all the regions info just for a particular table. I don’t see any 
> such command that provides me that information.
> It would be better to have a command that provides region info, start key, 
> end key etc taking a table name as the input parameter. This is available 
> through HBase UI on clicking on a particular table's link
> A tool/shell command to get a list of regions for a table or all tables in a 
> tabular structured output (that is machine readable)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)