[jira] [Commented] (HBASE-18152) [AMv2] Corrupt Procedure WAL file; procedure data stored out of order
[ https://issues.apache.org/jira/browse/HBASE-18152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081631#comment-16081631 ] Hudson commented on HBASE-18152: FAILURE: Integrated in Jenkins build HBase-1.4 #803 (See [https://builds.apache.org/job/HBase-1.4/803/]) Revert "HBASE-18216 [AMv2] Workaround for HBASE-18152, corrupt procedure (apurtell: rev 844596e09e7961f506ab2e8bb4aee5557e1b4a44) * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.java > [AMv2] Corrupt Procedure WAL file; procedure data stored out of order > - > > Key: HBASE-18152 > URL: https://issues.apache.org/jira/browse/HBASE-18152 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Affects Versions: 2.0.0 >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18152.master.001.patch, > pv2-0036.log, pv2-0047.log, > reading_bad_wal.patch > > > I've seen corruption from time-to-time testing. Its rare enough. Often we > can get over it but sometimes we can't. It took me a while to capture an > instance of corruption. Turns out we are write to the WAL out-of-order which > undoes a basic tenet; that WAL content is ordered in line w/ execution. > Below I'll post a corrupt WAL. > Looking at the write-side, there is a lot going on. I'm not clear on how we > could write out of order. Will try and get more insight. Meantime parking > this issue here to fill data into. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081693#comment-16081693 ] Guanghao Zhang commented on HBASE-18268: +1. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081677#comment-16081677
]
Hudson commented on HBASE-18267:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #161 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/161/])
HBASE-18267 The result from the postAppend is ignored (chia7712: rev
56659f3421dde0670bd9b757076a2d1b74140877)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResultFromCoprocessor.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18359) CoprocessorHConnection#getConnectionForEnvironment should read config from CoprocessorEnvironment
[
https://issues.apache.org/jira/browse/HBASE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081668#comment-16081668
]
Anoop Sam John commented on HBASE-18359:
Sounds correct.
> CoprocessorHConnection#getConnectionForEnvironment should read config from
> CoprocessorEnvironment
> -
>
> Key: HBASE-18359
> URL: https://issues.apache.org/jira/browse/HBASE-18359
> Project: HBase
> Issue Type: Bug
>Reporter: Samarth Jain
>
> It seems like the method getConnectionForEnvironment isn't doing the right
> thing when it is creating a CoprocessorHConnection by reading the config from
> HRegionServer and not from the env passed in.
> If coprocessors want to use a CoprocessorHConnection with some custom config
> settings, then they have no option but to configure it in the hbase-site.xml
> of the region servers. This isn't ideal as a lot of times these "global"
> level configs can have side effects. See PHOENIX-3974 as an example where
> configuring ServerRpcControllerFactory (a Phoenix implementation of
> RpcControllerFactory) could result in deadlocks. Or PHOENIX-3983 where
> presence of this global config causes our index rebuild code to incorrectly
> use handlers it shouldn't.
> If the CoprocessorHConnection created through getConnectionForEnvironment API
> used the CoprocessorEnvironment config, then it would allow co-processors to
> pass in their own config without needing to configure them in hbase-site.xml.
> The change would be simple. Basically change the below
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection((HRegionServer) services);
> }
> {code}
> to
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection(env.getConfiguration(),
> (HRegionServer) services);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16993) BucketCache throw java.io.IOException: Invalid HFile block magic when DATA_BLOCK_ENCODING set to DIFF
[
https://issues.apache.org/jira/browse/HBASE-16993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081663#comment-16081663
]
Anoop Sam John commented on HBASE-16993:
Hi [~liubangchen]. Can u reply to my earlier reply.
bq.,if a bucket is 64kb but datablock only 46kb then will waste 18kb
The current way restrict the size to be multiple of 256. So when the data
block size is 46KB, you can config this bucket size configuration. 46 KB is
a multiple of 256 so it is a valid value only. Below 256 bytes granular
setting might be not really happening from customer.
With current way we save 3 bytes per bucket entry and this will add upto a
considerable amount when the BC size is too large.
So IMHO we should just fix with
1. Documentation for the config that its value(s) to be exact multiples of 256.
2. Have a check at startup that all sizes are multiple of 256 and if not throw
Exception and fail the start.
cc [~ram_krish], [~stack]
> BucketCache throw java.io.IOException: Invalid HFile block magic when
> DATA_BLOCK_ENCODING set to DIFF
> -
>
> Key: HBASE-16993
> URL: https://issues.apache.org/jira/browse/HBASE-16993
> Project: HBase
> Issue Type: Bug
> Components: BucketCache, io
>Affects Versions: 1.1.3
> Environment: hbase version 1.1.3
>Reporter: liubangchen
>Assignee: liubangchen
> Fix For: 2.0.0
>
> Attachments: HBASE-16993.000.patch, HBASE-16993.001.patch,
> HBASE-16993.master.001.patch, HBASE-16993.master.002.patch,
> HBASE-16993.master.003.patch, HBASE-16993.master.004.patch,
> HBASE-16993.master.005.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> hbase-site.xml setting
>
> hbase.bucketcache.bucket.sizes
> 16384,32768,40960,
> 46000,49152,51200,65536,131072,524288
>
>
> hbase.bucketcache.size
> 16384
>
>
> hbase.bucketcache.ioengine
> offheap
>
>
> hfile.block.cache.size
> 0.3
>
>
> hfile.block.bloom.cacheonwrite
> true
>
>
> hbase.rs.cacheblocksonwrite
> true
>
>
> hfile.block.index.cacheonwrite
> true
> n_splits = 200
> create 'usertable',{NAME =>'family', COMPRESSION => 'snappy', VERSIONS =>
> 1,DATA_BLOCK_ENCODING => 'DIFF',CONFIGURATION =>
> {'hbase.hregion.memstore.block.multiplier' => 5}},{DURABILITY =>
> 'SKIP_WAL'},{SPLITS => (1..n_splits).map {|i|
> "user#{1000+i*(-1000)/n_splits}"}}
> load data
> bin/ycsb load hbase10 -P workloads/workloada -p table=usertable -p
> columnfamily=family -p fieldcount=10 -p fieldlength=100 -p
> recordcount=2 -p insertorder=hashed -p insertstart=0 -p
> clientbuffering=true -p durability=SKIP_WAL -threads 20 -s
> run
> bin/ycsb run hbase10 -P workloads/workloadb -p table=usertable -p
> columnfamily=family -p fieldcount=10 -p fieldlength=100 -p
> operationcount=2000 -p readallfields=true -p clientbuffering=true -p
> requestdistribution=zipfian -threads 10 -s
> log info
> 2016-11-02 20:20:20,261 ERROR
> [RW.default.readRpcServer.handler=36,queue=21,port=6020] bucket.BucketCache:
> Failed reading block fdcc7ed6f3b2498b9ef316cc8206c233_44819759 from bucket
> cache
> java.io.IOException: Invalid HFile block magic:
> \x00\x00\x00\x00\x00\x00\x00\x00
> at
> org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154)
> at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167)
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:273)
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:134)
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:121)
> at
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:427)
> at
> org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getBlock(CombinedBlockCache.java:85)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2.getCachedBlock(HFileReaderV2.java:266)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2.readBlock(HFileReaderV2.java:403)
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexReader.loadDataBlockWithScanInfo(HFileBlockIndex.java:269)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2$AbstractScannerV2.seekTo(HFileReaderV2.java:634)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderV2$AbstractScannerV2.seekTo(HFileReaderV2.java:584)
> at
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:247)
> at
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:156)
> at
>
[jira] [Commented] (HBASE-15062) IntegrationTestMTTR conditionally run some tests
[ https://issues.apache.org/jira/browse/HBASE-15062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081655#comment-16081655 ] Hudson commented on HBASE-15062: FAILURE: Integrated in Jenkins build HBase-2.0 #150 (See [https://builds.apache.org/job/HBase-2.0/150/]) HBASE-15062 IntegrationTestMTTR conditionally run some tests. (stack: rev 0f39f0874065939ed7ffceea0dcea48d29a10cb4) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java > IntegrationTestMTTR conditionally run some tests > - > > Key: HBASE-15062 > URL: https://issues.apache.org/jira/browse/HBASE-15062 > Project: HBase > Issue Type: Improvement > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Samir Ahmic >Assignee: Samir Ahmic >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-15062-v0.patch, HBASE-15062-v1.patch, > HBASE-15062-v1.patch, HBASE-15062-v1.patch > > > On master branch master-rs collocation is on by default which cause that > following test in IntegrationTestMTTR is same test as restartMaster > - testKillRsHoldingMeta > I will add condition so that if we have system tables on master test above > will be skipped else we will run it -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081652#comment-16081652 ] ramkrishna.s.vasudevan commented on HBASE-18295: +1 for v3. Great work. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18342) Add coprocessor service support for async admin
[
https://issues.apache.org/jira/browse/HBASE-18342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081643#comment-16081643
]
Hadoop QA commented on HBASE-18342:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
59s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 37s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
45s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18342 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876555/HBASE-18342.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux e5e68d2888cb 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 43492d2 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7608/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7608/testReport/ |
| modules | C: hbase-client hbase-endpoint U: . |
| Console output |
[jira] [Commented] (HBASE-18216) [AMv2] Workaround for HBASE-18152, corrupt procedure WAL
[ https://issues.apache.org/jira/browse/HBASE-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081630#comment-16081630 ] Hudson commented on HBASE-18216: FAILURE: Integrated in Jenkins build HBase-1.4 #803 (See [https://builds.apache.org/job/HBase-1.4/803/]) Revert "HBASE-18216 [AMv2] Workaround for HBASE-18152, corrupt procedure (apurtell: rev 844596e09e7961f506ab2e8bb4aee5557e1b4a44) * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.java > [AMv2] Workaround for HBASE-18152, corrupt procedure WAL > > > Key: HBASE-18216 > URL: https://issues.apache.org/jira/browse/HBASE-18216 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18216.branch-1.001.patch > > > Let me commit workaround for the issue up in HBASE-18152, corruption in the > master wal procedure files. Testing on cluster shows it helps. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18342) Add coprocessor service support for async admin
[ https://issues.apache.org/jira/browse/HBASE-18342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18342: --- Attachment: HBASE-18342.master.002.patch > Add coprocessor service support for async admin > --- > > Key: HBASE-18342 > URL: https://issues.apache.org/jira/browse/HBASE-18342 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18342.master.001.patch, > HBASE-18342.master.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18308) Eliminate the findbugs warnings for hbase-server
[ https://issues.apache.org/jira/browse/HBASE-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18308: --- Status: Patch Available (was: Open) > Eliminate the findbugs warnings for hbase-server > > > Key: HBASE-18308 > URL: https://issues.apache.org/jira/browse/HBASE-18308 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18308.v0.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18348) The implementation of AsyncTableRegionLocator does not follow the javadoc
[ https://issues.apache.org/jira/browse/HBASE-18348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081603#comment-16081603 ] Duo Zhang commented on HBASE-18348: --- Let me commit this first. The naming of the parameter could be addressed in another issue. > The implementation of AsyncTableRegionLocator does not follow the javadoc > - > > Key: HBASE-18348 > URL: https://issues.apache.org/jira/browse/HBASE-18348 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18348.branch-2.001.patch, HBASE-18348.patch > > > The reload parameter is just ignored. > Need to fix this before 2.0.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18308) Eliminate the findbugs warnings for hbase-server
[ https://issues.apache.org/jira/browse/HBASE-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18308: --- Attachment: HBASE-18308.v0.patch > Eliminate the findbugs warnings for hbase-server > > > Key: HBASE-18308 > URL: https://issues.apache.org/jira/browse/HBASE-18308 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18308.v0.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18358) Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081597#comment-16081597
]
Hadoop QA commented on HBASE-18358:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
8s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} branch-1.3 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
17s{color} | {color:red} hbase-server in branch-1.3 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 56s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 84m
36s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}118m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:9ba21e3 |
| JIRA Issue | HBASE-18358 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876542/18358.branch-1.3.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux e9c72025a753 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081576#comment-16081576
]
Chia-Ping Tsai commented on HBASE-18267:
The TestChoreService should be irrelevant to this jira. I run it 20 times but
no error happens.
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18358) Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18358:
---
Status: Patch Available (was: Open)
> Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent
> Region#flush() to finish' to branch-1.3
> --
>
> Key: HBASE-18358
> URL: https://issues.apache.org/jira/browse/HBASE-18358
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Attachments: 18358.branch-1.3.patch
>
>
> HBASE-18099 was only integrated to branch-1 and above in consideration of
> backward compatibility.
> This issue is to backport the fix to branch-1.3 and branch-1.2.
> Quoting Gary's suggestion from the tail of HBASE-18099 :
> {quote}
> Sure, don't add the method to Region, just to HRegion, check for an instance
> of HRegion in FlushSnapshotSubprocedure and cast the instance before calling
> the method.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081558#comment-16081558
]
Chia-Ping Tsai commented on HBASE-18267:
Some errors happen in branch-1.2
Will check it asap
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081569#comment-16081569 ] Guanghao Zhang commented on HBASE-18295: +1 for v3. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081563#comment-16081563
]
Hudson commented on HBASE-18267:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #894 (See
[https://builds.apache.org/job/HBase-1.2-IT/894/])
HBASE-18267 The result from the postAppend is ignored (chia7712: rev
56659f3421dde0670bd9b757076a2d1b74140877)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResultFromCoprocessor.java
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081567#comment-16081567 ] Chia-Ping Tsai commented on HBASE-18295: Thanks for the reviews boss. Will commit it tomorrow. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18267:
---
Component/s: Coprocessors
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18340) TestXXXProcedure tests hanging or failing on branch-1 (branch-1.4)
[ https://issues.apache.org/jira/browse/HBASE-18340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081521#comment-16081521 ] Andrew Purtell commented on HBASE-18340: It was HBASE-18216 > TestXXXProcedure tests hanging or failing on branch-1 (branch-1.4) > -- > > Key: HBASE-18340 > URL: https://issues.apache.org/jira/browse/HBASE-18340 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > TestAddColumnFamilyProcedure - hanging > TestCreateNamespaceProcedure - failing > TestDeleteNamespaceProcedure - failing > TestDisableTableProcedure - hanging > TestModifyColumnFamilyProcedure - hanging > TestModifyTableProcedure - hanging > TestTruncateTableProcedure - hanging > Tests are still running so this is not a complete list of all of them, but I > think they are all going to broken. Just tried TestEnableTableProcedure and > that is hanging too. > Tests run: 7, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 6.63 sec <<< > FAILURE! - in > org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure > testRollbackAndDoubleExecution(org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure) > Time elapsed: 2.053 sec <<< FAILURE! > java.lang.AssertionError: expected a running proc > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at > org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.assertProcNotYetCompleted(ProcedureTestingUtility.java:204) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureTestingUtility.testRollbackAndDoubleExecution(MasterProcedureTestingUtility.java:279) > at > org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure.testRollbackAndDoubleExecution(TestCreateNamespaceProcedure.java:219) > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 525.635 sec - > in org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure > Running org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure > Tests run: 6, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 9.331 sec <<< > FAILURE! - in org.apache.hadoop.hbase.master.procedure.TestDeleteNamespacePr > ocedure > testRollbackAndDoubleExecution(org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure) > Time elapsed: 3.528 sec <<< FAILURE! > java.lang.AssertionError: expected a running proc > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at > org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.assertProcNotYetCompleted(ProcedureTestingUtility.java:204) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureTestingUtility.testRollbackAndDoubleExecution(MasterProcedureTestingUtility.java:279) > at > org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure.testRollbackAndDoubleExecution(TestDeleteNamespaceProcedure.java:198) > Tests seem to be hanging in tearDown > "main" #1 prio=5 os_prio=31 tid=0x7fcdbd806000 nid=0x1703 in > Object.wait() [0x70218000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:186) > - locked <0x000716820ae0> (a > java.util.concurrent.atomic.AtomicBoolean) > at > org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4443) > at > org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4435) > at > org.apache.hadoop.hbase.client.HBaseAdmin.disableTableAsyncV2(HBaseAdmin.java:1370) > at > org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmin.java:1329) > at > org.apache.hadoop.hbase.HBaseTestingUtility.deleteTable(HBaseTestingUtility.java:1966) > at > org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure.tearDown(TestDisableTableProcedure.java:79) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18267:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Push this to master, branch-2, branch-1, branch-1.4, branch-1.3, and branch-1.2
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081551#comment-16081551
]
Hudson commented on HBASE-18267:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #133 (See
[https://builds.apache.org/job/HBase-1.3-IT/133/])
HBASE-18267 The result from the postAppend is ignored (chia7712: rev
0b31a730065ea4bfb6354646611049dda56350fa)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResultFromCoprocessor.java
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[
https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081550#comment-16081550
]
Hadoop QA commented on HBASE-16148:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 26 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} hbase-common in master has 2 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
59s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
50s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
40s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 55s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
28s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
12s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
35s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}123m 7s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
8s{color} | {color:green} The patch does not generate ASF
[jira] [Commented] (HBASE-18267) The result from the postAppend is ignored
[
https://issues.apache.org/jira/browse/HBASE-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081542#comment-16081542
]
Hudson commented on HBASE-18267:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #157 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/157/])
HBASE-18267 The result from the postAppend is ignored (chia7712: rev
56659f3421dde0670bd9b757076a2d1b74140877)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResultFromCoprocessor.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
> The result from the postAppend is ignored
> -
>
> Key: HBASE-18267
> URL: https://issues.apache.org/jira/browse/HBASE-18267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.3.1, 1.2.6, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2
>
> Attachments: HBASE-18267.branch-1.2.v0.patch,
> HBASE-18267.branch-1.3.v0.patch, HBASE-18267.branch-1.v0.patch,
> HBASE-18267.v0.patch, HBASE-18267.v1.patch
>
>
> {code:title=RegionCoprocessorHost.java|borderStyle=solid}
> /**
>* @param append Append object
>* @param result the result returned by the append
>* @throws IOException if an error occurred on the coprocessor
>*/
> public void postAppend(final Append append, final Result result) throws
> IOException {
> execOperation(coprocessors.isEmpty() ? null : new RegionOperation() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> oserver.postAppend(ctx, append, result);
> }
> });
> }
> /**
>* @param increment increment object
>* @param result the result returned by postIncrement
>* @throws IOException if an error occurred on the coprocessor
>*/
> public Result postIncrement(final Increment increment, Result result)
> throws IOException {
> return execOperationWithResult(result,
> coprocessors.isEmpty() ? null : new
> RegionOperationWithResult() {
> @Override
> public void call(RegionObserver oserver,
> ObserverContext ctx)
> throws IOException {
> setResult(oserver.postIncrement(ctx, increment, getResult()));
> }
> });
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18343) Track the remaining unimplemented methods for async admin
[ https://issues.apache.org/jira/browse/HBASE-18343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081537#comment-16081537 ] Guanghao Zhang commented on HBASE-18343: ping [~Apache9] for reviewing. > Track the remaining unimplemented methods for async admin > - > > Key: HBASE-18343 > URL: https://issues.apache.org/jira/browse/HBASE-18343 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18343.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18340) TestXXXProcedure tests hanging or failing on branch-1 (branch-1.4)
[ https://issues.apache.org/jira/browse/HBASE-18340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-18340. Resolution: Fixed Resolved by reverting HBASE-18216 on branch-1 and branch-1.4. To https://git-wip-us.apache.org/repos/asf/hbase.git 5d710bbe7f..844596e09e branch-1 -> branch-1 3903358eed..2256aedd3b branch-1.4 -> branch-1.4 > TestXXXProcedure tests hanging or failing on branch-1 (branch-1.4) > -- > > Key: HBASE-18340 > URL: https://issues.apache.org/jira/browse/HBASE-18340 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > TestAddColumnFamilyProcedure - hanging > TestCreateNamespaceProcedure - failing > TestDeleteNamespaceProcedure - failing > TestDisableTableProcedure - hanging > TestModifyColumnFamilyProcedure - hanging > TestModifyTableProcedure - hanging > TestTruncateTableProcedure - hanging > Tests are still running so this is not a complete list of all of them, but I > think they are all going to broken. Just tried TestEnableTableProcedure and > that is hanging too. > Tests run: 7, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 6.63 sec <<< > FAILURE! - in > org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure > testRollbackAndDoubleExecution(org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure) > Time elapsed: 2.053 sec <<< FAILURE! > java.lang.AssertionError: expected a running proc > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at > org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.assertProcNotYetCompleted(ProcedureTestingUtility.java:204) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureTestingUtility.testRollbackAndDoubleExecution(MasterProcedureTestingUtility.java:279) > at > org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure.testRollbackAndDoubleExecution(TestCreateNamespaceProcedure.java:219) > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 525.635 sec - > in org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure > Running org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure > Tests run: 6, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 9.331 sec <<< > FAILURE! - in org.apache.hadoop.hbase.master.procedure.TestDeleteNamespacePr > ocedure > testRollbackAndDoubleExecution(org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure) > Time elapsed: 3.528 sec <<< FAILURE! > java.lang.AssertionError: expected a running proc > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at > org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.assertProcNotYetCompleted(ProcedureTestingUtility.java:204) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureTestingUtility.testRollbackAndDoubleExecution(MasterProcedureTestingUtility.java:279) > at > org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure.testRollbackAndDoubleExecution(TestDeleteNamespaceProcedure.java:198) > Tests seem to be hanging in tearDown > "main" #1 prio=5 os_prio=31 tid=0x7fcdbd806000 nid=0x1703 in > Object.wait() [0x70218000] >java.lang.Thread.State: TIMED_WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > at > org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:186) > - locked <0x000716820ae0> (a > java.util.concurrent.atomic.AtomicBoolean) > at > org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4443) > at > org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4435) > at > org.apache.hadoop.hbase.client.HBaseAdmin.disableTableAsyncV2(HBaseAdmin.java:1370) > at > org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmin.java:1329) > at > org.apache.hadoop.hbase.HBaseTestingUtility.deleteTable(HBaseTestingUtility.java:1966) > at > org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure.tearDown(TestDisableTableProcedure.java:79) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18216) [AMv2] Workaround for HBASE-18152, corrupt procedure WAL
[ https://issues.apache.org/jira/browse/HBASE-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081522#comment-16081522 ] Andrew Purtell commented on HBASE-18216: I'm reverting this from branch-1.4 and branch-1, see HBASE-18340 > [AMv2] Workaround for HBASE-18152, corrupt procedure WAL > > > Key: HBASE-18216 > URL: https://issues.apache.org/jira/browse/HBASE-18216 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18216.branch-1.001.patch > > > Let me commit workaround for the issue up in HBASE-18152, corruption in the > master wal procedure files. Testing on cluster shows it helps. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18359) CoprocessorHConnection#getConnectionForEnvironment should read config from CoprocessorEnvironment from CoporcessorEnvironment
Samarth Jain created HBASE-18359:
Summary: CoprocessorHConnection#getConnectionForEnvironment should
read config from CoprocessorEnvironment from CoporcessorEnvironment
Key: HBASE-18359
URL: https://issues.apache.org/jira/browse/HBASE-18359
Project: HBase
Issue Type: Bug
Reporter: Samarth Jain
It seems like the method getConnectionForEnvironment isn't doing the right
thing when it is creating a CoprocessorHConnection by reading the config from
HRegionServer and not from the env passed in.
If coprocessors want to use a CoprocessorHConnection with some custom config
settings, then they have no option but to configure it in the hbase-site.xml of
the region servers. This isn't ideal as a lot of times these "global" level
configs can have side effects. See PHOENIX-3974 as an example where configuring
ServerRpcControllerFactory (a Phoenix implementation of RpcControllerFactory)
could result in deadlocks. Or PHOENIX-3983 where presence of this global config
causes our index rebuild code to incorrectly use handlers it shouldn't.
If the CoprocessorHConnection created through getConnectionForEnvironment API
used the CoprocessorEnvironment config, then it would allow co-processors to
pass in their own config without needing to configure them in hbase-site.xml.
The change would be simple. Basically change the below
{code}
if (services instanceof HRegionServer) {
return new CoprocessorHConnection((HRegionServer) services);
}
{code}
to
{code}
if (services instanceof HRegionServer) {
return new CoprocessorHConnection(env.getConfiguration(),
(HRegionServer) services);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18359) CoprocessorHConnection#getConnectionForEnvironment should read config from CoprocessorEnvironment
[
https://issues.apache.org/jira/browse/HBASE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated HBASE-18359:
-
Summary: CoprocessorHConnection#getConnectionForEnvironment should read
config from CoprocessorEnvironment (was:
CoprocessorHConnection#getConnectionForEnvironment should read config from
CoprocessorEnvironment from CoporcessorEnvironment)
> CoprocessorHConnection#getConnectionForEnvironment should read config from
> CoprocessorEnvironment
> -
>
> Key: HBASE-18359
> URL: https://issues.apache.org/jira/browse/HBASE-18359
> Project: HBase
> Issue Type: Bug
>Reporter: Samarth Jain
>
> It seems like the method getConnectionForEnvironment isn't doing the right
> thing when it is creating a CoprocessorHConnection by reading the config from
> HRegionServer and not from the env passed in.
> If coprocessors want to use a CoprocessorHConnection with some custom config
> settings, then they have no option but to configure it in the hbase-site.xml
> of the region servers. This isn't ideal as a lot of times these "global"
> level configs can have side effects. See PHOENIX-3974 as an example where
> configuring ServerRpcControllerFactory (a Phoenix implementation of
> RpcControllerFactory) could result in deadlocks. Or PHOENIX-3983 where
> presence of this global config causes our index rebuild code to incorrectly
> use handlers it shouldn't.
> If the CoprocessorHConnection created through getConnectionForEnvironment API
> used the CoprocessorEnvironment config, then it would allow co-processors to
> pass in their own config without needing to configure them in hbase-site.xml.
> The change would be simple. Basically change the below
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection((HRegionServer) services);
> }
> {code}
> to
> {code}
> if (services instanceof HRegionServer) {
> return new CoprocessorHConnection(env.getConfiguration(),
> (HRegionServer) services);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081515#comment-16081515 ] Anoop Sam John commented on HBASE-18295: LGTM > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18358) Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3
Ted Yu created HBASE-18358:
--
Summary: Backport HBASE-18099 'FlushSnapshotSubprocedure should
wait for concurrent Region#flush() to finish' to branch-1.3
Key: HBASE-18358
URL: https://issues.apache.org/jira/browse/HBASE-18358
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Critical
HBASE-18099 was only integrated to branch-1 and above in consideration of
backward compatibility.
This issue is to backport the fix to branch-1.3 and branch-1.2.
Quoting Gary's suggestion from the tail of HBASE-18099 :
{quote}
Sure, don't add the method to Region, just to HRegion, check for an instance of
HRegion in FlushSnapshotSubprocedure and cast the instance before calling the
method.
{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18330) NPE in ReplicationZKLockCleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081464#comment-16081464
]
Minwoo Kang edited comment on HBASE-18330 at 7/11/17 1:20 AM:
--
Hello~ :)
Yes, In the master branch, however, the ReplicationZKLockCleanerChore code
seems to have disappeared. So I do not know where to patch.
If you can solve it, I think that would be good.
was (Author: minwoo.kang):
Hello~ :)
Yes, In the master branch, however, the ReplicationZKLockCleanerChore code
seems to have disappeared.
So I do not know where to patch.
> NPE in ReplicationZKLockCleanerChore
>
>
> Key: HBASE-18330
> URL: https://issues.apache.org/jira/browse/HBASE-18330
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.5
>Reporter: Minwoo Kang
>Priority: Minor
>
> While I am watching HMaster log, I found NullPointerException Logs.
> This occurs every minute.
>
> 2017-07-06 09:05:02,579 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
> 2017-07-06 09:05:02,585 ERROR [,1498445640728_ChoreService_2]
> hbase.ScheduledChore: Caught error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.cleaner.ReplicationZKLockCleanerChore.chore(ReplicationZKLockCleanerChore.java:80)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:110)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2017-07-06 09:05:02,585 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
> 2017-07-06 09:05:02,586 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
>
> Here is related code:
> List replicators = queues.getListOfReplicators();
> for (String replicator: replicators) {
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18099) FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
[
https://issues.apache.org/jira/browse/HBASE-18099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081476#comment-16081476
]
Ted Yu commented on HBASE-18099:
Opened HBASE-18358 for backport.
Thanks
> FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
> -
>
> Key: HBASE-18099
> URL: https://issues.apache.org/jira/browse/HBASE-18099
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 18099.v1.txt, 18099.v2.txt, 18099.v3.txt, 18099.v4.txt
>
>
> In the following thread:
> http://search-hadoop.com/m/HBase/YGbbMXkeHlI9zo
> Jacob described the scenario where data from certain region were missing in
> the snapshot.
> Here was related region server log:
> https://pastebin.com/1ECXjhRp
> He pointed out that concurrent flush from MemStoreFlusher.1 thread was not
> initiated from the thread pool for snapshot.
> In RegionSnapshotTask#call() method there is this:
> {code}
> region.flush(true);
> {code}
> The return value is not checked.
> In HRegion#flushcache(), Result.CANNOT_FLUSH may be returned due to:
> {code}
> String msg = "Not flushing since "
> + (writestate.flushing ? "already flushing"
> : "writes not enabled");
> {code}
> This implies that FlushSnapshotSubprocedure may incorrectly skip waiting for
> the concurrent flush to complete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18358) Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish' to branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18358:
---
Attachment: 18358.branch-1.3.patch
> Backport HBASE-18099 'FlushSnapshotSubprocedure should wait for concurrent
> Region#flush() to finish' to branch-1.3
> --
>
> Key: HBASE-18358
> URL: https://issues.apache.org/jira/browse/HBASE-18358
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Attachments: 18358.branch-1.3.patch
>
>
> HBASE-18099 was only integrated to branch-1 and above in consideration of
> backward compatibility.
> This issue is to backport the fix to branch-1.3 and branch-1.2.
> Quoting Gary's suggestion from the tail of HBASE-18099 :
> {quote}
> Sure, don't add the method to Region, just to HRegion, check for an instance
> of HRegion in FlushSnapshotSubprocedure and cast the instance before calling
> the method.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18330) NPE in ReplicationZKLockCleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081464#comment-16081464
]
Minwoo Kang commented on HBASE-18330:
-
Hello~ :)
Yes, In the master branch, however, the ReplicationZKLockCleanerChore code
seems to have disappeared.
So I do not know where to patch.
> NPE in ReplicationZKLockCleanerChore
>
>
> Key: HBASE-18330
> URL: https://issues.apache.org/jira/browse/HBASE-18330
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.5
>Reporter: Minwoo Kang
>Priority: Minor
>
> While I am watching HMaster log, I found NullPointerException Logs.
> This occurs every minute.
>
> 2017-07-06 09:05:02,579 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
> 2017-07-06 09:05:02,585 ERROR [,1498445640728_ChoreService_2]
> hbase.ScheduledChore: Caught error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.cleaner.ReplicationZKLockCleanerChore.chore(ReplicationZKLockCleanerChore.java:80)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:110)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2017-07-06 09:05:02,585 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
> 2017-07-06 09:05:02,586 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
>
> Here is related code:
> List replicators = queues.getListOfReplicators();
> for (String replicator: replicators) {
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18330) NPE in ReplicationZKLockCleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081447#comment-16081447
]
Andrew Purtell commented on HBASE-18330:
Are you interested in submitting a patch for this [~minwoo.kang] ?
> NPE in ReplicationZKLockCleanerChore
>
>
> Key: HBASE-18330
> URL: https://issues.apache.org/jira/browse/HBASE-18330
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.5
>Reporter: Minwoo Kang
>Priority: Minor
>
> While I am watching HMaster log, I found NullPointerException Logs.
> This occurs every minute.
>
> 2017-07-06 09:05:02,579 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
> 2017-07-06 09:05:02,585 ERROR [,1498445640728_ChoreService_2]
> hbase.ScheduledChore: Caught error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.cleaner.ReplicationZKLockCleanerChore.chore(ReplicationZKLockCleanerChore.java:80)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:110)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2017-07-06 09:05:02,585 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
> 2017-07-06 09:05:02,586 DEBUG [,1498445640728_ChoreService_1]
> cleaner.CleanerChore: Removing: hdfs://*** from archive
>
> Here is related code:
> List replicators = queues.getListOfReplicators();
> for (String replicator: replicators) {
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18099) FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
[
https://issues.apache.org/jira/browse/HBASE-18099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081448#comment-16081448
]
Gary Helmling commented on HBASE-18099:
---
bq. Is there suggestion on how backward compatibility can be kept ?
Sure, don't add the method to Region, just to HRegion, check for an instance of
HRegion in FlushSnapshotSubprocedure and cast the instance before calling the
method.
This is a critical issue that means that our current snapshot implementation in
1.3 is broken. It doesn't guarantee that all of the data that should be
present in a snapshot is there. I think all of the users of the impacted
versions would be interested in a fix.
> FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
> -
>
> Key: HBASE-18099
> URL: https://issues.apache.org/jira/browse/HBASE-18099
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 18099.v1.txt, 18099.v2.txt, 18099.v3.txt, 18099.v4.txt
>
>
> In the following thread:
> http://search-hadoop.com/m/HBase/YGbbMXkeHlI9zo
> Jacob described the scenario where data from certain region were missing in
> the snapshot.
> Here was related region server log:
> https://pastebin.com/1ECXjhRp
> He pointed out that concurrent flush from MemStoreFlusher.1 thread was not
> initiated from the thread pool for snapshot.
> In RegionSnapshotTask#call() method there is this:
> {code}
> region.flush(true);
> {code}
> The return value is not checked.
> In HRegion#flushcache(), Result.CANNOT_FLUSH may be returned due to:
> {code}
> String msg = "Not flushing since "
> + (writestate.flushing ? "already flushing"
> : "writes not enabled");
> {code}
> This implies that FlushSnapshotSubprocedure may incorrectly skip waiting for
> the concurrent flush to complete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (HBASE-18345) TestCanaryTool fails on branch-1 (branch-1.4)
[ https://issues.apache.org/jira/browse/HBASE-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-18345. Resolution: Cannot Reproduce Fix Version/s: (was: 1.5.0) (was: 1.4.0) Only happened on one dev box of several. I spent about an hour trying to figure the difference and then decided to clear the maven cache. Made no other changes. Test now passes everywhere. > TestCanaryTool fails on branch-1 (branch-1.4) > - > > Key: HBASE-18345 > URL: https://issues.apache.org/jira/browse/HBASE-18345 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell > > Incorrect mocking, easy fix > Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 67.898 sec > <<< FAILURE! - in org.apache.hadoop.hbase.tool.TestCanaryTool > testReadTableTimeouts(org.apache.hadoop.hbase.tool.TestCanaryTool) Time > elapsed: 11.727 sec <<< FAILURE! > org.mockito.exceptions.verification.junit.ArgumentsAreDifferent: > Argument(s) are different! Wanted: > mockAppender.doAppend( > > ); > -> at > org.apache.hadoop.hbase.tool.TestCanaryTool.testReadTableTimeouts(TestCanaryTool.java:150) > Actual invocation has different arguments: > mockAppender.doAppend( > org.apache.log4j.spi.LoggingEvent@7ed49a7f > ); > -> at > org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66) > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:423) > at > org.apache.hadoop.hbase.tool.TestCanaryTool.testReadTableTimeouts(TestCanaryTool.java:150) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18086) Create native client which creates load on selected cluster
[ https://issues.apache.org/jira/browse/HBASE-18086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18086: --- Attachment: 18086.v8.txt Patch v8 adds support for random number of columns. > Create native client which creates load on selected cluster > --- > > Key: HBASE-18086 > URL: https://issues.apache.org/jira/browse/HBASE-18086 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18086.v1.txt, 18086.v3.txt, 18086.v4.txt, 18086.v5.txt, > 18086.v6.txt, 18086.v7.txt, 18086.v8.txt > > > This task is to create a client which uses multiple threads to conduct Puts > followed by Gets against selected cluster. > Default is to run the tool against local cluster. > This would give us some idea on the characteristics of native client in terms > of handling high load. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18099) FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
[
https://issues.apache.org/jira/browse/HBASE-18099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081432#comment-16081432
]
Ted Yu commented on HBASE-18099:
The patch adds waitForFlushes() to Region.
Is there suggestion on how backward compatibility can be kept ?
> FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
> -
>
> Key: HBASE-18099
> URL: https://issues.apache.org/jira/browse/HBASE-18099
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 18099.v1.txt, 18099.v2.txt, 18099.v3.txt, 18099.v4.txt
>
>
> In the following thread:
> http://search-hadoop.com/m/HBase/YGbbMXkeHlI9zo
> Jacob described the scenario where data from certain region were missing in
> the snapshot.
> Here was related region server log:
> https://pastebin.com/1ECXjhRp
> He pointed out that concurrent flush from MemStoreFlusher.1 thread was not
> initiated from the thread pool for snapshot.
> In RegionSnapshotTask#call() method there is this:
> {code}
> region.flush(true);
> {code}
> The return value is not checked.
> In HRegion#flushcache(), Result.CANNOT_FLUSH may be returned due to:
> {code}
> String msg = "Not flushing since "
> + (writestate.flushing ? "already flushing"
> : "writes not enabled");
> {code}
> This implies that FlushSnapshotSubprocedure may incorrectly skip waiting for
> the concurrent flush to complete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18341) Update findHangingTests.py script to match changed consoleText of trunk build
[
https://issues.apache.org/jira/browse/HBASE-18341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081422#comment-16081422
]
Hudson commented on HBASE-18341:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3352 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3352/])
HBASE-18341 (addendum) Replace '.' in test names with '_' when using (appy: rev
7d08c78103792e599b0676c318da1aca54501289)
* (edit) dev-support/flaky-dashboard-template.html
> Update findHangingTests.py script to match changed consoleText of trunk build
> -
>
> Key: HBASE-18341
> URL: https://issues.apache.org/jira/browse/HBASE-18341
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0, 3.0.0
>
> Attachments: patch, patch_addendum
>
>
> consoleText in earlier builds used to report test results as shown below
> {noformat}
> Running org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.753 s - in
> org.apache.hadoop.hbase.client.TestSizeFailures
> {noformat}
> However now we have "[INFO]" / "[WARNING]" in the beginning of lines which
> messed up regex matcher. Updating regex matches to be more general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18099) FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
[
https://issues.apache.org/jira/browse/HBASE-18099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081418#comment-16081418
]
Gary Helmling commented on HBASE-18099:
---
I believe this also impacts 1.3.1, as we were just investigating the same issue
there, and possible also 1.2. Is there a reason this fix was not committed
there as well?
> FlushSnapshotSubprocedure should wait for concurrent Region#flush() to finish
> -
>
> Key: HBASE-18099
> URL: https://issues.apache.org/jira/browse/HBASE-18099
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 18099.v1.txt, 18099.v2.txt, 18099.v3.txt, 18099.v4.txt
>
>
> In the following thread:
> http://search-hadoop.com/m/HBase/YGbbMXkeHlI9zo
> Jacob described the scenario where data from certain region were missing in
> the snapshot.
> Here was related region server log:
> https://pastebin.com/1ECXjhRp
> He pointed out that concurrent flush from MemStoreFlusher.1 thread was not
> initiated from the thread pool for snapshot.
> In RegionSnapshotTask#call() method there is this:
> {code}
> region.flush(true);
> {code}
> The return value is not checked.
> In HRegion#flushcache(), Result.CANNOT_FLUSH may be returned due to:
> {code}
> String msg = "Not flushing since "
> + (writestate.flushing ? "already flushing"
> : "writes not enabled");
> {code}
> This implies that FlushSnapshotSubprocedure may incorrectly skip waiting for
> the concurrent flush to complete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[ https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081353#comment-16081353 ] Amit Patel commented on HBASE-16148: v (Fixed TestIncrementTimeRange that failed in patch above) HLC enabled on just meta table + updating of clocks on region open and region close. Verifying that tests pass. [^HBASE-16148.master.014.patch] > Hybrid Logical Clocks(placeholder for running tests) > > > Key: HBASE-16148 > URL: https://issues.apache.org/jira/browse/HBASE-16148 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: Sai Teja Ranuva >Assignee: Sai Teja Ranuva >Priority: Minor > Labels: test-patch > Attachments: HBASE-16148.master.001.patch, > HBASE-16148.master.002.patch, HBASE-16148.master.003.patch, > HBASE-16148.master.004.patch, HBASE-16148.master.005.patch, > HBASE-16148.master.006.patch, HBASE-16148.master.007.patch, > HBASE-16148.master.008.patch, HBASE-16148.master.009.patch, > HBASE-16148.master.010.patch, HBASE-16148.master.011.patch, > HBASE-16148.master.012.patch, HBASE-16148.master.013.patch, > HBASE-16148.master.014.patch, HBASE-16148.master.6.patch, > HBASE-16148.master.test.1.patch, HBASE-16148.master.test.2.patch, > HBASE-16148.master.test.3.patch, HBASE-16148.master.test.4.patch, > HBASE-16148.master.test.5.patch, HLC.10.1.patch, HLC.10.2.patch, > HLC.10.3.patch, HLC.10.4.patch, HLC.10.5.patch, HLC.10.6.patch, > HLC.10.7.patch, HLC.10.patch, HLC.1.patch, HLC.2.patch, HLC.3.patch, > HLC.4.patch, HLC.5.patch, HLC.6.patch, HLC.8.patch, HLC.9.patch, HLC.patch > > > This JIRA is just a placeholder to test Hybrid Logical Clocks code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[ https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-16148: --- Attachment: HBASE-16148.master.014.patch > Hybrid Logical Clocks(placeholder for running tests) > > > Key: HBASE-16148 > URL: https://issues.apache.org/jira/browse/HBASE-16148 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: Sai Teja Ranuva >Assignee: Sai Teja Ranuva >Priority: Minor > Labels: test-patch > Attachments: HBASE-16148.master.001.patch, > HBASE-16148.master.002.patch, HBASE-16148.master.003.patch, > HBASE-16148.master.004.patch, HBASE-16148.master.005.patch, > HBASE-16148.master.006.patch, HBASE-16148.master.007.patch, > HBASE-16148.master.008.patch, HBASE-16148.master.009.patch, > HBASE-16148.master.010.patch, HBASE-16148.master.011.patch, > HBASE-16148.master.012.patch, HBASE-16148.master.013.patch, > HBASE-16148.master.014.patch, HBASE-16148.master.6.patch, > HBASE-16148.master.test.1.patch, HBASE-16148.master.test.2.patch, > HBASE-16148.master.test.3.patch, HBASE-16148.master.test.4.patch, > HBASE-16148.master.test.5.patch, HLC.10.1.patch, HLC.10.2.patch, > HLC.10.3.patch, HLC.10.4.patch, HLC.10.5.patch, HLC.10.6.patch, > HLC.10.7.patch, HLC.10.patch, HLC.1.patch, HLC.2.patch, HLC.3.patch, > HLC.4.patch, HLC.5.patch, HLC.6.patch, HLC.8.patch, HLC.9.patch, HLC.patch > > > This JIRA is just a placeholder to test Hybrid Logical Clocks code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18278) [AMv2] Enable and fix uni test hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta
[ https://issues.apache.org/jira/browse/HBASE-18278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081333#comment-16081333 ] Umesh Agashe commented on HBASE-18278: -- Hi [~easyliangjob], No idea, this one looks new. I can look into it as I am working in that area. thanks! > [AMv2] Enable and fix uni test > hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta > - > > Key: HBASE-18278 > URL: https://issues.apache.org/jira/browse/HBASE-18278 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-18278.master.001.patch, > HBASE-18278.master.002.patch, HBASE-18278.master.002.patch > > > Enable and fix uni test > hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081271#comment-16081271 ] Xiaobing Zhou edited comment on HBASE-18338 at 7/10/17 10:16 PM: - Posted v1. # learned from wangle RPC example, built a HBase test client and test server and the corresponding client/server handlers. # bridged native hbase::request and hbase::response into Bonk and Xtruct to do easy test Need some work to make it runnable in context of native hbase::request and hbase::response. was (Author: xiaobingo): Posted v1. # learned from wangle RPC example, built an HBase test client and test server and the corresponding client/server handlers. # bridged native hbase::request and hbase::response into Bonk and Xtruct to do easy test Need some work to make it runnable in context of native hbase::request and hbase::response. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081271#comment-16081271 ] Xiaobing Zhou commented on HBASE-18338: --- Posted v1. # learned from wangle RPC example, built an HBase test client and test server and the corresponding client/server handlers. # bridged native hbase::request and hbase::response into Bonk and Xtruct to do easy test Need some work to make it runnable in context of native hbase::request and hbase::response. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081285#comment-16081285 ] Chia-Ping Tsai commented on HBASE-18295: [~anoop.hbase] Ping for reviews. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18278) [AMv2] Enable and fix uni test hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta
[ https://issues.apache.org/jira/browse/HBASE-18278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081292#comment-16081292 ] Yi Liang commented on HBASE-18278: -- Hi [~uagashe] I am doing HBASE-18229 now, and the unit test TestServerCrashProcedure always fail recently(it is good one week ago). And I also try it on local, it always throw errors with TableNotFoundException. Any idea about this? Thanks > [AMv2] Enable and fix uni test > hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta > - > > Key: HBASE-18278 > URL: https://issues.apache.org/jira/browse/HBASE-18278 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-18278.master.001.patch, > HBASE-18278.master.002.patch, HBASE-18278.master.002.patch > > > Enable and fix uni test > hbase.master.procedure.TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081244#comment-16081244
]
Hadoop QA commented on HBASE-18295:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
57s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} branch-1.3 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
52s{color} | {color:red} hbase-server in branch-1.3 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 11s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 82m
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}112m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:9ba21e3 |
| JIRA Issue | HBASE-18295 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876484/HBASE-18295.branch-1.3.v2.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 4a4ae30c9d0c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1.3 / 29e0e73 |
| Default Java | 1.7.0_131 |
|
[jira] [Updated] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HBASE-18338: -- Attachment: HBASE-18338.001.patch > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18061) [C++] Fix retry logic in multi-get calls
[
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081243#comment-16081243
]
Enis Soztutar commented on HBASE-18061:
---
Thanks Sudeep for the updated patch.
Can you please clean up this part:
{code}
if (search != actions_by_server.end()) {
+ // Multiple regions might be hosted on the same server
(ServerName)
+ // Check if a Region is already present in the map or not. If
not add it
+ // auto actions_by_region_name =
search->second->actions_by_region();
+ auto itr =
search->second->actions_by_region().find(region_loc->region_name());
+ if (itr != search->second->actions_by_region().end()) {
search->second->AddActionsByRegion(region_loc, action);
} else {
- // Create new key
+// Create new key for the region location region_loc
+search->second = std::make_shared(region_loc);
+search->second->AddActionsByRegion(region_loc, action);
+// search->second = server_request;
+ }
+} else {
+ // Create new key for this ServerName
{code}
- Can you also cleap up the VLOG's a little bit. We can use VLOG(5) for very
excessive stuff, VLOG(1) for most of the exceptions, and anything in between.
VLOG(8) is too much.
- Please remove all commented out code like this:
{code}
+//#include "connection/request.h"
..
//LOG(INFO) << "tresults size :- " << tresults.size();
{code}
- Did you run bin/format-code.sh and make lint ?
- remove these:
{code}
//TODO This shouldn't be in THROW, but we are getting incorrect RL's at the
moment
{code}
Some of these tests were expected to fail, no?
- You need to enable this test?
{code}
+TEST_F(AsyncBatchRpcRetryTest, TestFailWithException) {
+ std::shared_ptr region_locator(
+ std::make_shared(5));
+ EXPECT_ANY_THROW(runMultiTest(region_locator, "table3"));
+ //TODO will be in EXPECT_ANY_THROW
+ // Not failing.
+ //runMultiTest(region_locator, "table3");
+}
{code}
- Undo this:
{code}
-test_util->StartMiniCluster(2);
+test_util->StartMiniCluster(10);
{code}
- Please go over the patch again, and make sure that there is no commented-out
code lying around.
- This test is good {{+TEST_F(ClientTest, MultiGetsWithRegionSplits)}}, but
there is a lot of code duplication. Maybe move the logic to a method, and call
it from the MutlGets and MultiGetsWithRegionSplits tests.
> [C++] Fix retry logic in multi-get calls
>
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch,
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry
> logic, and some unit testing to be done for the multi-gets. We'll do these in
> this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[
https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081235#comment-16081235
]
Hadoop QA commented on HBASE-16148:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 26 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
8s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
36s{color} | {color:red} hbase-common in master has 2 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
1s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
54s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
50s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 25s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
11s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}121m 6s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
10s{color} | {color:green} The patch does not generate ASF
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[
https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081222#comment-16081222
]
Hadoop QA commented on HBASE-14135:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
6s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 36s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}116m
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-14135 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876474/HBASE-14135-v6.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux f01985501bd3 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7d08c78 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7603/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7603/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7603/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> HBase Backup/Restore Phase 3: Merge backup images
> -
>
> Key: HBASE-14135
> URL: https://issues.apache.org/jira/browse/HBASE-14135
> Project: HBase
> Issue Type: New Feature
>Reporter: Vladimir
[jira] [Commented] (HBASE-17705) Procedure execution must fail fast if procedure is not registered
[ https://issues.apache.org/jira/browse/HBASE-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081091#comment-16081091 ] Hudson commented on HBASE-17705: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3351 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3351/]) HBASE-17705 Procedure execution must fail fast if procedure is not (tedyu: rev 7d007eac98daef8d41ac1d8adf397967fa2919fd) * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestFastFailOnProcedureNotRegistered.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java > Procedure execution must fail fast if procedure is not registered > - > > Key: HBASE-17705 > URL: https://issues.apache.org/jira/browse/HBASE-17705 > Project: HBase > Issue Type: Bug >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-17705.v2.patch, HBASE-17705.v3.patch > > > The issue was discovered during backup testing and described here: > https://issues.apache.org/jira/browse/HBASE-14123?focusedCommentId=15886712=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15886712 > If procedure is not registered, client will be retrying until max attempts > reached. The Master should throw DoNotRetryIOException and client RPC should > handle this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Patch Available (was: Open) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1, 1.3.1, 1.3.0 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Open (was: Patch Available) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1, 1.3.1, 1.3.0 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Attachment: HBASE-18295.branch-1.3.v2.patch > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.3.v2.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v2.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch, > HBASE-18295.v2.patch, HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080945#comment-16080945
]
Hadoop QA commented on HBASE-18295:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
57s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
55s{color} | {color:red} hbase-server in branch-1 has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 0s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}106m 34s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}137m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure |
| | hadoop.hbase.master.procedure.TestCreateNamespaceProcedure |
| | hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | hadoop.hbase.regionserver.TestRSKilledWhenInitializing |
| | hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | hadoop.hbase.client.TestSnapshotWithAcl |
| | hadoop.hbase.master.procedure.TestEnableTableProcedure |
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| |
[jira] [Commented] (HBASE-18344) Replace Append#add(byte[], byte[], byte[]) by Append#addColumn
[
https://issues.apache.org/jira/browse/HBASE-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080919#comment-16080919
]
Hadoop QA commented on HBASE-18344:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 22 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
3s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
7s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
48s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}116m
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
5s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
16s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
2s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}188m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18344 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876311/HBASE-18344.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 68d68b77e718 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Updated] (HBASE-18341) Update findHangingTests.py script to match changed consoleText of trunk build
[
https://issues.apache.org/jira/browse/HBASE-18341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-18341:
-
Attachment: patch_addendum
> Update findHangingTests.py script to match changed consoleText of trunk build
> -
>
> Key: HBASE-18341
> URL: https://issues.apache.org/jira/browse/HBASE-18341
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0, 3.0.0
>
> Attachments: patch, patch_addendum
>
>
> consoleText in earlier builds used to report test results as shown below
> {noformat}
> Running org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.753 s - in
> org.apache.hadoop.hbase.client.TestSizeFailures
> {noformat}
> However now we have "[INFO]" / "[WARNING]" in the beginning of lines which
> messed up regex matcher. Updating regex matches to be more general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[
https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov updated HBASE-14135:
--
Attachment: HBASE-14135-v6.patch
v6 fixes @author and missing test
> HBase Backup/Restore Phase 3: Merge backup images
> -
>
> Key: HBASE-14135
> URL: https://issues.apache.org/jira/browse/HBASE-14135
> Project: HBase
> Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch,
> HBASE-14135-v6.patch
>
>
> User can merge incremental backup images into single incremental backup image.
> # Merge supports only incremental images
> # Merge supports only images for the same backup destinations
> Command:
> {code}
> hbase backup merge image1,image2,..imageK
> {code}
> Example:
> {code}
> hbase backup merge backup_143126764557,backup_143126764456
> {code}
> When operation is complete, only the most recent backup image will be kept
> (in above example - backup_143126764557) as a merged backup image, all other
> images will be deleted from both: file system and backup system tables,
> corresponding backup manifest for the merged backup image will be updated to
> remove dependencies from deleted images. Merged backup image will contains
> all the data from original image and from deleted images.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[ https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080828#comment-16080828 ] Amit Patel edited comment on HBASE-16148 at 7/10/17 6:40 PM: - v HLC enabled on just meta table + updating of clocks on region open and region close. Verifying that tests pass. Still need to write more rigorous integration tests. [^HBASE-16148.master.013.patch] was (Author: amit.patel): v HLC enabled on just meta table + updating of clocks on region open and region close. Verifying that tests pass. Still need to write more rigorous integration tests. > Hybrid Logical Clocks(placeholder for running tests) > > > Key: HBASE-16148 > URL: https://issues.apache.org/jira/browse/HBASE-16148 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: Sai Teja Ranuva >Assignee: Sai Teja Ranuva >Priority: Minor > Labels: test-patch > Attachments: HBASE-16148.master.001.patch, > HBASE-16148.master.002.patch, HBASE-16148.master.003.patch, > HBASE-16148.master.004.patch, HBASE-16148.master.005.patch, > HBASE-16148.master.006.patch, HBASE-16148.master.007.patch, > HBASE-16148.master.008.patch, HBASE-16148.master.009.patch, > HBASE-16148.master.010.patch, HBASE-16148.master.011.patch, > HBASE-16148.master.012.patch, HBASE-16148.master.013.patch, > HBASE-16148.master.6.patch, HBASE-16148.master.test.1.patch, > HBASE-16148.master.test.2.patch, HBASE-16148.master.test.3.patch, > HBASE-16148.master.test.4.patch, HBASE-16148.master.test.5.patch, > HLC.10.1.patch, HLC.10.2.patch, HLC.10.3.patch, HLC.10.4.patch, > HLC.10.5.patch, HLC.10.6.patch, HLC.10.7.patch, HLC.10.patch, HLC.1.patch, > HLC.2.patch, HLC.3.patch, HLC.4.patch, HLC.5.patch, HLC.6.patch, HLC.8.patch, > HLC.9.patch, HLC.patch > > > This JIRA is just a placeholder to test Hybrid Logical Clocks code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[ https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Patel updated HBASE-16148: --- Attachment: HBASE-16148.master.013.patch > Hybrid Logical Clocks(placeholder for running tests) > > > Key: HBASE-16148 > URL: https://issues.apache.org/jira/browse/HBASE-16148 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: Sai Teja Ranuva >Assignee: Sai Teja Ranuva >Priority: Minor > Labels: test-patch > Attachments: HBASE-16148.master.001.patch, > HBASE-16148.master.002.patch, HBASE-16148.master.003.patch, > HBASE-16148.master.004.patch, HBASE-16148.master.005.patch, > HBASE-16148.master.006.patch, HBASE-16148.master.007.patch, > HBASE-16148.master.008.patch, HBASE-16148.master.009.patch, > HBASE-16148.master.010.patch, HBASE-16148.master.011.patch, > HBASE-16148.master.012.patch, HBASE-16148.master.013.patch, > HBASE-16148.master.6.patch, HBASE-16148.master.test.1.patch, > HBASE-16148.master.test.2.patch, HBASE-16148.master.test.3.patch, > HBASE-16148.master.test.4.patch, HBASE-16148.master.test.5.patch, > HLC.10.1.patch, HLC.10.2.patch, HLC.10.3.patch, HLC.10.4.patch, > HLC.10.5.patch, HLC.10.6.patch, HLC.10.7.patch, HLC.10.patch, HLC.1.patch, > HLC.2.patch, HLC.3.patch, HLC.4.patch, HLC.5.patch, HLC.6.patch, HLC.8.patch, > HLC.9.patch, HLC.patch > > > This JIRA is just a placeholder to test Hybrid Logical Clocks code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17908) Upgrade guava
[
https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080874#comment-16080874
]
Hadoop QA commented on HBASE-17908:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
30s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 210 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 12m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 9m
56s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-testing-util hbase-assembly . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
59s{color} | {color:red} hbase-common in master has 2 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
47s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 5m
41s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
2s{color} | {color:red} hbase-rest in master has 3 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 11m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
46s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
6s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 12m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 10m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
47s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
59m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-testing-util hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
22s{color} | {color:green} hbase-common generated 0 new + 0 unchanged - 2 fixed
= 0 total (was 2) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
55s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
42s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color}
[jira] [Resolved] (HBASE-18292) Fix flaky test hbase.master.locking.TestLockProcedure#testLocalMasterLockRecovery()
[ https://issues.apache.org/jira/browse/HBASE-18292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe resolved HBASE-18292. -- Resolution: Fixed TestLockProcedure is slipped off of flaky list for a while now. We can re/open JIRA if it shows up again. > Fix flaky test > hbase.master.locking.TestLockProcedure#testLocalMasterLockRecovery() > --- > > Key: HBASE-18292 > URL: https://issues.apache.org/jira/browse/HBASE-18292 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0-alpha-2 > > Attachments: HBASE-18292.master.001.patch > > > Assert before waitProcedure() assumes that procedure executer is still > running but this assumption is incorrect. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[
https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080866#comment-16080866
]
Hadoop QA commented on HBASE-14135:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
37s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:red}-1{color} | {color:red} @author {color} | {color:red} 0m
0s{color} | {color:red} The patch appears to contain 1 @author tags which the
community has agreed to not allow in code contributions. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
30s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
31s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
30s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 30s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
34s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
4s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
31s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
57s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
23s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
52s{color} | {color:red} The patch causes 44 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m
22s{color} | {color:red} The patch causes 44 errors with Hadoop v2.7.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
50s{color} | {color:red} The patch causes 44 errors with Hadoop v2.7.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 13m
13s{color} | {color:red} The patch causes 44 errors with Hadoop v3.0.0-alpha3.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
28s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
35s{color} | {color:red} hbase-server generated 3 new + 0 unchanged - 0 fixed =
3 total (was 0) {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem ||
[jira] [Commented] (HBASE-16148) Hybrid Logical Clocks(placeholder for running tests)
[ https://issues.apache.org/jira/browse/HBASE-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080828#comment-16080828 ] Amit Patel commented on HBASE-16148: v HLC enabled on just meta table + updating of clocks on region open and region close. Verifying that tests pass. Still need to write more rigorous integration tests. > Hybrid Logical Clocks(placeholder for running tests) > > > Key: HBASE-16148 > URL: https://issues.apache.org/jira/browse/HBASE-16148 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: Sai Teja Ranuva >Assignee: Sai Teja Ranuva >Priority: Minor > Labels: test-patch > Attachments: HBASE-16148.master.001.patch, > HBASE-16148.master.002.patch, HBASE-16148.master.003.patch, > HBASE-16148.master.004.patch, HBASE-16148.master.005.patch, > HBASE-16148.master.006.patch, HBASE-16148.master.007.patch, > HBASE-16148.master.008.patch, HBASE-16148.master.009.patch, > HBASE-16148.master.010.patch, HBASE-16148.master.011.patch, > HBASE-16148.master.012.patch, HBASE-16148.master.6.patch, > HBASE-16148.master.test.1.patch, HBASE-16148.master.test.2.patch, > HBASE-16148.master.test.3.patch, HBASE-16148.master.test.4.patch, > HBASE-16148.master.test.5.patch, HLC.10.1.patch, HLC.10.2.patch, > HLC.10.3.patch, HLC.10.4.patch, HLC.10.5.patch, HLC.10.6.patch, > HLC.10.7.patch, HLC.10.patch, HLC.1.patch, HLC.2.patch, HLC.3.patch, > HLC.4.patch, HLC.5.patch, HLC.6.patch, HLC.8.patch, HLC.9.patch, HLC.patch > > > This JIRA is just a placeholder to test Hybrid Logical Clocks code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18354) Fix TestMasterMetrics that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov reassigned HBASE-18354: - Assignee: Vladimir Rodionov > Fix TestMasterMetrics that were disabled by Proc-V2 AM in HBASE-14614 > - > > Key: HBASE-18354 > URL: https://issues.apache.org/jira/browse/HBASE-18354 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Vladimir Rodionov > > With Core Proc-V2 AM change in HBASE-14614, stuff is different now around > startup which messes up the TestMasterMetrics test. HBASE-14614 disabled two > of three tests. > This JIRA tracks work to fix the disabled tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18349) Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan reassigned HBASE-18349: Assignee: Thiruvel Thirumoolan > Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled > by Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18349 > URL: https://issues.apache.org/jira/browse/HBASE-18349 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > > The following 3 tests in TestFavoredStochasticLoadBalancerwere disabled by > HBASE-14614 (Core Proc-V2 AM): > - testAllFavoredNodesDead > - testAllFavoredNodesDeadMasterRestarted > - testMisplacedRegions > This JIRA is tracking necessary work to re-able (or remove/change if not > applicable) these UTs -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080786#comment-16080786 ] Thiruvel Thirumoolan commented on HBASE-18356: -- Lemme give this a shot this week. > Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by > Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18356 > URL: https://issues.apache.org/jira/browse/HBASE-18356 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > > The testPickers in TestFavoredStochasticBalancerPickers hangs after applying > the change in Core Proc-V2 AM in HBASE-14614. It was disabled. > This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan reassigned HBASE-18356: Assignee: Thiruvel Thirumoolan > Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by > Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18356 > URL: https://issues.apache.org/jira/browse/HBASE-18356 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Thiruvel Thirumoolan > > The testPickers in TestFavoredStochasticBalancerPickers hangs after applying > the change in Core Proc-V2 AM in HBASE-14614. It was disabled. > This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18357) Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18357: -- Summary: Enable disabled tests in TestHCM that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18357 URL: https://issues.apache.org/jira/browse/HBASE-18357 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The Core Proc-V2 AM change in HBASE-14614 disabled two tests inTestHCM: testMulti and testRegionCaching This JIRA tracks the work to enable them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18353) Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov reassigned HBASE-18353: - Assignee: Vladimir Rodionov > Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in > HBASE-14614 > --- > > Key: HBASE-18353 > URL: https://issues.apache.org/jira/browse/HBASE-18353 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang >Assignee: Vladimir Rodionov > > HBASE-14614 disabled TestCorruptedRegionStoreFile, as it depends on a > half-implemented reopen of a region when a store file goes missing. > This JIRA tracks the work to fix/enable the test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[
https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov updated HBASE-14135:
--
Attachment: HBASE-14135-v5.patch
v5 addresses findbugs and formatting.
> HBase Backup/Restore Phase 3: Merge backup images
> -
>
> Key: HBASE-14135
> URL: https://issues.apache.org/jira/browse/HBASE-14135
> Project: HBase
> Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch
>
>
> User can merge incremental backup images into single incremental backup image.
> # Merge supports only incremental images
> # Merge supports only images for the same backup destinations
> Command:
> {code}
> hbase backup merge image1,image2,..imageK
> {code}
> Example:
> {code}
> hbase backup merge backup_143126764557,backup_143126764456
> {code}
> When operation is complete, only the most recent backup image will be kept
> (in above example - backup_143126764557) as a merged backup image, all other
> images will be deleted from both: file system and backup system tables,
> corresponding backup manifest for the merged backup image will be updated to
> remove dependencies from deleted images. Merged backup image will contains
> all the data from original image and from deleted images.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18356) Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18356: -- Summary: Enable TestFavoredStochasticBalancerPickers#testPickers that was disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18356 URL: https://issues.apache.org/jira/browse/HBASE-18356 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The testPickers in TestFavoredStochasticBalancerPickers hangs after applying the change in Core Proc-V2 AM in HBASE-14614. It was disabled. This JIRA tracks the work to enable it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18355) Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18355: -- Summary: Enable export snapshot tests that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18355 URL: https://issues.apache.org/jira/browse/HBASE-18355 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The Proc-V2 AM in HBASE-14614 disabled the following tests: - Disabled TestExportSnapshot Hangs. - Disabled TestSecureExportSnapshot - Disabled TestMobSecureExportSnapshot and TestMobExportSnapshot This JIRA tracks the work to enable them. If MOB requires more work, we could split to 2 tickets. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15631) Backport Regionserver Groups (HBASE-6721) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080745#comment-16080745
]
Andrew Purtell commented on HBASE-15631:
Will fix these here
{quote}
FindBugs
module:hbase-server
Null pointer dereference of regionState in
org.apache.hadoop.hbase.master.HMaster.move(byte[], byte[]) Dereferenced at
HMaster.java:in org.apache.hadoop.hbase.master.HMaster.move(byte[], byte[])
Dereferenced at HMaster.java:[line 1639]
Load of known null value in
org.apache.hadoop.hbase.master.HMaster.move(byte[], byte[]) At HMaster.java:in
org.apache.hadoop.hbase.master.HMaster.move(byte[], byte[]) At
HMaster.java:[line 1639]
{quote}
> Backport Regionserver Groups (HBASE-6721) to branch-1
> --
>
> Key: HBASE-15631
> URL: https://issues.apache.org/jira/browse/HBASE-15631
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 1.4.0
>Reporter: Francis Liu
>Assignee: Francis Liu
> Attachments: HBASE-15631.02.branch-1.patch,
> HBASE-15631_1_branch-1.patch, HBASE-15631.branch-1.1.patch,
> HBASE-15631-branch-1.patch, HBASE-15631.branch-1.patch, HBASE-15631.patch
>
>
> Based on dev list discussion backporting region server group should not be an
> issue as it does not: 1. destabilize the code. 2. cause backward
> incompatibility.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15631) Backport Regionserver Groups (HBASE-6721) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080739#comment-16080739 ] Andrew Purtell commented on HBASE-15631: QA didn't handle cross module changes? > Backport Regionserver Groups (HBASE-6721) to branch-1 > -- > > Key: HBASE-15631 > URL: https://issues.apache.org/jira/browse/HBASE-15631 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.4.0 >Reporter: Francis Liu >Assignee: Francis Liu > Attachments: HBASE-15631.02.branch-1.patch, > HBASE-15631_1_branch-1.patch, HBASE-15631.branch-1.1.patch, > HBASE-15631-branch-1.patch, HBASE-15631.branch-1.patch, HBASE-15631.patch > > > Based on dev list discussion backporting region server group should not be an > issue as it does not: 1. destabilize the code. 2. cause backward > incompatibility. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18352) Enable Replica tests that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Yuan Jiang updated HBASE-18352: --- Description: The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: - Disabled parts of...testCreateTableWithMultipleReplicas in TestMasterOperationsForRegionReplicas There is an issue w/ assigning more replicas if number of replicas is changed on us. See '/* DISABLED! FOR NOW'. - Disabled testRegionReplicasOnMidClusterHighReplication in TestStochasticLoadBalancer2 This JIRA tracks the work to enable them (or modify/remove if not applicable). was: The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: - Disabled parts of...testCreateTableWithMultipleReplicas in TestMasterOperationsForRegionReplicas There is an issue w/ assigning more replicas if number of replicas is changed on us. See '/* DISABLED! FOR NOW'. This JIRA tracks the work to enable them (or modify/remove if not applicable). > Enable Replica tests that were disabled by Proc-V2 AM in HBASE-14614 > > > Key: HBASE-18352 > URL: https://issues.apache.org/jira/browse/HBASE-18352 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang > > The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: > - Disabled parts of...testCreateTableWithMultipleReplicas in > TestMasterOperationsForRegionReplicas There is an issue w/ assigning more > replicas if number of replicas is changed on us. See '/* DISABLED! FOR > NOW'. > - Disabled testRegionReplicasOnMidClusterHighReplication in > TestStochasticLoadBalancer2 > This JIRA tracks the work to enable them (or modify/remove if not applicable). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18223) Track the effort to improve/bug fix read replica feature
[ https://issues.apache.org/jira/browse/HBASE-18223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huaxiang sun reassigned HBASE-18223: Assignee: huaxiang sun > Track the effort to improve/bug fix read replica feature > > > Key: HBASE-18223 > URL: https://issues.apache.org/jira/browse/HBASE-18223 > Project: HBase > Issue Type: Task > Components: Client >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > > During the hbasecon 2017, a group of people met and agreed to collaborate the > effort to improve/bug fix read replica feature so users can enable this > feature in their clusters. This jira is created to track jiras which are > known related with read replica feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18352) Enable Replica tests that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Yuan Jiang updated HBASE-18352: --- Description: The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: - Disabled parts of...testCreateTableWithMultipleReplicas in TestMasterOperationsForRegionReplicas There is an issue w/ assigning more replicas if number of replicas is changed on us. See '/* DISABLED! FOR NOW'. - Disabled testRegionReplicasOnMidClusterHighReplication in TestStochasticLoadBalancer2 - Disabled testFlushAndCompactionsInPrimary in TestRegionReplicas This JIRA tracks the work to enable them (or modify/remove if not applicable). was: The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: - Disabled parts of...testCreateTableWithMultipleReplicas in TestMasterOperationsForRegionReplicas There is an issue w/ assigning more replicas if number of replicas is changed on us. See '/* DISABLED! FOR NOW'. - Disabled testRegionReplicasOnMidClusterHighReplication in TestStochasticLoadBalancer2 This JIRA tracks the work to enable them (or modify/remove if not applicable). > Enable Replica tests that were disabled by Proc-V2 AM in HBASE-14614 > > > Key: HBASE-18352 > URL: https://issues.apache.org/jira/browse/HBASE-18352 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang > > The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: > - Disabled parts of...testCreateTableWithMultipleReplicas in > TestMasterOperationsForRegionReplicas There is an issue w/ assigning more > replicas if number of replicas is changed on us. See '/* DISABLED! FOR > NOW'. > - Disabled testRegionReplicasOnMidClusterHighReplication in > TestStochasticLoadBalancer2 > - Disabled testFlushAndCompactionsInPrimary in TestRegionReplicas > This JIRA tracks the work to enable them (or modify/remove if not applicable). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18350) Enable RSGroups UT that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18350: -- Summary: Enable RSGroups UT that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18350 URL: https://issues.apache.org/jira/browse/HBASE-18350 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614: - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what offline is. - Disabled/Ignore TestRSGroups. This JIRA tracks the work to enable them (or remove/modify if not applicable). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18353) Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18353: -- Summary: Enable TestCorruptedRegionStoreFile that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18353 URL: https://issues.apache.org/jira/browse/HBASE-18353 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang HBASE-14614 disabled TestCorruptedRegionStoreFile, as it depends on a half-implemented reopen of a region when a store file goes missing. This JIRA tracks the work to fix/enable the test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18351) Fix tests that carry meta in Master that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Yuan Jiang updated HBASE-18351: --- Description: The following tests were disabled as part of Core Proc-V2 AM in HBASE-14614 - TestRegionRebalancing is disabled because doesn't consider the fact that Master carries system tables only (fix of average in RegionStates brought out the issue). - Disabled testMetaAddressChange in TestMetaWithReplicas because presumes can move meta... you can't - TestAsyncTableGetMultiThreaded wants to move hbase:meta...Balancer does NPEs. AMv2 won't let you move hbase:meta off Master. - TestMasterFailover needs to be rewritten for AMv2. It uses tricks not ordained when up on AMv2. The test is also hobbled by fact that we religiously enforce that only master can carry meta, something we are lose about in old AM This JIRA is tracking the work to enable/modify them. was: The following tests were disabled as part of Core Proc-V2 AM in HBASE-14614 - TestRegionRebalancing is disabled because doesn't consider the fact that Master carries system tables only (fix of average in RegionStates brought out the issue). - Disabled testMetaAddressChange in TestMetaWithReplicas because presumes can move meta... you can't - TestAsyncTableGetMultiThreaded wants to move hbase:meta...Balancer does NPEs. AMv2 won't let you move hbase:meta off Master. This JIRA is tracking the work to enable/modify them. > Fix tests that carry meta in Master that were disabled by Proc-V2 AM in > HBASE-14614 > --- > > Key: HBASE-18351 > URL: https://issues.apache.org/jira/browse/HBASE-18351 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang > > The following tests were disabled as part of Core Proc-V2 AM in HBASE-14614 > - TestRegionRebalancing is disabled because doesn't consider the fact that > Master carries system tables only (fix of average in RegionStates brought out > the issue). > - Disabled testMetaAddressChange in TestMetaWithReplicas because presumes can > move meta... you can't > - TestAsyncTableGetMultiThreaded wants to move hbase:meta...Balancer does > NPEs. AMv2 won't let you move hbase:meta off Master. > - TestMasterFailover needs to be rewritten for AMv2. It uses tricks not > ordained when up on AMv2. The test is also hobbled by fact that we > religiously enforce that only master can carry meta, something we are lose > about in old AM > This JIRA is tracking the work to enable/modify them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18354) Fix TestMasterMetrics that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18354: -- Summary: Fix TestMasterMetrics that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18354 URL: https://issues.apache.org/jira/browse/HBASE-18354 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang With Core Proc-V2 AM change in HBASE-14614, stuff is different now around startup which messes up the TestMasterMetrics test. HBASE-14614 disabled two of three tests. This JIRA tracks work to fix the disabled tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18352) Enable Replica tests that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18352: -- Summary: Enable Replica tests that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18352 URL: https://issues.apache.org/jira/browse/HBASE-18352 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614: - Disabled parts of...testCreateTableWithMultipleReplicas in TestMasterOperationsForRegionReplicas There is an issue w/ assigning more replicas if number of replicas is changed on us. See '/* DISABLED! FOR NOW'. This JIRA tracks the work to enable them (or modify/remove if not applicable). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18349) Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled by Proc-V2 AM in HBASE-14614
[ https://issues.apache.org/jira/browse/HBASE-18349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Yuan Jiang updated HBASE-18349: --- Summary: Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled by Proc-V2 AM in HBASE-14614 (was: Enable disabled tests in TestFavoredStochasticLoadBalancer that was disabled by Proc-V2 AM in HBASE-14614) > Enable disabled tests in TestFavoredStochasticLoadBalancer that were disabled > by Proc-V2 AM in HBASE-14614 > -- > > Key: HBASE-18349 > URL: https://issues.apache.org/jira/browse/HBASE-18349 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-1 >Reporter: Stephen Yuan Jiang > > The following 3 tests in TestFavoredStochasticLoadBalancerwere disabled by > HBASE-14614 (Core Proc-V2 AM): > - testAllFavoredNodesDead > - testAllFavoredNodesDeadMasterRestarted > - testMisplacedRegions > This JIRA is tracking necessary work to re-able (or remove/change if not > applicable) these UTs -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Open (was: Patch Available) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1, 1.3.1, 1.3.0 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v2.patch, > HBASE-18295.v0.patch, HBASE-18295.v1.patch, HBASE-18295.v2.patch, > HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Attachment: HBASE-18295.branch-1.v2.patch > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v2.patch, > HBASE-18295.v0.patch, HBASE-18295.v1.patch, HBASE-18295.v2.patch, > HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18351) Fix tests that carry meta in Master that were disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18351: -- Summary: Fix tests that carry meta in Master that were disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18351 URL: https://issues.apache.org/jira/browse/HBASE-18351 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The following tests were disabled as part of Core Proc-V2 AM in HBASE-14614 - TestRegionRebalancing is disabled because doesn't consider the fact that Master carries system tables only (fix of average in RegionStates brought out the issue). - Disabled testMetaAddressChange in TestMetaWithReplicas because presumes can move meta... you can't - TestAsyncTableGetMultiThreaded wants to move hbase:meta...Balancer does NPEs. AMv2 won't let you move hbase:meta off Master. This JIRA is tracking the work to enable/modify them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Patch Available (was: Open) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-1, 1.3.1, 1.3.0 >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch, > HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v2.patch, > HBASE-18295.v0.patch, HBASE-18295.v1.patch, HBASE-18295.v2.patch, > HBASE-18295.v2.patch, HBASE-18295.v3.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18349) Enable disabled tests in TestFavoredStochasticLoadBalancer that was disabled by Proc-V2 AM in HBASE-14614
Stephen Yuan Jiang created HBASE-18349: -- Summary: Enable disabled tests in TestFavoredStochasticLoadBalancer that was disabled by Proc-V2 AM in HBASE-14614 Key: HBASE-18349 URL: https://issues.apache.org/jira/browse/HBASE-18349 Project: HBase Issue Type: Bug Components: test Affects Versions: 2.0.0-alpha-1 Reporter: Stephen Yuan Jiang The following 3 tests in TestFavoredStochasticLoadBalancerwere disabled by HBASE-14614 (Core Proc-V2 AM): - testAllFavoredNodesDead - testAllFavoredNodesDeadMasterRestarted - testMisplacedRegions This JIRA is tracking necessary work to re-able (or remove/change if not applicable) these UTs -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080577#comment-16080577
]
Hadoop QA commented on HBASE-18295:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
2s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}118m
24s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}183m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18295 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876411/HBASE-18295.v3.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 2b0db131ca01 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3517034 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7598/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7598/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7598/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> The result contains the cells across different rows
>
>
> Key: HBASE-18295
> URL: https://issues.apache.org/jira/browse/HBASE-18295
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.0, 1.3.1,
[jira] [Commented] (HBASE-12208) Integerating Jacoco code coverage report into the hadoop qa bot
[ https://issues.apache.org/jira/browse/HBASE-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080586#comment-16080586 ] Sean Busbey commented on HBASE-12208: - Yes, this would be a great improvement over the naive test4tests. We used to run jacoco in nightlies, but that stopped working at some point; I suspect the license file on the asf servers moved/evaporated. > Integerating Jacoco code coverage report into the hadoop qa bot > --- > > Key: HBASE-12208 > URL: https://issues.apache.org/jira/browse/HBASE-12208 > Project: HBase > Issue Type: New Feature > Components: test >Affects Versions: 2.0.0 >Reporter: Manukranth Kolloju > Fix For: 2.0.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > HBASE-8936 introduced jacoco code coverage report into the pom, but its > disabled by default. The code coverage tool would help in finding the extent > of code coverage we have in new patches. The hadoop qa bot should be able to > stamp a -1 on diffs that decrease the coverage. This jira is to do the same. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17748) Include HBase Snapshots in Space Quotas
[ https://issues.apache.org/jira/browse/HBASE-17748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080559#comment-16080559 ] Josh Elser commented on HBASE-17748: bq. Just asking. Should we push this to branch-2? We certainly could. I think this is a nice addition to the feature, and fairly low-impact as well. I'm happy to do the cherry-pick if folks think it's a good idea. I wasn't sure how quickly 2.0.0 was going to move, and didn't want to slow things down as I was still working. > Include HBase Snapshots in Space Quotas > --- > > Key: HBASE-17748 > URL: https://issues.apache.org/jira/browse/HBASE-17748 > Project: HBase > Issue Type: Umbrella >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0 > > Attachments: HBASE-17748.001.patch, HBASE-17748.002.patch, > HBASE-17748.003.patch > > > Umbrella issue for the inclusion of HBase Snapshots in the Space Quota > feature (HBASE-16961) > https://docs.google.com/document/d/1f7utThEBYRXYHvp3e5fOhQBv2K1aeuzGHGEfNNE3Clc/edit# > / > https://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase-Snapshots.pdf -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17705) Procedure execution must fail fast if procedure is not registered
[ https://issues.apache.org/jira/browse/HBASE-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-17705: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: (was: 2.0.0) 2.0.0-alpha-2 3.0.0 Status: Resolved (was: Patch Available) Thanks for the patch, Vlad. Thanks for the review, Stack. > Procedure execution must fail fast if procedure is not registered > - > > Key: HBASE-17705 > URL: https://issues.apache.org/jira/browse/HBASE-17705 > Project: HBase > Issue Type: Bug >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-17705.v2.patch, HBASE-17705.v3.patch > > > The issue was discovered during backup testing and described here: > https://issues.apache.org/jira/browse/HBASE-14123?focusedCommentId=15886712=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15886712 > If procedure is not registered, client will be retrying until max attempts > reached. The Master should throw DoNotRetryIOException and client RPC should > handle this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15134) Add visibility into Flush and Compaction queues
[ https://issues.apache.org/jira/browse/HBASE-15134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080585#comment-16080585 ] Sean Busbey commented on HBASE-15134: - Sounds good to me. > Add visibility into Flush and Compaction queues > --- > > Key: HBASE-15134 > URL: https://issues.apache.org/jira/browse/HBASE-15134 > Project: HBase > Issue Type: New Feature > Components: Compaction, metrics, regionserver >Reporter: Elliott Clark >Assignee: Abhishek Singh Chouhan > Fix For: 2.0.0 > > Attachments: HBASE-15134.master.001.patch, > HBASE-15134.master.002.patch, HBASE-15134.patch, HBASE-15134.patch > > > On busy spurts we can see regionservers start to see large queues for > compaction. It's really hard to tell if the server is queueing a lot of > compactions for the same region, lots of compactions for lots of regions, or > just falling behind. > For flushes much the same. There can be flushes in queue that aren't being > run because of delayed flushes. There's no way to know from the metrics how > many flushes are for each region, how many are delayed. Etc. > We should add either more metrics around this ( num per region, max per > region, min per region ) or add on a UI page that has the list of compactions > and flushes. > Or both. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
