[jira] [Commented] (HBASE-16415) Replication in different namespace

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088629#comment-16088629
 ] 

Ted Yu commented on HBASE-16415:


>From populating tableRedirectionsMap, apart from init(), you use utilize the 
>following (see BaseReplicationEndpoint):
{code}
  public void peerConfigUpdated(ReplicationPeerConfig rpc){
{code}

> Replication in different namespace
> --
>
> Key: HBASE-16415
> URL: https://issues.apache.org/jira/browse/HBASE-16415
> Project: HBase
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Christian Guegi
>Assignee: Jan Kunigk
> Attachments: HBASE-16415.patch
>
>
> It would be nice to replicate tables from one namespace to another namespace.
> Example:
> Master cluster, namespace=default, table=bar
> Slave cluster, namespace=dr, table=bar
> Replication happens in class ReplicationSink:
>   public void replicateEntries(List entries, final CellScanner 
> cells, ...){
> ...
> TableName table = 
> TableName.valueOf(entry.getKey().getTableName().toByteArray());
> ...
> addToHashMultiMap(rowMap, table, clusterIds, m);
> ...
> for (Entry> entry : 
> rowMap.entrySet()) {
>   batch(entry.getKey(), entry.getValue().values());
> }
>}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16415) Replication in different namespace

[Jan Kunigk (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088616#comment-16088616
 ] 

Jan Kunigk commented on HBASE-16415:


Hello, sorry for the delay and thanks for the feedback. I have created 
https://reviews.apache.org/r/60896/

With regards to the above questions (not addressed the posting on reviewboard 
yet):

> please move the javadoc starting with...
Changed

> Please add annotation for audience for 
> RedirectingInterClusterReplicationEndpoint (Private).
done

> For redirectEntries(), tableRedirectionsMap is populated. This action can be 
> lifted outside redirectEntries() 
Can you point me to a good place where it should go? Are you thinking to 
override init() with super.init() and populate it in there? The way I 
understand it init may not suffice. The mapping may be changed in between, 
correct? 

> IllegalArgumentException can come from parsing val - adjust message 
> accordingly. This shouldn't be at INFO level.
Agree, changed to LOG.warn



> Replication in different namespace
> --
>
> Key: HBASE-16415
> URL: https://issues.apache.org/jira/browse/HBASE-16415
> Project: HBase
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Christian Guegi
>Assignee: Jan Kunigk
> Attachments: HBASE-16415.patch
>
>
> It would be nice to replicate tables from one namespace to another namespace.
> Example:
> Master cluster, namespace=default, table=bar
> Slave cluster, namespace=dr, table=bar
> Replication happens in class ReplicationSink:
>   public void replicateEntries(List entries, final CellScanner 
> cells, ...){
> ...
> TableName table = 
> TableName.valueOf(entry.getKey().getTableName().toByteArray());
> ...
> addToHashMultiMap(rowMap, table, clusterIds, m);
> ...
> for (Entry> entry : 
> rowMap.entrySet()) {
>   batch(entry.getKey(), entry.getValue().values());
> }
>}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18052) Add document for async admin

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088567#comment-16088567
 ] 

Duo Zhang commented on HBASE-18052:
---

{quote}
One method need you provide a thread pool to use for executing callback
{quote}
One method has one extra thread pool parameter which is used to execute 
callbacks.

{quote}
For `list*` operations, we only accept `Pattern` as the parameter type to match.
{quote}

For `list*` operations, we only accept `Pattern` as the parameter type if you 
want to do regex matching.

No other problems. Fix and then commit!

> Add document for async admin
> 
>
> Key: HBASE-18052
> URL: https://issues.apache.org/jira/browse/HBASE-18052
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18052.master.001.patch, 
> HBASE-18052.master.002.patch, HBASE-18052.master.003.patch, 
> HBASE-18052.master.004.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)