[jira] [Commented] (HBASE-18650) HBase replication Master-Master model issue
[
https://issues.apache.org/jira/browse/HBASE-18650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137943#comment-16137943
]
cuizhaohua commented on HBASE-18650:
Before I am enable replication, I put about ten recored in cluster 1, but only
one is different when I run "hbase
org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication clusterID
repliTest" after I am setting master-master model .
I am not sure ,but I guess the code below in VerifyReplication.java is the
reason , when scan source cluster with timestamp and check sink cluster with
"scan.setStartRow(value.getRow());
scan.setStopRow(tableSplit.getEndRow()); "
+++
HConnectionManager.execute(new HConnectable(conf) {
@Override
public Void connect(HConnection conn) throws IOException {
String zkClusterKey = conf.get(NAME + ".peerQuorumAddress");
Configuration peerConf = HBaseConfiguration.create(conf);
ZKUtil.applyClusterKeyToConf(peerConf, zkClusterKey);
TableName tableName = TableName.valueOf(conf.get(NAME +
".tableName"));
replicatedTable = new HTable(peerConf, tableName);
scan.setStartRow(value.getRow());
scan.setStopRow(tableSplit.getEndRow());
replicatedScanner = replicatedTable.getScanner(scan);
return null;
}
});
> HBase replication Master-Master model issue
> -
>
> Key: HBASE-18650
> URL: https://issues.apache.org/jira/browse/HBASE-18650
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Affects Versions: 1.1.6
>Reporter: cuizhaohua
>Priority: Minor
>
> When I use HBase replication with Master-Master model, install like below:
> 1> with cluster 1 I create table "repliTest", and put some data on it .
> 2> after about 6 month, I have cluster 2 ,and install master-master model
> with two cluster.
> 3> I put cluster 1 some data and It replication to cluster 2, it's correct.
> 4> I put cluster 2 some data and it replication to cluster 1, It's correct
> also.
> 5> The issue is : when I run command
> "hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication
> clusterID repliTest "on each cluster.
> the result is different :
> on cluster 1 the result is
>
> org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters
> BADROWS=33
> GOODROWS=20
> ONLY_IN_PEER_TABLE_ROWS=4
> ONLY_IN_SOURCE_TABLE_ROWS=29
> on cluster 2 the result is:
>
> org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters
> BADROWS=32
> GOODROWS=20
> ONLY_IN_PEER_TABLE_ROWS=28
> ONLY_IN_SOURCE_TABLE_ROWS=4
> It means one record is lost on cluster 2 verifierreplication . I check the
> table and get the recode is one recode I have put it 6 month ago.
> I delete this record like this:
> hbase(main):017:0> delete 'repliTest','3','score:english'
> and after that, when I run hbase verifyreplication is also correct on
> every cluster.
> environment :
> HBase 1.16
> hdfs 2.7.1
> ps: I am not good at english ,sorry about that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18658) Purge hokey hbase Service implementation; use (internal) Guava Service instead
[ https://issues.apache.org/jira/browse/HBASE-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137935#comment-16137935 ] Anoop Sam John commented on HBASE-18658: +1 > Purge hokey hbase Service implementation; use (internal) Guava Service instead > -- > > Key: HBASE-18658 > URL: https://issues.apache.org/jira/browse/HBASE-18658 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18658.master.001.patch, > HBASE-18658.master.002.patch > > > Purge useless hbase Service class. Having it around only confuses. Purge it > here because we thought it might be of use fixing parent issue but it only > confused the issue. And now it is safe to use Guava Service with its nice > supporting facility (including ServiceManager for running many at a time). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18658) Purge hokey hbase Service implementation; use (internal) Guava Service instead
[ https://issues.apache.org/jira/browse/HBASE-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137922#comment-16137922 ] stack commented on HBASE-18658: --- .002 addresses [~anoop.hbase] feedback up in rb. > Purge hokey hbase Service implementation; use (internal) Guava Service instead > -- > > Key: HBASE-18658 > URL: https://issues.apache.org/jira/browse/HBASE-18658 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18658.master.001.patch, > HBASE-18658.master.002.patch > > > Purge useless hbase Service class. Having it around only confuses. Purge it > here because we thought it might be of use fixing parent issue but it only > confused the issue. And now it is safe to use Guava Service with its nice > supporting facility (including ServiceManager for running many at a time). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18658) Purge hokey hbase Service implementation; use (internal) Guava Service instead
[ https://issues.apache.org/jira/browse/HBASE-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18658: -- Attachment: HBASE-18658.master.002.patch > Purge hokey hbase Service implementation; use (internal) Guava Service instead > -- > > Key: HBASE-18658 > URL: https://issues.apache.org/jira/browse/HBASE-18658 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18658.master.001.patch, > HBASE-18658.master.002.patch > > > Purge useless hbase Service class. Having it around only confuses. Purge it > here because we thought it might be of use fixing parent issue but it only > confused the issue. And now it is safe to use Guava Service with its nice > supporting facility (including ServiceManager for running many at a time). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18448) EndPoint example for refreshing HFiles for stores
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137918#comment-16137918 ] Anoop Sam John edited comment on HBASE-18448 at 8/23/17 5:36 AM: - bq.getNumHFilesForRS Here getting #files from all the online regions. There might be other table regions also in this RS. So we need check the table name for that region and then only get files# from Store. Else patch LGTM was (Author: anoop.hbase): bq.getNumHFilesForRS Here getting #files from all the online regions. There might be other table regions also in this RS. So we need check the table name for that region and then only get files# from Store. > EndPoint example for refreshing HFiles for stores > -- > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) EndPoint example for refreshing HFiles for stores
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137918#comment-16137918 ] Anoop Sam John commented on HBASE-18448: bq.getNumHFilesForRS Here getting #files from all the online regions. There might be other table regions also in this RS. So we need check the table name for that region and then only get files# from Store. > EndPoint example for refreshing HFiles for stores > -- > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) EndPoint example for refreshing HFiles for stores
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18448: --- Summary: EndPoint example for refreshing HFiles for stores (was: Added support for refreshing HFiles through API and shell) > EndPoint example for refreshing HFiles for stores > -- > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) EndPoint example for refreshing HFiles for stores
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18448: --- Component/s: Coprocessors > EndPoint example for refreshing HFiles for stores > -- > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18508) [HLC] Fix timing out tests in HBASE-14070.HLC branch
[ https://issues.apache.org/jira/browse/HBASE-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18508: - Resolution: Resolved Fix Version/s: HBASE-14070 Status: Resolved (was: Patch Available) > [HLC] Fix timing out tests in HBASE-14070.HLC branch > > > Key: HBASE-18508 > URL: https://issues.apache.org/jira/browse/HBASE-18508 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Amit Patel > Fix For: HBASE-14070 > > Attachments: > 0001-HBASE-18508-empty-patch-added-new-line-in-TestClockW.patch, > HBASE-18508.HBASE-14070.HLC.001.patch, HBASE-18508.HBASE-14070.HLC.002.patch, > HBASE-18508.HBASE-14070.HLC.003.patch, HBASE-18508.HBASE-14070.HLC.003.patch, > HBASE-18508.HBASE-14070.HLC.004.patch, HBASE-18508.HBASE-14070.HLC.005.patch, > HBASE-18508.HBASE-14070.HLC.006.patch > > > Pre-commit runs for this branch output a huge list of timed out tests. Not > seeing those in master branch. > Needs to be fixed before merging. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18508) [HLC] Fix timing out tests in HBASE-14070.HLC branch
[ https://issues.apache.org/jira/browse/HBASE-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137913#comment-16137913 ] Appy commented on HBASE-18508: -- [~stack] merged the master branch into HBASE-14070.HLC after the [fix went in|https://github.com/apache/hbase/commit/05f07f692bf572be0829904d2b4ab48bbd611dde]. [Latest Hadoop QA run|https://issues.apache.org/jira/browse/HBASE-18509?focusedCommentId=16137879=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16137879] of HBASE-14070.HLC branch didn't have any timed out tests, so closing this one out as obsolete. > [HLC] Fix timing out tests in HBASE-14070.HLC branch > > > Key: HBASE-18508 > URL: https://issues.apache.org/jira/browse/HBASE-18508 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Amit Patel > Attachments: > 0001-HBASE-18508-empty-patch-added-new-line-in-TestClockW.patch, > HBASE-18508.HBASE-14070.HLC.001.patch, HBASE-18508.HBASE-14070.HLC.002.patch, > HBASE-18508.HBASE-14070.HLC.003.patch, HBASE-18508.HBASE-14070.HLC.003.patch, > HBASE-18508.HBASE-14070.HLC.004.patch, HBASE-18508.HBASE-14070.HLC.005.patch, > HBASE-18508.HBASE-14070.HLC.006.patch > > > Pre-commit runs for this branch output a huge list of timed out tests. Not > seeing those in master branch. > Needs to be fixed before merging. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-10504) Define Replication Interface
[ https://issues.apache.org/jira/browse/HBASE-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137649#comment-16137649 ] stack edited comment on HBASE-10504 at 8/23/17 5:22 AM: What we going to do here? ReplicationEndpoint is broken in hbase-2.0 so if we want to mess with Replication Interfaces, now is the time. [~gabriel.reid] if you are listening or [~whoschek], looking at the SEP implementation, it is broke for hbase2. The use of internal Admin protocols and expectation that our protobuf is at com.google.protobuf no longer holds. Lets figure this out lads. was (Author: stack): What we going to do here? ReplicationEndpoint is broken in hbase-2.0 so if we want to mess with Replication Interfaces, now is the time. > Define Replication Interface > > > Key: HBASE-10504 > URL: https://issues.apache.org/jira/browse/HBASE-10504 > Project: HBase > Issue Type: Task > Components: Replication >Reporter: stack >Assignee: Enis Soztutar >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: hbase-10504_v1.patch, hbase-10504_wip1.patch > > > HBase has replication. Fellas have been hijacking the replication apis to do > all kinds of perverse stuff like indexing hbase content (hbase-indexer > https://github.com/NGDATA/hbase-indexer) and our [~toffer] just showed up w/ > overrides that replicate via an alternate channel (over a secure thrift > channel between dcs over on HBASE-9360). This issue is about surfacing these > APIs as public with guarantees to downstreamers similar to those we have on > our public client-facing APIs (and so we don't break them for downstreamers). > Any input [~phunt] or [~gabriel.reid] or [~toffer]? > Thanks. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18661) [HLC] Move clocks to a separate hbase-clocks module
Appy created HBASE-18661: Summary: [HLC] Move clocks to a separate hbase-clocks module Key: HBASE-18661 URL: https://issues.apache.org/jira/browse/HBASE-18661 Project: HBase Issue Type: Sub-task Reporter: Appy Assignee: Appy I think we can move all clocks related code out of h-common and h-server into a new package which only needs to depend on h-shaded-protocol. If it's possible, I think it'll be much cleaner code layout and dependency structure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-18509:
-
Description:
Track all types of cleanups here:
- (done in 001.patch) --Rename classes to more consistent naming: SystemClock,
SystemMonotonicClock, HybridLogicalClock--
- (done in 001.patch) --Move implementations out from Clock interface. It's a
simple interface of 6 fns but very overloaded right now with everything put
inside it.--
- (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new
class. Then RSServices can just have getClocks() function.--
{noformat}
class Clocks {
// all 3 types of clocks.
// Fns:
- update(ClockType, timestamp)
- updateAll(List\)
- int64 now(ClockType)
- List\ nowAll()
}
{noformat}
was:
Track all types of cleanups here:
- (done in 001.patch) --Rename classes to more consistent naming: SystemClock,
SystemMonotonicClock, HybridLogicalClock--
- (done in 001.patch) --Move implementations out from Clock interface. It's a
simple interface of 6 fns but very overloaded right now with everything put
inside it.--
- Move to separate module/package/both
- Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
can just have getClocks() function.
{noformat}
class Clocks {
// all 3 types of clocks.
// Fns:
- update(ClockType, timestamp)
- updateAll(List\)
- int64 now(ClockType)
- List\ nowAll()
}
{noformat}
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new
> class. Then RSServices can just have getClocks() function.--
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137906#comment-16137906
]
Appy commented on HBASE-18509:
--
There's one more action item remaining - split out clocks in separate package.
But we can do it in another jira.
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[
https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137898#comment-16137898
]
Hadoop QA commented on HBASE-18448:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
0m 34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}115m
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
0s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}169m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18448 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883243/HBASE-18448.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile cc hbaseprotoc |
| uname | Linux 4a022b1418aa 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3be5e8c |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8251/testReport/ |
[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world
[ https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137888#comment-16137888 ] stack commented on HBASE-18105: --- [~easyliangjob] Thank you for digging in. I like your reasoning on why an HRI has SPLIT in it. The alternative would be a new column in hbase:meta that had state in it. We already have info:splitA, info:splitB, info:mergeA, and info:mergeB columns which are probably badly named now I look at them but marking a parent region as split in a column in hbase:meta would go w/ our writing of splitA and splitB as hbase:meta columns better than setting flag in HRI. File a TODO I'd say? In this issue, add your nice reasoning as a comment on the split method? (i thought we were putting region state already -- i.e. OPENING, OPEN -- into hbase:meta but I was wrong -- we just update locations as region goes through its stages). bq. Overall, there are still some places in split and merge needs to be cleaned up. What you thinking [~easyliangjob]? Thanks for doing this great cleanup. > [AMv2] Split/Merge need cleanup; currently they diverge and do not fully > embrace AMv2 world > --- > > Key: HBASE-18105 > URL: https://issues.apache.org/jira/browse/HBASE-18105 > Project: HBase > Issue Type: Sub-task > Components: Region Assignment >Affects Versions: 2.0.0 >Reporter: stack > Fix For: 2.0.0 > > > Region Split and Merge work on the new AMv2 but they work differently. This > issue is about bringing them back together and fully embracing the AMv2 > program. > They both have issues mostly the fact that they carry around baggage no > longer necessary in the new world of assignment. > Here are some of the items: > Split and Merge metadata modifications are done by the Master now but we have > vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master > which asks the RS, which turns around, and asks the Master to run the > operation. Fun. MERGE is all done Master-side. > > Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, > etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up > on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able > to detect when split, but have it be a client of Master like anyone else. > Split is Async but does not return procId > Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard > part here I think is the Admin API does not allow procid return. > Flags > Currently OFFLINE is determined by looking either at the master instance of > HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, > we rely on RegionState#state. Related is a note above on how split works -- > there is a split flag in HTD when there should not be. > > TODO is move to rely on RegionState#state exclusively in Master. > From Split/Merge Procedures need finishing in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137881#comment-16137881 ] Hudson commented on HBASE-12349: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3580 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3580/]) HBASE-12349 Add custom error-prone module (mdrob: rev 51d458872d703acdd853dd7b3149794d585ba285) * (edit) hbase-common/pom.xml * (add) hbase-build-support/hbase-error-prone/pom.xml * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-resource-bundle/pom.xml * (edit) hbase-client/pom.xml * (edit) hbase-shaded/pom.xml * (edit) hbase-spark-it/pom.xml * (edit) hbase-testing-util/pom.xml * (add) hbase-build-support/pom.xml * (edit) hbase-rsgroup/pom.xml * (edit) hbase-rest/pom.xml * (edit) hbase-spark/pom.xml * (edit) hbase-examples/pom.xml * (edit) hbase-hadoop-compat/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-prefix-tree/pom.xml * (edit) hbase-endpoint/pom.xml * (edit) hbase-protocol-shaded/pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-assembly/pom.xml * (edit) hbase-hadoop2-compat/pom.xml * (add) hbase-build-support/hbase-error-prone/src/main/java/org/apache/hadoop/hbase/errorprone/AlwaysPasses.java * (edit) hbase-protocol/pom.xml * (edit) hbase-shell/pom.xml * (edit) hbase-annotations/pom.xml * (edit) pom.xml * (edit) hbase-procedure/pom.xml * (add) hbase-build-configuration/pom.xml * (edit) hbase-it/pom.xml * (edit) hbase-metrics/pom.xml * (edit) hbase-assembly/src/main/assembly/src.xml * (edit) hbase-metrics-api/pom.xml * (edit) hbase-archetypes/pom.xml > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18658) Purge hokey hbase Service implementation; use (internal) Guava Service instead
[ https://issues.apache.org/jira/browse/HBASE-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18658: -- Hadoop Flags: Reviewed Status: Patch Available (was: Open) > Purge hokey hbase Service implementation; use (internal) Guava Service instead > -- > > Key: HBASE-18658 > URL: https://issues.apache.org/jira/browse/HBASE-18658 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18658.master.001.patch > > > Purge useless hbase Service class. Having it around only confuses. Purge it > here because we thought it might be of use fixing parent issue but it only > confused the issue. And now it is safe to use Guava Service with its nice > supporting facility (including ServiceManager for running many at a time). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137882#comment-16137882
]
Hudson commented on HBASE-18614:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3580 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3580/])
HBASE-18614 Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on
(tedyu: rev 3be5e8ce00d04d31ee8109e51eb02864e67e4286)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java
> Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
> --
>
> Key: HBASE-18614
> URL: https://issues.apache.org/jira/browse/HBASE-18614
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18614-1.1.2.PATCH, HBASE-18614.PATCH,
> HBASE-18614-V1.0.PATCH, HBASE-18614-V2.0.PATCH
>
>
> Enabling offheap cache and setting {{BUCKET_CACHE_COMBINED_KEY}} to {{false}}
> in site xml to make offheap cache a strict L2 cache to LRU cache, disables
> the L2 stats normally rendered on region server UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137879#comment-16137879
]
Hadoop QA commented on HBASE-18509:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
44s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
52s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 88m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestRegionSplitPolicy |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18509 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883235/HBASE-18509.HBASE-14070.HLC.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux ea9f15865698 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | HBASE-14070.HLC / 4e7c55d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8253/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8253/testReport/
[jira] [Updated] (HBASE-18655) TestAsyncClusterAdminApi2 failing sometimes
[
https://issues.apache.org/jira/browse/HBASE-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-18655:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.0.0-alpha-3
Status: Resolved (was: Patch Available)
Pushed to master and branch-2. Thanks for review and the legwork [~mdrob]
pinpointing cause of failure.
> TestAsyncClusterAdminApi2 failing sometimes
> ---
>
> Key: HBASE-18655
> URL: https://issues.apache.org/jira/browse/HBASE-18655
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Mike Drob
>Assignee: stack
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18655.master.001.patch
>
>
> Investigating a test failure seen on HBASE-12349
> git bisect shows me the following:
> {noformat}
> # first bad commit: [473446719b7b81b56216862bf2a94a576ff90f60] HBASE-18511
> Default no regions on master
> {noformat}
> It wouldn't fail every time, but I used this command with the bisect
> {noformat}
> export OPTS='test
> -Dtest=org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 -pl
> hbase-server -am'
> mvn clean $OPTS && mvn $OPTS && mvn $OPTS && mvn $OPTS
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18575) [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on master
[ https://issues.apache.org/jira/browse/HBASE-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18575: -- Attachment: hbase-18575.master.001.patch Retry. Doubt this patch responsible for all the failures. > [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on > master > > > Key: HBASE-18575 > URL: https://issues.apache.org/jira/browse/HBASE-18575 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18575.master.001.patch, > hbase-18575.master.001.patch > > > * Test creates 3 node cluster (master + 2 RS) and creates 3 tables with 1 > region each. > * It then takes a snapshot of region assignments > * Shuts down the cluster and restarts with 4 nodes (2 RS on same ports, 1 RS > on port where master was running previously and master on new port) > * Takes snapshot of region assignments > * Expected behavior is regions will be retained on RS with appropriate ports > Debugging done so far shows that, when cluster is restarted meta is loaded > but meta has old entries (though the ports are same for RSs, start timestamps > are different). AssignmentManager#processofflineServersWithOnlineRegions() > finds that old RS with different timestamps are not online even though > regions assigned to them are online; triggering submitting SCP for each those > RSs. Subprocedure AssignProcedure of SCP has forceNewPlan set to true. Which > triggers re-assignment of regions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18659) Use HDFS ACL to give user the ability to read snapshot directly on HDFS
[
https://issues.apache.org/jira/browse/HBASE-18659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137863#comment-16137863
]
stack commented on HBASE-18659:
---
[~apurtell] See above sir.
> Use HDFS ACL to give user the ability to read snapshot directly on HDFS
> ---
>
> Key: HBASE-18659
> URL: https://issues.apache.org/jira/browse/HBASE-18659
> Project: HBase
> Issue Type: New Feature
>Reporter: Duo Zhang
>
> On the dev meetup notes in Shenzhen after HBaseCon Asia, there is a topic
> about the permission to read hfiles on HDFS directly.
> {quote}
> For client-side scanner going against hfiles directly; is there a means of
> being able to pass the permissions from hbase to hdfs?
> {quote}
> And at Xiaomi we also face the same problem. {{SnapshotScanner}} is much
> faster and consumes less resources, but only super use has the ability to
> read hfile directly on HDFS.
> So here we want to use HDFS ACL to address this problem.
> https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsPermissionsGuide.html#ACLs_File_System_API
> The basic idea is to set acl and default on the table directory on HDFS for
> the users who have the permission to read the table on HBase.
> Suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
[ https://issues.apache.org/jira/browse/HBASE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18660: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.0 Status: Resolved (was: Patch Available) Pushed to branch-2 and master branch. Thanks for patch [~Yun Zhao] > Remove duplicate code from the checkAndPut method in HTable > --- > > Key: HBASE-18660 > URL: https://issues.apache.org/jira/browse/HBASE-18660 > Project: HBase > Issue Type: Task >Reporter: Yun Zhao >Assignee: Yun Zhao >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-18660.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137856#comment-16137856
]
stack commented on HBASE-18509:
---
Let me know if I should not have resolved this patch, if there is more cleanup
to do [~amit.patel] Thanks.
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-18509:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed .004 to HBASE-14070.HLC branch. Thanks [~amit.patel]
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
[
https://issues.apache.org/jira/browse/HBASE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137852#comment-16137852
]
Hadoop QA commented on HBASE-18660:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 22s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
23s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18660 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883252/HBASE-18660.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 6cc6751ac8bb 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3be5e8c |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8254/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8254/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove duplicate code from the checkAndPut method in HTable
> ---
>
> Key: HBASE-18660
> URL: https://issues.apache.org/jira/browse/HBASE-18660
> Project: HBase
> Issue Type: Task
>Reporter: Yun Zhao
>
[jira] [Updated] (HBASE-18224) Upgrade jetty
[ https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18224: -- Attachment: HBASE-18224.master.002.patch > Upgrade jetty > - > > Key: HBASE-18224 > URL: https://issues.apache.org/jira/browse/HBASE-18224 > Project: HBase > Issue Type: Improvement > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18224.branch-2.001 (1).patch, > HBASE-18224.branch-2.001.patch, HBASE-18224.branch-2.002 (1).patch, > HBASE-18224.branch-2.002.patch, HBASE-18224.branch-2.003.patch, > HBASE-18224.master.001.patch, HBASE-18224.master.002.patch, > HBASE-18224.master.003.patch > > > Jetty can be updated to 9.4.6 and thrift can be updated to 0.10.0. I tried to > update them in HBASE-17898 but some unit tests failed, so created a sub-task > for them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18224) Upgrade jetty
[ https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137850#comment-16137850 ] stack commented on HBASE-18224: --- .002 Fix other locations where we hard-code threads to 10. > Upgrade jetty > - > > Key: HBASE-18224 > URL: https://issues.apache.org/jira/browse/HBASE-18224 > Project: HBase > Issue Type: Improvement > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18224.branch-2.001 (1).patch, > HBASE-18224.branch-2.001.patch, HBASE-18224.branch-2.002 (1).patch, > HBASE-18224.branch-2.002.patch, HBASE-18224.branch-2.003.patch, > HBASE-18224.master.001.patch, HBASE-18224.master.002.patch, > HBASE-18224.master.003.patch > > > Jetty can be updated to 9.4.6 and thrift can be updated to 0.10.0. I tried to > update them in HBASE-17898 but some unit tests failed, so created a sub-task > for them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18224) Upgrade jetty
[ https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18224: -- Attachment: HBASE-18224.master.003.patch > Upgrade jetty > - > > Key: HBASE-18224 > URL: https://issues.apache.org/jira/browse/HBASE-18224 > Project: HBase > Issue Type: Improvement > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18224.branch-2.001 (1).patch, > HBASE-18224.branch-2.001.patch, HBASE-18224.branch-2.002 (1).patch, > HBASE-18224.branch-2.002.patch, HBASE-18224.branch-2.003.patch, > HBASE-18224.master.001.patch, HBASE-18224.master.002.patch, > HBASE-18224.master.003.patch > > > Jetty can be updated to 9.4.6 and thrift can be updated to 0.10.0. I tried to > update them in HBASE-17898 but some unit tests failed, so created a sub-task > for them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137847#comment-16137847
]
Hudson commented on HBASE-18614:
FAILURE: Integrated in Jenkins build HBase-2.0 #379 (See
[https://builds.apache.org/job/HBase-2.0/379/])
HBASE-18614 Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on
(tedyu: rev 28909b8f13a73a0c318a33e8b4641ecdffc71692)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
> Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
> --
>
> Key: HBASE-18614
> URL: https://issues.apache.org/jira/browse/HBASE-18614
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18614-1.1.2.PATCH, HBASE-18614.PATCH,
> HBASE-18614-V1.0.PATCH, HBASE-18614-V2.0.PATCH
>
>
> Enabling offheap cache and setting {{BUCKET_CACHE_COMBINED_KEY}} to {{false}}
> in site xml to make offheap cache a strict L2 cache to LRU cache, disables
> the L2 stats normally rendered on region server UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137845#comment-16137845 ] stack commented on HBASE-18640: --- Yeah, I ask same up on rb review about hbase-mapreduce-util Whats in hbase-mapreduce-util? I see OutputFormats, Map & Reduce Tasks, Partitioners, Record Readers, a little Util... Should it be called hbase-mapreduce? Or hbase-mapreduce-core. You have to include this ? If so, core? It looks like you might be able to do hbase-related MR work w/ core w/o having an hbase instance up for some of these jobs -- or not all need to communicate with a running hbase instance? Whats in hbase-mapreduce currently? InputFormats that depend on running being able to get at a running hbase and the MR tests. Call it hbase-mapreduce-cluster hbase-mapreduce-runtime (where runtime signifies you need a running hbase up for most of the included tasks and utils to work) or hbase-mapreduce-client where client here is client of a running hbase instance? BTW, there are two Driver classes, one in hbase-mapreduce-util and other in hbase-mapreduce? One is mapred and other is mapreduce. Can both be in same module? > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18640.master.001.patch, > HBASE-18640.master.002.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.005.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137838#comment-16137838 ] Josh Elser commented on HBASE-17614: bq. Edit: Basically, copy the block out of hbase-server/pom.xml in both cases, and you'll be good to go. Thanks for the tl;dr ;) bq. Suggest getting a clean run on jenkins and then commit. Thanks, Stack. I'll pick this up tmrw morning and do whatever is needed from your last re-attach. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137829#comment-16137829 ] stack commented on HBASE-17614: --- Where: stack@ve0524:~/hbase.git/hbase-backup$ uname -a Linux ve0524 3.13.0-83-generic #127-Ubuntu SMP Fri Mar 11 00:25:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux stack@ve0524:~/hbase.git/hbase-backup$ more /etc/issue Ubuntu 14.04.4 LTS \n \l How: 2709 mvn clean install -DskipTests 2710 cd hbase-backup/ 2712 mvn test -PrunAllTests We haven't purge the timeouts from build box yet but I do notice that in the set of failures there are these: TestBackupLogCleaner ... distinct from the Timedout tests. Let me retry. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
[ https://issues.apache.org/jira/browse/HBASE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137833#comment-16137833 ] stack commented on HBASE-18660: --- +1 Waiting on hadoopqa run. > Remove duplicate code from the checkAndPut method in HTable > --- > > Key: HBASE-18660 > URL: https://issues.apache.org/jira/browse/HBASE-18660 > Project: HBase > Issue Type: Task >Reporter: Yun Zhao >Assignee: Yun Zhao >Priority: Trivial > Attachments: HBASE-18660.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18532) Improve cache related stats rendered on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137832#comment-16137832
]
Hadoop QA commented on HBASE-18532:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 10s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}130m
41s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-external-blockcache in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}183m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18532 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883232/HBASE-18532-V2.0.PATCH
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 87fc47273440 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 51d4588 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3
[jira] [Updated] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17614: -- Attachment: HBASE-17614-v5.patch > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
[ https://issues.apache.org/jira/browse/HBASE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Zhao reassigned HBASE-18660: Assignee: Yun Zhao > Remove duplicate code from the checkAndPut method in HTable > --- > > Key: HBASE-18660 > URL: https://issues.apache.org/jira/browse/HBASE-18660 > Project: HBase > Issue Type: Task >Reporter: Yun Zhao >Assignee: Yun Zhao >Priority: Trivial > Attachments: HBASE-18660.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
[ https://issues.apache.org/jira/browse/HBASE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Zhao updated HBASE-18660: - Status: Patch Available (was: Open) Simple code refactoring > Remove duplicate code from the checkAndPut method in HTable > --- > > Key: HBASE-18660 > URL: https://issues.apache.org/jira/browse/HBASE-18660 > Project: HBase > Issue Type: Task >Reporter: Yun Zhao >Assignee: Yun Zhao >Priority: Trivial > Attachments: HBASE-18660.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
[ https://issues.apache.org/jira/browse/HBASE-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Zhao updated HBASE-18660: - Attachment: HBASE-18660.master.001.patch > Remove duplicate code from the checkAndPut method in HTable > --- > > Key: HBASE-18660 > URL: https://issues.apache.org/jira/browse/HBASE-18660 > Project: HBase > Issue Type: Task >Reporter: Yun Zhao >Assignee: Yun Zhao >Priority: Trivial > Attachments: HBASE-18660.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18660) Remove duplicate code from the checkAndPut method in HTable
Yun Zhao created HBASE-18660: Summary: Remove duplicate code from the checkAndPut method in HTable Key: HBASE-18660 URL: https://issues.apache.org/jira/browse/HBASE-18660 Project: HBase Issue Type: Task Reporter: Yun Zhao Priority: Trivial -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137809#comment-16137809
]
Hadoop QA commented on HBASE-18614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 13s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 85m 39s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}136m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
| | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanAll |
| | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.trace.TestHTraceHooks |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncTableBatch |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi |
| | org.apache.hadoop.hbase.mapreduce.TestCellCounter |
| | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanRenewLease |
| |
[jira] [Updated] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Patel updated HBASE-18509:
---
Status: Patch Available (was: In Progress)
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17442) Move most of the replication related classes to hbase-server package
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137793#comment-16137793
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-17442 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-17442 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883247/HBASE-17442.master.004.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8252/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move most of the replication related classes to hbase-server package
>
>
> Key: HBASE-17442
> URL: https://issues.apache.org/jira/browse/HBASE-17442
> Project: HBase
> Issue Type: Sub-task
> Components: build, Replication
>Affects Versions: 2.0.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Critical
> Fix For: 2.0.0-alpha-3
>
> Attachments: 0001-hbase-replication-module.patch,
> HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch,
> HBASE-17442.master.001.patch, HBASE-17442.master.002.patch,
> HBASE-17442.master.003.patch, HBASE-17442.master.004.patch,
> HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch,
> HBASE-17442.v3.patch
>
>
> After the replication requests are routed through master, replication
> implementation details didn't need be exposed to client. We should move most
> of the replication related classes to hbase-server package.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18659) Use HDFS ACL to give user the ability to read snapshot directly on HDFS
Duo Zhang created HBASE-18659:
-
Summary: Use HDFS ACL to give user the ability to read snapshot
directly on HDFS
Key: HBASE-18659
URL: https://issues.apache.org/jira/browse/HBASE-18659
Project: HBase
Issue Type: New Feature
Reporter: Duo Zhang
On the dev meetup notes in Shenzhen after HBaseCon Asia, there is a topic about
the permission to read hfiles on HDFS directly.
{quote}
For client-side scanner going against hfiles directly; is there a means of
being able to pass the permissions from hbase to hdfs?
{quote}
And at Xiaomi we also face the same problem. {{SnapshotScanner}} is much faster
and consumes less resources, but only super use has the ability to read hfile
directly on HDFS.
So here we want to use HDFS ACL to address this problem.
https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsPermissionsGuide.html#ACLs_File_System_API
The basic idea is to set acl and default on the table directory on HDFS for the
users who have the permission to read the table on HBase.
Suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137788#comment-16137788 ] Appy commented on HBASE-18640: -- [~Apache9] Always up for better names :). Suggest please. > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18640.master.001.patch, > HBASE-18640.master.002.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.005.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17442: - Attachment: (was: HBASE-17442.master.002.patch) > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.v1.patch, HBASE-17442.v2.patch, > HBASE-17442.v2.patch, HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17442: - Attachment: (was: HBASE-17442.master.002.patch) > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.v1.patch, HBASE-17442.v2.patch, > HBASE-17442.v2.patch, HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17442: - Attachment: (was: HBASE-17442.master.002.patch) > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.v1.patch, HBASE-17442.v2.patch, > HBASE-17442.v2.patch, HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17442: - Attachment: (was: HBASE-17442.master.001.patch) > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.v1.patch, HBASE-17442.v2.patch, > HBASE-17442.v2.patch, HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17442: - Attachment: HBASE-17442.master.004.patch > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.master.004.patch, > HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch, > HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17442: - Attachment: (was: HBASE-17442.master.003.patch) > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.v1.patch, HBASE-17442.v2.patch, > HBASE-17442.v2.patch, HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17442) Move most of the replication related classes to hbase-server package
[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137789#comment-16137789 ] Appy commented on HBASE-17442: -- Finally! Wohooo! Please help with the pom.xml [~stack]. Uploading on RB. Thanks. > Move most of the replication related classes to hbase-server package > > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication >Affects Versions: 2.0.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.branch-2.001.patch, HBASE-17442.branch-2.001.patch, > HBASE-17442.master.001.patch, HBASE-17442.master.001.patch, > HBASE-17442.master.002.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.002.patch, HBASE-17442.master.002.patch, > HBASE-17442.master.003.patch, HBASE-17442.master.003.patch, > HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch, > HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137771#comment-16137771
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 58 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
13s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
52m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}177m
25s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 15s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 6s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
49s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}426m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.backup.master.TestBackupLogCleaner |
| | hadoop.hbase.backup.master.TestBackupLogCleaner |
| Timed out junit tests |
[jira] [Commented] (HBASE-18575) [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on master
[
https://issues.apache.org/jira/browse/HBASE-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137767#comment-16137767
]
Hadoop QA commented on HBASE-18575:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 9 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
30s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 34s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
36s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}152m 7s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
| | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanAll |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|
[jira] [Resolved] (HBASE-18204) [C++] Rpc connection close and reconnecting
[ https://issues.apache.org/jira/browse/HBASE-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar resolved HBASE-18204. --- Resolution: Fixed Fix Version/s: HBASE-14850 > [C++] Rpc connection close and reconnecting > --- > > Key: HBASE-18204 > URL: https://issues.apache.org/jira/browse/HBASE-18204 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18204_v1.patch, hbase-18204_v2.patch, > hbase-18204_v3.patch, hbase-18204_v4.patch, hbase-18204-v5.patch > > > Our client-dispatcher maintains a map of outgoing RPCs per server with the > promises. > In case the server goes down, or TCP connection is closed, we should complete > the outgoing RPCs with exceptions so that higher level waiters can unblock > and retry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18204) [C++] Rpc connection close and reconnecting
[ https://issues.apache.org/jira/browse/HBASE-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-18204: -- Attachment: hbase-18204-v5.patch v5 patch. Addresses the reviews as we have discussed with Xiaobing offline, and fixes some of the issues in the prev patches. Will commit this one. > [C++] Rpc connection close and reconnecting > --- > > Key: HBASE-18204 > URL: https://issues.apache.org/jira/browse/HBASE-18204 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18204_v1.patch, hbase-18204_v2.patch, > hbase-18204_v3.patch, hbase-18204_v4.patch, hbase-18204-v5.patch > > > Our client-dispatcher maintains a map of outgoing RPCs per server with the > promises. > In case the server goes down, or TCP connection is closed, we should complete > the outgoing RPCs with exceptions so that higher level waiters can unblock > and retry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18655) TestAsyncClusterAdminApi2 failing sometimes
[
https://issues.apache.org/jira/browse/HBASE-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137754#comment-16137754
]
Hadoop QA commented on HBASE-18655:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}104m
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18655 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883213/HBASE-18655.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux a3609896f2fe 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 51d4588 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8245/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8245/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> TestAsyncClusterAdminApi2 failing sometimes
> ---
>
> Key: HBASE-18655
> URL: https://issues.apache.org/jira/browse/HBASE-18655
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Mike Drob
>Assignee: stack
> Attachments: HBASE-18655.master.001.patch
>
>
> Investigating a test failure seen on HBASE-12349
> git bisect shows
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Status: Patch Available (was: Open) > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.3.1, 2.0.0 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Attachment: HBASE-18448.master.002.patch > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18448) Added support for refreshing HFiles through API and shell
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-18448: Status: Open (was: Patch Available) > Added support for refreshing HFiles through API and shell > - > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.3.1, 2.0.0 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18224) Upgrade jetty
[
https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137751#comment-16137751
]
Hadoop QA commented on HBASE-18224:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
51s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 8s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 32m 53s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.http.TestSpnegoHttpServer |
| | hadoop.hbase.http.TestSSLHttpServer |
| | hadoop.hbase.http.TestSpnegoHttpServer |
| | hadoop.hbase.http.TestSSLHttpServer |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18224 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883216/HBASE-18224.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile xml |
| uname | Linux 09fb04d6782b 3.13.0-117-generic #164-Ubuntu
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137746#comment-16137746 ] Duo Zhang commented on HBASE-18640: --- So here, hbase-server will only depend on hbase-client, so we can eliminate the yarn related dependencies? Good. And hbase-mapreduce-util will not depend on hbase-server, and hbase-mapreduce will depend on all of the three modules? Looks good. My only concerns is the naming. hbase-mapreduce-util is a bit confusing to me. Why should the user depend on mapreduce-util instead of mapreduce when he/she wants to use mapreduce on HBase? Thanks. > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-18640.master.001.patch, > HBASE-18640.master.002.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.005.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17442) Move most of the replication related classes to hbase-server package
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137742#comment-16137742
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
8s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
22s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
5s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
34s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
11s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
40s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}144m
54s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}336m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17442 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-15982) Interface ReplicationEndpoint extends Guava's Service
[
https://issues.apache.org/jira/browse/HBASE-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137741#comment-16137741
]
Hadoop QA commented on HBASE-15982:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}151m 19s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}202m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
| | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
| |
hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-15982 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883193/HBASE-15982.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 8b404cc5012a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 51d4588 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8244/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8244/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8244/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Interface ReplicationEndpoint extends Guava's Service
>
[jira] [Commented] (HBASE-18658) Purge hokey hbase Service implementation; use (internal) Guava Service instead
[ https://issues.apache.org/jira/browse/HBASE-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137735#comment-16137735 ] Duo Zhang commented on HBASE-18658: --- +1. > Purge hokey hbase Service implementation; use (internal) Guava Service instead > -- > > Key: HBASE-18658 > URL: https://issues.apache.org/jira/browse/HBASE-18658 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18658.master.001.patch > > > Purge useless hbase Service class. Having it around only confuses. Purge it > here because we thought it might be of use fixing parent issue but it only > confused the issue. And now it is safe to use Guava Service with its nice > supporting facility (including ServiceManager for running many at a time). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18653) Undo hbase2 check against < hadoop2.6.x; i.e. implement agreed drop of hadoop 2.4 and 2.5 support in hbase2
[ https://issues.apache.org/jira/browse/HBASE-18653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137732#comment-16137732 ] Duo Zhang commented on HBASE-18653: --- +1. > Undo hbase2 check against < hadoop2.6.x; i.e. implement agreed drop of hadoop > 2.4 and 2.5 support in hbase2 > --- > > Key: HBASE-18653 > URL: https://issues.apache.org/jira/browse/HBASE-18653 > Project: HBase > Issue Type: Task > Components: build >Reporter: stack >Assignee: stack > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18653.branch-2.001.patch > > > Our hbase2 build is currently doing hadoop 2.4 and 2.5 checks. > In this discussion thread on dev, "[DISCUSS] Drop legacy hadoop support at > the 2.0 release" [1], we decided to not support hadoop 2.4/2.5 in hbase2. > This issue is about updating our build profile > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Drop-legacy-hadoop-support-at-the-2-0-release-td4083550.html#a4083554 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137721#comment-16137721
]
Ted Yu commented on HBASE-18614:
On branch-1, I got the following when running TestBlockCacheReporting :
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-hadoop2-compat: Compilation failure
[ERROR]
/Users/tyu/1-hbase/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java:[35,7]
error: cannot access MetricRegistryInfo
{code}
> Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
> --
>
> Key: HBASE-18614
> URL: https://issues.apache.org/jira/browse/HBASE-18614
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18614-1.1.2.PATCH, HBASE-18614.PATCH,
> HBASE-18614-V1.0.PATCH, HBASE-18614-V2.0.PATCH
>
>
> Enabling offheap cache and setting {{BUCKET_CACHE_COMBINED_KEY}} to {{false}}
> in site xml to make offheap cache a strict L2 cache to LRU cache, disables
> the L2 stats normally rendered on region server UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18655) TestAsyncClusterAdminApi2 failing sometimes
[
https://issues.apache.org/jira/browse/HBASE-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137707#comment-16137707
]
Mike Drob commented on HBASE-18655:
---
+1. Verified the tests passing as well.
> TestAsyncClusterAdminApi2 failing sometimes
> ---
>
> Key: HBASE-18655
> URL: https://issues.apache.org/jira/browse/HBASE-18655
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Mike Drob
>Assignee: stack
> Attachments: HBASE-18655.master.001.patch
>
>
> Investigating a test failure seen on HBASE-12349
> git bisect shows me the following:
> {noformat}
> # first bad commit: [473446719b7b81b56216862bf2a94a576ff90f60] HBASE-18511
> Default no regions on master
> {noformat}
> It wouldn't fail every time, but I used this command with the bisect
> {noformat}
> export OPTS='test
> -Dtest=org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 -pl
> hbase-server -am'
> mvn clean $OPTS && mvn $OPTS && mvn $OPTS && mvn $OPTS
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18614:
---
Hadoop Flags: Reviewed
Fix Version/s: 2.0.0-alpha-3
3.0.0
> Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
> --
>
> Key: HBASE-18614
> URL: https://issues.apache.org/jira/browse/HBASE-18614
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18614-1.1.2.PATCH, HBASE-18614.PATCH,
> HBASE-18614-V1.0.PATCH, HBASE-18614-V2.0.PATCH
>
>
> Enabling offheap cache and setting {{BUCKET_CACHE_COMBINED_KEY}} to {{false}}
> in site xml to make offheap cache a strict L2 cache to LRU cache, disables
> the L2 stats normally rendered on region server UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137705#comment-16137705
]
Vladimir Rodionov commented on HBASE-17614:
---
[~stack], how do you run tests? and where?
All test pass locally on my MBP.
The command I ran:
{code}
time mvn clean package -Dtest=org.apache.hadoop.hbase.backup.*
{code}
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137703#comment-16137703
]
Mike Drob edited comment on HBASE-17614 at 8/23/17 1:01 AM:
bq. Mike Drob, you all-clear now? Or should I still tread lightly on branch-2
to avoid smacking you?
Nah, do whatever. Master you'll want parent to be {{hbase-build-configuration}}
and branch-2 you'll want {{hbase}}, but you will need to adjust for version in
the pom.xml anyway, so it's not like you were getting a clean backport. If
error-prone ends up getting backported to branch-2 (I keep waffling back and
forth on this) then I'll deal with the conflicts then, you shouldn't have to
worry about making less work for me at this point.
Edit: Basically, copy the {{}} block out of hbase-server/pom.xml in
both cases, and you'll be good to go.
was (Author: mdrob):
bq. Mike Drob, you all-clear now? Or should I still tread lightly on branch-2
to avoid smacking you?
Nah, do whatever. Master you'll want parent to be {{hbase-build-configuration}}
and branch-2 you'll want {{hbase}}, but you will need to adjust for version in
the pom.xml anyway, so it's not like you were getting a clean backport. If
error-prone ends up getting backported to branch-2 (I keep waffling back and
forth on this) then I'll deal with the conflicts then, you shouldn't have to
worry about making less work for me at this point.
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137703#comment-16137703
]
Mike Drob commented on HBASE-17614:
---
bq. Mike Drob, you all-clear now? Or should I still tread lightly on branch-2
to avoid smacking you?
Nah, do whatever. Master you'll want parent to be {{hbase-build-configuration}}
and branch-2 you'll want {{hbase}}, but you will need to adjust for version in
the pom.xml anyway, so it's not like you were getting a clean backport. If
error-prone ends up getting backported to branch-2 (I keep waffling back and
forth on this) then I'll deal with the conflicts then, you shouldn't have to
worry about making less work for me at this point.
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Patel updated HBASE-18509:
---
Attachment: HBASE-18509.HBASE-14070.HLC.004.patch
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18448) Added support for refreshing HFiles through API and shell
[
https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137687#comment-16137687
]
Hadoop QA commented on HBASE-18448:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
17s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
14s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 14s{color} |
{color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 14s{color}
| {color:red} hbase-examples in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
22s{color} | {color:red} The patch causes 22 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
46s{color} | {color:red} The patch causes 22 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
7s{color} | {color:red} The patch causes 22 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m
32s{color} | {color:red} The patch causes 22 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
39s{color} | {color:red} The patch causes 22 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 13m
40s{color} | {color:red} The patch causes 22 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 15m
54s{color} | {color:red} The patch causes 22 errors with Hadoop v2.7.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m
8s{color} | {color:red} The patch causes 22 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 20m
20s{color} | {color:red} The patch causes 22 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m
15s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
18s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
18s{color} | {color:red} hbase-examples generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}159m
[jira] [Updated] (HBASE-18532) Improve cache related stats rendered on RS UI
[ https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair updated HBASE-18532: -- Attachment: HBASE-18532-V2.0.PATCH Re-attaching the patch. > Improve cache related stats rendered on RS UI > - > > Key: HBASE-18532 > URL: https://issues.apache.org/jira/browse/HBASE-18532 > Project: HBase > Issue Type: Improvement > Components: regionserver, UI >Affects Versions: 1.1.2 >Reporter: Biju Nair >Assignee: Biju Nair > Attachments: COMBINED-STATS.PNG, HBASE-18532-1.1.2.PATCH, > HBASE-18532.PATCH, HBASE-18532-V1.0.PATCH, HBASE-18532-V2.0.PATCH, > L1-STATS.PNG, L2-STATS.PNG > > > The stats currently rendered for L1 and L2 cache are incorrect. Refer to the > attached screenshots of stats from a cluster showing the combined cache > stats, L1 stats and L2 stats. For e.g. the combined stats shows 38 GB used > for cache while if we sum size of L1 and L2 cache the value is way less. One > way we can improve this is to use the same stats used to populate the > combined stats to render the values of L1 & L2 cache. Also for usability we > can remove the table with details with BucketCache buckets from the L2 cache > stats since this is going to be long for any installation using L2 cache. > This will help in understanding the cache usage better. Thoughts? If there > are no concerns will submit a patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18532) Improve cache related stats rendered on RS UI
[ https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair updated HBASE-18532: -- Attachment: (was: HBASE-18532-V2.0.PATCH) > Improve cache related stats rendered on RS UI > - > > Key: HBASE-18532 > URL: https://issues.apache.org/jira/browse/HBASE-18532 > Project: HBase > Issue Type: Improvement > Components: regionserver, UI >Affects Versions: 1.1.2 >Reporter: Biju Nair >Assignee: Biju Nair > Attachments: COMBINED-STATS.PNG, HBASE-18532-1.1.2.PATCH, > HBASE-18532.PATCH, HBASE-18532-V1.0.PATCH, L1-STATS.PNG, L2-STATS.PNG > > > The stats currently rendered for L1 and L2 cache are incorrect. Refer to the > attached screenshots of stats from a cluster showing the combined cache > stats, L1 stats and L2 stats. For e.g. the combined stats shows 38 GB used > for cache while if we sum size of L1 and L2 cache the value is way less. One > way we can improve this is to use the same stats used to populate the > combined stats to render the values of L1 & L2 cache. Also for usability we > can remove the table with details with BucketCache buckets from the L2 cache > stats since this is going to be long for any installation using L2 cache. > This will help in understanding the cache usage better. Thoughts? If there > are no concerns will submit a patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Biju Nair updated HBASE-18614:
--
Attachment: HBASE-18614-V2.0.PATCH
Attaching updated patch after rebase.
> Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
> --
>
> Key: HBASE-18614
> URL: https://issues.apache.org/jira/browse/HBASE-18614
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Attachments: HBASE-18614-1.1.2.PATCH, HBASE-18614.PATCH,
> HBASE-18614-V1.0.PATCH, HBASE-18614-V2.0.PATCH
>
>
> Enabling offheap cache and setting {{BUCKET_CACHE_COMBINED_KEY}} to {{false}}
> in site xml to make offheap cache a strict L2 cache to LRU cache, disables
> the L2 stats normally rendered on region server UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18624) Added support for clearing BlockCache
[
https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137662#comment-16137662
]
Hadoop QA commented on HBASE-18624:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 16m
6s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
30s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
0s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
38s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
11s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} hbase-protocol in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
14s{color} | {color:green} hbase-client in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
11s{color} | {color:green} hbase-shell in the patch passed with JDK v1.8.0_144.
{color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s{color}
| {color:red} hbase-server-jdk1.7.0_131 with JDK v1.7.0_131 generated 1 new + 4
unchanged - 6 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 9m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
10s{color} | {color:red} The patch generated 9 new + 825 unchanged - 3 fixed =
834 total (was 828) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 4 new + 655 unchanged - 0 fixed =
659 total (was 655) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 20s{color} | {color:green} The patch
[jira] [Comment Edited] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world
[
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137660#comment-16137660
]
Yi Liang edited comment on HBASE-18105 at 8/23/17 12:20 AM:
Hi [~stack]
I just do some investigation in the code, When split successful, it will
1.set its region state as SPLIT and 2. set HRI.split=true, and then put
serialized version of the HRegionInfo into META table. But for merge, it will
only set regionstate as MERGE, and not put HRI to META.
I think the reason is that after split, meta and HDFS will still contain
references to the parent region, so we need to keep this parent region, and
mark it as split in HRI. However after merge, we just delete the two merged
regions, they are not useful anymore, all info move to the the new region. I
think that is the reason why they keep transition state in the HRI, and there
is only SPLIT and no MERGE.
{quote}HRI should be read-only for life of the Region?{quote}
Yes, HRI should be immutable, and in split, current code will copy the
parent HRI and set HRI.split=true and then put into META
Overall, there are still some places in split and merge needs to be cleaned up.
was (Author: easyliangjob):
Hi [~stack]
I just do some investigation in the code, When split successful, it will
1.set its region state as SPLIT and 2. set HRI.split=true, and then put
serialized version of the HRegionInfo into META table. But for merge, it will
only set regionstate as MERGE, and not put HRI to META.
I think the reason is that after split, meta and HDFS will still contain
references to the parent region, so we need to keep this parent region, and
mark it as split in HRI. However after merge, we just delete the two merged
regions, they are not useful anymore, all info move to the the new region. I
think that is the reason why they keep transition state in the HRI, and there
is only SPLIT and no MERGE.
{quote}HRI should be read-only for life of the Region?{quote}
Yes, HRI should be immutable, and in split, current code will copy the
parent HRI and set HRI.split=true and then put.
Overall, there are still some places in split and merge needs to be cleaned up.
> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
> Issue Type: Sub-task
> Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
> Fix For: 2.0.0
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This
> issue is about bringing them back together and fully embracing the AMv2
> program.
> They both have issues mostly the fact that they carry around baggage no
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master
> which asks the RS, which turns around, and asks the Master to run the
> operation. Fun. MERGE is all done Master-side.
>
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest,
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE,
> we rely on RegionState#state. Related is a note above on how split works --
> there is a split flag in HTD when there should not be.
>
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world
[
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137660#comment-16137660
]
Yi Liang commented on HBASE-18105:
--
Hi [~stack]
I just do some investigation in the code, When split successful, it will
1.set its region state as SPLIT and 2. set HRI.split=true, and then put
serialized version of the HRegionInfo into META table. But for merge, it will
only set regionstate as MERGE, and not put HRI to META.
I think the reason is that after split, meta and HDFS will still contain
references to the parent region, so we need to keep this parent region, and
mark it as split in HRI. However after merge, we just delete the two merged
regions, they are not useful anymore, all info move to the the new region. I
think that is the reason why they keep transition state in the HRI, and there
is only SPLIT and no MERGE.
{quote}HRI should be read-only for life of the Region?{quote}
Yes, HRI should be immutable, and in split, current code will copy the
parent HRI and set HRI.split=true and then put.
Overall, there are still some places in split and merge needs to be cleaned up.
> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
> Issue Type: Sub-task
> Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
> Fix For: 2.0.0
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This
> issue is about bringing them back together and fully embracing the AMv2
> program.
> They both have issues mostly the fact that they carry around baggage no
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master
> which asks the RS, which turns around, and asks the Master to run the
> operation. Fun. MERGE is all done Master-side.
>
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest,
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE,
> we rely on RegionState#state. Related is a note above on how split works --
> there is a split flag in HTD when there should not be.
>
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15982) Interface ReplicationEndpoint extends Guava's Service
[
https://issues.apache.org/jira/browse/HBASE-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137657#comment-16137657
]
stack commented on HBASE-15982:
---
HBASE-10504 is the replication redo JIRA. It is an oldie that has stalled. Its
a big job. Trying to revive it. Might be best to just commit this as is and
attack HBASE-10504 separately.
> Interface ReplicationEndpoint extends Guava's Service
> -
>
> Key: HBASE-15982
> URL: https://issues.apache.org/jira/browse/HBASE-15982
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-15982.master.001.patch,
> HBASE-15982.master.002.patch, HBASE-15982.master.003.patch
>
>
> We have Guava's Service leaking into the LimitedPrivate interface
> ReplicationEndpoint:
> {code}
> public interface ReplicationEndpoint extends Service,
> ReplicationPeerConfigListener
> {code}
> This required a private patch when I updated Guava for our internal
> deployments. This is going to be a problem for us for long term maintenance
> and implenters of pluggable replication endpoints. LP is only less than
> public by a degree. We shouldn't leak types from third part code into either
> Public or LP APIs in my opinion. Let's fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137654#comment-16137654
]
stack commented on HBASE-17614:
---
Ran again:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.backup.TestBackupHFileCleaner
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.127 sec - in
org.apache.hadoop.hbase.backup.TestBackupHFileCleaner
Running org.apache.hadoop.hbase.backup.TestBackupCommandLineTool
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - in
org.apache.hadoop.hbase.backup.TestBackupCommandLineTool
Results :
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-surefire-plugin:2.19.1:test (secondPartTestsExecution) @
hbase-backup ---
---
T E S T S
---
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable
Running org.apache.hadoop.hbase.backup.TestBackupDescribe
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures
Running org.apache.hadoop.hbase.backup.TestFullBackupSet
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 518.986 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
Time elapsed: 516.534 sec <<< FAILURE!
java.lang.AssertionError
at
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:93)
Running org.apache.hadoop.hbase.backup.TestBackupRepair
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 553.194 sec -
in org.apache.hadoop.hbase.backup.TestBackupDescribe
Running org.apache.hadoop.hbase.backup.TestRemoteRestore
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 602.338 sec -
in org.apache.hadoop.hbase.backup.TestFullBackupSet
Running org.apache.hadoop.hbase.backup.TestBackupShowHistory
Running org.apache.hadoop.hbase.backup.TestFullBackup
Running org.apache.hadoop.hbase.backup.TestRemoteBackup
Running org.apache.hadoop.hbase.backup.TestBackupStatusProgress
Running org.apache.hadoop.hbase.backup.TestIncrementalBackup
Running org.apache.hadoop.hbase.backup.TestBackupMultipleDeletes
Running org.apache.hadoop.hbase.backup.TestBackupBoundaryTests
Running org.apache.hadoop.hbase.backup.TestFullRestore
Running org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete
Running org.apache.hadoop.hbase.backup.TestBackupDeleteRestore
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad
Running org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests
Running org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures
Running org.apache.hadoop.hbase.backup.TestBackupDelete
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures
Running org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet
Running org.apache.hadoop.hbase.backup.TestFullBackupWithFailures
Results :
Failed tests:
TestBackupLogCleaner.testBackupLogCleaner:93
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 20:08.911s
[INFO] Finished at: Tue Aug 22 17:09:44 PDT 2017
[INFO] Final Memory: 43M/1779M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test
(secondPartTestsExecution) on project hbase-backup: ExecutionException The
forked VM terminated without properly saying goodbye. VM crash or System.exit
called?
[ERROR] Command was /bin/sh -c cd /home/stack/hbase.git/hbase-backup &&
/home/stack/bin/jdk1.8.0_101/jre/bin/java -enableassertions
-Dhbase.build.id=2017-08-22T16:49:35Z -Xmx2800m
-Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true
-Djava.awt.headless=true -jar
/home/stack/hbase.git/hbase-backup/target/surefire/surefirebooter3260628695888461598.jar
/home/stack/hbase.git/hbase-backup/target/surefire/surefire6421378557322491102tmp
/home/stack/hbase.git/hbase-backup/target/surefire/surefire_326873114336621816595tmp
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
{code}
> Move Backup/Restore into separate
[jira] [Updated] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-17614: -- Attachment: HBASE-17614-v5.patch v5 adds log4j.properties file to backup module resources folder > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137651#comment-16137651 ] Vladimir Rodionov edited comment on HBASE-17614 at 8/23/17 12:16 AM: - v5 adds log4j.properties file to backup module resources folder, thanks [~elserj] was (Author: vrodionov): v5 adds log4j.properties file to backup module resources folder > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10504) Define Replication Interface
[ https://issues.apache.org/jira/browse/HBASE-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137649#comment-16137649 ] stack commented on HBASE-10504: --- What we going to do here? ReplicationEndpoint is broken in hbase-2.0 so if we want to mess with Replication Interfaces, now is the time. > Define Replication Interface > > > Key: HBASE-10504 > URL: https://issues.apache.org/jira/browse/HBASE-10504 > Project: HBase > Issue Type: Task > Components: Replication >Reporter: stack >Assignee: Enis Soztutar >Priority: Blocker > Fix For: 2.0.0-alpha-3 > > Attachments: hbase-10504_v1.patch, hbase-10504_wip1.patch > > > HBase has replication. Fellas have been hijacking the replication apis to do > all kinds of perverse stuff like indexing hbase content (hbase-indexer > https://github.com/NGDATA/hbase-indexer) and our [~toffer] just showed up w/ > overrides that replicate via an alternate channel (over a secure thrift > channel between dcs over on HBASE-9360). This issue is about surfacing these > APIs as public with guarantees to downstreamers similar to those we have on > our public client-facing APIs (and so we don't break them for downstreamers). > Any input [~phunt] or [~gabriel.reid] or [~toffer]? > Thanks. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137625#comment-16137625 ] stack commented on HBASE-17614: --- It just failed for me: --- T E S T S --- Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 428.16 sec <<< FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner) Time elapsed: 425.234 sec <<< FAILURE! java.lang.AssertionError at org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:93) Results : Failed tests: TestBackupLogCleaner.testBackupLogCleaner:93 Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 7:14.154s [INFO] Finished at: Tue Aug 22 16:45:37 PDT 2017 [INFO] Final Memory: 54M/2040M [INFO] > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137622#comment-16137622 ] stack commented on HBASE-17614: --- It gets stuck if I look at logs. Suggest getting a clean run on jenkins and then commit. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18575) [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on master
[ https://issues.apache.org/jira/browse/HBASE-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18575: - Attachment: hbase-18575.master.001.patch > [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on > master > > > Key: HBASE-18575 > URL: https://issues.apache.org/jira/browse/HBASE-18575 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18575.master.001.patch > > > * Test creates 3 node cluster (master + 2 RS) and creates 3 tables with 1 > region each. > * It then takes a snapshot of region assignments > * Shuts down the cluster and restarts with 4 nodes (2 RS on same ports, 1 RS > on port where master was running previously and master on new port) > * Takes snapshot of region assignments > * Expected behavior is regions will be retained on RS with appropriate ports > Debugging done so far shows that, when cluster is restarted meta is loaded > but meta has old entries (though the ports are same for RSs, start timestamps > are different). AssignmentManager#processofflineServersWithOnlineRegions() > finds that old RS with different timestamps are not online even though > regions assigned to them are online; triggering submitting SCP for each those > RSs. Subprocedure AssignProcedure of SCP has forceNewPlan set to true. Which > triggers re-assignment of regions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18575) [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on master
[ https://issues.apache.org/jira/browse/HBASE-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18575: - Status: Patch Available (was: In Progress) * Fixed ServerCrashProcedure to set forceNewPlan to false for instances AssignProcedure. This enables balancer to find most suitable target server * Fixed and enabled TestRestartCluster#testRetainAssignmentOnRestart on master * Renamed method ServerName@isSameHostnameAndPort() to isSameAddress() > [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on > master > > > Key: HBASE-18575 > URL: https://issues.apache.org/jira/browse/HBASE-18575 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18575.master.001.patch > > > * Test creates 3 node cluster (master + 2 RS) and creates 3 tables with 1 > region each. > * It then takes a snapshot of region assignments > * Shuts down the cluster and restarts with 4 nodes (2 RS on same ports, 1 RS > on port where master was running previously and master on new port) > * Takes snapshot of region assignments > * Expected behavior is regions will be retained on RS with appropriate ports > Debugging done so far shows that, when cluster is restarted meta is loaded > but meta has old entries (though the ports are same for RSs, start timestamps > are different). AssignmentManager#processofflineServersWithOnlineRegions() > finds that old RS with different timestamps are not online even though > regions assigned to them are online; triggering submitting SCP for each those > RSs. Subprocedure AssignProcedure of SCP has forceNewPlan set to true. Which > triggers re-assignment of regions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18575) [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on master
[ https://issues.apache.org/jira/browse/HBASE-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18575 started by Umesh Agashe. > [AMv2] Enable and fix TestRestartCluster#testRetainAssignmentOnRestart on > master > > > Key: HBASE-18575 > URL: https://issues.apache.org/jira/browse/HBASE-18575 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.0 >Reporter: Umesh Agashe >Assignee: Umesh Agashe >Priority: Critical > Fix For: 2.0.0 > > > * Test creates 3 node cluster (master + 2 RS) and creates 3 tables with 1 > region each. > * It then takes a snapshot of region assignments > * Shuts down the cluster and restarts with 4 nodes (2 RS on same ports, 1 RS > on port where master was running previously and master on new port) > * Takes snapshot of region assignments > * Expected behavior is regions will be retained on RS with appropriate ports > Debugging done so far shows that, when cluster is restarted meta is loaded > but meta has old entries (though the ports are same for RSs, start timestamps > are different). AssignmentManager#processofflineServersWithOnlineRegions() > finds that old RS with different timestamps are not online even though > regions assigned to them are online; triggering submitting SCP for each those > RSs. Subprocedure AssignProcedure of SCP has forceNewPlan set to true. Which > triggers re-assignment of regions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18224) Upgrade jetty
[ https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137604#comment-16137604 ] stack commented on HBASE-18224: --- Actually use the define. The findbugs is unrelated but fix. > Upgrade jetty > - > > Key: HBASE-18224 > URL: https://issues.apache.org/jira/browse/HBASE-18224 > Project: HBase > Issue Type: Improvement > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18224.branch-2.001 (1).patch, > HBASE-18224.branch-2.001.patch, HBASE-18224.branch-2.002 (1).patch, > HBASE-18224.branch-2.002.patch, HBASE-18224.branch-2.003.patch, > HBASE-18224.master.001.patch > > > Jetty can be updated to 9.4.6 and thrift can be updated to 0.10.0. I tried to > update them in HBASE-17898 but some unit tests failed, so created a sub-task > for them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18224) Upgrade jetty
[ https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18224: -- Attachment: HBASE-18224.master.001.patch > Upgrade jetty > - > > Key: HBASE-18224 > URL: https://issues.apache.org/jira/browse/HBASE-18224 > Project: HBase > Issue Type: Improvement > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18224.branch-2.001 (1).patch, > HBASE-18224.branch-2.001.patch, HBASE-18224.branch-2.002 (1).patch, > HBASE-18224.branch-2.002.patch, HBASE-18224.branch-2.003.patch, > HBASE-18224.master.001.patch > > > Jetty can be updated to 9.4.6 and thrift can be updated to 0.10.0. I tried to > update them in HBASE-17898 but some unit tests failed, so created a sub-task > for them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18655) TestAsyncClusterAdminApi2 failing sometimes
[
https://issues.apache.org/jira/browse/HBASE-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-18655:
--
Affects Version/s: (was: 3.0.0)
2.0.0
Status: Patch Available (was: Open)
> TestAsyncClusterAdminApi2 failing sometimes
> ---
>
> Key: HBASE-18655
> URL: https://issues.apache.org/jira/browse/HBASE-18655
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Mike Drob
>Assignee: stack
> Attachments: HBASE-18655.master.001.patch
>
>
> Investigating a test failure seen on HBASE-12349
> git bisect shows me the following:
> {noformat}
> # first bad commit: [473446719b7b81b56216862bf2a94a576ff90f60] HBASE-18511
> Default no regions on master
> {noformat}
> It wouldn't fail every time, but I used this command with the bisect
> {noformat}
> export OPTS='test
> -Dtest=org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 -pl
> hbase-server -am'
> mvn clean $OPTS && mvn $OPTS && mvn $OPTS && mvn $OPTS
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18655) TestAsyncClusterAdminApi2 failing sometimes
[
https://issues.apache.org/jira/browse/HBASE-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137592#comment-16137592
]
stack commented on HBASE-18655:
---
.001 simple patch that changes masters from 2 to 1. Ran this patch 20 times and
it passes. Some mess around kill of a RS (that was a Master in old days
pre-HBASE-12349) and race for backup Master to become actual Master I presume
(Haven't spent time on it).
> TestAsyncClusterAdminApi2 failing sometimes
> ---
>
> Key: HBASE-18655
> URL: https://issues.apache.org/jira/browse/HBASE-18655
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Mike Drob
>Assignee: stack
> Attachments: HBASE-18655.master.001.patch
>
>
> Investigating a test failure seen on HBASE-12349
> git bisect shows me the following:
> {noformat}
> # first bad commit: [473446719b7b81b56216862bf2a94a576ff90f60] HBASE-18511
> Default no regions on master
> {noformat}
> It wouldn't fail every time, but I used this command with the bisect
> {noformat}
> export OPTS='test
> -Dtest=org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 -pl
> hbase-server -am'
> mvn clean $OPTS && mvn $OPTS && mvn $OPTS && mvn $OPTS
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18655) TestAsyncClusterAdminApi2 failing sometimes
[
https://issues.apache.org/jira/browse/HBASE-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-18655:
--
Attachment: HBASE-18655.master.001.patch
> TestAsyncClusterAdminApi2 failing sometimes
> ---
>
> Key: HBASE-18655
> URL: https://issues.apache.org/jira/browse/HBASE-18655
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Mike Drob
>Assignee: stack
> Attachments: HBASE-18655.master.001.patch
>
>
> Investigating a test failure seen on HBASE-12349
> git bisect shows me the following:
> {noformat}
> # first bad commit: [473446719b7b81b56216862bf2a94a576ff90f60] HBASE-18511
> Default no regions on master
> {noformat}
> It wouldn't fail every time, but I used this command with the bisect
> {noformat}
> export OPTS='test
> -Dtest=org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 -pl
> hbase-server -am'
> mvn clean $OPTS && mvn $OPTS && mvn $OPTS && mvn $OPTS
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18224) Upgrade jetty
[
https://issues.apache.org/jira/browse/HBASE-18224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137584#comment-16137584
]
Hadoop QA commented on HBASE-18224:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
45s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
14s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
36s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 50s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
18s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 27m 1s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 40m 47s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}150m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Useless object stored in variable serverNameToServerNameWithoutCode of
method
org.apache.hadoop.hbase.favored.FavoredNodeLoadBalancer.balanceCluster(Map) At
FavoredNodeLoadBalancer.java:serverNameToServerNameWithoutCode of method
org.apache.hadoop.hbase.favored.FavoredNodeLoadBalancer.balanceCluster(Map) At
FavoredNodeLoadBalancer.java:[line 100] |
| Failed junit tests | hadoop.hbase.http.TestHttpServer |
| | hadoop.hbase.http.TestSpnegoHttpServer |
| | hadoop.hbase.http.TestSSLHttpServer |
| |
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137579#comment-16137579 ] Vladimir Rodionov edited comment on HBASE-17614 at 8/22/17 11:15 PM: - On my MBP 2014 test takes 105 sec to finish OK, this looks weird. When I tried what [~elserj] runs : *mvn clean package -Dtest=.. * - it failed with the same error. I usually run tests using : *mvn test -Dtest=... * - this runs OK for the test. [~elserj], can you try *mvn test*? Upd: never mind was (Author: vrodionov): On my MBP 2014 test takes 105 sec to finish OK, this looks weird. When I tried what [~elserj] runs : *mvn clean package -Dtest=.. * - it failed with the same error. I usually run tests using : *mvn test -Dtest=... * - this runs OK for the test. [~elserj], can you try *mvn test*? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137579#comment-16137579 ] Vladimir Rodionov commented on HBASE-17614: --- On my MBP 2014 test takes 105 sec to finish OK, this looks weird. When I tried what [~elserj] runs : *mvn clean package -Dtest=.. * - it failed with the same error. I usually run tests using : *mvn test -Dtest=... * - this runs OK for the test. [~elserj], can you try *mvn test*? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18614) Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137576#comment-16137576
]
Ted Yu commented on HBASE-18614:
git am gave me (after removing tab):
error: patch failed:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:45
error:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:
patch does not apply
Patch failed at 0001 HBASE-18614 Setting BUCKET_CACHE_COMBINED_KEY to false
disables stats on RS UI
Can you rebase the patch ?
> Setting BUCKET_CACHE_COMBINED_KEY to false disables stats on RS UI
> --
>
> Key: HBASE-18614
> URL: https://issues.apache.org/jira/browse/HBASE-18614
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
>Reporter: Biju Nair
>Assignee: Biju Nair
> Attachments: HBASE-18614-1.1.2.PATCH, HBASE-18614.PATCH,
> HBASE-18614-V1.0.PATCH
>
>
> Enabling offheap cache and setting {{BUCKET_CACHE_COMBINED_KEY}} to {{false}}
> in site xml to make offheap cache a strict L2 cache to LRU cache, disables
> the L2 stats normally rendered on region server UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
