[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159313#comment-16159313 ] Hudson commented on HBASE-18641: FAILURE: Integrated in Jenkins build HBase-1.5 #53 (See [https://builds.apache.org/job/HBase-1.5/53/]) HBASE-18641 Include block content verification logic used in lruCache in (tedyu: rev ab8a667c451bd7a023a5e506bb3fb58928de) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590
[
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159305#comment-16159305
]
Hadoop QA commented on HBASE-16894:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
42s{color} | {color:red} hbase-mapreduce generated 2 new + 0 unchanged - 0
fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
55s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-mapreduce |
| | Integral division result cast to double or float in
org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.calculateAutoBalancedSplits(List,
long) At TableInputFormatBase.java:double or float in
org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.calculateAutoBalancedSplits(List,
long) At TableInputFormatBase.java:[line 462] |
| | The method name
org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.CreateNInputSplits(InputSplit,
int) doesn't start with a lower case letter At
TableInputFormatBase.java:doesn't start with a lower case letter At
TableInputFormatBase.java:[lines 363-412] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-16894 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886148/HBASE-12590-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 2756b2524f13 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 77ca743 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| findbugs |
[jira] [Updated] (HBASE-18750) Cleanup the docs saying "HTable use write buffer"
[
https://issues.apache.org/jira/browse/HBASE-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18750:
---
Summary: Cleanup the docs saying "HTable use write buffer" (was: Document
the non-writebuffer for HTable)
> Cleanup the docs saying "HTable use write buffer"
> -
>
> Key: HBASE-18750
> URL: https://issues.apache.org/jira/browse/HBASE-18750
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
>
> Cleanup the docs saying "HTable use write buffer"
> {code}
> Default size of the HTable client write buffer in bytes. A bigger buffer
> takes more memory — on both the client and server side since server
> instantiates the passed write buffer to process it — but a larger buffer size
> reduces the number of RPCs made. For an estimate of server-side memory-used,
> evaluate hbase.client.write.buffer * hbase.regionserver.handler.count
> {code}
> {code}
> Put either adds new rows to a table (if the key is new) or can update
> existing rows (if the key already exists). Puts are executed via Table.put
> (writeBuffer) or Table.batch (non-writeBuffer).
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18750) Cleanup the docs saying "HTable use write buffer"
[
https://issues.apache.org/jira/browse/HBASE-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned HBASE-18750:
--
Assignee: Chia-Ping Tsai
> Cleanup the docs saying "HTable use write buffer"
> -
>
> Key: HBASE-18750
> URL: https://issues.apache.org/jira/browse/HBASE-18750
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
>
> Cleanup the docs saying "HTable use write buffer"
> {code}
> Default size of the HTable client write buffer in bytes. A bigger buffer
> takes more memory — on both the client and server side since server
> instantiates the passed write buffer to process it — but a larger buffer size
> reduces the number of RPCs made. For an estimate of server-side memory-used,
> evaluate hbase.client.write.buffer * hbase.regionserver.handler.count
> {code}
> {code}
> Put either adds new rows to a table (if the key is new) or can update
> existing rows (if the key already exists). Puts are executed via Table.put
> (writeBuffer) or Table.batch (non-writeBuffer).
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18718) Document the coprocessor.Export
[ https://issues.apache.org/jira/browse/HBASE-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159304#comment-16159304 ] Chia-Ping Tsai commented on HBASE-18718: [~stack] Would you please take a look? > Document the coprocessor.Export > --- > > Key: HBASE-18718 > URL: https://issues.apache.org/jira/browse/HBASE-18718 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors, documentation, tooling >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18718.v0.patch, HBASE-18718.v0.png, > HBASE-18718.v1.patch, HBASE-18718.v1.patch, HBASE-18718.v1.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159263#comment-16159263 ] Hudson commented on HBASE-18641: FAILURE: Integrated in Jenkins build HBase-1.4 #909 (See [https://builds.apache.org/job/HBase-1.4/909/]) HBASE-18641 Include block content verification logic used in lruCache in (tedyu: rev e177f71fd13f00faa104172a0a42bb6a7f5f9040) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18783) Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus
[ https://issues.apache.org/jira/browse/HBASE-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18783: --- Hadoop Flags: Incompatible change > Declare the builder of ClusterStatus as IA.Private; Remove the Writables from > ClusterStatus > --- > > Key: HBASE-18783 > URL: https://issues.apache.org/jira/browse/HBASE-18783 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-alpha-3 > > > To clarify the usage of ClusterStatus API. > # It makes no sense that user want to create custom ClusterStatus; As a > result, we should declare the builder of ClusterStatus as IA.Private. > # HBASE-6038 removed the write/readFields from ClusterStatus; thus the > Writable is meaningless for ClusterStatus now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18783) Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus
[ https://issues.apache.org/jira/browse/HBASE-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18783: --- Fix Version/s: 2.0.0-alpha-3 > Declare the builder of ClusterStatus as IA.Private; Remove the Writables from > ClusterStatus > --- > > Key: HBASE-18783 > URL: https://issues.apache.org/jira/browse/HBASE-18783 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-alpha-3 > > > To clarify the usage of ClusterStatus API. > # It makes no sense that user want to create custom ClusterStatus; As a > result, we should declare the builder of ClusterStatus as IA.Private. > # HBASE-6038 removed the write/readFields from ClusterStatus; thus the > Writable is meaningless for ClusterStatus now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18783) Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus
[ https://issues.apache.org/jira/browse/HBASE-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18783: --- Description: To clarify the usage of ClusterStatus API. # It makes no sense that user want to create custom ClusterStatus; As a result, we should declare the builder of ClusterStatus as IA.Private. # HBASE-6038 removed the write/readFields from ClusterStatus; thus the Writable is meaningless for ClusterStatus now. was: To clarify the usage of ClusterStatus API. # It makes no sense that user want to create custom ClusterStatus; As a result, we should declare the builder of ClusterStatus as IA.Private. # HBASE-6038 removed the write/readFields from ClusterStatus, thus the Writable is meaningless for ClusterStatus now. > Declare the builder of ClusterStatus as IA.Private; Remove the Writables from > ClusterStatus > --- > > Key: HBASE-18783 > URL: https://issues.apache.org/jira/browse/HBASE-18783 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > To clarify the usage of ClusterStatus API. > # It makes no sense that user want to create custom ClusterStatus; As a > result, we should declare the builder of ClusterStatus as IA.Private. > # HBASE-6038 removed the write/readFields from ClusterStatus; thus the > Writable is meaningless for ClusterStatus now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18783) Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus
[ https://issues.apache.org/jira/browse/HBASE-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned HBASE-18783: -- Assignee: Chia-Ping Tsai > Declare the builder of ClusterStatus as IA.Private; Remove the Writables from > ClusterStatus > --- > > Key: HBASE-18783 > URL: https://issues.apache.org/jira/browse/HBASE-18783 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > To clarify the usage of ClusterStatus API. > # It makes no sense that user want to create custom ClusterStatus; As a > result, we should declare the builder of ClusterStatus as IA.Private. > # HBASE-6038 removed the write/readFields from ClusterStatus, thus the > Writable is meaningless for ClusterStatus now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18769) Make CompareFilter use generic CompareOperator instead of internal enum
[ https://issues.apache.org/jira/browse/HBASE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159234#comment-16159234 ] Hudson commented on HBASE-18769: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3681 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3681/]) HBASE-18769 Make CompareFilter use generic CompareOperator instead of (stack: rev b8e0a8396f5f6ec02d9382a75f550499d85f3a23) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestSingleColumnValueFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestSingleColumnValueExcludeFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterSerialization.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestCheckAndMutate.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java * (edit) src/main/asciidoc/_chapters/architecture.adoc * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterWrapper.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/ExportUtils.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterWithScanLimits.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/filter/ByteArrayComparable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java * (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java * (edit) hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableBasedReplicationQueuesImpl.java > Make CompareFilter use generic CompareOperator instead of internal enum > --- > > Key: HBASE-18769 > URL: https://issues.apache.org/jira/browse/HBASE-18769 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18769.branch-2.001.patch, > HBASE-18769.branch-2.002.patch, HBASE-18769.branch-2.003.patch > > > Should probably do this so only the one enum in the codebase. Means a bunch > of boilerplate deprecating the old enum for the new. Suggested by > [~anoop.hbase]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159236#comment-16159236 ] Hudson commented on HBASE-18780: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3681 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3681/]) HBASE-18780 Remove HLogPrettyPrinter (stack: rev 87c3ae9314e3a6ba85900cceb06ea34cf295395a) * (edit) src/main/asciidoc/_chapters/ops_mgt.adoc * (edit) bin/hbase * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogPrettyPrinter.java * (edit) bin/hbase.cmd > Remove HLogPrettyPrinter and hlog command > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18779) Move CompareOperator to hbase-client module
[ https://issues.apache.org/jira/browse/HBASE-18779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159235#comment-16159235 ] Hudson commented on HBASE-18779: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3681 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3681/]) HBASE-18779 Move CompareOperator to hbase-client module (stack: rev c90602ef67d490205098f11bff57ec31a6ac6f87) * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/CompareOperator.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/CompareOperator.java > Move CompareOperator to hbase-client module > --- > > Key: HBASE-18779 > URL: https://issues.apache.org/jira/browse/HBASE-18779 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-3 > > > Comes of [~enis] review over in HBASE-14997. Do this review feedback after > HBASE-18769 goes in. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18778) Use Comparator for StealJobQueue
[ https://issues.apache.org/jira/browse/HBASE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159233#comment-16159233 ] Hudson commented on HBASE-18778: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3681 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3681/]) HBASE-18778 Use Comparator for StealJobQueue (zhangduo: rev 331910192af158aac33f883ae132fba444dda003) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/StealJobQueue.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestStealJobQueue.java > Use Comparator for StealJobQueue > > > Key: HBASE-18778 > URL: https://issues.apache.org/jira/browse/HBASE-18778 > Project: HBase > Issue Type: Improvement > Components: Compaction >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18778.patch, HBASE-18778-v1.patch > > > To eliminate the confusing compareTo and equals implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18106) Redo ProcedureInfo and LockInfo
[ https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159237#comment-16159237 ] Hudson commented on HBASE-18106: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3681 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3681/]) HBASE-18106 Redo ProcedureInfo and LockInfo (stack: rev 359fed7b4b62e4dc7818a211735630cf0e10fc14) * (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto * (add) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/LockedResource.java * (edit) hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestProcedureAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMergedRegionsProcedure.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureScheduler.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/locking/LockProcedure.java * (edit) hbase-shell/src/main/ruby/shell/commands/list_locks.rb * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ProcedureDescriber.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/locking/LockManager.java * (edit) hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/TestProcedureReplayOrder.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java * (add) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/LockedResourceType.java * (add) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/LockType.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/util/JRubyFormat.java * (edit) hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/ProcedureTestingUtility.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcedureAdminApi.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureInMemoryChore.java * (edit) hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/TestProcedureUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/store/wal/TestWALProcedureStore.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestProcedureDescriber.java * (add) hbase-shell/src/test/java/org/apache/hadoop/hbase/client/procedure/ShellTestProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AddColumnFamilyProcedure.java * (edit) hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestReplicationShell.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyColumnFamilyProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteNamespaceProcedure.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/locking/TestLockManager.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/Procedure.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * (edit) hbase-shell/src/main/ruby/shell/commands/list_procedures.rb * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java * (edit)
[jira] [Created] (HBASE-18783) Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus
Chia-Ping Tsai created HBASE-18783: -- Summary: Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus Key: HBASE-18783 URL: https://issues.apache.org/jira/browse/HBASE-18783 Project: HBase Issue Type: Bug Reporter: Chia-Ping Tsai Priority: Minor To clarify the usage of ClusterStatus API. # It makes no sense that user want to create custom ClusterStatus; As a result, we should declare the builder of ClusterStatus as IA.Private. # HBASE-6038 removed the write/readFields from ClusterStatus, thus the Writable is meaningless for ClusterStatus now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18783) Declare the builder of ClusterStatus as IA.Private; Remove the Writables from ClusterStatus
[ https://issues.apache.org/jira/browse/HBASE-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18783: --- Issue Type: Task (was: Bug) > Declare the builder of ClusterStatus as IA.Private; Remove the Writables from > ClusterStatus > --- > > Key: HBASE-18783 > URL: https://issues.apache.org/jira/browse/HBASE-18783 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Priority: Minor > > To clarify the usage of ClusterStatus API. > # It makes no sense that user want to create custom ClusterStatus; As a > result, we should declare the builder of ClusterStatus as IA.Private. > # HBASE-6038 removed the write/readFields from ClusterStatus, thus the > Writable is meaningless for ClusterStatus now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo
[ https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18106: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed. Actually resolving. > Redo ProcedureInfo and LockInfo > --- > > Key: HBASE-18106 > URL: https://issues.apache.org/jira/browse/HBASE-18106 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Balazs Meszaros >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18106.master.001.patch, > HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, > HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, > HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, > HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, > HBASE-18106.master.010.patch, HBASE-18106.master.011.patch, > HBASE-18106.master.011.patch, HBASE-18106.master.012.patch, > HBASE-18106.master.012.patch > > > ProcedureInfo was introduced as a lowest-common-denominator POJO that could > be used as a facade on PB Procedures. It was good for showing state of > Procedure framework in shell and UI. > Its a bit weird though. Its up in hbase-common rather than in Procedure and > it can only ever show a subset of the Procedure info. > I was thinking we could use the pb3.1 pb->JSON utility instead and emit a > JSON String wherever we need to export a view on procedure internals. > This issue is about exploring this possibility. Would depend on our having an > upgraded guava (so probably depends on the 'pre-build' project). > From ProcedureInfo and LockInfo need fixing in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18106) Redo ProcedureInfo and LockInfo
[ https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18106: -- I ran the test locally on master and branch-2 and both passed for me too. Pushed to master and branch-2. Thanks for keeping at this awkward patch [~balazs.meszaros]. Its great cleanup sir. This patch is also an enabler. Views on locks and procedures can be built out of the JSON we are pushing out. > Redo ProcedureInfo and LockInfo > --- > > Key: HBASE-18106 > URL: https://issues.apache.org/jira/browse/HBASE-18106 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Balazs Meszaros >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18106.master.001.patch, > HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, > HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, > HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, > HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, > HBASE-18106.master.010.patch, HBASE-18106.master.011.patch, > HBASE-18106.master.011.patch, HBASE-18106.master.012.patch, > HBASE-18106.master.012.patch > > > ProcedureInfo was introduced as a lowest-common-denominator POJO that could > be used as a facade on PB Procedures. It was good for showing state of > Procedure framework in shell and UI. > Its a bit weird though. Its up in hbase-common rather than in Procedure and > it can only ever show a subset of the Procedure info. > I was thinking we could use the pb3.1 pb->JSON utility instead and emit a > JSON String wherever we need to export a view on procedure internals. > This issue is about exploring this possibility. Would depend on our having an > upgraded guava (so probably depends on the 'pre-build' project). > From ProcedureInfo and LockInfo need fixing in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[ https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159188#comment-16159188 ] Mikhail Antonov commented on HBASE-18090: - Thanks for the patch! Before I go in reviews..opening regions in read-only mode for snapshots seems reasonable. That change would only affect MR over snapshots codebase or some other paths too? and another question - if we set readonly flag we skip replaying WAL and don't create those tmp files. Will that work for snapshots created with skipFlush option? Is it always safe to skip WAL in that case? > Improve TableSnapshotInputFormat to allow more multiple mappers per region > -- > > Key: HBASE-18090 > URL: https://issues.apache.org/jira/browse/HBASE-18090 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.4.0 >Reporter: Mikhail Antonov >Assignee: xinxin fan > Attachments: HBASE-18090-branch-1.3-v1.patch, > HBASE-18090-branch-1.3-v2.patch > > > TableSnapshotInputFormat runs one map task per region in the table snapshot. > This places unnecessary restriction that the region layout of the original > table needs to take the processing resources available to MR job into > consideration. Allowing to run multiple mappers per region (assuming > reasonably even key distribution) would be useful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18621) Refactor ClusterOptions before applying to code base
[ https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18621: --- Attachment: HBASE-18621.master.011.patch v11 is what i committed. > Refactor ClusterOptions before applying to code base > > > Key: HBASE-18621 > URL: https://issues.apache.org/jira/browse/HBASE-18621 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18621.master.001.patch, > HBASE-18621.master.002.patch, HBASE-18621.master.003.patch, > HBASE-18621.master.004.patch, HBASE-18621.master.005.patch, > HBASE-18621.master.006.patch, HBASE-18621.master.007.patch, > HBASE-18621.master.008.patch, HBASE-18621.master.009.patch, > HBASE-18621.master.010.patch, HBASE-18621.master.011.patch > > > So far, ClusterStatus.Options is not so clean that can be applied to code > base. > Refactoring it before next move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reopened HBASE-18641: TestBlockCacheReporting fails in branch-1 > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18621) Refactor ClusterOptions before applying to code base
[ https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18621: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Push to branch-2 and master. Thanks for the patch. [~reidchan] > Refactor ClusterOptions before applying to code base > > > Key: HBASE-18621 > URL: https://issues.apache.org/jira/browse/HBASE-18621 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18621.master.001.patch, > HBASE-18621.master.002.patch, HBASE-18621.master.003.patch, > HBASE-18621.master.004.patch, HBASE-18621.master.005.patch, > HBASE-18621.master.006.patch, HBASE-18621.master.007.patch, > HBASE-18621.master.008.patch, HBASE-18621.master.009.patch, > HBASE-18621.master.010.patch, HBASE-18621.master.011.patch > > > So far, ClusterStatus.Options is not so clean that can be applied to code > base. > Refactoring it before next move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159180#comment-16159180 ] Hudson commented on HBASE-18641: FAILURE: Integrated in Jenkins build HBase-1.4 #908 (See [https://builds.apache.org/job/HBase-1.4/908/]) HBASE-18641 Include block content verification logic used in lruCache in (tedyu: rev 3f831ebdc52999bc4eed657effb5a9aa6f8866fa) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159175#comment-16159175 ] Hudson commented on HBASE-18641: FAILURE: Integrated in Jenkins build HBase-1.5 #52 (See [https://builds.apache.org/job/HBase-1.5/52/]) HBASE-18641 Include block content verification logic used in lruCache in (tedyu: rev a6dbeba22a2ce73cfe1c71551bd932102d196224) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590
[
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liang updated HBASE-16894:
-
Attachment: HBASE-12590-v1.patch
Try unit test
> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-12590-v1.patch, ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map
> tasks are created per region. Right now, it is always 1 region = 1 input
> split = 1 map task. Same goes for Spark since it uses the TIF. With region
> sizes as large as 50 GBs, it is desirable to be able to create more than 1
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in
> region sizes. The algorithm is roughly:
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input
> splits
> If (average size <= region size < average size*ratio) : one region as one MR
> input split
> If (sum of several continuous regions size < average size * ratio): combine
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse
> HBASE-12590 into creating more than 1 split task per region, it is not ideal.
> But there is no way to create more with the patch as it is. For example we
> cannot create more than 2 tasks per region.
> If we want to fix this properly, we should extend the approach in
> HBASE-12590, and make it so that the client can specify the desired num of
> mappers, or desired split size, and the TIF generates the splits based on the
> current region sizes very similar to the algorithm in HBASE-12590, but a more
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats
> table which is used for exactly this purpose. Right now, the region can be
> split into powers of two assuming uniform distribution within the region.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590
[
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liang updated HBASE-16894:
-
Fix Version/s: 2.0.0-alpha-3
3.0.0
Affects Version/s: 3.0.0
2.0.0-alpha-2
Status: Patch Available (was: Open)
> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0-alpha-2, 3.0.0
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-12590-v1.patch, ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map
> tasks are created per region. Right now, it is always 1 region = 1 input
> split = 1 map task. Same goes for Spark since it uses the TIF. With region
> sizes as large as 50 GBs, it is desirable to be able to create more than 1
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in
> region sizes. The algorithm is roughly:
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input
> splits
> If (average size <= region size < average size*ratio) : one region as one MR
> input split
> If (sum of several continuous regions size < average size * ratio): combine
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse
> HBASE-12590 into creating more than 1 split task per region, it is not ideal.
> But there is no way to create more with the patch as it is. For example we
> cannot create more than 2 tasks per region.
> If we want to fix this properly, we should extend the approach in
> HBASE-12590, and make it so that the client can specify the desired num of
> mappers, or desired split size, and the TIF generates the splits based on the
> current region sizes very similar to the algorithm in HBASE-12590, but a more
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats
> table which is used for exactly this purpose. Right now, the region can be
> split into powers of two assuming uniform distribution within the region.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18641: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.0-alpha-3 1.5.0 1.4.0 Status: Resolved (was: Patch Available) Thanks for the patch, Biju. Thanks for the review, Anoop. > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[
https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159137#comment-16159137
]
Hadoop QA commented on HBASE-18780:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
5s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
5s{color} | {color:green} The patch generated 0 new + 497 unchanged - 1 fixed
= 497 total (was 498) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 16s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}154m
37s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
49s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}325m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.TestMasterFailover |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| |
[jira] [Updated] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair updated HBASE-18641: -- Attachment: HBASE-18641-branch-1.PATCH Patch for branch-1. > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18782: -- Status: Patch Available (was: Open) Make sure tests still work, that I haven't undone a dependency needed at test time. > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18782) Module untangling work
stack created HBASE-18782: - Summary: Module untangling work Key: HBASE-18782 URL: https://issues.apache.org/jira/browse/HBASE-18782 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Here is a bit of module untangling work done using structure 101. In a few places we depend on modules but are not making use of the dependency. In other places we depended on a module just because we had one references only, one we could undo. After this little exercise, we have nicer layering and stuff like hbase-protocol and hbase-protocol-shaded no longer depend on other hbase components. Not everything depends on annotations anymore. There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18782: -- Attachment: HBASE-18782.master.001.patch > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18298) RegionServerServices Interface cleanup for CP expose
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159098#comment-16159098
]
Chia-Ping Tsai commented on HBASE-18298:
{code}
- RegionServerServices getRegionServerServices();
+ CoprocessorRSServices getRegionServerServices();
{code}
What about renaming the method? getCoprocessorRSServices()?
BTW, should we also cleanup the MasterServices for CP? There is a connected
issue HBASE-12260.
> RegionServerServices Interface cleanup for CP expose
>
>
> Key: HBASE-18298
> URL: https://issues.apache.org/jira/browse/HBASE-18298
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18298.patch, HBASE-18298_V2.patch,
> HBASE-18298_V3.patch, HBASE-18298_V4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18298) RegionServerServices Interface cleanup for CP expose
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159089#comment-16159089
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
45m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
10s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}126m
44s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
55s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
11s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
54s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}215m 16s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18298 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886099/HBASE-18298_V4.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 3425c00765e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 3319101 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|
[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[
https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159088#comment-16159088
]
Hadoop QA commented on HBASE-18090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
59s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 46s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}401m 0s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
19s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 4m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}448m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestWALLockup |
| | hadoop.hbase.regionserver.TestRecoveredEdits |
| | hadoop.hbase.client.TestAdmin2 |
| Timed out junit tests |
[jira] [Commented] (HBASE-18762) Canary sink type cast error
[ https://issues.apache.org/jira/browse/HBASE-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159086#comment-16159086 ] Chinmay Kulkarni commented on HBASE-18762: -- [~lhofhansl] please take a look. Thanks! > Canary sink type cast error > --- > > Key: HBASE-18762 > URL: https://issues.apache.org/jira/browse/HBASE-18762 > Project: HBase > Issue Type: Bug >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni > > When running the main method of Canary.java, we see the following error: > Exception in thread "main" java.lang.ClassCastException: > org.apache.hadoop.hbase.tool.Canary$RegionServerStdOutSink cannot be cast to > org.apache.hadoop.hbase.tool.Canary$RegionStdOutSink > at org.apache.hadoop.hbase.tool.Canary.newMonitor(Canary.java:911) > at org.apache.hadoop.hbase.tool.Canary.run(Canary.java:796) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) > at org.apache.hadoop.hbase.tool.Canary.main(Canary.java:1571) > This happens because we typecast the sink depending on the mode (zookeeper > mode/region server mode) that Canary is configured in. In case no mode is > specified, we typecast the sink into _RegionStdOutSink_. In general, it is > possible to provide inconsistent mode and sink types while running Canary. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159082#comment-16159082 ] Kuan-Po Tseng commented on HBASE-17980: --- Copy that. Thanks for your advice~ > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18777) Create one table for subtests in multi-retry-test
[ https://issues.apache.org/jira/browse/HBASE-18777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-18777: -- Fix Version/s: HBASE-14850 > Create one table for subtests in multi-retry-test > - > > Key: HBASE-18777 > URL: https://issues.apache.org/jira/browse/HBASE-18777 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: HBASE-14850 > > Attachments: 18777.v1.txt > > > See HBASE-18541 for related information. > In short: when there're several test_util->CreateTable() calls in a test > (multi-retry-test e.g.), it is likely to have segfault during the test run. > Short term fix is to create one table for all the subtests in the test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159073#comment-16159073 ] Ted Yu commented on HBASE-18641: Biju: Please attach patch for branch-1 (there is conflict when applying 18641-V1.0.PATCH) > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Attachments: HBASE-18641.PATCH, HBASE-18641-V1.0.PATCH, > HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159071#comment-16159071 ] stack commented on HBASE-17980: --- Good on #2. On MutableRI being public, if only usage is delegation, then yes, make it private instead. When users need to make a RI, how does user do it going forward? Would be good to put this in Release Note. > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18760) Make hbase-shaded-check-invariants part of precommit
[ https://issues.apache.org/jira/browse/HBASE-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18760: Priority: Blocker (was: Major) > Make hbase-shaded-check-invariants part of precommit > > > Key: HBASE-18760 > URL: https://issues.apache.org/jira/browse/HBASE-18760 > Project: HBase > Issue Type: Bug > Components: community, test >Reporter: Appy >Assignee: Sean Busbey >Priority: Blocker > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18760) Make hbase-shaded-check-invariants part of precommit
[ https://issues.apache.org/jira/browse/HBASE-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18760 started by Sean Busbey. --- > Make hbase-shaded-check-invariants part of precommit > > > Key: HBASE-18760 > URL: https://issues.apache.org/jira/browse/HBASE-18760 > Project: HBase > Issue Type: Bug > Components: community, test >Reporter: Appy >Assignee: Sean Busbey > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18760) Make hbase-shaded-check-invariants part of precommit
[ https://issues.apache.org/jira/browse/HBASE-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18760: Component/s: test community > Make hbase-shaded-check-invariants part of precommit > > > Key: HBASE-18760 > URL: https://issues.apache.org/jira/browse/HBASE-18760 > Project: HBase > Issue Type: Bug > Components: community, test >Reporter: Appy >Assignee: Sean Busbey > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18641: --- Priority: Minor (was: Major) > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Attachments: HBASE-18641.PATCH, HBASE-18641-V1.0.PATCH, > HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159061#comment-16159061 ] Anoop Sam John commented on HBASE-18641: OK. +1 > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair > Attachments: HBASE-18641.PATCH, HBASE-18641-V1.0.PATCH, > HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18697) Need a shaded hbase-mapreduce module
[ https://issues.apache.org/jira/browse/HBASE-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159029#comment-16159029 ] Sean Busbey commented on HBASE-18697: - +1 on addendum please remove "Change Id" from commit message on commit. please flag this jira as incompatible. > Need a shaded hbase-mapreduce module > > > Key: HBASE-18697 > URL: https://issues.apache.org/jira/browse/HBASE-18697 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Appy > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18697.master.001.patch, > HBASE-18697.master.002.patch, HBASE-18697.master.003.patch, > HBASE-18697.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18753) Introduce the unsynchronized TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18753: --- Status: Patch Available (was: Open) > Introduce the unsynchronized TimeRangeTracker > - > > Key: HBASE-18753 > URL: https://issues.apache.org/jira/browse/HBASE-18753 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18753.v0.patch, HBASE-18753.v1.patch, > HBASE-18753.v2.patch, HBASE-18753.v3.patch > > > If HBASE-18752 is pushed, it will be better to introduce the unsync > TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18753) Introduce the unsynchronized TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18753: --- Attachment: HBASE-18753.v3.patch v3: AsyncTimeRangeTracker -> NonSyncTimeRangeTracker > Introduce the unsynchronized TimeRangeTracker > - > > Key: HBASE-18753 > URL: https://issues.apache.org/jira/browse/HBASE-18753 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18753.v0.patch, HBASE-18753.v1.patch, > HBASE-18753.v2.patch, HBASE-18753.v3.patch > > > If HBASE-18752 is pushed, it will be better to introduce the unsync > TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[ https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159007#comment-16159007 ] Ted Yu commented on HBASE-18090: This is a relatively large patch. Can you create patch for master branch and put it on review board ? > Improve TableSnapshotInputFormat to allow more multiple mappers per region > -- > > Key: HBASE-18090 > URL: https://issues.apache.org/jira/browse/HBASE-18090 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.4.0 >Reporter: Mikhail Antonov >Assignee: xinxin fan > Attachments: HBASE-18090-branch-1.3-v1.patch, > HBASE-18090-branch-1.3-v2.patch > > > TableSnapshotInputFormat runs one map task per region in the table snapshot. > This places unnecessary restriction that the region layout of the original > table needs to take the processing resources available to MR job into > consideration. Allowing to run multiple mappers per region (assuming > reasonably even key distribution) would be useful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159008#comment-16159008 ] Kuan-Po Tseng commented on HBASE-17980: --- Hello stack, 1. Yes, MutableRI is set to IA.Private. 2. I will correct the ImmutableRI to be IA.Private. Sorry about this mistake. 3. MutableRI is public because HRI delegate all things to MutableRI in this patch, if not so, we have to let MutableRI be private. Do you think let MutabableRI be private is better ??? > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590
[
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158998#comment-16158998
]
Yi Liang edited comment on HBASE-16894 at 9/8/17 5:51 PM:
--
Yes, and create splits for live table does not deal with WALs
was (Author: easyliangjob):
Yes, and create splits for live table does not deal with HDFS
> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
> Issue Type: Improvement
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Attachments: ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map
> tasks are created per region. Right now, it is always 1 region = 1 input
> split = 1 map task. Same goes for Spark since it uses the TIF. With region
> sizes as large as 50 GBs, it is desirable to be able to create more than 1
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in
> region sizes. The algorithm is roughly:
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input
> splits
> If (average size <= region size < average size*ratio) : one region as one MR
> input split
> If (sum of several continuous regions size < average size * ratio): combine
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse
> HBASE-12590 into creating more than 1 split task per region, it is not ideal.
> But there is no way to create more with the patch as it is. For example we
> cannot create more than 2 tasks per region.
> If we want to fix this properly, we should extend the approach in
> HBASE-12590, and make it so that the client can specify the desired num of
> mappers, or desired split size, and the TIF generates the splits based on the
> current region sizes very similar to the algorithm in HBASE-12590, but a more
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats
> table which is used for exactly this purpose. Right now, the region can be
> split into powers of two assuming uniform distribution within the region.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18753) Introduce the unsynchronized TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18753: --- Status: Open (was: Patch Available) > Introduce the unsynchronized TimeRangeTracker > - > > Key: HBASE-18753 > URL: https://issues.apache.org/jira/browse/HBASE-18753 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18753.v0.patch, HBASE-18753.v1.patch, > HBASE-18753.v2.patch > > > If HBASE-18752 is pushed, it will be better to introduce the unsync > TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590
[
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158998#comment-16158998
]
Yi Liang commented on HBASE-16894:
--
Yes, and create splits for live table does not deal with HDFS
> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
> Issue Type: Improvement
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Attachments: ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map
> tasks are created per region. Right now, it is always 1 region = 1 input
> split = 1 map task. Same goes for Spark since it uses the TIF. With region
> sizes as large as 50 GBs, it is desirable to be able to create more than 1
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in
> region sizes. The algorithm is roughly:
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input
> splits
> If (average size <= region size < average size*ratio) : one region as one MR
> input split
> If (sum of several continuous regions size < average size * ratio): combine
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse
> HBASE-12590 into creating more than 1 split task per region, it is not ideal.
> But there is no way to create more with the patch as it is. For example we
> cannot create more than 2 tasks per region.
> If we want to fix this properly, we should extend the approach in
> HBASE-12590, and make it so that the client can specify the desired num of
> mappers, or desired split size, and the TIF generates the splits based on the
> current region sizes very similar to the algorithm in HBASE-12590, but a more
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats
> table which is used for exactly this purpose. Right now, the region can be
> split into powers of two assuming uniform distribution within the region.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18773) Add utility to determine if a TableName is a meta table
[ https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158989#comment-16158989 ] Zach York commented on HBASE-18773: --- bq. Yeah. That looks about right. Make them the same. [~stack] I think there is some miscommunication here. While I think that making a dynamic way of accessing this makes sense, I also need to have both implementations of this function. (1) One that checks that this is the correct meta table name EXACTLY (including meta suffix if applicable) and (2) one that checks if it is a meta table (without any suffixes applied). I can change the funtionality of isMeta() and isMetaTableName() to (1) and then create a new method isMetaTableNameWithSuffix() for (2). What do you think of this approach? > Add utility to determine if a TableName is a meta table > --- > > Key: HBASE-18773 > URL: https://issues.apache.org/jira/browse/HBASE-18773 > Project: HBase > Issue Type: Sub-task >Reporter: Zach York >Assignee: Zach York > Attachments: HBASE-18773.HBASE-18477.001.patch > > > HBASE-18444 adds a method of specifying a meta table suffix. To continue work > on HBASE-18477, we need a way to determine if a TableName is a meta table. > This patch adds this method and a unit test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158977#comment-16158977 ] Chia-Ping Tsai commented on HBASE-18780: Thanks for the reviews. [~stack] > Remove HLogPrettyPrinter and hlog command > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18780: -- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change) Status: Resolved (was: Patch Available) Pushed to master and branch-2. > Remove HLogPrettyPrinter and hlog command > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18779) Move CompareOperator to hbase-client module
[ https://issues.apache.org/jira/browse/HBASE-18779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-18779. --- Resolution: Fixed Pushed to master and branch-2. Moved o.a.h.h.CompareOperator from hbase-common to hbase-client. > Move CompareOperator to hbase-client module > --- > > Key: HBASE-18779 > URL: https://issues.apache.org/jira/browse/HBASE-18779 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-3 > > > Comes of [~enis] review over in HBASE-14997. Do this review feedback after > HBASE-18769 goes in. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18769) Make CompareFilter use generic CompareOperator instead of internal enum
[ https://issues.apache.org/jira/browse/HBASE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18769: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks for the reviews lads. Helped. > Make CompareFilter use generic CompareOperator instead of internal enum > --- > > Key: HBASE-18769 > URL: https://issues.apache.org/jira/browse/HBASE-18769 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18769.branch-2.001.patch, > HBASE-18769.branch-2.002.patch, HBASE-18769.branch-2.003.patch > > > Should probably do this so only the one enum in the codebase. Means a bunch > of boilerplate deprecating the old enum for the new. Suggested by > [~anoop.hbase]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158936#comment-16158936 ] stack commented on HBASE-18780: --- +1 > Remove HLogPrettyPrinter and hlog command > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158920#comment-16158920 ] stack commented on HBASE-17980: --- [~brandboat] Can MutableRI be Audience Private? Can we get away with HRI and RI being Audience public only? Do we have to let MutableRI be Public? Thank you for working on this real nice cleanup. > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-13333) Renew Scanner Lease without advancing the RegionScanner
[ https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-1: -- Release Note: Adds a renewLease call to ClientScanner > Renew Scanner Lease without advancing the RegionScanner > --- > > Key: HBASE-1 > URL: https://issues.apache.org/jira/browse/HBASE-1 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 > > Attachments: 1-0.98.txt, 1-master.txt > > > We have a usecase (for Phoenix) where we want to let the server know that the > client is still around. Like a client-side heartbeat. > Doing a full heartbeat is complicated, but we could add the ability to make > scanner call with caching set to 0. The server already does the right thing > (it renews the lease, but does not advance the scanner). > It looks like the client (ScannerCallable) also does the right thing. We > cannot break ResultScanner before HBase 2.0, but we can add a renewLease() > method to AbstractClientScaner. Phoenix (or any other caller) can then cast > to ClientScanner and call that method to ensure we renew the lease on the > server. > It would be a simple and fully backwards compatible change. [~giacomotaylor] > Comments? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15809) Basic Replication WebUI
[ https://issues.apache.org/jira/browse/HBASE-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158898#comment-16158898 ] Appy commented on HBASE-15809: -- I have a great UI for monitoring and javascript for it, but it needs a backend for metrics collection. Unfortunately, don't have bandwidth for it right now. > Basic Replication WebUI > --- > > Key: HBASE-15809 > URL: https://issues.apache.org/jira/browse/HBASE-15809 > Project: HBase > Issue Type: New Feature > Components: Replication, UI >Affects Versions: 2.0.0 >Reporter: Matteo Bertozzi >Assignee: Appy >Priority: Minor > Fix For: 2.0.0, 1.5.0 > > Attachments: HBASE-15809-v0.patch, HBASE-15809-v0.png, > HBASE-15809-v1.patch > > > At the moment the only way to have some insight on replication from the webui > is looking at zkdump and metrics. > the basic information useful to get started debugging are: peer information > and the view of WALs offsets for each peer. > https://reviews.apache.org/r/47275/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18764) add slow read block log entry to alert slow datanodeinfo when reading a block is slow
[
https://issues.apache.org/jira/browse/HBASE-18764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158789#comment-16158789
]
Josh Elser commented on HBASE-18764:
Thanks for the reply!
This is definitely one of those tricky kinds of situations. To use your same
argument against you, RS logging would still not give us a definitive clue as
to where the problem lies, just a hint of where to look. When a RegionServer is
processing 15+ RPCs at one point in time, it requires a bit of human effort to
figure out which handler thread was actually tied to the user whose request
missed the SLA. That's the crux of why I suggested looking at HDFS metrics
would be a better approach.
To that point, if you want to figure out why some specific request was slow,
and specifically what part of the request was slow, we'd instead want to use
something like HTrace to aggregate this. However, in practice, this too is
difficult due to the overhead of the tracing as well as the intermittent
slowness that typically comes with these kinds of problems.
bq. When we talk about hdfs metrics, we will see 95th, 90th, mean, median etc
Yep, that is the downside of using aggregations like percentiles :). In most
cases, we know that we don't want to look at tail of operation times because of
"expected" slowness (e.g. JVM garbage collection or compactions); however,
there are certainly cases when looking at all of the metrics is necessary to
identify a culprit. Specifically, the case you have identified when a small
percent of requests to HDFS or, even worse, a small percent of requests to a
DataNode fall outside the bounds of normalcy.
At the end of the day, I'm not trying to levy a veto on this kind of change,
but instead trying to outline some cases in which this will just have you
blocked on the next question :). Since I've already spent this much time
thinking about the subject, let me look closer at your patch too:
{noformat}
+ this.conf = new HBaseConfiguration();
{noformat}
The no-args constructor is deprecated.
{noformat}
+ this.slowReadNs =
+100 * conf.getInt("hbase.regionserver.hlog.slowsync.ms",
+DEFAULT_SLOW_READ_TIME_MS);
{noformat}
Create a new configuration property, don't reuse the slowsync key.
{noformat}
+ long timeInNanos = System.nanoTime() - startNano;
+ if (timeInNanos > this.slowReadNs) {
{noformat}
Nit: combine these two lines
{noformat}
+ DFSInputStream dfsInputStream = (DFSInputStream)
is.getWrappedStream();
{noformat}
You need to check if this is an instance of {{DFSInputStream}} instead of
blindly casting it.
{noformat}
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
{noformat}
We do not print to stdout/stderr directly. You use a logger to do that. In this
case, since this is not a critical codepath, I'd suggest you make a {{debug}}
log call, with a message making clear that the exception was caught trying to
collect this slowread information. We want to make sure that if/when this block
happens, an admin/user would not interpret the exception as something they need
to take action on.
> add slow read block log entry to alert slow datanodeinfo when reading a block
> is slow
> -
>
> Key: HBASE-18764
> URL: https://issues.apache.org/jira/browse/HBASE-18764
> Project: HBase
> Issue Type: Improvement
> Components: HFile
>Affects Versions: 1.1.2
>Reporter: Wang, Xinglong
>Priority: Minor
> Attachments: HBASE-18764.rev1.1.2.patch
>
>
> HBASE is on top of HDFS and both are distributed system. HBASE will also get
> impacted when there is struggler datanode due to network/disk/cpu issue. All
> HBASE read/scan towards that datanode will be slowdown. It's not easy for
> hbase admin to find out the struggler datanode in such case.
> While we have a log entry known as slow sync. One such entry is like the
> following. It will help hbase admin to quickly identify the slow datanode in
> the pipline in case of network/disk/cup issue with one of the 3 datanods in
> pipeline.
> {noformat}
> 2017-07-08 19:11:30,538 INFO [sync.3] wal.FSHLog: Slow sync cost: 490189 ms,
> current pipeline:
> [DatanodeInfoWithStorage[xx.xx.xx.xx:50010,DS-c391299a-aa9f-4146-ac7e-a493ae536bff,DISK],
> DatanodeInfoWithSt
> orage[xx.xx.xx.xx:50010,DS-21a85f8b-f389-4f9e-95a8-b711945fd210,DISK],
> DatanodeInfoWithStorage[xx.xx.xx.xx:50010,DS-aa48cef2-3554-482f-b49d-be4763f4d8b8,DISK]]
> {noformat}
> Inspired by slow sync log entry, I think it will also be beneficial for us to
> print out such kind of entry when we encounter slow read case. So that it
> will be easy to identify the slow datanode.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18781) Accessing table.jsp directly returns Exception to user.
[
https://issues.apache.org/jira/browse/HBASE-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158759#comment-16158759
]
Hadoop QA commented on HBASE-18781:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
56s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}110m
16s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18781 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886061/HBASE-18781.patch |
| Optional Tests | asflicense javac javadoc unit |
| uname | Linux 8ed530a36d94 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e69b05d |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8521/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8521/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Accessing table.jsp directly returns Exception to user.
> ---
>
> Key: HBASE-18781
> URL: https://issues.apache.org/jira/browse/HBASE-18781
> Project: HBase
> Issue Type: Bug
>Reporter: Janos Gub
>Assignee: Janos Gub
> Attachments: HBASE-18781.patch
>
>
> Discovered by [~stack] while accessing table.jsp directly.
> Moved a function up introduced in
> https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message
> to be more descriptive. See more on
> https://issues.apache.org/jira/browse/HBASE-17436?focusedCommentId=16142040=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16142040
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18298) RegionServerServices Interface cleanup for CP expose
[ https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-18298: --- Attachment: HBASE-18298_V4.patch > RegionServerServices Interface cleanup for CP expose > > > Key: HBASE-18298 > URL: https://issues.apache.org/jira/browse/HBASE-18298 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18298.patch, HBASE-18298_V2.patch, > HBASE-18298_V3.patch, HBASE-18298_V4.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158746#comment-16158746 ] Hudson commented on HBASE-15607: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #285 (See [https://builds.apache.org/job/HBase-1.3-JDK8/285/]) HBASE-15607 - Deprecating SnapShotInfo (Ram) (ramkrishna: rev ae6ff50dc4ff0ccae92b6ad3eed12916675920cc) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.3.patch, > HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18769) Make CompareFilter use generic CompareOperator instead of internal enum
[
https://issues.apache.org/jira/browse/HBASE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158696#comment-16158696
]
Hadoop QA commented on HBASE-18769:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 19 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
2s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
54s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
59s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
3s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
44s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
46s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
30s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
40s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}146m
55s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
7s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
55s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
30s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}157m 24s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} |
[jira] [Updated] (HBASE-18778) Use Comparator for StealJobQueue
[ https://issues.apache.org/jira/browse/HBASE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18778: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks [~chia7712] for reviewing. > Use Comparator for StealJobQueue > > > Key: HBASE-18778 > URL: https://issues.apache.org/jira/browse/HBASE-18778 > Project: HBase > Issue Type: Improvement > Components: Compaction >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18778.patch, HBASE-18778-v1.patch > > > To eliminate the confusing compareTo and equals implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18780: --- Summary: Remove HLogPrettyPrinter and hlog command (was: Remove HLogPrettyPrinter ) > Remove HLogPrettyPrinter and hlog command > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18780) Remove HLogPrettyPrinter and hlog command
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18780: --- Status: Patch Available (was: Open) > Remove HLogPrettyPrinter and hlog command > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18765) The value of balancerRan is true even though no plans are executed
[
https://issues.apache.org/jira/browse/HBASE-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158631#comment-16158631
]
Hudson commented on HBASE-18765:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3679 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3679/])
HBASE-18765 The value of balancerRan is true even though no plans are
(chia7712: rev e69b05d109d4afa4bc6201197407e3f40044c522)
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
> The value of balancerRan is true even though no plans are executed
> --
>
> Key: HBASE-18765
> URL: https://issues.apache.org/jira/browse/HBASE-18765
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18765.v0.patch
>
>
> {code}
> //We balance per group instead of per table
> List plans = new ArrayList<>();
> for(Map.Entry> tableMap:
> getRSGroupAssignmentsByTable(groupName).entrySet()) {
> LOG.info("Creating partial plan for table " + tableMap.getKey() + ": "
> + tableMap.getValue());
> List partialPlans =
> balancer.balanceCluster(tableMap.getValue());
> LOG.info("Partial plan for table " + tableMap.getKey() + ": " +
> partialPlans);
> if (partialPlans != null) {
> plans.addAll(partialPlans);
> }
> }
> long startTime = System.currentTimeMillis();
> balancerRan = plans != null;
> {code}
> The *plans* is never null.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18780) Remove HLogPrettyPrinter
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18780: --- Component/s: documentation > Remove HLogPrettyPrinter > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18780) Remove HLogPrettyPrinter
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18780: --- Hadoop Flags: Incompatible change > Remove HLogPrettyPrinter > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18780) Remove HLogPrettyPrinter
[ https://issues.apache.org/jira/browse/HBASE-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18780: --- Attachment: HBASE-18780.v0.patch > Remove HLogPrettyPrinter > - > > Key: HBASE-18780 > URL: https://issues.apache.org/jira/browse/HBASE-18780 > Project: HBase > Issue Type: Sub-task > Components: documentation, wal >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18780.v0.patch > > > WALPrettyPrinter was substituted for HLogPrettyPrinter. Remove it for 2.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18778) Use Comparator for StealJobQueue
[ https://issues.apache.org/jira/browse/HBASE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158626#comment-16158626 ] Duo Zhang commented on HBASE-18778: --- Will commit shortly. > Use Comparator for StealJobQueue > > > Key: HBASE-18778 > URL: https://issues.apache.org/jira/browse/HBASE-18778 > Project: HBase > Issue Type: Improvement > Components: Compaction >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18778.patch, HBASE-18778-v1.patch > > > To eliminate the confusing compareTo and equals implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18771) Incorrect StoreFileRefresh leading to split and compaction failures
[
https://issues.apache.org/jira/browse/HBASE-18771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158614#comment-16158614
]
Hadoop QA commented on HBASE-18771:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 81m 17s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
56s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}131m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.regionserver.TestCompaction |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.apache.hadoop.hbase.wal.TestWALFiltering |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.regionserver.TestColumnSeeking |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort |
| | org.apache.hadoop.hbase.regionserver.TestRegionIncrement |
| | org.apache.hadoop.hbase.regionserver.TestWALLockup |
| | org.apache.hadoop.hbase.master.TestTableStateManager |
| | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush |
| | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash |
| | org.apache.hadoop.hbase.master.TestSplitLogManager |
| | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport |
| | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss |
| | org.apache.hadoop.hbase.master.TestRollingRestart |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| |
[jira] [Commented] (HBASE-18778) Use Comparator for StealJobQueue
[ https://issues.apache.org/jira/browse/HBASE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158600#comment-16158600 ] Chia-Ping Tsai commented on HBASE-18778: +1 > Use Comparator for StealJobQueue > > > Key: HBASE-18778 > URL: https://issues.apache.org/jira/browse/HBASE-18778 > Project: HBase > Issue Type: Improvement > Components: Compaction >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18778.patch, HBASE-18778-v1.patch > > > To eliminate the confusing compareTo and equals implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18683) Upgrade hbase to commons-math 3
[ https://issues.apache.org/jira/browse/HBASE-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158584#comment-16158584 ] Peter Somogyi commented on HBASE-18683: --- TestAvoidCellReferencesIntoShippedBlocks passes locally. > Upgrade hbase to commons-math 3 > --- > > Key: HBASE-18683 > URL: https://issues.apache.org/jira/browse/HBASE-18683 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0 > > Attachments: HBASE-18683.master.001.patch, > HBASE-18683.master.001.patch, HBASE-18683.master.002.patch, > HBASE-18683.master.003.patch, HBASE-18683.master.003.patch, LICENSE.txt, > LICENSE-v3, NOTICE.txt, NOTICE-v3 > > > Upgrade hbase to use commons-math 3.6. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158583#comment-16158583 ] Hudson commented on HBASE-15607: FAILURE: Integrated in Jenkins build HBase-1.4 #907 (See [https://builds.apache.org/job/HBase-1.4/907/]) HBASE-15607 - Deprecating SnapShotInfo (Ram) (ramkrishna: rev 93fbf25e3162d79a697450a64c7a56b56c3d3179) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.3.patch, > HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18683) Upgrade hbase to commons-math 3
[
https://issues.apache.org/jira/browse/HBASE-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158576#comment-16158576
]
Hadoop QA commented on HBASE-18683:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 99m
2s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
18s{color} | {color:green} hbase-resource-bundle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}112m 48s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}298m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18683 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-18778) Use Comparator for StealJobQueue
[ https://issues.apache.org/jira/browse/HBASE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158565#comment-16158565 ] Duo Zhang commented on HBASE-18778: --- OK, all green. Any other concerns [~chia7712]? Thanks. > Use Comparator for StealJobQueue > > > Key: HBASE-18778 > URL: https://issues.apache.org/jira/browse/HBASE-18778 > Project: HBase > Issue Type: Improvement > Components: Compaction >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18778.patch, HBASE-18778-v1.patch > > > To eliminate the confusing compareTo and equals implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18778) Use Comparator for StealJobQueue
[
https://issues.apache.org/jira/browse/HBASE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158556#comment-16158556
]
Hadoop QA commented on HBASE-18778:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 46s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m
46s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18778 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886037/HBASE-18778-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 66d04d91c4d1 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e69b05d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8518/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8518/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Use Comparator for StealJobQueue
>
>
> Key: HBASE-18778
> URL: https://issues.apache.org/jira/browse/HBASE-18778
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18778.patch,
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158546#comment-16158546 ] Hudson commented on HBASE-15607: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #204 (See [https://builds.apache.org/job/HBase-1.3-IT/204/]) HBASE-15607 - Deprecating SnapShotInfo (Ram) (ramkrishna: rev ae6ff50dc4ff0ccae92b6ad3eed12916675920cc) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.3.patch, > HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18753) Introduce the unsynchronized TimeRangeTracker
[
https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158544#comment-16158544
]
Hadoop QA commented on HBASE-18753:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
52s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 32s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
27s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}120m
33s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
18s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.0 Server=1.12.0 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18753 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886023/HBASE-18753.v2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux f3911d1ff657 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e69b05d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8516/testReport/ |
| modules | C: hbase-common hbase-server hbase-mapreduce U: . |
| Console output |
[jira] [Updated] (HBASE-18781) Accessing table.jsp directly returns Exception to user.
[ https://issues.apache.org/jira/browse/HBASE-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-18781: -- Description: Discovered by [~stack] while accessing table.jsp directly. Moved a function up introduced in https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message to be more descriptive. See more on https://issues.apache.org/jira/browse/HBASE-17436?focusedCommentId=16142040=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16142040 was: Discovered by [~stack] while accessing table.jsp directly. Moved a function up introduced in https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message to be more descriptive. See more on HBASE-17436 > Accessing table.jsp directly returns Exception to user. > --- > > Key: HBASE-18781 > URL: https://issues.apache.org/jira/browse/HBASE-18781 > Project: HBase > Issue Type: Bug >Reporter: Janos Gub >Assignee: Janos Gub > Attachments: HBASE-18781.patch > > > Discovered by [~stack] while accessing table.jsp directly. > Moved a function up introduced in > https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message > to be more descriptive. See more on > https://issues.apache.org/jira/browse/HBASE-17436?focusedCommentId=16142040=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16142040 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158527#comment-16158527 ] Janos Gub edited comment on HBASE-17436 at 9/8/17 12:20 PM: Created separate ticket for the NPE. [~stack] could you please have a look on that too (https://issues.apache.org/jira/browse/HBASE-18781 )? Also, for me the tablesDetailed.jsp is working. Could you please help me out a bit how to reproduce this error? What user tables you have? I mean what are their name or any hint how to reproduce. was (Author: gubjanos): Created separate ticket for the NPE. [~stack] could you please have a look on that too (https://issues.apache.org/jira/browse/HBASE-18781)? Also, for me the tablesDetailed.jsp is working. Could you please help me out a bit how to reproduce this error? What user tables you have? I mean what are their name or any hint how to reproduce. > Add facility to provide more information for Other Regions seen on Master UI > > > Key: HBASE-17436 > URL: https://issues.apache.org/jira/browse/HBASE-17436 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Janos Gub > Labels: ui, usability > Fix For: 2.0.0 > > Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, > HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17436-v6.patch, > HBASE-17436-v7.patch, HBASE-17436-v8.patch, HBASE-17779-v3.patch, > HBASE-17779-v4.patch, initial.patch, regionstates.png, Screen Shot 2017-04-24 > at 8.43.31 PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png, > tableregions.png, table-selected.png > > > [~rpednekar] and I were looking at a case where the count displayed under > Other Regions was high (~1200). > Since the table page just maintains a count instead of List of region names, > it is very difficult for user to determine which regions belong to this > category. > We should provide facility to provide more details for this category (LOG, > JMX, etc). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158527#comment-16158527 ] Janos Gub edited comment on HBASE-17436 at 9/8/17 12:15 PM: Created separate ticket for the NPE. [~stack] could you please have a look on that too (https://issues.apache.org/jira/browse/HBASE-18781)? Also, for me the tablesDetailed.jsp is working. Could you please help me out a bit how to reproduce this error? What user tables you have? I mean what are their name or any hint how to reproduce. was (Author: gubjanos): Created separate ticket for the NPE. [~stack] could you please have a look on that too? Also, for me the tablesDetailed.jsp is working. Could you please help me out a bit how to reproduce this error? What user tables you have? I mean what are their name or any hint how to reproduce. > Add facility to provide more information for Other Regions seen on Master UI > > > Key: HBASE-17436 > URL: https://issues.apache.org/jira/browse/HBASE-17436 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Janos Gub > Labels: ui, usability > Fix For: 2.0.0 > > Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, > HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17436-v6.patch, > HBASE-17436-v7.patch, HBASE-17436-v8.patch, HBASE-17779-v3.patch, > HBASE-17779-v4.patch, initial.patch, regionstates.png, Screen Shot 2017-04-24 > at 8.43.31 PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png, > tableregions.png, table-selected.png > > > [~rpednekar] and I were looking at a case where the count displayed under > Other Regions was high (~1200). > Since the table page just maintains a count instead of List of region names, > it is very difficult for user to determine which regions belong to this > category. > We should provide facility to provide more details for this category (LOG, > JMX, etc). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158530#comment-16158530 ] Hudson commented on HBASE-15607: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #275 (See [https://builds.apache.org/job/HBase-1.3-JDK7/275/]) HBASE-15607 - Deprecating SnapShotInfo (Ram) (ramkrishna: rev ae6ff50dc4ff0ccae92b6ad3eed12916675920cc) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.3.patch, > HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158527#comment-16158527 ] Janos Gub commented on HBASE-17436: --- Created separate ticket for the NPE. [~stack] could you please have a look on that too? Also, for me the tablesDetailed.jsp is working. Could you please help me out a bit how to reproduce this error? What user tables you have? I mean what are their name or any hint how to reproduce. > Add facility to provide more information for Other Regions seen on Master UI > > > Key: HBASE-17436 > URL: https://issues.apache.org/jira/browse/HBASE-17436 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Janos Gub > Labels: ui, usability > Fix For: 2.0.0 > > Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, > HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17436-v6.patch, > HBASE-17436-v7.patch, HBASE-17436-v8.patch, HBASE-17779-v3.patch, > HBASE-17779-v4.patch, initial.patch, regionstates.png, Screen Shot 2017-04-24 > at 8.43.31 PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png, > tableregions.png, table-selected.png > > > [~rpednekar] and I were looking at a case where the count displayed under > Other Regions was high (~1200). > Since the table page just maintains a count instead of List of region names, > it is very difficult for user to determine which regions belong to this > category. > We should provide facility to provide more details for this category (LOG, > JMX, etc). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18781) Accessing table.jsp directly returns Exception to user.
[ https://issues.apache.org/jira/browse/HBASE-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-18781: -- Description: Discovered by [~stack] while accessing table.jsp directly. Moved a function up introduced in https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message to be more descriptive. See more on HBASE-17436 was: Discovered by [~stack] while accessing table.jsp directly. Moved a function up introduced in https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message to be more descriptive. > Accessing table.jsp directly returns Exception to user. > --- > > Key: HBASE-18781 > URL: https://issues.apache.org/jira/browse/HBASE-18781 > Project: HBase > Issue Type: Bug >Reporter: Janos Gub >Assignee: Janos Gub > Attachments: HBASE-18781.patch > > > Discovered by [~stack] while accessing table.jsp directly. > Moved a function up introduced in > https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message > to be more descriptive. See more on HBASE-17436 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18781) Accessing table.jsp directly returns Exception to user.
[ https://issues.apache.org/jira/browse/HBASE-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-18781: -- Status: Patch Available (was: Open) > Accessing table.jsp directly returns Exception to user. > --- > > Key: HBASE-18781 > URL: https://issues.apache.org/jira/browse/HBASE-18781 > Project: HBase > Issue Type: Bug >Reporter: Janos Gub >Assignee: Janos Gub > Attachments: HBASE-18781.patch > > > Discovered by [~stack] while accessing table.jsp directly. > Moved a function up introduced in > https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message > to be more descriptive. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18106) Redo ProcedureInfo and LockInfo
[ https://issues.apache.org/jira/browse/HBASE-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158526#comment-16158526 ] Balazs Meszaros commented on HBASE-18106: - Test runs locally. > Redo ProcedureInfo and LockInfo > --- > > Key: HBASE-18106 > URL: https://issues.apache.org/jira/browse/HBASE-18106 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: stack >Assignee: Balazs Meszaros >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18106.master.001.patch, > HBASE-18106.master.002.patch, HBASE-18106.master.003.patch, > HBASE-18106.master.004.patch, HBASE-18106.master.005.patch, > HBASE-18106.master.006.patch, HBASE-18106.master.007.patch, > HBASE-18106.master.008.patch, HBASE-18106.master.009.patch, > HBASE-18106.master.010.patch, HBASE-18106.master.011.patch, > HBASE-18106.master.011.patch, HBASE-18106.master.012.patch, > HBASE-18106.master.012.patch > > > ProcedureInfo was introduced as a lowest-common-denominator POJO that could > be used as a facade on PB Procedures. It was good for showing state of > Procedure framework in shell and UI. > Its a bit weird though. Its up in hbase-common rather than in Procedure and > it can only ever show a subset of the Procedure info. > I was thinking we could use the pb3.1 pb->JSON utility instead and emit a > JSON String wherever we need to export a view on procedure internals. > This issue is about exploring this possibility. Would depend on our having an > upgraded guava (so probably depends on the 'pre-build' project). > From ProcedureInfo and LockInfo need fixing in > https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.kid1jzo114xw -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18781) Accessing table.jsp directly returns Exception to user.
[ https://issues.apache.org/jira/browse/HBASE-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-18781: -- Attachment: HBASE-18781.patch > Accessing table.jsp directly returns Exception to user. > --- > > Key: HBASE-18781 > URL: https://issues.apache.org/jira/browse/HBASE-18781 > Project: HBase > Issue Type: Bug >Reporter: Janos Gub >Assignee: Janos Gub > Attachments: HBASE-18781.patch > > > Discovered by [~stack] while accessing table.jsp directly. > Moved a function up introduced in > https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message > to be more descriptive. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18781) Accessing table.jsp directly returns Exception to user.
Janos Gub created HBASE-18781: - Summary: Accessing table.jsp directly returns Exception to user. Key: HBASE-18781 URL: https://issues.apache.org/jira/browse/HBASE-18781 Project: HBase Issue Type: Bug Reporter: Janos Gub Assignee: Janos Gub Discovered by [~stack] while accessing table.jsp directly. Moved a function up introduced in https://issues.apache.org/jira/browse/HBASE-15675. Also changed error message to be more descriptive. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158519#comment-16158519 ] ramkrishna.s.vasudevan commented on HBASE-15607: Pushed to branch-1.3 and branch-1.4 Thanks Stack. > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.3.patch, > HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[ https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinxin fan updated HBASE-18090: --- Comment: was deleted (was: patch v2 (rebased branch-1.3) for review) > Improve TableSnapshotInputFormat to allow more multiple mappers per region > -- > > Key: HBASE-18090 > URL: https://issues.apache.org/jira/browse/HBASE-18090 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.4.0 >Reporter: Mikhail Antonov >Assignee: xinxin fan > Attachments: HBASE-18090-branch-1.3-v1.patch, > HBASE-18090-branch-1.3-v2.patch > > > TableSnapshotInputFormat runs one map task per region in the table snapshot. > This places unnecessary restriction that the region layout of the original > table needs to take the processing resources available to MR job into > consideration. Allowing to run multiple mappers per region (assuming > reasonably even key distribution) would be useful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[ https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158505#comment-16158505 ] xinxin fan commented on HBASE-18090: rebase branch-1.3, patch v2 for review > Improve TableSnapshotInputFormat to allow more multiple mappers per region > -- > > Key: HBASE-18090 > URL: https://issues.apache.org/jira/browse/HBASE-18090 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.4.0 >Reporter: Mikhail Antonov >Assignee: xinxin fan > Attachments: HBASE-18090-branch-1.3-v1.patch, > HBASE-18090-branch-1.3-v2.patch > > > TableSnapshotInputFormat runs one map task per region in the table snapshot. > This places unnecessary restriction that the region layout of the original > table needs to take the processing resources available to MR job into > consideration. Allowing to run multiple mappers per region (assuming > reasonably even key distribution) would be useful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[ https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158394#comment-16158394 ] xinxin fan edited comment on HBASE-18090 at 9/8/17 11:25 AM: - patch v2 (rebased branch-1.3) for review was (Author: xinxin fan): patch v2 for review > Improve TableSnapshotInputFormat to allow more multiple mappers per region > -- > > Key: HBASE-18090 > URL: https://issues.apache.org/jira/browse/HBASE-18090 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.4.0 >Reporter: Mikhail Antonov >Assignee: xinxin fan > Attachments: HBASE-18090-branch-1.3-v1.patch, > HBASE-18090-branch-1.3-v2.patch > > > TableSnapshotInputFormat runs one map task per region in the table snapshot. > This places unnecessary restriction that the region layout of the original > table needs to take the processing resources available to MR job into > consideration. Allowing to run multiple mappers per region (assuming > reasonably even key distribution) would be useful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region
[ https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158394#comment-16158394 ] xinxin fan edited comment on HBASE-18090 at 9/8/17 11:20 AM: - patch v2 for review was (Author: xinxin fan): patch v2 for review > Improve TableSnapshotInputFormat to allow more multiple mappers per region > -- > > Key: HBASE-18090 > URL: https://issues.apache.org/jira/browse/HBASE-18090 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 1.4.0 >Reporter: Mikhail Antonov >Assignee: xinxin fan > Attachments: HBASE-18090-branch-1.3-v1.patch, > HBASE-18090-branch-1.3-v2.patch > > > TableSnapshotInputFormat runs one map task per region in the table snapshot. > This places unnecessary restriction that the region layout of the original > table needs to take the processing resources available to MR job into > consideration. Allowing to run multiple mappers per region (assuming > reasonably even key distribution) would be useful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
