[jira] [Updated] (HBASE-18925) Need updated mockito for using java optional

[Appy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Appy updated HBASE-18925:
-
Status: Patch Available  (was: Open)

> Need updated mockito for using java optional
> 
>
> Key: HBASE-18925
> URL: https://issues.apache.org/jira/browse/HBASE-18925
> Project: HBase
>  Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18925.master.001.patch
>
>
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was 
> Optional.
> Instead, we want it to return Optional.empty(). 
> New mockito versions support this (and other java8 things) - 
> https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core 
> has had more than 50 releases after that 
> (https://mvnrepository.com/artifact/org.mockito/mockito-core). 
> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of 
> changing pom files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18925) Need updated mockito for using java optional

[Appy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Appy updated HBASE-18925:
-
Attachment: HBASE-18925.master.001.patch

> Need updated mockito for using java optional
> 
>
> Key: HBASE-18925
> URL: https://issues.apache.org/jira/browse/HBASE-18925
> Project: HBase
>  Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18925.master.001.patch
>
>
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was 
> Optional.
> Instead, we want it to return Optional.empty(). 
> New mockito versions support this (and other java8 things) - 
> https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core 
> has had more than 50 releases after that 
> (https://mvnrepository.com/artifact/org.mockito/mockito-core). 
> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of 
> changing pom files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18922) Fix all dead links in our HBase book

[Chia-Ping Tsai (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189287#comment-16189287
 ] 

Chia-Ping Tsai commented on HBASE-18922:


bq. Could you assign this issue to me?
done

> Fix all dead links in our HBase book
> 
>
> Key: HBASE-18922
> URL: https://issues.apache.org/jira/browse/HBASE-18922
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chia-Ping Tsai
>Assignee: Yung-An He
>  Labels: beginner
> Fix For: 2.0.0
>
>
> see 
> [here|https://paper.dropbox.com/doc/dead-links-in-HBase-book-8YcTcH5mxZKn9TYlKJJq4?_tk=share_copylink]
>  to find the dead links.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18922) Fix all dead links in our HBase book

[Chia-Ping Tsai (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai reassigned HBASE-18922:
--

Assignee: Yung-An He

> Fix all dead links in our HBase book
> 
>
> Key: HBASE-18922
> URL: https://issues.apache.org/jira/browse/HBASE-18922
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chia-Ping Tsai
>Assignee: Yung-An He
>  Labels: beginner
> Fix For: 2.0.0
>
>
> see 
> [here|https://paper.dropbox.com/doc/dead-links-in-HBase-book-8YcTcH5mxZKn9TYlKJJq4?_tk=share_copylink]
>  to find the dead links.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189269#comment-16189269
 ] 

Hadoop QA commented on HBASE-14093:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
6s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  3m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
19s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  5m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  5m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  3m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
13s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
32s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
43m 10s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  
9s{color} | {color:green} hbase-static-web-resources in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m 
51s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
53s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
7s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
26s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
25s{color} | {color:green} hbase-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}155m 
59s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  2m 
20s{color} | {color:green} The patch does not generate ASF License 

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189268#comment-16189268
 ] 

stack commented on HBASE-18601:
---

Did you fix the NPEs [~tamaas] that Mr. [~mdrob] noted above sir? Thanks.

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18925) Need updated mockito for using java optional

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189266#comment-16189266
 ] 

stack commented on HBASE-18925:
---

Good one. Lets do this.

> Need updated mockito for using java optional
> 
>
> Key: HBASE-18925
> URL: https://issues.apache.org/jira/browse/HBASE-18925
> Project: HBase
>  Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-beta-1
>
>
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was 
> Optional.
> Instead, we want it to return Optional.empty(). 
> New mockito versions support this (and other java8 things) - 
> https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core 
> has had more than 50 releases after that 
> (https://mvnrepository.com/artifact/org.mockito/mockito-core). 
> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of 
> changing pom files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18925) Need updated mockito for using java optional

[stack (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18925:
--
Fix Version/s: 2.0.0-beta-1

> Need updated mockito for using java optional
> 
>
> Key: HBASE-18925
> URL: https://issues.apache.org/jira/browse/HBASE-18925
> Project: HBase
>  Issue Type: Improvement
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-beta-1
>
>
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was 
> Optional.
> Instead, we want it to return Optional.empty(). 
> New mockito versions support this (and other java8 things) - 
> https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core 
> has had more than 50 releases after that 
> (https://mvnrepository.com/artifact/org.mockito/mockito-core). 
> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of 
> changing pom files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189259#comment-16189259
 ] 

Peter Somogyi commented on HBASE-18815:
---

Unit tests timed out, reattached patch 5.

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch, 
> HBASE-18815.master.004.patch, HBASE-18815.master.005.patch, 
> HBASE-18815.master.005.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18815:
--
Attachment: HBASE-18815.master.005.patch

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch, 
> HBASE-18815.master.004.patch, HBASE-18815.master.005.patch, 
> HBASE-18815.master.005.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18814) Make ScanMetrics enabled and add counter into the MapReduce Job over snapshot

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189257#comment-16189257
 ] 

Hudson commented on HBASE-18814:


SUCCESS: Integrated in Jenkins build HBase-1.4 #939 (See 
[https://builds.apache.org/job/HBase-1.4/939/])
HBASE-18814 Make ScanMetrics enabled and add counter  Make ScanMetrics enabled and add counter  into 
> the MapReduce Job over snapshot
> 
>
> Key: HBASE-18814
> URL: https://issues.apache.org/jira/browse/HBASE-18814
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 2.0.0-alpha-2
>Reporter: xinxin fan
>Assignee: xinxin fan
>Priority: Minor
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18814-V1-master.patch
>
>
> Now the default counters of mapreduce over snapshot does not contain the 
> HBase Counters as the scan metrics not set enabled. It's necessary to display 
> the HBase Counters , especially the ROWS_SCANNED counter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189256#comment-16189256
 ] 

stack commented on HBASE-18926:
---

Thanks for the pointer [~appy]  The argument that Optional as param adds 
complexity seems fair. Optional in return or even as data member seems fine 
though.

> Cleanup Optional from method params
> --
>
> Key: HBASE-18926
> URL: https://issues.apache.org/jira/browse/HBASE-18926
> Project: HBase
>  Issue Type: Improvement
>Reporter: Appy
>Assignee: Duo Zhang
>
> ref: Discussion on HBASE-18878
> tldr: Optional is not supposed to be used in method params or class fields 
> (http://dolszewski.com/java/java-8-optional-use-cases/). We are doing that in 
> some places. Let's revert that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18814) Make ScanMetrics enabled and add counter into the MapReduce Job over snapshot

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189251#comment-16189251
 ] 

Hudson commented on HBASE-18814:


SUCCESS: Integrated in Jenkins build HBase-1.5 #83 (See 
[https://builds.apache.org/job/HBase-1.5/83/])
HBASE-18814 Make ScanMetrics enabled and add counter  Make ScanMetrics enabled and add counter  into 
> the MapReduce Job over snapshot
> 
>
> Key: HBASE-18814
> URL: https://issues.apache.org/jira/browse/HBASE-18814
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 2.0.0-alpha-2
>Reporter: xinxin fan
>Assignee: xinxin fan
>Priority: Minor
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18814-V1-master.patch
>
>
> Now the default counters of mapreduce over snapshot does not contain the 
> HBase Counters as the scan metrics not set enabled. It's necessary to display 
> the HBase Counters , especially the ROWS_SCANNED counter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18894) null pointer exception in list_regions in shell command

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189250#comment-16189250
 ] 

Hudson commented on HBASE-18894:


FAILURE: Integrated in Jenkins build HBase-2.0 #616 (See 
[https://builds.apache.org/job/HBase-2.0/616/])
HBASE-18894: null pointer exception in list_regions in shell command (mdrob: 
rev 176d8bd2c7dcfc7ecb619bd48eb0c4faf94a688c)
* (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb


> null pointer exception in list_regions in shell command
> ---
>
> Key: HBASE-18894
> URL: https://issues.apache.org/jira/browse/HBASE-18894
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0-alpha-3
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18894-v1-master.patch, 
> HBASE-18894-v2-master.patch, HBASE-18894-v3-master.patch
>
>
> See this error when run list_regions command After disable 't1'
> or after running split 't1', will see this error before split complete
> this caused by region is disabled or still in transition
> {quote}
> list_regions 't1'
> ERROR: undefined method `getDataLocality' for nil:NilClass
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18894) null pointer exception in list_regions in shell command

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189240#comment-16189240
 ] 

Hudson commented on HBASE-18894:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3817 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3817/])
HBASE-18894: null pointer exception in list_regions in shell command (mdrob: 
rev 4093cc0291aa7f00ec75a0bae48841ac85eb1fa5)
* (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb


> null pointer exception in list_regions in shell command
> ---
>
> Key: HBASE-18894
> URL: https://issues.apache.org/jira/browse/HBASE-18894
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0-alpha-3
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18894-v1-master.patch, 
> HBASE-18894-v2-master.patch, HBASE-18894-v3-master.patch
>
>
> See this error when run list_regions command After disable 't1'
> or after running split 't1', will see this error before split complete
> this caused by region is disabled or still in transition
> {quote}
> list_regions 't1'
> ERROR: undefined method `getDataLocality' for nil:NilClass
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18913) TestShell fails because NoMethodError: undefined method parseColumn

[Guanghao Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18913:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to master and branch-2.

> TestShell fails because NoMethodError: undefined method parseColumn
> ---
>
> Key: HBASE-18913
> URL: https://issues.apache.org/jira/browse/HBASE-18913
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18913.master.002.patch, HBASE-18913.patch
>
>
> Error: 
> ^[[48;5;16;38;5;226;1mtest_truncate_preserve_should_empty_a_table(Hbase::AdminMethodsTest)^[[0m:
>  NoMethodError: undefined method `parseColumn' for 
> Java::OrgApacheHadoopHbase::KeyValue:Class
> org/jruby/RubyBasicObject.java:1653:in `method_missing'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:725:in 
> `parse_column_name'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:131:in 
> `_put_internal'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands/put.rb:49:in
>  `put'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:38:in 
> `block in command_safe'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:108:in
>  `translate_hbase_exceptions'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:38:in 
> `command_safe'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell.rb:155:in 
> `internal_command'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:47:in 
> `block in put'
> src/test/ruby/hbase/admin_test.rb:291:in `block in 
> test_truncate_preserve_should_empty_a_table'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Ashish Singhi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189233#comment-16189233
 ] 

Ashish Singhi commented on HBASE-18900:
---

lgtm

> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18703) Inconsistent behavior for preBatchMutate in doMiniBatchMutate and processRowsWithLocks

[Umesh Agashe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Agashe updated HBASE-18703:
-
Attachment: hbase-18703.master.005.patch

retry

> Inconsistent behavior for preBatchMutate in doMiniBatchMutate and 
> processRowsWithLocks
> --
>
> Key: HBASE-18703
> URL: https://issues.apache.org/jira/browse/HBASE-18703
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Umesh Agashe
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: hbase-18703.master.001.patch, 
> hbase-18703.master.002.patch, hbase-18703.master.003.patch, 
> hbase-18703.master.004.patch, hbase-18703.master.005.patch, 
> hbase-18703.master.005.patch
>
>
> In doMiniBatchMutate, the preBatchMutate is called before building WAL, but 
> in processRowsWithLocks, we suggest the RowProcessor implementation to build 
> WAL in process  method, which is ahead of preBatchMutate.
> If a CP modifies the mutations, especially if it removes some cells from the 
> mutations, then the behavior of processRowsWithLocks is broken. The changes 
> applied to memstore and WAL will be different. And there is no way to remove 
> entries from a WALEdit through CP. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189227#comment-16189227
 ] 

Duo Zhang commented on HBASE-18926:
---

Thanks [~appy].

> Cleanup Optional from method params
> --
>
> Key: HBASE-18926
> URL: https://issues.apache.org/jira/browse/HBASE-18926
> Project: HBase
>  Issue Type: Improvement
>Reporter: Appy
>Assignee: Duo Zhang
>
> ref: Discussion on HBASE-18878
> tldr: Optional is not supposed to be used in method params or class fields 
> (http://dolszewski.com/java/java-8-optional-use-cases/). We are doing that in 
> some places. Let's revert that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189226#comment-16189226
 ] 

Duo Zhang commented on HBASE-18878:
---

Oh, just see your first comment. If we want to hide some methods, I prefer 
using an interface. I think you can open a new jira to do this first.

For the optional change I need to consider it again. In my original design, I 
tend to use Optional for all possible null parameters and return values. I 
think this is really useful as if an parameter or return value is not an 
Optional then you must provide it or do not need to do null check. For now 
either you need to dig deeply to see if it could be null, or you need null 
check everywhere which makes the code ugly...

Give me some time. I need to rethink that if method overload can solve the 
problem.

Thanks.

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189225#comment-16189225
 ] 

Appy commented on HBASE-18878:
--

Oh, i am sorry, i never refreshed my browser between comments. I wasn't 
expecting replies you see. :)  Go back to enjoying your holidays!! :P  :D

bq. And I’m not fully convinced by the reason that why Optional should not be 
used as a parameter
Me neither. But am not expert on jdk8 yet, so i too took the path of 
conventional wisdom. 

bq. I’ve already used lots of Optional parameters in the code.
Once you're back, we can hunt them together. 

bq. Any way, let’s instead adding Nullable annotations to indicate that a 
parameter could be null? My experience is that it is really a pain that we do 
not know if a variable could be null or not when implementing a class, 
especially if it is used everywhere in the class... Doing Null check everywhere 
but missing at some places is really confusing...

Absolutely with you on this. But which @Nullable. There are quite a few in the 
market. Let me defer the decision making on that to when you are back and at 
least keep making progress on returning Optional instead of T.

Filed a jira for cleanup of previously added Optional in method params.  
HBASE-18926

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18926) Cleanup Optional from method params

[Appy (JIRA)]

Appy created HBASE-18926:


 Summary: Cleanup Optional from method params
 Key: HBASE-18926
 URL: https://issues.apache.org/jira/browse/HBASE-18926
 Project: HBase
  Issue Type: Improvement
Reporter: Appy
Assignee: Duo Zhang


ref: Discussion on HBASE-18878
tldr: Optional is not supposed to be used in method params or class fields 
(http://dolszewski.com/java/java-8-optional-use-cases/). We are doing that in 
some places. Let's revert that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189215#comment-16189215
 ] 

Duo Zhang commented on HBASE-18878:
---

I’m traveling so can only access jira with a mobile device. That’s why I say 
that you can first file a jira to track the existing Optional parameters as I 
can not review the code until Oct 9th...

Thanks.

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189214#comment-16189214
 ] 

Appy edited comment on HBASE-18878 at 10/3/17 3:27 AM:
---

Uploaded patch with only return calls changed to optional.
{noformat}
These functions have been changed to return Optional instead of T, where T = 
old return type.
- ObserverContext#getCaller
- RpcCallContext#getRequestUser
- RpcCallContext#getRequestUserName
- RpcServer#getCurrentCall
- RpcServer#getRequestUser
- RpcServer#getRequestUserName
- RpcServer#getRemoteAddress
- ServerCall#getRequestUser
{noformat}


was (Author: appy):
Uploaded patch with only return calls changed to optional.
{noformat}
These functions have been changed to return Optional instead of T, where T = 
old return type.
- ObserverContext#getCaller
- RpcCallContext#getRequestUser
- RpcCallContext#getRequestUserName
- RpcServer#getCurrentCall
- RpcServer#getRequestUser
- RpcServer#getRequestUserName
- RpcServer#getRemoteAddress
- ServerCall#getRequestUse
{noformat}

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189214#comment-16189214
 ] 

Appy commented on HBASE-18878:
--

Uploaded patch with only return calls changed to optional.
{noformat}
These functions have been changed to return Optional instead of T, where T = 
old return type.
- ObserverContext#getCaller
- RpcCallContext#getRequestUser
- RpcCallContext#getRequestUserName
- RpcServer#getCurrentCall
- RpcServer#getRequestUser
- RpcServer#getRequestUserName
- RpcServer#getRemoteAddress
- ServerCall#getRequestUse
{noformat}

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Appy updated HBASE-18878:
-
Attachment: HBASE-18878.master.001.patch

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.master.001.patch, HBASE-18878.patch, 
> HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18925) Need updated mockito for using java optional

[Appy (JIRA)]

Appy created HBASE-18925:


 Summary: Need updated mockito for using java optional
 Key: HBASE-18925
 URL: https://issues.apache.org/jira/browse/HBASE-18925
 Project: HBase
  Issue Type: Improvement
Reporter: Appy
Assignee: Appy


Came up when i was trying to test HBASE-18878.
It kept failing because mock of RpcCall returned null where return type was 
Optional.
Instead, we want it to return Optional.empty(). 
New mockito versions support this (and other java8 things) - 
https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2

We use mockito-all which was last released in Dec2014. However, mockito-core 
has had more than 50 releases after that 
(https://mvnrepository.com/artifact/org.mockito/mockito-core). 
We need to change our deps from mockito-all to mockito-core.
However that comes with fair breakages, so this is not a simple task of 
changing pom files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18913) TestShell fails because NoMethodError: undefined method parseColumn

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189208#comment-16189208
 ] 

Hadoop QA commented on HBASE-18913:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green}  0m  
5s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
10s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
39m 20s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
54s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 40s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18913 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12890089/HBASE-18913.master.002.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux 079afe6fd2b9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 214d219 |
| Default Java | 1.8.0_144 |
| rubocop | v0.50.0 |
| ruby-lint | v2.3.1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8906/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8906/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> TestShell fails because NoMethodError: undefined method parseColumn
> ---
>
> Key: HBASE-18913
> URL: https://issues.apache.org/jira/browse/HBASE-18913
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18913.master.002.patch, HBASE-18913.patch
>
>
> Error: 
> ^[[48;5;16;38;5;226;1mtest_truncate_preserve_should_empty_a_table(Hbase::AdminMethodsTest)^[[0m:
>  NoMethodError: undefined method `parseColumn' for 
> Java::OrgApacheHadoopHbase::KeyValue:Class
> 

[jira] [Commented] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189205#comment-16189205
 ] 

Hadoop QA commented on HBASE-18815:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 20 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
55s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m 43s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m  2s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
55s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
33s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m  1s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
 |
|   | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
|   | org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink |
|   | org.apache.hadoop.hbase.replication.regionserver.TestGlobalThrottler |
|   | org.apache.hadoop.hbase.replication.TestReplicationTableBase |
|   | 
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
 |
|   | 
org.apache.hadoop.hbase.replication.regionserver.TestTableBasedReplicationSourceManagerImpl
 |
|   | 

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189194#comment-16189194
 ] 

Hadoop QA commented on HBASE-18601:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
25s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  7m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-testing-util . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 13m  
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  7m 
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
14s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
34s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  9m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  6m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green}  0m  
4s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
25s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
19s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m 20s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-testing-util . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
41s{color} | {color:red} hbase-common generated 1 new + 0 unchanged - 0 fixed = 
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
26s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
17s{color} | {color:green} hbase-common in the patch 

[jira] [Commented] (HBASE-18703) Inconsistent behavior for preBatchMutate in doMiniBatchMutate and processRowsWithLocks

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189197#comment-16189197
 ] 

Hadoop QA commented on HBASE-18703:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
18s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m  1s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
22s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 71m 10s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
51s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}134m 40s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay |
|   | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
|   | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
|   | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
|   | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy 
|
|   | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
|   | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
|   | org.apache.hadoop.hbase.regionserver.TestCompaction |
|   | org.apache.hadoop.hbase.trace.TestHTraceHooks |
|   | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|   | 

[jira] [Comment Edited] (HBASE-18909) Deprecate Admin's methods which used String regex

[Guanghao Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189190#comment-16189190
 ] 

Guanghao Zhang edited comment on HBASE-18909 at 10/3/17 2:37 AM:
-

Attach a patch to fix the too long line report. But why ruby-lint report 
"undefined method java_import"? [~mdrob] Any ideas?


was (Author: zghaobac):
Attach a patch to fix the long to line report. But why ruby-lint report 
"undefined method java_import"? [~mdrob] Any ideas?

> Deprecate Admin's methods which used String regex
> -
>
> Key: HBASE-18909
> URL: https://issues.apache.org/jira/browse/HBASE-18909
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18909.master.001.patch, 
> HBASE-18909.master.002.patch, HBASE-18909.master.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18909) Deprecate Admin's methods which used String regex

[Guanghao Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189190#comment-16189190
 ] 

Guanghao Zhang commented on HBASE-18909:


Attach a patch to fix the long to line report. But why ruby-lint report 
"undefined method java_import"? [~mdrob] Any ideas?

> Deprecate Admin's methods which used String regex
> -
>
> Key: HBASE-18909
> URL: https://issues.apache.org/jira/browse/HBASE-18909
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18909.master.001.patch, 
> HBASE-18909.master.002.patch, HBASE-18909.master.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18909) Deprecate Admin's methods which used String regex

[Guanghao Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18909:
---
Attachment: HBASE-18909.master.003.patch

> Deprecate Admin's methods which used String regex
> -
>
> Key: HBASE-18909
> URL: https://issues.apache.org/jira/browse/HBASE-18909
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18909.master.001.patch, 
> HBASE-18909.master.002.patch, HBASE-18909.master.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18913) TestShell fails because NoMethodError: undefined method parseColumn

[Guanghao Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189181#comment-16189181
 ] 

Guanghao Zhang commented on HBASE-18913:


Thanks [~chia7712] for the addendum. Attach a patch for parseColumn. Will 
commit it later.

> TestShell fails because NoMethodError: undefined method parseColumn
> ---
>
> Key: HBASE-18913
> URL: https://issues.apache.org/jira/browse/HBASE-18913
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18913.master.002.patch, HBASE-18913.patch
>
>
> Error: 
> ^[[48;5;16;38;5;226;1mtest_truncate_preserve_should_empty_a_table(Hbase::AdminMethodsTest)^[[0m:
>  NoMethodError: undefined method `parseColumn' for 
> Java::OrgApacheHadoopHbase::KeyValue:Class
> org/jruby/RubyBasicObject.java:1653:in `method_missing'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:725:in 
> `parse_column_name'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:131:in 
> `_put_internal'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands/put.rb:49:in
>  `put'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:38:in 
> `block in command_safe'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:108:in
>  `translate_hbase_exceptions'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:38:in 
> `command_safe'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell.rb:155:in 
> `internal_command'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:47:in 
> `block in put'
> src/test/ruby/hbase/admin_test.rb:291:in `block in 
> test_truncate_preserve_should_empty_a_table'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18913) TestShell fails because NoMethodError: undefined method parseColumn

[Guanghao Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18913:
---
Attachment: HBASE-18913.master.002.patch

> TestShell fails because NoMethodError: undefined method parseColumn
> ---
>
> Key: HBASE-18913
> URL: https://issues.apache.org/jira/browse/HBASE-18913
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18913.master.002.patch, HBASE-18913.patch
>
>
> Error: 
> ^[[48;5;16;38;5;226;1mtest_truncate_preserve_should_empty_a_table(Hbase::AdminMethodsTest)^[[0m:
>  NoMethodError: undefined method `parseColumn' for 
> Java::OrgApacheHadoopHbase::KeyValue:Class
> org/jruby/RubyBasicObject.java:1653:in `method_missing'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:725:in 
> `parse_column_name'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:131:in 
> `_put_internal'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands/put.rb:49:in
>  `put'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:38:in 
> `block in command_safe'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:108:in
>  `translate_hbase_exceptions'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell/commands.rb:38:in 
> `command_safe'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/shell.rb:155:in 
> `internal_command'
> /home/hao/open_source/hbase/hbase-shell/src/main/ruby/hbase/table.rb:47:in 
> `block in put'
> src/test/ruby/hbase/admin_test.rb:291:in `block in 
> test_truncate_preserve_should_empty_a_table'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18922) Fix all dead links in our HBase book

[Yung-An He (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189174#comment-16189174
 ] 

Yung-An He commented on HBASE-18922:


Hi [~chia7712],
Are all the dead links in the list of description? 
I could re-scan the HBase book and test all the links which are available or 
dead.
Could you assign this issue to me?

> Fix all dead links in our HBase book
> 
>
> Key: HBASE-18922
> URL: https://issues.apache.org/jira/browse/HBASE-18922
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chia-Ping Tsai
>  Labels: beginner
> Fix For: 2.0.0
>
>
> see 
> [here|https://paper.dropbox.com/doc/dead-links-in-HBase-book-8YcTcH5mxZKn9TYlKJJq4?_tk=share_copylink]
>  to find the dead links.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189173#comment-16189173
 ] 

Duo Zhang commented on HBASE-18878:
---

The patch has not been pushed yet so no problem for now? You can file a issue 
and post the existing warnings there and let’s solve the problems case by case?

Thanks.

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.patch, HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189169#comment-16189169
 ] 

Hadoop QA commented on HBASE-16894:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 7s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
33s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
41s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
57s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
26s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m 
10s{color} | {color:red} The patch causes 178 errors with Hadoop v3.0.0-alpha4. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}393m  8s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  3m 
49s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}432m 36s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.snapshot.TestRegionSnapshotTask |
|   | hadoop.hbase.client.TestAdmin2 |
|   | hadoop.hbase.master.TestMasterBalanceThrottling |
|   | hadoop.hbase.regionserver.TestRecoveredEdits |
|   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
| Timed out junit tests | 

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189168#comment-16189168
 ] 

Appy commented on HBASE-18878:
--

It's specially not good in our {{ObserverContext(User user)}} given we already 
have unnecessary churn of creating these context objects even though there 
might be no corresponding hook in any loaded observer. HBASE-18898

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.patch, HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18867) maven enforcer plugin needs update to work with jdk9

[Mike Drob (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189166#comment-16189166
 ] 

Mike Drob commented on HBASE-18867:
---

Once I upgraded from my early access version of java 9 to the GA version I 
started seeing the same enforcer failure. Patch fixed it for me.

+1

> maven enforcer plugin needs update to work with jdk9
> 
>
> Key: HBASE-18867
> URL: https://issues.apache.org/jira/browse/HBASE-18867
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Affects Versions: 2.0.0-alpha-3
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 2.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-18867.0.patch
>
>
> build fails under jdk9, even when targeting java 8
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4:enforce 
> (min-maven-min-java-banned-xerces) on project hbase: Execution 
> min-maven-min-java-banned-xerces of goal 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4:enforce failed: An API 
> incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4:enforce: 
> java.lang.ExceptionInInitializerError: null
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/1.4/maven-enforcer-plugin-1.4.jar
> [ERROR] urls[1] = 
> file:/Users/busbey/.m2/repository/org/codehaus/mojo/extra-enforcer-rules/1.0-beta-6/extra-enforcer-rules-1.0-beta-6.jar
> [ERROR] urls[2] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar
> [ERROR] urls[3] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [ERROR] urls[4] = 
> file:/Users/busbey/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar
> [ERROR] urls[5] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/1.4/maven-common-artifact-filters-1.4.jar
> [ERROR] urls[6] = 
> file:/Users/busbey/.m2/repository/com/ibm/icu/icu4j/56.1/icu4j-56.1.jar
> [ERROR] urls[7] = 
> file:/Users/busbey/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
> [ERROR] urls[8] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
> [ERROR] urls[9] = 
> file:/Users/busbey/.m2/repository/org/slf4j/slf4j-jdk14/1.5.6/slf4j-jdk14-1.5.6.jar
> [ERROR] urls[10] = 
> file:/Users/busbey/.m2/repository/org/slf4j/jcl-over-slf4j/1.5.6/jcl-over-slf4j-1.5.6.jar
> [ERROR] urls[11] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
> [ERROR] urls[12] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.jar
> [ERROR] urls[13] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
> [ERROR] urls[14] = 
> file:/Users/busbey/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
> [ERROR] urls[15] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
> [ERROR] urls[16] = 
> file:/Users/busbey/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
> [ERROR] urls[17] = 
> file:/Users/busbey/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
> [ERROR] urls[18] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
> [ERROR] urls[19] = 
> file:/Users/busbey/.m2/repository/commons-lang/commons-lang/2.3/commons-lang-2.3.jar
> [ERROR] urls[20] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.4/enforcer-api-1.4.jar
> [ERROR] urls[21] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/enforcer/enforcer-rules/1.4/enforcer-rules-1.4.jar
> [ERROR] urls[22] = 
> file:/Users/busbey/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar
> [ERROR] urls[23] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-6/plexus-i18n-1.0-beta-6.jar
> [ERROR] urls[24] = 
> file:/Users/busbey/.m2/repository/org/apache/maven/plugin-testing/maven-plugin-testing-harness/1.3/maven-plugin-testing-harness-1.3.jar
> [ERROR] urls[25] = 
> file:/Users/busbey/.m2/repository/org/codehaus/plexus/plexus-archiver/2.2/plexus-archiver-2.2.jar
> [ERROR] urls[26] = 
> 

[jira] [Updated] (HBASE-18814) Make ScanMetrics enabled and add counter into the MapReduce Job over snapshot

[Ashu Pachauri (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashu Pachauri updated HBASE-18814:
--
Fix Version/s: (was: 2.0.0)
   2.0.0-beta-1
   1.4.0

> Make ScanMetrics enabled and add counter  into 
> the MapReduce Job over snapshot
> 
>
> Key: HBASE-18814
> URL: https://issues.apache.org/jira/browse/HBASE-18814
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 2.0.0-alpha-2
>Reporter: xinxin fan
>Assignee: xinxin fan
>Priority: Minor
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18814-V1-master.patch
>
>
> Now the default counters of mapreduce over snapshot does not contain the 
> HBase Counters as the scan metrics not set enabled. It's necessary to display 
> the HBase Counters , especially the ROWS_SCANNED counter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18814) Make ScanMetrics enabled and add counter into the MapReduce Job over snapshot

[Ashu Pachauri (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashu Pachauri updated HBASE-18814:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Make ScanMetrics enabled and add counter  into 
> the MapReduce Job over snapshot
> 
>
> Key: HBASE-18814
> URL: https://issues.apache.org/jira/browse/HBASE-18814
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 2.0.0-alpha-2
>Reporter: xinxin fan
>Assignee: xinxin fan
>Priority: Minor
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-18814-V1-master.patch
>
>
> Now the default counters of mapreduce over snapshot does not contain the 
> HBase Counters as the scan metrics not set enabled. It's necessary to display 
> the HBase Counters , especially the ROWS_SCANNED counter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18814) Make ScanMetrics enabled and add counter into the MapReduce Job over snapshot

[Ashu Pachauri (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189157#comment-16189157
 ] 

Ashu Pachauri commented on HBASE-18814:
---

Pushed to master, branch-2, branch-1 and branch-1.4. Thanks [~xinxin fan] for 
the patch and [~Apache9] for the review.

> Make ScanMetrics enabled and add counter  into 
> the MapReduce Job over snapshot
> 
>
> Key: HBASE-18814
> URL: https://issues.apache.org/jira/browse/HBASE-18814
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 2.0.0-alpha-2
>Reporter: xinxin fan
>Assignee: xinxin fan
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18814-V1-master.patch
>
>
> Now the default counters of mapreduce over snapshot does not contain the 
> HBase Counters as the scan metrics not set enabled. It's necessary to display 
> the HBase Counters , especially the ROWS_SCANNED counter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Duo Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189156#comment-16189156
 ] 

Duo Zhang commented on HBASE-18878:
---

I’ve already used lots of Optional parameters in the code. So if IDEA think 
this is not the right case then let’s clean up those usage first instead of fix 
this one?

And I’m not fully convinced by the reason that why Optional should not be used 
as a parameter. They suggest to use method overload to hide the nullable 
parameter, and an Optional parameter requires extra wrapping. But what if the 
parameter is gotten from an method which returns an Optional? So I need to 
check if the parameter is present and then call different method?

But anyway, if a common used IDE shows warnings, I think it is better to remove 
theses usages as it may confuse a lot of developers. Any way, let’s instead 
adding Nullable annotations to indicate that a parameter could be null? My 
experience is that it is really a pain that we do not know if a variable could 
be null or not when implementing a class, especially if it is used everywhere 
in the class... Doing Null check everywhere but missing at some places is 
really confusing...

> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.patch, HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18814) Make ScanMetrics enabled and add counter into the MapReduce Job over snapshot

[Ashu Pachauri (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189154#comment-16189154
 ] 

Ashu Pachauri commented on HBASE-18814:
---

+1

> Make ScanMetrics enabled and add counter  into 
> the MapReduce Job over snapshot
> 
>
> Key: HBASE-18814
> URL: https://issues.apache.org/jira/browse/HBASE-18814
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 2.0.0-alpha-2
>Reporter: xinxin fan
>Assignee: xinxin fan
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-18814-V1-master.patch
>
>
> Now the default counters of mapreduce over snapshot does not contain the 
> HBase Counters as the scan metrics not set enabled. It's necessary to display 
> the HBase Counters , especially the ROWS_SCANNED counter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18923) TestTableResource flaky on branch-1

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189150#comment-16189150
 ] 

Andrew Purtell commented on HBASE-18923:


A bisect says this is the first bad commit

commit b2943504b867e7b26e7c6433f026a602ef42a0ab
Author: Pankaj Kumar 
Date:   Thu Sep 28 20:41:28 2017 +0800

HBASE-18890, Backport HBASE-14499 (Master coprocessors shutdown will not 
happen on master abort) to branch-1

Signed-off-by: [~tedyu]

Must be a timing problem with the test. 

> TestTableResource flaky on branch-1
> ---
>
> Key: HBASE-18923
> URL: https://issues.apache.org/jira/browse/HBASE-18923
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>
> Occasional NPE
> Flaked tests: 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
>   Run 2: PASS
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 
> NullPointer
>   Run 2: PASS
> Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189135#comment-16189135
 ] 

Appy commented on HBASE-18878:
--

Looks like Optional is not supposed to be used for parameters. (I started 
reading around when my IDE showed a little notice on {{Optional user}}.)
- 
https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-arguments
- http://dolszewski.com/java/java-8-optional-use-cases/

Let me put up a subset of [~Apache9]'s patch.


> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.patch, HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18878) Use Optional instead of Nullable annotation in ObserverContext to better describe that the caller may not be presented

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189134#comment-16189134
 ] 

Appy commented on HBASE-18878:
--

ObserverContext is IA.LimitedPrivate because CP implementations might want to 
use getEnvironment(), bypass(), complete(), getCaller(), etc.
However, they are not supposed to be using the following:
- Constructor : Only CPHost can create contexts.
- prepare(E env)  : this is for internal use only.
- createAndPrepare() : ObserverContext is created in context of a CPHost. Third 
party have use accessing constructor or these factory methods. Internally, 
these fns are used only by our tests.
Am marking these methods Private/VisibleForTesting explicitly.
But if [~Apache9] reappears after crazy long holidays, and thinks otherwise, we 
can always put an addendum.


> Use Optional instead of Nullable annotation in ObserverContext to better 
> describe that the caller may not be presented
> --
>
> Key: HBASE-18878
> URL: https://issues.apache.org/jira/browse/HBASE-18878
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18878.patch, HBASE-18878-v1.patch
>
>
> I've already done lots of Nullable to Optional change when purging the 
> interfaces for CP. This is a big one so open a separated issue for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18703) Inconsistent behavior for preBatchMutate in doMiniBatchMutate and processRowsWithLocks

[Umesh Agashe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Agashe updated HBASE-18703:
-
Attachment: hbase-18703.master.005.patch

Fixed unit tests

> Inconsistent behavior for preBatchMutate in doMiniBatchMutate and 
> processRowsWithLocks
> --
>
> Key: HBASE-18703
> URL: https://issues.apache.org/jira/browse/HBASE-18703
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Umesh Agashe
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: hbase-18703.master.001.patch, 
> hbase-18703.master.002.patch, hbase-18703.master.003.patch, 
> hbase-18703.master.004.patch, hbase-18703.master.005.patch
>
>
> In doMiniBatchMutate, the preBatchMutate is called before building WAL, but 
> in processRowsWithLocks, we suggest the RowProcessor implementation to build 
> WAL in process  method, which is ahead of preBatchMutate.
> If a CP modifies the mutations, especially if it removes some cells from the 
> mutations, then the behavior of processRowsWithLocks is broken. The changes 
> applied to memstore and WAL will be different. And there is no way to remove 
> entries from a WALEdit through CP. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189112#comment-16189112
 ] 

Peter Somogyi commented on HBASE-18815:
---

UnmodifiableCollection does not implement equals which one of the tests 
depended on. Modified test in v5.

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch, 
> HBASE-18815.master.004.patch, HBASE-18815.master.005.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18815:
--
Attachment: HBASE-18815.master.005.patch

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch, 
> HBASE-18815.master.004.patch, HBASE-18815.master.005.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189095#comment-16189095
 ] 

Hudson commented on HBASE-18105:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3816 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3816/])
HBASE-18105 [AMv2] Split/Merge need cleanup; currently they diverge and (stack: 
rev 38eaf47fa7dd4b0b3b822e73c9e644370a5cacb6)
* (edit) hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMergeTableRegionsProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureTestingUtility.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
* (edit) hbase-protocol-shaded/src/main/protobuf/RegionServerStatus.proto
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java


> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189092#comment-16189092
 ] 

Ted Yu commented on HBASE-18900:


Ran all Replication unit tests with patch which passed.

> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189074#comment-16189074
 ] 

Hadoop QA commented on HBASE-18815:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 19 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
56s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
38m 49s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 17s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
3s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 87m 18s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18815 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12890055/HBASE-18815.master.004.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 2a7a7250efda 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 

[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189059#comment-16189059
 ] 

Hudson commented on HBASE-18105:


FAILURE: Integrated in Jenkins build HBase-2.0 #615 (See 
[https://builds.apache.org/job/HBase-2.0/615/])
HBASE-18105 [AMv2] Split/Merge need cleanup; currently they diverge and (stack: 
rev 24e40f3e85e12f0eb74b8377c6470d35407282e6)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit) hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMergeTableRegionsProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java
* (edit) hbase-protocol-shaded/src/main/protobuf/RegionServerStatus.proto
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureTestingUtility.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java


> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189030#comment-16189030
 ] 

Hadoop QA commented on HBASE-18900:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
58s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
48s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
57s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
40s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
59s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
47s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 33s{color} 
| {color:red} hbase-server-jdk1.7.0_151 with JDK v1.7.0_151 generated 1 new + 4 
unchanged - 1 fixed = 5 total (was 5) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
15s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 17m  
0s{color} | {color:red} The patch causes 150 errors with Hadoop v3.0.0-alpha4. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}303m 25s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  5m 
56s{color} | {color:green} The patch does not generate ASF 

[jira] [Commented] (HBASE-18905) Allow CPs to request flush/compaction on Region

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189018#comment-16189018
 ] 

Andrew Purtell commented on HBASE-18905:


bq. Can the CP ask for a flush and compaction via HBase Admin rather than via 
some internal CP call?

Yeah, as long as we provide access to MasterServices, or a new subset of this 
API, such that the CP can make the request. (I believe elsewhere we are pulling 
MasterServices.)

> Allow CPs to request flush/compaction on Region
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0-alpha-4
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region

[stack (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18090:
--
Fix Version/s: (was: 2.0.0-alpha-4)
   (was: 3.0.0)
   2.0.0-beta-1

> Improve TableSnapshotInputFormat to allow more multiple mappers per region
> --
>
> Key: HBASE-18090
> URL: https://issues.apache.org/jira/browse/HBASE-18090
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Mikhail Antonov
>Assignee: xinxin fan
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18090-branch-1.3-v1.patch, 
> HBASE-18090-branch-1.3-v2.patch, HBASE-18090-V3-master.patch, 
> HBASE-18090-V4-master.patch, HBASE-18090-V5-master.patch
>
>
> TableSnapshotInputFormat runs one map task per region in the table snapshot. 
> This places unnecessary restriction that the region layout of the original 
> table needs to take the processing resources available to MR job into 
> consideration. Allowing to run multiple mappers per region (assuming 
> reasonably even key distribution) would be useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18905) Allow CPs to request flush/compaction on Region

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189002#comment-16189002
 ] 

stack commented on HBASE-18905:
---

I'm playing in same relative area but on Master. Can the CP ask for a flush and 
compaction via HBase Admin rather than via some internal CP call?

> Allow CPs to request flush/compaction on Region
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0-alpha-4
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-14093) deduplicate copies of bootstrap files

[Tamas Penzes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Penzes updated HBASE-14093:
-
Attachment: HBASE-14093.master.003.patch

retry

> deduplicate copies of bootstrap files
> -
>
> Key: HBASE-14093
> URL: https://issues.apache.org/jira/browse/HBASE-14093
> Project: HBase
>  Issue Type: Improvement
>  Components: build
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
>  Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-14093.master.001.patch, 
> HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, 
> HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, 
> patch-shadedjars.txt
>
>
> right now we have a couple of different copies of the bootstrap js and css 
> files. It'll be easier to maintain them later if we can centralize.
> Move them to a common location and use maven to populate them as needed in 
> various component build directories.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18924) Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188997#comment-16188997
 ] 

Peter Somogyi commented on HBASE-18924:
---

No, as I can see hashcode is handled differently on branch-1.1.

> Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2
> -
>
> Key: HBASE-18924
> URL: https://issues.apache.org/jira/browse/HBASE-18924
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Affects Versions: 1.2.6
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18924.branch-1.2.001.patch
>
>
> HBASE-18568 corrects an issue with metrics which leads to memory leak. We 
> should apply this fix to branch-1.2.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

[Tamas Penzes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Penzes updated HBASE-18601:
-
Attachment: HBASE-18601.master.006.patch

retry

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18924) Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2

[Josh Elser (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188990#comment-16188990
 ] 

Josh Elser commented on HBASE-18924:


[~psomogyi], best as I can tell, this doesn't need to go into branch-1.1, right?

> Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2
> -
>
> Key: HBASE-18924
> URL: https://issues.apache.org/jira/browse/HBASE-18924
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Affects Versions: 1.2.6
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18924.branch-1.2.001.patch
>
>
> HBASE-18568 corrects an issue with metrics which leads to memory leak. We 
> should apply this fix to branch-1.2.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18924) Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188982#comment-16188982
 ] 

Hadoop QA commented on HBASE-18924:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
51s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
11s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
11s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
16s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
24s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
 4s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
24s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
13s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
20s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m 
44s{color} | {color:red} The patch causes 140 errors with Hadoop v3.0.0-alpha4. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
19s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:933f4b3 |
| JIRA Issue | HBASE-18924 |
| JIRA Patch URL | 

[jira] [Updated] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18815:
--
Attachment: HBASE-18815.master.004.patch

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch, 
> HBASE-18815.master.004.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188946#comment-16188946
 ] 

Peter Somogyi commented on HBASE-18815:
---

I missed to modify one file. Patch 4 fixes it. 

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch, 
> HBASE-18815.master.004.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16338) update jackson to 2.y

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188941#comment-16188941
 ] 

Hadoop QA commented on HBASE-16338:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  2m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  8m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
8s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
6s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
5s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
6s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
6s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
6s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  6s{color} 
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  6s{color} 
| {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  6s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red}  0m  
9s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red}  0m  
5s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red}  0m  
5s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  0m 
14s{color} | {color:red} patch has 19 errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 
21s{color} | {color:red} The patch causes 19 errors with Hadoop v2.6.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 
27s{color} | {color:red} The patch causes 19 errors with Hadoop v2.6.2. {color} 
|
| {color:red}-1{color} | 

[jira] [Commented] (HBASE-18568) Correct metric of numRegions

[Peter Somogyi (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188930#comment-16188930
 ] 

Peter Somogyi commented on HBASE-18568:
---

I created HBASE-18924 for backporting it to branch-1.2.

> Correct  metric of  numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of  metric numReigons in Regions is not correct.
> the metric can not add or remove  region correctly as region  close or open.
> the metric  as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in 
> MetricsRegionSourceImpl#MetricsRegionSourceImpl 
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet 
> initialized.
> So, the setFromMap can not put or remove the object correctly. 
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188931#comment-16188931
 ] 

stack commented on HBASE-18105:
---

[~easyliangjob] Thank you for asking. 

You think this section is done: 
https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f

And 8.9?

8.15 looks like a fun one.

8.20 needs input. I don't think there is a JIRA for it yet.

8.21 is the disabled tests. Some have been reenabled but there are others. The 
RSGroup ones will probably just work when Balazs is finished with HBASE-18350. 

You know AMv2. This is probably the most effective contrib you could make; i.e. 
follow-up on these disabled tests. Some can be just left off because they make 
no sense anymore in the new world. Others could do w/ some fixup.

In general, current focus is on Coprocessor cleanup so we can make an alpha4 
release; CPs are its theme 
https://issues.apache.org/jira/projects/HBASE/versions/12341594. 

There doesn't seem to be any explicit AMv2 to do in the current list. Our 
[~balazs.meszaros] is on the meaty AMv2 for beta release, the fixup of 
RSGroups; HBASE-18350.  [~psomogyi] is doing the important HBASE-18108, cleanup 
of AMv2 WALs.

Any thoughts on ensuring system tables are assigned ahead of user tables?  (See 
tail of HBASE-14190 and HBASE-18865).

Let me know if you need more pointers sir or want to chat on any of the above.

> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18924) Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18924:
--
Fix Version/s: 1.2.7
   Status: Patch Available  (was: Open)

> Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2
> -
>
> Key: HBASE-18924
> URL: https://issues.apache.org/jira/browse/HBASE-18924
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Affects Versions: 1.2.6
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18924.branch-1.2.001.patch
>
>
> HBASE-18568 corrects an issue with metrics which leads to memory leak. We 
> should apply this fix to branch-1.2.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18924) Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18924:
--
Attachment: HBASE-18924.branch-1.2.001.patch

> Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2
> -
>
> Key: HBASE-18924
> URL: https://issues.apache.org/jira/browse/HBASE-18924
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Affects Versions: 1.2.6
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Attachments: HBASE-18924.branch-1.2.001.patch
>
>
> HBASE-18568 corrects an issue with metrics which leads to memory leak. We 
> should apply this fix to branch-1.2.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188917#comment-16188917
 ] 

Hadoop QA commented on HBASE-18815:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 19 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
14s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
27s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
13s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
28s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
14s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 28s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 14s{color} 
| {color:red} hbase-examples in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  2m  
5s{color} | {color:red} patch has 16 errors when building our shaded downstream 
artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
18s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
29s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  5m 
40s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.3. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m 
49s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.4. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  8m  
0s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  9m 
10s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 
23s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 
35s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.3. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | 

[jira] [Updated] (HBASE-18894) null pointer exception in list_regions in shell command

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-18894:
--
   Resolution: Fixed
Fix Version/s: (was: 2.0.0)
   2.0.0-alpha-4
   3.0.0
   Status: Resolved  (was: Patch Available)

Thanks for the patch, [~easyliangjob]. Pushed to branch-2 and master.

> null pointer exception in list_regions in shell command
> ---
>
> Key: HBASE-18894
> URL: https://issues.apache.org/jira/browse/HBASE-18894
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.0.0-alpha-3
>Reporter: Yi Liang
>Assignee: Yi Liang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18894-v1-master.patch, 
> HBASE-18894-v2-master.patch, HBASE-18894-v3-master.patch
>
>
> See this error when run list_regions command After disable 't1'
> or after running split 't1', will see this error before split complete
> this caused by region is disabled or still in transition
> {quote}
> list_regions 't1'
> ERROR: undefined method `getDataLocality' for nil:NilClass
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18924) Backport HBASE-18568 (Correct metric of numRegions) to branch-1.2

[Peter Somogyi (JIRA)]

Peter Somogyi created HBASE-18924:
-

 Summary: Backport HBASE-18568 (Correct metric of numRegions) to 
branch-1.2
 Key: HBASE-18924
 URL: https://issues.apache.org/jira/browse/HBASE-18924
 Project: HBase
  Issue Type: Bug
  Components: metrics
Affects Versions: 1.2.6
Reporter: Peter Somogyi
Assignee: Peter Somogyi
Priority: Critical


HBASE-18568 corrects an issue with metrics which leads to memory leak. We 
should apply this fix to branch-1.2.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18350) RSGroups are broken under AMv2

[stack (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack reassigned HBASE-18350:
-

Assignee: Balazs Meszaros

> RSGroups are broken under AMv2
> --
>
> Key: HBASE-18350
> URL: https://issues.apache.org/jira/browse/HBASE-18350
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-alpha-1
>Reporter: Stephen Yuan Jiang
>Assignee: Balazs Meszaros
>Priority: Blocker
> Fix For: 2.0.0-beta-2
>
>
> The following RSGroups tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled/Ignore TestRSGroupsOfflineMode#testOffline; need to dig in on what 
> offline is.
> - Disabled/Ignore TestRSGroups.
> This JIRA tracks the work to enable them (or remove/modify if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[Yi Liang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188894#comment-16188894
 ] 

Yi Liang commented on HBASE-18105:
--

[~stack], do you have any other AMv2 related tasks that I can do some help, I 
am quite free this week.  :)
I found some issues about regionstates in AMv2, but will start to fix it after 
HBASE-18490 done. 
And also as we discussed in HBASE-18803, How we are going to deal with the 
curator jar? Shaded jar? 
Thanks

> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-16338) update jackson to 2.y

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-16338:
--
Status: Patch Available  (was: Open)

> update jackson to 2.y
> -
>
> Key: HBASE-16338
> URL: https://issues.apache.org/jira/browse/HBASE-16338
> Project: HBase
>  Issue Type: Task
>  Components: dependencies
>Reporter: Sean Busbey
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-2
>
> Attachments: 16338.txt, HBASE-16338.v2.patch
>
>
> Our jackson dependency is from ~3 years ago. Update to the jackson 2.y line, 
> using 2.7.0+.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-16338) update jackson to 2.y

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-16338:
--
Assignee: Mike Drob
  Status: Open  (was: Patch Available)

> update jackson to 2.y
> -
>
> Key: HBASE-16338
> URL: https://issues.apache.org/jira/browse/HBASE-16338
> Project: HBase
>  Issue Type: Task
>  Components: dependencies
>Reporter: Sean Busbey
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-2
>
> Attachments: 16338.txt, HBASE-16338.v2.patch
>
>
> Our jackson dependency is from ~3 years ago. Update to the jackson 2.y line, 
> using 2.7.0+.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-16338) update jackson to 2.y

[Mike Drob (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-16338:
--
Attachment: HBASE-16338.v2.patch

v2: rebased stack's patch onto master

> update jackson to 2.y
> -
>
> Key: HBASE-16338
> URL: https://issues.apache.org/jira/browse/HBASE-16338
> Project: HBase
>  Issue Type: Task
>  Components: dependencies
>Reporter: Sean Busbey
> Fix For: 2.0.0-beta-2
>
> Attachments: 16338.txt, HBASE-16338.v2.patch
>
>
> Our jackson dependency is from ~3 years ago. Update to the jackson 2.y line, 
> using 2.7.0+.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18815:
--
Attachment: HBASE-18815.master.003.patch

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch, HBASE-18815.master.003.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188836#comment-16188836
 ] 

stack commented on HBASE-18090:
---

My fault. Thank you for update [~ashu210890]

> Improve TableSnapshotInputFormat to allow more multiple mappers per region
> --
>
> Key: HBASE-18090
> URL: https://issues.apache.org/jira/browse/HBASE-18090
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Mikhail Antonov
>Assignee: xinxin fan
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18090-branch-1.3-v1.patch, 
> HBASE-18090-branch-1.3-v2.patch, HBASE-18090-V3-master.patch, 
> HBASE-18090-V4-master.patch, HBASE-18090-V5-master.patch
>
>
> TableSnapshotInputFormat runs one map task per region in the table snapshot. 
> This places unnecessary restriction that the region layout of the original 
> table needs to take the processing resources available to MR job into 
> consideration. Allowing to run multiple mappers per region (assuming 
> reasonably even key distribution) would be useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region

[Ashu Pachauri (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188833#comment-16188833
 ] 

Ashu Pachauri commented on HBASE-18090:
---

[~stack] sir I already reapplied the patch with correct commit message for 
master and branch-2. The above comments from Hudson are for the reapply  (the 
update from incorrect patch and revert went to the different jira HBASE-18814 
). 
I am currently waiting on the patch for branch-1 from [~xinxin fan] before 
closing this issue.

> Improve TableSnapshotInputFormat to allow more multiple mappers per region
> --
>
> Key: HBASE-18090
> URL: https://issues.apache.org/jira/browse/HBASE-18090
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Mikhail Antonov
>Assignee: xinxin fan
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18090-branch-1.3-v1.patch, 
> HBASE-18090-branch-1.3-v2.patch, HBASE-18090-V3-master.patch, 
> HBASE-18090-V4-master.patch, HBASE-18090-V5-master.patch
>
>
> TableSnapshotInputFormat runs one map task per region in the table snapshot. 
> This places unnecessary restriction that the region layout of the original 
> table needs to take the processing resources available to MR job into 
> consideration. Allowing to run multiple mappers per region (assuming 
> reasonably even key distribution) would be useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18918) branch-1.3 nightly JDK 7 tests fail TestTableResource

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188792#comment-16188792
 ] 

Andrew Purtell commented on HBASE-18918:


See also HBASE-18918. We can fix this one with a backport. Since this is open 
tracking for branch-1.3 I won't resolve as dup.

> branch-1.3 nightly JDK 7 tests fail TestTableResource
> -
>
> Key: HBASE-18918
> URL: https://issues.apache.org/jira/browse/HBASE-18918
> Project: HBase
>  Issue Type: Bug
>  Components: REST, test
>Affects Versions: 1.3.2
>Reporter: Sean Busbey
>Priority: Critical
>
> nightly failing two REST tests.
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/76/
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/76/JDK7_Nightly_Build_Report/
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/76/artifact/output-jdk7/patch-unit-root.txt
> {code}
> Tests run: 8, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.382 sec <<< 
> FAILURE! - in org.apache.hadoop.hbase.rest.TestTableResource
> testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)  Time 
> elapsed: 0.09 sec  <<< ERROR!
> java.lang.NullPointerException: null
>   at 
> org.apache.hadoop.hbase.rest.TestTableResource.checkTableInfo(TestTableResource.java:183)
>   at 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(TestTableResource.java:271)
> testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)  Time 
> elapsed: 0.05 sec  <<< ERROR!
> java.lang.NullPointerException: null
>   at 
> org.apache.hadoop.hbase.rest.TestTableResource.checkTableInfo(TestTableResource.java:183)
>   at 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(TestTableResource.java:254)
> Running org.apache.hadoop.hbase.rest.TestScannersWithFilters
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18815) We need to pass something like CompactionRequest in CP to give user some information about the compaction

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-18815:
--
Attachment: HBASE-18815.master.002.patch

> We need to pass something like CompactionRequest in CP to give user some 
> information about the compaction
> -
>
> Key: HBASE-18815
> URL: https://issues.apache.org/jira/browse/HBASE-18815
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Peter Somogyi
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18815.master.001.patch, 
> HBASE-18815.master.002.patch
>
>
> For example, it is a major compaction or minor compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18923) TestTableResource flaky on branch-1

[Josh Elser (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188787#comment-16188787
 ] 

Josh Elser commented on HBASE-18923:


We also have HBASE-18918 for (what I assume to be) an equivalent issue on 
branch-1.3

> TestTableResource flaky on branch-1
> ---
>
> Key: HBASE-18923
> URL: https://issues.apache.org/jira/browse/HBASE-18923
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>
> Occasional NPE
> Flaked tests: 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
>   Run 2: PASS
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 
> NullPointer
>   Run 2: PASS
> Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18923) TestTableResource flaky on branch-1

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188778#comment-16188778
 ] 

Andrew Purtell commented on HBASE-18923:


java.lang.NullPointerException: null
at 
org.apache.hadoop.hbase.rest.TestTableResource.checkTableInfo(TestTableResource.java:184)
at 
org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(TestTableResource.java:271)

> TestTableResource flaky on branch-1
> ---
>
> Key: HBASE-18923
> URL: https://issues.apache.org/jira/browse/HBASE-18923
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>
> Occasional NPE
> Flaked tests: 
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
>   Run 2: PASS
> org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
>   Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 
> NullPointer
>   Run 2: PASS
> Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18923) TestTableResource flaky on branch-1

[Andrew Purtell (JIRA)]

Andrew Purtell created HBASE-18923:
--

 Summary: TestTableResource flaky on branch-1
 Key: HBASE-18923
 URL: https://issues.apache.org/jira/browse/HBASE-18923
 Project: HBase
  Issue Type: Bug
Affects Versions: 1.4.0, 1.5.0
Reporter: Andrew Purtell


Occasional NPE

Flaked tests: 
org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoPB(org.apache.hadoop.hbase.rest.TestTableResource)
  Run 1: TestTableResource.testTableInfoPB:271->checkTableInfo:184 NullPointer
  Run 2: PASS

org.apache.hadoop.hbase.rest.TestTableResource.testTableInfoXML(org.apache.hadoop.hbase.rest.TestTableResource)
  Run 1: TestTableResource.testTableInfoXML:254->checkTableInfo:184 NullPointer
  Run 2: PASS


Tests run: 213, Failures: 0, Errors: 0, Skipped: 0, Flakes: 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18090) Improve TableSnapshotInputFormat to allow more multiple mappers per region

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188760#comment-16188760
 ] 

stack commented on HBASE-18090:
---

Did you want to reapply this [~ashu210890]? Thanks.

> Improve TableSnapshotInputFormat to allow more multiple mappers per region
> --
>
> Key: HBASE-18090
> URL: https://issues.apache.org/jira/browse/HBASE-18090
> Project: HBase
>  Issue Type: Improvement
>  Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Mikhail Antonov
>Assignee: xinxin fan
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18090-branch-1.3-v1.patch, 
> HBASE-18090-branch-1.3-v2.patch, HBASE-18090-V3-master.patch, 
> HBASE-18090-V4-master.patch, HBASE-18090-V5-master.patch
>
>
> TableSnapshotInputFormat runs one map task per region in the table snapshot. 
> This places unnecessary restriction that the region layout of the original 
> table needs to take the processing resources available to MR job into 
> consideration. Allowing to run multiple mappers per region (assuming 
> reasonably even key distribution) would be useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

[Peter Somogyi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reassigned HBASE-18108:
-

Assignee: Peter Somogyi

> Procedure WALs are archived but not cleaned; fix
> 
>
> Key: HBASE-18108
> URL: https://issues.apache.org/jira/browse/HBASE-18108
> Project: HBase
>  Issue Type: Sub-task
>  Components: proc-v2
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 2.0.0
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them 
> around in case issue but what is missing is a GC for no-longer-needed WAL 
> files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[stack (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-18105:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: (was: 2.0.0)
   2.0.0-alpha-4
   Status: Resolved  (was: Patch Available)

Pushed branch-2 and master (after restoring proto indices). Thank you for the 
important cleanup [~easyliangjob]

> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590

[Yi Liang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188589#comment-16188589
 ] 

Yi Liang commented on HBASE-16894:
--

patch for master branch seems ok.
retry branch-1, and above errors in branch-1 passed locally. 

> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: HBASE-16894.branch-1.patch, HBASE-16894.master.patch, 
> HBASE-16894-V2-master.patch, HBASE-16894-V3-master.patch, 
> ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map 
> tasks are created per region. Right now, it is always 1 region = 1 input 
> split = 1 map task. Same goes for Spark since it uses the TIF. With region 
> sizes as large as 50 GBs, it is desirable to be able to create more than 1 
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in 
> region sizes. The algorithm is roughly: 
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input 
> splits
> If (average size <= region size < average size*ratio) : one region as one MR 
> input split
> If (sum of several continuous regions size < average size * ratio): combine 
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse 
> HBASE-12590 into creating more than 1 split task per region, it is not ideal. 
> But there is no way to create more with the patch as it is. For example we 
> cannot create more than 2 tasks per region. 
> If we want to fix this properly, we should extend the approach in 
> HBASE-12590, and make it so that the client can specify the desired num of 
> mappers, or desired split size, and the TIF generates the splits based on the 
> current region sizes very similar to the algorithm in HBASE-12590, but a more 
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats 
> table which is used for exactly this purpose. Right now, the region can be 
> split into powers of two assuming uniform distribution within the region. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590

[Yi Liang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liang updated HBASE-16894:
-
Attachment: (was: HBASE-16894.branch-1.patch)

> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: HBASE-16894.branch-1.patch, HBASE-16894.master.patch, 
> HBASE-16894-V2-master.patch, HBASE-16894-V3-master.patch, 
> ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map 
> tasks are created per region. Right now, it is always 1 region = 1 input 
> split = 1 map task. Same goes for Spark since it uses the TIF. With region 
> sizes as large as 50 GBs, it is desirable to be able to create more than 1 
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in 
> region sizes. The algorithm is roughly: 
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input 
> splits
> If (average size <= region size < average size*ratio) : one region as one MR 
> input split
> If (sum of several continuous regions size < average size * ratio): combine 
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse 
> HBASE-12590 into creating more than 1 split task per region, it is not ideal. 
> But there is no way to create more with the patch as it is. For example we 
> cannot create more than 2 tasks per region. 
> If we want to fix this properly, we should extend the approach in 
> HBASE-12590, and make it so that the client can specify the desired num of 
> mappers, or desired split size, and the TIF generates the splits based on the 
> current region sizes very similar to the algorithm in HBASE-12590, but a more 
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats 
> table which is used for exactly this purpose. Right now, the region can be 
> split into powers of two assuming uniform distribution within the region. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590

[Yi Liang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liang updated HBASE-16894:
-
Attachment: HBASE-16894.branch-1.patch

> Create more than 1 split per region, generalize HBASE-12590
> ---
>
> Key: HBASE-16894
> URL: https://issues.apache.org/jira/browse/HBASE-16894
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 2.0.0-alpha-2
>Reporter: Enis Soztutar
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: HBASE-16894.branch-1.patch, HBASE-16894.master.patch, 
> HBASE-16894-V2-master.patch, HBASE-16894-V3-master.patch, 
> ImplementaionAndSomeQuestion.docx
>
>
> A common request from users is to be able to better control how many map 
> tasks are created per region. Right now, it is always 1 region = 1 input 
> split = 1 map task. Same goes for Spark since it uses the TIF. With region 
> sizes as large as 50 GBs, it is desirable to be able to create more than 1 
> split per region.
> HBASE-12590 adds a config property for MR jobs to be able to handle skew in 
> region sizes. The algorithm is roughly: 
> {code}
> If (region size >= average size*ratio) : cut the region into two MR input 
> splits
> If (average size <= region size < average size*ratio) : one region as one MR 
> input split
> If (sum of several continuous regions size < average size * ratio): combine 
> these regions into one MR input split.
> {code}
> Although we can set data skew ratio to be 0.5 or something to abuse 
> HBASE-12590 into creating more than 1 split task per region, it is not ideal. 
> But there is no way to create more with the patch as it is. For example we 
> cannot create more than 2 tasks per region. 
> If we want to fix this properly, we should extend the approach in 
> HBASE-12590, and make it so that the client can specify the desired num of 
> mappers, or desired split size, and the TIF generates the splits based on the 
> current region sizes very similar to the algorithm in HBASE-12590, but a more 
> generic way. This also would eliminate the hand tuning of data skew ratio.
> We also can think about the guidepost approach that Phoenix has in the stats 
> table which is used for exactly this purpose. Right now, the region can be 
> split into powers of two assuming uniform distribution within the region. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18752) Recalculate the TimeRange in flushing snapshot to store file

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188582#comment-16188582
 ] 

Hadoop QA commented on HBASE-18752:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
54s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 0s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 95m 
35s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m 49s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18752 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12889977/HBASE-18752.v0.patch |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 914f194d2c4d 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d35d837 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8892/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8892/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Recalculate the TimeRange in flushing snapshot to store file
> 

[jira] [Commented] (HBASE-16894) Create more than 1 split per region, generalize HBASE-12590

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188500#comment-16188500
 ] 

Hadoop QA commented on HBASE-16894:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
25s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
28s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
57s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
36m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 
40s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 40s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-16894 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12889983/HBASE-16894.master.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux f14f5bfde90d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d35d837 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8893/testReport/ |
| modules | C: hbase-mapreduce U: hbase-mapreduce |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8893/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Create more than 1 split per region, generalize HBASE-12590
> 

[jira] [Commented] (HBASE-18897) Substitute MemStore for Memstore

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188445#comment-16188445
 ] 

Hudson commented on HBASE-18897:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3814 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3814/])
HBASE-18897 Substitute MemStore for Memstore (chia7712: rev 
d35d8376a70a8de63c5d232a46e39657ba739eef)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
* (edit) 
hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ServerStatistics.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWalAndCompactingMemStoreFlush.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemstoreSize.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerAccounting.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentFactory.java
* (edit) 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientExponentialBackoff.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/FlushLargeStoresPolicy.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionLoadStats.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CellArrayImmutableSegment.java
* (edit) 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* (edit) hbase-protocol/src/main/protobuf/Client.proto
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java
* (edit) 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java
* (add) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSize.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
* (edit) hbase-protocol-shaded/src/main/protobuf/ClusterStatus.proto
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
* (add) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestNegativeMemStoreSizeWithSlowCoprocessor.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Client.proto
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
* (edit) 

[jira] [Updated] (HBASE-18900) Backport HBASE-17290 "Potential loss of data for replication of bulk loaded hfiles" to 1.3

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-18900:
---
Attachment: 18900.branch-1.3.patch

> Backport HBASE-17290 "Potential loss of data for replication of bulk loaded 
> hfiles" to 1.3
> --
>
> Key: HBASE-18900
> URL: https://issues.apache.org/jira/browse/HBASE-18900
> Project: HBase
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.3.2
>
> Attachments: 17290-branch-1.3.patch, 18900.branch-1.3.patch
>
>
> HBASE-17290 fixes data loss bug.
> Bulk loaded hfile replication support is in branch-1.3
> This issue is to backport HBASE-17290 to branch-1.3



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[Yi Liang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188426#comment-16188426
 ] 

Yi Liang edited comment on HBASE-18105 at 10/2/17 5:06 PM:
---

[~stack],if it is not good to change proto indices, I can keep it as original 
value and give some comment. I think the other changes and test cases are ok. 
And after solving this jira, I think cleanup for split/merge is almost done.  


was (Author: easyliangjob):
[~stack],if it is not good to change proto indices, I can keep it as original 
value and give some comment. But the other changes and test cases should be ok

> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18105) [AMv2] Split/Merge need cleanup; currently they diverge and do not fully embrace AMv2 world

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188433#comment-16188433
 ] 

stack commented on HBASE-18105:
---

I can do it on commit no problem. Let me  do it. [~easyliangjob]


> [AMv2] Split/Merge need cleanup; currently they diverge and do not fully 
> embrace AMv2 world
> ---
>
> Key: HBASE-18105
> URL: https://issues.apache.org/jira/browse/HBASE-18105
> Project: HBase
>  Issue Type: Sub-task
>  Components: Region Assignment
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Yi Liang
> Fix For: 2.0.0
>
> Attachments: HBASE-14350-V1-master.patch
>
>
> Region Split and Merge work on the new AMv2 but they work differently. This 
> issue is about bringing them back together and fully embracing the AMv2 
> program.
> They both have issues mostly the fact that they carry around baggage no 
> longer necessary in the new world of assignment.
> Here are some of the items:
> Split and Merge metadata modifications are done by the Master now but we have 
> vestige of Split/Merge on RS still; e.g. when we SPLIT, we ask the Master 
> which asks the RS, which turns around, and asks the Master to run the 
> operation. Fun. MERGE is all done Master-side.
>  
> Clean this up. Remove asking RS to run SPLIT and remove RegionMergeRequest, 
> etc. on RS-side. Also remove PONR. We don’t Points-Of-No-Return now we are up 
> on Pv2. Remove all calls in Interfaces; they are unused. Make RS still able 
> to detect when split, but have it be a client of Master like anyone else.
> Split is Async but does not return procId
> Split is async. Doesn’t return the procId though. Merge does. Fix. Only hard 
> part here I think is the Admin API does not allow procid return.
> Flags
> Currently OFFLINE is determined by looking either at the master instance of 
> HTD (isOffline) and/or at the RegionState#state. Ditto for SPLIT. For MERGE, 
> we rely on RegionState#state. Related is a note above on how split works -- 
> there is a split flag in HTD when there should not be.
>  
> TODO is move to rely on RegionState#state exclusively in Master.
> From Split/Merge Procedures need finishing in 
> https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.4b60dc1h4m1f



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)