[jira] [Commented] (HBASE-19838) Can not shutdown backup master cleanly when it has already tried to become the active master

2018-01-21 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333976#comment-16333976
 ] 

stack commented on HBASE-19838:
---

{quote}And for the rpc, I think we need to find a way to close the 
ConnectionImplementation from outside so that all rpc will fail soon.
{quote}
Agreed. I'd opened HBASE-19834 Will give it a go...

> Can not shutdown backup master cleanly when it has already tried to become 
> the active master
> 
>
> Key: HBASE-19838
> URL: https://issues.apache.org/jira/browse/HBASE-19838
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19838-UT.patch
>
>
> This is the root cause that why TestZooKeeper hangs.
> Open a new issue to introduce a UT which can reproduce the problem stably so 
> that we can fix the TestZooKeeper since it is not designed to test this 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333958#comment-16333958
 ] 

stack commented on HBASE-19836:
---

That should do it. The backup master becomes active, then you can shut it down. 
+1.

> Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
> --
>
> Key: HBASE-19836
> URL: https://issues.apache.org/jira/browse/HBASE-19836
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19836.patch
>
>
> It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19838) Can not shutdown backup master cleanly when it has already tried to become the active master

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333957#comment-16333957
 ] 

Duo Zhang commented on HBASE-19838:
---

{quote}
Nice test. What you thinking? Add this and change TestZooKeeper?
{quote}

Yes. Let's fix TestZooKeeper first. It is not designed to test this problem it 
does not fail stably so also not a good UT for debugging.

And for the rpc, I think we need to find a way to close the 
ConnectionImplementation from outside so that all rpc will fail soon.


> Can not shutdown backup master cleanly when it has already tried to become 
> the active master
> 
>
> Key: HBASE-19838
> URL: https://issues.apache.org/jira/browse/HBASE-19838
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19838-UT.patch
>
>
> This is the root cause that why TestZooKeeper hangs.
> Open a new issue to introduce a UT which can reproduce the problem stably so 
> that we can fix the TestZooKeeper since it is not designed to test this 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333953#comment-16333953
 ] 

Duo Zhang commented on HBASE-19836:
---

I think the key point is the 
'TEST_UTIL.getHBaseCluster().waitForActiveAndReadyMaster(1);' in after 
method...

> Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
> --
>
> Key: HBASE-19836
> URL: https://issues.apache.org/jira/browse/HBASE-19836
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19836.patch
>
>
> It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19838) Can not shutdown backup master cleanly when it has already tried to become the active master

2018-01-21 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333954#comment-16333954
 ] 

stack commented on HBASE-19838:
---

Nice test. What you thinking? Add this and change TestZooKeeper?

We need to do same for all places master startup does an rpc to a region or 
server.

> Can not shutdown backup master cleanly when it has already tried to become 
> the active master
> 
>
> Key: HBASE-19838
> URL: https://issues.apache.org/jira/browse/HBASE-19838
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19838-UT.patch
>
>
> This is the root cause that why TestZooKeeper hangs.
> Open a new issue to introduce a UT which can reproduce the problem stably so 
> that we can fix the TestZooKeeper since it is not designed to test this 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19836:
--
Assignee: Duo Zhang
  Status: Patch Available  (was: Open)

> Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
> --
>
> Key: HBASE-19836
> URL: https://issues.apache.org/jira/browse/HBASE-19836
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19836.patch
>
>
> It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19836:
--
Attachment: HBASE-19836.patch

> Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
> --
>
> Key: HBASE-19836
> URL: https://issues.apache.org/jira/browse/HBASE-19836
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19836.patch
>
>
> It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19837) Flakey TestRegionLoad

2018-01-21 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333952#comment-16333952
 ] 

stack commented on HBASE-19837:
---

Pushed debug to master and branch-2 so can see how the two views differ on 
failure. Changes the row names so they are readable.

> Flakey TestRegionLoad
> -
>
> Key: HBASE-19837
> URL: https://issues.apache.org/jira/browse/HBASE-19837
> Project: HBase
>  Issue Type: Bug
>  Components: flakey, test
>Reporter: stack
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: 0001-HBASE-19837-Flakey-TestRegionLoad.patch
>
>
> This one fails the most in the flakey list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19837) Flakey TestRegionLoad

2018-01-21 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-19837:
--
Attachment: 0001-HBASE-19837-Flakey-TestRegionLoad.patch

> Flakey TestRegionLoad
> -
>
> Key: HBASE-19837
> URL: https://issues.apache.org/jira/browse/HBASE-19837
> Project: HBase
>  Issue Type: Bug
>  Components: flakey, test
>Reporter: stack
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: 0001-HBASE-19837-Flakey-TestRegionLoad.patch
>
>
> This one fails the most in the flakey list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19781) Add a new cluster state flag for synchronous replication

2018-01-21 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-19781:
---
Attachment: (was: HBASE-19781.HBASE-19064.004.patch)

> Add a new cluster state flag for synchronous replication
> 
>
> Key: HBASE-19781
> URL: https://issues.apache.org/jira/browse/HBASE-19781
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-19781.HBASE-19064.005.patch
>
>
> The state may be S, DA, or A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19781) Add a new cluster state flag for synchronous replication

2018-01-21 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-19781:
---
Attachment: HBASE-19781.HBASE-19064.005.patch

> Add a new cluster state flag for synchronous replication
> 
>
> Key: HBASE-19781
> URL: https://issues.apache.org/jira/browse/HBASE-19781
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-19781.HBASE-19064.005.patch
>
>
> The state may be S, DA, or A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19838) Can not shutdown backup master cleanly when it has already tried to become the active master

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333943#comment-16333943
 ] 

Duo Zhang commented on HBASE-19838:
---

[~stack] FYI. This UT fails stably for me.

Use a mocked HMaster implementation to hold in initClusterSchemaService and 
then we kill all the RSes and then let it go on. The UT will hang in 
HBaseTestingUtility.shutdownMiniCluster.

> Can not shutdown backup master cleanly when it has already tried to become 
> the active master
> 
>
> Key: HBASE-19838
> URL: https://issues.apache.org/jira/browse/HBASE-19838
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19838-UT.patch
>
>
> This is the root cause that why TestZooKeeper hangs.
> Open a new issue to introduce a UT which can reproduce the problem stably so 
> that we can fix the TestZooKeeper since it is not designed to test this 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19695) Handle disabled table for async client

2018-01-21 Thread Jingyun Tian (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingyun Tian updated HBASE-19695:
-
Attachment: HBASE-19695.master.002.patch

> Handle disabled table for async client
> --
>
> Key: HBASE-19695
> URL: https://issues.apache.org/jira/browse/HBASE-19695
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-19695.master.001.patch, 
> HBASE-19695.master.002.patch, HBASE-19695.patch
>
>
> Now for async client we will not check if a table is disabled when retrying, 
> so we will retry until the time or count limit is reached, and will not throw 
> a TableNotEnabledException.
> We should have the same behavior as sync client, but the implementation 
> should be carefully designed. For sync client, we will also check if a table 
> is disabled if it is a retry, no matter what the exception is. This will 
> double the pressure on meta table. We should try our best to eliminate 
> unnecessary access to meta table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19838) Can not shutdown backup master cleanly when it has already tried to become the active master

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19838:
--
Attachment: HBASE-19838-UT.patch

> Can not shutdown backup master cleanly when it has already tried to become 
> the active master
> 
>
> Key: HBASE-19838
> URL: https://issues.apache.org/jira/browse/HBASE-19838
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19838-UT.patch
>
>
> This is the root cause that why TestZooKeeper hangs.
> Open a new issue to introduce a UT which can reproduce the problem stably so 
> that we can fix the TestZooKeeper since it is not designed to test this 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-19837) Flakey TestRegionLoad

2018-01-21 Thread stack (JIRA)
stack created HBASE-19837:
-

 Summary: Flakey TestRegionLoad
 Key: HBASE-19837
 URL: https://issues.apache.org/jira/browse/HBASE-19837
 Project: HBase
  Issue Type: Bug
  Components: flakey, test
Reporter: stack
 Fix For: 2.0.0-beta-2


This one fails the most in the flakey list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-19838) Can not shutdown backup master cleanly when it has already tried to become the active master

2018-01-21 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-19838:
-

 Summary: Can not shutdown backup master cleanly when it has 
already tried to become the active master
 Key: HBASE-19838
 URL: https://issues.apache.org/jira/browse/HBASE-19838
 Project: HBase
  Issue Type: Bug
  Components: master
Reporter: Duo Zhang
 Fix For: 2.0.0-beta-2


This is the root cause that why TestZooKeeper hangs.

Open a new issue to introduce a UT which can reproduce the problem stably so 
that we can fix the TestZooKeeper since it is not designed to test this problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19781) Add a new cluster state flag for synchronous replication

2018-01-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333932#comment-16333932
 ] 

Hadoop QA commented on HBASE-19781:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-19064 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
37s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
5s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
12s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
43s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
28s{color} | {color:green} HBASE-19064 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  2m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
23s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
42s{color} | {color:red} hbase-client: The patch generated 10 new + 395 
unchanged - 0 fixed = 405 total (was 395) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
30s{color} | {color:red} hbase-server: The patch generated 13 new + 272 
unchanged - 0 fixed = 285 total (was 272) {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m 
18s{color} | {color:red} The patch generated 15 new + 320 unchanged - 3 fixed = 
335 total (was 323) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red}  0m 
16s{color} | {color:red} The patch generated 33 new + 404 unchanged - 0 fixed = 
437 total (was 404) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
14s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
24m 58s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  
1m 49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
19s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}114m 
21s{color} | {color:green} hbase-server in the 

[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2018-01-21 Thread DM (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333908#comment-16333908
 ] 

DM commented on HBASE-15666:


I am trying to use {{HBaseTestingUtility}} with {{hbase-shaded-client}} & 
{{hbase-shaded-server}} . On trying to start a mini cluster it is throwing me 
the below exception. Is this exception related to this issue? Can someone 
provide me some workaround
{code:java}
java.lang.ClassCastException: 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.servlet.Context$SContext 
cannot be cast to org.mortbay.jetty.handler.ContextHandler$SContext
at org.mortbay.jetty.servlet.DefaultServlet.init(DefaultServlet.java:154)
at javax.servlet.GenericServlet.init(GenericServlet.java:241)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:440)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:263)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:736)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.servlet.Context.startContext(Context.java:140)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:519)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:152)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:156)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.jetty.Server.doStart(Server.java:224)
at 
org.apache.hadoop.hbase.shaded.org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:900)
at 
org.apache.hadoop.hdfs.server.namenode.NameNodeHttpServer.start(NameNodeHttpServer.java:142)
at 
org.apache.hadoop.hdfs.server.namenode.NameNode.startHttpServer(NameNode.java:774)
at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:667)
at org.apache.hadoop.hdfs.server.namenode.NameNode.(NameNode.java:838)
at org.apache.hadoop.hdfs.server.namenode.NameNode.(NameNode.java:817)
at 
org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1538)
at 
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1114)
at 
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:985)
at 
org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:814)
at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:745)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:585)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:987)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:868)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:862)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:806)
at 
com.vnera.storage.metrics.HBaseTestTableFactory.(HBaseTestTableFactory.java:25)
at com.vnera.storage.metrics.HBaseTests.testCounterTimetamp(HBaseTests.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at 

[jira] [Commented] (HBASE-19443) HBase Client gets stuck - Cannot get replica 0 location for...

2018-01-21 Thread Lakshmiprasad D (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333879#comment-16333879
 ] 

Lakshmiprasad D commented on HBASE-19443:
-

Request people from community to help us to know what might be causing the 
actual hang in first place. 

> HBase Client gets stuck - Cannot get replica 0 location for...
> --
>
> Key: HBASE-19443
> URL: https://issues.apache.org/jira/browse/HBASE-19443
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.2.4
>Reporter: Lakshmiprasad D
>Priority: Critical
>
> When the loader is loading data to HBase, without any forewarning that client 
> gets stuck and prints the below message continuously:
> [ERROR] AsyncProcess[hconnection-0x71f5455a-shared--pool20-t40846] Cannot get 
> replica 0 location for 
> {"totalColumns":20,"families":{"v":[{"timestamp":151258499,"tag":[],"qualifier":"0","vlen":4},{"timestamp":151258499,"tag":[],"qualifier":"uid","vlen":8},{"timestamp":151258499,"tag":[],"qualifier":"1","vlen":8},{"timestamp":151258499,"tag":[],"qualifier":"2","vlen":11}]},"row":"C\\x99L[5\\x80\\x00\\x00"}
> At this time no other loaders are impacted. Restart of the loader seems to 
> solve the issue until next occurence.
> Upon doing jstack at this time on the loader, it is observed that process is 
> stuck on a object monitor inside 'AsyncProcess.java' class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19443) HBase Client gets stuck - Cannot get replica 0 location for...

2018-01-21 Thread Lakshmiprasad D (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333878#comment-16333878
 ] 

Lakshmiprasad D commented on HBASE-19443:
-

We have made a workaround to avoid this issue by starting a separate monitor 
thread. If the data loader thread hangs, monitor thread is interrupting the 
data loader thread and recreates a new data loader thread. Further the data 
loading goes ahead without any issues.

> HBase Client gets stuck - Cannot get replica 0 location for...
> --
>
> Key: HBASE-19443
> URL: https://issues.apache.org/jira/browse/HBASE-19443
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.2.4
>Reporter: Lakshmiprasad D
>Priority: Critical
>
> When the loader is loading data to HBase, without any forewarning that client 
> gets stuck and prints the below message continuously:
> [ERROR] AsyncProcess[hconnection-0x71f5455a-shared--pool20-t40846] Cannot get 
> replica 0 location for 
> {"totalColumns":20,"families":{"v":[{"timestamp":151258499,"tag":[],"qualifier":"0","vlen":4},{"timestamp":151258499,"tag":[],"qualifier":"uid","vlen":8},{"timestamp":151258499,"tag":[],"qualifier":"1","vlen":8},{"timestamp":151258499,"tag":[],"qualifier":"2","vlen":11}]},"row":"C\\x99L[5\\x80\\x00\\x00"}
> At this time no other loaders are impacted. Restart of the loader seems to 
> solve the issue until next occurence.
> Upon doing jstack at this time on the loader, it is observed that process is 
> stuck on a object monitor inside 'AsyncProcess.java' class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333869#comment-16333869
 ] 

Chia-Ping Tsai commented on HBASE-17513:


Could we avoid using the IOException? The error is caused by the incorrect 
config rather than the I/O failure.

If the incorrect config will obstruct us from creating the thrift server, 
throwing a unchecked exception is more appropriate. Perhaps 
IllegalArgumentException?

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.001.patch, 
> HBASE-17513.master.002.patch, HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333852#comment-16333852
 ] 

Duo Zhang commented on HBASE-19836:
---

In general I prefer that we introduce a new test which always fails to expose 
the root bug. So that it will be easy for us to make sure that the problem is 
actually fixed.

Let me have a try.

> Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
> --
>
> Key: HBASE-19836
> URL: https://issues.apache.org/jira/browse/HBASE-19836
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
>
> It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19781) Add a new cluster state flag for synchronous replication

2018-01-21 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-19781:
---
Attachment: HBASE-19781.HBASE-19064.004.patch

> Add a new cluster state flag for synchronous replication
> 
>
> Key: HBASE-19781
> URL: https://issues.apache.org/jira/browse/HBASE-19781
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-19781.HBASE-19064.004.patch
>
>
> The state may be S, DA, or A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19781) Add a new cluster state flag for synchronous replication

2018-01-21 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-19781:
---
Attachment: (was: HBASE-19781.HBASE-19064.002.patch)

> Add a new cluster state flag for synchronous replication
> 
>
> Key: HBASE-19781
> URL: https://issues.apache.org/jira/browse/HBASE-19781
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: HBASE-19064
>
>
> The state may be S, DA, or A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333812#comment-16333812
 ] 

stack commented on HBASE-19836:
---

In a bit of a different place... RPC during Master startup w/o means of being 
able to cancel if shutdown is messing us up in a few places. You can give this 
to me to change the test till we fix root problem [~Apache9] 

> Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
> --
>
> Key: HBASE-19836
> URL: https://issues.apache.org/jira/browse/HBASE-19836
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 2.0.0-beta-2
>
>
> It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-19836) Fix TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry

2018-01-21 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-19836:
-

 Summary: Fix 
TestZooKeeper.testLogSplittingAfterMasterRecoveryDueToZKExpiry
 Key: HBASE-19836
 URL: https://issues.apache.org/jira/browse/HBASE-19836
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Duo Zhang
 Fix For: 2.0.0-beta-2


It still hangs and the test itself is a bit strange.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333791#comment-16333791
 ] 

Duo Zhang commented on HBASE-19794:
---

The test still hangs...

https://builds.apache.org/job/HBASE-Flaky-Tests/24995/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.TestZooKeeper-output.txt/*view*/

When shutting down after testLogSplittingAfterMasterRecoveryDueToZKExpiry. The 
test itself is a bit strange that we abort without confirming that the RS we 
abort is the one which carries the region. But anyway, the problem is that when 
arriving the shutdown point, there is no active master yet and our backup 
master is trying to become the active master.

Let me open an issue to modify the test to see if it helps.

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> HBASE-19794.master.003.patch, org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Reid Chan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333790#comment-16333790
 ] 

Reid Chan commented on HBASE-17513:
---

I'd like that, thank you [~elserj].

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.001.patch, 
> HBASE-17513.master.002.patch, HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333765#comment-16333765
 ] 

Josh Elser commented on HBASE-17513:


Ya, known Yetus bug, [~reidchan]. There's a fix coming for that.

{code}
+try {
+  thriftServer = new ThriftServer(conf);
+} catch (Exception e) {
+  exception.expect(IOException.class);
+  exception.expectMessage("hbase.thrift.ssl.enabled is false");
+}
{code}

Need to add a {{fail()}} after assigning {{thriftServer}}. Right now, if the 
exception isn't thrown, the test would still succeed.

I can add that and commit it if you'd like, [~reidchan].

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.001.patch, 
> HBASE-17513.master.002.patch, HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333640#comment-16333640
 ] 

Hadoop QA commented on HBASE-19835:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
35s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
36s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
21m 32s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
33s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
8s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}104m 
34s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
48s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}157m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19835 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12907013/HBASE-19835.master.01.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 868644f234cd 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master 

[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Status: Patch Available  (was: Open)

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
> Attachments: HBASE-19835.master.01.patch
>
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Attachment: (was: master.v02.patch)

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Attachment: HBASE-19835.master.01.patch

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
> Attachments: HBASE-19835.master.01.patch
>
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Attachment: (was: HBASE-19835.patch)

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Status: Open  (was: Patch Available)

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
> Attachments: HBASE-19835.patch
>
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Status: Patch Available  (was: Open)

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
> Attachments: HBASE-19835.patch
>
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Attachment: HBASE-19835.patch

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
> Attachments: HBASE-19835.patch
>
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Poonia updated HBASE-19835:

Attachment: master.v02.patch

> Make explicit casting of atleast one operand to final type
> --
>
> Key: HBASE-19835
> URL: https://issues.apache.org/jira/browse/HBASE-19835
> Project: HBase
>  Issue Type: Bug
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: Aman Poonia
>Priority: Minor
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333581#comment-16333581
 ] 

Hudson commented on HBASE-19794:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4442 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4442/])
HBASE-19794 TestZooKeeper hangs (zhangduo: rev 
27d00f5861336cb9f8f01174be33f8c3c431980f)
* (edit) hbase-common/src/main/resources/hbase-default.xml
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/ZKNamespaceManager.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterSchemaServiceImpl.java


> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> HBASE-19794.master.003.patch, org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-19835) Make explicit casting of atleast one operand to final type

2018-01-21 Thread Aman Poonia (JIRA)
Aman Poonia created HBASE-19835:
---

 Summary: Make explicit casting of atleast one operand to final type
 Key: HBASE-19835
 URL: https://issues.apache.org/jira/browse/HBASE-19835
 Project: HBase
  Issue Type: Bug
  Components: hbase
Affects Versions: 3.0.0
Reporter: Aman Poonia


We have used 

_long = int + int_ 

at many places mostly wherever ClassSize.java variables are used for 
calculation.

Need to cast explicitly at-least one operand to final type(i.e. type the result 
is intended to be casted).

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333555#comment-16333555
 ] 

Hadoop QA commented on HBASE-17513:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
14s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
42s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
20m 35s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
21s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 20s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-17513 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12907004/HBASE-17513.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux db8814d120ac 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 27d00f5861 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11145/testReport/ |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11145/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 

[jira] [Commented] (HBASE-19658) Fix and reenable TestCompactingToCellFlatMapMemStore#testFlatteningToJumboCellChunkMap

2018-01-21 Thread Gali Sheffi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333547#comment-16333547
 ] 

Gali Sheffi commented on HBASE-19658:
-

Hi everyone,

I uploaded the new patch to the Review Board ([~jmspaggiari_impala_a970] - the 
test shouldn't fail now). Please take a look and review.

Thanks!

> Fix and reenable 
> TestCompactingToCellFlatMapMemStore#testFlatteningToJumboCellChunkMap
> --
>
> Key: HBASE-19658
> URL: https://issues.apache.org/jira/browse/HBASE-19658
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-beta-1
>Reporter: stack
>Assignee: Anastasia Braginsky
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19658-V01.patch, HBASE-19658-V02.patch, 
> HBASE-19658-V03.patch, HBASE-19658-V04.patch, 
> org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore-output.txt
>
>
> testFlatteningToJumboCellChunkMap was disabled so could commit HBASE-19282 on 
> branch-2. This test is failing reliably. Assigned to [~anastas]. This issue 
> is about fixing the failing test and reenabling it in time for beta-2. Thanks 
> A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Reid Chan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-17513:
--
Attachment: HBASE-17513.master.001.patch

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.001.patch, 
> HBASE-17513.master.002.patch, HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Reid Chan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-17513:
--
Attachment: (was: HBASE-17513.master.001.patch)

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.002.patch, 
> HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Reid Chan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333544#comment-16333544
 ] 

Reid Chan commented on HBASE-17513:
---

Thank you Ted, i'll try again.

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.001.patch, 
> HBASE-17513.master.002.patch, HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19658) Fix and reenable TestCompactingToCellFlatMapMemStore#testFlatteningToJumboCellChunkMap

2018-01-21 Thread Gali Sheffi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gali Sheffi updated HBASE-19658:

Attachment: HBASE-19658-V04.patch

> Fix and reenable 
> TestCompactingToCellFlatMapMemStore#testFlatteningToJumboCellChunkMap
> --
>
> Key: HBASE-19658
> URL: https://issues.apache.org/jira/browse/HBASE-19658
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.0.0-beta-1
>Reporter: stack
>Assignee: Anastasia Braginsky
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19658-V01.patch, HBASE-19658-V02.patch, 
> HBASE-19658-V03.patch, HBASE-19658-V04.patch, 
> org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore-output.txt
>
>
> testFlatteningToJumboCellChunkMap was disabled so could commit HBASE-19282 on 
> branch-2. This test is failing reliably. Assigned to [~anastas]. This issue 
> is about fixing the failing test and reenabling it in time for beta-2. Thanks 
> A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333527#comment-16333527
 ] 

Eshcar Hillel commented on HBASE-18294:
---

Thanks Ted.

I will try it if QA doesn't succeed this time as well.

> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333526#comment-16333526
 ] 

Ted Yu commented on HBASE-18294:


You can remove the .01 patch and rename .15 patch as .01 patch so that QA runs 
tests over the new patch

> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333525#comment-16333525
 ] 

Eshcar Hillel commented on HBASE-18294:
---

We are back to a ``fat'' patch, so here is a summary of major changes w.r.t. 
master:
- MemStoreSize and MemStoreSizing now manage three counters (1) data size (2) 
heap size (3) off heap size,
- FlushLargeStorePolicy::shouldFlush(), HRegion::checkResources(), 
HRegion::isFlushSize() and HRegion::requestFlushIfNeeded() check both heap size 
and off heap size against their (heap and off-heap) bounds,
- RegionServerAccounting manages 3 counters (off-heap size is added), 
RegionServerAccounting::isAboveHighWaterMark(), 
RegionServerAccounting::isAboveLowWaterMark(), and 
RegionServerAccounting::getFlushPressure() compare on-heap and off-heap sizes 
to their bounds,
- ByteBufferKeyValue::heapSize() always considers key-value length.

Patch is also in RB.

> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17513) Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and can easily be misconfigured so there is no encryption when the operator expects it.

2018-01-21 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333522#comment-16333522
 ] 

Ted Yu commented on HBASE-17513:


You can remove master.001 and rename v3 as master.001 so that QA runs tests 
using 001

> Thrift Server 1 uses different QOP settings than RPC and Thrift Server 2 and 
> can easily be misconfigured so there is no encryption when the operator 
> expects it.
> 
>
> Key: HBASE-17513
> URL: https://issues.apache.org/jira/browse/HBASE-17513
> Project: HBase
>  Issue Type: Bug
>  Components: documentation, security, Thrift, Usability
>Affects Versions: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>Reporter: Sean Busbey
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.2.8
>
> Attachments: HBASE-17513.master.001.patch, 
> HBASE-17513.master.002.patch, HBASE-17513.master.003.patch
>
>
> As of HBASE-14400 the setting {{hbase.thrift.security.qop}} was unified to 
> behave the same as the general HBase RPC protection. However, this only 
> happened for the Thrift2 server. The Thrift server found in the thrift 
> package (aka Thrift Server 1) still hard codes the old configs of 'auth', 
> 'auth-int', and 'auth-conf'.
> Additionally, these Quality of Protection (qop) settings are used only by the 
> SASL transport. If a user configures the HBase Thrift Server to make use of 
> the HTTP transport (to enable doAs proxying e.g. for Hue) then a QOP setting 
> of 'privacy' or 'auth-conf' won't get them encryption as expected.
> We should
> 1) update {{hbase-thrift/src/main/.../thrift/ThriftServerRunner}} to rely on 
> {{SaslUtil}} to use the same 'authentication', 'integrity', 'privacy' configs 
> in a backward compatible way
> 2) also have ThriftServerRunner warn when both {{hbase.thrift.security.qop}} 
> and {{hbase.regionserver.thrift.http}} are set, since the latter will cause 
> the former to be ignored. (users should be directed to 
> {{hbase.thrift.ssl.enabled}} and related configs to ensure their transport is 
> encrypted when using the HTTP transport.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eshcar Hillel updated HBASE-18294:
--
Status: Patch Available  (was: Open)

> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eshcar Hillel updated HBASE-18294:
--
Status: Open  (was: Patch Available)

> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333514#comment-16333514
 ] 

Hadoop QA commented on HBASE-18294:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HBASE-18294 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18294 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12897297/HBASE-18294.01.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11144/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-18294) Reduce global heap pressure: flush based on heap occupancy

2018-01-21 Thread Eshcar Hillel (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eshcar Hillel updated HBASE-18294:
--
Attachment: HBASE-18294.15.patch

> Reduce global heap pressure: flush based on heap occupancy
> --
>
> Key: HBASE-18294
> URL: https://issues.apache.org/jira/browse/HBASE-18294
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Eshcar Hillel
>Assignee: Eshcar Hillel
>Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-18294.01.patch, HBASE-18294.02.patch, 
> HBASE-18294.03.patch, HBASE-18294.04.patch, HBASE-18294.05.patch, 
> HBASE-18294.06.patch, HBASE-18294.07.patch, HBASE-18294.07.patch, 
> HBASE-18294.08.patch, HBASE-18294.09.patch, HBASE-18294.10.patch, 
> HBASE-18294.11.patch, HBASE-18294.11.patch, HBASE-18294.12.patch, 
> HBASE-18294.13.patch, HBASE-18294.15.patch
>
>
> A region is flushed if its memory component exceed a threshold (default size 
> is 128MB).
> A flush policy decides whether to flush a store by comparing the size of the 
> store to another threshold (that can be configured with 
> hbase.hregion.percolumnfamilyflush.size.lower.bound).
> Currently the implementation (in both cases) compares the data size 
> (key-value only) to the threshold where it should compare the heap size 
> (which includes index size, and metadata).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19791) TestZKAsyncRegistry hangs

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333508#comment-16333508
 ] 

Duo Zhang commented on HBASE-19791:
---

Tried after HBASE-19794 goes in. We are still stuck at the same place...

I guess the problem is meta region replica...

Will dig more later.

Thanks.

> TestZKAsyncRegistry hangs
> -
>
> Key: HBASE-19791
> URL: https://issues.apache.org/jira/browse/HBASE-19791
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: 0001-HBASE-19791-do-nothing.patch, jstack, output
>
>
> It hangs in TEST_UTIL.shutdownMiniCluster() for me locally.
> Will upload the test output and jstack result for further digging.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19794:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to master and branch-2. Thanks [~stack].

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> HBASE-19794.master.003.patch, org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333500#comment-16333500
 ] 

Duo Zhang commented on HBASE-19794:
---

Let me commit after fixing the checkstyle issues.

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> HBASE-19794.master.003.patch, org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333498#comment-16333498
 ] 

Hadoop QA commented on HBASE-19794:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
51s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
6s{color} | {color:red} hbase-server: The patch generated 2 new + 205 unchanged 
- 0 fixed = 207 total (was 205) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
35s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
20m 12s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
15s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m 
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}144m  2s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19794 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12906993/HBASE-19794.master.003.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  xml  findbugs  shadedjars 
 hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 128a0399b128 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 7fe4aa6fe4 |
| maven | version: Apache Maven 3.5.2 

[jira] [Commented] (HBASE-19080) Implement a procedure to convert RS from A to DA

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333461#comment-16333461
 ] 

Duo Zhang commented on HBASE-19080:
---

Discussed with [~zghaobac] offline and we found a problem. We need to write out 
flush marker through WAL when flushing region. When we want to convert RS from 
A to DA, it usually means that the remote side is down and our dual output WAL 
is broken, then it is impossible for us to close the region and open it again 
with a new WAL since we need to flush the region before close it but the WAL 
has already been broken...

Need to find out a way to address the problem...

> Implement a procedure to convert RS from A to DA
> 
>
> Key: HBASE-19080
> URL: https://issues.apache.org/jira/browse/HBASE-19080
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Priority: Major
>  Labels: HBASE-19064
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19079) Implement a procedure to convert normal RS to state DA

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333460#comment-16333460
 ] 

Duo Zhang commented on HBASE-19079:
---

I think this would be the procedure for adding a synchronous replication peer...

> Implement a procedure to convert normal RS to state DA
> --
>
> Key: HBASE-19079
> URL: https://issues.apache.org/jira/browse/HBASE-19079
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Priority: Major
>  Labels: HBASE-19064
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333452#comment-16333452
 ] 

Duo Zhang commented on HBASE-19794:
---

Do not know when will YETUS-598 be online so delete the old patches and try 
again...

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> HBASE-19794.master.003.patch, org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19794:
--
Attachment: HBASE-19794.master.003.patch

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> HBASE-19794.master.003.patch, org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19794:
--
Attachment: (was: HBASE-19794.master.001.patch)

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19794:
--
Attachment: (was: HBASE-19794.master.002.patch)

> TestZooKeeper hangs
> ---
>
> Key: HBASE-19794
> URL: https://issues.apache.org/jira/browse/HBASE-19794
> Project: HBase
>  Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19794.master.003.patch, 
> org.apache.hadoop.hbase.TestZooKeeper-output.txt
>
>
> Seems like the TestZKAsyncRegistry that hangs in shutdown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19794) TestZooKeeper hangs

2018-01-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333433#comment-16333433
 ] 

Hadoop QA commented on HBASE-19794:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
55s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
7s{color} | {color:red} hbase-server: The patch generated 1 new + 205 unchanged 
- 0 fixed = 206 total (was 205) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
47s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
20m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}124m 
48s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}165m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19794 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12906974/HBASE-19794.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux c6e490663a34 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 7fe4aa6fe4 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11142/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11142/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11142/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> TestZooKeeper hangs
>