[jira] [Resolved] (HBASE-22182) Introduce a getRegionMetrics(ServerName) method
[ https://issues.apache.org/jira/browse/HBASE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22182. --- Resolution: Invalid Oh, forget to check the interface, just checked HBaseAdmin. There is a getRegionMetrics(ServerName) method, which has a default implementation. > Introduce a getRegionMetrics(ServerName) method > --- > > Key: HBASE-22182 > URL: https://issues.apache.org/jira/browse/HBASE-22182 > Project: HBase > Issue Type: Task >Reporter: Duo Zhang >Priority: Major > > So we do not need to pass null if we want to get all the regions of a region > server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21965: -- Status: Patch Available (was: Reopened) > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22185) RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
[ https://issues.apache.org/jira/browse/HBASE-22185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812126#comment-16812126 ] Duo Zhang commented on HBASE-22185: --- How can we get AssertionError? This should be a code bug... > RAMQueueEntry#writeToCache should freeBlock if any exception encountered > instead of the IOException catch block > > > Key: HBASE-22185 > URL: https://issues.apache.org/jira/browse/HBASE-22185 > Project: HBase > Issue Type: Bug >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > > When preparing patch for HBASE-22159, I found that if thrown an > AssertionError in RAMQueueEntry#writeToCache, the bucketAllocator won't free > its memory. > This is an memory leak bug, and should be fixed in almost all 2.x branches. > will also check branch-1.x -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
[
https://issues.apache.org/jira/browse/HBASE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohammad Arshad updated HBASE-22179:
Component/s: asyncclient
> Fix RawAsyncHBaseAdmin.getCompactionState
> -
>
> Key: HBASE-22179
> URL: https://issues.apache.org/jira/browse/HBASE-22179
> Project: HBase
> Issue Type: Bug
> Components: Admin, asyncclient
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> {code}
> if (!future.isDone()) {
> future.complete(state);
> }
> {code}
> This piece of code should be placed outside the for loop, it should be a
> typo. And we should use a thread safe collection to collect the region state
> instead of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22177) Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
[ https://issues.apache.org/jira/browse/HBASE-22177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad updated HBASE-22177: Component/s: asyncclient > Do not recreate IOException in RawAsyncHBaseAdmin.adminCall > --- > > Key: HBASE-22177 > URL: https://issues.apache.org/jira/browse/HBASE-22177 > Project: HBase > Issue Type: Bug > Components: Admin, asyncclient >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5 > > > This should be a typo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812102#comment-16812102
]
HBase QA commented on HBASE-22169:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
51s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
8s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-2.2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
9s{color} | {color:red} hbase-server: The patch generated 1 new + 242 unchanged
- 0 fixed = 243 total (was 242) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 56s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}134m 22s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}168m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.TestOpenSeqNumUnexpectedIncrease |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/13/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22169 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965146/HBASE-22169-branch-2.2-v1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 383ccd2faba2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.2 / 4c5eec5bb3 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/13/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
[jira] [Assigned] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail
[
https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao reassigned HBASE-21751:
-
Assignee: Bing Xiao (was: Allan Yang)
> WAL creation fails during region open may cause region assign forever fail
> --
>
> Key: HBASE-21751
> URL: https://issues.apache.org/jira/browse/HBASE-21751
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.2, 2.0.4
>Reporter: Allan Yang
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 2.0.6, 2.1.5, 2.2.1
>
> Attachments: HBASE-21751.patch, HBASE-21751v2.patch
>
>
> During the first region opens on the RS, WALFactory will create a WAL file,
> but if the wal creation fails, in some cases, HDFS will leave a empty file in
> the dir(e.g. disk full, file is created succesfully but block allocation
> fails). We have a check in AbstractFSWAL that if WAL belong to the same
> factory exists, then a error will be throw. Thus, the region can never be
> open on this RS later.
> {code:java}
> 2019-01-17 02:15:53,320 ERROR [RS_OPEN_META-regionserver/server003:16020-0]
> handler.OpenRegionHandler(301): Failed open of region=hbase:meta,,1.1588230740
> java.io.IOException: Target WAL already exists within directory
> hdfs://cluster/hbase/WALs/server003.hbase.hostname.com,16020,1545269815888
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.(AbstractFSWAL.java:382)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.(AsyncFSWAL.java:210)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:72)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:47)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:138)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:57)
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:264)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2085)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:284)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:108)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
> at java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22185) RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
[ https://issues.apache.org/jira/browse/HBASE-22185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22185: - Summary: RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block (was: RAMQueueEntry#writeToCache should freeBlock in the finally block instead of the IOException catch block ) > RAMQueueEntry#writeToCache should freeBlock if any exception encountered > instead of the IOException catch block > > > Key: HBASE-22185 > URL: https://issues.apache.org/jira/browse/HBASE-22185 > Project: HBase > Issue Type: Bug >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > > When preparing patch for HBASE-22159, I found that if thrown an > AssertionError in RAMQueueEntry#writeToCache, the bucketAllocator won't free > its memory. > This is an memory leak bug, and should be fixed in almost all 2.x branches. > will also check branch-1.x -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: (was: HBASE-22169-branch-2.2-v1.patch)
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.1.5
>
> Attachments: HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: (was: HBASE-22169-branch-2.1-v1.patch)
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.1.5
>
> Attachments: HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: (was: HBASE-22169-branch-2-v1.patch)
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.1.5
>
> Attachments: HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22185) RAMQueueEntry#writeToCache should freeBlock in the finally block instead of the IOException catch block
Zheng Hu created HBASE-22185: Summary: RAMQueueEntry#writeToCache should freeBlock in the finally block instead of the IOException catch block Key: HBASE-22185 URL: https://issues.apache.org/jira/browse/HBASE-22185 Project: HBase Issue Type: Bug Reporter: Zheng Hu Assignee: Zheng Hu When preparing patch for HBASE-22159, I found that if thrown an AssertionError in RAMQueueEntry#writeToCache, the bucketAllocator won't free its memory. This is an memory leak bug, and should be fixed in almost all 2.x branches. will also check branch-1.x -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[
https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-21492:
--
Hadoop Flags: Incompatible change,Reviewed (was: Reviewed)
Release Note: After HBASE-21492 the return type of
WALCellCodec#getWALCellCodecClass has been changed from String to Class
> CellCodec Written To WAL Before It's Verified
> -
>
> Key: HBASE-21492
> URL: https://issues.apache.org/jira/browse/HBASE-21492
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.2.7, 2.0.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Critical
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10
>
> Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch,
> HBASE-21492.2.patch, HBASE-21492.2.patch
>
>
> The cell codec class name is written into the WAL file, but the cell codec
> class is not actually verified to exist. Therefore, users can inadvertently
> configure an invalid class name and it will be recorded into the WAL file.
> At that point, the WAL file becomes unreadable and blocks processing of all
> other WAL files.
> {code:java|title=AbstractProtobufLogWriter.java}
> private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder
> builder) {
> if (!builder.hasWriterClsName()) {
> builder.setWriterClsName(getWriterClassName());
> }
> if (!builder.hasCellCodecClsName()) {
> builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf));
> }
> return builder.build();
> }
> {code}
> https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21148) [Docs] Some errors in section#Security Configuration Example of hbase book
[ https://issues.apache.org/jira/browse/HBASE-21148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21148: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) > [Docs] Some errors in section#Security Configuration Example of hbase book > -- > > Key: HBASE-21148 > URL: https://issues.apache.org/jira/browse/HBASE-21148 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Labels: beginner, document > Fix For: 3.0.0 > > Attachments: HBASE-21148.master.001.patch > > > * There is a wrong package name about VisibilityController in mentioned > section: it should be > org.apache.hadoop.hbase.security.*visibility*.VisibilityController instead of > org.apache.hadoop.hbase.security.*access*.VisibilityController. > * A wrong slash: org.apache.hadoop/hbase.security.access.AccessController > * VisibilityController should not be in > *hbase.coprocessor.regionserver.classes* which will fail rs starting up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812060#comment-16812060
]
Hudson commented on HBASE-22020:
Results for branch HBASE-22020
[build #5 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/5/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/5//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/5//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/5//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812057#comment-16812057
]
Reid Chan edited comment on HBASE-21048 at 4/8/19 3:08 AM:
---
I filed HBASE-22184 and assigned that to you [~jojochuang].
To make review easier, let's focus on kerberos support in HTTP mode first which
is the main problem in this issue.
was (Author: reidchan):
I filed HBASE-22184 and assigned to you [~jojochuang].
To make review easier, let's focus on kerberos support in HTTP mode first which
is the main problem in this issue.
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812057#comment-16812057
]
Reid Chan edited comment on HBASE-21048 at 4/8/19 3:06 AM:
---
I filed HBASE-22184 and assigned to you [~jojochuang].
To make review easier, let's focus on kerberos support in HTTP mode first which
is the main problem in this issue.
was (Author: reidchan):
I filed HBASE-22184 and assigned to you [~jojochuang].
To make review easier, let's focus on kerberos support in HTTP mode first which
is the main problem.
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812057#comment-16812057
]
Reid Chan commented on HBASE-21048:
---
I filed HBASE-22184 and assigned to you [~jojochuang].
To make review easier, let's focus on kerberos support in HTTP mode first which
is the main problem.
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22184) [security] Support get|set LogLevel in HTTPS mode
[ https://issues.apache.org/jira/browse/HBASE-22184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22184: -- Description: As title read. > [security] Support get|set LogLevel in HTTPS mode > - > > Key: HBASE-22184 > URL: https://issues.apache.org/jira/browse/HBASE-22184 > Project: HBase > Issue Type: Improvement > Components: logging, website >Reporter: Reid Chan >Assignee: Wei-Chiu Chuang >Priority: Major > > As title read. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22184) [security] Support get|set LogLevel in HTTPS mode
Reid Chan created HBASE-22184: - Summary: [security] Support get|set LogLevel in HTTPS mode Key: HBASE-22184 URL: https://issues.apache.org/jira/browse/HBASE-22184 Project: HBase Issue Type: Improvement Components: logging, website Reporter: Reid Chan Assignee: Wei-Chiu Chuang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Affects Version/s: 2.0.5
2.1.4
Fix Version/s: 2.1.5
2.2.0
3.0.0
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.1.5
>
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allan Yang updated HBASE-22169:
---
Priority: Critical (was: Major)
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Summary: Open region failed cause memory leak (was: Coprocessor path wrong
then Region open failed cause memory leak)
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.013.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22127) Ensure that the block cached in the LRUBlockCache offheap is allocated from heap
[ https://issues.apache.org/jira/browse/HBASE-22127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22127: - Attachment: HBASE-22127.HBASE-21879.v8.patch > Ensure that the block cached in the LRUBlockCache offheap is allocated from > heap > > > Key: HBASE-22127 > URL: https://issues.apache.org/jira/browse/HBASE-22127 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-22127.HBASE-21879.v1.patch, > HBASE-22127.HBASE-21879.v2.patch, HBASE-22127.HBASE-21879.v3.patch, > HBASE-22127.HBASE-21879.v4.patch, HBASE-22127.HBASE-21879.v5.patch, > HBASE-22127.HBASE-21879.v6.patch, HBASE-22127.HBASE-21879.v7.patch, > HBASE-22127.HBASE-21879.v8.patch > > > In here [1], [~anoop.hbase] pointed out an crtial problem , I pasted here: > bq. So if we read from HDFS into a pooled BB and then give to LRU cache for > caching (ya mostly cache on read might be true) we will cache the block which > is backed by this pooled DBB? Unless the block is evicted , this BB wont go > back to pool. I think this is some thing we can not livw with !! For LRU > cache the sizing itself is based on what % of heap size we can grow. But here > in effect we are occupying the off heap space for the cached blocks. All the > sizing assumptions and calc going out of control ! > It's indeed an big problem here. so we can only make the block ref to an heap > area if we use LRUCache (both LruBlockCache and CombinedBlockCache case). Or > we can also make the lru cache offheap ? > I think we can introduce an switch indicate that whether the lru block cache > offheap or not, if heap, then coping those bytes from ByteBuff to heap. > https://reviews.apache.org/r/70153/diff/6?file=2133545#file2133545line398 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812051#comment-16812051
]
Reid Chan commented on HBASE-21048:
---
For https support, would you mind filing another Jira?
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 commented on issue #122: HBASE-22163 Should not archive the compacted store files when region warmup
Apache9 commented on issue #122: HBASE-22163 Should not archive the compacted store files when region warmup URL: https://github.com/apache/hbase/pull/122#issuecomment-480663311 The fix is straight forward, but can we add a UT to confirm that we will not archive storefiles when warmup is true? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22153) Fix the flaky TestRestartCluster
[ https://issues.apache.org/jira/browse/HBASE-22153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22153: - Assignee: Duo Zhang (was: Zheng Hu) > Fix the flaky TestRestartCluster > > > Key: HBASE-22153 > URL: https://issues.apache.org/jira/browse/HBASE-22153 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Duo Zhang >Priority: Major > > I guess it's related to HBASE-21565 or HBASE-21588 > Log can be see here: > https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2902/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestRestartCluster-output.txt -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #123: HBASE-22153 Fix the flaky TestRestartCluster
Apache9 opened a new pull request #123: HBASE-22153 Fix the flaky TestRestartCluster URL: https://github.com/apache/hbase/pull/123 Remove the the non-null assertion, use a waitFor to wait until it is not null instead. Increase the waiting time to make the test more stable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22169) Coprocessor path wrong then Region open failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: HBASE-22169-branch-2.2-v1.patch
> Coprocessor path wrong then Region open failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Coprocessor path wrong then Region open failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Status: Patch Available (was: Open)
> Coprocessor path wrong then Region open failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Coprocessor path wrong then Region open failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: (was: HBASE-22169-branch-2.2-v1.patch)
> Coprocessor path wrong then Region open failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] infraio opened a new pull request #122: HBASE-22163 Should not archive the compacted store files when region warmup
infraio opened a new pull request #122: HBASE-22163 Should not archive the compacted store files when region warmup URL: https://github.com/apache/hbase/pull/122 Should not archive the compacted store files when region warmup This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22169) Coprocessor path wrong then Region open failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: HBASE-22169-branch-2.2-v1.patch
> Coprocessor path wrong then Region open failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Attachments: HBASE-22169-branch-2-v1.patch,
> HBASE-22169-branch-2.1-v1.patch, HBASE-22169-branch-2.2-v1.patch,
> HBASE-22169-master-v1.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22163) Should not archive the compacted store files when region warmup
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-22163:
---
Summary: Should not archive the compacted store files when region warmup
(was: May send a warmup rpc for a splited parent region)
> Should not archive the compacted store files when region warmup
> ---
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] busbey commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT
busbey commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT URL: https://github.com/apache/hbase/pull/121#issuecomment-480653805 Peter has things set up on one of the other repos to build again when someone comments with a certain keyword. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT
busbey commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT URL: https://github.com/apache/hbase/pull/121#issuecomment-480653703 I retriggered it by going to the build and telling Jenkins to rebuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT
Apache9 commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT URL: https://github.com/apache/hbase/pull/121#issuecomment-480652515 These tests are easy to fail in pre commit due to a slow machine. So how could we trigger the QA again here? On jira we could just upload the patch again... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22171) Release 1.2.12
[ https://issues.apache.org/jira/browse/HBASE-22171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812015#comment-16812015 ] Sean Busbey edited comment on HBASE-22171 at 4/8/19 12:49 AM: -- VOTE for RC0 https://s.apache.org/hbase-1.2.12-rc0-vote was (Author: busbey): VOTE for RC0 https://lists.apache.org/thread.html/8f683059252e06fd44e75c8a9384e259661b825f5373424a56bbfd9d@ > Release 1.2.12 > -- > > Key: HBASE-22171 > URL: https://issues.apache.org/jira/browse/HBASE-22171 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.2.12 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.2.12 > > > Last planned release out of 1.2 line, so bit different on steps this time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22171) Release 1.2.12
[ https://issues.apache.org/jira/browse/HBASE-22171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812015#comment-16812015 ] Sean Busbey commented on HBASE-22171: - VOTE for RC0 https://lists.apache.org/thread.html/8f683059252e06fd44e75c8a9384e259661b825f5373424a56bbfd9d@ > Release 1.2.12 > -- > > Key: HBASE-22171 > URL: https://issues.apache.org/jira/browse/HBASE-22171 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.2.12 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 1.2.12 > > > Last planned release out of 1.2 line, so bit different on steps this time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812005#comment-16812005
]
Hudson commented on HBASE-22180:
Results for branch branch-2.1
[build #1033 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1033/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1033//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1033//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1033//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
[
https://issues.apache.org/jira/browse/HBASE-22178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812004#comment-16812004
]
Hudson commented on HBASE-22178:
Results for branch branch-2
[build #1804 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce a createTableAsync with TableDescriptor method in Admin
> -
>
> Key: HBASE-22178
> URL: https://issues.apache.org/jira/browse/HBASE-22178
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
> So we do not need to pass null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22108) Avoid passing null in Admin methods
[
https://issues.apache.org/jira/browse/HBASE-22108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812003#comment-16812003
]
Hudson commented on HBASE-22108:
Results for branch branch-2
[build #1804 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid passing null in Admin methods
> ---
>
> Key: HBASE-22108
> URL: https://issues.apache.org/jira/browse/HBASE-22108
> Project: HBase
> Issue Type: Task
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22108-branch-2.patch, HBASE-22108-branch-2.patch,
> HBASE-22108-branch-2.patch, HBASE-22108-v1.patch, HBASE-22108.patch
>
>
> For some methods we must pass null if we want specific behaviors, for
> example, move region to a random server, split region without providing an
> explicit split point, etc.
> We should provide methods without some parameters so user do not need to pass
> null.
> So in the future users do not need to guess whether a method accept null
> parameters, the answer is always no.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812002#comment-16812002
]
Hudson commented on HBASE-22180:
Results for branch branch-2
[build #1804 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1804//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT
Apache-HBase commented on issue #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT URL: https://github.com/apache/hbase/pull/121#issuecomment-480641155 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 302 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 379 | master passed | | +1 | compile | 68 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 357 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 191 | master passed | | +1 | javadoc | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 320 | the patch passed | | +1 | compile | 69 | the patch passed | | +1 | javac | 69 | the patch passed | | +1 | checkstyle | 91 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 333 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 684 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 201 | the patch passed | | +1 | javadoc | 42 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17534 | hbase-server in the patch failed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 20806 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.master.TestSplitWALManager | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-121/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/121 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux eab9ad775b83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 11547b79f3 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-121/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-121/1/testReport/ | | Max. process+thread count | 4921 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-121/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #105: should closing flag be set false in HRegion.java
Apache-HBase commented on issue #105: should closing flag be set false in HRegion.java URL: https://github.com/apache/hbase/pull/105#issuecomment-480639775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 238 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 256 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 71 | master passed | | +1 | shadedjars | 257 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 148 | master passed | | +1 | javadoc | 33 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 257 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 502 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 145 | the patch passed | | +1 | javadoc | 31 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15641 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 18118 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestSplitWALManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/105 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux babe299e61b0 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 11547b79f3 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/testReport/ | | Max. process+thread count | 4850 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-105/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811989#comment-16811989
]
Hudson commented on HBASE-22180:
Results for branch master
[build #915 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/915/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/915//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/915//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/915//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
[
https://issues.apache.org/jira/browse/HBASE-22178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811990#comment-16811990
]
Hudson commented on HBASE-22178:
Results for branch master
[build #915 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/915/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/915//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/915//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/915//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce a createTableAsync with TableDescriptor method in Admin
> -
>
> Key: HBASE-22178
> URL: https://issues.apache.org/jira/browse/HBASE-22178
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
> So we do not need to pass null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480636226 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 6 | https://github.com/apache/hbase/pull/91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/91 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811985#comment-16811985
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #168 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/168/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/168//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/168//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/168//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] medb commented on issue #104: Update findbugs-maven-plugin version [1.3 branch]
medb commented on issue #104: Update findbugs-maven-plugin version [1.3 branch] URL: https://github.com/apache/hbase/pull/104#issuecomment-480635727 This is already solved by https://issues.apache.org/jira/browse/HBASE-21687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] medb closed pull request #104: Update findbugs-maven-plugin version [1.3 branch]
medb closed pull request #104: Update findbugs-maven-plugin version [1.3 branch] URL: https://github.com/apache/hbase/pull/104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811980#comment-16811980
]
Hudson commented on HBASE-22180:
Results for branch branch-2.0
[build #1500 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1500/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1500//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1500//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1500//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811972#comment-16811972
]
Hudson commented on HBASE-22180:
Results for branch branch-2.2
[build #161 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22108) Avoid passing null in Admin methods
[
https://issues.apache.org/jira/browse/HBASE-22108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811973#comment-16811973
]
Hudson commented on HBASE-22108:
Results for branch branch-2.2
[build #161 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid passing null in Admin methods
> ---
>
> Key: HBASE-22108
> URL: https://issues.apache.org/jira/browse/HBASE-22108
> Project: HBase
> Issue Type: Task
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22108-branch-2.patch, HBASE-22108-branch-2.patch,
> HBASE-22108-branch-2.patch, HBASE-22108-v1.patch, HBASE-22108.patch
>
>
> For some methods we must pass null if we want specific behaviors, for
> example, move region to a random server, split region without providing an
> explicit split point, etc.
> We should provide methods without some parameters so user do not need to pass
> null.
> So in the future users do not need to guess whether a method accept null
> parameters, the answer is always no.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
[
https://issues.apache.org/jira/browse/HBASE-22178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811974#comment-16811974
]
Hudson commented on HBASE-22178:
Results for branch branch-2.2
[build #161 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/161//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce a createTableAsync with TableDescriptor method in Admin
> -
>
> Key: HBASE-22178
> URL: https://issues.apache.org/jira/browse/HBASE-22178
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
> So we do not need to pass null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #120: HBASE-20494 Updated the version of metrics-core to 3.2.6
Apache-HBase commented on issue #120: HBASE-20494 Updated the version of metrics-core to 3.2.6 URL: https://github.com/apache/hbase/pull/120#issuecomment-480631297 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 308 | master passed | | +1 | compile | 213 | master passed | | +1 | shadedjars | 332 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 207 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 314 | the patch passed | | +1 | compile | 217 | the patch passed | | +1 | javac | 217 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | +1 | shadedjars | 336 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 696 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | javadoc | 208 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17578 | root in the patch failed. | | +1 | asflicense | 34 | The patch does not generate ASF License warnings. | | | | 20558 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-120/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/120 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 6ebaff4ab0ff 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 11547b79f3 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-120/1/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-120/1/testReport/ | | Max. process+thread count | 4949 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-120/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21718) Implement Admin based on AsyncAdmin
[
https://issues.apache.org/jira/browse/HBASE-21718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811964#comment-16811964
]
HBase QA commented on HBASE-21718:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
46s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 44 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-21512 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
25s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
5s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
28s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
31s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
48s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
17s{color} | {color:green} HBASE-21512 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} hbase-server: The patch generated 0 new + 412
unchanged - 4 fixed = 412 total (was 416) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} The patch passed checkstyle in hbase-mapreduce
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} The patch passed checkstyle in hbase-thrift {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} The patch passed checkstyle in hbase-backup {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 56s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
47s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}257m 55s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 24m
57s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
43s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} |
[GitHub] [hbase] Apache-HBase commented on issue #92: HBASE-20521 change getConf as first sequence instead of jobContext in…
Apache-HBase commented on issue #92: HBASE-20521 change getConf as first sequence instead of jobContext in… URL: https://github.com/apache/hbase/pull/92#issuecomment-480622599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1180 | Docker mode activated. | ||| _ Prechecks _ | | 0 | findbugs | 0 | Findbugs executables are not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1.4 Compile Tests _ | | +1 | mvninstall | 152 | branch-1.4 passed | | +1 | compile | 38 | branch-1.4 passed with JDK v1.8.0_202 | | +1 | compile | 42 | branch-1.4 passed with JDK v1.7.0_211 | | +1 | checkstyle | 74 | branch-1.4 passed | | +1 | shadedjars | 156 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 30 | branch-1.4 passed with JDK v1.8.0_202 | | +1 | javadoc | 39 | branch-1.4 passed with JDK v1.7.0_211 | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 107 | the patch passed | | +1 | compile | 38 | the patch passed with JDK v1.8.0_202 | | +1 | javac | 38 | the patch passed | | +1 | compile | 46 | the patch passed with JDK v1.7.0_211 | | +1 | javac | 46 | the patch passed | | +1 | checkstyle | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 159 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 64 | The patch causes 26 errors with Hadoop v2.4.1. | | -1 | hadoopcheck | 139 | The patch causes 26 errors with Hadoop v2.5.2. | | +1 | javadoc | 28 | the patch passed with JDK v1.8.0_202 | | +1 | javadoc | 38 | the patch passed with JDK v1.7.0_211 | ||| _ Other Tests _ | | -1 | unit | 2838 | hbase-server in the patch failed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 5488 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.mapreduce.TestImportExport | | | hadoop.hbase.mapreduce.TestTimeRangeMapRed | | | hadoop.hbase.mapreduce.TestCopyTable | | | hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | hadoop.hbase.mapreduce.TestRowCounter | | | hadoop.hbase.master.procedure.TestCreateTableProcedure | | | hadoop.hbase.master.handler.TestEnableTableHandler | | | hadoop.hbase.master.TestOpenedRegionHandler | | | hadoop.hbase.master.balancer.TestBalancerStatusTagInJMXMetrics | | | hadoop.hbase.mapreduce.TestImportTsv | | | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | | | hadoop.hbase.master.TestMasterFailover | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.master.TestMasterBalanceThrottling | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.TestHColumnDescriptorDefaultVersions | | | hadoop.hbase.mapreduce.TestCellCounter | | | hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster | | | hadoop.hbase.master.TestMasterFileSystemWithWALDir | | | hadoop.hbase.master.TestRestartCluster | | | hadoop.hbase.TestHBaseTestingUtility | | | hadoop.hbase.master.procedure.TestModifyTableProcedure | | | hadoop.hbase.master.TestMasterMetricsWrapper | | | hadoop.hbase.mapreduce.TestTableInputFormatScan2 | | | hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient | | | hadoop.hbase.mapreduce.TestHFileOutputFormat2 | | | hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | hadoop.hbase.mapreduce.TestTableMapReduce | | | hadoop.hbase.master.procedure.TestEnableTableProcedure | | | hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure | | | hadoop.hbase.mapreduce.TestWALRecordReader | | | hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | hadoop.hbase.TestAcidGuarantees | | | hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner | | | hadoop.hbase.master.TestDistributedLogSplitting | | | hadoop.hbase.master.TestSplitLogManager | | | hadoop.hbase.master.TestAssignmentListener | | | hadoop.hbase.mapreduce.TestTableSnapshotInputFormat | | | hadoop.hbase.master.TestGetInfoPort | | | hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels | | | hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery | | | hadoop.hbase.mapreduce.TestHFileOutputFormat | | | hadoop.hbase.master.TestRegionPlacement2 | | |
[GitHub] [hbase] Apache-HBase commented on issue #100: HBASE-21467 Fix flaky test TestCoprocessorClassLoader.testCleanupOldJars
Apache-HBase commented on issue #100: HBASE-21467 Fix flaky test TestCoprocessorClassLoader.testCleanupOldJars URL: https://github.com/apache/hbase/pull/100#issuecomment-480619152 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 278 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 319 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 29 | master passed | | +1 | shadedjars | 332 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 51 | master passed | | +1 | javadoc | 25 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 315 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 28 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 334 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 654 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 59 | the patch passed | | +1 | javadoc | 23 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 188 | hbase-common in the patch passed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 2763 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/100 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a38276c593df 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 11547b79f3 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/1/testReport/ | | Max. process+thread count | 290 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-100/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[
https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811941#comment-16811941
]
HBase QA commented on HBASE-22155:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
30s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
35s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
55s{color} | {color:green} branch-2.2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 5s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m 3s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 58s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.shaded.protobuf.TestProtobufUtil |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/12/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22155 |
| JIRA Patch URL |
[GitHub] [hbase] Apache-HBase commented on issue #98: Basic heat map implementation at region level
Apache-HBase commented on issue #98: Basic heat map implementation at region level URL: https://github.com/apache/hbase/pull/98#issuecomment-480615514 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 6 | https://github.com/apache/hbase/pull/98 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/98 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-98/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22183) [hbck2] Update hbck2 README to explain new "setRegionState" method.
[
https://issues.apache.org/jira/browse/HBASE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811937#comment-16811937
]
stack commented on HBASE-22183:
---
Excellent.
Rather than listing table states, elsewhere in help output I see we do this:
{{{Arrays.stream(TableState.State.values()).map(i ->
i.toString()).collect(Collectors.joining(", ")));}}} Should we do same here?
s/resource/resort/
s/for this is/are when/
s/due region/due to region/
s/on an/in an/
s/a running/by a running/
Nice clarification to the philosophy behind hbck2 operations.
I suppose we should figure a way to ship code code that can be interpreted
server-side. Super dangerous and insecure but maybe we figure something?
Thanks for working on this [~wchevreuil]
> [hbck2] Update hbck2 README to explain new "setRegionState" method.
> ---
>
> Key: HBASE-22183
> URL: https://issues.apache.org/jira/browse/HBASE-22183
> Project: HBase
> Issue Type: New Feature
>Reporter: Wellington Chevreuil
>Priority: Minor
> Attachments: HBASE-22183-master-001.patch
>
>
> HBase-22143 introduced new *setRegionState* method that allows for manually
> setting a region to an specific state, in meta. This was added a client side
> logic for updating region state, to workout case where region is left in
> OPENING state (unassigns/assigns will fail to progress here) on releases
> prior to 2.1.2 (when scheduleServerCrashProcedure was added to Master's
> HbckService). To reflect, this jira adds not only setRegionState description,
> but also additional explanations on the Overview section of README.md file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[ https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811936#comment-16811936 ] Sean Busbey commented on HBASE-22020: - The feature branch for the upgrade on master and branches-2 looks fine. The one for braches-1 is a mess, but I don't think that's due to the upgrade. Also the xml parsing error that brought me here isn't actually fixed in yetus yet, so I'll try a workaround next. > upgrade to yetus 0.9.0 > -- > > Key: HBASE-22020 > URL: https://issues.apache.org/jira/browse/HBASE-22020 > Project: HBase > Issue Type: Task > Components: build, community >Reporter: stack >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch, > HBASE-22020.1.patch > > > branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language > js can not be found" > See parent for some context. Checkstyle references dtds that were hosted on > puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing > for among other reasons, complaint that there is bad xml in the build... > notably, the unresolvable DTDs. > I'd just update the DTDs but there is a need for a js engine some where and > openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and > then we can backport the parent issue... > See > https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt > ... which in case its rolled away, is filled with this message: > "script engine for language js can not be found" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22155: -- Attachment: HBASE-22155-branch-2.2.v004.patch > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155.branch-2.2.001.patch, > HBASE-22155.branch-2.2.002.patch, HBASE-22155.branch-2.2.003.patch, > HBASE-22155.branch-2.2.004.patch, HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811931#comment-16811931 ] stack commented on HBASE-22155: --- Woah. Unexpected total pass. Suspicious. Let me retry. > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155.branch-2.2.001.patch, > HBASE-22155.branch-2.2.002.patch, HBASE-22155.branch-2.2.003.patch, > HBASE-22155.branch-2.2.004.patch, HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] HorizonNet opened a new pull request #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT
HorizonNet opened a new pull request #121: HBASE-17666 Removed remaining usage of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_DEFAULT URL: https://github.com/apache/hbase/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-18333) Upgrade maven-site-plugin to ASF version
[ https://issues.apache.org/jira/browse/HBASE-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811911#comment-16811911 ] Jan Hentschel commented on HBASE-18333: --- I think that we can close this one. The master is currently using the parent POM v. 21. > Upgrade maven-site-plugin to ASF version > > > Key: HBASE-18333 > URL: https://issues.apache.org/jira/browse/HBASE-18333 > Project: HBase > Issue Type: Improvement >Reporter: Peter Somogyi >Priority: Minor > > Currently we use maven-site-plugin version 3.4. The ASF parent pom v.18 uses > 3.5.1. > https://svn.apache.org/viewvc/maven/pom/tags/apache-18/pom.xml?view=markup > Migration steps described here: > http://maven.apache.org/plugins/maven-site-plugin/migrate.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] HorizonNet opened a new pull request #120: HBASE-20494 Updated the version of metrics-core to 3.2.6
HorizonNet opened a new pull request #120: HBASE-20494 Updated the version of metrics-core to 3.2.6 URL: https://github.com/apache/hbase/pull/120 Raised the version of metrics-core from 3.2.1 to 3.2.6. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-20494) Upgrade com.yammer.metrics dependency
[
https://issues.apache.org/jira/browse/HBASE-20494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned HBASE-20494:
-
Assignee: Jan Hentschel
> Upgrade com.yammer.metrics dependency
> -
>
> Key: HBASE-20494
> URL: https://issues.apache.org/jira/browse/HBASE-20494
> Project: HBase
> Issue Type: Improvement
> Components: dependencies
>Reporter: Vlad Rozov
>Assignee: Jan Hentschel
>Priority: Major
>
> The current {{com.yammer.metrics}} version is quite outdated. Please consider
> upgrading to the latest {{io.dropwizard.metrics}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work started] (HBASE-20494) Upgrade com.yammer.metrics dependency
[
https://issues.apache.org/jira/browse/HBASE-20494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-20494 started by Jan Hentschel.
-
> Upgrade com.yammer.metrics dependency
> -
>
> Key: HBASE-20494
> URL: https://issues.apache.org/jira/browse/HBASE-20494
> Project: HBase
> Issue Type: Improvement
> Components: dependencies
>Reporter: Vlad Rozov
>Assignee: Jan Hentschel
>Priority: Major
>
> The current {{com.yammer.metrics}} version is quite outdated. Please consider
> upgrading to the latest {{io.dropwizard.metrics}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet commented on issue #105: should closing flag be set false in HRegion.java
HorizonNet commented on issue #105: should closing flag be set false in HRegion.java URL: https://github.com/apache/hbase/pull/105#issuecomment-480600551 @zhengxle Could you please update the commit message to include the Jira ticket ID? See the appropriate [documentation](https://hbase.apache.org/book.html#_commit_message_format) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #104: Update findbugs-maven-plugin version [1.3 branch]
HorizonNet commented on issue #104: Update findbugs-maven-plugin version [1.3 branch] URL: https://github.com/apache/hbase/pull/104#issuecomment-480600080 @medb What's the underlying Jira ticket for this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22183) [hbck2] Update hbck2 README to explain new "setRegionState" method.
[ https://issues.apache.org/jira/browse/HBASE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-22183: - Attachment: HBASE-22183-master-001.patch > [hbck2] Update hbck2 README to explain new "setRegionState" method. > --- > > Key: HBASE-22183 > URL: https://issues.apache.org/jira/browse/HBASE-22183 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22183-master-001.patch > > > HBase-22143 introduced new *setRegionState* method that allows for manually > setting a region to an specific state, in meta. This was added a client side > logic for updating region state, to workout case where region is left in > OPENING state (unassigns/assigns will fail to progress here) on releases > prior to 2.1.2 (when scheduleServerCrashProcedure was added to Master's > HbckService). To reflect, this jira adds not only setRegionState description, > but also additional explanations on the Overview section of README.md file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22143) HBCK2 setRegionState command
[
https://issues.apache.org/jira/browse/HBASE-22143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811908#comment-16811908
]
Wellington Chevreuil commented on HBASE-22143:
--
{quote}Sorry I'm late on feedback here, but what happens when I try to use this
to set the region state for meta?
{quote}
Since meta region is not stored in meta table itself, it will do nothing and
return a message saying it couldn't find any region with the passed encoded
name in meta table.
{quote}Also there's no update to the README explaining that this command exists
or when I should or should not use it. Wellington Chevreuil can you open a
followup please to add that?{quote}
Sure, opened HBASE-22183 for that.
> HBCK2 setRegionState command
>
>
> Key: HBASE-22143
> URL: https://issues.apache.org/jira/browse/HBASE-22143
> Project: HBase
> Issue Type: New Feature
> Components: hbase-operator-tools, hbck2
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: hbck2-1.0.0
>
> Attachments: HBASE-22143.master.0001.patch,
> HBASE-22143.master.0002.patch, HBASE-22143.master.0003.patch
>
>
> Among some of the current AMv2 issues, we faced situation where some regions
> had state as OPENING in meta, with an RS startcode that was not valid
> anymore. There was no AP running, the region stays permanently being logged
> as IN-Transition on master logs, yet no procedure is really trying to bring
> it online. Current hbck2 unassigns/assigns commands didn't work either, as
> per the exception shown, it expects regions to be in state SPLITTING, SPLIT,
> MERGING, OPEN, or CLOSING:
> {noformat}
> WARN org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure:
> Failed transition, suspend 1secs pid=7093,
> state=RUNNABLE:REGION_TRANSITION_DISPATCH, locked=true; UnassignProcedure
> table=rc_accounts, region=db85127b77fa56f7ad44e2c988e53925,
> server=server1.example.com,16020,1552682193324; rit=OPENING,
> location=server1.example.com,16020,1552682193324; waiting on rectified
> condition fixed by other Procedure or operator intervention
> org.apache.hadoop.hbase.exceptions.UnexpectedStateException: Expected
> [SPLITTING, SPLIT, MERGING, OPEN, CLOSING] so could move to CLOSING but
> current state=OPENING
> at
> org.apache.hadoop.hbase.master.assignment.RegionStates$RegionStateNode.transitionState(RegionStates.java:166)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.markRegionAsClosing(AssignmentManager.java:1479)
> at
> org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:212)
> at
> org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:369)
> at
> org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:97)
> at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:957)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1835)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1595){noformat}
> In this specific case, since we know the region is not actually being
> operated by any proc and is not really open anywhere, it's ok to manually set
> it's state to one of those assigns/unassigns can operate on, so this jira
> proposes a new hbck2 command that allows for arbitrarily set a region to a
> given state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22183) [hbck2] Update hbck2 README to explain new "setRegionState" method.
Wellington Chevreuil created HBASE-22183: Summary: [hbck2] Update hbck2 README to explain new "setRegionState" method. Key: HBASE-22183 URL: https://issues.apache.org/jira/browse/HBASE-22183 Project: HBase Issue Type: New Feature Reporter: Wellington Chevreuil HBase-22143 introduced new *setRegionState* method that allows for manually setting a region to an specific state, in meta. This was added a client side logic for updating region state, to workout case where region is left in OPENING state (unassigns/assigns will fail to progress here) on releases prior to 2.1.2 (when scheduleServerCrashProcedure was added to Master's HbckService). To reflect, this jira adds not only setRegionState description, but also additional explanations on the Overview section of README.md file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811900#comment-16811900
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #167 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/167/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/167//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/167//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/167//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21718) Implement Admin based on AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-21718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21718: -- Attachment: HBASE-21718-HBASE-21512-v6.patch > Implement Admin based on AsyncAdmin > --- > > Key: HBASE-21718 > URL: https://issues.apache.org/jira/browse/HBASE-21718 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-21718-HBASE-21512-v1.patch, > HBASE-21718-HBASE-21512-v2.patch, HBASE-21718-HBASE-21512-v3.patch, > HBASE-21718-HBASE-21512-v4.patch, HBASE-21718-HBASE-21512-v5.patch, > HBASE-21718-HBASE-21512-v6.patch, HBASE-21718-HBASE-21512.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22182) Introduce a getRegionMetrics(ServerName) method
Duo Zhang created HBASE-22182: - Summary: Introduce a getRegionMetrics(ServerName) method Key: HBASE-22182 URL: https://issues.apache.org/jira/browse/HBASE-22182 Project: HBase Issue Type: Task Reporter: Duo Zhang So we do not need to pass null if we want to get all the regions of a region server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480593757 You have some merge commits in your own repo, which leads to conflicts. I suggest you record the commit id 'fcfa14e2f176d19e9ce984fe4687c3e1fd57e66f', and then reset to an earlier commit before the merge commits, and then sync with the master branch of apache/hbase again, and then cherry-pick the 'fcfa14e2f176d19e9ce984fe4687c3e1fd57e66f'. And last, do a force push your master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gangxueZhang commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
gangxueZhang commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480592656 @Apache9 Hey, I have done what you said, but I don't know if it is right, help me confirm it,please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811891#comment-16811891
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #53 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/53/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/53//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/53//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/53//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
[ https://issues.apache.org/jira/browse/HBASE-22178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22178. --- Resolution: Fixed Hadoop Flags: Reviewed Release Note: Introduced Future createTableAsync(TableDescriptor); Pushed to branch-2.2+. Thanks [~zghaobac] for reviewing. > Introduce a createTableAsync with TableDescriptor method in Admin > - > > Key: HBASE-22178 > URL: https://issues.apache.org/jira/browse/HBASE-22178 > Project: HBase > Issue Type: Bug > Components: Admin >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > > So we do not need to pass null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
[ https://issues.apache.org/jira/browse/HBASE-22178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22178: -- Fix Version/s: 2.3.0 2.2.0 3.0.0 > Introduce a createTableAsync with TableDescriptor method in Admin > - > > Key: HBASE-22178 > URL: https://issues.apache.org/jira/browse/HBASE-22178 > Project: HBase > Issue Type: Bug > Components: Admin >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > > So we do not need to pass null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480591516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 5 | https://github.com/apache/hbase/pull/91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/91 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22108) Avoid passing null in Admin methods
[ https://issues.apache.org/jira/browse/HBASE-22108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22108: -- Release Note: Introduced these methods: void move(byte[]); void move(byte[], ServerName); Future splitRegionAsync(byte[]); These methods are deprecated: void move(byte[], byte[]) > Avoid passing null in Admin methods > --- > > Key: HBASE-22108 > URL: https://issues.apache.org/jira/browse/HBASE-22108 > Project: HBase > Issue Type: Task > Components: Admin >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22108-branch-2.patch, HBASE-22108-branch-2.patch, > HBASE-22108-branch-2.patch, HBASE-22108-v1.patch, HBASE-22108.patch > > > For some methods we must pass null if we want specific behaviors, for > example, move region to a random server, split region without providing an > explicit split point, etc. > We should provide methods without some parameters so user do not need to pass > null. > So in the future users do not need to guess whether a method accept null > parameters, the answer is always no. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22108) Avoid passing null in Admin methods
[ https://issues.apache.org/jira/browse/HBASE-22108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22108: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to branch-2.2+. Thanks [~zghaobac] for reviewing. Will fill the release note soon. > Avoid passing null in Admin methods > --- > > Key: HBASE-22108 > URL: https://issues.apache.org/jira/browse/HBASE-22108 > Project: HBase > Issue Type: Task > Components: Admin >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22108-branch-2.patch, HBASE-22108-branch-2.patch, > HBASE-22108-branch-2.patch, HBASE-22108-v1.patch, HBASE-22108.patch > > > For some methods we must pass null if we want specific behaviors, for > example, move region to a random server, split region without providing an > explicit split point, etc. > We should provide methods without some parameters so user do not need to pass > null. > So in the future users do not need to guess whether a method accept null > parameters, the answer is always no. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22163) May send a warmup rpc for a splited parent region
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-22163:
---
Priority: Blocker (was: Major)
> May send a warmup rpc for a splited parent region
> -
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 merged pull request #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method …
Apache9 merged pull request #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method … URL: https://github.com/apache/hbase/pull/117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-22180.
---
Resolution: Fixed
Hadoop Flags: Reviewed
Pushed to branch-2.0+.
Thanks [~openinx] for reviewing.
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22180:
--
Fix Version/s: 2.1.5
2.0.6
2.3.0
2.2.0
3.0.0
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480588198 Just check out the newest master of hbase, and cherry-pick your old patch, resolve conflicts, then force push to your master, the PR here will be changed automatically. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp…
Apache9 merged pull request #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp… URL: https://github.com/apache/hbase/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
[
https://issues.apache.org/jira/browse/HBASE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811838#comment-16811838
]
Hudson commented on HBASE-22179:
Results for branch master
[build #913 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/913/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/913//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/913//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/913//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix RawAsyncHBaseAdmin.getCompactionState
> -
>
> Key: HBASE-22179
> URL: https://issues.apache.org/jira/browse/HBASE-22179
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> {code}
> if (!future.isDone()) {
> future.complete(state);
> }
> {code}
> This piece of code should be placed outside the for loop, it should be a
> typo. And we should use a thread safe collection to collect the region state
> instead of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22177) Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
[
https://issues.apache.org/jira/browse/HBASE-22177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811837#comment-16811837
]
Hudson commented on HBASE-22177:
Results for branch master
[build #913 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/913/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/913//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/913//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/913//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
> ---
>
> Key: HBASE-22177
> URL: https://issues.apache.org/jira/browse/HBASE-22177
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> This should be a typo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22177) Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
[
https://issues.apache.org/jira/browse/HBASE-22177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811831#comment-16811831
]
Hudson commented on HBASE-22177:
Results for branch branch-2.2
[build #160 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
> ---
>
> Key: HBASE-22177
> URL: https://issues.apache.org/jira/browse/HBASE-22177
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> This should be a typo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
[
https://issues.apache.org/jira/browse/HBASE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811832#comment-16811832
]
Hudson commented on HBASE-22179:
Results for branch branch-2.2
[build #160 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/160//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix RawAsyncHBaseAdmin.getCompactionState
> -
>
> Key: HBASE-22179
> URL: https://issues.apache.org/jira/browse/HBASE-22179
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> {code}
> if (!future.isDone()) {
> future.complete(state);
> }
> {code}
> This piece of code should be placed outside the for loop, it should be a
> typo. And we should use a thread safe collection to collect the region state
> instead of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
[
https://issues.apache.org/jira/browse/HBASE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811822#comment-16811822
]
Hudson commented on HBASE-22179:
Results for branch branch-2.1
[build #1031 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix RawAsyncHBaseAdmin.getCompactionState
> -
>
> Key: HBASE-22179
> URL: https://issues.apache.org/jira/browse/HBASE-22179
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> {code}
> if (!future.isDone()) {
> future.complete(state);
> }
> {code}
> This piece of code should be placed outside the for loop, it should be a
> typo. And we should use a thread safe collection to collect the region state
> instead of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22177) Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
[
https://issues.apache.org/jira/browse/HBASE-22177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811821#comment-16811821
]
Hudson commented on HBASE-22177:
Results for branch branch-2.1
[build #1031 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1031//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
> ---
>
> Key: HBASE-22177
> URL: https://issues.apache.org/jira/browse/HBASE-22177
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> This should be a typo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
[
https://issues.apache.org/jira/browse/HBASE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811820#comment-16811820
]
Hudson commented on HBASE-22179:
Results for branch branch-2
[build #1803 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1803/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1803//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1803//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1803//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix RawAsyncHBaseAdmin.getCompactionState
> -
>
> Key: HBASE-22179
> URL: https://issues.apache.org/jira/browse/HBASE-22179
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> {code}
> if (!future.isDone()) {
> future.complete(state);
> }
> {code}
> This piece of code should be placed outside the for loop, it should be a
> typo. And we should use a thread safe collection to collect the region state
> instead of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
