[GitHub] [hbase] HorizonNet commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY
HorizonNet commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY URL: https://github.com/apache/hbase/pull/124#issuecomment-481113139 Ok. Let me change the Jira tickets and this PR accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
HorizonNet commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131#discussion_r273334485 ## File path: hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml ## @@ -37,6 +37,7 @@ + Review comment: Yes, you're right. That's too general. Will change it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
HorizonNet commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131#discussion_r273334380 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpRequestLogAppender.java ## @@ -1,4 +1,4 @@ -/** +/* Review comment: Most of the time ([example](https://gist.github.com/SparklingComet/6d4bd88ae8559eb8a66a4385f89d8250)) I see it with a single *. I know that we use some kind of mixture. In IntelliJ this is also marked as a dangling JavaDoc comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22163) Should not archive the compacted store files when region warmup
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813016#comment-16813016
]
Anoop Sam John commented on HBASE-22163:
How we solved the bug finally? can add as a comment or RN pls?
> Should not archive the compacted store files when region warmup
> ---
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22060) postOpenDeployTasks could send OPENED region transition state to the wrong master
[
https://issues.apache.org/jira/browse/HBASE-22060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bahram Chehrazy updated HBASE-22060:
Attachment:
Reset-cached-rssStub-on-region-servers-as-soon-as-the-master-changes-v2.patch
> postOpenDeployTasks could send OPENED region transition state to the wrong
> master
> -
>
> Key: HBASE-22060
> URL: https://issues.apache.org/jira/browse/HBASE-22060
> Project: HBase
> Issue Type: Bug
> Components: amv2, proc-v2
>Affects Versions: 3.0.0
>Reporter: Bahram Chehrazy
>Assignee: Duo Zhang
>Priority: Critical
> Attachments:
> Reset-cached-rssStub-on-region-servers-as-soon-as-the-master-changes-v2.patch
>
>
> As was reported in HBASE-21788, we have repeatedly seen regions getting stuck
> in OPENING after master restarts. Here is one scenario that I've observed
> recently:
>
> 1) There is a region is transit (RIT).
> 2) The active master aborts and begins shutting down.
> 3) The backup master becomes active quickly, finds the RIT, creates
> OpenRegionProcedure and send request to some server.
> 4) The server quickly opens the region and posts OPENED state transition, but
> it uses its cached master instead of the new one.
> 5) The old active master which had not completely shutdown its assignment
> manager yet, notes the OPENED state report and ignores it. Because no
> corresponding procedure can be found.
> 6) The new master waits forever for a response to its OPEN region request.
>
> This happens more often with the meta region because it's small and takes a
> few seconds to open. Below are some related logs:
> *Previous HMaster:*
> 2019-03-14 13:19:16,310 ERROR [PEWorker-1] master.HMaster: * ABORTING
> master ,17000,1552438242232: Shutting down HBase cluster: file
> system not available *
> 2019-03-14 13:19:16,310 INFO [PEWorker-1] regionserver.HRegionServer: *
> STOPPING region server ',17000,1552438242232' *
> 2019-03-14 13:20:54,358 WARN
> [RpcServer.priority.FPBQ.Fifo.handler=11,queue=1,port=17000]
> assignment.AssignmentManager: No matching procedure found for rit=OPEN,
> location=*,17020,1552561955412, table=hbase:meta,
> region=1588230740 transition to OPENED
> 2019-03-14 13:20:55,707 INFO [master/:17000]
> assignment.AssignmentManager: Stopping assignment manager
> *New HMaster logs:*
> 2019-03-14 13:19:16,907 INFO [master/:17000:becomeActiveMaster]
> master.ActiveMasterManager: Deleting ZNode for
> /HBaseServerZnodeCommonDir/**/backup-masters/,17000,1552438259871
> from backup master directory
> 2019-03-14 13:19:17,031 INFO [master/:17000:becomeActiveMaster]
> master.ActiveMasterManager: Registered as active
> master=,17000,1552438259871
> 2019-03-14 13:20:52,017 INFO [PEWorker-12] zookeeper.MetaTableLocator:
> Setting hbase:meta (replicaId=0) location in ZooKeeper as
> ,17020,1552536956826
> 2019-03-14 13:20:52,105 INFO [PEWorker-12] procedure2.ProcedureExecutor:
> Initialized subprocedures=[\{pid=178230, ppid=178229, state=RUNNABLE,
> hasLock=false; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure}]
>
> *HServer logs:*
> 2019-03-14 13:20:52,708 INFO [RS_CLOSE_META-regionserver/:17020-0]
> handler.AssignRegionHandler: Open hbase:meta,,1.1588230740
> 2019-03-14 13:20:54,353 INFO [RS_CLOSE_META-regionserver/:17020-0]
> regionserver.HRegion: Opened 1588230740; next sequenceid=229166
> 2019-03-14 13:20:54,356 INFO [RS_CLOSE_META-regionserver/:17020-0]
> regionserver.HRegionServer: Post open deploy tasks for
> hbase:meta,,1.1588230740
> 2019-03-14 13:20:54,358 INFO [RS_CLOSE_META-regionserver/:17020-0]
> handler.AssignRegionHandler: Opened hbase:meta,,1.1588230740
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22060) postOpenDeployTasks could send OPENED region transition state to the wrong master
[
https://issues.apache.org/jira/browse/HBASE-22060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bahram Chehrazy updated HBASE-22060:
Attachment: (was:
Reset-cached-rssStub-on-region-servers-as-soon-as-the-master-changes-v2.patch)
> postOpenDeployTasks could send OPENED region transition state to the wrong
> master
> -
>
> Key: HBASE-22060
> URL: https://issues.apache.org/jira/browse/HBASE-22060
> Project: HBase
> Issue Type: Bug
> Components: amv2, proc-v2
>Affects Versions: 3.0.0
>Reporter: Bahram Chehrazy
>Assignee: Duo Zhang
>Priority: Critical
>
> As was reported in HBASE-21788, we have repeatedly seen regions getting stuck
> in OPENING after master restarts. Here is one scenario that I've observed
> recently:
>
> 1) There is a region is transit (RIT).
> 2) The active master aborts and begins shutting down.
> 3) The backup master becomes active quickly, finds the RIT, creates
> OpenRegionProcedure and send request to some server.
> 4) The server quickly opens the region and posts OPENED state transition, but
> it uses its cached master instead of the new one.
> 5) The old active master which had not completely shutdown its assignment
> manager yet, notes the OPENED state report and ignores it. Because no
> corresponding procedure can be found.
> 6) The new master waits forever for a response to its OPEN region request.
>
> This happens more often with the meta region because it's small and takes a
> few seconds to open. Below are some related logs:
> *Previous HMaster:*
> 2019-03-14 13:19:16,310 ERROR [PEWorker-1] master.HMaster: * ABORTING
> master ,17000,1552438242232: Shutting down HBase cluster: file
> system not available *
> 2019-03-14 13:19:16,310 INFO [PEWorker-1] regionserver.HRegionServer: *
> STOPPING region server ',17000,1552438242232' *
> 2019-03-14 13:20:54,358 WARN
> [RpcServer.priority.FPBQ.Fifo.handler=11,queue=1,port=17000]
> assignment.AssignmentManager: No matching procedure found for rit=OPEN,
> location=*,17020,1552561955412, table=hbase:meta,
> region=1588230740 transition to OPENED
> 2019-03-14 13:20:55,707 INFO [master/:17000]
> assignment.AssignmentManager: Stopping assignment manager
> *New HMaster logs:*
> 2019-03-14 13:19:16,907 INFO [master/:17000:becomeActiveMaster]
> master.ActiveMasterManager: Deleting ZNode for
> /HBaseServerZnodeCommonDir/**/backup-masters/,17000,1552438259871
> from backup master directory
> 2019-03-14 13:19:17,031 INFO [master/:17000:becomeActiveMaster]
> master.ActiveMasterManager: Registered as active
> master=,17000,1552438259871
> 2019-03-14 13:20:52,017 INFO [PEWorker-12] zookeeper.MetaTableLocator:
> Setting hbase:meta (replicaId=0) location in ZooKeeper as
> ,17020,1552536956826
> 2019-03-14 13:20:52,105 INFO [PEWorker-12] procedure2.ProcedureExecutor:
> Initialized subprocedures=[\{pid=178230, ppid=178229, state=RUNNABLE,
> hasLock=false; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure}]
>
> *HServer logs:*
> 2019-03-14 13:20:52,708 INFO [RS_CLOSE_META-regionserver/:17020-0]
> handler.AssignRegionHandler: Open hbase:meta,,1.1588230740
> 2019-03-14 13:20:54,353 INFO [RS_CLOSE_META-regionserver/:17020-0]
> regionserver.HRegion: Opened 1588230740; next sequenceid=229166
> 2019-03-14 13:20:54,356 INFO [RS_CLOSE_META-regionserver/:17020-0]
> regionserver.HRegionServer: Post open deploy tasks for
> hbase:meta,,1.1588230740
> 2019-03-14 13:20:54,358 INFO [RS_CLOSE_META-regionserver/:17020-0]
> handler.AssignRegionHandler: Opened hbase:meta,,1.1588230740
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22165) Huge Read requests for Meta table, while scan the user table with SCVF.
[ https://issues.apache.org/jira/browse/HBASE-22165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813014#comment-16813014 ] Anoop Sam John commented on HBASE-22165: You sure when you dont have the SCVF on scan, request storm on META wont be happening? > Huge Read requests for Meta table, while scan the user table with SCVF. > --- > > Key: HBASE-22165 > URL: https://issues.apache.org/jira/browse/HBASE-22165 > Project: HBase > Issue Type: Bug > Components: Filters, scan >Affects Versions: 2.1.1 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > > Huge Read Request are observed for the meta table, while running the scan > operation for the user table with filters (SCVF). > User table is a pre splited table of approx 500 regions, and the data is > loaded to all the regions. > In our test scenario, > 1. Table holds 10 million records across 500 regions. > 2. Executed the scan operation with SCVF to fetch 10 records as a result. > 3. But observed the more Read requests to the meta table. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22185) RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
[ https://issues.apache.org/jira/browse/HBASE-22185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813010#comment-16813010 ] Anoop Sam John commented on HBASE-22185: To get to exception might not be that likely (I mean when Off heap BC).. Still it will be better to return in finally. > RAMQueueEntry#writeToCache should freeBlock if any exception encountered > instead of the IOException catch block > > > Key: HBASE-22185 > URL: https://issues.apache.org/jira/browse/HBASE-22185 > Project: HBase > Issue Type: Bug >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > > When preparing patch for HBASE-22159, I found that if thrown an > AssertionError in RAMQueueEntry#writeToCache, the bucketAllocator won't free > its memory. > This is an memory leak bug, and should be fixed in almost all 2.x branches. > will also check branch-1.x -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Description:
In some cases (for example, coprocessor path is wrong) region open failed,
MetricsRegionWrapperImpl is already init and not close, cause memory leak;
{code:java}
2019-02-21 15:41:32,929 ERROR [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
at
org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
at
org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
at org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
at
org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
at
org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
at
org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
at
org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
at
org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
was:
By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl is
already init and not close, cause memory leak;
{code:java}
2019-02-21 15:41:32,929 ERROR [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
at
org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
at
org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
at org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
at
org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
at
org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
at
org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
at
[jira] [Updated] (HBASE-22169) Open region failed cause memory leak
[
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-22169:
--
Attachment: HBASE-22169-master-v2.patch
> Open region failed cause memory leak
>
>
> Key: HBASE-22169
> URL: https://issues.apache.org/jira/browse/HBASE-22169
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.1.5
>
> Attachments: HBASE-22169-master-v1.patch, HBASE-22169-master-v2.patch
>
>
> By coprocessor path wrong region will open failed, MetricsRegionWrapperImpl
> is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7]
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:619)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22159) ByteBufferIOEngine should support write off-heap ByteBuff to the bufferArray
[
https://issues.apache.org/jira/browse/HBASE-22159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812984#comment-16812984
]
Zheng Hu commented on HBASE-22159:
--
The TestBucketCache UT is related to patch.v5 , let me have a check.
> ByteBufferIOEngine should support write off-heap ByteBuff to the bufferArray
>
>
> Key: HBASE-22159
> URL: https://issues.apache.org/jira/browse/HBASE-22159
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Attachments: HBASE-22159.HBASE-21879.v1.patch,
> HBASE-22159.HBASE-21879.v2.patch, HBASE-22159.HBASE-21879.v3.patch,
> HBASE-22159.HBASE-21879.v4.patch, HBASE-22159.HBASE-21879.v5.patch
>
>
> In ByteBufferIOEngine , we have the assert:
> {code}
> @Override
> public void write(ByteBuffer srcBuffer, long offset) throws IOException {
> assert srcBuffer.hasArray();
> bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(),
> srcBuffer.arrayOffset());
> }
> @Override
> public void write(ByteBuff srcBuffer, long offset) throws IOException {
> // When caching block into BucketCache there will be single buffer
> backing for this HFileBlock.
> // This will work for now. But from the DFS itself if we get DBB then
> this may not hold true.
> assert srcBuffer.hasArray();
> bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(),
> srcBuffer.arrayOffset());
> }
> {code}
> Should remove the assert, and allow to write off-heap ByteBuff to bufferArray.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22193) Reduce the default ASSIGN_MAX_ATTEMPTS config
[
https://issues.apache.org/jira/browse/HBASE-22193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812981#comment-16812981
]
Allan Yang commented on HBASE-22193:
We set ASSIGN_MAX_ATTEMPTS to Int.Max because we can't let SCP fail, since
failed, the region will remain unassigned forever(unless using HBCK2 tool to
schedule a SCP again), as for the procedure log problem, I think we have
considered that, before we changed ASSIGN_MAX_ATTEMPTS to In.Max, we asked
[~Apache9] about whether purging the procedure log can work, it should not
left so many un-deleted log here even lots of retries. Is it a bug here,
[~Apache9]?
> Reduce the default ASSIGN_MAX_ATTEMPTS config
> -
>
> Key: HBASE-22193
> URL: https://issues.apache.org/jira/browse/HBASE-22193
> Project: HBase
> Issue Type: Improvement
>Reporter: Guanghao Zhang
>Priority: Major
>
>
> {code:java}
> public static final String ASSIGN_MAX_ATTEMPTS =
> "hbase.assignment.maximum.attempts";
> private static final int DEFAULT_ASSIGN_MAX_ATTEMPTS = Integer.MAX_VALUE;
> {code}
> Now the default config is Integer.MAX_VALUE.
>
> {code:java}
> 2019-04-09,10:50:44,921 INFO
> org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure:
> Retry=170813 of max=2147483647; pid=2849, ppid=2846,
> state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, locked=true;
> TransitRegionStateProcedure table=IntegrationTestBigLinkedList,
> region=634feb79a583480597e1843647d11228, REOPEN/MOVE; rit=OPENING,
> location=c4-hadoop-tst-st26.bj,29100,1554262369262
> {code}
> The ITBLL failed to open the region as HBASE-22163 and retry 170813 to
> reopen. After I fixed the problem and restart master, I found it need take a
> long time to init the old procedure logs because there are too many old
> logs...
> Code in WALProcedureStore,java.
>
> {code:java}
> private long initOldLogs(FileStatus[] logFiles) throws IOException {
> if (logFiles == null || logFiles.length == 0) {
> return 0L;
> }
> long maxLogId = 0;
> for (int i = 0; i < logFiles.length; ++i) {
> final Path logPath = logFiles[i].getPath();
> leaseRecovery.recoverFileLease(fs, logPath);
> if (!isRunning()) {
> throw new IOException("wal aborting");
> }
> maxLogId = Math.max(maxLogId, getLogIdFromName(logPath.getName()));
> ProcedureWALFile log = initOldLog(logFiles[i], this.walArchiveDir);
> if (log != null) {
> this.logs.add(log);
> }
> }
> initTrackerFromOldLogs();
> return maxLogId;
> }
> {code}
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22193) Reduce the default ASSIGN_MAX_ATTEMPTS config
Guanghao Zhang created HBASE-22193:
--
Summary: Reduce the default ASSIGN_MAX_ATTEMPTS config
Key: HBASE-22193
URL: https://issues.apache.org/jira/browse/HBASE-22193
Project: HBase
Issue Type: Improvement
Reporter: Guanghao Zhang
{code:java}
public static final String ASSIGN_MAX_ATTEMPTS =
"hbase.assignment.maximum.attempts";
private static final int DEFAULT_ASSIGN_MAX_ATTEMPTS = Integer.MAX_VALUE;
{code}
Now the default config is Integer.MAX_VALUE.
{code:java}
2019-04-09,10:50:44,921 INFO
org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure:
Retry=170813 of max=2147483647; pid=2849, ppid=2846,
state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, locked=true;
TransitRegionStateProcedure table=IntegrationTestBigLinkedList,
region=634feb79a583480597e1843647d11228, REOPEN/MOVE; rit=OPENING,
location=c4-hadoop-tst-st26.bj,29100,1554262369262
{code}
The ITBLL failed to open the region as HBASE-22163 and retry 170813 to reopen.
After I fixed the problem and restart master, I found it need take a long time
to init the old procedure logs because there are too many old logs...
Code in WALProcedureStore,java.
{code:java}
private long initOldLogs(FileStatus[] logFiles) throws IOException {
if (logFiles == null || logFiles.length == 0) {
return 0L;
}
long maxLogId = 0;
for (int i = 0; i < logFiles.length; ++i) {
final Path logPath = logFiles[i].getPath();
leaseRecovery.recoverFileLease(fs, logPath);
if (!isRunning()) {
throw new IOException("wal aborting");
}
maxLogId = Math.max(maxLogId, getLogIdFromName(logPath.getName()));
ProcedureWALFile log = initOldLog(logFiles[i], this.walArchiveDir);
if (log != null) {
this.logs.add(log);
}
}
initTrackerFromOldLogs();
return maxLogId;
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] busbey commented on issue #132: HBASE-22192 Delete misc 2.0.5 pom files from branch-2.1
busbey commented on issue #132: HBASE-22192 Delete misc 2.0.5 pom files from branch-2.1 URL: https://github.com/apache/hbase/pull/132#issuecomment-481081992 mind taking a look @saintstack? Okay for me to delete the whole `create-release` instead of the directories under it? should I add it to `.gitignore`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey opened a new pull request #132: HBASE-22192 Delete misc 2.0.5 pom files from branch-2.1
busbey opened a new pull request #132: HBASE-22192 Delete misc 2.0.5 pom files from branch-2.1 URL: https://github.com/apache/hbase/pull/132 bunch of files under dev-support/create-release that look to be left over from the 2.0.5 release process. shouldn't be on branch-2.1. remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail
[
https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812954#comment-16812954
]
Bing Xiao commented on HBASE-21751:
---
{noformat}
I think the root problem here is that, we throw exception in a constructor, and
do not do any cleanup work when there are exceptions in constructor. On master
branch, IIRC, I introduced a init method for WAL, for creating the first
writer. So maybe we could use the same pattern for branch-2.x, and when init
method throws any exceptions, we should close the WAL to do cleanup work. And
if close is also failed, then we abort the RS. What do you think{noformat}
[~Apache9] Follow your idea , I submit a patch when init method throws any
exceptions, try to close the WAL to do cleanup work, If close failed, then
abort the rs; How about this patch?And there are many ut run timeout, I don't
know why, it seems no relate to the patch.
Thanks
> WAL creation fails during region open may cause region assign forever fail
> --
>
> Key: HBASE-21751
> URL: https://issues.apache.org/jira/browse/HBASE-21751
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.2, 2.0.4
>Reporter: Allan Yang
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 2.0.6, 2.1.5, 2.2.1
>
> Attachments: HBASE-21751-branch-2.1-v1.patch, HBASE-21751.patch,
> HBASE-21751.v2.patch, HBASE-21751v2.patch
>
>
> During the first region opens on the RS, WALFactory will create a WAL file,
> but if the wal creation fails, in some cases, HDFS will leave a empty file in
> the dir(e.g. disk full, file is created succesfully but block allocation
> fails). We have a check in AbstractFSWAL that if WAL belong to the same
> factory exists, then a error will be throw. Thus, the region can never be
> open on this RS later.
> {code:java}
> 2019-01-17 02:15:53,320 ERROR [RS_OPEN_META-regionserver/server003:16020-0]
> handler.OpenRegionHandler(301): Failed open of region=hbase:meta,,1.1588230740
> java.io.IOException: Target WAL already exists within directory
> hdfs://cluster/hbase/WALs/server003.hbase.hostname.com,16020,1545269815888
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.(AbstractFSWAL.java:382)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.(AsyncFSWAL.java:210)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:72)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:47)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:138)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:57)
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:264)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2085)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:284)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:108)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
> at java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22192) Delete misc 2.0.5 pom files from branch-2.1
Sean Busbey created HBASE-22192: --- Summary: Delete misc 2.0.5 pom files from branch-2.1 Key: HBASE-22192 URL: https://issues.apache.org/jira/browse/HBASE-22192 Project: HBase Issue Type: Task Components: community Affects Versions: 2.1.4, 2.1.5 Reporter: Sean Busbey Assignee: Sean Busbey Fix For: 2.1.5 there are a bunch of 2.0.5 pom files in dev-support/create-release -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail
[
https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-21751:
--
Attachment: HBASE-21751-branch-2.1-v1.patch
> WAL creation fails during region open may cause region assign forever fail
> --
>
> Key: HBASE-21751
> URL: https://issues.apache.org/jira/browse/HBASE-21751
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.2, 2.0.4
>Reporter: Allan Yang
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 2.0.6, 2.1.5, 2.2.1
>
> Attachments: HBASE-21751-branch-2.1-v1.patch, HBASE-21751.patch,
> HBASE-21751.v2.patch, HBASE-21751v2.patch
>
>
> During the first region opens on the RS, WALFactory will create a WAL file,
> but if the wal creation fails, in some cases, HDFS will leave a empty file in
> the dir(e.g. disk full, file is created succesfully but block allocation
> fails). We have a check in AbstractFSWAL that if WAL belong to the same
> factory exists, then a error will be throw. Thus, the region can never be
> open on this RS later.
> {code:java}
> 2019-01-17 02:15:53,320 ERROR [RS_OPEN_META-regionserver/server003:16020-0]
> handler.OpenRegionHandler(301): Failed open of region=hbase:meta,,1.1588230740
> java.io.IOException: Target WAL already exists within directory
> hdfs://cluster/hbase/WALs/server003.hbase.hostname.com,16020,1545269815888
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.(AbstractFSWAL.java:382)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.(AsyncFSWAL.java:210)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:72)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:47)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:138)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:57)
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:264)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2085)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:284)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:108)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
> at java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail
[
https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bing Xiao updated HBASE-21751:
--
Attachment: (was: HBASE-21751-branch-2.1-v1.patch)
> WAL creation fails during region open may cause region assign forever fail
> --
>
> Key: HBASE-21751
> URL: https://issues.apache.org/jira/browse/HBASE-21751
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.2, 2.0.4
>Reporter: Allan Yang
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 2.0.6, 2.1.5, 2.2.1
>
> Attachments: HBASE-21751-branch-2.1-v1.patch, HBASE-21751.patch,
> HBASE-21751.v2.patch, HBASE-21751v2.patch
>
>
> During the first region opens on the RS, WALFactory will create a WAL file,
> but if the wal creation fails, in some cases, HDFS will leave a empty file in
> the dir(e.g. disk full, file is created succesfully but block allocation
> fails). We have a check in AbstractFSWAL that if WAL belong to the same
> factory exists, then a error will be throw. Thus, the region can never be
> open on this RS later.
> {code:java}
> 2019-01-17 02:15:53,320 ERROR [RS_OPEN_META-regionserver/server003:16020-0]
> handler.OpenRegionHandler(301): Failed open of region=hbase:meta,,1.1588230740
> java.io.IOException: Target WAL already exists within directory
> hdfs://cluster/hbase/WALs/server003.hbase.hostname.com,16020,1545269815888
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.(AbstractFSWAL.java:382)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.(AsyncFSWAL.java:210)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:72)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createWAL(AsyncFSWALProvider.java:47)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:138)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:57)
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:264)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2085)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:284)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:108)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1147)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
> at java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22163) Should not archive the compacted store files when region warmup
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812947#comment-16812947
]
Hudson commented on HBASE-22163:
Results for branch branch-2
[build #1807 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1807/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1807//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1807//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1807//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not archive the compacted store files when region warmup
> ---
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22163) Should not archive the compacted store files when region warmup
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812941#comment-16812941
]
Hudson commented on HBASE-22163:
Results for branch master
[build #918 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/918/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/918//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/918//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/918//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not archive the compacted store files when region warmup
> ---
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22173) Update doc on integration tests
[
https://issues.apache.org/jira/browse/HBASE-22173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812940#comment-16812940
]
Hudson commented on HBASE-22173:
Results for branch master
[build #918 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/918/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/918//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/918//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/918//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update doc on integration tests
> ---
>
> Key: HBASE-22173
> URL: https://issues.apache.org/jira/browse/HBASE-22173
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22173 doc.png, HBASE-22173.master.001.patch,
> HBASE-22173.master.002.patch
>
>
> Followed the doc to run integration tests but maven failed to run. Turns out
> an additional parameter {{-DfailIfNoTests=false}} is required, so file this
> jira to get that updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812939#comment-16812939
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #55 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/55/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/55//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/55//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/55//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.014.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[
https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812929#comment-16812929
]
HBase QA commented on HBASE-22155:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
37s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
50s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 15s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}195m
16s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}241m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/34/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22155 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965251/HBASE-22155.branch-2.001.patch
|
| Optional Tests | dupname
[GitHub] [hbase] openinx edited a comment on issue #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
openinx edited a comment on issue #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block URL: https://github.com/apache/hbase/pull/130#issuecomment-481072282 > A try finally will be better? Usually I will use a succ flag, and set it to true in the last, so in the finally block, if it is not true, then free the block. OK, let me address this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on issue #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
openinx commented on issue #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block URL: https://github.com/apache/hbase/pull/130#issuecomment-481072282 > A try finally will be better? Usually I will use a succ flag, and set it to true in the last, so in the finally block, if it is not true, then free the block. OK, let me address this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY
Apache9 commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY URL: https://github.com/apache/hbase/pull/124#issuecomment-481070474 Yes, maybe we can do it in one issue. Just remove these two fields, and target to 3.0.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-481067952 Seems the robot is still not able to apply the patch. @gangxueZhang Yes, you can close this one and open a new one, if it is easier for you. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
Apache9 commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131#discussion_r273296500 ## File path: hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml ## @@ -37,6 +37,7 @@ + Review comment: Maybe too general? We disable this check in our the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
Apache9 commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131#discussion_r273296668 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpRequestLogAppender.java ## @@ -1,4 +1,4 @@ -/** +/* Review comment: I think this should be **? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
Apache9 commented on a change in pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131#discussion_r273296875 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java ## @@ -1,4 +1,4 @@ -/** +/* * Review comment: Remove the empty line? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-481067293 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 6 | https://github.com/apache/hbase/pull/91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/91 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/5/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gangxueZhang commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
gangxueZhang commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-481067057 @Apache9 Hi, is this OK？ if not, can I close this PR and submit a new PR based on the latest version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22128) Move namespace region then master crashed make deadlock
[
https://issues.apache.org/jira/browse/HBASE-22128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812902#comment-16812902
]
Hudson commented on HBASE-22128:
Results for branch branch-2.1
[build #1036 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1036/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1036//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1036//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1036//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move namespace region then master crashed make deadlock
> ---
>
> Key: HBASE-22128
> URL: https://issues.apache.org/jira/browse/HBASE-22128
> Project: HBase
> Issue Type: Bug
> Components: amv2
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 2.0.6, 2.1.5
>
> Attachments: HBASE-22128-branch-2.1-v1.patch,
> HBASE-22128-branch-2.1-v2.patch, HBASE-22128-branch-2.1-v3.patch,
> HBASE-22128-branch-2.1-v4.patch, HBASE-22128-branch-2.1-v5.patch
>
>
> When move namespace region start unassign produre, after unassign procedure
> finished namespace region will be offline. At the same time master crashed
> then reboot will stuck, because master init is block by waiting namespace
> table online ,at same time master init not finish so move region procedure
> can not go on, make deadlock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20105) Allow flushes to target SSD storage
[
https://issues.apache.org/jira/browse/HBASE-20105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812865#comment-16812865
]
HBase QA commented on HBASE-20105:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-20105 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20105 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914473/HBASE-20105-v6.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/37/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Allow flushes to target SSD storage
> ---
>
> Key: HBASE-20105
> URL: https://issues.apache.org/jira/browse/HBASE-20105
> Project: HBase
> Issue Type: New Feature
> Components: Performance, regionserver
>Affects Versions: hbase-2.0.0-alpha-4
>Reporter: Jean-Marc Spaggiari
>Assignee: Jean-Marc Spaggiari
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20105-v0.patch, HBASE-20105-v1.patch,
> HBASE-20105-v2.patch, HBASE-20105-v3.patch, HBASE-20105-v4.patch,
> HBASE-20105-v5.patch, HBASE-20105-v6.patch
>
>
> On heavy writes usecases, flushes are compactes together pretty quickly.
> Allowing flushes to go on SSD allows faster flush and faster first
> compactions. Subsequent compactions going on regular storage.
>
> I will be interesting to have an option to target SSD for flushes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20105) Allow flushes to target SSD storage
[
https://issues.apache.org/jira/browse/HBASE-20105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812864#comment-16812864
]
HBase QA commented on HBASE-20105:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-20105 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20105 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914473/HBASE-20105-v6.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/36/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Allow flushes to target SSD storage
> ---
>
> Key: HBASE-20105
> URL: https://issues.apache.org/jira/browse/HBASE-20105
> Project: HBase
> Issue Type: New Feature
> Components: Performance, regionserver
>Affects Versions: hbase-2.0.0-alpha-4
>Reporter: Jean-Marc Spaggiari
>Assignee: Jean-Marc Spaggiari
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20105-v0.patch, HBASE-20105-v1.patch,
> HBASE-20105-v2.patch, HBASE-20105-v3.patch, HBASE-20105-v4.patch,
> HBASE-20105-v5.patch, HBASE-20105-v6.patch
>
>
> On heavy writes usecases, flushes are compactes together pretty quickly.
> Allowing flushes to go on SSD allows faster flush and faster first
> compactions. Subsequent compactions going on regular storage.
>
> I will be interesting to have an option to target SSD for flushes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-20105) Allow flushes to target SSD storage
[ https://issues.apache.org/jira/browse/HBASE-20105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-20105: --- Assignee: Sean Busbey (was: Jean-Marc Spaggiari) > Allow flushes to target SSD storage > --- > > Key: HBASE-20105 > URL: https://issues.apache.org/jira/browse/HBASE-20105 > Project: HBase > Issue Type: New Feature > Components: Performance, regionserver >Affects Versions: hbase-2.0.0-alpha-4 >Reporter: Jean-Marc Spaggiari >Assignee: Sean Busbey >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20105-v0.patch, HBASE-20105-v1.patch, > HBASE-20105-v2.patch, HBASE-20105-v3.patch, HBASE-20105-v4.patch, > HBASE-20105-v5.patch, HBASE-20105-v6.patch > > > On heavy writes usecases, flushes are compactes together pretty quickly. > Allowing flushes to go on SSD allows faster flush and faster first > compactions. Subsequent compactions going on regular storage. > > I will be interesting to have an option to target SSD for flushes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20105) Allow flushes to target SSD storage
[ https://issues.apache.org/jira/browse/HBASE-20105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-20105: Assignee: Jean-Marc Spaggiari (was: Sean Busbey) Status: Patch Available (was: In Progress) > Allow flushes to target SSD storage > --- > > Key: HBASE-20105 > URL: https://issues.apache.org/jira/browse/HBASE-20105 > Project: HBase > Issue Type: New Feature > Components: Performance, regionserver >Affects Versions: hbase-2.0.0-alpha-4 >Reporter: Jean-Marc Spaggiari >Assignee: Jean-Marc Spaggiari >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20105-v0.patch, HBASE-20105-v1.patch, > HBASE-20105-v2.patch, HBASE-20105-v3.patch, HBASE-20105-v4.patch, > HBASE-20105-v5.patch, HBASE-20105-v6.patch > > > On heavy writes usecases, flushes are compactes together pretty quickly. > Allowing flushes to go on SSD allows faster flush and faster first > compactions. Subsequent compactions going on regular storage. > > I will be interesting to have an option to target SSD for flushes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22172) Suppress Java 11 reflective access warnings
[
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22172:
---
Attachment: hbase-22172.master.001.patch
> Suppress Java 11 reflective access warnings
> ---
>
> Key: HBASE-22172
> URL: https://issues.apache.org/jira/browse/HBASE-22172
> Project: HBase
> Issue Type: Task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
> Labels: jdk11
> Attachments: hbase-22172.master.001.patch
>
>
> While running a Java 8 compiled hbase on Java 11 system, I found the
> following warnings being thrown. I think we can add the "--add-opens" flag to
> HBASE_OPTS (if the jdk version is 11) to suppress this warning.
> {code:java}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/jatsakthi/test/HBASE_TEST_AREA/hbase-3.0.0-SNAPSHOT/lib/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22172) Suppress Java 11 reflective access warnings
[
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812860#comment-16812860
]
Sakthi commented on HBASE-22172:
I tried hbase shell using --illegal-access=warn to list out all the warnings.
It listed around 250 warnings. I am not sure if there is any single flag that
can be passed to suppress all such warnings. We have to acknowledge the fact
that we know we are using these methods, by adding -add-opens flag for each of
them. I am attaching a sample patch.
> Suppress Java 11 reflective access warnings
> ---
>
> Key: HBASE-22172
> URL: https://issues.apache.org/jira/browse/HBASE-22172
> Project: HBase
> Issue Type: Task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
> Labels: jdk11
>
> While running a Java 8 compiled hbase on Java 11 system, I found the
> following warnings being thrown. I think we can add the "--add-opens" flag to
> HBASE_OPTS (if the jdk version is 11) to suppress this warning.
> {code:java}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/jatsakthi/test/HBASE_TEST_AREA/hbase-3.0.0-SNAPSHOT/lib/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22172) Suppress Java 11 reflective access warnings
[
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812859#comment-16812859
]
Sakthi commented on HBASE-22172:
FYI: [~busbey]
> Suppress Java 11 reflective access warnings
> ---
>
> Key: HBASE-22172
> URL: https://issues.apache.org/jira/browse/HBASE-22172
> Project: HBase
> Issue Type: Task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
> Labels: jdk11
>
> While running a Java 8 compiled hbase on Java 11 system, I found the
> following warnings being thrown. I think we can add the "--add-opens" flag to
> HBASE_OPTS (if the jdk version is 11) to suppress this warning.
> {code:java}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/jatsakthi/test/HBASE_TEST_AREA/hbase-3.0.0-SNAPSHOT/lib/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22128) Move namespace region then master crashed make deadlock
[
https://issues.apache.org/jira/browse/HBASE-22128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812855#comment-16812855
]
Hudson commented on HBASE-22128:
Results for branch branch-2.0
[build #1503 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1503/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1503//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1503//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1503//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Move namespace region then master crashed make deadlock
> ---
>
> Key: HBASE-22128
> URL: https://issues.apache.org/jira/browse/HBASE-22128
> Project: HBase
> Issue Type: Bug
> Components: amv2
>Affects Versions: 2.0.5, 2.1.4
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Critical
> Fix For: 2.0.6, 2.1.5
>
> Attachments: HBASE-22128-branch-2.1-v1.patch,
> HBASE-22128-branch-2.1-v2.patch, HBASE-22128-branch-2.1-v3.patch,
> HBASE-22128-branch-2.1-v4.patch, HBASE-22128-branch-2.1-v5.patch
>
>
> When move namespace region start unassign produre, after unassign procedure
> finished namespace region will be offline. At the same time master crashed
> then reboot will stuck, because master init is block by waiting namespace
> table online ,at same time master init not finish so move region procedure
> can not go on, make deadlock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22120) remove HTrace
[ https://issues.apache.org/jira/browse/HBASE-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812854#comment-16812854 ] Wei-Chiu Chuang commented on HBASE-22120: - I am starting to get serious about this, and I will assign the HADOOP side of the work to myself soon. Since HBase has to be aligned with Hadoop, I'd like to also assign this Jira to myself. I wonder if it makes sense to work on this in a feature branch. Would that be okay? I can start a DISCUSS thread for this. > remove HTrace > - > > Key: HBASE-22120 > URL: https://issues.apache.org/jira/browse/HBASE-22120 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Sergey Shelukhin >Priority: Major > > Suggested in HBASE-22115 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22163) Should not archive the compacted store files when region warmup
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812851#comment-16812851
]
Hudson commented on HBASE-22163:
Results for branch branch-2.2
[build #164 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/164/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/164//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/164//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/164//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not archive the compacted store files when region warmup
> ---
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21818) Incorrect list item in javadoc
[
https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812850#comment-16812850
]
Hudson commented on HBASE-21818:
Results for branch branch-1
[build #761 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/761/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/761//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/761//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/761//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Incorrect list item in javadoc
> --
>
> Key: HBASE-21818
> URL: https://issues.apache.org/jira/browse/HBASE-21818
> Project: HBase
> Issue Type: Improvement
> Components: documentation, master
>Affects Versions: 1.1.0
> Environment: has nothing to do with env
>Reporter: qiang Liu
>Assignee: qiang Liu
>Priority: Trivial
> Labels: easyfix, javadoc
> Fix For: 1.4.10, 1.3.4, 1.5.1
>
> Attachments: HBASE-21818.branch-1.001.patch,
> HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch,
> HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch,
> HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> the java doc of this function type a as ，so dispaly a blanck line
> {code:java}
> //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization
> {code}
> paste the function and it's doc here , please look the line "Ensure
> assignment of meta/namespace regions"
>
>
> {code:java}
> /**
> * Finish initialization of HMaster after becoming the primary master.
> *
> *
> * Initialize master components - file system manager, server manager,
> * assignment manager, region server tracker, etc
> * Start necessary service threads - balancer, catalog janior,
> * executor services, etc
> * Set cluster as UP in ZooKeeper
> * Wait for RegionServers to check-in
> * Split logs and perform data recovery, if necessary
> * Ensure assignment of meta/namespace regions
> * Handle either fresh cluster start or master failover
> *
> *
> * @throws IOException
> * @throws InterruptedException
> * @throws KeeperException
> * @throws CoordinatedStateException
> */
> private void finishActiveMasterInitialization(MonitoredTask status)
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22191) 2.1.4 is busted?
[
https://issues.apache.org/jira/browse/HBASE-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812846#comment-16812846
]
Sean Busbey commented on HBASE-22191:
-
HBASE-21709 would have helped with this, I think?
> 2.1.4 is busted?
>
>
> Key: HBASE-22191
> URL: https://issues.apache.org/jira/browse/HBASE-22191
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Major
>
> Trying to run it in cluster-format, it does this when I start master:
> {code}
> 2019-04-08 20:07:33,593 ERROR [main] master.HMasterCommandLine
> (HMasterCommandLine.java:startMaster(247)) - Master exiting
> java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMaster.
> at
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3100)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:236)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3111)
> Caused by: java.lang.NoClassDefFoundError: org/apache/htrace/SamplerBuilder
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:644)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:628)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2667)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:93)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2701)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2683)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:372)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.getRootDir(CommonFSUtils.java:362)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.isValidWALRootDir(CommonFSUtils.java:411)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.getWALRootDir(CommonFSUtils.java:387)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.initializeFileSystem(HRegionServer.java:704)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:613)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:489)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3093)
> ... 5 more
> Caused by: java.lang.ClassNotFoundException: org.apache.htrace.SamplerBuilder
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> {code}
> Ditto starting RegionServer.
> Fine in standalone mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812826#comment-16812826 ] stack commented on HBASE-22155: --- I pushed on branch-2.2. Trying patch against branch-2. > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155.branch-2.001.patch, HBASE-22155.branch-2.2.001.patch, > HBASE-22155.branch-2.2.002.patch, HBASE-22155.branch-2.2.003.patch, > HBASE-22155.branch-2.2.004.patch, HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22155: -- Attachment: HBASE-22155.branch-2.001.patch > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155.branch-2.001.patch, HBASE-22155.branch-2.2.001.patch, > HBASE-22155.branch-2.2.002.patch, HBASE-22155.branch-2.2.003.patch, > HBASE-22155.branch-2.2.004.patch, HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) Incorrect list item in javadoc
[
https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812806#comment-16812806
]
Hudson commented on HBASE-21818:
Results for branch branch-1.3
[build #717 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/717/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/717//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/717//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/717//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Incorrect list item in javadoc
> --
>
> Key: HBASE-21818
> URL: https://issues.apache.org/jira/browse/HBASE-21818
> Project: HBase
> Issue Type: Improvement
> Components: documentation, master
>Affects Versions: 1.1.0
> Environment: has nothing to do with env
>Reporter: qiang Liu
>Assignee: qiang Liu
>Priority: Trivial
> Labels: easyfix, javadoc
> Fix For: 1.4.10, 1.3.4, 1.5.1
>
> Attachments: HBASE-21818.branch-1.001.patch,
> HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch,
> HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch,
> HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> the java doc of this function type a as ，so dispaly a blanck line
> {code:java}
> //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization
> {code}
> paste the function and it's doc here , please look the line "Ensure
> assignment of meta/namespace regions"
>
>
> {code:java}
> /**
> * Finish initialization of HMaster after becoming the primary master.
> *
> *
> * Initialize master components - file system manager, server manager,
> * assignment manager, region server tracker, etc
> * Start necessary service threads - balancer, catalog janior,
> * executor services, etc
> * Set cluster as UP in ZooKeeper
> * Wait for RegionServers to check-in
> * Split logs and perform data recovery, if necessary
> * Ensure assignment of meta/namespace regions
> * Handle either fresh cluster start or master failover
> *
> *
> * @throws IOException
> * @throws InterruptedException
> * @throws KeeperException
> * @throws CoordinatedStateException
> */
> private void finishActiveMasterInitialization(MonitoredTask status)
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
Apache-HBase commented on issue #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block URL: https://github.com/apache/hbase/pull/130#issuecomment-481012266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 139 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 280 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 70 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 148 | master passed | | +1 | javadoc | 35 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 255 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 70 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 547 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 154 | the patch passed | | +1 | javadoc | 34 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18725 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 21215 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestConnectionImplementation | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.replication.TestSyncReplicationStandbyKillMaster | | | hadoop.hbase.client.replication.TestReplicationAdminWithClusters | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.quotas.TestSpaceQuotas | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/130 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9888d87fa513 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 89ce5d17e4 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/testReport/ | | Max. process+thread count | 5342 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22144) MultiRowRangeFilter does not work with reversed scans
[
https://issues.apache.org/jira/browse/HBASE-22144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812759#comment-16812759
]
HBase QA commented on HBASE-22144:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
29s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}137m
23s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}183m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/33/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22144 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965225/HBASE-22144.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6a8ac4c9da83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 89ce5d17e4 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs |
[jira] [Resolved] (HBASE-22191) 2.1.4 is busted?
[
https://issues.apache.org/jira/browse/HBASE-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack resolved HBASE-22191.
---
Resolution: Duplicate
See the release note on HBASE-22052... Resolving.
> 2.1.4 is busted?
>
>
> Key: HBASE-22191
> URL: https://issues.apache.org/jira/browse/HBASE-22191
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Major
>
> Trying to run it in cluster-format, it does this when I start master:
> {code}
> 2019-04-08 20:07:33,593 ERROR [main] master.HMasterCommandLine
> (HMasterCommandLine.java:startMaster(247)) - Master exiting
> java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMaster.
> at
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3100)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:236)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3111)
> Caused by: java.lang.NoClassDefFoundError: org/apache/htrace/SamplerBuilder
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:644)
> at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:628)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2667)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:93)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2701)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2683)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:372)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.getRootDir(CommonFSUtils.java:362)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.isValidWALRootDir(CommonFSUtils.java:411)
> at
> org.apache.hadoop.hbase.util.CommonFSUtils.getWALRootDir(CommonFSUtils.java:387)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.initializeFileSystem(HRegionServer.java:704)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:613)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:489)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3093)
> ... 5 more
> Caused by: java.lang.ClassNotFoundException: org.apache.htrace.SamplerBuilder
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> {code}
> Ditto starting RegionServer.
> Fine in standalone mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input
Apache-HBase commented on issue #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input URL: https://github.com/apache/hbase/pull/127#issuecomment-480991957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ HBASE-21879 Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 247 | HBASE-21879 passed | | +1 | compile | 71 | HBASE-21879 passed | | +1 | checkstyle | 92 | HBASE-21879 passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 180 | HBASE-21879 passed | | +1 | javadoc | 52 | HBASE-21879 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 256 | the patch passed | | +1 | compile | 72 | the patch passed | | +1 | javac | 72 | the patch passed | | -1 | checkstyle | 22 | hbase-common: The patch generated 1 new + 8 unchanged - 1 fixed = 9 total (was 9) | | +1 | checkstyle | 69 | hbase-server: The patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 494 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 203 | the patch passed | | +1 | javadoc | 54 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 164 | hbase-common in the patch passed. | | -1 | unit | 17397 | hbase-server in the patch failed. | | +1 | asflicense | 59 | The patch does not generate ASF License warnings. | | | | 20114 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestSplitWALManager | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.TestSplitMerge | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-127/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/127 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 559cb7044fc3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21879 / c70acf9ed4 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-127/2/artifact/out/diff-checkstyle-hbase-common.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-127/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-127/2/testReport/ | | Max. process+thread count | 5293 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-127/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812754#comment-16812754 ] stack commented on HBASE-22155: --- Let me apply. Will keep an eye on it after it goes in. > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155.branch-2.2.001.patch, HBASE-22155.branch-2.2.002.patch, > HBASE-22155.branch-2.2.003.patch, HBASE-22155.branch-2.2.004.patch, > HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22191) 2.1.4 is busted?
stack created HBASE-22191:
-
Summary: 2.1.4 is busted?
Key: HBASE-22191
URL: https://issues.apache.org/jira/browse/HBASE-22191
Project: HBase
Issue Type: Bug
Reporter: stack
Trying to run it in cluster-format, it does this when I start master:
{code}
2019-04-08 20:07:33,593 ERROR [main] master.HMasterCommandLine
(HMasterCommandLine.java:startMaster(247)) - Master exiting
java.lang.RuntimeException: Failed construction of Master: class
org.apache.hadoop.hbase.master.HMaster.
at
org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3100)
at
org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:236)
at
org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at
org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3111)
Caused by: java.lang.NoClassDefFoundError: org/apache/htrace/SamplerBuilder
at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:644)
at org.apache.hadoop.hdfs.DFSClient.(DFSClient.java:628)
at
org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
at
org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2667)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:93)
at
org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2701)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2683)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:372)
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
at
org.apache.hadoop.hbase.util.CommonFSUtils.getRootDir(CommonFSUtils.java:362)
at
org.apache.hadoop.hbase.util.CommonFSUtils.isValidWALRootDir(CommonFSUtils.java:411)
at
org.apache.hadoop.hbase.util.CommonFSUtils.getWALRootDir(CommonFSUtils.java:387)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.initializeFileSystem(HRegionServer.java:704)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:613)
at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:489)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3093)
... 5 more
Caused by: java.lang.ClassNotFoundException: org.apache.htrace.SamplerBuilder
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
{code}
Ditto starting RegionServer.
Fine in standalone mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY
Apache-HBase commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY URL: https://github.com/apache/hbase/pull/124#issuecomment-480987239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 46 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 301 | master passed | | +1 | compile | 67 | master passed | | +1 | checkstyle | 84 | master passed | | +1 | shadedjars | 331 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 179 | master passed | | +1 | javadoc | 41 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | -1 | checkstyle | 82 | hbase-server: The patch generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 329 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 637 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 204 | the patch passed | | +1 | javadoc | 41 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16953 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 19786 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.master.TestSplitWALManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-124/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/124 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 393a8209c498 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 89ce5d17e4 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-124/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-124/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-124/2/testReport/ | | Max. process+thread count | 4874 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-124/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[
https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812746#comment-16812746
]
HBase QA commented on HBASE-22155:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
5s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
31s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
52s{color} | {color:green} branch-2.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
26s{color} | {color:green} branch-2.2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
6m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}239m
25s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}281m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/32/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22155 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965206/HBASE-22155-branch-2.2.v004.patch
|
| Optional Tests |
[jira] [Commented] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail
[
https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812727#comment-16812727
]
HBase QA commented on HBASE-21751:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 5m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
23s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
31s{color} | {color:red} hbase-client: The patch generated 3 new + 0 unchanged
- 0 fixed = 3 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 2 new + 76 unchanged
- 0 fixed = 78 total (was 76) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
20s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}317m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}368m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestSplitWALManager |
| | hadoop.hbase.master.TestAssignmentManagerMetrics |
| |
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
|
| | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.master.procedure.TestProcedurePriority |
| | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles |
| |
[jira] [Commented] (HBASE-21937) Make the Compression#decompress can accept ByteBuff as input
[
https://issues.apache.org/jira/browse/HBASE-21937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812724#comment-16812724
]
HBase QA commented on HBASE-21937:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-21879 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
31s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
57s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} HBASE-21879 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
22s{color} | {color:red} hbase-common: The patch generated 1 new + 8 unchanged
- 1 fixed = 9 total (was 9) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} hbase-server: The patch generated 0 new + 26
unchanged - 1 fixed = 26 total (was 27) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
50s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}282m 33s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
1s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}330m 46s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.quotas.TestSpaceQuotas |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | hadoop.hbase.master.procedure.TestSCPWithReplicas |
| | hadoop.hbase.master.TestRestartCluster |
| | hadoop.hbase.TestSplitMerge |
| | hadoop.hbase.master.TestSplitWALManager |
| |
[jira] [Commented] (HBASE-21818) Incorrect list item in javadoc
[
https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812719#comment-16812719
]
Hudson commented on HBASE-21818:
Results for branch branch-1.4
[build #737 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/737/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/737//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/737//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/737//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Incorrect list item in javadoc
> --
>
> Key: HBASE-21818
> URL: https://issues.apache.org/jira/browse/HBASE-21818
> Project: HBase
> Issue Type: Improvement
> Components: documentation, master
>Affects Versions: 1.1.0
> Environment: has nothing to do with env
>Reporter: qiang Liu
>Assignee: qiang Liu
>Priority: Trivial
> Labels: easyfix, javadoc
> Fix For: 1.4.10, 1.3.4, 1.5.1
>
> Attachments: HBASE-21818.branch-1.001.patch,
> HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch,
> HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch,
> HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> the java doc of this function type a as ，so dispaly a blanck line
> {code:java}
> //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization
> {code}
> paste the function and it's doc here , please look the line "Ensure
> assignment of meta/namespace regions"
>
>
> {code:java}
> /**
> * Finish initialization of HMaster after becoming the primary master.
> *
> *
> * Initialize master components - file system manager, server manager,
> * assignment manager, region server tracker, etc
> * Start necessary service threads - balancer, catalog janior,
> * executor services, etc
> * Set cluster as UP in ZooKeeper
> * Wait for RegionServers to check-in
> * Split logs and perform data recovery, if necessary
> * Ensure assignment of meta/namespace regions
> * Handle either fresh cluster start or master failover
> *
> *
> * @throws IOException
> * @throws InterruptedException
> * @throws KeeperException
> * @throws CoordinatedStateException
> */
> private void finishActiveMasterInitialization(MonitoredTask status)
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22159) ByteBufferIOEngine should support write off-heap ByteBuff to the bufferArray
[
https://issues.apache.org/jira/browse/HBASE-22159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812712#comment-16812712
]
HBase QA commented on HBASE-22159:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
48s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-21879 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} HBASE-21879 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
24s{color} | {color:red} hbase-common: The patch generated 1 new + 23 unchanged
- 6 fixed = 24 total (was 29) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}363m 32s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}410m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
| | hadoop.hbase.io.hfile.bucket.TestBucketCache |
| | hadoop.hbase.client.TestAsyncTableAdminApi |
| | hadoop.hbase.master.TestAssignmentManagerMetrics |
| | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.namespace.TestNamespaceAuditor |
| | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs |
| |
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
[jira] [Commented] (HBASE-22144) MultiRowRangeFilter does not work with reversed scans
[
https://issues.apache.org/jira/browse/HBASE-22144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812710#comment-16812710
]
Josh Elser commented on HBASE-22144:
{quote}what are the target version(s) here?
{quote}
2.x and master, certainly. A quick glance at the 1.x line looked like it also
had the same defect.
> MultiRowRangeFilter does not work with reversed scans
> -
>
> Key: HBASE-22144
> URL: https://issues.apache.org/jira/browse/HBASE-22144
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Attachments: HBASE-22144.001.patch, HBASE-22144.002.patch,
> HBASE-22144.002.patch
>
>
> It appears that MultiRowRangeFilter was never written to function with
> reverse scans. There is too much logic that operates with the assumption that
> we are always moving "forward" through increasing ranges. It needs to be
> rewritten to "traverse" forward or backward, given how the context of the
> scan being used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22143) HBCK2 setRegionState command
[
https://issues.apache.org/jira/browse/HBASE-22143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812706#comment-16812706
]
stack commented on HBASE-22143:
---
Dealing with these in the past, IIRC, I'd file an assign for each region stuck
in OPENING. For assigns, expected states can be
{code}
State.OPEN, // State may already be OPEN if we died after receiving the OPEN
from regionserver
// but before complete finish of AssignProcedure. HBASE-20100.
State.OFFLINE, State.CLOSED, // disable/offline
State.SPLITTING, State.SPLIT, // ServerCrashProcedure
State.OPENING, State.FAILED_OPEN, // already in-progress (retrying)
{code}
After assign completed, I'd then file the unassign.
Thats what this paragraph in the 'fixing' section on the hbck2 page was trying
to say:
"Also, if a table is DISABLED, you cannot assign a Region. In the Master logs,
you will see that the Master will report that the assign has been skipped
because the table is DISABLED. You may want to assign a Region because it is
currently in the OPENING state and you want it in the CLOSED state so it agrees
with the table's DISABLED state. In this situation, you may have to temporarily
set the table status to ENABLED, just so you can do the assign, and then set it
back again after the unassign."
https://github.com/apache/hbase-operator-tools/tree/master/hbase-hbck2
That said, this facility looks like a nice addition. Was it useful in a
particular predicament [~wchevreuil]? IIRC, locks were a problem. There might
not be an AP anymore but the lock might be in place. Would have to break those
before being able to do anything.
> HBCK2 setRegionState command
>
>
> Key: HBASE-22143
> URL: https://issues.apache.org/jira/browse/HBASE-22143
> Project: HBase
> Issue Type: New Feature
> Components: hbase-operator-tools, hbck2
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: hbck2-1.0.0
>
> Attachments: HBASE-22143.master.0001.patch,
> HBASE-22143.master.0002.patch, HBASE-22143.master.0003.patch
>
>
> Among some of the current AMv2 issues, we faced situation where some regions
> had state as OPENING in meta, with an RS startcode that was not valid
> anymore. There was no AP running, the region stays permanently being logged
> as IN-Transition on master logs, yet no procedure is really trying to bring
> it online. Current hbck2 unassigns/assigns commands didn't work either, as
> per the exception shown, it expects regions to be in state SPLITTING, SPLIT,
> MERGING, OPEN, or CLOSING:
> {noformat}
> WARN org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure:
> Failed transition, suspend 1secs pid=7093,
> state=RUNNABLE:REGION_TRANSITION_DISPATCH, locked=true; UnassignProcedure
> table=rc_accounts, region=db85127b77fa56f7ad44e2c988e53925,
> server=server1.example.com,16020,1552682193324; rit=OPENING,
> location=server1.example.com,16020,1552682193324; waiting on rectified
> condition fixed by other Procedure or operator intervention
> org.apache.hadoop.hbase.exceptions.UnexpectedStateException: Expected
> [SPLITTING, SPLIT, MERGING, OPEN, CLOSING] so could move to CLOSING but
> current state=OPENING
> at
> org.apache.hadoop.hbase.master.assignment.RegionStates$RegionStateNode.transitionState(RegionStates.java:166)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.markRegionAsClosing(AssignmentManager.java:1479)
> at
> org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:212)
> at
> org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:369)
> at
> org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:97)
> at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:957)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1835)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1595){noformat}
> In this specific case, since we know the region is not actually being
> operated by any proc and is not really open anywhere, it's ok to manually set
> it's state to one of those assigns/unassigns can operate on, so this jira
> proposes a new hbck2 command that allows for arbitrarily set a region to a
> given state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail
[
https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812692#comment-16812692
]
HBase QA commented on HBASE-21751:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
44s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
32s{color} | {color:red} hbase-client: The patch generated 3 new + 0 unchanged
- 0 fixed = 3 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
14s{color} | {color:red} hbase-server: The patch generated 2 new + 76 unchanged
- 0 fixed = 78 total (was 76) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 14s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}352m 30s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
45s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}402m 36s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.procedure.TestSCP |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
| | hadoop.hbase.client.TestAsyncTableAdminApi |
| | hadoop.hbase.master.TestAssignmentManagerMetrics |
| | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.TestSplitMerge |
| | hadoop.hbase.namespace.TestNamespaceAuditor |
| | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| |
[GitHub] [hbase] Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480947128 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 5 | https://github.com/apache/hbase/pull/91 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/91 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-91/4/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22114) Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811695#comment-16811695 ] Andrew Purtell edited comment on HBASE-22114 at 4/8/19 6:19 PM: Thanks for looking into those issues [~busbey] . I’ve rescheduled this for a future 1.6.0 and hopefully by then it will fit in better with what precommit is able to do was (Author: apurtell): Thanks for looking into those issues [~busbey] . I’ve rescheduled this for a future 1.6.0 and hopefully by then > Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 > --- > > Key: HBASE-22114 > URL: https://issues.apache.org/jira/browse/HBASE-22114 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.6.0 > > Attachments: HBASE-22114-branch-1.patch, HBASE-22114-branch-1.patch, > HBASE-22114-branch-1.patch > > > HBASE-15560 introduces the TinyLFU cache policy for the blockcache. > W-TinyLFU ([research paper|http://arxiv.org/pdf/1512.00727.pdf]) records the > frequency in a counting sketch, ages periodically by halving the counters, > and orders entries by SLRU. An entry is discarded by comparing the frequency > of the new arrival (candidate) to the SLRU's victim, and keeping the one with > the highest frequency. This allows the operations to be performed in O(1) > time and, though the use of a compact sketch, a much larger history is > retained beyond the current working set. In a variety of real world traces > the policy had [near optimal hit > rates|https://github.com/ben-manes/caffeine/wiki/Efficiency]. > The implementation of HBASE-15560 uses several Java 8 idioms, depends on JRE > 8+ type Optional, and has dependencies on libraries compiled with Java 8+ > bytecode. It could be backported to branch-1 but must be made optional both > at compile time and runtime, enabled by the 'build-with-jdk8' build profile. > The TinyLFU policy must go into its own build module. > The blockcache must be modified to load L1 implementation/policy dynamically > at startup by reflection if the policy is "TinyLFU" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22114) Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22114: --- Status: Open (was: Patch Available) > Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 > --- > > Key: HBASE-22114 > URL: https://issues.apache.org/jira/browse/HBASE-22114 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.6.0 > > Attachments: HBASE-22114-branch-1.patch, HBASE-22114-branch-1.patch, > HBASE-22114-branch-1.patch > > > HBASE-15560 introduces the TinyLFU cache policy for the blockcache. > W-TinyLFU ([research paper|http://arxiv.org/pdf/1512.00727.pdf]) records the > frequency in a counting sketch, ages periodically by halving the counters, > and orders entries by SLRU. An entry is discarded by comparing the frequency > of the new arrival (candidate) to the SLRU's victim, and keeping the one with > the highest frequency. This allows the operations to be performed in O(1) > time and, though the use of a compact sketch, a much larger history is > retained beyond the current working set. In a variety of real world traces > the policy had [near optimal hit > rates|https://github.com/ben-manes/caffeine/wiki/Efficiency]. > The implementation of HBASE-15560 uses several Java 8 idioms, depends on JRE > 8+ type Optional, and has dependencies on libraries compiled with Java 8+ > bytecode. It could be backported to branch-1 but must be made optional both > at compile time and runtime, enabled by the 'build-with-jdk8' build profile. > The TinyLFU policy must go into its own build module. > The blockcache must be modified to load L1 implementation/policy dynamically > at startup by reflection if the policy is "TinyLFU" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22144) MultiRowRangeFilter does not work with reversed scans
[ https://issues.apache.org/jira/browse/HBASE-22144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812680#comment-16812680 ] Sean Busbey commented on HBASE-22144: - what are the target version(s) here? > MultiRowRangeFilter does not work with reversed scans > - > > Key: HBASE-22144 > URL: https://issues.apache.org/jira/browse/HBASE-22144 > Project: HBase > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Attachments: HBASE-22144.001.patch, HBASE-22144.002.patch, > HBASE-22144.002.patch > > > It appears that MultiRowRangeFilter was never written to function with > reverse scans. There is too much logic that operates with the assumption that > we are always moving "forward" through increasing ranges. It needs to be > rewritten to "traverse" forward or backward, given how the context of the > scan being used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
[ https://issues.apache.org/jira/browse/HBASE-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812666#comment-16812666 ] stack commented on HBASE-17564: --- This for master or branch-2? (hbase-2.2.0?) [~Jan Hentschel]? Thanks. > Fix remaining calls to deprecated methods of Admin and HBaseAdmin > - > > Key: HBASE-17564 > URL: https://issues.apache.org/jira/browse/HBASE-17564 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17564.master.001.patch > > > Fix the remaining calls to deprecated methods of the *Admin* interface and > the *HBaseAdmin* class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
[ https://issues.apache.org/jira/browse/HBASE-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-17564: -- Assignee: (was: Jan Hentschel) Status: Open (was: Patch Available) > Fix remaining calls to deprecated methods of Admin and HBaseAdmin > - > > Key: HBASE-17564 > URL: https://issues.apache.org/jira/browse/HBASE-17564 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17564.master.001.patch > > > Fix the remaining calls to deprecated methods of the *Admin* interface and > the *HBaseAdmin* class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22144) MultiRowRangeFilter does not work with reversed scans
[ https://issues.apache.org/jira/browse/HBASE-22144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-22144: --- Attachment: HBASE-22144.002.patch > MultiRowRangeFilter does not work with reversed scans > - > > Key: HBASE-22144 > URL: https://issues.apache.org/jira/browse/HBASE-22144 > Project: HBase > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Attachments: HBASE-22144.001.patch, HBASE-22144.002.patch, > HBASE-22144.002.patch > > > It appears that MultiRowRangeFilter was never written to function with > reverse scans. There is too much logic that operates with the assumption that > we are always moving "forward" through increasing ranges. It needs to be > rewritten to "traverse" forward or backward, given how the context of the > scan being used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22144) MultiRowRangeFilter does not work with reversed scans
[ https://issues.apache.org/jira/browse/HBASE-22144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812631#comment-16812631 ] Josh Elser commented on HBASE-22144: Reattaching to get another run. I don't think these failures are related. > MultiRowRangeFilter does not work with reversed scans > - > > Key: HBASE-22144 > URL: https://issues.apache.org/jira/browse/HBASE-22144 > Project: HBase > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Attachments: HBASE-22144.001.patch, HBASE-22144.002.patch, > HBASE-22144.002.patch > > > It appears that MultiRowRangeFilter was never written to function with > reverse scans. There is too much logic that operates with the assumption that > we are always moving "forward" through increasing ranges. It needs to be > rewritten to "traverse" forward or backward, given how the context of the > scan being used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
Apache-HBase commented on issue #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131#issuecomment-480916851 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 273 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for branch | | +1 | mvninstall | 254 | master passed | | +1 | compile | 32 | master passed | | +1 | checkstyle | 136 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hbase-checkstyle | | +1 | findbugs | 32 | master passed | | +1 | javadoc | 26 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 249 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 133 | root: The patch generated 0 new + 0 unchanged - 143 fixed = 0 total (was 143) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 518 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hbase-checkstyle | | +1 | findbugs | 40 | the patch passed | | +1 | javadoc | 26 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 12 | hbase-checkstyle in the patch passed. | | +1 | unit | 56 | hbase-http in the patch passed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 2506 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/131 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml shadedjars hadoopcheck compile findbugs hbaseanti | | uname | Linux 055b27d5ba5f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 89ce5d17e4 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/1/testReport/ | | Max. process+thread count | 281 (vs. ulimit of 1) | | modules | C: hbase-checkstyle hbase-http U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-131/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22183) [hbck2] Update hbck2 README to explain new "setRegionState" method.
[ https://issues.apache.org/jira/browse/HBASE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-22183: --- Attachment: (was: HBASE-22183-master-002.patch) > [hbck2] Update hbck2 README to explain new "setRegionState" method. > --- > > Key: HBASE-22183 > URL: https://issues.apache.org/jira/browse/HBASE-22183 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22183-master-001.patch > > > HBase-22143 introduced new *setRegionState* method that allows for manually > setting a region to an specific state, in meta. This was added a client side > logic for updating region state, to workout case where region is left in > OPENING state (unassigns/assigns will fail to progress here) on releases > prior to 2.1.2 (when scheduleServerCrashProcedure was added to Master's > HbckService). To reflect, this jira adds not only setRegionState description, > but also additional explanations on the Overview section of README.md file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21110) Issues with Unsafe and JDK 11
[
https://issues.apache.org/jira/browse/HBASE-21110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812589#comment-16812589
]
Sean Busbey commented on HBASE-21110:
-
I'd do it as a different JIRA so that this one can handle the actual
modularization and migration for moving off of Unsafe.
> Issues with Unsafe and JDK 11
> -
>
> Key: HBASE-21110
> URL: https://issues.apache.org/jira/browse/HBASE-21110
> Project: HBase
> Issue Type: Task
>Reporter: Mike Drob
>Priority: Major
> Labels: jdk11
> Fix For: 3.0.0
>
>
> Using Java 11 RC 1, I get the following warning, probably need to add the
> suggested flag to our scripts?
> {noformat}
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ java -version
> java version "11" 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ bin/start-hbase.sh
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ cat
> /Users/mdrob/IdeaProjects/hbase/bin/../logs/hbase-mdrob-master-mdrob-MBP.local.out
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/mdrob/IdeaProjects/hbase/hbase-common/target/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #128: HBASE-22188 Make TestSplitMerge more stable
Apache-HBase commented on issue #128: HBASE-22188 Make TestSplitMerge more stable URL: https://github.com/apache/hbase/pull/128#issuecomment-480903821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 270 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 315 | master passed | | +1 | compile | 69 | master passed | | +1 | checkstyle | 84 | master passed | | +1 | shadedjars | 323 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 190 | master passed | | +1 | javadoc | 42 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 67 | the patch passed | | +1 | javac | 67 | the patch passed | | +1 | checkstyle | 82 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 327 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 639 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 203 | the patch passed | | +1 | javadoc | 41 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18044 | hbase-server in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 21114 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.quotas.TestSpaceQuotas | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-128/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/128 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 549ca0221bd3 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / a871d3139a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-128/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-128/1/testReport/ | | Max. process+thread count | 5262 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-128/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet opened a new pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http
HorizonNet opened a new pull request #131: HBASE-19762 Fixed Checkstyle errors in hbase-http URL: https://github.com/apache/hbase/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22183) [hbck2] Update hbck2 README to explain new "setRegionState" method.
[ https://issues.apache.org/jira/browse/HBASE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812559#comment-16812559 ] stack commented on HBASE-22183: --- bq. You mean, dynamic generating MD content? My fault. Thought I was looking at java code. Ignore my comment. Is the patch right at 5MB in size? Thanks [~wchevreuil] > [hbck2] Update hbck2 README to explain new "setRegionState" method. > --- > > Key: HBASE-22183 > URL: https://issues.apache.org/jira/browse/HBASE-22183 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22183-master-001.patch, > HBASE-22183-master-002.patch > > > HBase-22143 introduced new *setRegionState* method that allows for manually > setting a region to an specific state, in meta. This was added a client side > logic for updating region state, to workout case where region is left in > OPENING state (unassigns/assigns will fail to progress here) on releases > prior to 2.1.2 (when scheduleServerCrashProcedure was added to Master's > HbckService). To reflect, this jira adds not only setRegionState description, > but also additional explanations on the Overview section of README.md file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22109) Update hbase shaded content checker after guava update in hadoop branch-3.0 to 27.0-jre
[ https://issues.apache.org/jira/browse/HBASE-22109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812527#comment-16812527 ] Sean Busbey commented on HBASE-22109: - [~gabor.bota] you still working on this? > Update hbase shaded content checker after guava update in hadoop branch-3.0 > to 27.0-jre > --- > > Key: HBASE-22109 > URL: https://issues.apache.org/jira/browse/HBASE-22109 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Gabor Bota >Assignee: Gabor Bota >Priority: Minor > Attachments: HBASE-22109.001.patch > > > I'm updating guava version from 11.0.2 to 27.0-jre in HADOOP-15960 because of > a CVE. I will create a patch for branch-3.0, 3.1, 3.2 and trunk (3.3). > I wanted to be sure that HBase works with the updated guava, I compiled and > run the HBase tests with my hadoop snapshot containing the updated version, > but there were some issues that I had to fix: > * New shaded dependency: org.checkerframework > * New license needs to be added to LICENSE.vm: Apache 2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) Incorrect list item in javadoc
[
https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812523#comment-16812523
]
Hudson commented on HBASE-21818:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #540 (See
[https://builds.apache.org/job/HBase-1.3-IT/540/])
HBASE-21818 Incorrect list item in javadoc (psomogyi:
[https://github.com/apache/hbase/commit/16e05306de55517ce64d6d7ac62728cdc832578a])
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
> Incorrect list item in javadoc
> --
>
> Key: HBASE-21818
> URL: https://issues.apache.org/jira/browse/HBASE-21818
> Project: HBase
> Issue Type: Improvement
> Components: documentation, master
>Affects Versions: 1.1.0
> Environment: has nothing to do with env
>Reporter: qiang Liu
>Assignee: qiang Liu
>Priority: Trivial
> Labels: easyfix, javadoc
> Fix For: 1.4.10, 1.3.4, 1.5.1
>
> Attachments: HBASE-21818.branch-1.001.patch,
> HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch,
> HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch,
> HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> the java doc of this function type a as ，so dispaly a blanck line
> {code:java}
> //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization
> {code}
> paste the function and it's doc here , please look the line "Ensure
> assignment of meta/namespace regions"
>
>
> {code:java}
> /**
> * Finish initialization of HMaster after becoming the primary master.
> *
> *
> * Initialize master components - file system manager, server manager,
> * assignment manager, region server tracker, etc
> * Start necessary service threads - balancer, catalog janior,
> * executor services, etc
> * Set cluster as UP in ZooKeeper
> * Wait for RegionServers to check-in
> * Split logs and perform data recovery, if necessary
> * Ensure assignment of meta/namespace regions
> * Handle either fresh cluster start or master failover
> *
> *
> * @throws IOException
> * @throws InterruptedException
> * @throws KeeperException
> * @throws CoordinatedStateException
> */
> private void finishActiveMasterInitialization(MonitoredTask status)
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet commented on issue #129: HBASE-22189 Removed remaining usage of StoreFile.getModificationTimeStamp
HorizonNet commented on issue #129: HBASE-22189 Removed remaining usage of StoreFile.getModificationTimeStamp URL: https://github.com/apache/hbase/pull/129#issuecomment-480885105 The failing test case seems to be unrelated to the actual change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812505#comment-16812505 ] stack commented on HBASE-22155: --- Test failed with java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; at org.apache.hadoop.hbase.shaded.protobuf.TestProtobufUtil.testToCell(TestProtobufUtil.java:274) ... which seems to say it picked up thirdparty lib compiled w/ jdk10? Passes locally and passed in the run before this https://builds.apache.org/job/PreCommit-HBASE-Build/10/testReport/org.apache.hadoop.hbase.shaded.protobuf/TestProtobufUtil/testToCell/ > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155.branch-2.2.001.patch, HBASE-22155.branch-2.2.002.patch, > HBASE-22155.branch-2.2.003.patch, HBASE-22155.branch-2.2.004.patch, > HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22114) Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812503#comment-16812503 ] Sean Busbey commented on HBASE-22114: - sounds good. I'm going to try to clean up branch-1 precommit as a part of HBASE-22020 and then run through my proposed precommit changes for this here. some of the structural issues look like they also come up on the current branch due to the hbase-error-prone module. > Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 > --- > > Key: HBASE-22114 > URL: https://issues.apache.org/jira/browse/HBASE-22114 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.6.0 > > Attachments: HBASE-22114-branch-1.patch, HBASE-22114-branch-1.patch, > HBASE-22114-branch-1.patch > > > HBASE-15560 introduces the TinyLFU cache policy for the blockcache. > W-TinyLFU ([research paper|http://arxiv.org/pdf/1512.00727.pdf]) records the > frequency in a counting sketch, ages periodically by halving the counters, > and orders entries by SLRU. An entry is discarded by comparing the frequency > of the new arrival (candidate) to the SLRU's victim, and keeping the one with > the highest frequency. This allows the operations to be performed in O(1) > time and, though the use of a compact sketch, a much larger history is > retained beyond the current working set. In a variety of real world traces > the policy had [near optimal hit > rates|https://github.com/ben-manes/caffeine/wiki/Efficiency]. > The implementation of HBASE-15560 uses several Java 8 idioms, depends on JRE > 8+ type Optional, and has dependencies on libraries compiled with Java 8+ > bytecode. It could be backported to branch-1 but must be made optional both > at compile time and runtime, enabled by the 'build-with-jdk8' build profile. > The TinyLFU policy must go into its own build module. > The blockcache must be modified to load L1 implementation/policy dynamically > at startup by reflection if the policy is "TinyLFU" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[
https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812501#comment-16812501
]
HBase QA commented on HBASE-21965:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
21s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
23s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}289m 48s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}349m 1s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.quotas.TestSpaceQuotas |
| | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
| | hadoop.hbase.master.procedure.TestSCPWithReplicas |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| |
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
|
| |
[GitHub] [hbase] Apache-HBase commented on issue #129: HBASE-22189 Removed remaining usage of StoreFile.getModificationTimeStamp
Apache-HBase commented on issue #129: HBASE-22189 Removed remaining usage of StoreFile.getModificationTimeStamp URL: https://github.com/apache/hbase/pull/129#issuecomment-480876944 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 27 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 302 | master passed | | +1 | javadoc | 34 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 253 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 30 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 8405 | hbase-server in the patch failed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 9141 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.locking.TestLockManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-129/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/129 | | Optional Tests | dupname asflicense javac javadoc unit | | uname | Linux 8fb385828517 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / a871d3139a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-129/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-129/1/testReport/ | | Max. process+thread count | 4793 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-129/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx opened a new pull request #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block
openinx opened a new pull request #130: HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block URL: https://github.com/apache/hbase/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22155) Move 2.2.0 on to hbase-thirdparty-2.2.0
[ https://issues.apache.org/jira/browse/HBASE-22155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22155: -- Attachment: HBASE-22155-branch-2.2.v004.patch > Move 2.2.0 on to hbase-thirdparty-2.2.0 > --- > > Key: HBASE-22155 > URL: https://issues.apache.org/jira/browse/HBASE-22155 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2-001.patch, > HBASE-22155-branch-2.2-001.patch, HBASE-22155-branch-2.2.004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155-branch-2.2.v004.patch, HBASE-22155-branch-2.2.v004.patch, > HBASE-22155.branch-2.2.001.patch, HBASE-22155.branch-2.2.002.patch, > HBASE-22155.branch-2.2.003.patch, HBASE-22155.branch-2.2.004.patch, > HBASE-22155.branch-2.2.005.patch > > > hbase-thirdparty-2.2.0 was just released. The 2.2.0 RM ([~zghaobac]) gave his > blessing in parent issue that 2.2.0 should use thirdparty 2.2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #126: HBASE-21718 Implement Admin based on AsyncAdmin
Apache-HBase commented on issue #126: HBASE-21718 Implement Admin based on AsyncAdmin URL: https://github.com/apache/hbase/pull/126#issuecomment-480869726 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 92 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 44 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | 0 | mvndep | 11 | Maven dependency ordering for branch | | +1 | mvninstall | 387 | HBASE-21512 passed | | +1 | compile | 200 | HBASE-21512 passed | | +1 | checkstyle | 202 | HBASE-21512 passed | | +1 | shadedjars | 343 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 472 | HBASE-21512 passed | | +1 | javadoc | 144 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 199 | the patch passed | | +1 | javac | 199 | the patch passed | | +1 | checkstyle | 40 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 97 | hbase-server: The patch generated 0 new + 412 unchanged - 4 fixed = 412 total (was 416) | | +1 | checkstyle | 21 | The patch passed checkstyle in hbase-mapreduce | | +1 | checkstyle | 35 | The patch passed checkstyle in hbase-thrift | | +1 | checkstyle | 17 | The patch passed checkstyle in hbase-backup | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 328 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 665 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 514 | the patch passed | | +1 | javadoc | 143 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 228 | hbase-client in the patch passed. | | -1 | unit | 15801 | hbase-server in the patch failed. | | +1 | unit | 1572 | hbase-mapreduce in the patch passed. | | +1 | unit | 355 | hbase-thrift in the patch passed. | | +1 | unit | 1110 | hbase-backup in the patch passed. | | +1 | asflicense | 152 | The patch does not generate ASF License warnings. | | | | 23621 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/126 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6c6a5e99dadf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / ee3774040f | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/testReport/ | | Max. process+thread count | 5784 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-126/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #122: HBASE-22163 Should not archive the compacted store files when region warmup
Apache-HBase commented on issue #122: HBASE-22163 Should not archive the compacted store files when region warmup URL: https://github.com/apache/hbase/pull/122#issuecomment-480860333 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 234 | master passed | | +1 | compile | 98 | master passed | | +1 | checkstyle | 107 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 224 | master passed | | +1 | javadoc | 66 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 236 | the patch passed | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | -1 | checkstyle | 77 | hbase-server: The patch generated 2 new + 568 unchanged - 0 fixed = 570 total (was 568) | | +1 | checkstyle | 18 | The patch passed checkstyle in hbase-mapreduce | | +1 | checkstyle | 14 | hbase-examples: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 472 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 242 | the patch passed | | +1 | javadoc | 68 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18502 | hbase-server in the patch failed. | | +1 | unit | 1391 | hbase-mapreduce in the patch passed. | | +1 | unit | 148 | hbase-examples in the patch passed. | | +1 | asflicense | 78 | The patch does not generate ASF License warnings. | | | | 22785 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.master.TestSplitWALManager | | | hadoop.hbase.master.locking.TestLockManager | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.tool.TestLoadIncrementalHFiles | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-122/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/122 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d632bf1facce 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / a871d3139a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-122/4/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-122/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-122/4/testReport/ | | Max. process+thread count | 4926 (vs. ulimit of 1) | | modules | C: hbase-server hbase-mapreduce hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-122/4/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically
[jira] [Updated] (HBASE-22163) Should not archive the compacted store files when region warmup
[
https://issues.apache.org/jira/browse/HBASE-22163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-22163:
---
Resolution: Fixed
Fix Version/s: 2.3.0
2.2.0
3.0.0
Status: Resolved (was: Patch Available)
Pushed to branch-2.2+. Thanks [~Apache9] for reviewing.
> Should not archive the compacted store files when region warmup
> ---
>
> Key: HBASE-22163
> URL: https://issues.apache.org/jira/browse/HBASE-22163
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.3.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22163.master.001.patch,
> HBASE-22163.master.002.patch, HBASE-22163.master.002.patch
>
>
> Found this problem when run ITBLL for branch-2.2.
> The master log shows that it try to move a splited parent region.
> {code:java}
> 2019-04-03,12:56:13,635 INFO
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=2823,
> state=SUCCESS; SplitTableRegionProcedure table=IntegrationTestBigLinkedList,
> parent=a777f8fab6d17d37aaec842ba6035ad5,
> daughterA=634feb79a583480597e1843647d11228,
> daughterB=e370e6013ad35b83471671f2374278ab in 2.5930sec
> 2019-04-03,12:56:23,344 INFO org.apache.hadoop.hbase.master.HMaster:
> Client=hdfs_tst_admin//10.142.58.8 move hri=a777f8fab6d17d37aaec842ba6035ad5,
> source=, destination=c4-hadoop-tst-st30.bj,29100,1554265874772, running
> balancer
> {code}
> And the regionserver will try to open the stores of this region. After
> HBASE-20724, the compated store file will be archived when open the stroes.
> But there are still have reference for these file in daughter regions' store
> dir. Then the daughter region will can't open because file not found.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22128) Move namespace region then master crashed make deadlock
[ https://issues.apache.org/jira/browse/HBASE-22128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22128: Component/s: amv2 > Move namespace region then master crashed make deadlock > --- > > Key: HBASE-22128 > URL: https://issues.apache.org/jira/browse/HBASE-22128 > Project: HBase > Issue Type: Bug > Components: amv2 >Affects Versions: 2.0.5, 2.1.4 >Reporter: Bing Xiao >Assignee: Bing Xiao >Priority: Critical > Fix For: 2.0.6, 2.1.5 > > Attachments: HBASE-22128-branch-2.1-v1.patch, > HBASE-22128-branch-2.1-v2.patch, HBASE-22128-branch-2.1-v3.patch, > HBASE-22128-branch-2.1-v4.patch, HBASE-22128-branch-2.1-v5.patch > > > When move namespace region start unassign produre, after unassign procedure > finished namespace region will be offline. At the same time master crashed > then reboot will stuck, because master init is block by waiting namespace > table online ,at same time master init not finish so move region procedure > can not go on, make deadlock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812468#comment-16812468
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #54 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/54/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/54//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/54//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/54//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812460#comment-16812460
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #169 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/169/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/169//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/169//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/169//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] infraio merged pull request #122: HBASE-22163 Should not archive the compacted store files when region warmup
infraio merged pull request #122: HBASE-22163 Should not archive the compacted store files when region warmup URL: https://github.com/apache/hbase/pull/122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #125: HBASE-22187 Removed remaining usages of ClusterConnection.clearRegionCache
Apache-HBase commented on issue #125: HBASE-22187 Removed remaining usages of ClusterConnection.clearRegionCache URL: https://github.com/apache/hbase/pull/125#issuecomment-480846019 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for branch | | +1 | mvninstall | 289 | master passed | | +1 | compile | 98 | master passed | | +1 | checkstyle | 126 | master passed | | +1 | shadedjars | 332 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 264 | master passed | | +1 | javadoc | 77 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 302 | the patch passed | | +1 | compile | 99 | the patch passed | | +1 | javac | 99 | the patch passed | | +1 | checkstyle | 124 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 330 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 634 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 286 | the patch passed | | +1 | javadoc | 68 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 222 | hbase-client in the patch passed. | | -1 | unit | 17448 | hbase-server in the patch failed. | | +1 | asflicense | 62 | The patch does not generate ASF License warnings. | | | | 20936 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.TestSplitWALManager | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-125/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/125 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 900b4f6f929d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / a871d3139a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-125/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-125/1/testReport/ | | Max. process+thread count | 5061 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-125/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY
HorizonNet commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY URL: https://github.com/apache/hbase/pull/124#issuecomment-480844977 @Apache9 I think it should be for 3.0 only. I updated the PR accordingly. Should I do the same to HBASE-17666? In my opinion both are related to each other. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22190) TestSnapshotFromMaster is flakey
Duo Zhang created HBASE-22190: - Summary: TestSnapshotFromMaster is flakey Key: HBASE-22190 URL: https://issues.apache.org/jira/browse/HBASE-22190 Project: HBase Issue Type: Task Reporter: Duo Zhang And it seems that it is not only a test issue, we do delete the files under the archive directory, which is incorrect. Need to find out why, this maybe a serious bug. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] openinx commented on issue #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input
openinx commented on issue #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input URL: https://github.com/apache/hbase/pull/127#issuecomment-480843072 @Apache9 Yes, it's related. will update the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY
Apache9 commented on issue #124: HBASE-22186 Removed remaining usages of SnapshotDescriptionUtils.SNAPSHOT_TIMEOUT_MILLIS_KEY URL: https://github.com/apache/hbase/pull/124#issuecomment-480834762 This is for 3.0 only? Then we'd better also remove the deprecated fields? Not only the references? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
