[jira] [Commented] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[
https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817573#comment-16817573
]
HBase QA commented on HBASE-21408:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
2s{color} | {color:red} The patch generated 2 new + 57 unchanged - 0 fixed = 59
total (was 57) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/83/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-21408 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965904/HBASE-21408.002.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux ca3f471d2fd1 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / cb84b2788a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| shellcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/83/artifact/patchprocess/diff-patch-shellcheck.txt
|
| Max. process+thread count | 41 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/83/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Add hbase.wal.dir clean operation also to hbase cleanup script.
> ---
>
> Key: HBASE-21408
> URL: https://issues.apache.org/jira/browse/HBASE-21408
> Project: HBase
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 2.1.0
>Reporter: Y. SREENIVASULU REDDY
>Priority: Major
> Attachments: HBASE-21408.001.patch, HBASE-21408.002.patch
>
>
> If user configured hbase.wal.dir explicitly.
> cleaning scripts should handle this too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22208) Create access checker and expose it in RS
[ https://issues.apache.org/jira/browse/HBASE-22208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817572#comment-16817572 ] Guanghao Zhang commented on HBASE-22208: And why need to stop AccessController when it is NoopAccessController? > Create access checker and expose it in RS > - > > Key: HBASE-22208 > URL: https://issues.apache.org/jira/browse/HBASE-22208 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Attachments: HBASE-22208.master.001.patch, > HBASE-22208.master.002.patch, HBASE-22208.master.003.patch, > HBASE-22208.master.004.patch, HBASE-22208.master.005.patch > > > In HBase access control service, access checker performs authorization checks > for a given user's assigned permissions. The access checker holds a auth > manager instance which cache all global, namespace and table permissions. > A access checker is created when master, RS and region load AccessController, > permission cache is refreshed when acl znode changed. > We can create access checker when master and RS start and expose it in order > to use procedure to refresh its cache rather than watch ZK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Y. SREENIVASULU REDDY updated HBASE-21408: -- Comment: was deleted (was: [~an...@apache.org]) > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch, HBASE-21408.002.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817569#comment-16817569 ] Y. SREENIVASULU REDDY commented on HBASE-21408: --- [~an...@apache.org] I have attached the patch. please review and provide your comments. > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch, HBASE-21408.002.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817568#comment-16817568 ] Y. SREENIVASULU REDDY commented on HBASE-21408: --- [~an...@apache.org] > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch, HBASE-21408.002.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Y. SREENIVASULU REDDY updated HBASE-21408: -- Attachment: HBASE-21408.002.patch > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch, HBASE-21408.002.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814072#comment-16814072 ] Y. SREENIVASULU REDDY edited comment on HBASE-21408 at 4/15/19 5:30 AM: Thanks for the review and comment [~an...@apache.org] I will address your comments. was (Author: sreenivasulureddy): Thanks for the review and comment [~an...@apache.org] I will address you comments. > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22149) HBOSS: A FileSystem implementation to provide HBase's required semantics
[
https://issues.apache.org/jira/browse/HBASE-22149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817543#comment-16817543
]
Steve Loughran commented on HBASE-22149:
bq. LimitedPrivate({"HBase"}),
Prefer @VisibleForTesting. I really hate the limited private stuff
> HBOSS: A FileSystem implementation to provide HBase's required semantics
>
>
> Key: HBASE-22149
> URL: https://issues.apache.org/jira/browse/HBASE-22149
> Project: HBase
> Issue Type: New Feature
> Components: Filesystem Integration
>Reporter: Sean Mackrory
>Assignee: Sean Mackrory
>Priority: Critical
> Attachments: HBASE-22149-hadoop.patch, HBASE-22149-hbase-2.patch,
> HBASE-22149-hbase-3.patch, HBASE-22149-hbase.patch
>
>
> (Have been using the name HBOSS for HBase / Object Store Semantics)
> I've had some thoughts about how to solve the problem of running HBase on
> object stores. There has been some thought in the past about adding the
> required semantics to S3Guard, but I have some concerns about that. First,
> it's mixing complicated solutions to different problems (bridging the gap
> between a flat namespace and a hierarchical namespace vs. solving
> inconsistency). Second, it's S3-specific, whereas other objects stores could
> use virtually identical solutions. And third, we can't do things like atomic
> renames in a true sense. There would have to be some trade-offs specific to
> HBase's needs and it's better if we can solve that in an HBase-specific
> module without mixing all that logic in with the rest of S3A.
> Ideas to solve this above the FileSystem layer have been proposed and
> considered (HBASE-20431, for one), and maybe that's the right way forward
> long-term, but it certainly seems to be a hard problem and hasn't been done
> yet. But I don't know enough of all the internal considerations to make much
> of a judgment on that myself.
> I propose a FileSystem implementation that wraps another FileSystem instance
> and provides locking of FileSystem operations to ensure correct semantics.
> Locking could quite possibly be done on the same ZooKeeper ensemble as an
> HBase cluster already uses (I'm sure there are some performance
> considerations here that deserve more attention). I've put together a
> proof-of-concept on which I've tested some aspects of atomic renames and
> atomic file creates. Both of these tests fail reliably on a naked s3a
> instance. I've also done a small YCSB run against a small cluster to sanity
> check other functionality and was successful. I will post the patch, and my
> laundry list of things that still need work. The WAL is still placed on HDFS,
> but the HBase root directory is otherwise on S3.
> Note that my prototype is built on Hadoop's source tree right now. That's
> purely for my convenience in putting it together quickly, as that's where I
> mostly work. I actually think long-term, if this is accepted as a good
> solution, it makes sense to live in HBase (or it's own repository). It only
> depends on stable, public APIs in Hadoop and is targeted entirely at HBase's
> needs, so it should be able to iterate on the HBase community's terms alone.
> Another idea [~ste...@apache.org] proposed to me is that of an inode-based
> FileSystem that keeps hierarchical metadata in a more appropriate store that
> would allow the required transactions (maybe a special table in HBase could
> provide that store itself for other tables), and stores the underlying files
> with unique identifiers on S3. This allows renames to actually become fast
> instead of just large atomic operations. It does however place a strong
> dependency on the metadata store. I have not explored this idea much. My
> current proof-of-concept has been pleasantly simple, so I think it's the
> right solution unless it proves unable to provide the required performance
> characteristics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22240) [backport] HBASE-19762 Fix Checkstyle errors in hbase-http
[ https://issues.apache.org/jira/browse/HBASE-22240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817534#comment-16817534 ] Wei-Chiu Chuang commented on HBASE-22240: - Except a few dangling Javadoc for Apache license, the patch is essentially the same as HBASE-19762. Why is it necessary to change the checkstyle supression file? > [backport] HBASE-19762 Fix Checkstyle errors in hbase-http > -- > > Key: HBASE-22240 > URL: https://issues.apache.org/jira/browse/HBASE-22240 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.1 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Attachments: HBASE-22240.branch-2.001.patch > > > I tried to apply HBASE-21048 to branch-2 which is based on master branch with > HBASE-19762 applied. Therefore, there were lot of conflicts. > I will back-port HBASE-19762 to branch-2, then push HBASE-21048 to branch-2 > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22208) Create access checker and expose it in RS
[ https://issues.apache.org/jira/browse/HBASE-22208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei updated HBASE-22208: --- Attachment: HBASE-22208.master.005.patch > Create access checker and expose it in RS > - > > Key: HBASE-22208 > URL: https://issues.apache.org/jira/browse/HBASE-22208 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Attachments: HBASE-22208.master.001.patch, > HBASE-22208.master.002.patch, HBASE-22208.master.003.patch, > HBASE-22208.master.004.patch, HBASE-22208.master.005.patch > > > In HBase access control service, access checker performs authorization checks > for a given user's assigned permissions. The access checker holds a auth > manager instance which cache all global, namespace and table permissions. > A access checker is created when master, RS and region load AccessController, > permission cache is refreshed when acl znode changed. > We can create access checker when master and RS start and expose it in order > to use procedure to refresh its cache rather than watch ZK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22240) [backport] HBASE-19762 Fix Checkstyle errors in hbase-http
[
https://issues.apache.org/jira/browse/HBASE-22240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817526#comment-16817526
]
HBase QA commented on HBASE-22240:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
5s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
31s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
12s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-checkstyle {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
27s{color} | {color:green} root: The patch generated 0 new + 0 unchanged - 143
fixed = 0 total (was 143) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-checkstyle {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
8s{color} | {color:green} hbase-checkstyle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/81/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22240 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817519#comment-16817519
]
Hudson commented on HBASE-22020:
Results for branch HBASE-22020
[build #12 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/12/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/12//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/12//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/12//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[
https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817513#comment-16817513
]
Hudson commented on HBASE-21492:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #542 (See
[https://builds.apache.org/job/HBase-1.3-IT/542/])
HBASE-21492 CellCodec Written To WAL Before It's Verified (toffer:
[https://github.com/apache/hbase/commit/ef58d789921283022d05371bb68a9d2950f6857f])
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestCustomWALCellCodec.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
> CellCodec Written To WAL Before It's Verified
> -
>
> Key: HBASE-21492
> URL: https://issues.apache.org/jira/browse/HBASE-21492
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.2.7, 2.0.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Critical
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10, 1.3.4
>
> Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch,
> HBASE-21492.2.patch, HBASE-21492.2.patch
>
>
> The cell codec class name is written into the WAL file, but the cell codec
> class is not actually verified to exist. Therefore, users can inadvertently
> configure an invalid class name and it will be recorded into the WAL file.
> At that point, the WAL file becomes unreadable and blocks processing of all
> other WAL files.
> {code:java|title=AbstractProtobufLogWriter.java}
> private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder
> builder) {
> if (!builder.hasWriterClsName()) {
> builder.setWriterClsName(getWriterClassName());
> }
> if (!builder.hasCellCodecClsName()) {
> builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf));
> }
> return builder.build();
> }
> {code}
> https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22240) [backport] HBASE-19762 Fix Checkstyle errors in hbase-http
[ https://issues.apache.org/jira/browse/HBASE-22240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22240: -- Status: Patch Available (was: Open) > [backport] HBASE-19762 Fix Checkstyle errors in hbase-http > -- > > Key: HBASE-22240 > URL: https://issues.apache.org/jira/browse/HBASE-22240 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.1 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Attachments: HBASE-22240.branch-2.001.patch > > > I tried to apply HBASE-21048 to branch-2 which is based on master branch with > HBASE-19762 applied. Therefore, there were lot of conflicts. > I will back-port HBASE-19762 to branch-2, then push HBASE-21048 to branch-2 > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21903) Backport major compaction tool HBASE-19528 from to 1.4 and 1.3
[ https://issues.apache.org/jira/browse/HBASE-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Liu updated HBASE-21903: Fix Version/s: (was: 1.3.4) 1.3.5 > Backport major compaction tool HBASE-19528 from to 1.4 and 1.3 > -- > > Key: HBASE-21903 > URL: https://issues.apache.org/jira/browse/HBASE-21903 > Project: HBase > Issue Type: Task > Components: Client, Compaction, tooling >Affects Versions: 1.3.3, 1.4.9 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Fix For: 1.4.10, 1.3.5 > > Attachments: HBASE-21903-branch-1.3-addendum.patch > > > Our internal deployments are based on branch-1.3. We will be using the major > compaction tool HBASE-19528 from [~churromorales] and the enhancements on top > of it HBASE-21883 on our 1.3 clusters. I would like to backport HBASE-19528 > to 1.3 and hence 1.4 as well. Since its a standalone tool without any other > dependency or code changes, I believe that should be ok. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22225) Profiler tab on Master/RS UI not working w/o comprehensive message
[
https://issues.apache.org/jira/browse/HBASE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Liu updated HBASE-5:
Fix Version/s: (was: 1.3.4)
1.3.5
> Profiler tab on Master/RS UI not working w/o comprehensive message
> --
>
> Key: HBASE-5
> URL: https://issues.apache.org/jira/browse/HBASE-5
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Affects Versions: 1.5.0
>Reporter: Yu Li
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.3.0, 1.2.12, 2.1.5, 1.3.5
>
>
> As titled, when checking 1.5.0 RC3 binary package, clicking the "Profiler"
> tab on HMaster/RegionServer web UI, it complains page not found error like
> below:
> {noformat}
> Problem accessing /prof. Reason:
> NOT_FOUND
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work
[
https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Liu updated HBASE-20993:
Fix Version/s: (was: 1.3.4)
1.3.5
> [Auth] IPC client fallback to simple auth allowed doesn't work
> --
>
> Key: HBASE-20993
> URL: https://issues.apache.org/jira/browse/HBASE-20993
> Project: HBase
> Issue Type: Bug
> Components: Client, IPC/RPC, security
>Affects Versions: 1.2.6, 1.3.2, 1.2.7, 1.4.7
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 1.5.0, 1.4.10, 1.3.5
>
> Attachments: HBASE-20993.001.patch,
> HBASE-20993.003.branch-1.flowchart.png, HBASE-20993.branch-1.002.patch,
> HBASE-20993.branch-1.003.patch, HBASE-20993.branch-1.004.patch,
> HBASE-20993.branch-1.005.patch, HBASE-20993.branch-1.006.patch,
> HBASE-20993.branch-1.007.patch, HBASE-20993.branch-1.008.patch,
> HBASE-20993.branch-1.009.patch, HBASE-20993.branch-1.009.patch,
> HBASE-20993.branch-1.010.patch, HBASE-20993.branch-1.011.patch,
> HBASE-20993.branch-1.012.patch, HBASE-20993.branch-1.2.001.patch,
> HBASE-20993.branch-1.wip.002.patch, HBASE-20993.branch-1.wip.patch,
> yetus-local-testpatch-output-009.txt
>
>
> It is easily reproducible.
> client's hbase-site.xml: hadoop.security.authentication:kerberos,
> hbase.security.authentication:kerberos,
> hbase.ipc.client.fallback-to-simple-auth-allowed:true, keytab and principal
> are right set
> A simple auth hbase cluster, a kerberized hbase client application.
> application trying to r/w/c/d table will have following exception:
> {code}
> javax.security.sasl.SaslException: GSS initiate failed [Caused by
> GSSException: No valid credentials provided (Mechanism level: Failed to find
> any Kerberos tgt)]
> at
> com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:211)
> at
> org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:179)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:617)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$700(RpcClientImpl.java:162)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:743)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:740)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1628)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:740)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:906)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:873)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1241)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:227)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:336)
> at
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.isMasterRunning(MasterProtos.java:58383)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.isMasterRunning(ConnectionManager.java:1592)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1530)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1552)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1581)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1738)
> at
> org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:134)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsyncV2(HBaseAdmin.java:753)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:674)
> at
>
[jira] [Updated] (HBASE-16488) Starting namespace and quota services in master startup asynchronously
[ https://issues.apache.org/jira/browse/HBASE-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Liu updated HBASE-16488: Fix Version/s: (was: 1.3.4) 1.3.5 > Starting namespace and quota services in master startup asynchronously > -- > > Key: HBASE-16488 > URL: https://issues.apache.org/jira/browse/HBASE-16488 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 1.3.0, 1.0.3, 1.4.0, 1.1.5, 1.2.2, 2.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Xu Cang >Priority: Major > Fix For: 1.5.0, 1.4.10, 1.3.5 > > Attachments: HBASE-16488.branch-1.012.patch, > HBASE-16488.branch-1.012.patch, HBASE-16488.revisit.v11-branch-1.patch, > HBASE-16488.v1-branch-1.patch, HBASE-16488.v1-master.patch, > HBASE-16488.v10-branch-1.patch, HBASE-16488.v2-branch-1.patch, > HBASE-16488.v2-branch-1.patch, HBASE-16488.v3-branch-1.patch, > HBASE-16488.v3-branch-1.patch, HBASE-16488.v4-branch-1.patch, > HBASE-16488.v5-branch-1.patch, HBASE-16488.v6-branch-1.patch, > HBASE-16488.v7-branch-1.patch, HBASE-16488.v8-branch-1.patch, > HBASE-16488.v9-branch-1.patch > > > From time to time, during internal IT test and from customer, we often see > master initialization failed due to namespace table region takes long time to > assign (eg. sometimes split log takes long time or hanging; or sometimes RS > is temporarily not available; sometimes due to some unknown assignment > issue). In the past, there was some proposal to improve this situation, eg. > HBASE-13556 / HBASE-14190 (Assign system tables ahead of user region > assignment) or HBASE-13557 (Special WAL handling for system tables) or > HBASE-14623 (Implement dedicated WAL for system tables). > This JIRA proposes another way to solve this master initialization fail > issue: namespace service is only used by a handful operations (eg. create > table / namespace DDL / get namespace API / some RS group DDL). Only quota > manager depends on it and quota management is off by default. Therefore, > namespace service is not really needed for master to be functional. So we > could start namespace service asynchronizely without blocking master startup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[
https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817482#comment-16817482
]
Francis Liu commented on HBASE-21492:
-
Cherry-picked to branch-1.3. Looks like it's missing.
> CellCodec Written To WAL Before It's Verified
> -
>
> Key: HBASE-21492
> URL: https://issues.apache.org/jira/browse/HBASE-21492
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.2.7, 2.0.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Critical
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10, 1.3.4
>
> Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch,
> HBASE-21492.2.patch, HBASE-21492.2.patch
>
>
> The cell codec class name is written into the WAL file, but the cell codec
> class is not actually verified to exist. Therefore, users can inadvertently
> configure an invalid class name and it will be recorded into the WAL file.
> At that point, the WAL file becomes unreadable and blocks processing of all
> other WAL files.
> {code:java|title=AbstractProtobufLogWriter.java}
> private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder
> builder) {
> if (!builder.hasWriterClsName()) {
> builder.setWriterClsName(getWriterClassName());
> }
> if (!builder.hasCellCodecClsName()) {
> builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf));
> }
> return builder.build();
> }
> {code}
> https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21492) CellCodec Written To WAL Before It's Verified
[
https://issues.apache.org/jira/browse/HBASE-21492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Liu updated HBASE-21492:
Fix Version/s: 1.3.4
> CellCodec Written To WAL Before It's Verified
> -
>
> Key: HBASE-21492
> URL: https://issues.apache.org/jira/browse/HBASE-21492
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.2.7, 2.0.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Critical
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.2, 1.2.10, 2.0.4, 1.4.10, 1.3.4
>
> Attachments: HBASE-21492-branch-1.patch, HBASE-21492.1.patch,
> HBASE-21492.2.patch, HBASE-21492.2.patch
>
>
> The cell codec class name is written into the WAL file, but the cell codec
> class is not actually verified to exist. Therefore, users can inadvertently
> configure an invalid class name and it will be recorded into the WAL file.
> At that point, the WAL file becomes unreadable and blocks processing of all
> other WAL files.
> {code:java|title=AbstractProtobufLogWriter.java}
> private WALHeader buildWALHeader0(Configuration conf, WALHeader.Builder
> builder) {
> if (!builder.hasWriterClsName()) {
> builder.setWriterClsName(getWriterClassName());
> }
> if (!builder.hasCellCodecClsName()) {
> builder.setCellCodecClsName(WALCellCodec.getWALCellCodecClass(conf));
> }
> return builder.build();
> }
> {code}
> https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractProtobufLogWriter.java#L78-L86
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21257) misspelled words.[occured -> occurred]
[
https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817481#comment-16817481
]
Hudson commented on HBASE-21257:
Results for branch branch-2.2
[build #186 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> misspelled words.[occured -> occurred]
> --
>
> Key: HBASE-21257
> URL: https://issues.apache.org/jira/browse/HBASE-21257
> Project: HBase
> Issue Type: Improvement
>Reporter: zhanggangxue
>Assignee: zhanggangxue
>Priority: Trivial
> Labels: occured, occurred, typo
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
> Attachments: 0001-misspelled-words.-occured-occurred.patch,
> HBASE-21257.master.0001.patch
>
>
> I found some spelling errors on the master Branch.Found in [misspelled
> words|https://github.com/apache/hbase/pull/91]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22207) Fix flakey TestAssignmentManager.testAssignSocketTimeout
[
https://issues.apache.org/jira/browse/HBASE-22207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817480#comment-16817480
]
Hudson commented on HBASE-22207:
Results for branch branch-2.2
[build #186 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/186//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix flakey TestAssignmentManager.testAssignSocketTimeout
>
>
> Key: HBASE-22207
> URL: https://issues.apache.org/jira/browse/HBASE-22207
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
> The problem is that we may kill the RS which holds meta so the assertion of
> the number of procedures maybe incorrect, as we may schedule another TRSP for
> assigning meta...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22207) Fix flakey TestAssignmentManager.testAssignSocketTimeout
[
https://issues.apache.org/jira/browse/HBASE-22207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817468#comment-16817468
]
Hudson commented on HBASE-22207:
Results for branch branch-2
[build #1820 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix flakey TestAssignmentManager.testAssignSocketTimeout
>
>
> Key: HBASE-22207
> URL: https://issues.apache.org/jira/browse/HBASE-22207
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
> The problem is that we may kill the RS which holds meta so the assertion of
> the number of procedures maybe incorrect, as we may schedule another TRSP for
> assigning meta...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
[
https://issues.apache.org/jira/browse/HBASE-22234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817467#comment-16817467
]
Hudson commented on HBASE-22234:
Results for branch master
[build #933 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/933/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
> ---
>
> Key: HBASE-22234
> URL: https://issues.apache.org/jira/browse/HBASE-22234
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21257) misspelled words.[occured -> occurred]
[
https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817469#comment-16817469
]
Hudson commented on HBASE-21257:
Results for branch branch-2
[build #1820 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1820//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> misspelled words.[occured -> occurred]
> --
>
> Key: HBASE-21257
> URL: https://issues.apache.org/jira/browse/HBASE-21257
> Project: HBase
> Issue Type: Improvement
>Reporter: zhanggangxue
>Assignee: zhanggangxue
>Priority: Trivial
> Labels: occured, occurred, typo
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
> Attachments: 0001-misspelled-words.-occured-occurred.patch,
> HBASE-21257.master.0001.patch
>
>
> I found some spelling errors on the master Branch.Found in [misspelled
> words|https://github.com/apache/hbase/pull/91]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22236) TestAsyncTableGetMultiThreaded sometimes timed out
[
https://issues.apache.org/jira/browse/HBASE-22236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817465#comment-16817465
]
Hudson commented on HBASE-22236:
Results for branch master
[build #933 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/933/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestAsyncTableGetMultiThreaded sometimes timed out
> --
>
> Key: HBASE-22236
> URL: https://issues.apache.org/jira/browse/HBASE-22236
> Project: HBase
> Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22236.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2992/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt/*view*/
> After this line
> {noformat}
> 2019-04-14 04:44:41,736 INFO [PEWorker-12]
> procedure2.ProcedureExecutor(1410): Finished pid=117, state=SUCCESS,
> hasLock=false; TransitRegionStateProcedure table=hbase:meta,
> region=1588230740, REOPEN/MOVE in 2.0690sec
> {noformat}
> Seems we just do nothing until the test is timed out.
> And there is no main thread in the output hanging thread, which is a bit
> strange, although all the get threads are hanging there.
> Let me add some logs for better debugging first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21257) misspelled words.[occured -> occurred]
[
https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817466#comment-16817466
]
Hudson commented on HBASE-21257:
Results for branch master
[build #933 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/933/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/933//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> misspelled words.[occured -> occurred]
> --
>
> Key: HBASE-21257
> URL: https://issues.apache.org/jira/browse/HBASE-21257
> Project: HBase
> Issue Type: Improvement
>Reporter: zhanggangxue
>Assignee: zhanggangxue
>Priority: Trivial
> Labels: occured, occurred, typo
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
> Attachments: 0001-misspelled-words.-occured-occurred.patch,
> HBASE-21257.master.0001.patch
>
>
> I found some spelling errors on the master Branch.Found in [misspelled
> words|https://github.com/apache/hbase/pull/91]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21257) misspelled words.[occured -> occurred]
[
https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817464#comment-16817464
]
Hudson commented on HBASE-21257:
Results for branch branch-2.1
[build #1053 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1053/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1053//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1053//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1053//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> misspelled words.[occured -> occurred]
> --
>
> Key: HBASE-21257
> URL: https://issues.apache.org/jira/browse/HBASE-21257
> Project: HBase
> Issue Type: Improvement
>Reporter: zhanggangxue
>Assignee: zhanggangxue
>Priority: Trivial
> Labels: occured, occurred, typo
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
> Attachments: 0001-misspelled-words.-occured-occurred.patch,
> HBASE-21257.master.0001.patch
>
>
> I found some spelling errors on the master Branch.Found in [misspelled
> words|https://github.com/apache/hbase/pull/91]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors
[
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-22235:
---
Fix Version/s: 2.3.0
1.5.0
3.0.0
> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Reporter: Lars Hofhansl
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors.
> OperationStatus and OperationStatusCode should have the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors
[
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817450#comment-16817450
]
Andrew Purtell commented on HBASE-22235:
Sounds good to me
> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Reporter: Lars Hofhansl
>Priority: Major
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors.
> OperationStatus and OperationStatusCode should have the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #149: HBASE-22239 Should translate the exception before returning it in Asy…
Apache-HBase commented on issue #149: HBASE-22239 Should translate the exception before returning it in Asy… URL: https://github.com/apache/hbase/pull/149#issuecomment-483047305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 282 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ HBASE-21512 Compile Tests _ | | +1 | mvninstall | 307 | HBASE-21512 passed | | +1 | compile | 66 | HBASE-21512 passed | | +1 | checkstyle | 82 | HBASE-21512 passed | | +1 | shadedjars | 336 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 276 | HBASE-21512 passed | | +1 | javadoc | 41 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | +1 | checkstyle | 80 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 329 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 636 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 245 | the patch passed | | +1 | javadoc | 42 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14878 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 18077 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDroppedTables | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-149/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/149 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e8a94dd85a25 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / f47f6dfe51 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-149/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-149/1/testReport/ | | Max. process+thread count | 5127 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-149/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-16002) Many DataType constructors are not public
[
https://issues.apache.org/jira/browse/HBASE-16002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817369#comment-16817369
]
Nick Dimiduk commented on HBASE-16002:
--
I believe my original intent was to only expose constructors where a caller
must provide their own parameters; everywhere else there are static constants
available. The idea being to help callers avoid accidental excessive
construction of these things. However, it makes for an inconsistent API, which
becomes a bit of a burden for someone who wants to generate instances
dynamically.
I'm coming around to the idea of keeping your improvement, retain the public
constructors everywhere. For me, the argument for consistency is stronger than
the argument of "protecting" the caller. [~Jan Hentschel] what do you think?
> Many DataType constructors are not public
> -
>
> Key: HBASE-16002
> URL: https://issues.apache.org/jira/browse/HBASE-16002
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: HBASE-16002.master.001.patch
>
>
> Using the {{Struct}} class to build a rowkey, I noticed than many of the
> provided {{DataType}} implementations' constructors are protected. They
> should be public in most (all?) cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #151: HBASE-22242 Removed deprecated method in RegionLoadStats
Apache-HBase commented on issue #151: HBASE-22242 Removed deprecated method in RegionLoadStats URL: https://github.com/apache/hbase/pull/151#issuecomment-483023869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 239 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 256 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 30 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 59 | master passed | | +1 | javadoc | 22 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 252 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 276 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 513 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 65 | the patch passed | | +1 | javadoc | 22 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 199 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2357 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-151/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/151 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux eee5d0c1b3b6 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / cb84b2788a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-151/1/testReport/ | | Max. process+thread count | 307 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-151/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #140: HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator
Apache-HBase commented on issue #140: HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator URL: https://github.com/apache/hbase/pull/140#issuecomment-483023511 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for branch | | +1 | mvninstall | 268 | HBASE-21512 passed | | +1 | compile | 81 | HBASE-21512 passed | | +1 | checkstyle | 108 | HBASE-21512 passed | | +1 | shadedjars | 280 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 289 | HBASE-21512 passed | | +1 | javadoc | 61 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 270 | the patch passed | | +1 | compile | 86 | the patch passed | | +1 | javac | 86 | the patch passed | | +1 | checkstyle | 108 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 285 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 546 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 267 | the patch passed | | +1 | javadoc | 56 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 194 | hbase-client in the patch passed. | | -1 | unit | 14635 | hbase-server in the patch failed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 17766 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.quotas.TestSpaceQuotas | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/140 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7cf768ed521d 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / f47f6dfe51 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/testReport/ | | Max. process+thread count | 4640 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #148: HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
Apache-HBase commented on issue #148: HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated URL: https://github.com/apache/hbase/pull/148#issuecomment-483019707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 22 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 257 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 69 | master passed | | +1 | shadedjars | 268 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 181 | master passed | | +1 | javadoc | 33 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 243 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 68 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 498 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 208 | the patch passed | | +1 | javadoc | 33 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8200 | hbase-server in the patch passed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 10557 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-148/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/148 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dce521c820ad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 01c26c5311 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-148/1/testReport/ | | Max. process+thread count | 5086 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-148/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ekienle commented on issue #149: HBASE-22239 Should translate the exception before returning it in Asy…
ekienle commented on issue #149: HBASE-22239 Should translate the exception before returning it in Asy… URL: https://github.com/apache/hbase/pull/149#issuecomment-483017836 Unsubscribe > On Apr 14, 2019, at 7:30 AM, Apache9 wrote: > > …ncRegionServerAdmin > > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/hbase/pull/149 > > Commit Summary > > HBASE-22239 Should translate the exception before returning it in AsyncRegionServerAdmin > File Changes > > M hbase-server/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionServerAdmin.java (3) > Patch Links: > > https://github.com/apache/hbase/pull/149.patch > https://github.com/apache/hbase/pull/149.diff > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet opened a new pull request #151: HBASE-22242 Removed deprecated method in RegionLoadStats
HorizonNet opened a new pull request #151: HBASE-22242 Removed deprecated method in RegionLoadStats URL: https://github.com/apache/hbase/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22242) Remove deprecated method in RegionLoadStats
Jan Hentschel created HBASE-22242: - Summary: Remove deprecated method in RegionLoadStats Key: HBASE-22242 URL: https://issues.apache.org/jira/browse/HBASE-22242 Project: HBase Issue Type: Task Components: Client Reporter: Jan Hentschel Assignee: Jan Hentschel getMemstoreLoad() in RegionLoadStats was deprecated back in 2.0.0 and should be removed for 3.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #150: HBASE-22241 Fix TestRegionServerCoprocessorEndpoint
Apache-HBase commented on issue #150: HBASE-22241 Fix TestRegionServerCoprocessorEndpoint URL: https://github.com/apache/hbase/pull/150#issuecomment-483003722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 265 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | +1 | mvninstall | 253 | HBASE-21512 passed | | +1 | compile | 25 | HBASE-21512 passed | | +1 | checkstyle | 12 | HBASE-21512 passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 39 | HBASE-21512 passed | | +1 | javadoc | 13 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 239 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 504 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 45 | the patch passed | | +1 | javadoc | 12 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 303 | hbase-endpoint in the patch passed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 2359 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-150/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/150 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 31488ec48634 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / f47f6dfe51 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-150/1/testReport/ | | Max. process+thread count | 3009 (vs. ulimit of 1) | | modules | C: hbase-endpoint U: hbase-endpoint | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-150/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817336#comment-16817336
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #176 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/176/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/176//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/176//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/176//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #150: HBASE-22241 Fix TestRegionServerCoprocessorEndpoint
Apache9 opened a new pull request #150: HBASE-22241 Fix TestRegionServerCoprocessorEndpoint URL: https://github.com/apache/hbase/pull/150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22241) Fix TestRegionServerCoprocessorEndpoint
[ https://issues.apache.org/jira/browse/HBASE-22241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22241: -- Description: In AsyncAdmin we will unwrap the RemoteException so the assertion should be changed. > Fix TestRegionServerCoprocessorEndpoint > --- > > Key: HBASE-22241 > URL: https://issues.apache.org/jira/browse/HBASE-22241 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Duo Zhang >Priority: Major > > In AsyncAdmin we will unwrap the RemoteException so the assertion should be > changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22241) Fix TestRegionServerCoprocessorEndpoint
Duo Zhang created HBASE-22241: - Summary: Fix TestRegionServerCoprocessorEndpoint Key: HBASE-22241 URL: https://issues.apache.org/jira/browse/HBASE-22241 Project: HBase Issue Type: Sub-task Components: test Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22239) Should translate the exception before returning it in AsyncRegionServerAdmin
[ https://issues.apache.org/jira/browse/HBASE-22239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22239: - Assignee: Duo Zhang > Should translate the exception before returning it in AsyncRegionServerAdmin > > > Key: HBASE-22239 > URL: https://issues.apache.org/jira/browse/HBASE-22239 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > This breaks TestSyncReplicationActive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22240) [backport] HBASE-19762 Fix Checkstyle errors in hbase-http
[ https://issues.apache.org/jira/browse/HBASE-22240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22240: -- Attachment: HBASE-22240.branch-2.001.patch > [backport] HBASE-19762 Fix Checkstyle errors in hbase-http > -- > > Key: HBASE-22240 > URL: https://issues.apache.org/jira/browse/HBASE-22240 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.1 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Attachments: HBASE-22240.branch-2.001.patch > > > I tried to apply HBASE-21048 to branch-2 which is based on master branch with > HBASE-19762 applied. Therefore, there were lot of conflicts. > I will back-port HBASE-19762 to branch-2, then push HBASE-21048 to branch-2 > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] tianjy1990 merged pull request #148: HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
tianjy1990 merged pull request #148: HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated URL: https://github.com/apache/hbase/pull/148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22240) [backport] HBASE-19762 Fix Checkstyle errors in hbase-http
Reid Chan created HBASE-22240: - Summary: [backport] HBASE-19762 Fix Checkstyle errors in hbase-http Key: HBASE-22240 URL: https://issues.apache.org/jira/browse/HBASE-22240 Project: HBase Issue Type: Improvement Reporter: Reid Chan Assignee: Reid Chan I tried to apply HBASE-21048 to branch-2 which is based on master branch with HBASE-19762 applied. Therefore, there were lot of conflicts. I will back-port HBASE-19762 to branch-2, then push HBASE-21048 to branch-2 as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22240) [backport] HBASE-19762 Fix Checkstyle errors in hbase-http
[ https://issues.apache.org/jira/browse/HBASE-22240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22240: -- Affects Version/s: 2.2.1 > [backport] HBASE-19762 Fix Checkstyle errors in hbase-http > -- > > Key: HBASE-22240 > URL: https://issues.apache.org/jira/browse/HBASE-22240 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.1 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > > I tried to apply HBASE-21048 to branch-2 which is based on master branch with > HBASE-19762 applied. Therefore, there were lot of conflicts. > I will back-port HBASE-19762 to branch-2, then push HBASE-21048 to branch-2 > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #149: HBASE-22239 Should translate the exception before returning it in Asy…
Apache9 opened a new pull request #149: HBASE-22239 Should translate the exception before returning it in Asy… URL: https://github.com/apache/hbase/pull/149 …ncRegionServerAdmin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22239) Should translate the exception before returning it in AsyncRegionServerAdmin
Duo Zhang created HBASE-22239: - Summary: Should translate the exception before returning it in AsyncRegionServerAdmin Key: HBASE-22239 URL: https://issues.apache.org/jira/browse/HBASE-22239 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang This breaks TestSyncReplicationActive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817313#comment-16817313
]
Hudson commented on HBASE-21048:
Results for branch master
[build #932 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/932/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/932//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/932//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/932//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: security
> Attachments: HBASE-21048.001.patch, HBASE-21048.branch-1.001.patch,
> HBASE-21048.master.001.patch, HBASE-21048.master.002.patch,
> HBASE-21048.master.003.patch, HBASE-21048.master.004.patch,
> HBASE-21048.master.005.patch, HBASE-21048.master.006.patch,
> HBASE-21048.master.007.patch, HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #147: HBASE-22238 Fix TestRpcControllerFactory
Apache-HBase commented on issue #147: HBASE-22238 Fix TestRpcControllerFactory URL: https://github.com/apache/hbase/pull/147#issuecomment-482986014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 287 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | +1 | mvninstall | 285 | HBASE-21512 passed | | +1 | compile | 23 | HBASE-21512 passed | | +1 | checkstyle | 11 | HBASE-21512 passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 42 | HBASE-21512 passed | | +1 | javadoc | 14 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 268 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 10 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 252 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 501 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 51 | the patch passed | | +1 | javadoc | 12 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 565 | hbase-endpoint in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 2686 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/147 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e32c37092806 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / f47f6dfe51 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/artifact/out/patch-unit-hbase-endpoint.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/testReport/ | | Max. process+thread count | 2923 (vs. ulimit of 1) | | modules | C: hbase-endpoint U: hbase-endpoint | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] tianjy1990 opened a new pull request #148: HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
tianjy1990 opened a new pull request #148: HBASE-22234 Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated URL: https://github.com/apache/hbase/pull/148 fix flakey test which is easily failed due to unfinished assign region procedure . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #147: HBASE-22238 Fix TestRpcControllerFactory
Apache-HBase commented on issue #147: HBASE-22238 Fix TestRpcControllerFactory URL: https://github.com/apache/hbase/pull/147#issuecomment-482985191 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 166 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | +1 | mvninstall | 254 | HBASE-21512 passed | | +1 | compile | 25 | HBASE-21512 passed | | +1 | checkstyle | 13 | HBASE-21512 passed | | +1 | shadedjars | 256 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 38 | HBASE-21512 passed | | +1 | javadoc | 14 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 243 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 505 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 45 | the patch passed | | +1 | javadoc | 14 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 446 | hbase-endpoint in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2405 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/147 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d173a24ec8ed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / f47f6dfe51 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/artifact/out/patch-unit-hbase-endpoint.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/testReport/ | | Max. process+thread count | 3044 (vs. ulimit of 1) | | modules | C: hbase-endpoint U: hbase-endpoint | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-21257) misspelled words.[occured -> occurred]
[ https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21257: -- Resolution: Fixed Fix Version/s: 2.1.5 2.3.0 2.2.0 3.0.0 Status: Resolved (was: Patch Available) Pushed to branch-2.1+. Thanks [~zhanggangxue] for contributing. > misspelled words.[occured -> occurred] > -- > > Key: HBASE-21257 > URL: https://issues.apache.org/jira/browse/HBASE-21257 > Project: HBase > Issue Type: Bug >Reporter: zhanggangxue >Assignee: zhanggangxue >Priority: Trivial > Labels: occured, occurred, typo > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5 > > Attachments: 0001-misspelled-words.-occured-occurred.patch, > HBASE-21257.master.0001.patch > > > I found some spelling errors on the master Branch.Found in [misspelled > words|https://github.com/apache/hbase/pull/91] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21257) misspelled words.[occured -> occurred]
[ https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21257: -- Issue Type: Improvement (was: Bug) > misspelled words.[occured -> occurred] > -- > > Key: HBASE-21257 > URL: https://issues.apache.org/jira/browse/HBASE-21257 > Project: HBase > Issue Type: Improvement >Reporter: zhanggangxue >Assignee: zhanggangxue >Priority: Trivial > Labels: occured, occurred, typo > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5 > > Attachments: 0001-misspelled-words.-occured-occurred.patch, > HBASE-21257.master.0001.patch > > > I found some spelling errors on the master Branch.Found in [misspelled > words|https://github.com/apache/hbase/pull/91] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 merged pull request #146: HBASE-21257 misspelled words.[occured -> occurred]
Apache9 merged pull request #146: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #147: Hbase 22238
Apache9 opened a new pull request #147: Hbase 22238 URL: https://github.com/apache/hbase/pull/147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22238) Fix TestRpcControllerFactory
Duo Zhang created HBASE-22238: - Summary: Fix TestRpcControllerFactory Key: HBASE-22238 URL: https://issues.apache.org/jira/browse/HBASE-22238 Project: HBase Issue Type: Sub-task Components: test Reporter: Duo Zhang Assignee: Duo Zhang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817304#comment-16817304
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #63 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/63/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/63//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/63//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/63//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22237) Fix broken UTs on branch HBASE-21512
Duo Zhang created HBASE-22237: - Summary: Fix broken UTs on branch HBASE-21512 Key: HBASE-22237 URL: https://issues.apache.org/jira/browse/HBASE-22237 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang There are lots of UTs broken on HBASE-21512. https://builds.apache.org/job/HBASE-Find-Flaky-Tests/job/HBASE-21512/lastSuccessfulBuild/artifact/dashboard.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22199) Replace "UTF-8" with StandardCharsets.UTF_8 where possible
[ https://issues.apache.org/jira/browse/HBASE-22199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817286#comment-16817286 ] Jan Hentschel commented on HBASE-22199: --- [~psomogyi] I think when working with bytes this makes sense, but for strings we should change it, or? > Replace "UTF-8" with StandardCharsets.UTF_8 where possible > -- > > Key: HBASE-22199 > URL: https://issues.apache.org/jira/browse/HBASE-22199 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > > Currently the String "UTF-8" is used in some places where > StandardCharsets.UTF_8 could be used. To make it easier to maintain, the > current usages of "UTF-8" as a String should be replaced with > StandardCharsets.UTF_8. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817278#comment-16817278 ] Jingyun Tian commented on HBASE-21965: -- [~busbey] [~Apache9], This patch could go to different hbase versions, since it only find these problematic regions by scan meta or compare regioninfos on FS. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22207) Fix flakey TestAssignmentManager.testAssignSocketTimeout
[ https://issues.apache.org/jira/browse/HBASE-22207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22207: -- Fix Version/s: 2.3.0 2.2.0 3.0.0 > Fix flakey TestAssignmentManager.testAssignSocketTimeout > > > Key: HBASE-22207 > URL: https://issues.apache.org/jira/browse/HBASE-22207 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > > The problem is that we may kill the RS which holds meta so the assertion of > the number of procedures maybe incorrect, as we may schedule another TRSP for > assigning meta... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817240#comment-16817240 ] Duo Zhang commented on HBASE-21965: --- [~tianjingyun] How do we know if we can use a specific function in HBCK2 for different hbase versions? Thanks. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22236) TestAsyncTableGetMultiThreaded sometimes timed out
[
https://issues.apache.org/jira/browse/HBASE-22236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817239#comment-16817239
]
Duo Zhang commented on HBASE-22236:
---
This is what I pushed to master branch. Will keep an eye on the flakey
dashboard.
> TestAsyncTableGetMultiThreaded sometimes timed out
> --
>
> Key: HBASE-22236
> URL: https://issues.apache.org/jira/browse/HBASE-22236
> Project: HBase
> Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22236.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2992/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt/*view*/
> After this line
> {noformat}
> 2019-04-14 04:44:41,736 INFO [PEWorker-12]
> procedure2.ProcedureExecutor(1410): Finished pid=117, state=SUCCESS,
> hasLock=false; TransitRegionStateProcedure table=hbase:meta,
> region=1588230740, REOPEN/MOVE in 2.0690sec
> {noformat}
> Seems we just do nothing until the test is timed out.
> And there is no main thread in the output hanging thread, which is a bit
> strange, although all the get threads are hanging there.
> Let me add some logs for better debugging first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22236) TestAsyncTableGetMultiThreaded sometimes timed out
[
https://issues.apache.org/jira/browse/HBASE-22236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22236:
--
Attachment: HBASE-22236.patch
> TestAsyncTableGetMultiThreaded sometimes timed out
> --
>
> Key: HBASE-22236
> URL: https://issues.apache.org/jira/browse/HBASE-22236
> Project: HBase
> Issue Type: Bug
>Reporter: Duo Zhang
>Priority: Major
> Attachments: HBASE-22236.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2992/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt/*view*/
> After this line
> {noformat}
> 2019-04-14 04:44:41,736 INFO [PEWorker-12]
> procedure2.ProcedureExecutor(1410): Finished pid=117, state=SUCCESS,
> hasLock=false; TransitRegionStateProcedure table=hbase:meta,
> region=1588230740, REOPEN/MOVE in 2.0690sec
> {noformat}
> Seems we just do nothing until the test is timed out.
> And there is no main thread in the output hanging thread, which is a bit
> strange, although all the get threads are hanging there.
> Let me add some logs for better debugging first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-22236) TestAsyncTableGetMultiThreaded sometimes timed out
[
https://issues.apache.org/jira/browse/HBASE-22236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-22236:
-
Assignee: Duo Zhang
> TestAsyncTableGetMultiThreaded sometimes timed out
> --
>
> Key: HBASE-22236
> URL: https://issues.apache.org/jira/browse/HBASE-22236
> Project: HBase
> Issue Type: Bug
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22236.patch
>
>
> https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2992/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt/*view*/
> After this line
> {noformat}
> 2019-04-14 04:44:41,736 INFO [PEWorker-12]
> procedure2.ProcedureExecutor(1410): Finished pid=117, state=SUCCESS,
> hasLock=false; TransitRegionStateProcedure table=hbase:meta,
> region=1588230740, REOPEN/MOVE in 2.0690sec
> {noformat}
> Seems we just do nothing until the test is timed out.
> And there is no main thread in the output hanging thread, which is a bit
> strange, although all the get threads are hanging there.
> Let me add some logs for better debugging first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817236#comment-16817236
]
HBase QA commented on HBASE-21048:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
12s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
48s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
20s{color} | {color:red} hbase-server: The patch generated 3 new + 1 unchanged
- 16 fixed = 4 total (was 17) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
52s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
1m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}123m
38s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m 53s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/80/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-21048 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965857/HBASE-21048.branch-1.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 679fbec7184f
[jira] [Created] (HBASE-22236) TestAsyncTableGetMultiThreaded sometimes timed out
Duo Zhang created HBASE-22236:
-
Summary: TestAsyncTableGetMultiThreaded sometimes timed out
Key: HBASE-22236
URL: https://issues.apache.org/jira/browse/HBASE-22236
Project: HBase
Issue Type: Bug
Reporter: Duo Zhang
https://builds.apache.org/job/HBase-Flaky-Tests/job/master/2992/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded-output.txt/*view*/
After this line
{noformat}
2019-04-14 04:44:41,736 INFO [PEWorker-12] procedure2.ProcedureExecutor(1410):
Finished pid=117, state=SUCCESS, hasLock=false; TransitRegionStateProcedure
table=hbase:meta, region=1588230740, REOPEN/MOVE in 2.0690sec
{noformat}
Seems we just do nothing until the test is timed out.
And there is no main thread in the output hanging thread, which is a bit
strange, although all the get threads are hanging there.
Let me add some logs for better debugging first.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi reassigned HBASE-2:
-
Assignee: Duo Zhang (was: Peter Somogyi)
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-2.patch
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817225#comment-16817225
]
Peter Somogyi commented on HBASE-2:
---
The thirdparty change is merged. After thirdparty-2.2.1 is out this patch that
[~Apache9] attached can be merged to branch-2.2+.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-2.patch
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-22233. --- Resolution: Fixed Thanks for the review [~Apache9]! Merged PR #1. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Peter Somogyi >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reassigned HBASE-22233: - Assignee: Peter Somogyi (was: Duo Zhang) > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Peter Somogyi >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors
[
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817220#comment-16817220
]
Lars Hofhansl commented on HBASE-22235:
---
I found a different (and better) way to solve TEPHRA-299, but I still think
this should be fixes. In fact I want to change it for HBase 1.5.x.
[~apurtell]
It needs two changes: (1) change the visibility label, and (2) make
OperationStatus.\{SUCCESS|FAILURE|NOT_RUN} public.
> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Reporter: Lars Hofhansl
>Priority: Major
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors.
> OperationStatus and OperationStatusCode should have the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
[ https://issues.apache.org/jira/browse/HBASE-22234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22234: -- Fix Version/s: (was: 2.2.0) > Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated > --- > > Key: HBASE-22234 > URL: https://issues.apache.org/jira/browse/HBASE-22234 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
[ https://issues.apache.org/jira/browse/HBASE-22234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22234: -- Component/s: test > Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated > --- > > Key: HBASE-22234 > URL: https://issues.apache.org/jira/browse/HBASE-22234 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
[ https://issues.apache.org/jira/browse/HBASE-22234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22234: -- Fix Version/s: 2.3.0 2.2.0 3.0.0 > Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated > --- > > Key: HBASE-22234 > URL: https://issues.apache.org/jira/browse/HBASE-22234 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors
[
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817218#comment-16817218
]
Duo Zhang commented on HBASE-22235:
---
Since it is immutable and can be retrieved by calling methods in the Region
interface which is visible to CPs, I think it is fine to also make it visible
to CPs.
> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Reporter: Lars Hofhansl
>Priority: Major
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors.
> OperationStatus and OperationStatusCode should have the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817215#comment-16817215 ] Duo Zhang commented on HBASE-22233: --- I approved your PR [~psomogyi]. Please merge it and then we can push out the RC. Thanks. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22208) Create access checker and expose it in RS
[ https://issues.apache.org/jira/browse/HBASE-22208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817204#comment-16817204 ] Guanghao Zhang commented on HBASE-22208: For 004 patch, need add @Override for method in NoopAccessChecker and no need to add methods' javadoc comment? But need one class's javadoc comment. And the accessChecker may be null in AccessController? > Create access checker and expose it in RS > - > > Key: HBASE-22208 > URL: https://issues.apache.org/jira/browse/HBASE-22208 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Attachments: HBASE-22208.master.001.patch, > HBASE-22208.master.002.patch, HBASE-22208.master.003.patch, > HBASE-22208.master.004.patch > > > In HBase access control service, access checker performs authorization checks > for a given user's assigned permissions. The access checker holds a auth > manager instance which cache all global, namespace and table permissions. > A access checker is created when master, RS and region load AccessController, > permission cache is refreshed when acl znode changed. > We can create access checker when master and RS start and expose it in order > to use procedure to refresh its cache rather than watch ZK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-21048:
Attachment: HBASE-21048.branch-1.001.patch
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: security
> Attachments: HBASE-21048.001.patch, HBASE-21048.branch-1.001.patch,
> HBASE-21048.master.001.patch, HBASE-21048.master.002.patch,
> HBASE-21048.master.003.patch, HBASE-21048.master.004.patch,
> HBASE-21048.master.005.patch, HBASE-21048.master.006.patch,
> HBASE-21048.master.007.patch, HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817202#comment-16817202
]
Wei-Chiu Chuang commented on HBASE-21048:
-
Attach branch-1 patch for precommit.
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: security
> Attachments: HBASE-21048.001.patch, HBASE-21048.branch-1.001.patch,
> HBASE-21048.master.001.patch, HBASE-21048.master.002.patch,
> HBASE-21048.master.003.patch, HBASE-21048.master.004.patch,
> HBASE-21048.master.005.patch, HBASE-21048.master.006.patch,
> HBASE-21048.master.007.patch, HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://; + args[1] + "/logLevel?log=" + args[2]
> + "=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
