[GitHub] [hbase] Apache-HBase commented on issue #190: HBASE-21723 Remove ConnectionImplementation and related classes
Apache-HBase commented on issue #190: HBASE-21723 Remove ConnectionImplementation and related classes URL: https://github.com/apache/hbase/pull/190#issuecomment-496081138 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for branch | | +1 | mvninstall | 264 | HBASE-21512 passed | | +1 | compile | 130 | HBASE-21512 passed | | +1 | checkstyle | 149 | HBASE-21512 passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 314 | HBASE-21512 passed | | +1 | javadoc | 82 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 242 | the patch passed | | +1 | compile | 127 | the patch passed | | +1 | javac | 127 | the patch passed | | +1 | checkstyle | 28 | hbase-client: The patch generated 0 new + 4 unchanged - 289 fixed = 4 total (was 293) | | +1 | checkstyle | 77 | hbase-server: The patch generated 0 new + 210 unchanged - 50 fixed = 210 total (was 260) | | +1 | checkstyle | 18 | hbase-mapreduce: The patch generated 0 new + 15 unchanged - 5 fixed = 15 total (was 20) | | +1 | checkstyle | 16 | hbase-it: The patch generated 0 new + 120 unchanged - 5 fixed = 120 total (was 125) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1021 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 284 | the patch passed | | +1 | javadoc | 80 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 101 | hbase-client in the patch passed. | | +1 | unit | 7454 | hbase-server in the patch passed. | | +1 | unit | 973 | hbase-mapreduce in the patch passed. | | +1 | unit | 63 | hbase-it in the patch passed. | | +1 | asflicense | 106 | The patch does not generate ASF License warnings. | | | | 12586 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-190/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/190 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 142e3e1c1b86 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / 675247686d | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-190/11/testReport/ | | Max. process+thread count | 5156 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-it U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-190/11/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22419) Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all active branches
[
https://issues.apache.org/jira/browse/HBASE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848617#comment-16848617
]
Hudson commented on HBASE-22419:
Results for branch branch-1.3
[build #788 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all
> active branches
>
>
> Key: HBASE-22419
> URL: https://issues.apache.org/jira/browse/HBASE-22419
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 1.4.10, 2.0.6, 1.3.5, 2.1.6
>
> Attachments: HBASE-22419-branch-1.4.patch,
> HBASE-22419-branch-2.0.patch, HBASE-22419-branch-2.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22399) Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks
[
https://issues.apache.org/jira/browse/HBASE-22399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848618#comment-16848618
]
Hudson commented on HBASE-22399:
Results for branch branch-1.3
[build #788 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/788//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks
> -
>
> Key: HBASE-22399
> URL: https://issues.apache.org/jira/browse/HBASE-22399
> Project: HBase
> Issue Type: Sub-task
> Components: build, hadoop2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22399-v1.patch, HBASE-22399-v2.patch,
> HBASE-22399.patch
>
>
> Our nightly is failing so let's do this first, and for the ref guide changes
> can be done in another sub task.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22399) Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks
[
https://issues.apache.org/jira/browse/HBASE-22399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848615#comment-16848615
]
Hudson commented on HBASE-22399:
Results for branch branch-1.4
[build #817 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks
> -
>
> Key: HBASE-22399
> URL: https://issues.apache.org/jira/browse/HBASE-22399
> Project: HBase
> Issue Type: Sub-task
> Components: build, hadoop2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22399-v1.patch, HBASE-22399-v2.patch,
> HBASE-22399.patch
>
>
> Our nightly is failing so let's do this first, and for the ref guide changes
> can be done in another sub task.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22419) Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all active branches
[
https://issues.apache.org/jira/browse/HBASE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848614#comment-16848614
]
Hudson commented on HBASE-22419:
Results for branch branch-1.4
[build #817 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/817//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all
> active branches
>
>
> Key: HBASE-22419
> URL: https://issues.apache.org/jira/browse/HBASE-22419
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 1.4.10, 2.0.6, 1.3.5, 2.1.6
>
> Attachments: HBASE-22419-branch-1.4.patch,
> HBASE-22419-branch-2.0.patch, HBASE-22419-branch-2.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22473) Split TestSCP
[
https://issues.apache.org/jira/browse/HBASE-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848606#comment-16848606
]
Hudson commented on HBASE-22473:
Results for branch branch-2
[build #1921 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1921/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1921//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1921//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1921//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1921//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Split TestSCP
> -
>
> Key: HBASE-22473
> URL: https://issues.apache.org/jira/browse/HBASE-22473
> Project: HBase
> Issue Type: Bug
> Components: Recovery, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1
>
>
> It is time consuming.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22403) Balance in RSGroup should consider throttling and a failure affects the whole
[
https://issues.apache.org/jira/browse/HBASE-22403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848604#comment-16848604
]
HBase QA commented on HBASE-22403:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} branch-1 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} branch-1 passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
38s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} branch-1 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} branch-1 passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
4m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}103m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
32s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
44s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}155m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.security.access.TestAdminOnlyOperations |
\\
\\
||
[jira] [Commented] (HBASE-22473) Split TestSCP
[
https://issues.apache.org/jira/browse/HBASE-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848599#comment-16848599
]
Hudson commented on HBASE-22473:
Results for branch branch-2.2
[build #291 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/291/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/291//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/291//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/291//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/291//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Split TestSCP
> -
>
> Key: HBASE-22473
> URL: https://issues.apache.org/jira/browse/HBASE-22473
> Project: HBase
> Issue Type: Bug
> Components: Recovery, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1
>
>
> It is time consuming.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22473) Split TestSCP
[
https://issues.apache.org/jira/browse/HBASE-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848593#comment-16848593
]
Hudson commented on HBASE-22473:
Results for branch master
[build #1039 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1039/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1039//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1039//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1039//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1039//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Split TestSCP
> -
>
> Key: HBASE-22473
> URL: https://issues.apache.org/jira/browse/HBASE-22473
> Project: HBase
> Issue Type: Bug
> Components: Recovery, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1
>
>
> It is time consuming.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] ramkrish86 commented on a change in pull request #242: HBASE-22422 Retain an ByteBuff with refCnt=0 when getBlock from LRUCache
ramkrish86 commented on a change in pull request #242: HBASE-22422 Retain an
ByteBuff with refCnt=0 when getBlock from LRUCache
URL: https://github.com/apache/hbase/pull/242#discussion_r287636742
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
##
@@ -313,10 +313,13 @@ public BlockWithScanInfo loadDataBlockWithScanInfo(Cell
key, HFileBlock currentB
int index = -1;
HFileBlock block = null;
- boolean dataBlock = false;
KeyOnlyKeyValue tmpNextIndexKV = new KeyValue.KeyOnlyKeyValue();
while (true) {
try {
+ // Must initialize it with null here, because if don't and once an
exception happen in
+ // readBlock, then we'll release the previous assigned block twice
in the finally block.
+ // (See HBASE-22422)
+ block = null;
Review comment:
Good catch.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup
[ https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848585#comment-16848585 ] Xiaolin Ha commented on HBASE-22411: Uploaded to the review board, see at: https://reviews.apache.org/r/70638/ > Refactor codes of moving reigons in RSGroup > --- > > Key: HBASE-22411 > URL: https://issues.apache.org/jira/browse/HBASE-22411 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22411.branch-2.2.001.patch, > HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, > HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, > HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, > HBASE-22411.master.010.patch, HBASE-22411.master.011.patch > > > Essentially RSGroup managed regions. Organizing tables or servers' RSGroups > is to move relevant regions. Codes of moving regions can be refactored. > So that some problems caused by moving regions can be fixed elegantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22419) Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all active branches
[ https://issues.apache.org/jira/browse/HBASE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848582#comment-16848582 ] Hudson commented on HBASE-22419: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #564 (See [https://builds.apache.org/job/HBase-1.3-IT/564/]) HBASE-22419 Backport hbase-personality changes in HBASE-22399 to all (zhangduo: rev c0f9087d044f1f0ddf2413b558c46de64b0f4a0b) * (edit) dev-support/hbase-personality.sh > Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all > active branches > > > Key: HBASE-22419 > URL: https://issues.apache.org/jira/browse/HBASE-22419 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 1.4.10, 2.0.6, 1.3.5, 2.1.6 > > Attachments: HBASE-22419-branch-1.4.patch, > HBASE-22419-branch-2.0.patch, HBASE-22419-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22399) Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks
[ https://issues.apache.org/jira/browse/HBASE-22399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848583#comment-16848583 ] Hudson commented on HBASE-22399: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #564 (See [https://builds.apache.org/job/HBase-1.3-IT/564/]) HBASE-22419 Backport hbase-personality changes in HBASE-22399 to all (zhangduo: rev c0f9087d044f1f0ddf2413b558c46de64b0f4a0b) * (edit) dev-support/hbase-personality.sh > Change default hadoop-two.version to 2.8.x and remove the 2.7.x hadoop checks > - > > Key: HBASE-22399 > URL: https://issues.apache.org/jira/browse/HBASE-22399 > Project: HBase > Issue Type: Sub-task > Components: build, hadoop2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22399-v1.patch, HBASE-22399-v2.patch, > HBASE-22399.patch > > > Our nightly is failing so let's do this first, and for the ref guide changes > can be done in another sub task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22475) Nightly integration test fails with NoClassDefFoundError
[
https://issues.apache.org/jira/browse/HBASE-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848579#comment-16848579
]
Duo Zhang commented on HBASE-22475:
---
We have different checks in nightly jobs, the general build report is only one
of the checks...
The integration test is to start a cluster on a hadoop cluster and test basic
operations, I believe.
> Nightly integration test fails with NoClassDefFoundError
>
>
> Key: HBASE-22475
> URL: https://issues.apache.org/jira/browse/HBASE-22475
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0
>
>
> On Nightly the packaging and integration step fails when executing
> hbase_nightly_pseudo-distributed-test.sh. The create table step fails
> NoClassDefFoundError when starting the shell.
> [https://builds.apache.org/job/HBase%20Nightly/job/master/1037/artifact/output-integration/hadoop-2/table_create.log]
> {noformat}
> LoadError: load error: hbase/hbase -- java.lang.NoClassDefFoundError:
> org/codehaus/jackson/JsonGenerator
> require at org/jruby/RubyKernel.java:956
> require at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/lib/ruby/hbase_constants.rb:117
> require at org/jruby/RubyKernel.java:956
>(root) at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/bin/../bin/hirb.rb:131{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22477) Throwing exception when meta region is not in OPEN state in client registry may crash a naster
Duo Zhang created HBASE-22477:
-
Summary: Throwing exception when meta region is not in OPEN state
in client registry may crash a naster
Key: HBASE-22477
URL: https://issues.apache.org/jira/browse/HBASE-22477
Project: HBase
Issue Type: Bug
Components: Client, master, meta
Reporter: Duo Zhang
{noformat}
2019-05-26 17:10:31,195 ERROR [master/asf906:0:becomeActiveMaster]
helpers.MarkerIgnoringBase(159): Failed to become active master
org.apache.hadoop.hbase.client.RetriesExhaustedException: Cannot get the
location for replica0 of region for in hbase:meta
at
org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.getRegionLocations(RpcRetryingCallerWithReadReplicas.java:335)
at
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:153)
at
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:58)
at
org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
at
org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:263)
at
org.apache.hadoop.hbase.client.ClientScanner.loadCache(ClientScanner.java:405)
at
org.apache.hadoop.hbase.client.ClientScanner.nextWithSyncCache(ClientScanner.java:285)
at
org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:564)
at
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:766)
at
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:734)
at
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:690)
at
org.apache.hadoop.hbase.MetaTableAccessor.fullScanRegions(MetaTableAccessor.java:220)
at
org.apache.hadoop.hbase.master.assignment.RegionStateStore.visitMeta(RegionStateStore.java:77)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.loadMeta(AssignmentManager.java:1294)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.joinCluster(AssignmentManager.java:1255)
at
org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1100)
at
org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2375)
at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:605)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: Meta region is in state OPENING
at
org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getMetaRegionLocation$1(ZKAsyncRegistry.java:162)
at
org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:70)
at
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
at
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
at
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at
java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
at
org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getAndConvert$0(ZKAsyncRegistry.java:81)
at
org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:70)
at
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
at
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
at
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at
java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
at
org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$ZKTask$1.exec(ReadOnlyZKClient.java:174)
at
org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient.run(ReadOnlyZKClient.java:342)
... 1 more
{noformat}
I think the logic is introduced at the time that we do not change the state of
meta region on zk. But now, we will change the state of meta region, so maybe
we should remove the logic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup
[ https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848574#comment-16848574 ] Guanghao Zhang commented on HBASE-22411: Upload the 011 patch to review board? > Refactor codes of moving reigons in RSGroup > --- > > Key: HBASE-22411 > URL: https://issues.apache.org/jira/browse/HBASE-22411 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22411.branch-2.2.001.patch, > HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, > HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, > HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, > HBASE-22411.master.010.patch, HBASE-22411.master.011.patch > > > Essentially RSGroup managed regions. Organizing tables or servers' RSGroups > is to move relevant regions. Codes of moving regions can be refactored. > So that some problems caused by moving regions can be fixed elegantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22472) The newly split TestReplicationStatus* tests are flaky
[
https://issues.apache.org/jira/browse/HBASE-22472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848573#comment-16848573
]
Duo Zhang commented on HBASE-22472:
---
{noformat}
2019-05-26 17:10:31,195 ERROR [master/asf906:0:becomeActiveMaster]
helpers.MarkerIgnoringBase(159): Failed to become active master
org.apache.hadoop.hbase.client.RetriesExhaustedException: Cannot get the
location for replica0 of region for in hbase:meta
at
org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.getRegionLocations(RpcRetryingCallerWithReadReplicas.java:335)
at
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:153)
at
org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:58)
at
org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
at
org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:263)
at
org.apache.hadoop.hbase.client.ClientScanner.loadCache(ClientScanner.java:405)
at
org.apache.hadoop.hbase.client.ClientScanner.nextWithSyncCache(ClientScanner.java:285)
at
org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:564)
at
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:766)
at
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:734)
at
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:690)
at
org.apache.hadoop.hbase.MetaTableAccessor.fullScanRegions(MetaTableAccessor.java:220)
at
org.apache.hadoop.hbase.master.assignment.RegionStateStore.visitMeta(RegionStateStore.java:77)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.loadMeta(AssignmentManager.java:1294)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.joinCluster(AssignmentManager.java:1255)
at
org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1100)
at
org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2375)
at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:605)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: Meta region is in state OPENING
at
org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getMetaRegionLocation$1(ZKAsyncRegistry.java:162)
at
org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:70)
at
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
at
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
at
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at
java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
at
org.apache.hadoop.hbase.client.ZKAsyncRegistry.lambda$getAndConvert$0(ZKAsyncRegistry.java:81)
at
org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:70)
at
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
at
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
at
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at
java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
at
org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$ZKTask$1.exec(ReadOnlyZKClient.java:174)
at
org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient.run(ReadOnlyZKClient.java:342)
... 1 more
{noformat}
Seems something wrong when restarting the whole cluster. For these tests, I
think a possible solution, is to only shutdown all the region servers, not the
whole cluster. And we can open a new issue to addressing the above problem.
> The newly split TestReplicationStatus* tests are flaky
> --
>
> Key: HBASE-22472
> URL: https://issues.apache.org/jira/browse/HBASE-22472
> Project: HBase
> Issue Type: Bug
> Components: Replication, test
>Reporter: Duo Zhang
>Priority: Major
>
> They are introduced by HBASE-22455, from the original TestReplicationStatus
> tests. Need to dig more.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22475) Nightly integration test fails with NoClassDefFoundError
[
https://issues.apache.org/jira/browse/HBASE-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848572#comment-16848572
]
Guanghao Zhang commented on HBASE-22475:
But why
[https://builds.apache.org/job/HBase%20Nightly/job/master/1037/General_20Nightly_20Build_20Report/]
get a +1 overall result?
> Nightly integration test fails with NoClassDefFoundError
>
>
> Key: HBASE-22475
> URL: https://issues.apache.org/jira/browse/HBASE-22475
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0
>
>
> On Nightly the packaging and integration step fails when executing
> hbase_nightly_pseudo-distributed-test.sh. The create table step fails
> NoClassDefFoundError when starting the shell.
> [https://builds.apache.org/job/HBase%20Nightly/job/master/1037/artifact/output-integration/hadoop-2/table_create.log]
> {noformat}
> LoadError: load error: hbase/hbase -- java.lang.NoClassDefFoundError:
> org/codehaus/jackson/JsonGenerator
> require at org/jruby/RubyKernel.java:956
> require at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/lib/ruby/hbase_constants.rb:117
> require at org/jruby/RubyKernel.java:956
>(root) at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/bin/../bin/hirb.rb:131{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22419) Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all active branches
[ https://issues.apache.org/jira/browse/HBASE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22419: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.1&2.0&1.4&1.3. > Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all > active branches > > > Key: HBASE-22419 > URL: https://issues.apache.org/jira/browse/HBASE-22419 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 1.4.10, 2.0.6, 1.3.5, 2.1.6 > > Attachments: HBASE-22419-branch-1.4.patch, > HBASE-22419-branch-2.0.patch, HBASE-22419-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22419) Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all active branches
[ https://issues.apache.org/jira/browse/HBASE-22419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22419: -- Fix Version/s: (was: 2.1.5) 2.1.6 > Backport hbase-personality changes in HBASE-22399 and HBASE-20970 to all > active branches > > > Key: HBASE-22419 > URL: https://issues.apache.org/jira/browse/HBASE-22419 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 1.4.10, 2.0.6, 1.3.5, 2.1.6 > > Attachments: HBASE-22419-branch-1.4.patch, > HBASE-22419-branch-2.0.patch, HBASE-22419-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-22411) Refactor codes of moving reigons in RSGroup
[ https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848566#comment-16848566 ] Xiaolin Ha edited comment on HBASE-22411 at 5/27/19 1:51 AM: - Can this patch be committed? Solving HBASE-22414 needs this patch. was (Author: xiaolin ha): Can this patch be committed? Solving HBASE-22424 needs this patch. > Refactor codes of moving reigons in RSGroup > --- > > Key: HBASE-22411 > URL: https://issues.apache.org/jira/browse/HBASE-22411 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22411.branch-2.2.001.patch, > HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, > HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, > HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, > HBASE-22411.master.010.patch, HBASE-22411.master.011.patch > > > Essentially RSGroup managed regions. Organizing tables or servers' RSGroups > is to move relevant regions. Codes of moving regions can be refactored. > So that some problems caused by moving regions can be fixed elegantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup
[ https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848566#comment-16848566 ] Xiaolin Ha commented on HBASE-22411: Can this patch be committed? Solving HBASE-22424 needs this patch. > Refactor codes of moving reigons in RSGroup > --- > > Key: HBASE-22411 > URL: https://issues.apache.org/jira/browse/HBASE-22411 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22411.branch-2.2.001.patch, > HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, > HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, > HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, > HBASE-22411.master.010.patch, HBASE-22411.master.011.patch > > > Essentially RSGroup managed regions. Organizing tables or servers' RSGroups > is to move relevant regions. Codes of moving regions can be refactored. > So that some problems caused by moving regions can be fixed elegantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22403) Balance in RSGroup should consider throttling and a failure affects the whole
[ https://issues.apache.org/jira/browse/HBASE-22403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848563#comment-16848563 ] Xiaolin Ha commented on HBASE-22403: Attached patch for branch-1. > Balance in RSGroup should consider throttling and a failure affects the whole > - > > Key: HBASE-22403 > URL: https://issues.apache.org/jira/browse/HBASE-22403 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22403.branch-1.001.patch, > HBASE-22403.branch-2.2.001.patch, HBASE-22403.branch-2.2.002.patch, > HBASE-22403.master.001.patch, HBASE-22403.master.002.patch > > > balanceRSGroup(groupName) excutes region move plans concurrently, which will > affect the availability of relevant tables. And a plan fails will cause the > whole balance plan abort. > As mentioned in master balance issues, HBASE-17178, HBASE-21260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22476) HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.
[
https://issues.apache.org/jira/browse/HBASE-22476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848562#comment-16848562
]
HBase QA commented on HBASE-22476:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
3s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
25s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
55s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/420/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22476 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12969825/HBASE-22476.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b5b3dd2b45a7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 998b8416ca |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/420/testReport/ |
| Max. process+thread count | 4564 (vs. ulimit of 1) |
| modules | C: hbase-backup U: hbase-backup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/420/console |
|
[jira] [Updated] (HBASE-22403) Balance in RSGroup should consider throttling and a failure affects the whole
[ https://issues.apache.org/jira/browse/HBASE-22403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-22403: --- Attachment: HBASE-22403.branch-1.001.patch > Balance in RSGroup should consider throttling and a failure affects the whole > - > > Key: HBASE-22403 > URL: https://issues.apache.org/jira/browse/HBASE-22403 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22403.branch-1.001.patch, > HBASE-22403.branch-2.2.001.patch, HBASE-22403.branch-2.2.002.patch, > HBASE-22403.master.001.patch, HBASE-22403.master.002.patch > > > balanceRSGroup(groupName) excutes region move plans concurrently, which will > affect the availability of relevant tables. And a plan fails will cause the > whole balance plan abort. > As mentioned in master balance issues, HBASE-17178, HBASE-21260 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #190: HBASE-21723 Remove ConnectionImplementation and related classes
Apache-HBase commented on issue #190: HBASE-21723 Remove ConnectionImplementation and related classes URL: https://github.com/apache/hbase/pull/190#issuecomment-496045000 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 43 | https://github.com/apache/hbase/pull/190 does not apply to HBASE-21512. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/190 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-190/10/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22476) HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.
[
https://issues.apache.org/jira/browse/HBASE-22476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lixiaobao updated HBASE-22476:
--
Attachment: HBASE-22476.patch
Status: Patch Available (was: Open)
> HBase-backup module's class
> "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not
> close.
> -
>
> Key: HBASE-22476
> URL: https://issues.apache.org/jira/browse/HBASE-22476
> Project: HBase
> Issue Type: Bug
> Components: backuprestore
>Affects Versions: 2.1.4, 2.1.0
>Reporter: lixiaobao
>Assignee: lixiaobao
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22476.patch
>
>
> class "org.apache.hadoop.hbase.backup.impl.BackupManifest" constructe function
> public BackupManifest(FileSystem fs, Path backupPath) throws BackupException
> \{...}
> FSDataInputStream is not close after use.
> {code:java}
> //代码占位符
> if (subFile.getPath().getName().equals(MANIFEST_FILE_NAME)) {
> // load and set manifest field from file content
> FSDataInputStream in = fs.open(subFile.getPath());
> long len = subFile.getLen();
> byte[] pbBytes = new byte[(int) len];
> in.readFully(pbBytes);
> BackupProtos.BackupImage proto = null;
> try {
> proto = BackupProtos.BackupImage.parseFrom(pbBytes);
> } catch (Exception e) {
> throw new BackupException(e);
> }
> this.backupImage = BackupImage.fromProto(proto);
> LOG.debug("Loaded manifest instance from manifest file: "
> + BackupUtils.getPath(subFile.getPath()));
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22473) Split TestSCP
[ https://issues.apache.org/jira/browse/HBASE-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22473. --- Resolution: Fixed Assignee: Duo Zhang Hadoop Flags: Reviewed Pushed to branch-2.2+. Thanks [~psomogyi] for reviewing. > Split TestSCP > - > > Key: HBASE-22473 > URL: https://issues.apache.org/jira/browse/HBASE-22473 > Project: HBase > Issue Type: Bug > Components: Recovery, test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > > It is time consuming. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22476) HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.
lixiaobao created HBASE-22476:
-
Summary: HBase-backup module's class
"org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not
close.
Key: HBASE-22476
URL: https://issues.apache.org/jira/browse/HBASE-22476
Project: HBase
Issue Type: Bug
Components: backuprestore
Affects Versions: 2.1.4, 2.1.0
Reporter: lixiaobao
Assignee: lixiaobao
Fix For: 3.0.0
class "org.apache.hadoop.hbase.backup.impl.BackupManifest" constructe function
public BackupManifest(FileSystem fs, Path backupPath) throws BackupException
\{...}
FSDataInputStream is not close after use.
{code:java}
//代码占位符
if (subFile.getPath().getName().equals(MANIFEST_FILE_NAME)) {
// load and set manifest field from file content
FSDataInputStream in = fs.open(subFile.getPath());
long len = subFile.getLen();
byte[] pbBytes = new byte[(int) len];
in.readFully(pbBytes);
BackupProtos.BackupImage proto = null;
try {
proto = BackupProtos.BackupImage.parseFrom(pbBytes);
} catch (Exception e) {
throw new BackupException(e);
}
this.backupImage = BackupImage.fromProto(proto);
LOG.debug("Loaded manifest instance from manifest file: "
+ BackupUtils.getPath(subFile.getPath()));
return;
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22473) Split TestSCP
[ https://issues.apache.org/jira/browse/HBASE-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22473: -- Fix Version/s: 2.2.1 2.3.0 3.0.0 > Split TestSCP > - > > Key: HBASE-22473 > URL: https://issues.apache.org/jira/browse/HBASE-22473 > Project: HBase > Issue Type: Bug > Components: Recovery, test >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > > It is time consuming. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22456) Polish TestSplitTransitionOnCluster
[ https://issues.apache.org/jira/browse/HBASE-22456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22456: -- Fix Version/s: (was: 2.2.0) 2.2.1 > Polish TestSplitTransitionOnCluster > --- > > Key: HBASE-22456 > URL: https://issues.apache.org/jira/browse/HBASE-22456 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22456.patch > > > Remove the compaction state check in > TestSplitTransitionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor, > as region.compact is a synchronous call, we will only return when the > compaction is finished. And not sure why we do not wait for the split to > finish in this test, before getting the daughter regions... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 commented on a change in pull request #253: HBASE-22473 Split TestSCP
Apache9 commented on a change in pull request #253: HBASE-22473 Split TestSCP
URL: https://github.com/apache/hbase/pull/253#discussion_r287619836
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestSCPWithMetaWithReplicasWithoutZKCoordinated.java
##
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.procedure;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.junit.ClassRule;
+import org.junit.experimental.categories.Category;
+
+@Category({ MasterTests.class, LargeTests.class })
+public class TestSCPWithMetaWithReplicasWithoutZKCoordinated extends
TestSCPWithMetaWithReplicas {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+
HBaseClassTestRule.forClass(TestSCPWithMetaWithReplicasWithoutZKCoordinated.class);
+
+ @Override
+ protected void setupConf(Configuration conf) {
+super.setupConf(conf);
+conf.setBoolean(HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK, false);
Review comment:
There is no new code here, the only problem is that the test method for
killing rs carrying meta is time consuming, so I split them into individual
test classes so we do not timeout...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #253: HBASE-22473 Split TestSCP
Apache9 merged pull request #253: HBASE-22473 Split TestSCP URL: https://github.com/apache/hbase/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22475) Nightly integration test fails with NoClassDefFoundError
[
https://issues.apache.org/jira/browse/HBASE-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848551#comment-16848551
]
Duo Zhang commented on HBASE-22475:
---
https://builds.apache.org/job/HBase%20Nightly/job/master/1037/artifact/output-integration/hadoop-2.log
{noformat}
Hadoop version information:
Hadoop 2.7.1
Subversion https://git-wip-us.apache.org/repos/asf/hadoop.git -r
15ecc87ccf4a0228f35af08fc56de536e6ce657a
Compiled by jenkins on 2015-06-29T06:04Z
Compiled with protoc 2.5.0
>From source with checksum fc0a1a23fc1868e4d5ee7fa2b28a58a
This command was run using
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hadoop-2/share/hadoop/common/hadoop-common-2.7.1.jar
{noformat}
In hadoop-2.log we are still using 2.7.1...
> Nightly integration test fails with NoClassDefFoundError
>
>
> Key: HBASE-22475
> URL: https://issues.apache.org/jira/browse/HBASE-22475
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0
>
>
> On Nightly the packaging and integration step fails when executing
> hbase_nightly_pseudo-distributed-test.sh. The create table step fails
> NoClassDefFoundError when starting the shell.
> [https://builds.apache.org/job/HBase%20Nightly/job/master/1037/artifact/output-integration/hadoop-2/table_create.log]
> {noformat}
> LoadError: load error: hbase/hbase -- java.lang.NoClassDefFoundError:
> org/codehaus/jackson/JsonGenerator
> require at org/jruby/RubyKernel.java:956
> require at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/lib/ruby/hbase_constants.rb:117
> require at org/jruby/RubyKernel.java:956
>(root) at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/bin/../bin/hirb.rb:131{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #250: HBASE-22451 TestLoadIncrementalHFiles and TestSecureLoadIncrementalHFiles are flaky
Apache-HBase commented on issue #250: HBASE-22451 TestLoadIncrementalHFiles and TestSecureLoadIncrementalHFiles are flaky URL: https://github.com/apache/hbase/pull/250#issuecomment-496036976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1181 | Docker mode activated. | ||| _ Prechecks _ | | 0 | findbugs | 0 | Findbugs executables are not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 185 | branch-1 passed | | +1 | compile | 48 | branch-1 passed with JDK v1.8.0_212 | | +1 | compile | 50 | branch-1 passed with JDK v1.7.0_222 | | +1 | checkstyle | 94 | branch-1 passed | | +1 | shadedjars | 188 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | branch-1 passed with JDK v1.8.0_212 | | +1 | javadoc | 48 | branch-1 passed with JDK v1.7.0_222 | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 129 | the patch passed | | +1 | compile | 50 | the patch passed with JDK v1.8.0_212 | | +1 | javac | 50 | the patch passed | | +1 | compile | 53 | the patch passed with JDK v1.7.0_222 | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 99 | the patch passed | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedjars | 216 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 309 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 37 | the patch passed with JDK v1.8.0_212 | | +1 | javadoc | 48 | the patch passed with JDK v1.7.0_222 | ||| _ Other Tests _ | | +1 | unit | 9196 | hbase-server in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 17070 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-250/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/250 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 02d9253aa87b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-1 / 68a0160 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_222 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-250/3/testReport/ | | Max. process+thread count | 4330 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-250/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22475) Nightly integration test fails with NoClassDefFoundError
[
https://issues.apache.org/jira/browse/HBASE-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848541#comment-16848541
]
Sean Busbey commented on HBASE-22475:
-
This is fallout from the combination of our Jackson upgrade in HBase 2 and
updating our Hadoop 2 version to 2.8. we had a similar CNFE in a rest module
test. Essentially it depends on if some static methods in Configuration get
touched.
Does the Hadoop 2 we bundle include Jackson jars? Is the failed test relying on
our packages Hadoop or the Hadoop executable?
> Nightly integration test fails with NoClassDefFoundError
>
>
> Key: HBASE-22475
> URL: https://issues.apache.org/jira/browse/HBASE-22475
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0
>
>
> On Nightly the packaging and integration step fails when executing
> hbase_nightly_pseudo-distributed-test.sh. The create table step fails
> NoClassDefFoundError when starting the shell.
> [https://builds.apache.org/job/HBase%20Nightly/job/master/1037/artifact/output-integration/hadoop-2/table_create.log]
> {noformat}
> LoadError: load error: hbase/hbase -- java.lang.NoClassDefFoundError:
> org/codehaus/jackson/JsonGenerator
> require at org/jruby/RubyKernel.java:956
> require at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/lib/ruby/hbase_constants.rb:117
> require at org/jruby/RubyKernel.java:956
>(root) at
> uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
> at
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/bin/../bin/hirb.rb:131{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848538#comment-16848538
]
Hudson commented on HBASE-22474:
Results for branch branch-2
[build #1919 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1919/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1919//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1919//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1919//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1919//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21920) Ignoring 'empty' end_key while calculating end_key for new region in HBCK -fixHdfsOverlaps command can cause data loss
[
https://issues.apache.org/jira/browse/HBASE-21920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848531#comment-16848531
]
Toshihiro Suzuki commented on HBASE-21920:
--
Sorry [~arshiya9414]. I just noticed this. I will review it.
> Ignoring 'empty' end_key while calculating end_key for new region in HBCK
> -fixHdfsOverlaps command can cause data loss
> --
>
> Key: HBASE-21920
> URL: https://issues.apache.org/jira/browse/HBASE-21920
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.0.0
>Reporter: Syeda Arshiya Tabreen
>Assignee: Syeda Arshiya Tabreen
>Priority: Major
> Attachments: HBASE-21920.branch-1.001.patch,
> HBASE-21920.branch-1.002.patch, HBASE-21920.branch-1.002.patch,
> HBASE-21920.branch-1.002.patch, HBASE-21920.branch-1.patch
>
>
> When running *-fixHdfsOverlaps* command due to overlap in the regions of the
> table ,it moves all the hfiles of overlapping regions into new region with
> start_key and end_key calculating based on minimum and maximum start_key and
> end_key of all overlapping regions.
> When calculating start_key and end_key for new region,end_key with 'empty' is
> not considered which leads to data loss when scanned using '*startrow'.*
> *For example:*
> 1.create table 't'
> 2.Insert records \{00,111,200} into the table 't'and flush the data
> 3.split the table 't' with split-key '100'
> 4.Now we have three regions( 1 parent and two daughter regions )
> 1.*Region-1*('Empty','Empty') => \{00,111,200}
> 2.*Region-2*('Empty','100')=>\{00}
> 3.*Region-3*('100','Empty')=>\{111,200}
> 5.Make sure parent region is not deleted in file system and run
> -*fixHdfsOverlaps* command
> This -*fixHdfsOverlaps* command will move all the hfiles of the three regions
> {*Region-1,Region- 2,Region-3*} into a new region(*Region-4*) created with
> start_key='*Empty'* and end_key='*100'*
> This is because it does not consider end_key=*'Empty'* and considers
> end_key=*'100'* as maximum which in turn makes all the hfiles of three
> regions to move into new region even if records in hfile is more than the
> end_key='*100'* and one empty region *Region -5 (100,Empty)* will be
> created because table region end key was not empty.
> Now we have 2 regions:
> 1.*Region-4*(Empty,100)=>\{00,111,200}
> 2.*Region-5*(100,Empty)=>{}
> when the entire table scan is done, all the records will be displayed, there
> wont be any data loss but scan with start_key is done below are the results:
> 1.scan 't', \{ STARTROW => '00'} => \{00,111,200}
> 2.scan 't', \{ STARTROW => '100'}=>{}
> The second scan will give empty result because it searches the rows in
> *Region -5*(100,Empty) which contains no records but records \{111,200} is
> present in *Region-4*(Empty,100).
> The problem exists only when end_key=*'Empty'* is present in any of the
> overlapping regions.I think if end_key is present in any of the overlapping
> regions,we have to consider it as maximum end_key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848526#comment-16848526
]
Hudson commented on HBASE-22474:
Results for branch branch-2.1
[build #1194 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1194/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1194//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1194//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1194//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848525#comment-16848525
]
Hudson commented on HBASE-22474:
Results for branch branch-2.2
[build #289 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/289/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/289//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/289//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/289//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/289//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848523#comment-16848523
]
Hudson commented on HBASE-22474:
Results for branch branch-1.4
[build #815 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/815/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/815//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/815//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/815//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848514#comment-16848514
]
Hudson commented on HBASE-22474:
Results for branch branch-2.0
[build #1620 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1620/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1620//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1620//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1620//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848509#comment-16848509
]
Hudson commented on HBASE-22474:
Results for branch master
[build #1038 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1038/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1038//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1038//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1038//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1038//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #253: HBASE-22473 Split TestSCP
Apache-HBase commented on issue #253: HBASE-22473 Split TestSCP URL: https://github.com/apache/hbase/pull/253#issuecomment-496025005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 11 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 270 | master passed | | +1 | compile | 50 | master passed | | +1 | checkstyle | 73 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 166 | master passed | | +1 | javadoc | 33 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 246 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 265 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1005 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 168 | the patch passed | | +1 | javadoc | 32 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14210 | hbase-server in the patch failed. | | +1 | asflicense | 39 | The patch does not generate ASF License warnings. | | | | 17332 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/253 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 92f2e0cee2ac 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 27c02a0b95 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/testReport/ | | Max. process+thread count | 4735 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848506#comment-16848506
]
Hudson commented on HBASE-22474:
Results for branch branch-1
[build #853 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/853/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/853//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/853//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/853//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[
https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848505#comment-16848505
]
Hudson commented on HBASE-22474:
Results for branch branch-1.3
[build #786 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/786/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/786//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/786//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/786//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add --mvn-custom-repo parameter to yetus calls
> --
>
> Key: HBASE-22474
> URL: https://issues.apache.org/jira/browse/HBASE-22474
> Project: HBase
> Issue Type: Improvement
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
>
> PreCommit validation from yetus uses a shared .m2 repository. By adding
> --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2
> directory for executions for PR validations.
> [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848497#comment-16848497 ] Toshihiro Suzuki commented on HBASE-22160: -- [~daisuke.kobayashi] Sorry, I found one thing when I re-tested this patch. It looks like we can't sort "Last Major Compaction" field in "Compaction Metrics". Can you please check this? > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, Screen Shot > 2019-04-03 at 15.56.02.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22475) Nightly integration test fails with NoClassDefFoundError
Peter Somogyi created HBASE-22475:
-
Summary: Nightly integration test fails with NoClassDefFoundError
Key: HBASE-22475
URL: https://issues.apache.org/jira/browse/HBASE-22475
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 3.0.0, 2.2.0
Reporter: Peter Somogyi
Assignee: Peter Somogyi
Fix For: 3.0.0, 2.2.0
On Nightly the packaging and integration step fails when executing
hbase_nightly_pseudo-distributed-test.sh. The create table step fails
NoClassDefFoundError when starting the shell.
[https://builds.apache.org/job/HBase%20Nightly/job/master/1037/artifact/output-integration/hadoop-2/table_create.log]
{noformat}
LoadError: load error: hbase/hbase -- java.lang.NoClassDefFoundError:
org/codehaus/jackson/JsonGenerator
require at org/jruby/RubyKernel.java:956
require at
uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:55
at
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/lib/ruby/hbase_constants.rb:117
require at org/jruby/RubyKernel.java:956
(root) at
uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
at
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master-4PMG3QPNOXT5YRQZS7HMZP3GLNX6XSF6DVHYXYIB5BWQ75VW3CPA/hbase-client/bin/../bin/hirb.rb:131{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] petersomogyi commented on a change in pull request #253: HBASE-22473 Split TestSCP
petersomogyi commented on a change in pull request #253: HBASE-22473 Split
TestSCP
URL: https://github.com/apache/hbase/pull/253#discussion_r287607990
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestSCPWithMetaWithReplicasWithoutZKCoordinated.java
##
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.procedure;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.junit.ClassRule;
+import org.junit.experimental.categories.Category;
+
+@Category({ MasterTests.class, LargeTests.class })
+public class TestSCPWithMetaWithReplicasWithoutZKCoordinated extends
TestSCPWithMetaWithReplicas {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+
HBaseClassTestRule.forClass(TestSCPWithMetaWithReplicasWithoutZKCoordinated.class);
+
+ @Override
+ protected void setupConf(Configuration conf) {
+super.setupConf(conf);
+conf.setBoolean(HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK, false);
Review comment:
Good! Looks like this wasn't tested before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848486#comment-16848486
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #242 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/242/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/242//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/242//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/242//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/242//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[ https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848483#comment-16848483 ] Hudson commented on HBASE-22474: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #563 (See [https://builds.apache.org/job/HBase-1.3-IT/563/]) HBASE-22474 Add --mvn-custom-repo parameter to yetus calls (psomogyi: rev c62015174e393e99fa00a7a43caf2b02eb613fc4) * (edit) dev-support/Jenkinsfile_GitHub > Add --mvn-custom-repo parameter to yetus calls > -- > > Key: HBASE-22474 > URL: https://issues.apache.org/jira/browse/HBASE-22474 > Project: HBase > Issue Type: Improvement >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5 > > > PreCommit validation from yetus uses a shared .m2 repository. By adding > --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2 > directory for executions for PR validations. > [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[ https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22474: -- Resolution: Fixed Fix Version/s: 1.3.5 2.1.5 2.0.6 1.4.10 2.2.0 1.5.0 3.0.0 Status: Resolved (was: Patch Available) Thanks for reviewing [~Apache9]! > Add --mvn-custom-repo parameter to yetus calls > -- > > Key: HBASE-22474 > URL: https://issues.apache.org/jira/browse/HBASE-22474 > Project: HBase > Issue Type: Improvement >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5 > > > PreCommit validation from yetus uses a shared .m2 repository. By adding > --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2 > directory for executions for PR validations. > [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] petersomogyi merged pull request #252: HBASE-22474 Add --mvn-custom-repo parameter to yetus calls
petersomogyi merged pull request #252: HBASE-22474 Add --mvn-custom-repo parameter to yetus calls URL: https://github.com/apache/hbase/pull/252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #252: HBASE-22474 Add --mvn-custom-repo parameter to yetus calls
Apache-HBase commented on issue #252: HBASE-22474 Add --mvn-custom-repo parameter to yetus calls URL: https://github.com/apache/hbase/pull/252#issuecomment-496011296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 57 | Docker mode activated. | ||| _ Prechecks _ | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 4965 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-252/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/252 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux 7bc0792f2297 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 27c02a0b95 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | shellcheck | v0.4.4 | | Max. process+thread count | 42 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-252/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support
petersomogyi commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support URL: https://github.com/apache/hbase/pull/239#discussion_r287601588 ## File path: src/main/site/site.xml ## @@ -77,12 +77,17 @@ - - - - - - + + + + + + + Review comment: Do we need 1.1 Documentation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support
petersomogyi commented on a change in pull request #239: HBASE-22409 update
branch-1 ref guide for Hadoop, Java, and HBase version support
URL: https://github.com/apache/hbase/pull/239#discussion_r287601604
##
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##
@@ -81,20 +83,27 @@ To see the usage, use the `--help` parameter.
$ ${HBASE_HOME}/bin/hbase canary -help
-Usage: bin/hbase org.apache.hadoop.hbase.tool.Canary [opts] [table1
[table2]...] | [regionserver1 [regionserver2]..]
+Usage: hbase org.apache.hadoop.hbase.tool.Canary [opts] [table1 [table2]...] |
[regionserver1 [regionserver2]..]
where [opts] are:
-help Show this help and exit.
-regionserver replace the table argument to regionserver,
which means to enable regionserver mode
+ -allRegionsTries all regions on a regionserver,
+ only works in regionserver mode.
+ -zookeeperTries to grab zookeeper.znode.parent
+ on each zookeeper instance
-daemonContinuous check at defined intervals.
Review comment:
This option is missing from the help message:
```
-permittedZookeeperFailures Ignore first N failures when attempting
to
connect to individual zookeeper nodes in the ensemble```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848454#comment-16848454
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #114 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/114/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/114//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/114//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/114//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #253: HBASE-22473 Split TestSCP
Apache9 opened a new pull request #253: HBASE-22473 Split TestSCP URL: https://github.com/apache/hbase/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
[ https://issues.apache.org/jira/browse/HBASE-22474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22474: -- Status: Patch Available (was: Open) > Add --mvn-custom-repo parameter to yetus calls > -- > > Key: HBASE-22474 > URL: https://issues.apache.org/jira/browse/HBASE-22474 > Project: HBase > Issue Type: Improvement >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > > PreCommit validation from yetus uses a shared .m2 repository. By adding > --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2 > directory for executions for PR validations. > [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] petersomogyi opened a new pull request #252: HBASE-22474 Add --mvn-custom-repo parameter to yetus calls
petersomogyi opened a new pull request #252: HBASE-22474 Add --mvn-custom-repo parameter to yetus calls URL: https://github.com/apache/hbase/pull/252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22474) Add --mvn-custom-repo parameter to yetus calls
Peter Somogyi created HBASE-22474: - Summary: Add --mvn-custom-repo parameter to yetus calls Key: HBASE-22474 URL: https://issues.apache.org/jira/browse/HBASE-22474 Project: HBase Issue Type: Improvement Reporter: Peter Somogyi Assignee: Peter Somogyi PreCommit validation from yetus uses a shared .m2 repository. By adding --mvn-custom-repo and --jenkins paramters yetus will use a custom .m2 directory for executions for PR validations. [https://yetus.apache.org/documentation/0.9.0/precommit-buildtools/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] petersomogyi commented on issue #250: HBASE-22451 TestLoadIncrementalHFiles and TestSecureLoadIncrementalHFiles are flaky
petersomogyi commented on issue #250: HBASE-22451 TestLoadIncrementalHFiles and
TestSecureLoadIncrementalHFiles are flaky
URL: https://github.com/apache/hbase/pull/250#issuecomment-496003871
The workspace is clean before the job but it looks like ${HOME}.m2 is shared
on the host which could cause similar issues.
The current call to yetus test-patch call does not have `--mvn-custom-repo`
parameter. Let me create an issue for this.
I've retriggered this execution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-22473) Split TestSCP
[ https://issues.apache.org/jira/browse/HBASE-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22473: -- Summary: Split TestSCP (was: Separate TestSCP.testRecoveryAndDoubleExecutionOnRsWithMeta) > Split TestSCP > - > > Key: HBASE-22473 > URL: https://issues.apache.org/jira/browse/HBASE-22473 > Project: HBase > Issue Type: Bug > Components: Recovery, test >Reporter: Duo Zhang >Priority: Major > > It is time consuming. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22456) Polish TestSplitTransitionOnCluster
[
https://issues.apache.org/jira/browse/HBASE-22456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848399#comment-16848399
]
Hudson commented on HBASE-22456:
Results for branch branch-2
[build #1918 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1918/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1918//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1918//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1918//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1918//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Polish TestSplitTransitionOnCluster
> ---
>
> Key: HBASE-22456
> URL: https://issues.apache.org/jira/browse/HBASE-22456
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22456.patch
>
>
> Remove the compaction state check in
> TestSplitTransitionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor,
> as region.compact is a synchronous call, we will only return when the
> compaction is finished. And not sure why we do not wait for the split to
> finish in this test, before getting the daughter regions...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22456) Polish TestSplitTransitionOnCluster
[
https://issues.apache.org/jira/browse/HBASE-22456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848394#comment-16848394
]
Hudson commented on HBASE-22456:
Results for branch branch-2.2
[build #288 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/288/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/288//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/288//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/288//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/288//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Polish TestSplitTransitionOnCluster
> ---
>
> Key: HBASE-22456
> URL: https://issues.apache.org/jira/browse/HBASE-22456
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22456.patch
>
>
> Remove the compaction state check in
> TestSplitTransitionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor,
> as region.compact is a synchronous call, we will only return when the
> compaction is finished. And not sure why we do not wait for the split to
> finish in this test, before getting the daughter regions...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22422) Retain an ByteBuff with refCnt=0 when getBlock from LRUCache
[
https://issues.apache.org/jira/browse/HBASE-22422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848366#comment-16848366
]
HBase QA commented on HBASE-22422:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-21879 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
26s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
11s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
23s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
47s{color} | {color:blue} hbase-server in HBASE-21879 has 11 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} HBASE-21879 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
12s{color} | {color:red} hbase-server: The patch generated 1 new + 130
unchanged - 2 fixed = 131 total (was 132) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 25s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}130m
17s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}170m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/419/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22422 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12969803/HBASE-22422.HBASE-21879.v02.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a8b269ea44a8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-21879 / 111c95c11c |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/419/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/419/testReport/ |
| Max. process+thread count | 4895 (vs. ulimit of 1) |
|
[jira] [Created] (HBASE-22473) Separate TestSCP.testRecoveryAndDoubleExecutionOnRsWithMeta
Duo Zhang created HBASE-22473: - Summary: Separate TestSCP.testRecoveryAndDoubleExecutionOnRsWithMeta Key: HBASE-22473 URL: https://issues.apache.org/jira/browse/HBASE-22473 Project: HBase Issue Type: Bug Components: Recovery, test Reporter: Duo Zhang It is time consuming. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22456) Polish TestSplitTransitionOnCluster
[ https://issues.apache.org/jira/browse/HBASE-22456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22456: -- Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Pushed to branch-2.2+. > Polish TestSplitTransitionOnCluster > --- > > Key: HBASE-22456 > URL: https://issues.apache.org/jira/browse/HBASE-22456 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22456.patch > > > Remove the compaction state check in > TestSplitTransitionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor, > as region.compact is a synchronous call, we will only return when the > compaction is finished. And not sure why we do not wait for the split to > finish in this test, before getting the daughter regions... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22472) The newly split TestReplicationStatus* tests are flaky
Duo Zhang created HBASE-22472: - Summary: The newly split TestReplicationStatus* tests are flaky Key: HBASE-22472 URL: https://issues.apache.org/jira/browse/HBASE-22472 Project: HBase Issue Type: Bug Components: Replication, test Reporter: Duo Zhang They are introduced by HBASE-22455, from the original TestReplicationStatus tests. Need to dig more. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22456) Polish TestSplitTransitionOnCluster
[ https://issues.apache.org/jira/browse/HBASE-22456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848352#comment-16848352 ] Duo Zhang commented on HBASE-22456: --- Seems worked. Let me push to all branches. > Polish TestSplitTransitionOnCluster > --- > > Key: HBASE-22456 > URL: https://issues.apache.org/jira/browse/HBASE-22456 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-22456.patch > > > Remove the compaction state check in > TestSplitTransitionOnCluster.testMasterRestartAtRegionSplitPendingCatalogJanitor, > as region.compact is a synchronous call, we will only return when the > compaction is finished. And not sure why we do not wait for the split to > finish in this test, before getting the daughter regions... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22346) scanner priorities/deadline units are invalid for non-huge scanners
[
https://issues.apache.org/jira/browse/HBASE-22346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848349#comment-16848349
]
Hudson commented on HBASE-22346:
Results for branch HBASE-22346
[build #21 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22346/21/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22346/21//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22346/21//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22346/21//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> scanner priorities/deadline units are invalid for non-huge scanners
> ---
>
> Key: HBASE-22346
> URL: https://issues.apache.org/jira/browse/HBASE-22346
> Project: HBase
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: HBASE-22346.01.patch, HBASE-22346.patch
>
>
> I was looking at using the priority (deadline) queue for scanner requests;
> what I see is that AnnotationReadingPriorityFunction, the only impl of the
> deadline function available, implements getDeadline as sqrt of the number of
> next() calls, from HBASE-10993.
> However, CallPriorityComparator.compare, its only caller, adds that
> "deadline" value to the callA.getReceiveTime() in milliseconds...
> That results in some sort of a meaningless value that I assume only make
> sense "by coincidence" for telling apart broad and specific classes of
> scanners... in practice next calls must be in the 1000s before it becomes
> meaningful vs small differences in ReceivedTime
> When there's contention from many scanners, e.g. small scanners for meta, or
> just users creating tons of scanners to the point where requests queue up,
> the actual deadline is not accounted for and the priority function itself is
> meaningless... In fact as queueing increases, it becomes worse because
> receivedtime differences grow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
