[jira] [Commented] (HBASE-22483) Maybe it's better to use 65KB as the default buffer size in ByteBuffAllocator
[ https://issues.apache.org/jira/browse/HBASE-22483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850519#comment-16850519 ] Anoop Sam John commented on HBASE-22483: Good one.. Ya now we try to read the block data into these pooled BBs, it would be better to consider the extra. In BC also, the size of the buckets are chosen like +1KB extra (4+1, 8+1... 64+1,. 512+1).. Adding 1 KB extra is very much fine. > Maybe it's better to use 65KB as the default buffer size in ByteBuffAllocator > - > > Key: HBASE-22483 > URL: https://issues.apache.org/jira/browse/HBASE-22483 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: 121240.stack, BucketCacheWriter-is-busy.png, > checksum-stacktrace.png > > > There're some reason why it's better to choose 64KB as the default buffer > size: > 1. Almost all of the data block have a block size: 64KB + delta, whose delta > is very small, depends on the size of lastKeyValue. If we use the default > hbase.ipc.server.allocator.buffer.size=64KB, then each block will be > allocated as a MultiByteBuff: one 64KB DirectByteBuffer and delta bytes > HeapByteBuffer, the HeapByteBuffer will increase the GC pressure. Ideally, we > should let the data block to be allocated as a SingleByteBuff, it has simpler > data structure, faster access speed, less heap usage... > 2. In my benchmark, I found some checksum stack traces . (see > [checksum-stacktrace.png > |https://issues.apache.org/jira/secure/attachment/12969905/checksum-stacktrace.png]) > > Since the block are MultiByteBuff, so we have to calculate the checksum by > an temp heap copying ( see HBASE-21917), while if we're a SingleByteBuff, we > can speed the checksum by calling the hadoop' checksum in native lib, it's > more faster. > 3. Seems the BucketCacheWriters were always busy because of the higher cost > of copying from MultiByteBuff to DirectByteBuffer. For SingleByteBuff, we > can just use the unsafe array copying while for MultiByteBuff we have to copy > byte one by one. > Anyway, I will give a benchmark for this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22480) Get block from BlockCache once and return this block to BlockCache twice make ref count error.
[ https://issues.apache.org/jira/browse/HBASE-22480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850516#comment-16850516 ] Anoop Sam John commented on HBASE-22480: Patch LGTM. Great find. > Get block from BlockCache once and return this block to BlockCache twice make > ref count error. > -- > > Key: HBASE-22480 > URL: https://issues.apache.org/jira/browse/HBASE-22480 > Project: HBase > Issue Type: Sub-task >Reporter: binlijin >Assignee: binlijin >Priority: Major > Attachments: HBASE-22480-master-v1.patch, > HBASE-22480-master-v2.patch, HBASE-22480-master-v3.patch, > HBASE-22480-master-v4.patch > > > After debugging HBASE-22433, i find the problem it is that we get a block > from BucketCache once and return this block to BucketCache twice and make the > ref count error, sometimes the refCount can be negative. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850515#comment-16850515
]
Hudson commented on HBASE-22467:
Results for branch master
[build #1053 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1053/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1053//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] ramkrish86 commented on a change in pull request #242: HBASE-22422 Retain an ByteBuff with refCnt=0 when getBlock from LRUCache
ramkrish86 commented on a change in pull request #242: HBASE-22422 Retain an
ByteBuff with refCnt=0 when getBlock from LRUCache
URL: https://github.com/apache/hbase/pull/242#discussion_r288398976
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1533,21 +1534,28 @@ public boolean containsKey(BlockCacheKey key) {
}
public RAMQueueEntry get(BlockCacheKey key) {
- RAMQueueEntry re = delegate.get(key);
- if (re != null) {
-// It'll be referenced by RPC, so retain here.
+ return delegate.computeIfPresent(key, (k, re) -> {
+// It'll be referenced by RPC, so retain atomically here. if the get
and retain is not
+// atomic, another thread may remove and release the block, when
retaining in this thread we
+// may retain a block with refCnt=0 which is disallowed. (see
HBASE-22422)
re.getData().retain();
- }
- return re;
+return re;
+ });
}
+/**
+ * Return the previous associated value, or null if absent. It has the
same meaning as
+ * {@link ConcurrentMap#putIfAbsent(Object, Object)}
+ */
public RAMQueueEntry putIfAbsent(BlockCacheKey key, RAMQueueEntry entry) {
- RAMQueueEntry previous = delegate.putIfAbsent(key, entry);
- if (previous == null) {
+ AtomicBoolean absent = new AtomicBoolean(false);
+ RAMQueueEntry re = delegate.computeIfAbsent(key, k -> {
// The RAMCache reference to this entry, so reference count should be
increment.
entry.getData().retain();
- }
- return previous;
+absent.set(true);
+return entry;
+ });
+ return absent.get() ? null : re;
Review comment:
I think I got it now. You have changed the get() to computeIfPresent(). So
if the remove has already removed the entry then the get() cannot do a
retain(). So a similar change is also needed for putIfAbsent() also? Rest looks
good to me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #262: HBASE-22488 Cleanup the explicit timeout value for test methods
Apache-HBase commented on issue #262: HBASE-22488 Cleanup the explicit timeout value for test methods URL: https://github.com/apache/hbase/pull/262#issuecomment-496784087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 159 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 11 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for branch | | +1 | mvninstall | 275 | master passed | | +1 | compile | 107 | master passed | | +1 | checkstyle | 110 | master passed | | +1 | shadedjars | 358 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 444 | master passed | | +1 | javadoc | 76 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 251 | the patch passed | | +1 | compile | 78 | the patch passed | | +1 | javac | 78 | the patch passed | | +1 | checkstyle | 85 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 312 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1401 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 240 | the patch passed | | +1 | javadoc | 50 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 78 | hbase-http in the patch passed. | | -1 | unit | 8880 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 13402 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-262/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/262 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fe8713a8be65 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 858d30dd30 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-262/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-262/2/testReport/ | | Max. process+thread count | 4673 (vs. ulimit of 1) | | modules | C: hbase-http hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-262/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ramkrish86 commented on a change in pull request #242: HBASE-22422 Retain an ByteBuff with refCnt=0 when getBlock from LRUCache
ramkrish86 commented on a change in pull request #242: HBASE-22422 Retain an
ByteBuff with refCnt=0 when getBlock from LRUCache
URL: https://github.com/apache/hbase/pull/242#discussion_r288391398
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1533,21 +1534,28 @@ public boolean containsKey(BlockCacheKey key) {
}
public RAMQueueEntry get(BlockCacheKey key) {
- RAMQueueEntry re = delegate.get(key);
- if (re != null) {
-// It'll be referenced by RPC, so retain here.
+ return delegate.computeIfPresent(key, (k, re) -> {
+// It'll be referenced by RPC, so retain atomically here. if the get
and retain is not
+// atomic, another thread may remove and release the block, when
retaining in this thread we
+// may retain a block with refCnt=0 which is disallowed. (see
HBASE-22422)
re.getData().retain();
- }
- return re;
+return re;
+ });
}
+/**
+ * Return the previous associated value, or null if absent. It has the
same meaning as
+ * {@link ConcurrentMap#putIfAbsent(Object, Object)}
+ */
public RAMQueueEntry putIfAbsent(BlockCacheKey key, RAMQueueEntry entry) {
- RAMQueueEntry previous = delegate.putIfAbsent(key, entry);
- if (previous == null) {
+ AtomicBoolean absent = new AtomicBoolean(false);
+ RAMQueueEntry re = delegate.computeIfAbsent(key, k -> {
// The RAMCache reference to this entry, so reference count should be
increment.
entry.getData().retain();
- }
- return previous;
+absent.set(true);
+return entry;
+ });
+ return absent.get() ? null : re;
}
public boolean remove(BlockCacheKey key) {
Review comment:
While removing the atomicity is not needed? Because we do computeIfAbsent
and that is already now atomically guarded?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information
[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850493#comment-16850493
]
Hudson commented on HBASE-22469:
Results for branch master
[build #1052 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1052/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1052//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
>
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we
> long retired md5 from the releases, it makes sense to replace hbase version
> information as well. I also noticed that revision doesn't always show, case
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only
> appears if the compiled code was cloned from git and not a release candidate
> download file. In that sense, release candidates should be checked out rather
> than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850478#comment-16850478 ] Daisuke Kobayashi commented on HBASE-22160: --- Thanks for checking and catching that part, carefully [~brfrn169]! I managed to be able to sort the field as attached: !Screen Shot 2019-05-28 at 6.45.46 PM.png! I had to wrap the timezone info. in parentheses to make the field sortable. Hope this does not break anything [~pho] brought. I will attach a new patch if there's no problem. > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HBASE-22160: -- Attachment: Screen Shot 2019-05-28 at 6.45.46 PM.png > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22490) Nightly client integration test fails with hadoop-3.0.3
[
https://issues.apache.org/jira/browse/HBASE-22490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-22490:
--
Description:
{noformat}
2019-05-28 15:27:10,107 WARN common.Storage: Storage directory
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-integration/hadoop-3/target/test/data/dfs/name-0-1
does not exist
2019-05-28 15:27:10,109 WARN namenode.FSNamesystem: Encountered exception
loading fsimage
org.apache.hadoop.hdfs.server.common.InconsistentFSStateException: Directory
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-integration/hadoop-3/target/test/data/dfs/name-0-1
is in an inconsistent state: storage directory does not exist or is not
accessible.
at
org.apache.hadoop.hdfs.server.namenode.FSImage.recoverStorageDirs(FSImage.java:376)
at
org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:227)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:1074)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:706)
at
org.apache.hadoop.hdfs.server.namenode.NameNode.loadNamesystem(NameNode.java:628)
at
org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:690)
at
org.apache.hadoop.hdfs.server.namenode.NameNode.(NameNode.java:919)
at
org.apache.hadoop.hdfs.server.namenode.NameNode.(NameNode.java:892)
at
org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1622)
at
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1305)
at
org.apache.hadoop.hdfs.MiniDFSCluster.configureNameService(MiniDFSCluster.java:1074)
at
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:949)
at
org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:881)
at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:514)
at
org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:473)
at
org.apache.hadoop.mapreduce.MiniHadoopClusterManager.start(MiniHadoopClusterManager.java:160)
at
org.apache.hadoop.mapreduce.MiniHadoopClusterManager.run(MiniHadoopClusterManager.java:132)
at
org.apache.hadoop.mapreduce.MiniHadoopClusterManager.main(MiniHadoopClusterManager.java:320)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
at
org.apache.hadoop.test.MapredTestDriver.run(MapredTestDriver.java:139)
at
org.apache.hadoop.test.MapredTestDriver.main(MapredTestDriver.java:147)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:244)
at org.apache.hadoop.util.RunJar.main(RunJar.java:158)
{noformat}
> Nightly client integration test fails with hadoop-3.0.3
> ---
>
> Key: HBASE-22490
> URL: https://issues.apache.org/jira/browse/HBASE-22490
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> {noformat}
> 2019-05-28 15:27:10,107 WARN common.Storage: Storage directory
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-integration/hadoop-3/target/test/data/dfs/name-0-1
> does not exist
> 2019-05-28 15:27:10,109 WARN namenode.FSNamesystem: Encountered exception
> loading fsimage
> org.apache.hadoop.hdfs.server.common.InconsistentFSStateException: Directory
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-integration/hadoop-3/target/test/data/dfs/name-0-1
> is in an inconsistent state: storage directory does not exist or is not
> accessible.
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.recoverStorageDirs(FSImage.java:376)
> at
> org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:227)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:1074)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:706)
> at
>
[jira] [Updated] (HBASE-22490) Nightly client integration test fails with hadoop-3.0.3
[ https://issues.apache.org/jira/browse/HBASE-22490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22490: -- Component/s: build > Nightly client integration test fails with hadoop-3.0.3 > --- > > Key: HBASE-22490 > URL: https://issues.apache.org/jira/browse/HBASE-22490 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22490) Nightly client integration test fails with hadoop-3.0.3
Duo Zhang created HBASE-22490: - Summary: Nightly client integration test fails with hadoop-3.0.3 Key: HBASE-22490 URL: https://issues.apache.org/jira/browse/HBASE-22490 Project: HBase Issue Type: Bug Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] anoopsjohn commented on a change in pull request #257: HBASE-22463 Some paths in HFileScannerImpl did not consider block#release which will exhaust the ByteBuffAllocator
anoopsjohn commented on a change in pull request #257: HBASE-22463 Some paths
in HFileScannerImpl did not consider block#release which will exhaust the
ByteBuffAllocator
URL: https://github.com/apache/hbase/pull/257#discussion_r288383942
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
##
@@ -520,20 +520,18 @@ public HFileScannerImpl(final HFile.Reader reader, final
boolean cacheBlocks,
}
void updateCurrBlockRef(HFileBlock block) {
- if (block != null && this.curBlock != null &&
- block.getOffset() == this.curBlock.getOffset()) {
+ if (block != null && curBlock != null && block.getOffset() ==
curBlock.getOffset()) {
return;
}
- // We don't have to keep ref to EXCLUSIVE type of block
- if (this.curBlock != null && this.curBlock.usesSharedMemory()) {
Review comment:
There is a concern here. Even if the block is on an exclusive heap memory
area, we will keep ref to that in this list. In a Phoenix Aggregation kind of
use case where many blocks might get fetched and not immediately shipped, we
are keeping the ref unwantedly here for longer time. This makes the GC not able
to reclaim the heap memory area for the blocks. This might be a hidden bomb
IMO. Its not good to remove the MemType. Lets create the block with memory
type as EXCLUSIVE when the block data is on heap. The block might be coming
from LRU cache or by fetching the block data from HDFS into heap memory area.
When the block comes from off heap BC or if it is backed by a BB from the pool
(While reading from HDFS, read into pooled BB) lets create the block with mem
type as SHARED. Every block can have the retain and release method but let
the EXCLUSIVE types do a noop here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[ https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22471: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: (was: 2.0.6) Status: Resolved (was: Patch Available) Pushed to branch-2.1+. Thanks [~busbey] for reviewing. > Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in > integration test > - > > Key: HBASE-22471 > URL: https://issues.apache.org/jira/browse/HBASE-22471 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.6 > > Attachments: HBASE-22471.patch > > > We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1 > jars are already there for a long time. We need to clean the workspace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[ https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22471: -- Fix Version/s: (was: 2.2.1) 2.1.6 2.0.6 2.2.0 > Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in > integration test > - > > Key: HBASE-22471 > URL: https://issues.apache.org/jira/browse/HBASE-22471 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.6 > > Attachments: HBASE-22471.patch > > > We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1 > jars are already there for a long time. We need to clean the workspace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[ https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850420#comment-16850420 ] Duo Zhang commented on HBASE-22471: --- [~zghaobac] Seems we still need to hold on releasing 2.2.0... > Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in > integration test > - > > Key: HBASE-22471 > URL: https://issues.apache.org/jira/browse/HBASE-22471 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22471.patch > > > We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1 > jars are already there for a long time. We need to clean the workspace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[ https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850419#comment-16850419 ] Duo Zhang commented on HBASE-22471: --- Let me commit this first and then open new issue to address the hadoop 3 problem. > Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in > integration test > - > > Key: HBASE-22471 > URL: https://issues.apache.org/jira/browse/HBASE-22471 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22471.patch > > > We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1 > jars are already there for a long time. We need to clean the workspace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup
[
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850406#comment-16850406
]
HBase QA commented on HBASE-22411:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
40s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
26s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 13s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
19s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/441/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970099/HBASE-22411.branch-2.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3e3f8ebc5354 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 4f05b22880 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/441/testReport/ |
| Max. process+thread count | 4365 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
[jira] [Commented] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[ https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850405#comment-16850405 ] Duo Zhang commented on HBASE-22471: --- OK, now we fail with hadoop3... > Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in > integration test > - > > Key: HBASE-22471 > URL: https://issues.apache.org/jira/browse/HBASE-22471 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22471.patch > > > We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1 > jars are already there for a long time. We need to clean the workspace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850404#comment-16850404
]
Hudson commented on HBASE-22467:
Results for branch branch-2.1
[build #1203 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1203//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22489) When regionServer stopping open region cause server aborting
[
https://issues.apache.org/jira/browse/HBASE-22489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850394#comment-16850394
]
binlijin commented on HBASE-22489:
--
When regionserver stopping, throw wrong max sequence id also aborting
regionserver
{code}
Tue May 28 23:06:31 CST 2019 Terminating regionserver
2019-05-28 23:06:31,873 INFO [Thread-5] regionserver.ShutdownHook: Shutdown
hook starting; hbase.shutdown.hook=true;
fsShutdownHook=org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@26d96e5
2019-05-28 23:06:31,873 INFO [Thread-5] regionserver.HRegionServer: *
STOPPING region server '10.11.45.152,16020,1559046718578' *
2019-05-28 23:06:31,873 INFO [Thread-5] regionserver.HRegionServer: STOPPED:
Shutdown hook
2019-05-28 23:06:31,950 ERROR
[RS_CLOSE_REGION-regionserver/hbaseperf-4:16020-6] regionserver.HRegionServer:
* ABORTING region server 10.11.45.152,16020,1559046718578: Unrecoverable
exception while closing region
user,a4432394ed8-dca3-4eab-a61f-86541787b600155854,1559023636867.770e1f69047d51d90cc24a6b5927458d.,
still finishing close *
java.io.IOException: The new max sequence id 9187005 is less than the old max
sequence id 9187006
at
org.apache.hadoop.hbase.wal.WALSplitter.writeRegionSequenceIdFile(WALSplitter.java:684)
at
org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1177)
at
org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1709)
at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1526)
at
org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:110)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
> When regionServer stopping open region cause server aborting
>
>
> Key: HBASE-22489
> URL: https://issues.apache.org/jira/browse/HBASE-22489
> Project: HBase
> Issue Type: Bug
>Reporter: binlijin
>Priority: Major
>
> When regionserver stopping, region open will ABORTING regionserver, need to
> take care it.
> {code}
> 2019-05-28 20:32:48,672 WARN
> [RS_OPEN_REGION-regionserver/hbaseperf-8:16020-15]
> handler.AssignRegionHandler: Fatal error occurred while opening region
> user,f768,1559033479968.6f1508a4480447698cf8b04cd850698f., aborting...
> org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: Server
> 10.11.45.52,16020,1559046489201 stopping
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1505)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2206)
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:139)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> 2019-05-28 20:32:48,677 ERROR
> [RS_OPEN_REGION-regionserver/hbaseperf-8:16020-15]
> regionserver.HRegionServer: * ABORTING region server
> 10.11.45.52,16020,1559046489201: Failed to open region
> user,f768,1559033479968.6f1508a4480447698cf8b04cd850698f. and can not
> recover *
> org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: Server
> 10.11.45.52,16020,1559046489201 stopping
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1505)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2206)
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:139)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> 2019-05-28 20:32:48,677 ERROR
> [RS_OPEN_REGION-regionserver/hbaseperf-8:16020-15]
> regionserver.HRegionServer: RegionServer abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850330#comment-16850330 ] Jingyun Tian commented on HBASE-22454: -- pushed to master. Branch-2 has some conflicts with this patch, thus I uploaded a patch for it. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.master.001.patch, HBASE-22454.master.002.patch, > HBASE-22454.master.003.patch, HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.branch-2.001.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.master.001.patch, HBASE-22454.master.002.patch, > HBASE-22454.master.003.patch, HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-12169) Document IPC binding options
[
https://issues.apache.org/jira/browse/HBASE-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850329#comment-16850329
]
HBase QA commented on HBASE-12169:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 11m
51s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
19s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/443/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-12169 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970105/HBASE-12169-001.PATCH
|
| Optional Tests | dupname asflicense refguide |
| uname | Linux 9eae5c816097 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c3642b1dda |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/443/artifact/patchprocess/branch-site/book.html
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/443/artifact/patchprocess/whitespace-eol.txt
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/443/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 95 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/443/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Document IPC binding options
>
>
> Key: HBASE-12169
> URL: https://issues.apache.org/jira/browse/HBASE-12169
> Project: HBase
> Issue Type: Task
> Components: documentation
>Affects Versions: 0.98.0, 0.94.7, 0.99.0
>Reporter: Sean Busbey
>Assignee: Mike Drob
>Priority: Minor
> Attachments: HBASE-12169-001.PATCH, HBASE-12169.patch
>
>
> HBASE-8148 added options to change binding component services, but there
> aren't any docs for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22489) When regionServer stopping open region cause server aborting
binlijin created HBASE-22489:
Summary: When regionServer stopping open region cause server
aborting
Key: HBASE-22489
URL: https://issues.apache.org/jira/browse/HBASE-22489
Project: HBase
Issue Type: Bug
Reporter: binlijin
When regionserver stopping, region open will ABORTING regionserver, need to
take care it.
{code}
2019-05-28 20:32:48,672 WARN
[RS_OPEN_REGION-regionserver/hbaseperf-8:16020-15] handler.AssignRegionHandler:
Fatal error occurred while opening region
user,f768,1559033479968.6f1508a4480447698cf8b04cd850698f., aborting...
org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: Server
10.11.45.52,16020,1559046489201 stopping
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1505)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2206)
at
org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:139)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
2019-05-28 20:32:48,677 ERROR
[RS_OPEN_REGION-regionserver/hbaseperf-8:16020-15] regionserver.HRegionServer:
* ABORTING region server 10.11.45.52,16020,1559046489201: Failed to open
region user,f768,1559033479968.6f1508a4480447698cf8b04cd850698f. and can
not recover *
org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: Server
10.11.45.52,16020,1559046489201 stopping
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1505)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2206)
at
org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:139)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
2019-05-28 20:32:48,677 ERROR
[RS_OPEN_REGION-regionserver/hbaseperf-8:16020-15] regionserver.HRegionServer:
RegionServer abort: loaded coprocessors are:
[org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint]
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15898) Document G1GC Recommendations
[
https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850327#comment-16850327
]
HBase QA commented on HBASE-15898:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
26s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 8m
3s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
56s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/442/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-15898 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970104/HBASE-15898-001.PATCH
|
| Optional Tests | dupname asflicense refguide |
| uname | Linux 7ac46351afd2 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c3642b1dda |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/442/artifact/patchprocess/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/442/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 62 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/442/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Document G1GC Recommendations
> -
>
> Key: HBASE-15898
> URL: https://issues.apache.org/jira/browse/HBASE-15898
> Project: HBase
> Issue Type: Bug
> Components: documentation, java
>Affects Versions: 2.0.0
>Reporter: Misty Linville
>Assignee: Misty Linville
>Priority: Major
> Attachments: HBASE-15898-001.PATCH, HBASE-15898.patch
>
>
> Document G1GC recommendations for HBase
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] infraio merged pull request #260: HBASE-22486 Fix flaky test TestLockManager
infraio merged pull request #260: HBASE-22486 Fix flaky test TestLockManager URL: https://github.com/apache/hbase/pull/260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850321#comment-16850321 ] Jingyun Tian commented on HBASE-22454: -- Sure. [~zghaobac] Thanks for your review. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] infraio merged pull request #258: HBASE-22485 Fix failed ut TestClusterRestartFailover
infraio merged pull request #258: HBASE-22485 Fix failed ut TestClusterRestartFailover URL: https://github.com/apache/hbase/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22476) HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.
[
https://issues.apache.org/jira/browse/HBASE-22476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850313#comment-16850313
]
Hadoop QA commented on HBASE-22476:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
1s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
20s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/263 |
| JIRA Issue | HBASE-22476 |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8ec507d3bd24 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 858d30dd30 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/testReport/
|
| Max. process+thread count | 4642 (vs. ulimit of 1) |
| modules | C: hbase-backup U: hbase-backup |
| Console output |
[GitHub] [hbase] Apache-HBase commented on issue #263: [HBASE-22476] FSDataInputStream is not closed.
Apache-HBase commented on issue #263: [HBASE-22476] FSDataInputStream is not closed. URL: https://github.com/apache/hbase/pull/263#issuecomment-496758921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 28 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 298 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 16 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 44 | master passed | | +1 | javadoc | 17 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 259 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 283 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1031 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 46 | the patch passed | | +1 | javadoc | 15 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 740 | hbase-backup in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3480 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/263 | | JIRA Issue | HBASE-22476 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8ec507d3bd24 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 858d30dd30 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/testReport/ | | Max. process+thread count | 4642 (vs. ulimit of 1) | | modules | C: hbase-backup U: hbase-backup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850309#comment-16850309
]
Hudson commented on HBASE-22148:
Results for branch master
[build #1051 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1051/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1051//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1051//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1051//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1051//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15867) Move HBase replication tracking from ZooKeeper to HBase
[ https://issues.apache.org/jira/browse/HBASE-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850305#comment-16850305 ] Xu Cang commented on HBASE-15867: - thank you [~openinx] very helpful! > Move HBase replication tracking from ZooKeeper to HBase > --- > > Key: HBASE-15867 > URL: https://issues.apache.org/jira/browse/HBASE-15867 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.1.0 >Reporter: Joseph >Assignee: Zheng Hu >Priority: Major > Fix For: 2.3.0 > > > Move the WAL file and offset tracking out of ZooKeeper and into an HBase > table called hbase:replication. > The largest three new changes will be two classes ReplicationTableBase, > TableBasedReplicationQueues, and TableBasedReplicationQueuesClient. As of now > ReplicationPeers and HFileRef's tracking will not be implemented. Subtasks > have been filed for these two jobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-12169) Document IPC binding options
[ https://issues.apache.org/jira/browse/HBASE-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850303#comment-16850303 ] Biju Nair commented on HBASE-12169: --- [~busbey], the new patch helps? > Document IPC binding options > > > Key: HBASE-12169 > URL: https://issues.apache.org/jira/browse/HBASE-12169 > Project: HBase > Issue Type: Task > Components: documentation >Affects Versions: 0.98.0, 0.94.7, 0.99.0 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Minor > Attachments: HBASE-12169-001.PATCH, HBASE-12169.patch > > > HBASE-8148 added options to change binding component services, but there > aren't any docs for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-12169) Document IPC binding options
[ https://issues.apache.org/jira/browse/HBASE-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair updated HBASE-12169: -- Attachment: HBASE-12169-001.PATCH > Document IPC binding options > > > Key: HBASE-12169 > URL: https://issues.apache.org/jira/browse/HBASE-12169 > Project: HBase > Issue Type: Task > Components: documentation >Affects Versions: 0.98.0, 0.94.7, 0.99.0 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Minor > Attachments: HBASE-12169-001.PATCH, HBASE-12169.patch > > > HBASE-8148 added options to change binding component services, but there > aren't any docs for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15867) Move HBase replication tracking from ZooKeeper to HBase
[ https://issues.apache.org/jira/browse/HBASE-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850297#comment-16850297 ] Zheng Hu commented on HBASE-15867: -- bq. will we track peer changes in table or we only keep the current peer information? In our original desgin, we didn't plan to store the peer changes. I guess the starting point that tracking the history changes because you want to debug the peer related problems, maybe it's better for us to enable the debug log or enhance the peer related log info. Of course, once we change to hbase:replication table we can keep all versions in it then all history changes can be accessed. Thanks. > Move HBase replication tracking from ZooKeeper to HBase > --- > > Key: HBASE-15867 > URL: https://issues.apache.org/jira/browse/HBASE-15867 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.1.0 >Reporter: Joseph >Assignee: Zheng Hu >Priority: Major > Fix For: 2.3.0 > > > Move the WAL file and offset tracking out of ZooKeeper and into an HBase > table called hbase:replication. > The largest three new changes will be two classes ReplicationTableBase, > TableBasedReplicationQueues, and TableBasedReplicationQueuesClient. As of now > ReplicationPeers and HFileRef's tracking will not be implemented. Subtasks > have been filed for these two jobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15898) Document G1GC Recommendations
[ https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850292#comment-16850292 ] Biju Nair commented on HBASE-15898: --- Attached an updated patch which takes care of the previous comments. Hope this helps to get this information into the doc [~stack]. > Document G1GC Recommendations > - > > Key: HBASE-15898 > URL: https://issues.apache.org/jira/browse/HBASE-15898 > Project: HBase > Issue Type: Bug > Components: documentation, java >Affects Versions: 2.0.0 >Reporter: Misty Linville >Assignee: Misty Linville >Priority: Major > Attachments: HBASE-15898-001.PATCH, HBASE-15898.patch > > > Document G1GC recommendations for HBase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-15898) Document G1GC Recommendations
[ https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair updated HBASE-15898: -- Attachment: HBASE-15898-001.PATCH > Document G1GC Recommendations > - > > Key: HBASE-15898 > URL: https://issues.apache.org/jira/browse/HBASE-15898 > Project: HBase > Issue Type: Bug > Components: documentation, java >Affects Versions: 2.0.0 >Reporter: Misty Linville >Assignee: Misty Linville >Priority: Major > Attachments: HBASE-15898-001.PATCH, HBASE-15898.patch > > > Document G1GC recommendations for HBase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22387) Evaluate the get/scan performance after reading HFile block into offheap directly
[ https://issues.apache.org/jira/browse/HBASE-22387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850290#comment-16850290 ] Zheng Hu commented on HBASE-22387: -- After enable the short-circuit read feature, the throughtput improved much. see the graphs 1. [G1GC-stage-stw.case02-with-buffer-size-64KB.pnghttps://issues.apache.org/jira/secure/attachment/12970103/G1GC-stage-stw.case02-with-buffer-size-64KB.png] ; 2. [G1GC-stw.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970101/G1GC-stw.case02-with-buffer-size-64KB.png] 3. [QPS-latency.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970100/QPS-latency.case02-with-buffer-size-64KB.png] We use the default hbase.ipc.server.allocator.buffer.size=64KB here, as HBASE-22483 said, I will have a benchmark by setting the buffer.size=65KB, should be better performance. > Evaluate the get/scan performance after reading HFile block into offheap > directly > - > > Key: HBASE-22387 > URL: https://issues.apache.org/jira/browse/HBASE-22387 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: G1GC-stage-stw.case01.png, > G1GC-stage-stw.case02-with-buffer-size-64KB.png, G1GC-stw.case01.png, > G1GC-stw.case02-with-buffer-size-64KB.png, QPS-latency.case01.png, > QPS-latency.case02-with-buffer-size-64KB.png, blockReaderRemote.png, > blocksByHFile-stack-trace.png, screenshot-1.png, > test-cluster-configuration-details.png > > > Now, all sub-tasks has been resolved now (except the HBASE-21946 because of > the hadoop dependency problem), will provide some performance benckmarks to > show the latency improvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-22387) Evaluate the get/scan performance after reading HFile block into offheap directly
[ https://issues.apache.org/jira/browse/HBASE-22387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850290#comment-16850290 ] Zheng Hu edited comment on HBASE-22387 at 5/29/19 1:48 AM: --- After enable the short-circuit read feature, the throughtput improved much. see the graphs 1. [G1GC-stage-stw.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970103/G1GC-stage-stw.case02-with-buffer-size-64KB.png] ; 2. [G1GC-stw.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970101/G1GC-stw.case02-with-buffer-size-64KB.png] 3. [QPS-latency.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970100/QPS-latency.case02-with-buffer-size-64KB.png] We use the default hbase.ipc.server.allocator.buffer.size=64KB here, as HBASE-22483 said, I will have a benchmark by setting the buffer.size=65KB, should be better performance. was (Author: openinx): After enable the short-circuit read feature, the throughtput improved much. see the graphs 1. [G1GC-stage-stw.case02-with-buffer-size-64KB.pnghttps://issues.apache.org/jira/secure/attachment/12970103/G1GC-stage-stw.case02-with-buffer-size-64KB.png] ; 2. [G1GC-stw.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970101/G1GC-stw.case02-with-buffer-size-64KB.png] 3. [QPS-latency.case02-with-buffer-size-64KB.png|https://issues.apache.org/jira/secure/attachment/12970100/QPS-latency.case02-with-buffer-size-64KB.png] We use the default hbase.ipc.server.allocator.buffer.size=64KB here, as HBASE-22483 said, I will have a benchmark by setting the buffer.size=65KB, should be better performance. > Evaluate the get/scan performance after reading HFile block into offheap > directly > - > > Key: HBASE-22387 > URL: https://issues.apache.org/jira/browse/HBASE-22387 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: G1GC-stage-stw.case01.png, > G1GC-stage-stw.case02-with-buffer-size-64KB.png, G1GC-stw.case01.png, > G1GC-stw.case02-with-buffer-size-64KB.png, QPS-latency.case01.png, > QPS-latency.case02-with-buffer-size-64KB.png, blockReaderRemote.png, > blocksByHFile-stack-trace.png, screenshot-1.png, > test-cluster-configuration-details.png > > > Now, all sub-tasks has been resolved now (except the HBASE-21946 because of > the hadoop dependency problem), will provide some performance benckmarks to > show the latency improvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22387) Evaluate the get/scan performance after reading HFile block into offheap directly
[ https://issues.apache.org/jira/browse/HBASE-22387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22387: - Attachment: G1GC-stw.case02-with-buffer-size-64KB.png > Evaluate the get/scan performance after reading HFile block into offheap > directly > - > > Key: HBASE-22387 > URL: https://issues.apache.org/jira/browse/HBASE-22387 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: G1GC-stage-stw.case01.png, > G1GC-stage-stw.case02-with-buffer-size-64KB.png, G1GC-stw.case01.png, > G1GC-stw.case02-with-buffer-size-64KB.png, QPS-latency.case01.png, > QPS-latency.case02-with-buffer-size-64KB.png, blockReaderRemote.png, > blocksByHFile-stack-trace.png, screenshot-1.png, > test-cluster-configuration-details.png > > > Now, all sub-tasks has been resolved now (except the HBASE-21946 because of > the hadoop dependency problem), will provide some performance benckmarks to > show the latency improvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22387) Evaluate the get/scan performance after reading HFile block into offheap directly
[ https://issues.apache.org/jira/browse/HBASE-22387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22387: - Attachment: G1GC-stage-stw.case02-with-buffer-size-64KB.png > Evaluate the get/scan performance after reading HFile block into offheap > directly > - > > Key: HBASE-22387 > URL: https://issues.apache.org/jira/browse/HBASE-22387 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: G1GC-stage-stw.case01.png, > G1GC-stage-stw.case02-with-buffer-size-64KB.png, G1GC-stw.case01.png, > G1GC-stw.case02-with-buffer-size-64KB.png, QPS-latency.case01.png, > QPS-latency.case02-with-buffer-size-64KB.png, blockReaderRemote.png, > blocksByHFile-stack-trace.png, screenshot-1.png, > test-cluster-configuration-details.png > > > Now, all sub-tasks has been resolved now (except the HBASE-21946 because of > the hadoop dependency problem), will provide some performance benckmarks to > show the latency improvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22387) Evaluate the get/scan performance after reading HFile block into offheap directly
[ https://issues.apache.org/jira/browse/HBASE-22387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22387: - Attachment: QPS-latency.case02-with-buffer-size-64KB.png > Evaluate the get/scan performance after reading HFile block into offheap > directly > - > > Key: HBASE-22387 > URL: https://issues.apache.org/jira/browse/HBASE-22387 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: G1GC-stage-stw.case01.png, G1GC-stw.case01.png, > QPS-latency.case01.png, QPS-latency.case02-with-buffer-size-64KB.png, > blockReaderRemote.png, blocksByHFile-stack-trace.png, screenshot-1.png, > test-cluster-configuration-details.png > > > Now, all sub-tasks has been resolved now (except the HBASE-21946 because of > the hadoop dependency problem), will provide some performance benckmarks to > show the latency improvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22411) Refactor codes of moving reigons in RSGroup
[ https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22411: --- Attachment: HBASE-22411.branch-2.001.patch > Refactor codes of moving reigons in RSGroup > --- > > Key: HBASE-22411 > URL: https://issues.apache.org/jira/browse/HBASE-22411 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.2.0 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: HBASE-22411.branch-2.001.patch, > HBASE-22411.branch-2.2.001.patch, HBASE-22411.master.001.patch, > HBASE-22411.master.002.patch, HBASE-22411.master.003.patch, > HBASE-22411.master.004.patch, HBASE-22411.master.005.patch, > HBASE-22411.master.006.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, > HBASE-22411.master.007.patch, HBASE-22411.master.008.patch, > HBASE-22411.master.009.patch, HBASE-22411.master.010.patch, > HBASE-22411.master.011.patch, HBASE-22411.master.012.patch, > HBASE-22411.master.013.patch, HBASE-22411.master.014.patch, > HBASE-22411.master.015.patch, HBASE-22411.master.016.patch > > > Essentially RSGroup managed regions. Organizing tables or servers' RSGroups > is to move relevant regions. Codes of moving regions can be refactored. > So that some problems caused by moving regions can be fixed elegantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850279#comment-16850279 ] Guanghao Zhang commented on HBASE-22454: +1. The TestMetaTableMetrics not related. And as I will release branch-2.2 today. Please only commit to master and branch-2. I will cherry-pick this to branch-2.2 afrer branch-2.2 released. Thanks. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850277#comment-16850277
]
Hudson commented on HBASE-22467:
Results for branch branch-2
[build #1932 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1932//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] q977734161 opened a new pull request #263: [HBASE-22476] FSDataInputStream is not closed.
q977734161 opened a new pull request #263: [HBASE-22476] FSDataInputStream is not closed. URL: https://github.com/apache/hbase/pull/263 HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22488) Cleanup the explicit timeout value for test methods
[ https://issues.apache.org/jira/browse/HBASE-22488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22488: --- Description: After HBASE-19948, no need to add explicit timeout for test methods. But there are some new test methods which used explicit timeout and easy to fail when precommit job run them. One example is [https://builds.apache.org/job/PreCommit-HBASE-Build/436/testReport/org.apache.hadoop.hbase.coprocessor/TestMetaTableMetrics/testConcurrentAccess/] See [http://hbase.apache.org/book.html#hbase.unittests.timeouts] was:After HBASE-19948, no need to add explicit timeout for test methods. But there are some new test methods which used explicit timeout and easy to fail when precommit job run them. One example is [https://builds.apache.org/job/PreCommit-HBASE-Build/436/testReport/org.apache.hadoop.hbase.coprocessor/TestMetaTableMetrics/testConcurrentAccess/] > Cleanup the explicit timeout value for test methods > --- > > Key: HBASE-22488 > URL: https://issues.apache.org/jira/browse/HBASE-22488 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > After HBASE-19948, no need to add explicit timeout for test methods. But > there are some new test methods which used explicit timeout and easy to fail > when precommit job run them. One example is > [https://builds.apache.org/job/PreCommit-HBASE-Build/436/testReport/org.apache.hadoop.hbase.coprocessor/TestMetaTableMetrics/testConcurrentAccess/] > > See [http://hbase.apache.org/book.html#hbase.unittests.timeouts] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] infraio opened a new pull request #262: HBASE-22488 Cleanup the explicit timeout value for test methods
infraio opened a new pull request #262: HBASE-22488 Cleanup the explicit timeout value for test methods URL: https://github.com/apache/hbase/pull/262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850263#comment-16850263
]
Hudson commented on HBASE-22467:
Results for branch branch-2.2
[build #300 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/300//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22488) Cleanup the explicit timeout value for test methods
Guanghao Zhang created HBASE-22488: -- Summary: Cleanup the explicit timeout value for test methods Key: HBASE-22488 URL: https://issues.apache.org/jira/browse/HBASE-22488 Project: HBase Issue Type: Improvement Reporter: Guanghao Zhang Assignee: Guanghao Zhang After HBASE-19948, no need to add explicit timeout for test methods. But there are some new test methods which used explicit timeout and easy to fail when precommit job run them. One example is [https://builds.apache.org/job/PreCommit-HBASE-Build/436/testReport/org.apache.hadoop.hbase.coprocessor/TestMetaTableMetrics/testConcurrentAccess/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information
[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850257#comment-16850257
]
Hudson commented on HBASE-22469:
Results for branch branch-2
[build #1930 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1930//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
>
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we
> long retired md5 from the releases, it makes sense to replace hbase version
> information as well. I also noticed that revision doesn't always show, case
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only
> appears if the compiled code was cloned from git and not a release candidate
> download file. In that sense, release candidates should be checked out rather
> than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[
https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850246#comment-16850246
]
Hudson commented on HBASE-22471:
Results for branch master
[build #1050 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1050/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1050//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1050//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1050//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1050//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in
> integration test
> -
>
> Key: HBASE-22471
> URL: https://issues.apache.org/jira/browse/HBASE-22471
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1
>
> Attachments: HBASE-22471.patch
>
>
> We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1
> jars are already there for a long time. We need to clean the workspace.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22487) getMostLoadedRegions is unused
[
https://issues.apache.org/jira/browse/HBASE-22487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850242#comment-16850242
]
HBase QA commented on HBASE-22487:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}263m 46s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}335m 29s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/439/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22487 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970051/0001-HBASE-22487-getMostLoadedRegions-is-unused.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b72a46cb1dda 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7
07:56:38 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6ddf893a34 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/439/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test
[jira] [Commented] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850221#comment-16850221
]
Hudson commented on HBASE-22148:
Results for branch branch-2
[build #1929 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1929/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1929//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1929//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1929//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850202#comment-16850202
]
Hudson commented on HBASE-22148:
Results for branch branch-2.2
[build #298 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/298/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/298//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/298//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/298//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850182#comment-16850182 ] stack commented on HBASE-22467: --- ... started RC build. Thanks. > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850179#comment-16850179
]
Hudson commented on HBASE-22148:
Results for branch branch-2.0
[build #1627 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1627/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1627//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1627//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1627//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850163#comment-16850163
]
Hudson commented on HBASE-22148:
Results for branch branch-2.1
[build #1202 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1202/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1202//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1202//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1202//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22393) HBOSS: Shade curator to prevent conflict with Hadoop
[
https://issues.apache.org/jira/browse/HBASE-22393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850127#comment-16850127
]
Sean Busbey commented on HBASE-22393:
-
I'm pulling down the latest and reviewing today/tomorrow.
> HBOSS: Shade curator to prevent conflict with Hadoop
>
>
> Key: HBASE-22393
> URL: https://issues.apache.org/jira/browse/HBASE-22393
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Mackrory
>Assignee: Sean Mackrory
>Priority: Critical
> Labels: HBOSS
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments:
> 0001-HBASE-22393-HBOSS-Shade-dependencies-to-prevent-conf.patch,
> 0001-HBASE-22393.patch, HBASE-22393.001.patch, HBASE-22393.002.patch
>
>
> Hadoop uses a very old version of Curator, and if it ever ends up in the
> classpath with HBOSS you can get this:
> {code}Exception in thread "main" java.lang.IllegalAccessError: tried to
> access method
> org.apache.curator.framework.recipes.locks.InterProcessMutex.isOwnedByCurrentThread()Z
> from class org.apache.hadoop.hbase.oss.sync.ZKTreeLockManager{code}
> I think the simplest solution is to just shade Curator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-22467: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed the commit which duplicates some "sanitization" logic from within HtmlQuoting to avoid holding up Stack. HtmlQuoting, at present, doesn't work for what ProfileOutputServlet needs. Thanks for the reviews. > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] petersomogyi commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support
petersomogyi commented on a change in pull request #239: HBASE-22409 update
branch-1 ref guide for Hadoop, Java, and HBase version support
URL: https://github.com/apache/hbase/pull/239#discussion_r288290200
##
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##
@@ -81,20 +83,27 @@ To see the usage, use the `--help` parameter.
$ ${HBASE_HOME}/bin/hbase canary -help
-Usage: bin/hbase org.apache.hadoop.hbase.tool.Canary [opts] [table1
[table2]...] | [regionserver1 [regionserver2]..]
+Usage: hbase org.apache.hadoop.hbase.tool.Canary [opts] [table1 [table2]...] |
[regionserver1 [regionserver2]..]
where [opts] are:
-help Show this help and exit.
-regionserver replace the table argument to regionserver,
which means to enable regionserver mode
+ -allRegionsTries all regions on a regionserver,
+ only works in regionserver mode.
+ -zookeeperTries to grab zookeeper.znode.parent
+ on each zookeeper instance
-daemonContinuous check at defined intervals.
Review comment:
The rest of the help output looked correct for branch-1 canary, only
`-permittedZookeeperFailures` was missing. Master branch has a slightly
different help message but the master reference guide is up to date with it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] asfgit closed pull request #261: HBASE-22467 UI fixes to enable Knox proxying
asfgit closed pull request #261: HBASE-22467 UI fixes to enable Knox proxying URL: https://github.com/apache/hbase/pull/261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on issue #261: HBASE-22467 UI fixes to enable Knox proxying
joshelser commented on issue #261: HBASE-22467 UI fixes to enable Knox proxying URL: https://github.com/apache/hbase/pull/261#issuecomment-496676168 Ripping out edaae03 -- doesn't work for what I'm trying to do here. Will leave a comment on commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support
petersomogyi commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support URL: https://github.com/apache/hbase/pull/239#discussion_r288287480 ## File path: src/main/site/site.xml ## @@ -77,12 +77,17 @@ - - - - - - + + + + + + + Review comment: Since 1.1 docs are still there we can add it. I haven't checked it before. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #261: HBASE-22467 UI fixes to enable Knox proxying
joshelser commented on a change in pull request #261: HBASE-22467 UI fixes to
enable Knox proxying
URL: https://github.com/apache/hbase/pull/261#discussion_r288283407
##
File path:
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestProfileOutputServlet.java
##
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.http;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category({SmallTests.class})
+public class TestProfileOutputServlet {
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestProfileOutputServlet.class);
+
+ @Test
+ public void testSanitization() {
Review comment:
Ugh, yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-21158) Empty qualifier cell should not be returned if it does not match QualifierFilter
[
https://issues.apache.org/jira/browse/HBASE-21158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850092#comment-16850092
]
Andrew Purtell commented on HBASE-21158:
[~andrewcheng] See above where [~lhofhansl] indicates the change here is not
consistent in branch-2.
> Empty qualifier cell should not be returned if it does not match
> QualifierFilter
>
>
> Key: HBASE-21158
> URL: https://issues.apache.org/jira/browse/HBASE-21158
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Critical
> Fix For: 3.0.0, 1.3.3, 1.2.8, 2.2.0, 1.4.8, 2.1.1, 2.0.3
>
> Attachments: HBASE-21158.branch-1.001.patch,
> HBASE-21158.master.001.patch, HBASE-21158.master.002.patch,
> HBASE-21158.master.003.patch, HBASE-21158.master.004.patch
>
>
> {code:xml}
> hbase(main):002:0> put 'testTable','testrow','f:testcol1','testvalue1'
> 0 row(s) in 0.0040 seconds
> hbase(main):003:0> put 'testTable','testrow','f:','testvalue2'
> 0 row(s) in 0.0070 seconds
> # get row with empty column f:, result is correct.
> hbase(main):004:0> scan 'testTable',{FILTER => "QualifierFilter (=,
> 'binary:')"}
> ROW COLUMN+CELL
>
>
> testrowcolumn=f:,
> timestamp=1536218563581, value=testvalue2
>
> 1 row(s) in 0.0460 seconds
> # get row with column f:testcol1, result is incorrect.
> hbase(main):005:0> scan 'testTable',{FILTER => "QualifierFilter (=,
> 'binary:testcol1')"}
> ROW COLUMN+CELL
>
>
> testrowcolumn=f:,
> timestamp=1536218563581, value=testvalue2
>
> testrowcolumn=f:testcol1,
> timestamp=1536218550827, value=testvalue1
>
> 1 row(s) in 0.0070 seconds
> {code}
> As the above operation, when the row contains empty qualifier column, empty
> qualifier cell is always returned when using QualifierFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21158) Empty qualifier cell should not be returned if it does not match QualifierFilter
[
https://issues.apache.org/jira/browse/HBASE-21158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850088#comment-16850088
]
Andrew Purtell commented on HBASE-21158:
Maybe the difference is due to 1.4.10 not being released yet with the change
included. Adding the OR condition in the Phoenix code is the right thing to do
given that HBase has decided the earlier behavior was a bug.
> Empty qualifier cell should not be returned if it does not match
> QualifierFilter
>
>
> Key: HBASE-21158
> URL: https://issues.apache.org/jira/browse/HBASE-21158
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Critical
> Fix For: 3.0.0, 1.3.3, 1.2.8, 2.2.0, 1.4.8, 2.1.1, 2.0.3
>
> Attachments: HBASE-21158.branch-1.001.patch,
> HBASE-21158.master.001.patch, HBASE-21158.master.002.patch,
> HBASE-21158.master.003.patch, HBASE-21158.master.004.patch
>
>
> {code:xml}
> hbase(main):002:0> put 'testTable','testrow','f:testcol1','testvalue1'
> 0 row(s) in 0.0040 seconds
> hbase(main):003:0> put 'testTable','testrow','f:','testvalue2'
> 0 row(s) in 0.0070 seconds
> # get row with empty column f:, result is correct.
> hbase(main):004:0> scan 'testTable',{FILTER => "QualifierFilter (=,
> 'binary:')"}
> ROW COLUMN+CELL
>
>
> testrowcolumn=f:,
> timestamp=1536218563581, value=testvalue2
>
> 1 row(s) in 0.0460 seconds
> # get row with column f:testcol1, result is incorrect.
> hbase(main):005:0> scan 'testTable',{FILTER => "QualifierFilter (=,
> 'binary:testcol1')"}
> ROW COLUMN+CELL
>
>
> testrowcolumn=f:,
> timestamp=1536218563581, value=testvalue2
>
> testrowcolumn=f:testcol1,
> timestamp=1536218550827, value=testvalue1
>
> 1 row(s) in 0.0070 seconds
> {code}
> As the above operation, when the row contains empty qualifier column, empty
> qualifier cell is always returned when using QualifierFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] busbey commented on a change in pull request #261: HBASE-22467 UI fixes to enable Knox proxying
busbey commented on a change in pull request #261: HBASE-22467 UI fixes to
enable Knox proxying
URL: https://github.com/apache/hbase/pull/261#discussion_r288271023
##
File path:
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestProfileOutputServlet.java
##
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.http;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category({SmallTests.class})
+public class TestProfileOutputServlet {
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestProfileOutputServlet.class);
+
+ @Test
+ public void testSanitization() {
Review comment:
won't these tests fail now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-21158) Empty qualifier cell should not be returned if it does not match QualifierFilter
[
https://issues.apache.org/jira/browse/HBASE-21158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850074#comment-16850074
]
Andrew Purtell commented on HBASE-21158:
branch-1 commit is d4d0a21b
branch-1.4 commit is b3aa1c19
branch-1.3 commit is 469c0279
The change to QualifierFilter.java is identical in all of these commits. There
must be more going on here.[~lhofhansl]
> Empty qualifier cell should not be returned if it does not match
> QualifierFilter
>
>
> Key: HBASE-21158
> URL: https://issues.apache.org/jira/browse/HBASE-21158
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Critical
> Fix For: 3.0.0, 1.3.3, 1.2.8, 2.2.0, 1.4.8, 2.1.1, 2.0.3
>
> Attachments: HBASE-21158.branch-1.001.patch,
> HBASE-21158.master.001.patch, HBASE-21158.master.002.patch,
> HBASE-21158.master.003.patch, HBASE-21158.master.004.patch
>
>
> {code:xml}
> hbase(main):002:0> put 'testTable','testrow','f:testcol1','testvalue1'
> 0 row(s) in 0.0040 seconds
> hbase(main):003:0> put 'testTable','testrow','f:','testvalue2'
> 0 row(s) in 0.0070 seconds
> # get row with empty column f:, result is correct.
> hbase(main):004:0> scan 'testTable',{FILTER => "QualifierFilter (=,
> 'binary:')"}
> ROW COLUMN+CELL
>
>
> testrowcolumn=f:,
> timestamp=1536218563581, value=testvalue2
>
> 1 row(s) in 0.0460 seconds
> # get row with column f:testcol1, result is incorrect.
> hbase(main):005:0> scan 'testTable',{FILTER => "QualifierFilter (=,
> 'binary:testcol1')"}
> ROW COLUMN+CELL
>
>
> testrowcolumn=f:,
> timestamp=1536218563581, value=testvalue2
>
> testrowcolumn=f:testcol1,
> timestamp=1536218550827, value=testvalue1
>
> 1 row(s) in 0.0070 seconds
> {code}
> As the above operation, when the row contains empty qualifier column, empty
> qualifier cell is always returned when using QualifierFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-12169) Document IPC binding options
[ https://issues.apache.org/jira/browse/HBASE-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850073#comment-16850073 ] Sean Busbey commented on HBASE-12169: - Neither of the two options under discussion back in 2017 appears to have been taken. > Document IPC binding options > > > Key: HBASE-12169 > URL: https://issues.apache.org/jira/browse/HBASE-12169 > Project: HBase > Issue Type: Task > Components: documentation >Affects Versions: 0.98.0, 0.94.7, 0.99.0 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Minor > Attachments: HBASE-12169.patch > > > HBASE-8148 added options to change binding component services, but there > aren't any docs for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information
[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-22469:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.3.0
3.0.0
Release Note: The HBase "source checksum" now uses SHA512 instead of MD5.
Status: Resolved (was: Patch Available)
Thanks, Artem. Fixed it on commit.
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
>
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we
> long retired md5 from the releases, it makes sense to replace hbase version
> information as well. I also noticed that revision doesn't always show, case
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only
> appears if the compiled code was cloned from git and not a release candidate
> download file. In that sense, release candidates should be checked out rather
> than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] joshelser commented on issue #261: HBASE-22467 UI fixes to enable Knox proxying
joshelser commented on issue #261: HBASE-22467 UI fixes to enable Knox proxying URL: https://github.com/apache/hbase/pull/261#issuecomment-496654992 Pushed edaae03 which uses HtmlQuoting. Don't see a need to re-invent the wheel and I think the implementation of that method is fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-18280) Manual Array Copy Cleanup: Automated
[
https://issues.apache.org/jira/browse/HBASE-18280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850053#comment-16850053
]
Biju Nair edited comment on HBASE-18280 at 5/28/19 7:24 PM:
[~chia7712] Will {{System.arraycopy}} perform better than the manual looping?
If so can this be merged? There are some graphs on
[performance|https://stackoverflow.com/questions/18638743/is-it-better-to-use-system-arraycopy-than-a-for-loop-for-copying-arrays]
comparison between manual looping, Arrays.copy and System.arraycopy.
was (Author: gsbiju):
[~chia7712] Will {{System.arraycopy}} perform better than the manual looping?
If so can this be merged? There are some graphs on
[performance|https://stackoverflow.com/questions/18638743/is-it-better-to-use-system-arraycopy-than-a-for-loop-for-copying-arrays].
> Manual Array Copy Cleanup: Automated
>
>
> Key: HBASE-18280
> URL: https://issues.apache.org/jira/browse/HBASE-18280
> Project: HBase
> Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: 0001-HBASE-18280-Remove-Manual-Array-Copies.patch
>
>
> Remove Manual Array Copies: Style Issue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22471) Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in integration test
[ https://issues.apache.org/jira/browse/HBASE-22471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850059#comment-16850059 ] Sean Busbey commented on HBASE-22471: - belated +1, that's a nice way to do it. clearing the workspace manually involves digging through pipeline stages to find the node assignment, which will get you a link to the workspace, which will have a link to clear it. It's a big pain. This is much better. > Our nightly jobs for master and branch-2 are still using hadoop-2.7.1 in > integration test > - > > Key: HBASE-22471 > URL: https://issues.apache.org/jira/browse/HBASE-22471 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22471.patch > > > We use ls to get the hadoop 2 jars, so maybe the problem is that the 2.7.1 > jars are already there for a long time. We need to clean the workspace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18280) Manual Array Copy Cleanup: Automated
[
https://issues.apache.org/jira/browse/HBASE-18280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850060#comment-16850060
]
HBase QA commented on HBASE-18280:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-18280 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18280 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874725/0001-HBASE-18280-Remove-Manual-Array-Copies.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/440/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Manual Array Copy Cleanup: Automated
>
>
> Key: HBASE-18280
> URL: https://issues.apache.org/jira/browse/HBASE-18280
> Project: HBase
> Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: 0001-HBASE-18280-Remove-Manual-Array-Copies.patch
>
>
> Remove Manual Array Copies: Style Issue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18280) Manual Array Copy Cleanup: Automated
[
https://issues.apache.org/jira/browse/HBASE-18280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850053#comment-16850053
]
Biju Nair commented on HBASE-18280:
---
[~chia7712] Will {{System.arraycopy}} perform better than the manual looping?
If so can this be merged? There are some graphs on
[performance|https://stackoverflow.com/questions/18638743/is-it-better-to-use-system-arraycopy-than-a-for-loop-for-copying-arrays].
> Manual Array Copy Cleanup: Automated
>
>
> Key: HBASE-18280
> URL: https://issues.apache.org/jira/browse/HBASE-18280
> Project: HBase
> Issue Type: Improvement
>Reporter: John Leach
>Assignee: John Leach
>Priority: Trivial
> Attachments: 0001-HBASE-18280-Remove-Manual-Array-Copies.patch
>
>
> Remove Manual Array Copies: Style Issue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[
https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850045#comment-16850045
]
Josh Elser commented on HBASE-22467:
{quote}Was going to start a new RC build. I can wait if commit will happen soon
else will punt to 2.1.6.
{quote}
If you could wait, that'd be great. Busbey left me feedback on the linked PR
which I'm looking at now.
{quote}Are the *.jamon changes related? Or just cleanup?
{quote}
Yeah, they're related. tl;dr being a little more explicit in the templates
makes it much easier in Knox to create a rewrite rule so that it can generate
proper links.
> WebUI changes to enable Apache Knox UI proxying
> ---
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.1.5, 2.2.1
>
> Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch,
> HBASE-22467.003.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized
> authentication and authorization for a collection of service. Additionally,
> it can expose "private" nodes through a single point (e.g. a gateway). This
> makes our life as developers much easier in cloud deployments where it's not
> straightforward to access nodes (e.g. they're running on some private
> network).
> KNOX-1866 captures the changes over there required to make HBase's proxying
> actually work (definition lives there), but there were a few things we do in
> our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated
> properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-17233) See if we should replace System.arrayCopy with Arrays.copyOfRange
[
https://issues.apache.org/jira/browse/HBASE-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850046#comment-16850046
]
Biju Nair commented on HBASE-17233:
---
So the conclusion is {{Arrays.copyOfRange}} is better performing than
{{System.arraycopy}}. Correct? By how much?
> See if we should replace System.arrayCopy with Arrays.copyOfRange
> -
>
> Key: HBASE-17233
> URL: https://issues.apache.org/jira/browse/HBASE-17233
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Major
>
> Just saw this interesting comment in PB code. Since we deal with byte[]
> extensively (when we are onheap) we do lot of copies too.
> {code}
> * One of the noticeable costs of copying a byte[] into a new array using
>* {@code System.arraycopy} is nullification of a new buffer before the
> copy. It has been shown
>* the Hotspot VM is capable to intrisicfy {@code Arrays.copyOfRange}
> operation to avoid this
>* expensive nullification and provide substantial performance gain.
> Unfortunately this does not
>* hold on Android runtimes and could make the copy slightly slower due to
> additional code in
>* the {@code Arrays.copyOfRange}.
> {code}
> So since we are hotspot VM we could see if the places we use System.arrayCopy
> can be replaced with Arrays.copyOfRange.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] joshelser commented on a change in pull request #261: HBASE-22467 UI fixes to enable Knox proxying
joshelser commented on a change in pull request #261: HBASE-22467 UI fixes to
enable Knox proxying
URL: https://github.com/apache/hbase/pull/261#discussion_r288254045
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProfileOutputServlet.java
##
@@ -37,6 +38,8 @@
private static final long serialVersionUID = 1L;
private static final Logger LOG =
LoggerFactory.getLogger(ProfileOutputServlet.class);
private static final int REFRESH_PERIOD = 2;
+ // Alphanumeric characters, plus percent (url-encoding), equals, and
ampersand
+ private static final Pattern ALPHA_NUMERIC =
Pattern.compile("[a-zA-Z0-9\\%\\=\\&]*");
Review comment:
Agree!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #261: HBASE-22467 UI fixes to enable Knox proxying
joshelser commented on a change in pull request #261: HBASE-22467 UI fixes to
enable Knox proxying
URL: https://github.com/apache/hbase/pull/261#discussion_r288253912
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProfileOutputServlet.java
##
@@ -48,11 +51,25 @@ protected void doGet(final HttpServletRequest req, final
HttpServletResponse res
// will be <100 bytes (in all modes).
if (requestedFile.length() < 100) {
LOG.info(requestedFile + " is incomplete. Sending auto-refresh
header.");
- resp.setHeader("Refresh", REFRESH_PERIOD + "," + req.getRequestURI());
+ String refreshUrl = req.getRequestURI();
+ // Rebuild the query string (if we have one)
+ if (req.getQueryString() != null) {
+refreshUrl += "?" + sanitize(req.getQueryString());
+ }
+ ProfileServlet.setResponseHeader(resp);
+ resp.setHeader("Refresh", REFRESH_PERIOD + ";" + refreshUrl);
resp.getWriter().write("This page will be auto-refreshed every " +
REFRESH_PERIOD +
-" seconds until the output file is ready.");
+" seconds until the output file is ready. Redirecting to " +
refreshUrl);
} else {
super.doGet(req, resp);
}
}
+
+ static String sanitize(String input) {
Review comment:
Nope! Just ignorant of that class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information
[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850034#comment-16850034
]
Josh Elser commented on HBASE-22469:
Actually, Artem, you changed too much.
{code:java}
@@ -317,7 +317,7 @@ AssignmentManager assignmentManager =
master.getAssignmentManager();
Hadoop Source Checksum
<% org.apache.hadoop.util.VersionInfo.getSrcChecksum()
%>
-Hadoop source MD5 checksum
+Hadoop source SHA512 checksum
ZooKeeper Client Version
{code}
You're modifying the table-cell for the Hadoop source checksum. The only change
you made here was to the HBase source checksum. The Hadoop checksum is still an
MD5.
Otherwise, this is fine. I'll just fix this on commit to branch-2 and master.
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
>
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22469.v01.patch, HBASE-22469.v02.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we
> long retired md5 from the releases, it makes sense to replace hbase version
> information as well. I also noticed that revision doesn't always show, case
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only
> appears if the compiled code was cloned from git and not a release candidate
> download file. In that sense, release candidates should be checked out rather
> than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] busbey commented on a change in pull request #261: HBASE-22467 UI fixes to enable Knox proxying
busbey commented on a change in pull request #261: HBASE-22467 UI fixes to
enable Knox proxying
URL: https://github.com/apache/hbase/pull/261#discussion_r288248769
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProfileOutputServlet.java
##
@@ -48,11 +51,25 @@ protected void doGet(final HttpServletRequest req, final
HttpServletResponse res
// will be <100 bytes (in all modes).
if (requestedFile.length() < 100) {
LOG.info(requestedFile + " is incomplete. Sending auto-refresh
header.");
- resp.setHeader("Refresh", REFRESH_PERIOD + "," + req.getRequestURI());
+ String refreshUrl = req.getRequestURI();
+ // Rebuild the query string (if we have one)
+ if (req.getQueryString() != null) {
+refreshUrl += "?" + sanitize(req.getQueryString());
+ }
+ ProfileServlet.setResponseHeader(resp);
+ resp.setHeader("Refresh", REFRESH_PERIOD + ";" + refreshUrl);
resp.getWriter().write("This page will be auto-refreshed every " +
REFRESH_PERIOD +
-" seconds until the output file is ready.");
+" seconds until the output file is ready. Redirecting to " +
refreshUrl);
} else {
super.doGet(req, resp);
}
}
+
+ static String sanitize(String input) {
Review comment:
Any particular rationale for this approach rather than using the existing
`org.apache.hadoop.hbase.http.HtmlQuoting.quoteHtmlChars(String)` method?
I guess the quoting approach doesn't protect against an attacker setting the
`Accept` header to javascript at the same time they include a query parameter
that would cause the browser to execute said javascript in the echoed page.
I'm surprised there isn't already a utility method for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #261: HBASE-22467 UI fixes to enable Knox proxying
busbey commented on a change in pull request #261: HBASE-22467 UI fixes to
enable Knox proxying
URL: https://github.com/apache/hbase/pull/261#discussion_r288251010
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/ProfileOutputServlet.java
##
@@ -37,6 +38,8 @@
private static final long serialVersionUID = 1L;
private static final Logger LOG =
LoggerFactory.getLogger(ProfileOutputServlet.class);
private static final int REFRESH_PERIOD = 2;
+ // Alphanumeric characters, plus percent (url-encoding), equals, and
ampersand
+ private static final Pattern ALPHA_NUMERIC =
Pattern.compile("[a-zA-Z0-9\\%\\=\\&]*");
Review comment:
nit:should also accept a literal `+` for spaces I think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22003) Fix flaky test TestVerifyReplication.testHBase14905
[
https://issues.apache.org/jira/browse/HBASE-22003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850031#comment-16850031
]
Hudson commented on HBASE-22003:
Results for branch branch-2.1
[build #1200 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1200/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1200//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1200//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1200//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1200//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Fix flaky test TestVerifyReplication.testHBase14905
> ---
>
> Key: HBASE-22003
> URL: https://issues.apache.org/jira/browse/HBASE-22003
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> [ERROR] Failures:
> [ERROR] TestVerifyReplication.testHBase14905:246 expected:<3> but was:<2>
> [ERROR] Errors:
> [ERROR]
> org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
> [ERROR] Run 1: TestVerifyReplicationCrossDiffHdfs.testVerifyRepBySnapshot:199
> » TestTimedOut ...
> [ERROR] Run 2:
> TestVerifyReplicationCrossDiffHdfs.org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
> »
>
> It failed many time when i try all ut for branch-2.2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #260: HBASE-22486 Fix flaky test TestLockManager
Apache-HBase commented on issue #260: HBASE-22486 Fix flaky test TestLockManager URL: https://github.com/apache/hbase/pull/260#issuecomment-496641457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 191 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 288 | master passed | | +1 | compile | 59 | master passed | | +1 | checkstyle | 70 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 187 | master passed | | +1 | javadoc | 36 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 260 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 276 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1118 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 221 | the patch passed | | +1 | javadoc | 34 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 13479 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 17007 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-260/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/260 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 37d5dd5631ac 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 97090560a5 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-260/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-260/2/testReport/ | | Max. process+thread count | 4504 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-260/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850027#comment-16850027 ] stack commented on HBASE-22467: --- You need this in 2.1.5 [~elserj] ? Was going to start a new RC build. I can wait if commit will happen soon else will punt to 2.1.6. Thanks. BTW, changes look good to me. Are the *.jamon changes related? Or just cleanup? > WebUI changes to enable Apache Knox UI proxying > --- > > Key: HBASE-22467 > URL: https://issues.apache.org/jira/browse/HBASE-22467 > Project: HBase > Issue Type: Improvement > Components: UI >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.1.5, 2.2.1 > > Attachments: HBASE-22467.001.patch, HBASE-22467.002.patch, > HBASE-22467.003.patch > > > Apache Knox's gateway is nice in that it can provide centralized > authentication and authorization for a collection of service. Additionally, > it can expose "private" nodes through a single point (e.g. a gateway). This > makes our life as developers much easier in cloud deployments where it's not > straightforward to access nodes (e.g. they're running on some private > network). > KNOX-1866 captures the changes over there required to make HBase's proxying > actually work (definition lives there), but there were a few things we do in > our UI which made it hard/impossible to proxy it correctly. > * ProfilerServlet was dropping extra query parameters in the URL > * JSON task output on master/regionserver couldn't be disambiguated > * Some missing /master-status and /rs-status links couldn't be disambiguated > properly due to a lack of context > * Missing content-type set on a profiler servlet response -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22003) Fix flaky test TestVerifyReplication.testHBase14905
[
https://issues.apache.org/jira/browse/HBASE-22003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850020#comment-16850020
]
Hudson commented on HBASE-22003:
Results for branch branch-2
[build #1928 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1928/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1928//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1928//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1928//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1928//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Fix flaky test TestVerifyReplication.testHBase14905
> ---
>
> Key: HBASE-22003
> URL: https://issues.apache.org/jira/browse/HBASE-22003
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> [ERROR] Failures:
> [ERROR] TestVerifyReplication.testHBase14905:246 expected:<3> but was:<2>
> [ERROR] Errors:
> [ERROR]
> org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
> [ERROR] Run 1: TestVerifyReplicationCrossDiffHdfs.testVerifyRepBySnapshot:199
> » TestTimedOut ...
> [ERROR] Run 2:
> TestVerifyReplicationCrossDiffHdfs.org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
> »
>
> It failed many time when i try all ut for branch-2.2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22003) Fix flaky test TestVerifyReplication.testHBase14905
[
https://issues.apache.org/jira/browse/HBASE-22003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850019#comment-16850019
]
Hudson commented on HBASE-22003:
Results for branch master
[build #1049 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1049/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1049//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1049//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1049//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1049//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Fix flaky test TestVerifyReplication.testHBase14905
> ---
>
> Key: HBASE-22003
> URL: https://issues.apache.org/jira/browse/HBASE-22003
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
>
> [ERROR] Failures:
> [ERROR] TestVerifyReplication.testHBase14905:246 expected:<3> but was:<2>
> [ERROR] Errors:
> [ERROR]
> org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
> [ERROR] Run 1: TestVerifyReplicationCrossDiffHdfs.testVerifyRepBySnapshot:199
> » TestTimedOut ...
> [ERROR] Run 2:
> TestVerifyReplicationCrossDiffHdfs.org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
> »
>
> It failed many time when i try all ut for branch-2.2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22469) replace md5 checksum in saveVersion script with sha512 for hbase version information
[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850014#comment-16850014
]
HBase QA commented on HBASE-22469:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
37s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}245m 31s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
56s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}260m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/437/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22469 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970035/HBASE-22469.v02.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc
unit |
| uname | Linux 6ad8003c9710 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 97090560a5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| shellcheck | v0.4.4 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/437/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/437/testReport/ |
| Max. process+thread count | 5477 (vs. ulimit of 1) |
| modules | C: hbase-common hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/437/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
>
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
[jira] [Commented] (HBASE-15867) Move HBase replication tracking from ZooKeeper to HBase
[ https://issues.apache.org/jira/browse/HBASE-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850008#comment-16850008 ] Xu Cang commented on HBASE-15867: - thanks [~openinx]! Good info! One thing I want to discuss is, if we finish all tasks above mentioned, will we track peer changes in table or we only keep the current peer information? If no, should we also consider adding this? Peer changes are not that frequent, storing all peer changes into a DB is very useful for understanding certain system behavior. Lacking this information is a big disadvantage since we don't log peer changes into logs either. So, when someone asks "what peers did this cluster have during certain date", we just cannot answer it with proofs, which is not good. Want to know what do you think about this and do you have solution in some ways? [~openinx] thanks again. > Move HBase replication tracking from ZooKeeper to HBase > --- > > Key: HBASE-15867 > URL: https://issues.apache.org/jira/browse/HBASE-15867 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.1.0 >Reporter: Joseph >Assignee: Zheng Hu >Priority: Major > Fix For: 2.3.0 > > > Move the WAL file and offset tracking out of ZooKeeper and into an HBase > table called hbase:replication. > The largest three new changes will be two classes ReplicationTableBase, > TableBasedReplicationQueues, and TableBasedReplicationQueuesClient. As of now > ReplicationPeers and HFileRef's tracking will not be implemented. Subtasks > have been filed for these two jobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22393) HBOSS: Shade curator to prevent conflict with Hadoop
[
https://issues.apache.org/jira/browse/HBASE-22393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849977#comment-16849977
]
Josh Elser commented on HBASE-22393:
[^0001-HBASE-22393.patch] looks OK to me, but would probably be good to wait
for Busbey to come back :)
> HBOSS: Shade curator to prevent conflict with Hadoop
>
>
> Key: HBASE-22393
> URL: https://issues.apache.org/jira/browse/HBASE-22393
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Mackrory
>Assignee: Sean Mackrory
>Priority: Critical
> Labels: HBOSS
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments:
> 0001-HBASE-22393-HBOSS-Shade-dependencies-to-prevent-conf.patch,
> 0001-HBASE-22393.patch, HBASE-22393.001.patch, HBASE-22393.002.patch
>
>
> Hadoop uses a very old version of Curator, and if it ever ends up in the
> classpath with HBOSS you can get this:
> {code}Exception in thread "main" java.lang.IllegalAccessError: tried to
> access method
> org.apache.curator.framework.recipes.locks.InterProcessMutex.isOwnedByCurrentThread()Z
> from class org.apache.hadoop.hbase.oss.sync.ZKTreeLockManager{code}
> I think the simplest solution is to just shade Curator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22487) getMostLoadedRegions is unused
[
https://issues.apache.org/jira/browse/HBASE-22487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clay B. updated HBASE-22487:
Attachment: 0001-HBASE-22487-getMostLoadedRegions-is-unused.patch
Status: Patch Available (was: Open)
This is a trivial patch which simply removes the uncalled code.
> getMostLoadedRegions is unused
> --
>
> Key: HBASE-22487
> URL: https://issues.apache.org/jira/browse/HBASE-22487
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: 0001-HBASE-22487-getMostLoadedRegions-is-unused.patch
>
>
> Reading {{HRegionServer.java}}, I noticed the function
> {{getMostLoadedRegions}} this seems to replicate functionality found now in
> the {{StochasticLoadBalancer.}} Further, it seems the only consumer of this
> function was removed in HBASE-805.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] busbey commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support
busbey commented on a change in pull request #239: HBASE-22409 update branch-1
ref guide for Hadoop, Java, and HBase version support
URL: https://github.com/apache/hbase/pull/239#discussion_r288221005
##
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##
@@ -81,20 +83,27 @@ To see the usage, use the `--help` parameter.
$ ${HBASE_HOME}/bin/hbase canary -help
-Usage: bin/hbase org.apache.hadoop.hbase.tool.Canary [opts] [table1
[table2]...] | [regionserver1 [regionserver2]..]
+Usage: hbase org.apache.hadoop.hbase.tool.Canary [opts] [table1 [table2]...] |
[regionserver1 [regionserver2]..]
where [opts] are:
-help Show this help and exit.
-regionserver replace the table argument to regionserver,
which means to enable regionserver mode
+ -allRegionsTries all regions on a regionserver,
+ only works in regionserver mode.
+ -zookeeperTries to grab zookeeper.znode.parent
+ on each zookeeper instance
-daemonContinuous check at defined intervals.
Review comment:
this was added to the master ref guide in HBASE-21320. let me see if all
those related changes work for branch-1.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support
busbey commented on a change in pull request #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support URL: https://github.com/apache/hbase/pull/239#discussion_r288219646 ## File path: src/main/site/site.xml ## @@ -77,12 +77,17 @@ - - - - - - + + + + + + + Review comment: Good question. This menu item came in as a part of one of the version change updates. We still host the 1.1 javadocs and ref guide, so there's no harm pointing to them. There is a later commit that removes 1.1 (as evidenced by us no longer linking to 1.1 on the main website). I could track that down and include it as well if you like. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #258: HBASE-22485 Fix failed ut TestClusterRestartFailover
Apache-HBase commented on issue #258: HBASE-22485 Fix failed ut TestClusterRestartFailover URL: https://github.com/apache/hbase/pull/258#issuecomment-496611714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 24 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 261 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 68 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 230 | master passed | | +1 | javadoc | 36 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 256 | the patch passed | | +1 | compile | 61 | the patch passed | | +1 | javac | 61 | the patch passed | | +1 | checkstyle | 73 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 279 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1009 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 221 | the patch passed | | +1 | javadoc | 33 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 7927 | hbase-server in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 11127 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-258/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/258 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 708cd492429d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 97090560a5 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-258/3/testReport/ | | Max. process+thread count | 4579 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-258/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22148:
Release Note:
The `CellUtil.setTimestamp` method changes to be an API with audience
`LimitedPrivate(COPROC)` in HBase 3.0. With that designation the API should
remain stable within a given minor release line, but may change between minor
releases.
Previously, this method was deprecated in HBase 2.0 for removal in HBase 3.0.
Deprecation messages in HBase 2.y releases have been updated to indicate the
expected API audience change.
was:
The `CellUtil.setTimestamp` changes to be an API with audience
`LimitedPrivate(COPROC)` in HBase 3.0. With that designation the API should
remain stable within a given minor release line, but may change between minor
releases.
Previously, this method was deprecated in HBase 2.0 for removal in HBase 3.0.
Deprecation messages in HBase 2.y releases have been updated to indicate the
expected API audience change.
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22148) Provide an alternative to CellUtil.setTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22148:
Resolution: Fixed
Fix Version/s: 2.1.6
2.2.1
2.0.6
2.3.0
Release Note:
The `CellUtil.setTimestamp` changes to be an API with audience
`LimitedPrivate(COPROC)` in HBase 3.0. With that designation the API should
remain stable within a given minor release line, but may change between minor
releases.
Previously, this method was deprecated in HBase 2.0 for removal in HBase 3.0.
Deprecation messages in HBase 2.y releases have been updated to indicate the
expected API audience change.
Status: Resolved (was: Patch Available)
> Provide an alternative to CellUtil.setTimestamp
>
>
> Key: HBASE-22148
> URL: https://issues.apache.org/jira/browse/HBASE-22148
> Project: HBase
> Issue Type: New Feature
> Components: API, Coprocessors
>Affects Versions: 3.0.0
>Reporter: Thomas D'Silva
>Assignee: Sean Busbey
>Priority: Blocker
> Labels: phoenix
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22148-branch-2.v0.patch, HBASE-22148.0.patch
>
>
> {{CellUtil.setTimestamp}} has been deprecated in 2.0 and is marked for
> removal in 3.0. Phoenix currently uses this api to set the timestamp of cells
> in its indexing coprocessor for tables that have mutable indexes. We can't
> use the CellBuilder api since this involves creating a copy of the cell which
> will be expensive.
> FYI @stack
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #258: HBASE-22485 Fix failed ut TestClusterRestartFailover
Apache-HBase commented on issue #258: HBASE-22485 Fix failed ut TestClusterRestartFailover URL: https://github.com/apache/hbase/pull/258#issuecomment-496609908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 24 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 264 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 69 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 206 | master passed | | +1 | javadoc | 32 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 239 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 69 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 987 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. | | +1 | findbugs | 220 | the patch passed | | +1 | javadoc | 32 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8042 | hbase-server in the patch passed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 11160 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-258/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/258 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 59ba6605f038 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 97090560a5 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-258/2/testReport/ | | Max. process+thread count | 4320 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-258/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser opened a new pull request #261: HBASE-22467 UI fixes to enable Knox proxying
joshelser opened a new pull request #261: HBASE-22467 UI fixes to enable Knox proxying URL: https://github.com/apache/hbase/pull/261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
