[GitHub] [hbase] Apache-HBase commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Apache-HBase commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#issuecomment-498948265 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 790 | Docker mode activated. | ||| _ Prechecks _ | | 0 | findbugs | 1 | Findbugs executables are not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 113 | branch-1 passed | | +1 | compile | 37 | branch-1 passed with JDK v1.8.0_212 | | +1 | compile | 42 | branch-1 passed with JDK v1.7.0_222 | | +1 | checkstyle | 80 | branch-1 passed | | +1 | shadedjars | 165 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 30 | branch-1 passed with JDK v1.8.0_212 | | +1 | javadoc | 38 | branch-1 passed with JDK v1.7.0_222 | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 98 | the patch passed | | +1 | compile | 37 | the patch passed with JDK v1.8.0_212 | | +1 | javac | 37 | the patch passed | | +1 | compile | 41 | the patch passed with JDK v1.7.0_222 | | +1 | javac | 41 | the patch passed | | +1 | checkstyle | 81 | hbase-server: The patch generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 168 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 198 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 28 | the patch passed with JDK v1.8.0_212 | | +1 | javadoc | 37 | the patch passed with JDK v1.7.0_222 | ||| _ Other Tests _ | | +1 | unit | 6246 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 8434 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/288 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 114f8c111ed4 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-1 / 749d58f | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_222 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/2/testReport/ | | Max. process+thread count | 3784 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[
https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856365#comment-16856365
]
Hudson commented on HBASE-22160:
Results for branch master
[build #1093 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1093/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1093//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1093//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1093//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add sorting functionality in regionserver web UI for user regions
> -
>
> Key: HBASE-22160
> URL: https://issues.apache.org/jira/browse/HBASE-22160
> Project: HBase
> Issue Type: Improvement
> Components: monitoring, regionserver, UI, Usability
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22160.branch2.001.patch,
> HBASE-22160.master.001.patch, HBASE-22160.master.001.patch,
> HBASE-22160.master.002.patch, HBASE-22160.master.003.patch, Screen Shot
> 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png, Screen
> Shot 2019-05-29 at 11.42.29.png, Screen Shot 2019-05-30 at 1.03.15 AM.png,
> Screen Shot 2019-05-30 at 1.04.40 AM.png, Screen Shot 2019-05-30 at
> 14.23.34.png
>
>
> Should be good to have the same sort of sorting functionality, like hmaster
> via HBASE-21207, in regionserver web UI for the list of regions too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #168: HBASE-22271 Implement grant/revoke/delete table acls/delete namespace acls in Procedure
Apache-HBase commented on issue #168: HBASE-22271 Implement grant/revoke/delete table acls/delete namespace acls in Procedure URL: https://github.com/apache/hbase/pull/168#issuecomment-498945384 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 27 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 9 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 23 | Maven dependency ordering for branch | | +1 | mvninstall | 241 | master passed | | +1 | compile | 161 | master passed | | +1 | checkstyle | 145 | master passed | | +1 | shadedjars | 257 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 510 | master passed | | +1 | javadoc | 104 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 223 | the patch passed | | +1 | compile | 158 | the patch passed | | +1 | cc | 158 | the patch passed | | +1 | javac | 158 | the patch passed | | +1 | checkstyle | 8 | The patch passed checkstyle in hbase-protocol-shaded | | +1 | checkstyle | 31 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 12 | The patch passed checkstyle in hbase-procedure | | +1 | checkstyle | 70 | hbase-server: The patch generated 0 new + 302 unchanged - 4 fixed = 302 total (was 306) | | +1 | checkstyle | 28 | The patch passed checkstyle in hbase-thrift | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 704 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 134 | the patch passed | | +1 | findbugs | 534 | the patch passed | | +1 | javadoc | 104 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 34 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 130 | hbase-client in the patch passed. | | +1 | unit | 200 | hbase-procedure in the patch passed. | | +1 | unit | 8263 | hbase-server in the patch passed. | | +1 | unit | 214 | hbase-thrift in the patch passed. | | +1 | asflicense | 100 | The patch does not generate ASF License warnings. | | | | 13062 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/168 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux b64b53fa1bae 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 9b23e1d00c | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/6/testReport/ | | Max. process+thread count | 4583 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/6/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856358#comment-16856358
]
Hudson commented on HBASE-22534:
Results for branch branch-2
[build #1964 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1964/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1964//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1964//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1964//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1964//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21920) Ignoring 'empty' end_key while calculating end_key for new region in HBCK -fixHdfsOverlaps command can cause data loss
[
https://issues.apache.org/jira/browse/HBASE-21920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856336#comment-16856336
]
Toshihiro Suzuki commented on HBASE-21920:
--
LGTM.
Reattaching the latest patch to rerun QA.
> Ignoring 'empty' end_key while calculating end_key for new region in HBCK
> -fixHdfsOverlaps command can cause data loss
> --
>
> Key: HBASE-21920
> URL: https://issues.apache.org/jira/browse/HBASE-21920
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.0.0
>Reporter: Syeda Arshiya Tabreen
>Assignee: Syeda Arshiya Tabreen
>Priority: Major
> Attachments: HBASE-21920.branch-1.001.patch,
> HBASE-21920.branch-1.002.patch, HBASE-21920.branch-1.002.patch,
> HBASE-21920.branch-1.002.patch, HBASE-21920.branch-1.002.patch,
> HBASE-21920.branch-1.patch
>
>
> When running *-fixHdfsOverlaps* command due to overlap in the regions of the
> table ,it moves all the hfiles of overlapping regions into new region with
> start_key and end_key calculating based on minimum and maximum start_key and
> end_key of all overlapping regions.
> When calculating start_key and end_key for new region,end_key with 'empty' is
> not considered which leads to data loss when scanned using '*startrow'.*
> *For example:*
> 1.create table 't'
> 2.Insert records \{00,111,200} into the table 't'and flush the data
> 3.split the table 't' with split-key '100'
> 4.Now we have three regions( 1 parent and two daughter regions )
> 1.*Region-1*('Empty','Empty') => \{00,111,200}
> 2.*Region-2*('Empty','100')=>\{00}
> 3.*Region-3*('100','Empty')=>\{111,200}
> 5.Make sure parent region is not deleted in file system and run
> -*fixHdfsOverlaps* command
> This -*fixHdfsOverlaps* command will move all the hfiles of the three regions
> {*Region-1,Region- 2,Region-3*} into a new region(*Region-4*) created with
> start_key='*Empty'* and end_key='*100'*
> This is because it does not consider end_key=*'Empty'* and considers
> end_key=*'100'* as maximum which in turn makes all the hfiles of three
> regions to move into new region even if records in hfile is more than the
> end_key='*100'* and one empty region *Region -5 (100,Empty)* will be
> created because table region end key was not empty.
> Now we have 2 regions:
> 1.*Region-4*(Empty,100)=>\{00,111,200}
> 2.*Region-5*(100,Empty)=>{}
> when the entire table scan is done, all the records will be displayed, there
> wont be any data loss but scan with start_key is done below are the results:
> 1.scan 't', \{ STARTROW => '00'} => \{00,111,200}
> 2.scan 't', \{ STARTROW => '100'}=>{}
> The second scan will give empty result because it searches the rows in
> *Region -5*(100,Empty) which contains no records but records \{111,200} is
> present in *Region-4*(Empty,100).
> The problem exists only when end_key=*'Empty'* is present in any of the
> overlapping regions.I think if end_key is present in any of the overlapping
> regions,we have to consider it as maximum end_key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21920) Ignoring 'empty' end_key while calculating end_key for new region in HBCK -fixHdfsOverlaps command can cause data loss
[
https://issues.apache.org/jira/browse/HBASE-21920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Toshihiro Suzuki updated HBASE-21920:
-
Attachment: HBASE-21920.branch-1.002.patch
> Ignoring 'empty' end_key while calculating end_key for new region in HBCK
> -fixHdfsOverlaps command can cause data loss
> --
>
> Key: HBASE-21920
> URL: https://issues.apache.org/jira/browse/HBASE-21920
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 1.0.0
>Reporter: Syeda Arshiya Tabreen
>Assignee: Syeda Arshiya Tabreen
>Priority: Major
> Attachments: HBASE-21920.branch-1.001.patch,
> HBASE-21920.branch-1.002.patch, HBASE-21920.branch-1.002.patch,
> HBASE-21920.branch-1.002.patch, HBASE-21920.branch-1.002.patch,
> HBASE-21920.branch-1.patch
>
>
> When running *-fixHdfsOverlaps* command due to overlap in the regions of the
> table ,it moves all the hfiles of overlapping regions into new region with
> start_key and end_key calculating based on minimum and maximum start_key and
> end_key of all overlapping regions.
> When calculating start_key and end_key for new region,end_key with 'empty' is
> not considered which leads to data loss when scanned using '*startrow'.*
> *For example:*
> 1.create table 't'
> 2.Insert records \{00,111,200} into the table 't'and flush the data
> 3.split the table 't' with split-key '100'
> 4.Now we have three regions( 1 parent and two daughter regions )
> 1.*Region-1*('Empty','Empty') => \{00,111,200}
> 2.*Region-2*('Empty','100')=>\{00}
> 3.*Region-3*('100','Empty')=>\{111,200}
> 5.Make sure parent region is not deleted in file system and run
> -*fixHdfsOverlaps* command
> This -*fixHdfsOverlaps* command will move all the hfiles of the three regions
> {*Region-1,Region- 2,Region-3*} into a new region(*Region-4*) created with
> start_key='*Empty'* and end_key='*100'*
> This is because it does not consider end_key=*'Empty'* and considers
> end_key=*'100'* as maximum which in turn makes all the hfiles of three
> regions to move into new region even if records in hfile is more than the
> end_key='*100'* and one empty region *Region -5 (100,Empty)* will be
> created because table region end key was not empty.
> Now we have 2 regions:
> 1.*Region-4*(Empty,100)=>\{00,111,200}
> 2.*Region-5*(100,Empty)=>{}
> when the entire table scan is done, all the records will be displayed, there
> wont be any data loss but scan with start_key is done below are the results:
> 1.scan 't', \{ STARTROW => '00'} => \{00,111,200}
> 2.scan 't', \{ STARTROW => '100'}=>{}
> The second scan will give empty result because it searches the rows in
> *Region -5*(100,Empty) which contains no records but records \{111,200} is
> present in *Region-4*(Empty,100).
> The problem exists only when end_key=*'Empty'* is present in any of the
> overlapping regions.I think if end_key is present in any of the overlapping
> regions,we have to consider it as maximum end_key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-22540. --- Resolution: Fixed Hadoop Flags: Reviewed > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 1.5.0, 1.4.11 > > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22540: -- Fix Version/s: 1.4.11 1.5.0 > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 1.5.0, 1.4.11 > > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22540: -- Affects Version/s: 1.4.6 > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.6 >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 1.5.0, 1.4.11 > > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856330#comment-16856330 ] Reid Chan commented on HBASE-22540: --- Skimmed, master and branch-2 are big different from branch-1. Filing another JIRA forward-port is more suitable, IMO. > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Reidddddd merged pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Reidd merged pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Reidd commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#issuecomment-498928986 Thank you sir, @apurtell It's a small improvement, I think it should not occupy too much time of you. Please allow me S, free to revert or ping me if any inappropriate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22516) release hbase-filesystem version 1.0.0-alpha1
[
https://issues.apache.org/jira/browse/HBASE-22516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856307#comment-16856307
]
Sean Busbey commented on HBASE-22516:
-
tag for RC0:
https://gitbox.apache.org/repos/asf?p=hbase-filesystem.git;a=tag;h=refs/tags/1.0.0-alpha1-RC0
and I deployed a staged repository to the asf nexus:
https://repository.apache.org/content/repositories/orgapachehbase-1321/
> release hbase-filesystem version 1.0.0-alpha1
> -
>
> Key: HBASE-22516
> URL: https://issues.apache.org/jira/browse/HBASE-22516
> Project: HBase
> Issue Type: Task
> Components: community, Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments: hbase-filesystem-1.0.0-alpha1-src.tar.gz
>
>
> for this first alpha release we haven't evaluated deployment options yet, so
> let's just rely on maven for convenience binaries.
> Rough outline of process:
> # review LICENSE / NOTICE files
> # Make sure rat says our files are fine wrt license headers ({{mvn
> apache-rat:check}})
> # Check git vs jira for a correct list of issues included in the release
> # use Apache Yetus Release Doc Maker to generate release notes / changes and
> check into repo
> # update versions to be non-SNAPSHOT
> # make sure we can still build jars
> # tag RC ({{git tag -s 1.0.0-alpha1-RC0 -m "HBASE- Tagging the
> 1.0.0-alpha1 first Releae Candidate" && git push origin 1.0.0-alpha1-RC0}})
> # use the git archive command to create a source artifact ({{git archive
> --format=tar.gz
> --output="/tmp/hbase-filesystem-1.0.0-alpha1-RC0/hbase-filesystem-1.0.0-alpha1-src.tar.gz"
> --prefix="hbase-filesystem-1.0.0-alpha1/" 1.0.0-alpha1-RC0}})
> # stage the RC artifacts somewhere accessible by https. Should include
> release notes, changes, and source artifact. each of those should have a gpg
> signature and a sha512 checksum file.
> # stage maven repository (tl;dr: {{mvn deploy -DskipTests -Papache-release}}
> and then https://repository.apache.org. See the longer explanation under the
> steps "Deploy to the Maven Repository" and "Make the Release Candidate
> available" in the [Making a Release
> Candidate|http://hbase.apache.org/book.html#maven.release] ref guide section
> for the main project)
> # call VOTE for release candidate. Include the staged artifacts, staged maven
> repository, any critical issues that need summary
> # iterate on RCs if needed due to VOTE feedback
> # When VOTE passes, tag {{rel/1.0.0-alpha1}}, release maven repository,
> publish artifacts on dist.apache.org, send ANNOUNCE email, and prepare repo
> for further development
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Reidddddd edited a comment on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Reidd edited a comment on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#issuecomment-498927044 2nd commit removed the parent thread info from statistics thread which looks like this``StoreOpener-79d229f8aa7a4a99bfbff213cb37ab0f-1-MemStoreChunkPool Statistics``, there is only one MemStoreChunkPool instance in RS. And address one nit, "got" > "requested". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Reidd commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#issuecomment-498927044 2nd Commit removed the parent thread info from statistics thread which looks like this``StoreOpener-79d229f8aa7a4a99bfbff213cb37ab0f-1-MemStoreChunkPool Statistics``, there is only one MemStoreChunkPool instance in RS. And address one nit, "got" > "requested". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856295#comment-16856295
]
Hudson commented on HBASE-22534:
Results for branch branch-2.2
[build #333 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/333/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/333//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/333//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/333//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856292#comment-16856292
]
Hudson commented on HBASE-22534:
Results for branch master
[build #1092 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1092/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1092//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1092//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1092//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22541) Backport HBASE-22160 "Add sorting functionality in regionserver web UI for user regions" to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856282#comment-16856282 ] Daisuke Kobayashi commented on HBASE-22541: --- Sure, thanks! > Backport HBASE-22160 "Add sorting functionality in regionserver web UI for > user regions" to branch-1 > > > Key: HBASE-22541 > URL: https://issues.apache.org/jira/browse/HBASE-22541 > Project: HBase > Issue Type: Sub-task > Components: backport >Reporter: Toshihiro Suzuki >Assignee: Daisuke Kobayashi >Priority: Major > > Backport parent issue to branch-1. Hope you don't mind my assigning it to you > [~daisuke.kobayashi] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Reidddddd commented on a change in pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Reidd commented on a change in pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#discussion_r290566438 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreChunkPool.java ## @@ -77,6 +77,7 @@ private static final int statThreadPeriod = 60 * 5; private AtomicLong createdChunkCount = new AtomicLong(); private AtomicLong reusedChunkCount = new AtomicLong(); + private AtomicLong gotChunkCount = new AtomicLong(); Review comment: It's a counter for the number of method `Chunk#getChunk` get called. Agree, "got" is not good. What about `requestedChunkCount`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856277#comment-16856277 ] Zheng Hu commented on HBASE-22539: -- It's strange that ByteBufferUtils.copyFromBufferToArray would made the difference. bq. apart from minor improvement reported on HBASE-22496, which shouldn't be causing this corruption Still got the corruption after applied HBASE-22496 in your clusters, you mean ? In theory, HBASE-22496 was a risk for corruption.. > Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place > - > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22541) Backport HBASE-22160 "Add sorting functionality in regionserver web UI for user regions" to branch-1
Toshihiro Suzuki created HBASE-22541: Summary: Backport HBASE-22160 "Add sorting functionality in regionserver web UI for user regions" to branch-1 Key: HBASE-22541 URL: https://issues.apache.org/jira/browse/HBASE-22541 Project: HBase Issue Type: Sub-task Components: backport Reporter: Toshihiro Suzuki Assignee: Daisuke Kobayashi Backport parent issue to branch-1. Hope you don't mind my assigning it to you [~daisuke.kobayashi] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-22160: - Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master, branch-2, branch-2.2 and branch-2.1. Will create a new Jira for a backport for this to branch-1. > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, > HBASE-22160.master.002.patch, HBASE-22160.master.003.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png, Screen > Shot 2019-05-29 at 11.42.29.png, Screen Shot 2019-05-30 at 1.03.15 AM.png, > Screen Shot 2019-05-30 at 1.04.40 AM.png, Screen Shot 2019-05-30 at > 14.23.34.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-22160: - Hadoop Flags: Reviewed > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, > HBASE-22160.master.002.patch, HBASE-22160.master.003.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png, Screen > Shot 2019-05-29 at 11.42.29.png, Screen Shot 2019-05-30 at 1.03.15 AM.png, > Screen Shot 2019-05-30 at 1.04.40 AM.png, Screen Shot 2019-05-30 at > 14.23.34.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-22160: - Fix Version/s: 2.1.6 2.2.1 2.3.0 3.0.0 > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, > HBASE-22160.master.002.patch, HBASE-22160.master.003.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png, Screen > Shot 2019-05-29 at 11.42.29.png, Screen Shot 2019-05-30 at 1.03.15 AM.png, > Screen Shot 2019-05-30 at 1.04.40 AM.png, Screen Shot 2019-05-30 at > 14.23.34.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22533) TestAccessController3 is flaky (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856252#comment-16856252
]
Hudson commented on HBASE-22533:
Results for branch branch-1
[build #875 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/875/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/875//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/875//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/875//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> TestAccessController3 is flaky (branch-1)
> -
>
> Key: HBASE-22533
> URL: https://issues.apache.org/jira/browse/HBASE-22533
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.4.10, 1.3.5
>
> Attachments: HBASE-22533-branch-1.patch
>
>
> Wait for table create to complete before taking further action in security
> tests. Avoid a noisy NPE if test initialization fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856251#comment-16856251
]
Hudson commented on HBASE-22536:
Results for branch master
[build #1090 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1090/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1090//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1090//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1090//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1090//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856239#comment-16856239 ] Toshihiro Suzuki commented on HBASE-22160: -- +1 for the latest patch. Let me commit it. > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, > HBASE-22160.master.002.patch, HBASE-22160.master.003.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png, Screen > Shot 2019-05-29 at 11.42.29.png, Screen Shot 2019-05-30 at 1.03.15 AM.png, > Screen Shot 2019-05-30 at 1.04.40 AM.png, Screen Shot 2019-05-30 at > 14.23.34.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22458) TestClassFinder fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856228#comment-16856228
]
HBase QA commented on HBASE-22458:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
16s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/491/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22458 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970895/hbase-22458.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 122cd6ede6aa 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26
12:43:40 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9b23e1d00c |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/491/testReport/ |
| Max. process+thread count | 351 (vs. ulimit of 1) |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/491/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> TestClassFinder fails when
[jira] [Commented] (HBASE-22533) TestAccessController3 is flaky (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856220#comment-16856220
]
Hudson commented on HBASE-22533:
Results for branch branch-1.3
[build #805 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/805/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/805//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/805//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/805//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> TestAccessController3 is flaky (branch-1)
> -
>
> Key: HBASE-22533
> URL: https://issues.apache.org/jira/browse/HBASE-22533
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.4.10, 1.3.5
>
> Attachments: HBASE-22533-branch-1.patch
>
>
> Wait for table create to complete before taking further action in security
> tests. Avoid a noisy NPE if test initialization fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22533) TestAccessController3 is flaky (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856218#comment-16856218
]
Hudson commented on HBASE-22533:
Results for branch branch-1.4
[build #833 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/833/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/833//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/833//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/833//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> TestAccessController3 is flaky (branch-1)
> -
>
> Key: HBASE-22533
> URL: https://issues.apache.org/jira/browse/HBASE-22533
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.4.10, 1.3.5
>
> Attachments: HBASE-22533-branch-1.patch
>
>
> Wait for table create to complete before taking further action in security
> tests. Avoid a noisy NPE if test initialization fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22458) TestClassFinder fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22458:
---
Component/s: test
java
> TestClassFinder fails when run on JDK11
> ---
>
> Key: HBASE-22458
> URL: https://issues.apache.org/jira/browse/HBASE-22458
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22458.master.001.patch,
> hbase-22458.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestClassFinder
> fails. A sample stacktrace:
> {code:java}
> java.lang.ClassCastException: class
> jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class
> java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and
> java.net.URLClassLoader are in module java.base of loader 'bootstrap')
> at
> org.apache.hadoop.hbase.TestClassFinder.packageAndLoadJar(TestClassFinder.java:418)
> at
> org.apache.hadoop.hbase.TestClassFinder.createAndLoadJar(TestClassFinder.java:193)
> at
> org.apache.hadoop.hbase.TestClassFinder.testClassFinderCanFindClassesInDirs(TestClassFinder.java:233){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22458) TestClassFinder fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22458:
---
Status: Patch Available (was: In Progress)
> TestClassFinder fails when run on JDK11
> ---
>
> Key: HBASE-22458
> URL: https://issues.apache.org/jira/browse/HBASE-22458
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22458.master.001.patch,
> hbase-22458.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestClassFinder
> fails. A sample stacktrace:
> {code:java}
> java.lang.ClassCastException: class
> jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class
> java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and
> java.net.URLClassLoader are in module java.base of loader 'bootstrap')
> at
> org.apache.hadoop.hbase.TestClassFinder.packageAndLoadJar(TestClassFinder.java:418)
> at
> org.apache.hadoop.hbase.TestClassFinder.createAndLoadJar(TestClassFinder.java:193)
> at
> org.apache.hadoop.hbase.TestClassFinder.testClassFinderCanFindClassesInDirs(TestClassFinder.java:233){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856209#comment-16856209
]
Hudson commented on HBASE-22534:
Results for branch branch-2.1
[build #1231 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1231/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1231//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1231//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1231//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22458) TestClassFinder fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22458:
---
Attachment: hbase-22458.master.002.patch
> TestClassFinder fails when run on JDK11
> ---
>
> Key: HBASE-22458
> URL: https://issues.apache.org/jira/browse/HBASE-22458
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22458.master.001.patch,
> hbase-22458.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestClassFinder
> fails. A sample stacktrace:
> {code:java}
> java.lang.ClassCastException: class
> jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class
> java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and
> java.net.URLClassLoader are in module java.base of loader 'bootstrap')
> at
> org.apache.hadoop.hbase.TestClassFinder.packageAndLoadJar(TestClassFinder.java:418)
> at
> org.apache.hadoop.hbase.TestClassFinder.createAndLoadJar(TestClassFinder.java:193)
> at
> org.apache.hadoop.hbase.TestClassFinder.testClassFinderCanFindClassesInDirs(TestClassFinder.java:233){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work started] (HBASE-22458) TestClassFinder fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22458 started by Sakthi.
--
> TestClassFinder fails when run on JDK11
> ---
>
> Key: HBASE-22458
> URL: https://issues.apache.org/jira/browse/HBASE-22458
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22458.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestClassFinder
> fails. A sample stacktrace:
> {code:java}
> java.lang.ClassCastException: class
> jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class
> java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and
> java.net.URLClassLoader are in module java.base of loader 'bootstrap')
> at
> org.apache.hadoop.hbase.TestClassFinder.packageAndLoadJar(TestClassFinder.java:418)
> at
> org.apache.hadoop.hbase.TestClassFinder.createAndLoadJar(TestClassFinder.java:193)
> at
> org.apache.hadoop.hbase.TestClassFinder.testClassFinderCanFindClassesInDirs(TestClassFinder.java:233){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22458) TestClassFinder fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22458:
---
Attachment: hbase-22458.master.001.patch
> TestClassFinder fails when run on JDK11
> ---
>
> Key: HBASE-22458
> URL: https://issues.apache.org/jira/browse/HBASE-22458
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22458.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestClassFinder
> fails. A sample stacktrace:
> {code:java}
> java.lang.ClassCastException: class
> jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class
> java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and
> java.net.URLClassLoader are in module java.base of loader 'bootstrap')
> at
> org.apache.hadoop.hbase.TestClassFinder.packageAndLoadJar(TestClassFinder.java:418)
> at
> org.apache.hadoop.hbase.TestClassFinder.createAndLoadJar(TestClassFinder.java:193)
> at
> org.apache.hadoop.hbase.TestClassFinder.testClassFinderCanFindClassesInDirs(TestClassFinder.java:233){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22264) Separate out jars related to JDK 11 into a folder in /lib
[
https://issues.apache.org/jira/browse/HBASE-22264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856206#comment-16856206
]
Sakthi commented on HBASE-22264:
I plan to get back to this shortly. So should have an update soon, Sean.
> Separate out jars related to JDK 11 into a folder in /lib
> -
>
> Key: HBASE-22264
> URL: https://issues.apache.org/jira/browse/HBASE-22264
> Project: HBase
> Issue Type: Task
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22264.master.001.patch,
> hbase-22264.master.002.patch, hbase-22264.master.003.patch,
> hbase-22264.master.004.patch, hbase-22264.master.005.patch,
> hbase-22264_jdks.txt, run_ITD_with_REST_ClusterManager.log
>
>
> UPDATE:
> Separate out the the jars related to JDK 11 and add control their addition to
> the classpath using an environment variable or auto-detection of the jdk
> version installed.
> OLD:
> This is in continuation with HBASE-22249. When compiled with jdk 8 and run on
> jdk 11, the master branch throws the following exception during an attempt to
> start the hbase rest server:
> {code:java}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> javax/annotation/Priority
> at
> org.glassfish.jersey.model.internal.ComponentBag.modelFor(ComponentBag.java:483)
> at
> org.glassfish.jersey.model.internal.ComponentBag.access$100(ComponentBag.java:89)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:408)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:398)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
> at
> org.glassfish.jersey.model.internal.ComponentBag.registerModel(ComponentBag.java:398)
> at
> org.glassfish.jersey.model.internal.ComponentBag.register(ComponentBag.java:235)
> at
> org.glassfish.jersey.model.internal.CommonConfig.register(CommonConfig.java:420)
> at
> org.glassfish.jersey.server.ResourceConfig.register(ResourceConfig.java:425)
> at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:245)
> at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:421)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856201#comment-16856201
]
Hudson commented on HBASE-22536:
Results for branch branch-2.2
[build #331 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/331/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/331//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/331//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/331//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856200#comment-16856200
]
Hudson commented on HBASE-22536:
Results for branch branch-2
[build #1962 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1962/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1962//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1962//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1962//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856188#comment-16856188
]
Hudson commented on HBASE-21415:
Results for branch master
[build #1089 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1089/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1089//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1089//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1089//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22533) TestAccessController3 is flaky (branch-1)
[ https://issues.apache.org/jira/browse/HBASE-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856149#comment-16856149 ] Hudson commented on HBASE-22533: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #573 (See [https://builds.apache.org/job/HBase-1.3-IT/573/]) HBASE-22533 TestAccessController3 is flaky (branch-1) (apurtell: rev a719a44f9832c3133d9ee595044268761bed62c6) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessControlFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSecureBulkLoadEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java > TestAccessController3 is flaky (branch-1) > - > > Key: HBASE-22533 > URL: https://issues.apache.org/jira/browse/HBASE-22533 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.4.10, 1.3.5 > > Attachments: HBASE-22533-branch-1.patch > > > Wait for table create to complete before taking further action in security > tests. Avoid a noisy NPE if test initialization fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20993) [Auth] IPC client fallback to simple auth allowed doesn't work
[
https://issues.apache.org/jira/browse/HBASE-20993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-20993:
---
Fix Version/s: (was: 1.4.10)
1.4.11
> [Auth] IPC client fallback to simple auth allowed doesn't work
> --
>
> Key: HBASE-20993
> URL: https://issues.apache.org/jira/browse/HBASE-20993
> Project: HBase
> Issue Type: Bug
> Components: Client, IPC/RPC, security
>Affects Versions: 1.2.6, 1.3.2, 1.2.7, 1.4.7
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Critical
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-20993.001.patch,
> HBASE-20993.003.branch-1.flowchart.png, HBASE-20993.branch-1.002.patch,
> HBASE-20993.branch-1.003.patch, HBASE-20993.branch-1.004.patch,
> HBASE-20993.branch-1.005.patch, HBASE-20993.branch-1.006.patch,
> HBASE-20993.branch-1.007.patch, HBASE-20993.branch-1.008.patch,
> HBASE-20993.branch-1.009.patch, HBASE-20993.branch-1.009.patch,
> HBASE-20993.branch-1.010.patch, HBASE-20993.branch-1.011.patch,
> HBASE-20993.branch-1.012.patch, HBASE-20993.branch-1.013.patch,
> HBASE-20993.branch-1.2.001.patch, HBASE-20993.branch-1.wip.002.patch,
> HBASE-20993.branch-1.wip.patch, yetus-local-testpatch-output-009.txt
>
>
> It is easily reproducible.
> client's hbase-site.xml: hadoop.security.authentication:kerberos,
> hbase.security.authentication:kerberos,
> hbase.ipc.client.fallback-to-simple-auth-allowed:true, keytab and principal
> are right set
> A simple auth hbase cluster, a kerberized hbase client application.
> application trying to r/w/c/d table will have following exception:
> {code}
> javax.security.sasl.SaslException: GSS initiate failed [Caused by
> GSSException: No valid credentials provided (Mechanism level: Failed to find
> any Kerberos tgt)]
> at
> com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:211)
> at
> org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:179)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:617)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$700(RpcClientImpl.java:162)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:743)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:740)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1628)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:740)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:906)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:873)
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1241)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:227)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:336)
> at
> org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$BlockingStub.isMasterRunning(MasterProtos.java:58383)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.isMasterRunning(ConnectionManager.java:1592)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1530)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1552)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1581)
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1738)
> at
> org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:134)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4297)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4289)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsyncV2(HBaseAdmin.java:753)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:674)
> at
>
[jira] [Updated] (HBASE-21903) Backport major compaction tool HBASE-19528 from to 1.4 and 1.3
[ https://issues.apache.org/jira/browse/HBASE-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-21903: --- Fix Version/s: (was: 1.4.10) 1.4.11 > Backport major compaction tool HBASE-19528 from to 1.4 and 1.3 > -- > > Key: HBASE-21903 > URL: https://issues.apache.org/jira/browse/HBASE-21903 > Project: HBase > Issue Type: Task > Components: Client, Compaction, tooling >Affects Versions: 1.3.3, 1.4.9 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Fix For: 1.3.6, 1.4.11 > > Attachments: HBASE-21903-branch-1.3-addendum.patch > > > Our internal deployments are based on branch-1.3. We will be using the major > compaction tool HBASE-19528 from [~churromorales] and the enhancements on top > of it HBASE-21883 on our 1.3 clusters. I would like to backport HBASE-19528 > to 1.3 and hence 1.4 as well. Since its a standalone tool without any other > dependency or code changes, I believe that should be ok. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856125#comment-16856125
]
Hudson commented on HBASE-22536:
Results for branch branch-2.1
[build #1230 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1230/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1230//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1230//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1230//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22533) TestAccessController3 is flaky (branch-1)
[ https://issues.apache.org/jira/browse/HBASE-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22533: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.5 1.4.10 Status: Resolved (was: Patch Available) > TestAccessController3 is flaky (branch-1) > - > > Key: HBASE-22533 > URL: https://issues.apache.org/jira/browse/HBASE-22533 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Fix For: 1.5.0, 1.4.10, 1.3.5 > > Attachments: HBASE-22533-branch-1.patch > > > Wait for table create to complete before taking further action in security > tests. Avoid a noisy NPE if test initialization fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856115#comment-16856115
]
Hudson commented on HBASE-22535:
Results for branch branch-2.1
[build #1229 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1229/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1229//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1229//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1229//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856093#comment-16856093
]
Hudson commented on HBASE-22535:
Results for branch master
[build #1088 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1088/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1088//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1088//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1088//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22516) release hbase-filesystem version 1.0.0-alpha1
[
https://issues.apache.org/jira/browse/HBASE-22516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856094#comment-16856094
]
Sean Busbey commented on HBASE-22516:
-
I'll generate the tag later this evening when I am around my signing machine.
> release hbase-filesystem version 1.0.0-alpha1
> -
>
> Key: HBASE-22516
> URL: https://issues.apache.org/jira/browse/HBASE-22516
> Project: HBase
> Issue Type: Task
> Components: community, Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments: hbase-filesystem-1.0.0-alpha1-src.tar.gz
>
>
> for this first alpha release we haven't evaluated deployment options yet, so
> let's just rely on maven for convenience binaries.
> Rough outline of process:
> # review LICENSE / NOTICE files
> # Make sure rat says our files are fine wrt license headers ({{mvn
> apache-rat:check}})
> # Check git vs jira for a correct list of issues included in the release
> # use Apache Yetus Release Doc Maker to generate release notes / changes and
> check into repo
> # update versions to be non-SNAPSHOT
> # make sure we can still build jars
> # tag RC ({{git tag -s 1.0.0-alpha1-RC0 -m "HBASE- Tagging the
> 1.0.0-alpha1 first Releae Candidate" && git push origin 1.0.0-alpha1-RC0}})
> # use the git archive command to create a source artifact ({{git archive
> --format=tar.gz
> --output="/tmp/hbase-filesystem-1.0.0-alpha1-RC0/hbase-filesystem-1.0.0-alpha1-src.tar.gz"
> --prefix="hbase-filesystem-1.0.0-alpha1/" 1.0.0-alpha1-RC0}})
> # stage the RC artifacts somewhere accessible by https. Should include
> release notes, changes, and source artifact. each of those should have a gpg
> signature and a sha512 checksum file.
> # stage maven repository (tl;dr: {{mvn deploy -DskipTests -Papache-release}}
> and then https://repository.apache.org. See the longer explanation under the
> steps "Deploy to the Maven Repository" and "Make the Release Candidate
> available" in the [Making a Release
> Candidate|http://hbase.apache.org/book.html#maven.release] ref guide section
> for the main project)
> # call VOTE for release candidate. Include the staged artifacts, staged maven
> repository, any critical issues that need summary
> # iterate on RCs if needed due to VOTE feedback
> # When VOTE passes, tag {{rel/1.0.0-alpha1}}, release maven repository,
> publish artifacts on dist.apache.org, send ANNOUNCE email, and prepare repo
> for further development
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22516) release hbase-filesystem version 1.0.0-alpha1
[
https://issues.apache.org/jira/browse/HBASE-22516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856092#comment-16856092
]
Sean Busbey commented on HBASE-22516:
-
merged https://github.com/apache/hbase-filesystem/pull/3
> release hbase-filesystem version 1.0.0-alpha1
> -
>
> Key: HBASE-22516
> URL: https://issues.apache.org/jira/browse/HBASE-22516
> Project: HBase
> Issue Type: Task
> Components: community, Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments: hbase-filesystem-1.0.0-alpha1-src.tar.gz
>
>
> for this first alpha release we haven't evaluated deployment options yet, so
> let's just rely on maven for convenience binaries.
> Rough outline of process:
> # review LICENSE / NOTICE files
> # Make sure rat says our files are fine wrt license headers ({{mvn
> apache-rat:check}})
> # Check git vs jira for a correct list of issues included in the release
> # use Apache Yetus Release Doc Maker to generate release notes / changes and
> check into repo
> # update versions to be non-SNAPSHOT
> # make sure we can still build jars
> # tag RC ({{git tag -s 1.0.0-alpha1-RC0 -m "HBASE- Tagging the
> 1.0.0-alpha1 first Releae Candidate" && git push origin 1.0.0-alpha1-RC0}})
> # use the git archive command to create a source artifact ({{git archive
> --format=tar.gz
> --output="/tmp/hbase-filesystem-1.0.0-alpha1-RC0/hbase-filesystem-1.0.0-alpha1-src.tar.gz"
> --prefix="hbase-filesystem-1.0.0-alpha1/" 1.0.0-alpha1-RC0}})
> # stage the RC artifacts somewhere accessible by https. Should include
> release notes, changes, and source artifact. each of those should have a gpg
> signature and a sha512 checksum file.
> # stage maven repository (tl;dr: {{mvn deploy -DskipTests -Papache-release}}
> and then https://repository.apache.org. See the longer explanation under the
> steps "Deploy to the Maven Repository" and "Make the Release Candidate
> available" in the [Making a Release
> Candidate|http://hbase.apache.org/book.html#maven.release] ref guide section
> for the main project)
> # call VOTE for release candidate. Include the staged artifacts, staged maven
> repository, any critical issues that need summary
> # iterate on RCs if needed due to VOTE feedback
> # When VOTE passes, tag {{rel/1.0.0-alpha1}}, release maven repository,
> publish artifacts on dist.apache.org, send ANNOUNCE email, and prepare repo
> for further development
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22516) release hbase-filesystem version 1.0.0-alpha1
[
https://issues.apache.org/jira/browse/HBASE-22516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856091#comment-16856091
]
Sean Busbey commented on HBASE-22516:
-
Attaching hte generated source here seems like as good a way to get it to me as
any. You'll need to attach checksum/signature files as well.
> release hbase-filesystem version 1.0.0-alpha1
> -
>
> Key: HBASE-22516
> URL: https://issues.apache.org/jira/browse/HBASE-22516
> Project: HBase
> Issue Type: Task
> Components: community, Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments: hbase-filesystem-1.0.0-alpha1-src.tar.gz
>
>
> for this first alpha release we haven't evaluated deployment options yet, so
> let's just rely on maven for convenience binaries.
> Rough outline of process:
> # review LICENSE / NOTICE files
> # Make sure rat says our files are fine wrt license headers ({{mvn
> apache-rat:check}})
> # Check git vs jira for a correct list of issues included in the release
> # use Apache Yetus Release Doc Maker to generate release notes / changes and
> check into repo
> # update versions to be non-SNAPSHOT
> # make sure we can still build jars
> # tag RC ({{git tag -s 1.0.0-alpha1-RC0 -m "HBASE- Tagging the
> 1.0.0-alpha1 first Releae Candidate" && git push origin 1.0.0-alpha1-RC0}})
> # use the git archive command to create a source artifact ({{git archive
> --format=tar.gz
> --output="/tmp/hbase-filesystem-1.0.0-alpha1-RC0/hbase-filesystem-1.0.0-alpha1-src.tar.gz"
> --prefix="hbase-filesystem-1.0.0-alpha1/" 1.0.0-alpha1-RC0}})
> # stage the RC artifacts somewhere accessible by https. Should include
> release notes, changes, and source artifact. each of those should have a gpg
> signature and a sha512 checksum file.
> # stage maven repository (tl;dr: {{mvn deploy -DskipTests -Papache-release}}
> and then https://repository.apache.org. See the longer explanation under the
> steps "Deploy to the Maven Repository" and "Make the Release Candidate
> available" in the [Making a Release
> Candidate|http://hbase.apache.org/book.html#maven.release] ref guide section
> for the main project)
> # call VOTE for release candidate. Include the staged artifacts, staged maven
> repository, any critical issues that need summary
> # iterate on RCs if needed due to VOTE feedback
> # When VOTE passes, tag {{rel/1.0.0-alpha1}}, release maven repository,
> publish artifacts on dist.apache.org, send ANNOUNCE email, and prepare repo
> for further development
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase-filesystem] busbey merged pull request #3: HBASE-22516 - changing versions values on related pom files
busbey merged pull request #3: HBASE-22516 - changing versions values on related pom files URL: https://github.com/apache/hbase-filesystem/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856078#comment-16856078
]
Hudson commented on HBASE-22535:
Results for branch branch-2.2
[build #330 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/330/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/330//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/330//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/330//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22534:
Resolution: Fixed
Fix Version/s: 2.1.6
2.2.1
2.3.0
3.0.0
Status: Resolved (was: Patch Available)
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase-filesystem] wchevreuil commented on issue #3: HBASE-22516 - changing versions values on related pom files
wchevreuil commented on issue #3: HBASE-22516 - changing versions values on related pom files URL: https://github.com/apache/hbase-filesystem/pull/3#issuecomment-498815669 Committed new version for CHANGELOG.md and RELEASENOTES.md, with ASF license header added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22516) release hbase-filesystem version 1.0.0-alpha1
[
https://issues.apache.org/jira/browse/HBASE-22516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856062#comment-16856062
]
Wellington Chevreuil commented on HBASE-22516:
--
Cool, let me know once you manage to have the tag created. Is it ok to upload
the generated source then here in this jira?
> release hbase-filesystem version 1.0.0-alpha1
> -
>
> Key: HBASE-22516
> URL: https://issues.apache.org/jira/browse/HBASE-22516
> Project: HBase
> Issue Type: Task
> Components: community, Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments: hbase-filesystem-1.0.0-alpha1-src.tar.gz
>
>
> for this first alpha release we haven't evaluated deployment options yet, so
> let's just rely on maven for convenience binaries.
> Rough outline of process:
> # review LICENSE / NOTICE files
> # Make sure rat says our files are fine wrt license headers ({{mvn
> apache-rat:check}})
> # Check git vs jira for a correct list of issues included in the release
> # use Apache Yetus Release Doc Maker to generate release notes / changes and
> check into repo
> # update versions to be non-SNAPSHOT
> # make sure we can still build jars
> # tag RC ({{git tag -s 1.0.0-alpha1-RC0 -m "HBASE- Tagging the
> 1.0.0-alpha1 first Releae Candidate" && git push origin 1.0.0-alpha1-RC0}})
> # use the git archive command to create a source artifact ({{git archive
> --format=tar.gz
> --output="/tmp/hbase-filesystem-1.0.0-alpha1-RC0/hbase-filesystem-1.0.0-alpha1-src.tar.gz"
> --prefix="hbase-filesystem-1.0.0-alpha1/" 1.0.0-alpha1-RC0}})
> # stage the RC artifacts somewhere accessible by https. Should include
> release notes, changes, and source artifact. each of those should have a gpg
> signature and a sha512 checksum file.
> # stage maven repository (tl;dr: {{mvn deploy -DskipTests -Papache-release}}
> and then https://repository.apache.org. See the longer explanation under the
> steps "Deploy to the Maven Repository" and "Make the Release Candidate
> available" in the [Making a Release
> Candidate|http://hbase.apache.org/book.html#maven.release] ref guide section
> for the main project)
> # call VOTE for release candidate. Include the staged artifacts, staged maven
> repository, any critical issues that need summary
> # iterate on RCs if needed due to VOTE feedback
> # When VOTE passes, tag {{rel/1.0.0-alpha1}}, release maven repository,
> publish artifacts on dist.apache.org, send ANNOUNCE email, and prepare repo
> for further development
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856060#comment-16856060
]
Wellington Chevreuil commented on HBASE-22539:
--
{quote}Oh, good, this is a nasty bug and seems we are about to reach the root
cause. So the solution is to switch back from NettyRpcServer to
SimpleRpcServer? So we will not pass cells with DBB?
{quote}
Yeah, that was the immediate workaround in this customer cluster.
{quote}And could you reproduce the problem?
{quote}
We couldn't, unfortunately. Not on any of our test clusters, nor even on
customer's staging environment. This is currently only seen in their production
cluster, consistently, once we switch back to Netty.
{quote}Could you please try moving the copy of the buf before the
this.os.write(this.buf, 0, bytesToCopy);? It is also possible that something
wrong inside the OutputStream implementation where changes the array?
{quote}
So you suspect *FSDataOutputStream* implementation might be changing source
*this.buf*? I guess that would still cause this type of corruption even when
not using netty, right?
{quote}And in general, both SimpleRpcServer and NettyRpcServer will use DBB,
the difference is that, in SimpleRpcServer, the DBB is allocated by our own
while in NettyRpcServer, it is a netty ByteBuf...
{quote}
Indeed, although there are conditions where BB will be allocated
[here|https://github.com/wchevreuil/hbase/blob/HBASE-22539/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleServerRpcConnection.java#L269],
I guess most of the time we'll be reaching [this
condition|https://github.com/wchevreuil/hbase/blob/HBASE-22539/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleServerRpcConnection.java#L271],
which gives us a DBB, as you mentioned. Ain't sure how differently is Netty
allocating a DBB instance to the point a *Unsafe.copyMemory* call could damage
the copy.
> Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
> -
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856053#comment-16856053
]
Hudson commented on HBASE-22535:
Results for branch branch-1
[build #874 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/874/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/874//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/874//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/874//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856046#comment-16856046
]
Hudson commented on HBASE-22535:
Results for branch branch-2.0
[build #1645 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1645/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1645//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1645//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1645//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856038#comment-16856038
]
Hudson commented on HBASE-22535:
Results for branch branch-2
[build #1961 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1961/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1961//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1961//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1961//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22534:
Component/s: test
java
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22534:
Labels: jdk11 (was: )
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
> Components: java, test
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856022#comment-16856022
]
Sean Busbey commented on HBASE-22534:
-
that sounds reasonable to me. Can you link a follow on jira here for updating
the mockito version?
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Apache-HBase commented on issue #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#issuecomment-498800174 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1225 | Docker mode activated. | ||| _ Prechecks _ | | 0 | findbugs | 0 | Findbugs executables are not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 127 | branch-1 passed | | +1 | compile | 39 | branch-1 passed with JDK v1.8.0_212 | | +1 | compile | 41 | branch-1 passed with JDK v1.7.0_222 | | +1 | checkstyle | 79 | branch-1 passed | | +1 | shadedjars | 166 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 30 | branch-1 passed with JDK v1.8.0_212 | | +1 | javadoc | 38 | branch-1 passed with JDK v1.7.0_222 | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 101 | the patch passed | | +1 | compile | 40 | the patch passed with JDK v1.8.0_212 | | +1 | javac | 40 | the patch passed | | +1 | compile | 41 | the patch passed with JDK v1.7.0_222 | | +1 | javac | 41 | the patch passed | | +1 | checkstyle | 73 | hbase-server: The patch generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 167 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 222 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 29 | the patch passed with JDK v1.8.0_212 | | +1 | javadoc | 37 | the patch passed with JDK v1.7.0_222 | ||| _ Other Tests _ | | -1 | unit | 8687 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 11361 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/288 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4768c83df863 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-1 / e058ffe | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_222 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/1/testReport/ | | Max. process+thread count | 4389 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-288/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856001#comment-16856001
]
Biju Nair commented on HBASE-22535:
---
Thanks [~jatsakthi] for the information.
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855989#comment-16855989 ] Andrew Purtell commented on HBASE-22540: +1 > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] apurtell commented on a change in pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
apurtell commented on a change in pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288#discussion_r290435237 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreChunkPool.java ## @@ -77,6 +77,7 @@ private static final int statThreadPeriod = 60 * 5; private AtomicLong createdChunkCount = new AtomicLong(); private AtomicLong reusedChunkCount = new AtomicLong(); + private AtomicLong gotChunkCount = new AtomicLong(); Review comment: Super minor nit. "has" instead of "got" is more common, in our code base and elsewhere This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22516) release hbase-filesystem version 1.0.0-alpha1
[
https://issues.apache.org/jira/browse/HBASE-22516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855987#comment-16855987
]
Sean Busbey commented on HBASE-22516:
-
yeah it needs to be made off of the tag to ensure it matches the contents.
> release hbase-filesystem version 1.0.0-alpha1
> -
>
> Key: HBASE-22516
> URL: https://issues.apache.org/jira/browse/HBASE-22516
> Project: HBase
> Issue Type: Task
> Components: community, Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: hbase-filesystem-1.0.0-alpha1
>
> Attachments: hbase-filesystem-1.0.0-alpha1-src.tar.gz
>
>
> for this first alpha release we haven't evaluated deployment options yet, so
> let's just rely on maven for convenience binaries.
> Rough outline of process:
> # review LICENSE / NOTICE files
> # Make sure rat says our files are fine wrt license headers ({{mvn
> apache-rat:check}})
> # Check git vs jira for a correct list of issues included in the release
> # use Apache Yetus Release Doc Maker to generate release notes / changes and
> check into repo
> # update versions to be non-SNAPSHOT
> # make sure we can still build jars
> # tag RC ({{git tag -s 1.0.0-alpha1-RC0 -m "HBASE- Tagging the
> 1.0.0-alpha1 first Releae Candidate" && git push origin 1.0.0-alpha1-RC0}})
> # use the git archive command to create a source artifact ({{git archive
> --format=tar.gz
> --output="/tmp/hbase-filesystem-1.0.0-alpha1-RC0/hbase-filesystem-1.0.0-alpha1-src.tar.gz"
> --prefix="hbase-filesystem-1.0.0-alpha1/" 1.0.0-alpha1-RC0}})
> # stage the RC artifacts somewhere accessible by https. Should include
> release notes, changes, and source artifact. each of those should have a gpg
> signature and a sha512 checksum file.
> # stage maven repository (tl;dr: {{mvn deploy -DskipTests -Papache-release}}
> and then https://repository.apache.org. See the longer explanation under the
> steps "Deploy to the Maven Repository" and "Make the Release Candidate
> available" in the [Making a Release
> Candidate|http://hbase.apache.org/book.html#maven.release] ref guide section
> for the main project)
> # call VOTE for release candidate. Include the staged artifacts, staged maven
> repository, any critical issues that need summary
> # iterate on RCs if needed due to VOTE feedback
> # When VOTE passes, tag {{rel/1.0.0-alpha1}}, release maven repository,
> publish artifacts on dist.apache.org, send ANNOUNCE email, and prepare repo
> for further development
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase-filesystem] busbey commented on a change in pull request #3: HBASE-22516 - changing versions values on related pom files
busbey commented on a change in pull request #3: HBASE-22516 - changing versions values on related pom files URL: https://github.com/apache/hbase-filesystem/pull/3#discussion_r290433027 ## File path: CHANGELOG.md ## @@ -0,0 +1,39 @@ +# HBASE Changelog Review comment: this file needs a ASF license header. if you run release doc maker with the `--license` option it should do it for you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-filesystem] busbey commented on a change in pull request #3: HBASE-22516 - changing versions values on related pom files
busbey commented on a change in pull request #3: HBASE-22516 - changing versions values on related pom files URL: https://github.com/apache/hbase-filesystem/pull/3#discussion_r290433077 ## File path: RELEASENOTES.md ## @@ -0,0 +1,35 @@ +# HBASE hbase-filesystem-1.0.0-alpha1 Release Notes Review comment: this file needs a ASF license header. if you run release doc maker with the `--license` option it should do it for you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855983#comment-16855983
]
Sakthi commented on HBASE-22536:
Thanks [~busbey]
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855981#comment-16855981
]
Sakthi commented on HBASE-22535:
Thanks [~busbey] for pushing this in.
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855979#comment-16855979
]
Sakthi commented on HBASE-22535:
[~gsbiju], my current java 11 version is:
{code:java}
$ java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
{code}
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855977#comment-16855977
]
Sakthi commented on HBASE-22534:
Currently mockito-core version is at 2.1.0. According to
[https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md],
looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims to
have full java 11 support after byte-buddy fix etc. I haven't yet tried
upgrading and checking though. But nevertheless, by upgrading mockito, I'm not
sure if other tests based on mockito start failing or need to changed. So would
say comparatively little higher risk but worth making a note of considering
up-gradation of mockito in near future.
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22536:
Resolution: Fixed
Fix Version/s: 2.1.6
2.2.1
2.3.0
3.0.0
Status: Resolved (was: Patch Available)
Pushed to 2.1+. thanks!
Please link the follow on jira here once you make it.
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15898) Document G1GC Recommendations
[
https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855891#comment-16855891
]
Sean Busbey commented on HBASE-15898:
-
Whoever commits this should be sure to check the commit as the correct
{{Author}} and {{Co-authored-by}} metadata.
> Document G1GC Recommendations
> -
>
> Key: HBASE-15898
> URL: https://issues.apache.org/jira/browse/HBASE-15898
> Project: HBase
> Issue Type: Bug
> Components: documentation, java
>Affects Versions: 2.0.0
>Reporter: Misty Linville
>Assignee: Misty Linville
>Priority: Major
> Attachments: HBASE-15898-001.PATCH, HBASE-15898.patch
>
>
> Document G1GC recommendations for HBase
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-15898) Document G1GC Recommendations
[ https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-15898: Labels: jdk11 (was: ) > Document G1GC Recommendations > - > > Key: HBASE-15898 > URL: https://issues.apache.org/jira/browse/HBASE-15898 > Project: HBase > Issue Type: Bug > Components: documentation, java >Affects Versions: 2.0.0 >Reporter: Misty Linville >Assignee: Misty Linville >Priority: Major > Labels: jdk11 > Attachments: HBASE-15898-001.PATCH, HBASE-15898.patch > > > Document G1GC recommendations for HBase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15898) Document G1GC Recommendations
[ https://issues.apache.org/jira/browse/HBASE-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855890#comment-16855890 ] Sean Busbey commented on HBASE-15898: - I don't think this is usable as is. It's not clear from reading if the target audience is general GC tuning or tuning specifically for an HBase service. Is the "practical tuning advice" from some recent testing with HBase? or from whatever was done in 2016? > Document G1GC Recommendations > - > > Key: HBASE-15898 > URL: https://issues.apache.org/jira/browse/HBASE-15898 > Project: HBase > Issue Type: Bug > Components: documentation, java >Affects Versions: 2.0.0 >Reporter: Misty Linville >Assignee: Misty Linville >Priority: Major > Attachments: HBASE-15898-001.PATCH, HBASE-15898.patch > > > Document G1GC recommendations for HBase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22264) Separate out jars related to JDK 11 into a folder in /lib
[
https://issues.apache.org/jira/browse/HBASE-22264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855886#comment-16855886
]
Sean Busbey commented on HBASE-22264:
-
this still in progress or is it stalled out?
> Separate out jars related to JDK 11 into a folder in /lib
> -
>
> Key: HBASE-22264
> URL: https://issues.apache.org/jira/browse/HBASE-22264
> Project: HBase
> Issue Type: Task
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22264.master.001.patch,
> hbase-22264.master.002.patch, hbase-22264.master.003.patch,
> hbase-22264.master.004.patch, hbase-22264.master.005.patch,
> hbase-22264_jdks.txt, run_ITD_with_REST_ClusterManager.log
>
>
> UPDATE:
> Separate out the the jars related to JDK 11 and add control their addition to
> the classpath using an environment variable or auto-detection of the jdk
> version installed.
> OLD:
> This is in continuation with HBASE-22249. When compiled with jdk 8 and run on
> jdk 11, the master branch throws the following exception during an attempt to
> start the hbase rest server:
> {code:java}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> javax/annotation/Priority
> at
> org.glassfish.jersey.model.internal.ComponentBag.modelFor(ComponentBag.java:483)
> at
> org.glassfish.jersey.model.internal.ComponentBag.access$100(ComponentBag.java:89)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:408)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:398)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
> at
> org.glassfish.jersey.model.internal.ComponentBag.registerModel(ComponentBag.java:398)
> at
> org.glassfish.jersey.model.internal.ComponentBag.register(ComponentBag.java:235)
> at
> org.glassfish.jersey.model.internal.CommonConfig.register(CommonConfig.java:420)
> at
> org.glassfish.jersey.server.ResourceConfig.register(ResourceConfig.java:425)
> at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:245)
> at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:421)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-21415:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed this to master (and only master). My attempt to cherry pick this to
branch-2 showed multiple areas where the master patch was insufficient.
I've no objection to getting this backported to other branches. I've just spent
enough time caressing this patch to make it acceptable and correct :)
Thanks for your initial work, Philippe!
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21415) Admin#snapshot method documentation is misleading.
[
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-21415:
---
Fix Version/s: 3.0.0
> Admin#snapshot method documentation is misleading.
> --
>
> Key: HBASE-21415
> URL: https://issues.apache.org/jira/browse/HBASE-21415
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Philippe Laflamme
>Assignee: Philippe Laflamme
>Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HBASE-21415.002.patch, HBASE-21415.003.patch,
> HBASE-21415.patch, HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in
> regards to snapshot concurrency.
> It currently states the following:
> {quote}Only a single snapshot should be taken at a time for an instance of
> HBase, or results may be undefined (you can tell multiple HBase clusters to
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when
> in fact the HBase master will simply run them sequentially (as per this Slack
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[
https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855861#comment-16855861
]
Reid Chan commented on HBASE-22540:
---
I can't find a component named {{memstore}}, but it doesn't matter i think...
> [Memstore] Correct counters in MemStoreChunkPool
>
>
> Key: HBASE-22540
> URL: https://issues.apache.org/jira/browse/HBASE-22540
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
>
> As title reads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855859#comment-16855859 ] Reid Chan commented on HBASE-22540: --- It is a simple improvement without unit test. But it affects all branches. PR is against branch-1, ping sir [~apurtell], if you have free cycles. I will forward-port branch-2 and master later after it is reviewed. > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22540: -- Comment: was deleted (was: It is a simple improvement without unit test. But it affects all branches. PR is against branch-1, ping sir [~apurtell], if you have free cycles. I will forward-port branch-2 and master later after it is reviewed. ) > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
[ https://issues.apache.org/jira/browse/HBASE-22540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855857#comment-16855857 ] Reid Chan commented on HBASE-22540: --- It is a simple improvement without unit test. But it affects all branches. PR is against branch-1, ping sir [~apurtell], if you have free cycles. I will forward-port branch-2 and master later after it is reviewed. > [Memstore] Correct counters in MemStoreChunkPool > > > Key: HBASE-22540 > URL: https://issues.apache.org/jira/browse/HBASE-22540 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > > As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22535:
Resolution: Fixed
Fix Version/s: 2.1.6
2.2.1
2.0.6
2.3.0
1.5.0
3.0.0
Status: Resolved (was: Patch Available)
I wasn't able to test the change under JDK11 on branch-1, but this change
should also be needed under JDK8 and the test works with jdk8 there.
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22536:
Labels: jdk11 (was: )
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22536) TestForeignExceptionSerialization fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22536:
Component/s: java
> TestForeignExceptionSerialization fails when run on JDK11
> -
>
> Key: HBASE-22536
> URL: https://issues.apache.org/jira/browse/HBASE-22536
> Project: HBase
> Issue Type: Bug
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22536.master.001.patch,
> hbase-22536.master.002.patch
>
>
> When built on Java 8 and unit tests are run on Java 11,
> TestForeignExceptionSerialization fails. A sample stacktrace:
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.546 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization
> testRemoteFromLocal(org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization)
> Time elapsed: 0.084 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Local stack trace got corrupted:
> arrays first differed at element [0]; expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78)
> Caused by: java.lang.AssertionError: expected:
> java.lang.StackTraceElement
> but was:
> java.lang.StackTraceElement
> at
> org.apache.hadoop.hbase.errorhandling.TestForeignExceptionSerialization.testRemoteFromLocal(TestForeignExceptionSerialization.java:78){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Reidddddd opened a new pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool
Reidd opened a new pull request #288: HBASE-22540 [Memstore] Correct counters in MemStoreChunkPool URL: https://github.com/apache/hbase/pull/288 Add a new counter `gotChunkCount` for calculating reuse ratio. Correct `createdChunkCount` initial count. Set `logStats` INFO level, every 5 minutes which is not very chatty, and it is useful information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855830#comment-16855830
]
Sean Busbey commented on HBASE-22535:
-
I can reproduce this locally with:
{quote}
mvn -version
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was
removed in 8.0
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T13:41:47-05:00)
Maven home: /usr/local/Cellar/maven/3.6.0/libexec
Java version: 11.0.2, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
{quote}
Looking at the code I'm not sure why this even works on JDK8. It must be that
however JRuby uses reflection bypasses the access modifier on the class.
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22535:
Component/s: shell
java
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22535) TestShellRSGroups fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22535:
Labels: jdk11 (was: )
> TestShellRSGroups fails when run on JDK11
> -
>
> Key: HBASE-22535
> URL: https://issues.apache.org/jira/browse/HBASE-22535
> Project: HBase
> Issue Type: Bug
> Components: java, shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22535.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestShellRSGroups
> fails. A sample stacktrace:
> {code}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.293 s <<<
> FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
> testRunShellTests(org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups)
> Time elapsed: 2.879 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:102)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> Error:
> ^[[48;5;16;38;5;226;1mtest_Test_bogus_arguments(Hbase::RSGroupShellTest)^[[0m:
> TypeError: illegal access on constructor for type 'RSGroupAdminClient':
> class org.jruby.javasupport.JavaConstructor cannot access a member of class
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient with modifiers "public"
> /Users/jatsakthi/dev/hbase/hbase-shell/src/test/ruby/shell/rsgroup_shell_test.rb:30:in
> `setup'
> org/jruby/RubyArray.java:1735:in `each'{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22540) [Memstore] Correct counters in MemStoreChunkPool
Reid Chan created HBASE-22540: - Summary: [Memstore] Correct counters in MemStoreChunkPool Key: HBASE-22540 URL: https://issues.apache.org/jira/browse/HBASE-22540 Project: HBase Issue Type: Improvement Reporter: Reid Chan Assignee: Reid Chan As title reads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22534) TestCellUtil fails when run on JDK11
[
https://issues.apache.org/jira/browse/HBASE-22534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855821#comment-16855821
]
Sean Busbey commented on HBASE-22534:
-
I think this can also get fixed by updating to the latest version of mockito.
What do you think [~jatsakthi]? Higher risk?
> TestCellUtil fails when run on JDK11
>
>
> Key: HBASE-22534
> URL: https://issues.apache.org/jira/browse/HBASE-22534
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-22534.master.001.patch
>
>
> When built on Java 8 and unit tests are run on Java 11, TestCellUtil fails. A
> sample stacktrace:
> {code}
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.096 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestCellUtil
> testGetType(org.apache.hadoop.hbase.TestCellUtil) Time elapsed: 0.544 s <<<
> ERROR!
> org.mockito.exceptions.base.MockitoException:
> Cannot call abstract real method on java object!
> Calling real methods is only possible when mocking non abstract method.
> //correct example:
> when(mockOfConcreteClass.nonAbstractMethod()).thenCallRealMethod();
> at
> org.apache.hadoop.hbase.TestCellUtil.testGetType(TestCellUtil.java:543){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21512) Reimplement sync client based on async client
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855813#comment-16855813
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #261 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/261/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/261//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/261//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/261//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reimplement sync client based on async client
> -
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855786#comment-16855786 ] Duo Zhang commented on HBASE-22539: --- And in general, both SimpleRpcServer and NettyRpcServer will use DBB, the difference is that, in SimpleRpcServer, the DBB is allocated by our own while in NettyRpcServer, it is a netty ByteBuf... > Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place > - > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22539) Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22539: Component/s: wal rpc > Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place > - > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855736#comment-16855736
]
Duo Zhang commented on HBASE-22539:
---
And could you reproduce the problem? Could you please try moving the copy of
the buf before the {{this.os.write(this.buf, 0, bytesToCopy);}}? It is also
possible that something wrong inside the OutputStream implementation where
changes the array?
> Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
> -
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #168: HBASE-22271 Implement grant/revoke/delete table acls/delete namespace acls in Procedure
Apache-HBase commented on issue #168: HBASE-22271 Implement grant/revoke/delete table acls/delete namespace acls in Procedure URL: https://github.com/apache/hbase/pull/168#issuecomment-498688812 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 92 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 9 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for branch | | +1 | mvninstall | 271 | master passed | | +1 | compile | 209 | master passed | | +1 | checkstyle | 167 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 518 | master passed | | +1 | javadoc | 120 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 11 | Maven dependency ordering for patch | | -1 | mvninstall | 211 | root in the patch failed. | | -1 | compile | 22 | hbase-backup in the patch failed. | | -1 | cc | 22 | hbase-backup in the patch failed. | | -1 | javac | 22 | hbase-backup in the patch failed. | | +1 | checkstyle | 12 | The patch passed checkstyle in hbase-protocol-shaded | | -1 | checkstyle | 31 | hbase-client: The patch generated 1 new + 105 unchanged - 0 fixed = 106 total (was 105) | | +1 | checkstyle | 12 | The patch passed checkstyle in hbase-procedure | | +1 | checkstyle | 67 | hbase-server: The patch generated 0 new + 302 unchanged - 4 fixed = 302 total (was 306) | | +1 | checkstyle | 33 | The patch passed checkstyle in hbase-thrift | | +1 | checkstyle | 13 | The patch passed checkstyle in hbase-backup | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 151 | The patch causes 16 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 298 | The patch causes 16 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 477 | The patch causes 16 errors with Hadoop v3.1.2. | | -1 | hbaseprotoc | 29 | hbase-backup in the patch failed. | | -1 | findbugs | 25 | hbase-backup in the patch failed. | | +1 | javadoc | 139 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 41 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 228 | hbase-client in the patch passed. | | +1 | unit | 207 | hbase-procedure in the patch passed. | | +1 | unit | 11404 | hbase-server in the patch passed. | | -1 | unit | 500 | hbase-thrift in the patch failed. | | -1 | unit | 34 | hbase-backup in the patch failed. | | +1 | asflicense | 151 | The patch does not generate ASF License warnings. | | | | 16764 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.thrift.TestThriftServer | | | hadoop.hbase.thrift2.TestThrift2HttpServer | | | hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels | | | hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithReadOnly | | | hadoop.hbase.thrift.TestThriftHttpServer | | | hadoop.hbase.thrift.TestThriftSpnegoHttpServer | | | hadoop.hbase.thrift2.TestThriftHBaseServiceHandler | | | hadoop.hbase.thrift2.TestThriftConnection | | | hadoop.hbase.thrift.TestThriftServerCmdLine | | | hadoop.hbase.thrift2.TestThrift2ServerCmdLine | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/168 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 79d38d32469a 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / aacacc5cce | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/5/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/5/artifact/out/patch-compile-hbase-backup.txt | | cc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-168/5/artifact/out/patch-compile-hbase-backup.txt | | javac |
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855721#comment-16855721 ] Duo Zhang commented on HBASE-22539: --- Oh, good, this is a nasty bug and seems we are about to reach the root cause. So the solution is to switch back from NettyRpcServer to SimpleRpcServer? So we will not pass cells with DBB? > Potential WAL corruption due to Unsafe.copyMemory usage when DBB are in place > - > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855715#comment-16855715
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #130 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/130/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/130//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/130//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/130//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
