[jira] [Commented] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[
https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919233#comment-16919233
]
HBase QA commented on HBASE-20688:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 6m
19s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 6m
9s{color} | {color:blue} patch has no errors when building the reference guide.
See footer for rendered docs, which you should manually inspect. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/562 |
| JIRA Issue | HBASE-20688 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 83d78c70553d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-562/out/precommit/personality/provided.sh
|
| git revision | master / 090c55f3ff |
| refguide |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/artifact/out/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/artifact/out/patch-site/book.html
|
| Max. process+thread count | 86 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Refguide has "HBase Backup" section and a chapter named "Backup and Restore";
> neither refers to the other
> -
>
> Key: HBASE-20688
> URL: https://issues.apache.org/jira/browse/HBASE-20688
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Rabi Kumar K C
>Priority: Major
>
> The two backup sections are not connected or related. It'd be confusing to
> the user. Needs addressing.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #562: HBASE-20688
Apache-HBase commented on issue #562: HBASE-20688 URL: https://github.com/apache/hbase/pull/562#issuecomment-526468431 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 352 | master passed | | 0 | refguide | 379 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 323 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 369 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1534 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/562 | | JIRA Issue | HBASE-20688 | | Optional Tests | dupname asflicense refguide | | uname | Linux 83d78c70553d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-562/out/precommit/personality/provided.sh | | git revision | master / 090c55f3ff | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/artifact/out/patch-site/book.html | | Max. process+thread count | 86 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #559: HBASE-22944 TableNotFoundException: hbase:quota is thrown when region server is restarted.
Apache-HBase commented on issue #559: HBASE-22944 TableNotFoundException: hbase:quota is thrown when region server is restarted. URL: https://github.com/apache/hbase/pull/559#issuecomment-526466072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 326 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 285 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 240 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 920 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 266 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 10359 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 13776 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.TestSplitMerge | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/559 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7c228facdfbd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-559/out/precommit/personality/provided.sh | | git revision | master / 090c55f3ff | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/5/testReport/ | | Max. process+thread count | 4966 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22941) MetaTableAccessor.getMergeRegions() returns parent regions in random order
[
https://issues.apache.org/jira/browse/HBASE-22941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919217#comment-16919217
]
Hudson commented on HBASE-22941:
Results for branch master
[build #1375 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1375/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1375//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1375//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1375//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> MetaTableAccessor.getMergeRegions() returns parent regions in random order
> --
>
> Key: HBASE-22941
> URL: https://issues.apache.org/jira/browse/HBASE-22941
> Project: HBase
> Issue Type: Bug
>Affects Versions: master
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> The multi-region merge patch has changed the behaviour of the
> MetaTableAccessor.getMergeRegions() method. Earlier, the parent regions were
> returned in the same order that they were passed to mergeRegion().
> The patch has changed this to return the regions in random order. To be more
> precise, the parent regions are stored in random order in Meta.
> I propose storing and returning the parent regions in ascending order.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22941) MetaTableAccessor.getMergeRegions() returns parent regions in random order
[
https://issues.apache.org/jira/browse/HBASE-22941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919214#comment-16919214
]
Hudson commented on HBASE-22941:
Results for branch branch-2.2
[build #554 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/554/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/554//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/554//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/554//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> MetaTableAccessor.getMergeRegions() returns parent regions in random order
> --
>
> Key: HBASE-22941
> URL: https://issues.apache.org/jira/browse/HBASE-22941
> Project: HBase
> Issue Type: Bug
>Affects Versions: master
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> The multi-region merge patch has changed the behaviour of the
> MetaTableAccessor.getMergeRegions() method. Earlier, the parent regions were
> returned in the same order that they were passed to mergeRegion().
> The patch has changed this to return the regions in random order. To be more
> precise, the parent regions are stored in random order in Meta.
> I propose storing and returning the parent regions in ascending order.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #548: HBASE-22930 Set unique name to longCompactions/shortCompactions threads
Apache-HBase commented on issue #548: HBASE-22930 Set unique name to longCompactions/shortCompactions threads URL: https://github.com/apache/hbase/pull/548#issuecomment-526464533 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 335 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 78 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 245 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 312 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 944 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 249 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 10307 | hbase-server in the patch passed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 13725 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/548 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1a67dd1182a8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh | | git revision | master / 090c55f3ff | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/5/testReport/ | | Max. process+thread count | 5038 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919208#comment-16919208
]
HBase QA commented on HBASE-22893:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} https://github.com/apache/hbase/pull/552 does not apply to
master. Rebase required? Wrong Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| GITHUB PR | https://github.com/apache/hbase/pull/552 |
| JIRA Issue | HBASE-22893 |
| Console output |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-552/4/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22893.patch
>
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #552: HBASE-22893
Apache-HBase commented on issue #552: HBASE-22893 URL: https://github.com/apache/hbase/pull/552#issuecomment-526462621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 7 | https://github.com/apache/hbase/pull/552 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/552 | | JIRA Issue | HBASE-22893 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-552/4/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22951) [HBCK2] hbase hbck throws IOE "No FileSystem for scheme: hdfs"
stack created HBASE-22951:
-
Summary: [HBCK2] hbase hbck throws IOE "No FileSystem for scheme:
hdfs"
Key: HBASE-22951
URL: https://issues.apache.org/jira/browse/HBASE-22951
Project: HBase
Issue Type: Bug
Reporter: stack
Input appreciated on this one.
If I do the below, passing a config that is pointing at a HDFS, I get the below
(If I run w/o, hbck just picks up the wrong fs -- the local fs).
{code}
$ /vagrant/hbase/bin/hbase --config hbase-conf hbck
2019-08-30 05:04:54,467 WARN [main] util.NativeCodeLoader: Unable to load
native-hadoop library for your platform... using builtin-java classes where
applicable
Exception in thread "main" java.io.IOException: No FileSystem for scheme: hdfs
at
org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2799)
at
org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
at
org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
at org.apache.hadoop.fs.Path.getFileSystem(Path.java:356)
at
org.apache.hadoop.hbase.util.CommonFSUtils.getRootDir(CommonFSUtils.java:361)
at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3605)
{code}
Its because the CLASSPATH is carefully curated so as to use shaded client only;
there are no hdfs classes on the CLASSPATH intentionally.
So, how to fix? Happens whether hbck1 or hbck2 (you have to do a hdfs operation
for hbck2 to trigger same issue).
Could be careful in hbck2 and note that if fs operation, you need to add hdfs
jars to CLASSPATH so hbck2 can go against hdfs.
If add the ' --internal-classpath' flag, then all classes are put on the
CLASSPATH for hbck(2) (including the hdfs client jar which got the hdfs
implementation after 2.7.2 was released) and stuff 'works'.
Could edit the bin/hbase script and make it so hdfs classes are added to the
hbck CLASSPATH? Could see if could do hdfs client-only?
Anyways, putting this up for now. Others may have opinions. Thanks.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22943) Various procedures should not cache log trace level
[
https://issues.apache.org/jira/browse/HBASE-22943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919194#comment-16919194
]
Hudson commented on HBASE-22943:
Results for branch branch-2.2
[build #553 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/553/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/553//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/553//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/553//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Various procedures should not cache log trace level
> ---
>
> Key: HBASE-22943
> URL: https://issues.apache.org/jira/browse/HBASE-22943
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
>
> several of the procedures have an idiom where they keep a member variable for
> if the log is at trace level or not, wrapped in a function so that it can be
> lazily looked up. This gives us an overhead per call of autoboxing and a
> function call, instead of just the function call from asking the logging
> system directly.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22872) Don't create normalization plan unnecesarily when split and merge both are disabled
[ https://issues.apache.org/jira/browse/HBASE-22872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22872: -- Fix Version/s: 1.4.11 > Don't create normalization plan unnecesarily when split and merge both are > disabled > --- > > Key: HBASE-22872 > URL: https://issues.apache.org/jira/browse/HBASE-22872 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.10 >Reporter: Aman Poonia >Assignee: Aman Poonia >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7 > > Attachments: HBASE-22872.branch-1.4.001.patch, > HBASE-22872.branch-1.4.002.patch, HBASE-22872.branch-1.4.003.patch, > HBASE-22872.branch-1.4.004.patch, HBASE-22872.branch-1.4.005.patch, > HBASE-22872.branch-2.patch, HBASE-22872.master.001.patch, > HBASE-22872.master.v01.patch > > > We should not proceed futher in normalization plan creation if split and > merge both are disabled on a table. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…
Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na… URL: https://github.com/apache/hbase/pull/524#issuecomment-526450180 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 333 | branch-2.1 passed | | +1 | compile | 30 | branch-2.1 passed | | +1 | checkstyle | 19 | branch-2.1 passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | branch-2.1 passed | | 0 | spotbugs | 57 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 56 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 30 | the patch passed | | +1 | javac | 30 | the patch passed | | -1 | checkstyle | 17 | hbase-rest: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1293 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 60 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 371 | hbase-rest in the patch failed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3551 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rest.TestNamespacesInstanceResource | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/17/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/524 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 73c7b32a104d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-524/out/precommit/personality/provided.sh | | git revision | branch-2.1 / db85526254 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/17/artifact/out/diff-checkstyle-hbase-rest.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/17/artifact/out/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/17/testReport/ | | Max. process+thread count | 2210 (vs. ulimit of 1) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/17/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319350268
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -242,6 +244,11 @@ public int compare(BlockCacheKey a, BlockCacheKey b) {
/** In-memory bucket size */
private float memoryFactor;
+ private String[] filePaths;
+ static final String FILE_VERIFY_ALGORITHM =
"hbase.bucketcache.file.verify.algorithm";
Review comment:
Please rename this parameters,
"hbase.bucketcache.persistent.file.integrity.check.algorithm" for your
reference.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22943) Various procedures should not cache log trace level
[
https://issues.apache.org/jira/browse/HBASE-22943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919172#comment-16919172
]
Hudson commented on HBASE-22943:
Results for branch branch-2.1
[build #1536 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1536/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1536//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1536//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1536//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Various procedures should not cache log trace level
> ---
>
> Key: HBASE-22943
> URL: https://issues.apache.org/jira/browse/HBASE-22943
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
>
> several of the procedures have an idiom where they keep a member variable for
> if the log is at trace level or not, wrapped in a function so that it can be
> lazily looked up. This gives us an overhead per call of autoboxing and a
> function call, instead of just the function call from asking the logging
> system directly.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349889
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -242,6 +244,11 @@ public int compare(BlockCacheKey a, BlockCacheKey b) {
/** In-memory bucket size */
private float memoryFactor;
+ private String[] filePaths;
+ static final String FILE_VERIFY_ALGORITHM =
"hbase.bucketcache.file.verify.algorithm";
+ static final String DEFAULT_FILE_VERIFY_ALGORITHM = "MD5";
+ private String algorithm;
Review comment:
Java doc for this new member, what is this algorithm for?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349732
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FileIOEngineUtils.java
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import org.apache.hadoop.util.Shell;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class FileIOEngineUtils {
+
+ private FileIOEngineUtils() {
+
+ }
+ /**
+ * When HBase is stoping, a key will be written to persistencePath
+ * @param persistencePath the backingMap persistence path
+ * @return the key
+ * @throws IOException something happened like file not exists
+ */
+ public static String getPreFilesKey(String persistencePath) throws
IOException {
+FileInputStream fis = null;
+ObjectInputStream ois = null;
+try {
+ fis = new FileInputStream(persistencePath);
+ ois = new ObjectInputStream(fis);
+ String result = ois.readUTF();
+ return result;
+} finally {
+ if (ois != null) {
+ois.close();
+ }
+ if (fis != null) {
+fis.close();
+ }
+}
+ }
+
+ /**
+ * delete bucketcache files
+ * @param filePaths the cache data files
+ */
+ public static void deleteCacheDataFile(String[] filePaths) {
+if (filePaths == null) {
+ return;
+}
+for (String file : filePaths) {
+ File file1 = new File(file);
+ file1.delete();
+}
+ }
+
+ /**
+ * Using an encryption algorithm to get a key, the default encryption
algorithm is MD5
+ * @param filePaths the cache data files
+ * @param algorithmName the encryption algorithm
+ * @return the key which is convert to HexString
+ * @throws IOException something happened like file not exists
+ * @throws NoSuchAlgorithmException no such algorithm
+ */
+ public static String getFilesKey(String[] filePaths, String algorithmName)
throws IOException, NoSuchAlgorithmException {
Review comment:
This line is too long to match code style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349696
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FileIOEngineUtils.java
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import org.apache.hadoop.util.Shell;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class FileIOEngineUtils {
+
+ private FileIOEngineUtils() {
+
+ }
+ /**
Review comment:
There should be a new line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349640
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FileIOEngineUtils.java
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import org.apache.hadoop.util.Shell;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class FileIOEngineUtils {
Review comment:
This class can be final
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349663
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FileIOEngineUtils.java
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import org.apache.hadoop.util.Shell;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class FileIOEngineUtils {
+
+ private FileIOEngineUtils() {
+
Review comment:
Useless new line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349611
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
##
@@ -59,6 +61,43 @@ public FileIOEngine(long capacity, String... filePaths)
throws IOException {
this.fileChannels = new FileChannel[filePaths.length];
this.rafs = new RandomAccessFile[filePaths.length];
this.channelLocks = new ReentrantLock[filePaths.length];
+init();
+ }
+
+ public FileIOEngine(String algorithmName, String persistencePath,
+long capacity, String... filePaths) throws IOException {
+this.sizePerFile = capacity / filePaths.length;
+this.capacity = this.sizePerFile * filePaths.length;
+this.filePaths = filePaths;
+this.fileChannels = new FileChannel[filePaths.length];
+this.rafs = new RandomAccessFile[filePaths.length];
+this.channelLocks = new ReentrantLock[filePaths.length];
+if (persistencePath != null){
+ try {
+String preFilesKey = FileIOEngineUtils.getPreFilesKey(persistencePath);
+String filesKey = FileIOEngineUtils.getFilesKey(filePaths,
algorithmName);
+LOG.info("preFilesKey: "+ preFilesKey + " filesKey: " + filesKey);
+if (preFilesKey == null || !preFilesKey.equals(filesKey)){
+ throw new IOException("File verification failed! Can't restore from
file.");
+}
+ } catch (IOException ioex) {
+LOG.error("Can't restore from file because of", ioex);
+// delete cache files and backingMap persistence file.
+FileIOEngineUtils.deleteCacheDataFile(filePaths);
+File persistenceFile = new File(persistencePath);
+persistenceFile.delete();
+ } catch (NoSuchAlgorithmException nsae) {
+LOG.error("No such algorithm " + algorithmName, nsae);
+throw new RuntimeException(nsae);
+ }
+} else {
+ // not configure persistencePath
+ FileIOEngineUtils.deleteCacheDataFile(filePaths);
+}
+init();
+ }
+
+ public void init() throws IOException {
Review comment:
this method should be private?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319349512
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FileIOEngineUtils.java
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import org.apache.hadoop.util.Shell;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+
+public class FileIOEngineUtils {
+
+ private FileIOEngineUtils() {
+
+ }
+ /**
+ * When HBase is stoping, a key will be written to persistencePath
+ * @param persistencePath the backingMap persistence path
+ * @return the key
+ * @throws IOException something happened like file not exists
+ */
+ public static String getPreFilesKey(String persistencePath) throws
IOException {
+FileInputStream fis = null;
+ObjectInputStream ois = null;
+try {
Review comment:
Use try-with-resource style
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#discussion_r319349466 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ## @@ -1056,6 +1069,7 @@ private void retrieveFromFile(int[] bucketSizes) throws IOException, BucketAlloc "Attempt to restore non-persistent cache mappings!"); fis = new FileInputStream(persistencePath); ois = new ObjectInputStream(fis); + ois.readUTF(); Review comment: It breaks backward compatibility. For an upgrading rs, it should read an old persistent file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319348610
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1029,19 +1036,25 @@ private void persistToFile() throws IOException {
}
fos = new FileOutputStream(persistencePath, false);
oos = new ObjectOutputStream(fos);
+ oos.writeUTF(FileIOEngineUtils.getFilesKey(filePaths, algorithm));
oos.writeLong(cacheCapacity);
oos.writeUTF(ioEngine.getClass().getName());
oos.writeUTF(backingMap.getClass().getName());
oos.writeObject(deserialiserMap);
oos.writeObject(backingMap);
+} catch (NoSuchAlgorithmException e) {
+ LOG.error("No such algorithm : " + algorithm + "! Failed to persist data
on exit",e);
+} catch (Exception e) {
+ LOG.error("persist to file error"+e);
Review comment:
nit, space style `"+e)`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#discussion_r319348296 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ## @@ -288,14 +294,15 @@ public BucketCache(String ioEngineName, long capacity, int blockSize, int[] buck this.ramCache = new ConcurrentHashMap(); this.backingMap = new ConcurrentHashMap((int) blockNumCapacity); - +this.algorithm = conf.get(FILE_VERIFY_ALGORITHM,DEFAULT_FILE_VERIFY_ALGORITHM); Review comment: nit, space `,DEFAULT_FILE_VERIFY_ALGORITHM` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Reidd commented on a change in pull request #528: HBASE-22890 Verify the
files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319348246
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -242,6 +244,11 @@ public int compare(BlockCacheKey a, BlockCacheKey b) {
/** In-memory bucket size */
private float memoryFactor;
+ private String[] filePaths;
+ static final String FILE_VERIFY_ALGORITHM =
"hbase.bucketcache.file.verify.algorithm";
+ static final String DEFAULT_FILE_VERIFY_ALGORITHM = "MD5";
Review comment:
Set them private, unless you use them somewhere outside package.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22943) Various procedures should not cache log trace level
[
https://issues.apache.org/jira/browse/HBASE-22943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919163#comment-16919163
]
Hudson commented on HBASE-22943:
Results for branch branch-2
[build #2205 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2205/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2205//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2205//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2205//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Various procedures should not cache log trace level
> ---
>
> Key: HBASE-22943
> URL: https://issues.apache.org/jira/browse/HBASE-22943
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
>
> several of the procedures have an idiom where they keep a member variable for
> if the log is at trace level or not, wrapped in a function so that it can be
> lazily looked up. This gives us an overhead per call of autoboxing and a
> function call, instead of just the function call from asking the logging
> system directly.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Reidddddd commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
Reidd commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319346359
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
Review comment:
The same question, can AsyncResult be generic? Looks like `AsyncResult` and
`Callback` should be designed together, but now they are separated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
Reidd commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319345784
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
Review comment:
Can `Callback` be generic?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
Reidd commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319345116
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
+
+ // Step.3: Start to traverse and delete the sub-directories.
+ if (subDirs.isEmpty()) {
+// If no sub-directories, then just
[GitHub] [hbase] Reidddddd commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
Reidd commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319345038
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
Review comment:
nit, about the type: `files` and `dirs` or `file` and `dir`.
[GitHub] [hbase] Reidddddd commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
Reidd commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319344765
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
+
+ // Step.3: Start to traverse and delete the sub-directories.
+ if (subDirs.isEmpty()) {
+// If no sub-directories, then just
[jira] [Resolved] (HBASE-22933) Do not need to kick reassign for rs group change any more
[
https://issues.apache.org/jira/browse/HBASE-22933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-22933.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.2+.
Thanks [~zghaobac] for reviewing.
> Do not need to kick reassign for rs group change any more
> -
>
> Key: HBASE-22933
> URL: https://issues.apache.org/jira/browse/HBASE-22933
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2
>
>
> The old implementation is a bit strange, the isStuck method is like this:
> {code}
> public boolean isStuck() {
> return isInState(State.FAILED_OPEN) && getProcedure() != null;
> }
> {code}
> It can only return true when there are ongoing procedures. But if we have a
> procedure, then the procedure will try to reassign region. Scheduling a new
> procedure does not make sense here, at least for branch-2.2+.
> I suggest we just remove the related code, since the default retry number for
> assigning a region is Integer.MAX_VALUE. And even if user set this to small
> value and finally the region is left in FAILED_OPEN state without a
> procedure, HBCK2 is used to deal with this, it is not necessary to deal it
> automatically.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22943) Various procedures should not cache log trace level
[
https://issues.apache.org/jira/browse/HBASE-22943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919149#comment-16919149
]
Hudson commented on HBASE-22943:
Results for branch master
[build #1374 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1374/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1374//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1374//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1374//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Various procedures should not cache log trace level
> ---
>
> Key: HBASE-22943
> URL: https://issues.apache.org/jira/browse/HBASE-22943
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
>
> several of the procedures have an idiom where they keep a member variable for
> if the log is at trace level or not, wrapped in a function so that it can be
> lazily looked up. This gives us an overhead per call of autoboxing and a
> function call, instead of just the function call from asking the logging
> system directly.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22939) SpaceQuotas- Bulkload from different hdfs failed when space quotas are turned on.
[
https://issues.apache.org/jira/browse/HBASE-22939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiran Wu updated HBASE-22939:
-
Attachment: HBASE-22939-v1.patch
> SpaceQuotas- Bulkload from different hdfs failed when space quotas are turned
> on.
> -
>
> Key: HBASE-22939
> URL: https://issues.apache.org/jira/browse/HBASE-22939
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Yiran Wu
>Assignee: Yiran Wu
>Priority: Major
> Attachments: HBASE-22939-v0.patch, HBASE-22939-v1.patch
>
>
> {code:java}
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.IOException):
> java.io.IOException: Wrong FS:
> hdfs://172.16.159.148:8020/tmp/bkldOutPut/fm1/327d2de5db4d4f0da667bfdf77105d4d,
> expected: hdfs://snake
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:433)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:132)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
> Caused by: java.lang.IllegalArgumentException: Wrong FS:
> hdfs://172.16.159.148:8020/tmp/bkldOutPut/fm1/327d2de5db4d4f0da667bfdf77105d4d,
> expected: hdfs://snake
> at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:665)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:214)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$27.doCall(DistributedFileSystem.java:1440)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem$27.doCall(DistributedFileSystem.java:1437)
> at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1437)
> at
> org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:442)
> at
> org.apache.hadoop.hbase.quotas.policies.AbstractViolationPolicyEnforcement.getFileSize(AbstractViolationPolicyEnforcement.java:95)
> at
> org.apache.hadoop.hbase.quotas.policies.MissingSnapshotViolationPolicyEnforcement.computeBulkLoadSize(MissingSnapshotViolationPolicyEnforcement.java:53)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.bulkLoadHFile(RSRpcServices.java:2407)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42004)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Reidddddd commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
Reidd commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319341692
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
Review comment:
A thought, can `AsyncResult` be inside `DirScanPool` rather than
`CleanerChore`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] sunhelly commented on issue #551: HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky
sunhelly commented on issue #551: HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky URL: https://github.com/apache/hbase/pull/551#issuecomment-526428039 Thanks @infraio . > It still is flaky after I revert HBASE-22857? Yes, it throws NPE when we run testFlushMarkersWALFail. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477#issuecomment-526426546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 89 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 46 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 370 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 91 | master passed | | +1 | shadedjars | 286 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 279 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 277 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 63 | the patch passed | | +1 | javac | 63 | the patch passed | | +1 | checkstyle | 91 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 284 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 968 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 49 | the patch passed | | +1 | findbugs | 289 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18413 | hbase-server in the patch failed. | | -1 | asflicense | 31 | The patch generated 30 ASF License warnings. | | | | 22106 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.TestLocalHBaseCluster | | | hadoop.hbase.tool.TestCanaryTool | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | hadoop.hbase.quotas.TestSpaceQuotaIncrease | | | hadoop.hbase.TestSplitMerge | | | hadoop.hbase.client.TestAsyncMetaRegionLocator | | | hadoop.hbase.fs.TestBlockReorderMultiBlocks | | | hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks | | | hadoop.hbase.mob.TestMobWithByteBuffAllocator | | | hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureBackoff | | | hadoop.hbase.util.TestMiniClusterLoadEncoded | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.TestServerCrashProcedureStuck | | | hadoop.hbase.client.TestCIGetOperationTimeout | | | hadoop.hbase.client.TestSeparateClientZKCluster | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated | | | hadoop.hbase.client.TestInvalidMutationDurabilityException | | | hadoop.hbase.master.procedure.TestSplitWALProcedure | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | | hadoop.hbase.snapshot.TestRestoreSnapshotHelper | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | hadoop.hbase.client.TestRawAsyncScanCursor | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientError | | | hadoop.hbase.client.TestAsyncTableLocatePrefetch | | | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | hadoop.hbase.regionserver.wal.TestLogRolling | | | hadoop.hbase.master.TestDeadServer | | | hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedWithRecovery | | | hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas | | | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | hadoop.hbase.regionserver.TestSettingTimeoutOnBlockingPoint | | | hadoop.hbase.client.TestGetScanColumnsWithNewVersionBehavior | | | hadoop.hbase.master.TestMetaShutdownHandler | | | hadoop.hbase.coprocessor.TestWALObserver | | | hadoop.hbase.client.TestAlwaysSetScannerId | | | hadoop.hbase.client.TestMultipleTimestamps | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestScannersFromClientSide2 | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.regionserver.TestScannerWithCorruptHFile | | | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver | | | hadoop.hbase.regionserver.TestHRegionOnCluster | |
[GitHub] [hbase] infraio commented on issue #551: HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky
infraio commented on issue #551: HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky URL: https://github.com/apache/hbase/pull/551#issuecomment-526424023 It still is flaky after I revert HBASE-22857? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent … URL: https://github.com/apache/hbase/pull/520#issuecomment-526422125 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 360 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 34 | master passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 67 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 332 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1021 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 77 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 103 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3217 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/520 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 24cecd8cdb25 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/26/testReport/ | | Max. process+thread count | 260 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22034) Backport HBASE-21401 and HBASE-22032 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-22034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919093#comment-16919093 ] Hudson commented on HBASE-22034: SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #124 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.5/124/]) PHOENIX-5455 - IndexedKeyValue creation fails after HBASE-22034 (s.kadam: rev df3cc54fb5ba4836a61983de9b607ec6b5e08cca) * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/wal/IndexedKeyValue.java * (edit) phoenix-core/src/test/java/org/apache/hadoop/hbase/regionserver/wal/IndexedKeyValueTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/wal/KeyValueCodec.java * (edit) phoenix-core/src/test/java/org/apache/hadoop/hbase/regionserver/wal/ReadWriteKeyValuesWithCodecTest.java > Backport HBASE-21401 and HBASE-22032 to branch-1 > > > Key: HBASE-22034 > URL: https://issues.apache.org/jira/browse/HBASE-22034 > Project: HBase > Issue Type: Improvement >Reporter: Geoffrey Jacoby >Assignee: Andrew Purtell >Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22034-branch-1.patch, HBASE-22034-branch-1.patch > > > Branch-2 and master have good validation checks when constructing KeyValues. > We should also have them on branch-1. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp URL: https://github.com/apache/hbase/pull/510#issuecomment-526421157 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 77 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 358 | master passed | | +1 | compile | 113 | master passed | | +1 | checkstyle | 152 | master passed | | +1 | shadedjars | 374 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 81 | master passed | | 0 | spotbugs | 316 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 400 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for patch | | +1 | mvninstall | 467 | the patch passed | | +1 | compile | 111 | the patch passed | | +1 | javac | 111 | the patch passed | | +1 | checkstyle | 142 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 358 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1383 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 81 | the patch passed | | +1 | findbugs | 428 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 124 | hbase-client in the patch passed. | | -1 | unit | 17023 | hbase-server in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 22347 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi3 | | | hadoop.hbase.quotas.TestSpaceQuotaRemoval | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/36/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/510 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a0fefa90b0fe 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/36/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/36/testReport/ | | Max. process+thread count | 4872 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/36/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #550: HBASE-22933 Do not need to kick reassign for rs group change any more
Apache9 merged pull request #550: HBASE-22933 Do not need to kick reassign for rs group change any more URL: https://github.com/apache/hbase/pull/550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-526417822 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 2 | No case conflicting files found. | | 0 | shelldocs | 2 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 38 | Maven dependency ordering for branch | | +1 | mvninstall | 340 | master passed | | +1 | compile | 184 | master passed | | +1 | checkstyle | 145 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 190 | master passed | | 0 | spotbugs | 29 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 29 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 294 | the patch passed | | +1 | compile | 175 | the patch passed | | +1 | javac | 175 | the patch passed | | +1 | checkstyle | 142 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 267 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 958 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 206 | the patch passed | | 0 | findbugs | 31 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 13543 | root in the patch failed. | | +1 | asflicense | 91 | The patch does not generate ASF License warnings. | | | | 19192 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/61/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 83e101a8d2db 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/61/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/61/testReport/ | | Max. process+thread count | 5501 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/61/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
apurtell commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319325332
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
+
+ // Step.3: Start to traverse and delete the sub-directories.
+ if (subDirs.isEmpty()) {
+// If no sub-directories, then just
[GitHub] [hbase] apurtell commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
apurtell commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319325225
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
+
+ // Step.3: Start to traverse and delete the sub-directories.
+ if (subDirs.isEmpty()) {
+// If no sub-directories, then just
[GitHub] [hbase] apurtell commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
apurtell commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319325384
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
+
+ // Step.3: Start to traverse and delete the sub-directories.
+ if (subDirs.isEmpty()) {
+// If no sub-directories, then just
[GitHub] [hbase] apurtell commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
apurtell commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319325060
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
Review comment:
notifyAll?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #549: HBASE-22912 [Backport] HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
apurtell commented on a change in pull request #549: HBASE-22912 [Backport]
HBASE-22867 to branch-1 to avoid ForkJoinPool to spawn thousands of threads
URL: https://github.com/apache/hbase/pull/549#discussion_r319325371
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##
@@ -322,140 +330,154 @@ public boolean getEnabled() {
T act() throws IOException;
}
- /**
- * Attemps to clean up a directory, its subdirectories, and files. Return
value is true if
- * everything was deleted. false on partial / total failures.
- */
- private final class CleanerTask extends RecursiveTask {
-private static final long serialVersionUID = -1584635903138015418L;
-private final Path dir;
-private final boolean root;
+ private interface Callback {
+void run(boolean val);
+ }
-CleanerTask(final FileStatus dir, final boolean root) {
- this(dir.getPath(), root);
+ private final class AsyncResult {
+
+private Callback callback;
+private boolean result;
+private boolean resultSet = false;
+
+AsyncResult(Callback callback) {
+ this.callback = callback;
}
-CleanerTask(final Path dir, final boolean root) {
- this.dir = dir;
- this.root = root;
+AsyncResult() {
}
-@Override
-protected Boolean compute() {
- LOG.trace("Cleaning under " + dir);
- List subDirs;
- List tmpFiles;
- final List files;
- try {
-// if dir doesn't exist, we'll get null back for both of these
-// which will fall through to succeeding.
-subDirs = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isDirectory();
- }
-});
-if (subDirs == null) {
- subDirs = Collections.emptyList();
+void set(boolean result) {
+ synchronized (this) {
+this.result = result;
+if (callback != null) {
+ callback.run(result);
}
-tmpFiles = FSUtils.listStatusWithStatusFilter(fs, dir, new
FileStatusFilter() {
- @Override
- public boolean accept(FileStatus f) {
-return f.isFile();
- }
-});
-files = tmpFiles == null ? Collections.emptyList() :
tmpFiles;
- } catch (IOException ioe) {
-LOG.warn("failed to get FileStatus for contents of '" + dir + "'",
ioe);
-return false;
+// Mark the result set process finished and notify the waiting get
method.
+this.resultSet = true;
+this.notify();
}
+}
- boolean allFilesDeleted = true;
- if (!files.isEmpty()) {
-allFilesDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return checkAndDeleteFiles(files);
- }
-}, "files");
+synchronized boolean get() throws Exception {
+ while (!resultSet) {
+wait();
+ }
+ return result;
+}
+ }
+
+ /**
+ * Attempts to clean up a directory(its subdirectories, and files) in a
+ * {@link java.util.concurrent.ThreadPoolExecutor} concurrently. We can get
the final result by
+ * calling result.get().
+ */
+ private void traverseAndDelete(final Path dir, final boolean root, final
AsyncResult result) {
+try {
+ final Action curDirDeletion = new Action() {
+@Override
+public Boolean act() throws IOException {
+ return fs.delete(dir, false);
+}
+ };
+
+ // Step.1: List all files under the given directory.
+ List allPaths = Arrays.asList(fs.listStatus(dir));
+ final List subDirs = new ArrayList<>();
+ final List files = new ArrayList<>();
+ for (FileStatus status : allPaths) {
+if (status.isDirectory()) {
+ subDirs.add(status);
+} else if (status.isFile()) {
+ files.add(status);
+}
}
- boolean allSubdirsDeleted = true;
- if (!subDirs.isEmpty()) {
-final List tasks =
Lists.newArrayListWithCapacity(subDirs.size());
-for (FileStatus subdir : subDirs) {
- CleanerTask task = new CleanerTask(subdir, false);
- tasks.add(task);
- task.fork();
+ // Step.2: Try to delete all the deletable files.
+ final boolean allFilesDeleted = files.isEmpty() || deleteAction(new
Action() {
+@Override
+public Boolean act() throws IOException {
+ return checkAndDeleteFiles(files);
}
-allSubdirsDeleted = deleteAction(new Action() {
- @Override
- public Boolean act() throws IOException {
-return getCleanResult(tasks);
- }
-}, "subdirs");
+ }, "files", dir);
+
+ // Step.3: Start to traverse and delete the sub-directories.
+ if (subDirs.isEmpty()) {
+// If no sub-directories, then just
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-526414314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 357 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 47 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 334 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1028 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 52 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 487 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3492 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/139/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b860e1e0c926 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/139/testReport/ | | Max. process+thread count | 4468 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/139/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-526414062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 1 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for branch | | +1 | mvninstall | 354 | branch-2 passed | | +1 | compile | 141 | branch-2 passed | | +1 | checkstyle | 158 | branch-2 passed | | +1 | shadedjars | 324 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 84 | branch-2 passed | | 0 | spotbugs | 206 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 474 | branch-2 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 376 | the patch passed | | +1 | compile | 142 | the patch passed | | +1 | cc | 142 | the patch passed | | +1 | javac | 142 | the patch passed | | +1 | checkstyle | 158 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 316 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1116 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 133 | the patch passed | | +1 | javadoc | 84 | the patch passed | | -1 | findbugs | 247 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 46 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 226 | hbase-client in the patch passed. | | +1 | unit | 9547 | hbase-server in the patch passed. | | +1 | asflicense | 84 | The patch does not generate ASF License warnings. | | | | 14883 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List, CellScanner, String, String, String) makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:makes inefficient use of keySet iterator instead of entrySet iterator At ReplicationSink.java:[line 256] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux 2b0e2c11d02b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / 6ece958268 | | Default Java | 1.8.0_181 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/testReport/ | | Max. process+thread count | 4196 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/40/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #558: HBASE-22881 Fix non-daemon threads in hbase server implementation (#512)
Apache-HBase commented on issue #558: HBASE-22881 Fix non-daemon threads in hbase server implementation (#512) URL: https://github.com/apache/hbase/pull/558#issuecomment-526410750 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ branch-2.1 Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for branch | | +1 | mvninstall | 383 | branch-2.1 passed | | +1 | compile | 135 | branch-2.1 passed | | +1 | checkstyle | 185 | branch-2.1 passed | | +1 | shadedjars | 311 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 122 | branch-2.1 passed | | 0 | spotbugs | 96 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 417 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 358 | the patch passed | | +1 | compile | 159 | the patch passed | | +1 | javac | 159 | the patch passed | | +1 | checkstyle | 30 | The patch passed checkstyle in hbase-common | | +1 | checkstyle | 43 | The patch passed checkstyle in hbase-client | | -1 | checkstyle | 102 | hbase-server: The patch generated 2 new + 166 unchanged - 7 fixed = 168 total (was 173) | | +1 | checkstyle | 30 | hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 302 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1520 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 123 | the patch passed | | +1 | findbugs | 468 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 189 | hbase-common in the patch passed. | | +1 | unit | 224 | hbase-client in the patch passed. | | +1 | unit | 8690 | hbase-server in the patch passed. | | +1 | unit | 166 | hbase-thrift in the patch passed. | | +1 | asflicense | 120 | The patch does not generate ASF License warnings. | | | | 14675 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-558/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/558 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 644c2e8df254 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-558/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 3b6f6b623d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-558/2/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-558/2/testReport/ | | Max. process+thread count | 5005 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-server hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-558/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #547: HBASE-22899 logging improvements for snapshot operations w/large manifests
Apache-HBase commented on issue #547: HBASE-22899 logging improvements for snapshot operations w/large manifests URL: https://github.com/apache/hbase/pull/547#issuecomment-526405285 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 75 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 411 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 89 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | master passed | | 0 | spotbugs | 279 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 275 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 89 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 311 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1046 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 36 | the patch passed | | +1 | findbugs | 282 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 14119 | hbase-server in the patch passed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 17961 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/547 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3118f2e2914e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/testReport/ | | Max. process+thread count | 5155 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-526404349 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 65 | Maven dependency ordering for branch | | +1 | mvninstall | 314 | master passed | | +1 | compile | 105 | master passed | | +1 | checkstyle | 117 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 79 | master passed | | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 352 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 304 | the patch passed | | +1 | compile | 109 | the patch passed | | +1 | javac | 109 | the patch passed | | -1 | checkstyle | 76 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 282 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 939 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 76 | the patch passed | | -1 | findbugs | 56 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 182 | hbase-common in the patch passed. | | +1 | unit | 10049 | hbase-server in the patch passed. | | +1 | unit | 305 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 77 | The patch does not generate ASF License warnings. | | | | 14565 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/89/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ea7de922e9de 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/89/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/89/artifact/out/new-findbugs-hbase-common.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/89/testReport/ | | Max. process+thread count | 4665 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/89/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #551: HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky
Apache-HBase commented on issue #551: HBASE-22896 TestHRegion.testFlushMarkersWALFail is flaky URL: https://github.com/apache/hbase/pull/551#issuecomment-526404237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 117 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 407 | master passed | | +1 | compile | 65 | master passed | | +1 | checkstyle | 92 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 41 | master passed | | 0 | spotbugs | 279 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 277 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 342 | the patch passed | | +1 | compile | 60 | the patch passed | | +1 | javac | 60 | the patch passed | | +1 | checkstyle | 92 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 302 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1059 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 281 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14128 | hbase-server in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 18051 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/551 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9eccbfdff1e6 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-551/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/testReport/ | | Max. process+thread count | 4706 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-551/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-526404308 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 35 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 321 | master passed | | +1 | compile | 85 | master passed | | +1 | checkstyle | 111 | master passed | | +1 | shadedjars | 282 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 60 | master passed | | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 325 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 314 | the patch passed | | +1 | compile | 84 | the patch passed | | +1 | javac | 84 | the patch passed | | +1 | checkstyle | 133 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 355 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1159 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 66 | the patch passed | | +1 | findbugs | 381 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 117 | hbase-client in the patch passed. | | +1 | unit | 9963 | hbase-server in the patch passed. | | +1 | asflicense | 52 | The patch does not generate ASF License warnings. | | | | 14370 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/144/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0fb2de274066 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/144/testReport/ | | Max. process+thread count | 4870 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/144/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #546: HBASE-22928 ScanMetrics counter update may not happen in case of exception in TableRecordReaderImpl
Apache-HBase commented on issue #546: HBASE-22928 ScanMetrics counter update may not happen in case of exception in TableRecordReaderImpl URL: https://github.com/apache/hbase/pull/546#issuecomment-526404316 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 386 | master passed | | +1 | compile | 31 | master passed | | +1 | checkstyle | 25 | master passed | | +1 | shadedjars | 346 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 61 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 59 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 378 | the patch passed | | +1 | compile | 30 | the patch passed | | +1 | javac | 30 | the patch passed | | +1 | checkstyle | 20 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 337 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1202 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 65 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1227 | hbase-mapreduce in the patch failed. | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 4661 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/546 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8b39a855cf12 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/testReport/ | | Max. process+thread count | 5441 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #538: HBASE-22905 Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
Apache-HBase commented on issue #538: HBASE-22905 Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest URL: https://github.com/apache/hbase/pull/538#issuecomment-526402701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 415 | master passed | | +1 | compile | 28 | master passed | | +1 | checkstyle | 37 | master passed | | +1 | shadedjars | 345 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 84 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 82 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 323 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 32 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 314 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1094 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 22 | the patch passed | | +1 | findbugs | 76 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3405 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-538/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/538 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dad9bd298ea1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-538/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-538/8/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-538/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shahrs87 opened a new pull request #565: [HBASE-22874] Canary should not be IA.Public
shahrs87 opened a new pull request #565: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #541: HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId
Apache-HBase commented on issue #541: HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId URL: https://github.com/apache/hbase/pull/541#issuecomment-526402049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 32 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 357 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 33 | master passed | | +1 | shadedjars | 305 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 76 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 74 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 337 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | +1 | checkstyle | 34 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 303 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1249 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3421 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/541 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e30f2ddeb9f8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/testReport/ | | Max. process+thread count | 263 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #544: HBASE-22917 Proc-WAL roll fails saying someone else has already created log
Apache-HBase commented on issue #544: HBASE-22917 Proc-WAL roll fails saying someone else has already created log URL: https://github.com/apache/hbase/pull/544#issuecomment-526400985 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 52 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 417 | master passed | | +1 | compile | 21 | master passed | | +1 | checkstyle | 18 | master passed | | +1 | shadedjars | 350 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 44 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 386 | the patch passed | | +1 | compile | 21 | the patch passed | | +1 | javac | 21 | the patch passed | | -1 | checkstyle | 17 | hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 346 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1192 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 17 | the patch passed | | +1 | findbugs | 47 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 238 | hbase-procedure in the patch passed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 3673 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/544 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9290041b03f7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-544/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/6/artifact/out/diff-checkstyle-hbase-procedure.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/6/testReport/ | | Max. process+thread count | 313 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll
Apache-HBase commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll URL: https://github.com/apache/hbase/pull/554#issuecomment-526400153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 446 | master passed | | +1 | compile | 29 | master passed | | +1 | checkstyle | 21 | master passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 18 | master passed | | 0 | spotbugs | 51 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 48 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 19 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 302 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1044 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 16 | the patch passed | | +1 | findbugs | 61 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1115 | hbase-mapreduce in the patch failed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 4240 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshot | | | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/554 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1aff48fd2c04 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/testReport/ | | Max. process+thread count | 5253 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #550: HBASE-22933 Do not need to kick reassign for rs group change any more
Apache-HBase commented on issue #550: HBASE-22933 Do not need to kick reassign for rs group change any more URL: https://github.com/apache/hbase/pull/550#issuecomment-526396926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 358 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 47 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 300 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1027 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 19 | the patch passed | | +1 | findbugs | 52 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 439 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3447 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-550/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/550 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cdfd3c2e8617 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-550/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-550/5/testReport/ | | Max. process+thread count | 4038 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-550/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/479#issuecomment-526396443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 372 | master passed | | +1 | compile | 83 | master passed | | +1 | checkstyle | 129 | master passed | | +1 | shadedjars | 340 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 60 | master passed | | 0 | spotbugs | 287 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 338 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 346 | the patch passed | | +1 | compile | 93 | the patch passed | | +1 | javac | 93 | the patch passed | | +1 | checkstyle | 31 | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | +1 | checkstyle | 87 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 311 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1037 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 63 | the patch passed | | +1 | findbugs | 310 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 188 | hbase-common in the patch passed. | | -1 | unit | 9629 | hbase-server in the patch failed. | | +1 | asflicense | 54 | The patch does not generate ASF License warnings. | | | | 13986 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/61/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/479 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2332468167da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh | | git revision | master / 56fd3e9007 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/61/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/61/testReport/ | | Max. process+thread count | 4662 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/61/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22881) Fix non-daemon threads in hbase server implementation
[ https://issues.apache.org/jira/browse/HBASE-22881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22881: -- Fix Version/s: 2.1.7 > Fix non-daemon threads in hbase server implementation > - > > Key: HBASE-22881 > URL: https://issues.apache.org/jira/browse/HBASE-22881 > Project: HBase > Issue Type: Bug > Components: master >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > "pool-8-thread-3" #7252 prio=5 os_prio=0 tid=0x7f91040044c0 nid=0xd71e > waiting on condition [0x7f8f4d209000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-8-thread-2" #7251 prio=5 os_prio=0 tid=0x7f910c010be0 nid=0xd71d > waiting on condition [0x7f8f4daab000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-8-thread-1" #7250 prio=5 os_prio=0 tid=0x7f9119d0 nid=0xd71c > waiting on condition [0x7f8f4da6a000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-5-thread-3" #7248 prio=5 os_prio=0 tid=0x7f9238005ad0 nid=0xd71a > waiting on condition [0x7f8f4cb65000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0ec51e0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22881) Fix non-daemon threads in hbase server implementation
[ https://issues.apache.org/jira/browse/HBASE-22881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919032#comment-16919032 ] stack commented on HBASE-22881: --- Merged the 2.1 PR. Thank you [~Xiaolin Ha] for the patch and for getting it into all branches. > Fix non-daemon threads in hbase server implementation > - > > Key: HBASE-22881 > URL: https://issues.apache.org/jira/browse/HBASE-22881 > Project: HBase > Issue Type: Bug > Components: master >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > "pool-8-thread-3" #7252 prio=5 os_prio=0 tid=0x7f91040044c0 nid=0xd71e > waiting on condition [0x7f8f4d209000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-8-thread-2" #7251 prio=5 os_prio=0 tid=0x7f910c010be0 nid=0xd71d > waiting on condition [0x7f8f4daab000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-8-thread-1" #7250 prio=5 os_prio=0 tid=0x7f9119d0 nid=0xd71c > waiting on condition [0x7f8f4da6a000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0e49ed0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) >Locked ownable synchronizers: > - None > "pool-5-thread-3" #7248 prio=5 os_prio=0 tid=0x7f9238005ad0 nid=0xd71a > waiting on condition [0x7f8f4cb65000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x0005c0ec51e0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] saintstack merged pull request #558: HBASE-22881 Fix non-daemon threads in hbase server implementation (#512)
saintstack merged pull request #558: HBASE-22881 Fix non-daemon threads in hbase server implementation (#512) URL: https://github.com/apache/hbase/pull/558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory URL: https://github.com/apache/hbase/pull/509#issuecomment-526393905 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 56 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 413 | master passed | | +1 | compile | 72 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 349 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 46 | master passed | | 0 | spotbugs | 279 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 276 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 58 | the patch passed | | +1 | javac | 58 | the patch passed | | +1 | checkstyle | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 285 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1005 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 38 | the patch passed | | +1 | findbugs | 256 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9539 | hbase-server in the patch passed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 13302 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/34/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/509 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3558ac521f02 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/34/testReport/ | | Max. process+thread count | 4477 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/34/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22949) [HBCK2] Add lang3 as explicit dependency
[ https://issues.apache.org/jira/browse/HBASE-22949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-22949. --- Fix Version/s: hbck2-1.0.0 Resolution: Fixed Pushed. > [HBCK2] Add lang3 as explicit dependency > > > Key: HBASE-22949 > URL: https://issues.apache.org/jira/browse/HBASE-22949 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: hbck2-1.0.0 > > > Failed to find lang3 StringUtils compiling against branch-2. Add as explicity > dependency. Used parsing version strings locally. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] saintstack merged pull request #19: HBASE-22949 [HBCK2] Add lang3 as explicit dependency
saintstack merged pull request #19: HBASE-22949 [HBCK2] Add lang3 as explicit dependency URL: https://github.com/apache/hbase-operator-tools/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #553: HBASE-22939 SpaceQuotas- Bulkload from different hdfs failed when space quotas are turned on.
Apache-HBase commented on issue #553: HBASE-22939 SpaceQuotas- Bulkload from different hdfs failed when space quotas are turned on. URL: https://github.com/apache/hbase/pull/553#issuecomment-526389291 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 396 | master passed | | +1 | compile | 58 | master passed | | +1 | checkstyle | 103 | master passed | | +1 | shadedjars | 351 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 44 | master passed | | 0 | spotbugs | 281 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 278 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 387 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | +1 | checkstyle | 100 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 333 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1161 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 277 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9551 | hbase-server in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 13658 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/553 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 636e6e3759b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-553/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/2/testReport/ | | Max. process+thread count | 4405 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-553/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #559: HBASE-22944 TableNotFoundException: hbase:quota is thrown when region server is restarted.
Apache-HBase commented on issue #559: HBASE-22944 TableNotFoundException: hbase:quota is thrown when region server is restarted. URL: https://github.com/apache/hbase/pull/559#issuecomment-526389142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 338 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 80 | master passed | | +1 | shadedjars | 282 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 243 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 309 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 281 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 975 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 287 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 10300 | hbase-server in the patch failed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 13850 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/559 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 11d992ee4e86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-559/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/4/testReport/ | | Max. process+thread count | 4674 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-559/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #548: HBASE-22930 Set unique name to longCompactions/shortCompactions threads
Apache-HBase commented on issue #548: HBASE-22930 Set unique name to longCompactions/shortCompactions threads URL: https://github.com/apache/hbase/pull/548#issuecomment-526388842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 327 | master passed | | +1 | compile | 56 | master passed | | +1 | checkstyle | 77 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 239 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 237 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 925 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 242 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9561 | hbase-server in the patch passed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 12920 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/548 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7aa3d957947d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/4/testReport/ | | Max. process+thread count | 5043 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #561: HBASE-22946 Fix TableNotFound when grant/revoke if AccessController is not loaded
Apache-HBase commented on issue #561: HBASE-22946 Fix TableNotFound when grant/revoke if AccessController is not loaded URL: https://github.com/apache/hbase/pull/561#issuecomment-526388249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 112 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 577 | master passed | | +1 | compile | 132 | master passed | | +1 | checkstyle | 111 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 272 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 269 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 65 | the patch passed | | +1 | javac | 65 | the patch passed | | -1 | checkstyle | 90 | hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 301 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1035 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 292 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9620 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 13768 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-561/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/561 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c9d6c760ee2d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-561/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-561/2/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-561/2/testReport/ | | Max. process+thread count | 4536 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-561/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #560: HBASE-22945 Show quota infos in master UI
Apache-HBase commented on issue #560: HBASE-22945 Show quota infos in master UI URL: https://github.com/apache/hbase/pull/560#issuecomment-526386292 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 37 | Maven dependency ordering for branch | | +1 | mvninstall | 344 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 60 | master passed | | 0 | spotbugs | 238 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 301 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for patch | | +1 | mvninstall | 294 | the patch passed | | +1 | compile | 83 | the patch passed | | +1 | javac | 83 | the patch passed | | +1 | checkstyle | 109 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 926 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 59 | the patch passed | | +1 | findbugs | 314 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 114 | hbase-client in the patch passed. | | +1 | unit | 9291 | hbase-server in the patch passed. | | +1 | asflicense | 60 | The patch does not generate ASF License warnings. | | | | 13199 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-560/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/560 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 935b5073c8ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-560/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-560/2/testReport/ | | Max. process+thread count | 4436 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-560/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent … URL: https://github.com/apache/hbase/pull/520#issuecomment-526384141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 79 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 389 | master passed | | +1 | compile | 34 | master passed | | +1 | checkstyle | 41 | master passed | | +1 | shadedjars | 380 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 29 | master passed | | 0 | spotbugs | 84 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 81 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 421 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 38 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 392 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1413 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 27 | the patch passed | | +1 | findbugs | 95 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 114 | hbase-client in the patch passed. | | +1 | asflicense | 16 | The patch does not generate ASF License warnings. | | | | 4090 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/520 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 03bc7528f8bd 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/25/testReport/ | | Max. process+thread count | 264 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[
https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919004#comment-16919004
]
HBase QA commented on HBASE-20688:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 6m
26s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 6m
10s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/562 |
| JIRA Issue | HBASE-20688 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux ec7bce43211b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-562/out/precommit/personality/provided.sh
|
| git revision | master / f6a4c66d13 |
| refguide |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/artifact/out/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/artifact/out/patch-site/book.html
|
| Max. process+thread count | 86 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Refguide has "HBase Backup" section and a chapter named "Backup and Restore";
> neither refers to the other
> -
>
> Key: HBASE-20688
> URL: https://issues.apache.org/jira/browse/HBASE-20688
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Rabi Kumar K C
>Priority: Major
>
> The two backup sections are not connected or related. It'd be confusing to
> the user. Needs addressing.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #562: HBASE-20688
Apache-HBase commented on issue #562: HBASE-20688 URL: https://github.com/apache/hbase/pull/562#issuecomment-526383310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 1 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 357 | master passed | | 0 | refguide | 386 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 332 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 370 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 1609 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/562 | | JIRA Issue | HBASE-20688 | | Optional Tests | dupname asflicense refguide | | uname | Linux ec7bce43211b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-562/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/artifact/out/patch-site/book.html | | Max. process+thread count | 86 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919002#comment-16919002
]
HBase QA commented on HBASE-22893:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} https://github.com/apache/hbase/pull/552 does not apply to
master. Rebase required? Wrong Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| GITHUB PR | https://github.com/apache/hbase/pull/552 |
| JIRA Issue | HBASE-22893 |
| Console output |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-552/3/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22893.patch
>
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #552: HBASE-22893
Apache-HBase commented on issue #552: HBASE-22893 URL: https://github.com/apache/hbase/pull/552#issuecomment-526382951 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 7 | https://github.com/apache/hbase/pull/552 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/552 | | JIRA Issue | HBASE-22893 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-552/3/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…
Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na… URL: https://github.com/apache/hbase/pull/524#issuecomment-526374840 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 304 | branch-2.1 passed | | +1 | compile | 31 | branch-2.1 passed | | +1 | checkstyle | 19 | branch-2.1 passed | | +1 | shadedjars | 231 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | branch-2.1 passed | | 0 | spotbugs | 61 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 58 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | -1 | checkstyle | 18 | hbase-rest: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 254 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1170 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 55 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 322 | hbase-rest in the patch failed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 3267 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rest.TestNamespacesInstanceResource | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/16/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/524 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 910fb5a2fa41 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-524/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 3b6f6b623d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/16/artifact/out/diff-checkstyle-hbase-rest.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/16/artifact/out/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/16/testReport/ | | Max. process+thread count | 1990 (vs. ulimit of 1) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/16/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22943) Various procedures should not cache log trace level
[ https://issues.apache.org/jira/browse/HBASE-22943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918971#comment-16918971 ] Sean Busbey commented on HBASE-22943: - this is still open because I need to do a branches-2 specific addendum and a branches-1 backport. > Various procedures should not cache log trace level > --- > > Key: HBASE-22943 > URL: https://issues.apache.org/jira/browse/HBASE-22943 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > > several of the procedures have an idiom where they keep a member variable for > if the log is at trace level or not, wrapped in a function so that it can be > lazily looked up. This gives us an overhead per call of autoboxing and a > function call, instead of just the function call from asking the logging > system directly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] saintstack commented on issue #562: HBASE-20688
saintstack commented on issue #562: HBASE-20688 URL: https://github.com/apache/hbase/pull/562#issuecomment-526363194 Oh, I see what @HorizonNet is on about now. Yeah, please fix as he requests. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22941) MetaTableAccessor.getMergeRegions() returns parent regions in random order
[ https://issues.apache.org/jira/browse/HBASE-22941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-22941. --- Fix Version/s: 2.2.2 2.1.7 2.3.0 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Thanks for the fix [~stoty] Took a while getting it in back to 2.1. Nice one. > MetaTableAccessor.getMergeRegions() returns parent regions in random order > -- > > Key: HBASE-22941 > URL: https://issues.apache.org/jira/browse/HBASE-22941 > Project: HBase > Issue Type: Bug >Affects Versions: master >Reporter: István Tóth >Assignee: István Tóth >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > The multi-region merge patch has changed the behaviour of the > MetaTableAccessor.getMergeRegions() method. Earlier, the parent regions were > returned in the same order that they were passed to mergeRegion(). > The patch has changed this to return the regions in random order. To be more > precise, the parent regions are stored in random order in Meta. > I propose storing and returning the parent regions in ascending order. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-526360076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 89 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 337 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 25 | master passed | | 0 | spotbugs | 64 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 62 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 313 | the patch passed | | +1 | compile | 29 | the patch passed | | +1 | javac | 29 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 283 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 968 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 639 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3559 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/138/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 566d4fac5bc8 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / f6a4c66d13 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/138/testReport/ | | Max. process+thread count | 4478 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/138/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey closed pull request #557: HBASE-22943 Various procedures should not cache log trace level
busbey closed pull request #557: HBASE-22943 Various procedures should not cache log trace level URL: https://github.com/apache/hbase/pull/557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #538: HBASE-22905 Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest
Apache-HBase commented on issue #538: HBASE-22905 Avoid temp ByteBuffer allocation in BlockingRpcConnection#writeRequest URL: https://github.com/apache/hbase/pull/538#issuecomment-526346958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 410 | master passed | | +1 | compile | 28 | master passed | | +1 | checkstyle | 37 | master passed | | +1 | shadedjars | 340 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 28 | master passed | | 0 | spotbugs | 81 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 77 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 370 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | +1 | checkstyle | 37 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 337 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1164 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 26 | the patch passed | | +1 | findbugs | 83 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 115 | hbase-client in the patch passed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 3565 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-538/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/538 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9f37cd566cf6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-538/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-538/7/testReport/ | | Max. process+thread count | 289 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-538/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #541: HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId
Apache-HBase commented on issue #541: HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId URL: https://github.com/apache/hbase/pull/541#issuecomment-526344979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 373 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 34 | master passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | master passed | | 0 | spotbugs | 78 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 76 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 341 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 33 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1038 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 22 | the patch passed | | +1 | findbugs | 83 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3296 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/541 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8c762a06e6e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/testReport/ | | Max. process+thread count | 262 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #546: HBASE-22928 ScanMetrics counter update may not happen in case of exception in TableRecordReaderImpl
Apache-HBase commented on issue #546: HBASE-22928 ScanMetrics counter update may not happen in case of exception in TableRecordReaderImpl URL: https://github.com/apache/hbase/pull/546#issuecomment-526344500 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 34 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 363 | master passed | | +1 | compile | 34 | master passed | | +1 | checkstyle | 25 | master passed | | +1 | shadedjars | 305 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 58 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 55 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 19 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 305 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1027 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 68 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1051 | hbase-mapreduce in the patch failed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 4101 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/546 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c86f95a7766a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/testReport/ | | Max. process+thread count | 5211 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #544: HBASE-22917 Proc-WAL roll fails saying someone else has already created log
Apache-HBase commented on issue #544: HBASE-22917 Proc-WAL roll fails saying someone else has already created log URL: https://github.com/apache/hbase/pull/544#issuecomment-526340391 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 90 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 360 | master passed | | +1 | compile | 17 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 316 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 42 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 40 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 345 | the patch passed | | +1 | compile | 19 | the patch passed | | +1 | javac | 19 | the patch passed | | -1 | checkstyle | 17 | hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 305 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1043 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 15 | the patch passed | | +1 | findbugs | 42 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 226 | hbase-procedure in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3286 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/544 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ad927a884387 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-544/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/5/artifact/out/diff-checkstyle-hbase-procedure.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/5/testReport/ | | Max. process+thread count | 282 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-544/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll
Apache-HBase commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll URL: https://github.com/apache/hbase/pull/554#issuecomment-526338534 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 47 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 331 | master passed | | +1 | compile | 27 | master passed | | +1 | checkstyle | 23 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 50 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 20 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 275 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 914 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 55 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1094 | hbase-mapreduce in the patch failed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 3850 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/554 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 69ee9677daf8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/testReport/ | | Max. process+thread count | 5384 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #550: HBASE-22933 Do not need to kick reassign for rs group change any more
Apache-HBase commented on issue #550: HBASE-22933 Do not need to kick reassign for rs group change any more URL: https://github.com/apache/hbase/pull/550#issuecomment-526338244 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 391 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 277 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 51 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 984 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 25 | the patch passed | | +1 | findbugs | 65 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 303 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3294 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-550/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/550 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 897a9e17f28d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-550/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-550/4/testReport/ | | Max. process+thread count | 4500 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-550/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] asf-ci commented on issue #19: HBASE-22949 [HBCK2] Add lang3 as explicit dependency
asf-ci commented on issue #19: HBASE-22949 [HBCK2] Add lang3 as explicit dependency URL: https://github.com/apache/hbase-operator-tools/pull/19#issuecomment-526333780 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/69/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22950) Expose metrics for RegionNormalizer
Nick Dimiduk created HBASE-22950: Summary: Expose metrics for RegionNormalizer Key: HBASE-22950 URL: https://issues.apache.org/jira/browse/HBASE-22950 Project: HBase Issue Type: Improvement Components: master Reporter: Nick Dimiduk We introduced another anti-entropy service to the Master over on HBASE-13103, called the region normalizer. We don't appear to have any metrics instrumentation for it. Let's sort out what's needed to operate this thing, know it's running healthy. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] saintstack commented on issue #556: HBASE-22941 merge operation returns parent regions in random order
saintstack commented on issue #556: HBASE-22941 merge operation returns parent regions in random order URL: https://github.com/apache/hbase/pull/556#issuecomment-526328367 Fixed checkstyle complaint in a follow-on addendum. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack merged pull request #556: HBASE-22941 merge operation returns parent regions in random order
saintstack merged pull request #556: HBASE-22941 merge operation returns parent regions in random order URL: https://github.com/apache/hbase/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent … URL: https://github.com/apache/hbase/pull/520#issuecomment-526326933 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 378 | master passed | | +1 | compile | 27 | master passed | | +1 | checkstyle | 37 | master passed | | +1 | shadedjars | 336 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 78 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 76 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 33 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 306 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1044 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 25 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 117 | hbase-client in the patch passed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 3324 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/520 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b3e73abecf8a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh | | git revision | master / 56980fb097 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/24/testReport/ | | Max. process+thread count | 289 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[
https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918904#comment-16918904
]
HBase QA commented on HBASE-20688:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
14s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 6m
22s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/562 |
| JIRA Issue | HBASE-20688 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux d6954c262cff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-562/out/precommit/personality/provided.sh
|
| git revision | master / 83e77940c5 |
| refguide |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/artifact/out/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/artifact/out/patch-site/book.html
|
| Max. process+thread count | 86 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Refguide has "HBase Backup" section and a chapter named "Backup and Restore";
> neither refers to the other
> -
>
> Key: HBASE-20688
> URL: https://issues.apache.org/jira/browse/HBASE-20688
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Rabi Kumar K C
>Priority: Major
>
> The two backup sections are not connected or related. It'd be confusing to
> the user. Needs addressing.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #556: HBASE-22941 merge operation returns parent regions in random order
Apache-HBase commented on issue #556: HBASE-22941 merge operation returns parent regions in random order URL: https://github.com/apache/hbase/pull/556#issuecomment-526326498 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 378 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 78 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 38 | master passed | | 0 | spotbugs | 234 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 232 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 54 | the patch passed | | +1 | javac | 54 | the patch passed | | -1 | checkstyle | 76 | hbase-server: The patch generated 1 new + 20 unchanged - 0 fixed = 21 total (was 20) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 932 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 233 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9463 | hbase-server in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 12853 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-556/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/556 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 04fe77053f9d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-556/out/precommit/personality/provided.sh | | git revision | master / 56980fb097 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-556/4/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-556/4/testReport/ | | Max. process+thread count | 4389 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-556/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #562: HBASE-20688
Apache-HBase commented on issue #562: HBASE-20688 URL: https://github.com/apache/hbase/pull/562#issuecomment-526326025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 126 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 585 | master passed | | 0 | refguide | 434 | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 332 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | 0 | refguide | 382 | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1972 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/562 | | JIRA Issue | HBASE-20688 | | Optional Tests | dupname asflicense refguide | | uname | Linux d6954c262cff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-562/out/precommit/personality/provided.sh | | git revision | master / 83e77940c5 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/artifact/out/patch-site/book.html | | Max. process+thread count | 86 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-562/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack opened a new pull request #19: HBASE-22949 [HBCK2] Add lang3 as explicit dependency
saintstack opened a new pull request #19: HBASE-22949 [HBCK2] Add lang3 as explicit dependency URL: https://github.com/apache/hbase-operator-tools/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
